[Buildbot-commits] [Buildbot] #1892: SetPropertiesFromEnv should be case-insensitive on Windows

[Buildbot]

#1892: SetPropertiesFromEnv should be case-insensitive on Windows
------------------------+------------------------
Reporter:  dabrahams    |       Owner:
    Type:  defect       |      Status:  new
Priority:  major        |   Milestone:  undecided
 Version:  0.8.3p1      |  Resolution:
Keywords:  windows git  |
------------------------+------------------------

Comment (by dabrahams):

 Replying to [comment:7 dustin]:
 > Replying to [comment:6 dabrahams]:
 > > > In addition, I wonder if windows actually supports case-sensitivity
 in variable names,
 > >
 > > It does, in the sense that if you ask it to list the environment
 variables, it will show them to you with the case you originally specified
 them with.  It does not, in the sense that you can't have two separate
 variables called "Foo" and "foo".
 >
 > This is called case-preserving but case-insensitive, and it's the way
 NTFS filenames work, for example.

 Right.  And HFS+, by default.

 > > > and cmd.exe just coerces everything to uppercase.
 > >
 > > cmd.exe does not coerce.
 >
 > We don't actually know what is going on - the questions

 I don't mean to be blunt or uncooperative, but IMO the answers to these
 questions are irrelevant. Still, I'll try to provide them anyway.

 > in comment 2

 Do you want me to undo my workarounds first?  And do you want the log on
 the slave or master or...?

 > and comment 3 are unanswered.

 The output has all-uppercase variable names.  But again, that's irrelevant
 IMO.  I can do {{{os.environ['TMP']}}} or {{{os.environ['Tmp']}}} in
 python and I'll get the same result.  That is, Python has to pick some
 representation for the case of variable names, and it chooses
 ALL_UPPERCASE for that, but when I ask for a particular variable name, it
 does the right thing regardless of case.  BB does not behave similarly,
 and it should.

 > Also, we need to know how you've installed Buildbot - msys? cygwin?
 native Python?  Does it behave the same way for all three?

 Native Python, but again IMO the answer to whether it behaves the same way
 is irrelevant, and would take an inordinate effort to discover for all
 three.

 > In general, Buildbot is not going to try to un-hork windows horked-ness.
 That way lies madness.

 If you think the idea case-insensitive-but-case-preserving environment
 variables is essentially horked, then I lose (along with everyone else who
 needs to run tests on windows among other platforms) and I'll stop wasting
 everyone's time now.  Is that your position?

 > I'm happy to add hints to the documentation, but they should explain,
 rather than direct, and should be a comprehensive description of what's
 going wrong.

 No, that way lies madness.  This should "just work." There's no reason for
 it not to, and there's no reason to burden users with an explanation of
 why it doesn't, and how to work around the problem.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1892#comment:8>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation