[Buildbot-commits] [buildbot/buildbot] 5d0b30: expand fakedb support for SourceStamp-related rows

noreply at github.com noreply at github.com
Sun Mar 20 01:19:09 UTC 2011


Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 5d0b30de3799032e91d31454dab2fb7dfe0651b0
    https://github.com/buildbot/buildbot/commit/5d0b30de3799032e91d31454dab2fb7dfe0651b0
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-03-19 (Sat, 19 Mar 2011)

Changed paths:
  M master/buildbot/schedulers/base.py
  M master/buildbot/test/fake/fakedb.py
  M master/buildbot/test/unit/test_schedulers_base.py
  M master/buildbot/test/unit/test_schedulers_triggerable.py
  M master/buildbot/test/unit/test_schedulers_trysched.py

Log Message:
-----------
expand fakedb support for SourceStamp-related rows

The existing fakedb support for SourceStamps was ad-hoc and did not test
that calls had appropriate arguments.  This made it easy to create
degenerate source stamp objects and test for them with assertBuildset,
but led to ambiguity in more sophisticated uses of fakedb.

This also fixes a bug in the base scheduler where createSourceStamp was
called with incorrect positional arguments.






More information about the Commits mailing list