[Buildbot-commits] [Buildbot] #1830: ER : Add a warning for logfiles if the log file does not exist or is not found

[Buildbot]

#1830: ER : Add a warning for logfiles if the log file does not exist or is not
found
------------------------+--------------------
Reporter:  darshie      |       Owner:
    Type:  enhancement  |      Status:  new
Priority:  major        |   Milestone:  0.8.4
 Version:  0.8.3        |  Resolution:
Keywords:               |
------------------------+--------------------
Changes (by dustin):

 * keywords:  shellCommand, logfiles =>
 * milestone:  undecided => 0.8.4


Old description:

> I've noticed that there is no warning in the logs if i try to read a log
> file from disk using logfiles.
>
> f.addStep(ShellCommand(
>                         command=["make", "test"],
>                         logfiles={"disk_log":
> "/slavebot/testbuild/test.log"}))
>
> In this case if the file cannot be found, an empty file called test.log
> will be created and added to the waterfall page.
>
> Would be useful to have a warning in the logs so is possible to know if
> the file exist or not, and troubleshoot why a log file is not displayed
> in the waterfall page, instead than just showing an empty file.
>
> Thanks

New description:

 I've noticed that there is no warning in the logs if i try to read a log
 file from disk using logfiles.

 {{{
 f.addStep(ShellCommand(
                         command=["make", "test"],
                         logfiles={"disk_log":
 "/slavebot/testbuild/test.log"}))
 }}}

 In this case if the file cannot be found, an empty file called test.log
 will be created and added to the waterfall page.

 Would be useful to have a warning in the logs so is possible to know if
 the file exist or not, and troubleshoot why a log file is not displayed in
 the waterfall page, instead than just showing an empty file.

 Thanks

--

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1830#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation