[Buildbot-commits] [Buildbot] #1853: Honour change filter in build details page (option)

[Buildbot]

#1853: Honour change filter in build details page (option)
------------------------+-----------------------
Reporter:  jollyroger   |      Owner:
    Type:  enhancement  |     Status:  new
Priority:  major        |  Milestone:  undecided
 Version:  0.8.3p1      |   Keywords:
------------------------+-----------------------
 When change filter is defined for scheduler the build status page should
 display details(blamelist, file changes) for the commit which triggered
 the build, not the whole list of changes between previously triggered
 build and the current one.

 '''Use case''': build performs tests on a database every time SQL file is
 changed in VCS. This is implemented via simple Scheduler scheduler and a
 change filter which checks wether SQL files are available in change.

 '''Steps to reproduce''': Master should include the following snippet:
 {{{
 import re
 def checkDBChanges(change):
     regexp = re.compile('.sql$)',re.IGNORECASE)

     for name in change.files:
         if regexp.search(name):
             return True
     return False

 c['schedulers'].append(Scheduler(name="dev_db", branch="trunk",
                                  treeStableTimer=0*60,
                                  fileIsImportant=checkDBChanges,
                                  builderNames=["dev_db"]))
 }}}

  1. Commit file `file1.sql` (revision 1).
  2. Commit file `file2.txt` (revision 2).
  3. Commit file `file3.sql` (revision 3).

 '''Given result''':

  1. Build is triggered. Build details page includes information about
 revision 1.
  2. Build is not triggered.
  3. Build is triggered. Build details page includes information about both
 revision 2 and 3.

 '''Expected result''':

  1. Build is triggered. Build details page includes information about
 revision 1.
  2. Build is not triggered.
  3. Build is triggered. Build details page includes information about
 revision 3.

 Perhaps this should be an option because there's a probability grater than
 zero that current behaviour will have it's use case.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1853>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation