[Buildbot-commits] [Buildbot] #2018: build mail breakage in 0.8.4p1

[Buildbot]

#2018: build mail breakage in 0.8.4p1
--------------------+--------------------
Reporter:  dberger  |       Owner:
    Type:  defect   |      Status:  new
Priority:  major    |   Milestone:  0.8.5
 Version:  0.8.4p1  |  Resolution:
Keywords:           |
--------------------+--------------------
Changes (by dustin):

 * milestone:  undecided => 0.8.5


Old description:

> the fix I mention in ticket 2017 moves the error further into the mail
> code.
>
> 2011-06-28 14:36:40-0700 [-] Exception caught notifying
> <buildbot.status.mail.MailNotifier instance at 0x029A9148> of
> buildFinished event
> 2011-06-28 14:36:40-0700 [-] Unhandled Error
>         Traceback (most recent call last):
>           File
> "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\build.py",
> line 288, in buildFinished
>             w.callback(self)
>           File
> "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line
> 361, in callback
>             self._startRunCallbacks(result)
>           File
> "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line
> 455, in _startRunCallbacks
>             self._runCallbacks()
>           File
> "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line
> 542, in _runCallbacks
>             current.result = callback(current.result, *args, **kw)
>         --- <exception caught here> ---
>           File
> "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\builder.py",
> line 541, in _buildFinished
>             w.buildFinished(name, s, results)
>           File
> "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\mail.py", line
> 410, in buildFinished
>             return self.buildMessage(name, [build], results)
>           File
> "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\mail.py", line
> 593, in buildMessage
>             results, builds, patches, logs)
>           File
> "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\mail.py", line
> 544, in createEmail
>             if len(builds == 1):
>         exceptions.TypeError: object of type 'bool' has no len()

New description:

 the fix I mention in #2017 moves the error further into the mail code.

 {{{
 2011-06-28 14:36:40-0700 [-] Exception caught notifying
 <buildbot.status.mail.MailNotifier instance at 0x029A9148> of
 buildFinished event
 2011-06-28 14:36:40-0700 [-] Unhandled Error
         Traceback (most recent call last):
           File
 "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\build.py", line
 288, in buildFinished
             w.callback(self)
           File
 "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line
 361, in callback
             self._startRunCallbacks(result)
           File
 "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line
 455, in _startRunCallbacks
             self._runCallbacks()
           File
 "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line
 542, in _runCallbacks
             current.result = callback(current.result, *args, **kw)
         --- <exception caught here> ---
           File
 "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\builder.py",
 line 541, in _buildFinished
             w.buildFinished(name, s, results)
           File
 "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\mail.py", line
 410, in buildFinished
             return self.buildMessage(name, [build], results)
           File
 "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\mail.py", line
 593, in buildMessage
             results, builds, patches, logs)
           File
 "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\mail.py", line
 544, in createEmail
             if len(builds == 1):
         exceptions.TypeError: object of type 'bool' has no len()
 }}}

--

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2018#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation