[Buildbot-commits] [Buildbot] #2017: attaching logs to build mail is broken in 0.8.4p1

[Buildbot]

#2017: attaching logs to build mail is broken in 0.8.4p1
--------------------+-----------------------
Reporter:  dberger  |      Owner:
    Type:  defect   |     Status:  new
Priority:  major    |  Milestone:  undecided
 Version:  0.8.4p1  |   Keywords:
--------------------+-----------------------
 2011-06-28 13:03:43-0700 [-] Exception caught notifying
 <buildbot.status.mail.MailNotifier instance at 0x029E8AA8> of
 buildFinished event
 2011-06-28 13:03:43-0700 [-] Unhandled Error
         Traceback (most recent call last):
           File
 "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\build.py", line
 288, in buildFinished
             w.callback(self)
           File
 "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line
 361, in callback
             self._startRunCallbacks(result)
           File
 "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line
 455, in _startRunCallbacks
             self._runCallbacks()
           File
 "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line
 542, in _runCallbacks
             current.result = callback(current.result, *args, **kw)
         --- <exception caught here> ---
           File
 "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\builder.py",
 line 541, in _buildFinished
             w.buildFinished(name, s, results)
           File
 "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\mail.py", line
 410, in buildFinished
             return self.buildMessage(name, [build], results)
           File
 "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\mail.py", line
 593, in buildMessage
             results, builds, patches, logs)
           File
 "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\mail.py", line
 529, in createEmail
             name = "%s.%s" % (log.getStep().getName(),
         exceptions.AttributeError: 'list' object has no attribute
 'getStep'

 It looks like this change may be related:

 2ad09c73        Adam    Added the ability to only send a single summary
 email from a MailNotif...       May 29, 2011

 I think changing logs.append(build.getLogs()) to
 logs.extend(build.getLogs()) on mail.py:583 is more correct, but I'm
 waiting for our master to shutdown so I can test.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2017>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation