[Buildbot-commits] [Buildbot] #2016: upgrade-master errror: local variable conn1 referenced before assignment

[Buildbot]

#2016: upgrade-master errror: local variable conn1 referenced before assignment
--------------------+-----------------------
Reporter:  cortana  |      Owner:
    Type:  defect   |     Status:  new
Priority:  major    |  Milestone:  undecided
 Version:  0.8.4p1  |   Keywords:
--------------------+-----------------------
 The fix for #1810 has broken upgrade-master on my system:

 {{{
 $ buildbot upgrade-master /srv/buildbot
 upgrading basedir
 /srv/buildbot/public_html/default.css has old/modified contents
  writing new contents to /srv/buildbot/public_html/default.css.new
 /srv/buildbot/master.cfg.sample has old/modified contents
  overwriting it with new contents
 checking master.cfg
 /usr/lib/python2.6/dist-packages/twisted/mail/smtp.py:10:
 DeprecationWarning: the MimeWriter module is deprecated; use the email
 package instead
   import MimeWriter, tempfile, rfc822
 upgrading database
 Traceback (most recent call last):
   File "/usr/lib/python2.6/dist-packages/twisted/internet/base.py", line
 426, in _continueFiring
     callable(*args, **kwargs)
   File "/usr/lib/python2.6/dist-packages/buildbot/scripts/runner.py", line
 36, in async
     d = defer.maybeDeferred(f, *args, **kwargs)
   File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line
 125, in maybeDeferred
     result = f(*args, **kw)
   File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line
 837, in unwindGenerator
     return _deferGenerator(f(*args, **kwargs), Deferred())
 --- <exception caught here> ---
   File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line
 739, in _deferGenerator
     result = g.next()
   File "/usr/lib/python2.6/dist-packages/buildbot/scripts/runner.py", line
 499, in upgradeMaster
     basedir=config['basedir'])
   File "/usr/lib/python2.6/dist-packages/buildbot/db/connector.py", line
 43, in __init__
     self.pool = pool.DBThreadPool(self._engine)
   File "/usr/lib/python2.6/dist-packages/buildbot/db/pool.py", line 73, in
 __init__
     self.__broken_sqlite = self.detect_bug1810()
   File "/usr/lib/python2.6/dist-packages/buildbot/db/pool.py", line 210,
 in detect_bug1810
     test()
   File "/usr/lib/python2.6/dist-packages/buildbot/db/pool.py", line 205,
 in test
     conn1.close()
 exceptions.UnboundLocalError: local variable 'conn1' referenced before
 assignment
 }}}

 I'm guessing that line 193 throws while connecting to dbfile, thus conn1
 is never assigned to.

 I'm using Python 2.6.6 on Debian with SQLAlchemy 0.6.3 and sqlalchemy-
 migrate 0.6.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2016>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation