[Buildbot-commits] [Buildbot] #2011: Traceback popping from empty deque in addChange

[Buildbot]

#2011: Traceback popping from empty deque in addChange
------------------------+--------------------
Reporter:  adamcollard  |       Owner:
    Type:  defect       |      Status:  new
Priority:  critical     |   Milestone:  0.8.5
 Version:  0.8.4p1      |  Resolution:
Keywords:               |
------------------------+--------------------

Comment (by dustin):

 So I can't see how this could have occurred.  If you're willing to do a
 bit of debugging, I can provide a new version of {{{lru.py}}} to try
 (attached).  Otherwise, a fix is:

 {{{
 #!patch
 diff --git a/master/buildbot/util/lru.py b/master/buildbot/util/lru.py
 index 7e19906..d13df75 100644
 --- a/master/buildbot/util/lru.py
 +++ b/master/buildbot/util/lru.py
 @@ -186,7 +186,7 @@ class AsyncLRUCache(object):
          # purge least recently used entries, using refcount
          # to count repeatedly-used entries
          while len(cache) > max_size:
 -            refc = 1
 +            refc = len(queue)
              while refc:
                  k = queue.popleft()
                  refc = refcount[k] = refcount[k] - 1
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2011#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation