[Buildbot-commits] [Buildbot] #2008: mergeRequests globally or per builder seems to not function

Buildbot nobody at buildbot.net
Sat Jun 25 19:20:21 UTC 2011


#2008: mergeRequests globally or per builder seems to not function
---------------------+---------------------
Reporter:  bdbaddog  |       Owner:
    Type:  defect    |      Status:  closed
Priority:  major     |   Milestone:  0.8.5
 Version:  0.8.4     |  Resolution:  fixed
Keywords:            |
---------------------+---------------------

Comment (by Dustin J. Mitchell):

 Builder configuration should default mergeRequests to None, not True

 Without this change, mergeRequests is True regardless of the global
 setting, unless specifically set to something else in the BuilderConfig.

 This also fixes an error in _getMergeRequestFn, which was looking at
 self.master.mergeRequests, not self.botmaster.mergeRequests, and updates
 the tests to match and to have somewhat more readable inputs.

 Fixes #2008.
  Changeset: 977eb41f40215a65215b6e74beac66a9f46b1801

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2008#comment:9>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation


More information about the Commits mailing list