[Buildbot-commits] [Buildbot] #2014: The MailNotifier's subject can't be overriden anymore with a function

[Buildbot]

#2014: The MailNotifier's subject can't be overriden anymore with a function
----------------------+------------------------
Reporter:  abompard   |      Owner:
    Type:  undecided  |     Status:  new
Priority:  major      |  Milestone:  undecided
 Version:  0.8.4p1    |   Keywords:  mail patch
----------------------+------------------------
 The `MailNotifier`'s documentation states that the `messageFormatter`
 function may set a "subject" key, to override the default mail subject.

 However, this is not possible anymore with Buildbot 0.8.4 (and p1, and
 today's master) because there is a line missing in `buildMessage()`.

 The patch is so small I'm pasting it here:
 {{{
 #!diff
 --- /usr/lib/python2.5/site-packages/buildbot/status/mail.py.orig
 2011-06-24 12:11:42.000000000 +0200
 +++ /usr/lib/python2.5/site-packages/buildbot/status/mail.py    2011-06-24
 12:12:29.000000000 +0200
 @@ -588,6 +588,8 @@
              msgdict['body'] += tmp['body']
              msgdict['body'] += '\n\n'
              msgdict['type'] = tmp['type']
 +            if "subject" in tmp:
 +                msgdict['subject'] = tmp['subject']

          m = self.createEmail(msgdict, name,
 self.master_status.getTitle(),
                               results, builds, patches, logs)
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2014>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation