[Buildbot-commits] [Buildbot] #1988: Incompatible change in svn_buildbot.py with steps/source.py

[Buildbot]

#1988: Incompatible change in svn_buildbot.py with steps/source.py
---------------------+----------------------
Reporter:  abompard  |       Owner:
    Type:  defect    |      Status:  closed
Priority:  blocker   |   Milestone:  0.8.4p1
 Version:  0.8.4     |  Resolution:  fixed
Keywords:  svn       |
---------------------+----------------------
Changes (by dustin):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Trying to replicate this.  The step is:
 {{{
 f1.addStep(SVN(baseURL='http://svn.r.igoro.us/projects/toys/Processor/',
 defaultBranch='trunk'))
 }}}

 but I'm using a !GitPoller, so the change looks like

  {{{Change(revision=u'e0f3a1d454e0afb12400c0244b132a68a2e2674b',
 who=u'dustin at zmanda.com', branch=u'master', comments=u'changed',
 when=1308374007, category=None, project=u'foo',
 repository=u'/home/dustin/code/buildbot/t/testrepo/')}}}

 from what I understand of the bug, I would expect the source step to check
 out {{{/home/dustin/code/buildbot/t/testrepo/}}}, since that's the
 repository attribute that will override the svnurl.  With Buidbot
 {{{v0.8.4}}} (the git tag), I do indeed see

  {{{/usr/bin/svn checkout --non-interactive --no-auth-cache --revision
 cb51672c9a78188ac99a936e539ca4437a9e6312
 /home/dustin/code/buildbot/t/testrepo/@cb51672c9a78188ac99a936e539ca4437a9e6312
 build}}}

 but with the current buildbot-0.8.4 branch (now at
 [91972b36d2970db77196c7a82a9b85e7204482bc], and which will become
 0.8.4p1), I see

  {{{/usr/bin/svn checkout --non-interactive --no-auth-cache --revision
 cc81fdfd38308d1eddfb468f42c266f4c1c174ca
 http://svn.r.igoro.us/projects/toys/Processor/master@cc81fdfd38308d1eddfb468f42c266f4c1c174ca
 build}}}

 which is to say that it used the baseurl and appended the branch.  I
 believe the fix was [08885362aa8a82aa3ddb7d0df75db8174d45fafb].

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1988#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation