[Buildbot-commits] [Buildbot] #1987: sendchange fails with TypeError

[Buildbot]

#1987: sendchange fails with TypeError
----------------------+--------------------
Reporter:  Underhand  |       Owner:
    Type:  defect     |      Status:  new
Priority:  major      |   Milestone:  0.8.5
 Version:  master     |  Resolution:
Keywords:             |
----------------------+--------------------
Changes (by dustin):

 * milestone:  undecided => 0.8.5


Old description:

> With the latest version from the master branch, downloaded today from
> github, attempting to run sendchange gives the following error.
>
> -bash-4.2$ buildbot sendchange --master 'localhost:9989' --who testuser
> --branch test a b
> Traceback (most recent call last):
>   File "/usr/pkg/bin/buildbot", line 4, in <module>
>     runner.run()
>   File "/usr/pkg/lib/python2.6/site-packages/buildbot/scripts/runner.py",
> line 1234, in run
>     if not sendchange(so, True):
>   File "/usr/pkg/lib/python2.6/site-packages/buildbot/scripts/runner.py",
> line 898, in sendchange
>     revlink=revlink)
>   File "/usr/pkg/lib/python2.6/site-
> packages/buildbot/clients/sendchange.py", line 40, in send
>     change['files'][i] = file.decode(self.encoding, 'replace')
> TypeError: 'tuple' object does not support item assignment
>
> Without specifying any files, I get this instead:
>
> -bash-4.2$ buildbot sendchange --master 'localhost:9989' --who testuser
> --branch test
> Traceback (most recent call last):
>   File "/usr/pkg/bin/buildbot", line 4, in <module>
>     runner.run()
>   File "/usr/pkg/lib/python2.6/site-packages/buildbot/scripts/runner.py",
> line 1234, in run
>     if not sendchange(so, True):
>   File "/usr/pkg/lib/python2.6/site-packages/buildbot/scripts/runner.py",
> line 904, in sendchange
>     d.addCallbacks(s.printSuccess, failed)
> AttributeError: Sender instance has no attribute 'printSuccess'

New description:

 With the latest version from the master branch, downloaded today from
 github, attempting to run sendchange gives the following error.

 {{{
 -bash-4.2$ buildbot sendchange --master 'localhost:9989' --who testuser
 --branch test a b
 Traceback (most recent call last):
   File "/usr/pkg/bin/buildbot", line 4, in <module>
     runner.run()
   File "/usr/pkg/lib/python2.6/site-packages/buildbot/scripts/runner.py",
 line 1234, in run
     if not sendchange(so, True):
   File "/usr/pkg/lib/python2.6/site-packages/buildbot/scripts/runner.py",
 line 898, in sendchange
     revlink=revlink)
   File "/usr/pkg/lib/python2.6/site-
 packages/buildbot/clients/sendchange.py", line 40, in send
     change['files'][i] = file.decode(self.encoding, 'replace')
 TypeError: 'tuple' object does not support item assignment

 Without specifying any files, I get this instead:

 -bash-4.2$ buildbot sendchange --master 'localhost:9989' --who testuser
 --branch test
 Traceback (most recent call last):
   File "/usr/pkg/bin/buildbot", line 4, in <module>
     runner.run()
   File "/usr/pkg/lib/python2.6/site-packages/buildbot/scripts/runner.py",
 line 1234, in run
     if not sendchange(so, True):
   File "/usr/pkg/lib/python2.6/site-packages/buildbot/scripts/runner.py",
 line 904, in sendchange
     d.addCallbacks(s.printSuccess, failed)
 AttributeError: Sender instance has no attribute 'printSuccess'
 }}}

--

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1987#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation