[Buildbot-commits] [Buildbot] #1983: Catch Stale Broker errors on duplicate notification

[Buildbot]

#1983: Catch Stale Broker errors on duplicate notification
-------------------+-------------------
Reporter:  dustin  |      Owner:
    Type:  defect  |     Status:  new
Priority:  major   |  Milestone:  0.8.5
 Version:  0.8.2   |   Keywords:
-------------------+-------------------
 {{{
         Traceback from remote host -- Traceback (most recent call last):
           File "/tools/buildbot-0.8.2/lib/python2.6/site-
 packages/twisted/spread/pb.py", line 1346, in remote_respond
             d = self.portal.login(self, mind, IPerspective)
           File "/tools/buildbot-0.8.2/lib/python2.6/site-
 packages/twisted/cred/portal.py", line 116, in login
             ).addCallback(self.realm.requestAvatar, mind, *interfaces
           File "/tools/buildbot-0.8.2/lib/python2.6/site-
 packages/twisted/internet/defer.py", line 260, in addCallback
             callbackKeywords=kw)
           File "/tools/buildbot-0.8.2/lib/python2.6/site-
 packages/twisted/internet/defer.py", line 249, in addCallbacks
             self._runCallbacks()
         --- <exception caught here> ---
           File "/tools/buildbot-0.8.2/lib/python2.6/site-
 packages/twisted/internet/defer.py", line 441, in _runCallbacks
             self.result = callback(self.result, *args, **kw)
           File "/tools/buildbot-0.8.2/lib/python2.6/site-
 packages/buildbot-0.8.2_hg_509eed75bf25_production_0.8-py2.6.egg/buildbot/master.py",
 line 474, in requestAvatar
             p = self.botmaster.getPerspective(mind, avatarID)
           File "/tools/buildbot-0.8.2/lib/python2.6/site-
 packages/buildbot-0.8.2_hg_509eed75bf25_production_0.8-py2.6.egg/buildbot/master.py",
 line 344, in getPerspective
             d = sl.slave.callRemote("print", "master got a duplicate
 connection; keeping this one")
           File "/tools/buildbot-0.8.2/lib/python2.6/site-
 packages/twisted/spread/pb.py", line 328, in callRemote
             _name, args, kw)
           File "/tools/buildbot-0.8.2/lib/python2.6/site-
 packages/twisted/spread/pb.py", line 807, in _sendMessage
             raise DeadReferenceError("Calling Stale Broker")
         twisted.spread.pb.DeadReferenceError: Calling Stale Broker
 }}}
 This is pretty much an indication that we can immediately accept the new
 slave.

 I'll need to see if I can replicate this with a more recent master.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1983>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation