From noreply at github.com Wed Jun 1 02:56:46 2011 From: noreply at github.com (noreply at github.com) Date: Tue, 31 May 2011 19:56:46 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 56a4db: return a list, not a dict, from remote_getBuildReq... Message-ID: <20110601025646.3FA03422A7@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 56a4db89f7725eed2e764549ffed9d51beb33233 https://github.com/buildbot/buildbot/commit/56a4db89f7725eed2e764549ffed9d51beb33233 Author: Dustin J. Mitchell Date: 2011-05-31 (Tue, 31 May 2011) Changed paths: M master/buildbot/status/client.py Log Message: ----------- return a list, not a dict, from remote_getBuildRequests From nobody at buildbot.net Wed Jun 1 03:09:21 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 01 Jun 2011 03:09:21 -0000 Subject: [Buildbot-commits] [Buildbot] #1969: How can I config GerritChangeSource trigger building? In-Reply-To: <037.93871fe205ab7159e963d8beed138b2d@buildbot.net> References: <037.93871fe205ab7159e963d8beed138b2d@buildbot.net> Message-ID: <052.5525b92a721f828f2f1e27f79cc9b127@buildbot.net> #1969: How can I config GerritChangeSource trigger building? ----------------------------+---------------------- Reporter: clino | Owner: Type: support-request | Status: new Priority: major | Milestone: ongoing Version: master | Resolution: Keywords: gerrit | ----------------------------+---------------------- Comment (by clino): Replying to [comment:6 dustin]: > This is probably the function you want to look at, in master/buildbot/schedulers/basic.py: > You may also want to update to the most recent commits on master - many bugs have been fixed since May 2. I git pull to update.And found if I config with SingleBranchScheduler or AnyBranchScheduler,it trigger build now. And I will report result after config with my production environment. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Jun 1 04:34:06 2011 From: noreply at github.com (noreply at github.com) Date: Tue, 31 May 2011 21:34:06 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] ec7055: Merge branch 'master' of git://github.com/liucouga... Message-ID: <20110601043406.623E142389@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: ec7055c68aa1c1d79142aa56d92deda5c42e21d6 https://github.com/buildbot/buildbot/commit/ec7055c68aa1c1d79142aa56d92deda5c42e21d6 Author: Dustin J. Mitchell Date: 2011-05-31 (Tue, 31 May 2011) Changed paths: M master/buildbot/steps/subunit.py Log Message: ----------- Merge branch 'master' of git://github.com/liucougar/buildbot * 'master' of git://github.com/liucougar/buildbot: if exit status is not 0, return failure status for buildbot subunit step From nobody at buildbot.net Wed Jun 1 14:42:38 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 01 Jun 2011 14:42:38 -0000 Subject: [Buildbot-commits] [Buildbot] #1871: Goofy quoting/space handling in buildbot_service.py In-Reply-To: <041.01b11010e70edfcc9095f4da89015f6c@buildbot.net> References: <041.01b11010e70edfcc9095f4da89015f6c@buildbot.net> Message-ID: <056.528dd0e9a0cd71a847bbf912f9cb4101@buildbot.net> #1871: Goofy quoting/space handling in buildbot_service.py ------------------------+------------------------ Reporter: dabrahams | Owner: dabrahams Type: enhancement | Status: assigned Priority: major | Milestone: 0.8.5 Version: 0.8.3p1 | Resolution: Keywords: docs | ------------------------+------------------------ Changes (by dabrahams): * owner: => dabrahams * status: new => assigned -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 1 14:42:49 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 01 Jun 2011 14:42:49 -0000 Subject: [Buildbot-commits] [Buildbot] #1871: Goofy quoting/space handling in buildbot_service.py In-Reply-To: <041.01b11010e70edfcc9095f4da89015f6c@buildbot.net> References: <041.01b11010e70edfcc9095f4da89015f6c@buildbot.net> Message-ID: <056.77836f7b51e0a44fde8e4e336f79e6b8@buildbot.net> #1871: Goofy quoting/space handling in buildbot_service.py ------------------------+------------------------ Reporter: dabrahams | Owner: dabrahams Type: enhancement | Status: closed Priority: major | Milestone: 0.8.5 Version: 0.8.3p1 | Resolution: fixed Keywords: docs | ------------------------+------------------------ Changes (by dabrahams): * status: assigned => closed * resolution: => fixed -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 1 14:43:50 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 01 Jun 2011 14:43:50 -0000 Subject: [Buildbot-commits] [Buildbot] #1871: Goofy quoting/space handling in buildbot_service.py In-Reply-To: <041.01b11010e70edfcc9095f4da89015f6c@buildbot.net> References: <041.01b11010e70edfcc9095f4da89015f6c@buildbot.net> Message-ID: <056.9e60e1ed71b7e7ca3538868ddb2b4cde@buildbot.net> #1871: Goofy quoting/space handling in buildbot_service.py ----------------------+------------------------ Reporter: dabrahams | Owner: dabrahams Type: defect | Status: reopened Priority: major | Milestone: 0.8.5 Version: 0.8.3p1 | Resolution: Keywords: docs | ----------------------+------------------------ Changes (by dabrahams): * status: closed => reopened * type: enhancement => defect * resolution: fixed => Comment: Oops; the actual problem isn't fixed; I just updated the Wiki -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 1 14:44:59 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 01 Jun 2011 14:44:59 -0000 Subject: [Buildbot-commits] [Buildbot] #1871: Goofy quoting/space handling in buildbot_service.py In-Reply-To: <041.01b11010e70edfcc9095f4da89015f6c@buildbot.net> References: <041.01b11010e70edfcc9095f4da89015f6c@buildbot.net> Message-ID: <056.b886d972d3b098a3540e0237841906c0@buildbot.net> #1871: Goofy quoting/space handling in buildbot_service.py ----------------------+----------------------- Reporter: dabrahams | Owner: djmitche Type: defect | Status: assigned Priority: major | Milestone: 0.8.5 Version: 0.8.3p1 | Resolution: Keywords: docs | ----------------------+----------------------- Changes (by dabrahams): * owner: dabrahams => djmitche * status: reopened => assigned -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 1 14:45:37 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 01 Jun 2011 14:45:37 -0000 Subject: [Buildbot-commits] [Buildbot] #1871: Goofy quoting/space handling in buildbot_service.py In-Reply-To: <041.01b11010e70edfcc9095f4da89015f6c@buildbot.net> References: <041.01b11010e70edfcc9095f4da89015f6c@buildbot.net> Message-ID: <056.6864443f3fb216f19b23de3c68253867@buildbot.net> #1871: Goofy quoting/space handling in buildbot_service.py ----------------------+----------------------- Reporter: dabrahams | Owner: dustin Type: defect | Status: assigned Priority: major | Milestone: 0.8.5 Version: 0.8.3p1 | Resolution: Keywords: docs | ----------------------+----------------------- Changes (by dabrahams): * owner: djmitche => dustin Comment: Sorry about the ticket churn; I'm done here now. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 1 15:11:33 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 01 Jun 2011 15:11:33 -0000 Subject: [Buildbot-commits] [Buildbot] #1871: Goofy quoting/space handling in buildbot_service.py In-Reply-To: <041.01b11010e70edfcc9095f4da89015f6c@buildbot.net> References: <041.01b11010e70edfcc9095f4da89015f6c@buildbot.net> Message-ID: <056.f797f1c45c6e6e3fae58425b695fd4bb@buildbot.net> #1871: Goofy quoting/space handling in buildbot_service.py ----------------------+----------------------- Reporter: dabrahams | Owner: Type: defect | Status: assigned Priority: major | Milestone: 0.8.5 Version: 0.8.3p1 | Resolution: Keywords: docs | ----------------------+----------------------- Changes (by dustin): * owner: dustin => -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Jun 1 15:24:10 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 1 Jun 2011 08:24:10 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 0edb2c: persistent_queue: use cPickle when possible Message-ID: <20110601152410.59E80424DF@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 0edb2c8c583a93ff0b87e6e3d19ff0b173781243 https://github.com/buildbot/buildbot/commit/0edb2c8c583a93ff0b87e6e3d19ff0b173781243 Author: P. Christeas Date: 2011-05-31 (Tue, 31 May 2011) Changed paths: M master/buildbot/status/persistent_queue.py Log Message: ----------- persistent_queue: use cPickle when possible Commit: 002695f03d42daf0d3b9882bdaa3257ca85d1212 https://github.com/buildbot/buildbot/commit/002695f03d42daf0d3b9882bdaa3257ca85d1212 Author: P. Christeas Date: 2011-05-31 (Tue, 31 May 2011) Changed paths: M master/buildbot/changes/base.py Log Message: ----------- changes/base: let a PollingChangeSource stop earlier, itself Commit: 8bf62315a734d3e34d2dbaeba92d6ea41a0e3287 https://github.com/buildbot/buildbot/commit/8bf62315a734d3e34d2dbaeba92d6ea41a0e3287 Author: P. Christeas Date: 2011-05-31 (Tue, 31 May 2011) Changed paths: M master/buildbot/process/botmaster.py Log Message: ----------- botmaster: shorter log, only names of builders We have too many of them, the log was so bloated. Commit: 26c6f8109f18a8ea21f4e1d9b26990280822428e https://github.com/buildbot/buildbot/commit/26c6f8109f18a8ea21f4e1d9b26990280822428e Author: Dustin J. Mitchell Date: 2011-06-01 (Wed, 01 Jun 2011) Changed paths: M master/buildbot/changes/base.py M master/buildbot/process/botmaster.py M master/buildbot/status/persistent_queue.py M master/buildbot/status/web/feeds.py Log Message: ----------- Merge branch 'push084-2' of git://github.com/xrg/buildbot * 'push084-2' of git://github.com/xrg/buildbot: botmaster: shorter log, only names of builders changes/base: let a PollingChangeSource stop earlier, itself persistent_queue: use cPickle when possible web/feeds: make sure dates are in en_US, not locale. Commit: 86adb4a94815e870142cf559bb783f35919bbf9f https://github.com/buildbot/buildbot/commit/86adb4a94815e870142cf559bb783f35919bbf9f Author: Dustin J. Mitchell Date: 2011-06-01 (Wed, 01 Jun 2011) Changed paths: M master/buildbot/status/persistent_queue.py Log Message: ----------- use cPickle unconditionally It's available in all CPython's forever, and the import trick makes pyflakes sad. Compare: https://github.com/buildbot/buildbot/compare/ec7055c...86adb4a From nobody at buildbot.net Wed Jun 1 23:49:37 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 01 Jun 2011 23:49:37 -0000 Subject: [Buildbot-commits] [Buildbot] #1975: changeHorizon set too soon Message-ID: <038.a0c48d44237d800a871f95ae960637d5@buildbot.net> #1975: changeHorizon set too soon ---------------------+---------------------- Reporter: dustin | Owner: dustin Type: defect | Status: new Priority: critical | Milestone: 0.8.4 Version: master | Keywords: database ---------------------+---------------------- {{{ 2011-06-02 01:48:00+0200 [-] Unhandled Error Traceback (most recent call last): File "/home/buildbot/metabuildbot/src/master/buildbot/master.py", line 189, in loadTheConfigFile d = self.loadConfig(f) File "/home/buildbot/metabuildbot/src/master/buildbot/master.py", line 535, in loadConfig d.addCallback(do_load) File "/home/buildbot/sandbox/lib/python2.6/site- packages/twisted/internet/defer.py", line 297, in addCallback callbackKeywords=kw) File "/home/buildbot/sandbox/lib/python2.6/site- packages/twisted/internet/defer.py", line 286, in addCallbacks self._runCallbacks() --- --- File "/home/buildbot/sandbox/lib/python2.6/site- packages/twisted/internet/defer.py", line 542, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/home/buildbot/metabuildbot/src/master/buildbot/master.py", line 325, in do_load self.db.changeHorizon = changeHorizon exceptions.AttributeError: 'NoneType' object has no attribute 'changeHorizon' }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Jun 2 01:00:57 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 02 Jun 2011 01:00:57 -0000 Subject: [Buildbot-commits] [Buildbot] #1976: Git build step fails after SVN step Message-ID: <036.3f77dd3bb4bc7a720ea33ca14f012359@buildbot.net> #1976: Git build step fails after SVN step --------------------+----------------------- Reporter: karl | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.3p1 | Keywords: svn git --------------------+----------------------- I have a build factory which needs to update and deploy from both a SVN and Git repository. This works when I force a build, however, when a build is scheduled by a SVN update noticed by PBChangeSource, the Git step fails. Here is a fragment: {{{ instance = factory.BuildFactory() instance.addStep( SVN(svnurl='xxx', workdir='xxx', mode='clobber')) instance.addStep(Compile(workdir='xxx')) instance.addStep( Git(repourl='xxx_2', workdir='xxx_2' mode='clobber')) }}} When this is triggered by a SVN update, one of the commands run by the Git step is /usr/bin/git reset --hard 4436 (or whatever SVN revision number triggered the build), which fails (since Git doesn't like the SVN revision number). This command isn't run for a forced build. Slave is running buildbot-0.8.3p1.zip downloaded from code.google.com, master is running 0.8.3p1 as well. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Jun 2 05:53:30 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 02 Jun 2011 05:53:30 -0000 Subject: [Buildbot-commits] [Buildbot] #1976: Git build step fails after SVN step In-Reply-To: <036.3f77dd3bb4bc7a720ea33ca14f012359@buildbot.net> References: <036.3f77dd3bb4bc7a720ea33ca14f012359@buildbot.net> Message-ID: <051.ef40998ffee73b0c7a3ed7d62ce32572@buildbot.net> #1976: Git build step fails after SVN step --------------------+------------------------ Reporter: karl | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.3p1 | Resolution: Keywords: svn git | --------------------+------------------------ Comment (by karl): The Git update isn't being triggered by a checkin here; I need a specific revision (HEAD in this case). This is a workaround that lets Git work when triggered by SVN: {{{ class GitHack(Git): def startVC(self, branch, revision, patch): return Git.startVC(self, branch, None, patch) }}} -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Jun 2 06:17:55 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 1 Jun 2011 23:17:55 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 36617a: Store configuration values in master.config Message-ID: <20110602061755.9CD4D42538@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 36617a8ad1a23e75448991e79616074ad8a96378 https://github.com/buildbot/buildbot/commit/36617a8ad1a23e75448991e79616074ad8a96378 Author: Dustin J. Mitchell Date: 2011-06-01 (Wed, 01 Jun 2011) Changed paths: M master/buildbot/config.py M master/buildbot/db/changes.py M master/buildbot/db/connector.py M master/buildbot/master.py M master/docs/developer.texinfo Log Message: ----------- Store configuration values in master.config This immediately fixes #1975, but opens the door to storing a lot more configuration here. From nobody at buildbot.net Thu Jun 2 06:18:01 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 02 Jun 2011 06:18:01 -0000 Subject: [Buildbot-commits] [Buildbot] #1975: changeHorizon set too soon In-Reply-To: <038.a0c48d44237d800a871f95ae960637d5@buildbot.net> References: <038.a0c48d44237d800a871f95ae960637d5@buildbot.net> Message-ID: <053.5908279104d95bded968f9866ad7afcd@buildbot.net> #1975: changeHorizon set too soon ---------------------+--------------------- Reporter: dustin | Owner: dustin Type: defect | Status: closed Priority: critical | Milestone: 0.8.4 Version: master | Resolution: fixed Keywords: database | ---------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Store configuration values in master.config This immediately fixes #1975, but opens the door to storing a lot more configuration here. Changeset: 36617a8ad1a23e75448991e79616074ad8a96378 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Jun 2 19:30:16 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 2 Jun 2011 12:30:16 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 391e43: Implement buildbot metrics tracking. Message-ID: <20110602193016.5F95442464@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 391e43ca8aa0d4db5e64a858910c73a0d926ea31 https://github.com/buildbot/buildbot/commit/391e43ca8aa0d4db5e64a858910c73a0d926ea31 Author: Chris AtLee Date: 2011-06-02 (Thu, 02 Jun 2011) Changed paths: M master/buildbot/buildslave.py M master/buildbot/master.py M master/buildbot/process/botmaster.py M master/buildbot/process/build.py M master/buildbot/process/buildstep.py A master/buildbot/process/metrics.py M master/buildbot/status/builder.py M master/buildbot/status/master.py M master/buildbot/status/web/status_json.py A master/buildbot/test/unit/test_process_metrics.py M master/buildbot/util/loop.py A master/contrib/check_buildbot.py M master/docs/cfg-global.texinfo M master/docs/developer.texinfo M slave/buildslave/commands/base.py Log Message: ----------- Implement buildbot metrics tracking. Fixes: #1945 From noreply at github.com Thu Jun 2 19:45:23 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 2 Jun 2011 12:45:23 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 41061a: Use defaultdict from buildbot.util.bbcollections. Message-ID: <20110602194523.760DB42575@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 41061ad8858b345eb34def7295c59087b13b5636 https://github.com/buildbot/buildbot/commit/41061ad8858b345eb34def7295c59087b13b5636 Author: Chris AtLee Date: 2011-06-02 (Thu, 02 Jun 2011) Changed paths: M master/buildbot/process/metrics.py Log Message: ----------- Use defaultdict from buildbot.util.bbcollections. From noreply at github.com Thu Jun 2 20:28:00 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 2 Jun 2011 13:28:00 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 16ff37: Don't use absolute values for testing amount of ga... Message-ID: <20110602202800.9C4CF425A9@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 16ff378f6f1cc5fa832f3b191a9d2e1d48cbe185 https://github.com/buildbot/buildbot/commit/16ff378f6f1cc5fa832f3b191a9d2e1d48cbe185 Author: Chris AtLee Date: 2011-06-02 (Thu, 02 Jun 2011) Changed paths: M master/buildbot/test/unit/test_process_metrics.py Log Message: ----------- Don't use absolute values for testing amount of garbage From noreply at github.com Thu Jun 2 20:56:57 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 2 Jun 2011 13:56:57 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 9926d1: Fix slave tests to cope with elapsed time data Message-ID: <20110602205657.C26B242542@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 9926d196a79dd51f8e633d8241354bbd1ae02a44 https://github.com/buildbot/buildbot/commit/9926d196a79dd51f8e633d8241354bbd1ae02a44 Author: Chris AtLee Date: 2011-06-02 (Thu, 02 Jun 2011) Changed paths: M slave/buildslave/test/unit/test_bot.py M slave/buildslave/test/unit/test_commands_base.py M slave/buildslave/test/unit/test_commands_fs.py M slave/buildslave/test/unit/test_commands_shell.py M slave/buildslave/test/unit/test_commands_transfer.py M slave/buildslave/test/util/command.py Log Message: ----------- Fix slave tests to cope with elapsed time data Commit: 9ee454877e93fce1e22620ef97d446c291daec87 https://github.com/buildbot/buildbot/commit/9ee454877e93fce1e22620ef97d446c291daec87 Author: Chris AtLee Date: 2011-06-02 (Thu, 02 Jun 2011) Changed paths: M slave/buildslave/test/unit/test_bot.py M slave/buildslave/test/unit/test_commands_base.py M slave/buildslave/test/unit/test_commands_fs.py M slave/buildslave/test/unit/test_commands_shell.py M slave/buildslave/test/unit/test_commands_transfer.py M slave/buildslave/test/util/command.py Log Message: ----------- Merge branch 'metrics' Compare: https://github.com/buildbot/buildbot/compare/16ff378...9ee4548 From noreply at github.com Thu Jun 2 21:21:13 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 2 Jun 2011 14:21:13 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 25f905: Rename metrics.FiniteList.maxlen to _maxlen to sup... Message-ID: <20110602212113.070894224E@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 25f9052ccc4758533df7c88d45cd17b0a663ad1b https://github.com/buildbot/buildbot/commit/25f9052ccc4758533df7c88d45cd17b0a663ad1b Author: Chris AtLee Date: 2011-06-02 (Thu, 02 Jun 2011) Changed paths: M master/buildbot/process/metrics.py Log Message: ----------- Rename metrics.FiniteList.maxlen to _maxlen to support python2.7 From noreply at github.com Thu Jun 2 21:24:52 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 2 Jun 2011 14:24:52 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] a5a728: fix pyflakes Message-ID: <20110602212452.8D50D425BB@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: a5a72864152b3a14cc6fce53b322a3a1110206cf https://github.com/buildbot/buildbot/commit/a5a72864152b3a14cc6fce53b322a3a1110206cf Author: Dustin J. Mitchell Date: 2011-06-02 (Thu, 02 Jun 2011) Changed paths: M master/buildbot/process/metrics.py M master/buildbot/util/loop.py Log Message: ----------- fix pyflakes From nobody at buildbot.net Fri Jun 3 08:00:12 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 03 Jun 2011 08:00:12 -0000 Subject: [Buildbot-commits] [Buildbot] #1773: deprecate 'default branch' In-Reply-To: <038.07b8bbcf29816b44f3bd20048e226379@buildbot.net> References: <038.07b8bbcf29816b44f3bd20048e226379@buildbot.net> Message-ID: <053.a8a44218dde3cb59d984a6d944e29778@buildbot.net> #1773: deprecate 'default branch' --------------------------------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.3p1 | Resolution: Keywords: bk, bzr, cvs, darcs, git, hg, p4, svn | --------------------------------------------------+-------------------- Changes (by in3xes): * cc: in3xes@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Jun 3 08:03:19 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 03 Jun 2011 08:03:19 -0000 Subject: [Buildbot-commits] [Buildbot] #76: add mercurial RSS poller change source In-Reply-To: <045.fc42a2ae1dbf5132f47e73265343ba32@buildbot.net> References: <045.fc42a2ae1dbf5132f47e73265343ba32@buildbot.net> Message-ID: <060.bb2558eef103f1c9f3a46a6b7956475a@buildbot.net> #76: add mercurial RSS poller change source --------------------------+--------------------- Reporter: TedMielczarek | Owner: warner Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.7.5 | Resolution: Keywords: hg | --------------------------+--------------------- Changes (by in3xes): * cc: in3xes@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Jun 3 13:26:50 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 03 Jun 2011 13:26:50 -0000 Subject: [Buildbot-commits] [Buildbot] #1977: transitions between working / broken not computed per-branch Message-ID: <041.02daa6178728651fb513ff2c7280e668@buildbot.net> #1977: transitions between working / broken not computed per-branch ----------------------+----------------------- Reporter: dabrahams | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.3p1 | Keywords: status ----------------------+----------------------- If I have a project building all branches, and branch A goes from fixed to broken, the next commit that builds cleanly on a different branch will be reported as a transition from broken to fixed. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jun 5 00:59:03 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 05 Jun 2011 00:59:03 -0000 Subject: [Buildbot-commits] [Buildbot] #1978: print hostname on master when sending UnauthorizedLogin Message-ID: <038.dc03be6e23b548c0aca3701f11b7ee29@buildbot.net> #1978: print hostname on master when sending UnauthorizedLogin ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: trivial | Milestone: 0.8.4 Version: master | Keywords: simple ------------------------+-------------------- the metabuildbot is seeing connection requests that are being responded to with !UnauthorizedLogin. But I don't know whose machines those are! An extra log line to give the attempted username would help. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Jun 5 01:01:10 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 4 Jun 2011 18:01:10 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] c33a11: make tests not depend on gc behavior Message-ID: <20110605010110.48F79425B7@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: c33a11aed2d2a23535065234e6372fb30cbe3f0c https://github.com/buildbot/buildbot/commit/c33a11aed2d2a23535065234e6372fb30cbe3f0c Author: Dustin J. Mitchell Date: 2011-06-04 (Sat, 04 Jun 2011) Changed paths: M master/buildbot/test/unit/test_process_metrics.py Log Message: ----------- make tests not depend on gc behavior Commit: 3c7db36b785ad04300b9afad60d81b57afdc6d7c https://github.com/buildbot/buildbot/commit/3c7db36b785ad04300b9afad60d81b57afdc6d7c Author: Dustin J. Mitchell Date: 2011-06-04 (Sat, 04 Jun 2011) Changed paths: M master/docs/cfg-global.texinfo Log Message: ----------- update manhole docs Compare: https://github.com/buildbot/buildbot/compare/a5a7286...3c7db36 From nobody at buildbot.net Sun Jun 5 01:23:41 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 05 Jun 2011 01:23:41 -0000 Subject: [Buildbot-commits] [Buildbot] #1979: maybeStartBuild not called often enough Message-ID: <038.5b57ba9dc5654c7b945f11f7c5f539ac@buildbot.net> #1979: maybeStartBuild not called often enough --------------------+---------------------- Reporter: dustin | Owner: dustin Type: defect | Status: new Priority: blocker | Milestone: 0.8.4 Version: master | Keywords: database --------------------+---------------------- The metabuildbot is showing builders in an "idle, plus 1" state, when they have connected, idle slaves. Calling the builder's maybeStartBuild in this state will cause a build to begin. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Jun 5 01:31:02 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 4 Jun 2011 18:31:02 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 8d0b86: Include username in the master's log when sending ... Message-ID: <20110605013102.EC34B425D3@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 8d0b86847b858e2b50ddc77cdea608174f0238f0 https://github.com/buildbot/buildbot/commit/8d0b86847b858e2b50ddc77cdea608174f0238f0 Author: Dustin J. Mitchell Date: 2011-06-04 (Sat, 04 Jun 2011) Changed paths: M master/buildbot/pbmanager.py Log Message: ----------- Include username in the master's log when sending UnauthorizedLogin Fixes #1978. It'd be useful to know the password in many cases, too, but I'm not sure that's a smart thing to commit. From nobody at buildbot.net Sun Jun 5 01:31:08 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 05 Jun 2011 01:31:08 -0000 Subject: [Buildbot-commits] [Buildbot] #1978: print hostname on master when sending UnauthorizedLogin In-Reply-To: <038.dc03be6e23b548c0aca3701f11b7ee29@buildbot.net> References: <038.dc03be6e23b548c0aca3701f11b7ee29@buildbot.net> Message-ID: <053.a3157d31ac303611d467baeaf9fc4391@buildbot.net> #1978: print hostname on master when sending UnauthorizedLogin ------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: trivial | Milestone: 0.8.4 Version: master | Resolution: fixed Keywords: simple | ------------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Include username in the master's log when sending UnauthorizedLogin Fixes #1978. It'd be useful to know the password in many cases, too, but I'm not sure that's a smart thing to commit. Changeset: 8d0b86847b858e2b50ddc77cdea608174f0238f0 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jun 5 02:03:43 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 05 Jun 2011 02:03:43 -0000 Subject: [Buildbot-commits] [Buildbot] #1980: updateBigStatus not called enough? Message-ID: <038.4985705335d7247968eef968f1dad004@buildbot.net> #1980: updateBigStatus not called enough? --------------------+---------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: blocker | Milestone: 0.8.4 Version: master | Keywords: database --------------------+---------------------- I'm looking at the metabuildbot's builders right now, and it says every builder is offline - yet all of the buildslaves are online. Also, os-win7 says it's building in the builders page, but on the builder (singular) page, it does not appear to be building anything. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jun 5 02:07:36 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 05 Jun 2011 02:07:36 -0000 Subject: [Buildbot-commits] [Buildbot] #1980: updateBigStatus not called enough? In-Reply-To: <038.4985705335d7247968eef968f1dad004@buildbot.net> References: <038.4985705335d7247968eef968f1dad004@buildbot.net> Message-ID: <053.c68048152651b592b400b0e88206822b@buildbot.net> #1980: updateBigStatus not called enough? ---------------------+-------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: blocker | Milestone: 0.8.4 Version: master | Resolution: Keywords: database | ---------------------+-------------------- Comment (by dustin): calling updateBigStatus via manhole is enough to synchronize the state. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jun 5 02:15:52 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 05 Jun 2011 02:15:52 -0000 Subject: [Buildbot-commits] [Buildbot] #1979: maybeStartBuild not called often enough In-Reply-To: <038.5b57ba9dc5654c7b945f11f7c5f539ac@buildbot.net> References: <038.5b57ba9dc5654c7b945f11f7c5f539ac@buildbot.net> Message-ID: <053.2f632c28f2f41fe9927e0581231d98e1@buildbot.net> #1979: maybeStartBuild not called often enough ---------------------+--------------------- Reporter: dustin | Owner: dustin Type: defect | Status: new Priority: blocker | Milestone: 0.8.4 Version: master | Resolution: Keywords: database | ---------------------+--------------------- Comment (by dustin): It looks like this is caused by the !BuildRequestDispatcher not adequately locking things: {{{ 2011-06-05 04:10:24+0200 [-] mSBO ['slave-minime'] 2011-06-05 04:10:24+0200 [-] mSBO ['slave-freebsd_7'] 2011-06-05 04:10:24+0200 [-] mSBO ['py27-tw1020'] 2011-06-05 04:10:24+0200 [-] mSBO ['py27-tw1100'] 2011-06-05 04:10:24+0200 [-] mSBO ['os-win7'] 2011-06-05 04:10:24+0200 [-] mSBO ['py24-tw1100'] 2011-06-05 04:10:24+0200 [-] mSBO ['py27-sa060'] 2011-06-05 04:10:24+0200 [-] mSBO ['py26-tw1100'] 2011-06-05 04:10:24+0200 [-] mSBO ['py26-tw0810'] 2011-06-05 04:10:24+0200 [-] mSBO ['py27-tw0810'] 2011-06-05 04:10:24+0200 [-] mSBO ['db-postgres'] 2011-06-05 04:10:24+0200 [-] mSBO ['slave-minimata'] 2011-06-05 04:10:24+0200 [-] mSBO ['slave-ubuntu810-64'] 2011-06-05 04:10:24+0200 [-] mSBO ['py25-tw0820'] 2011-06-05 04:10:24+0200 [-] mSBO ['py24-tw1020'] 2011-06-05 04:10:24+0200 [-] mSBO ['py25-tw0900'] 2011-06-05 04:10:24+0200 [-] mSBO ['py27-sa066'] 2011-06-05 04:10:24+0200 [-] mSBO ['slave-xp-cygwin-1.7'] 2011-06-05 04:10:24+0200 [-] mSBO ['py25-tw1020'] 2011-06-05 04:10:24+0200 [-] mSBO ['py24-tw0820'] 2011-06-05 04:10:24+0200 [-] mSBO ['py24-tw0810'] 2011-06-05 04:10:24+0200 [-] mSBO ['py27-sa070'] 2011-06-05 04:10:24+0200 [-] mSBO ['docs'] 2011-06-05 04:10:24+0200 [-] mSBO ['slave-centos_5_python2_4'] 2011-06-05 04:10:24+0200 [-] mSBO ['os-leopard'] 2011-06-05 04:10:24+0200 [-] mSBO ['py25-tw1100'] 2011-06-05 04:10:24+0200 [-] mSBO ['py27-tw0900'] 2011-06-05 04:10:24+0200 [-] mSBO ['linty'] 2011-06-05 04:10:24+0200 [-] mSBO ['py26-tw0900'] 2011-06-05 04:10:24+0200 [-] mSBO ['coverage'] 2011-06-05 04:10:24+0200 [-] mSBO ['py26-tw0820'] 2011-06-05 04:10:24+0200 [-] mSBO ['py27-tw0820'] 2011-06-05 04:10:24+0200 [-] mSBO ['py24-tw0900'] 2011-06-05 04:10:24+0200 [-] mSBO ['py26-tw1020'] 2011-06-05 04:10:24+0200 [-] mSBO ['py25-tw0810'] 2011-06-05 04:10:24+0200 [-] mSBO ['db-mysql'] 2011-06-05 04:10:24+0200 [-] mSBO ['os-winxp'] 2011-06-05 04:10:24+0200 [-] mSBO - loop; pending_builders = ['slave- minime'] 2011-06-05 04:10:24+0200 [-] mSBO - loop; calling mSB for slave-minime 2011-06-05 04:10:24+0200 [-] mSB - slave-minime 2011-06-05 04:10:24+0200 [-] mSBO - adding; pending_builders = [] 2011-06-05 04:10:24+0200 [-] mSB - slave-minime => loop (-, -) 2011-06-05 04:10:24+0200 [-] mSB - slave-minime => loop (minime, _) 2011-06-05 04:10:24+0200 [-] mSB - slave-minime => loop (minime, {'complete_at': None, 'submitted_at': datetime.datetime(2011, 6, 5, 2, 10, 24, 483381, tzinfo=), 'buildername': u'slave-minime', 'claimed_at': None, 'mine': False, 'results': -1, 'priority': 0, 'complete': False, 'claimed': False, 'brid': 21551, 'buildsetid': 1316}) 2011-06-05 04:10:24+0200 [-] mSBO - adding; pending_builders = ['slave- freebsd_7'] 2011-06-05 04:10:24+0200 [-] mSBO - adding; pending_builders = ['py27-tw1020'] 2011-06-05 04:10:24+0200 [-] mSBO - adding; pending_builders = ['py27-tw1100'] 2011-06-05 04:10:24+0200 [-] mSBO - adding; pending_builders = ['os-win7'] 2011-06-05 04:10:24+0200 [-] mSBO - adding; pending_builders = ['py24-tw1100'] 2011-06-05 04:10:24+0200 [-] mSBO - adding; pending_builders = ['py27-sa060'] 2011-06-05 04:10:24+0200 [-] mSBO - adding; pending_builders = ['py26-tw1100'] 2011-06-05 04:10:24+0200 [-] mSBO - adding; pending_builders = ['py26-tw0810'] 2011-06-05 04:10:24+0200 [-] mSBO - adding; pending_builders = ['py27-tw0810'] 2011-06-05 04:10:24+0200 [-] mSBO - adding; pending_builders = ['db- postgres'] 2011-06-05 04:10:24+0200 [-] mSBO - adding; pending_builders = ['slave- minimata'] 2011-06-05 04:10:24+0200 [-] mSB - slave-minime => loop (claimed) 2011-06-05 04:10:25+0200 [-] mSB - slave-minime => loop (started) 2011-06-05 04:10:25+0200 [-] mSB - slave-minime => loop DONE 2011-06-05 04:10:25+0200 [-] mSBO - loop; pending_builders = ['slave- minimata'] 2011-06-05 04:10:25+0200 [-] mSBO - loop; calling mSB for slave-minimata 2011-06-05 04:10:25+0200 [-] mSB - slave-minimata 2011-06-05 04:10:25+0200 [-] mSBO - adding; pending_builders = ['slave- ubuntu810-64'] 2011-06-05 04:10:25+0200 [-] mSB - slave-minimata => loop (-, -) 2011-06-05 04:10:25+0200 [-] mSB - slave-minimata => loop (minimata, _) 2011-06-05 04:10:25+0200 [-] mSB - slave-minimata => loop (minimata, {'complete_at': None, 'submitted_at': datetime.datetime(2011, 6, 5, 2, 10, 24, 483381, tzinfo=), 'buildername': u'slave-minimata', 'claimed_at': None, 'mine': False, 'results': -1, 'priority': 0, 'complete': False, 'claimed': False, 'brid': 21553, 'buildsetid': 1316}) 2011-06-05 04:10:25+0200 [-] mSBO - adding; pending_builders = ['py25-tw0820'] 2011-06-05 04:10:25+0200 [-] mSBO - adding; pending_builders = ['py24-tw1020'] 2011-06-05 04:10:25+0200 [-] mSBO - adding; pending_builders = ['py25-tw0900'] 2011-06-05 04:10:25+0200 [-] mSBO - adding; pending_builders = ['py27-sa066'] 2011-06-05 04:10:25+0200 [-] mSBO - adding; pending_builders = ['slave-xp- cygwin-1.7'] 2011-06-05 04:10:25+0200 [-] mSBO - adding; pending_builders = ['py25-tw1020'] 2011-06-05 04:10:25+0200 [-] mSBO - adding; pending_builders = ['py24-tw0820'] 2011-06-05 04:10:25+0200 [-] mSBO - adding; pending_builders = ['py24-tw0810'] 2011-06-05 04:10:25+0200 [-] mSBO - adding; pending_builders = ['py27-sa070'] 2011-06-05 04:10:25+0200 [-] mSBO - adding; pending_builders = ['docs'] 2011-06-05 04:10:25+0200 [-] mSBO - adding; pending_builders = ['slave- centos_5_python2_4'] 2011-06-05 04:10:25+0200 [-] mSBO - adding; pending_builders = ['os- leopard'] 2011-06-05 04:10:25+0200 [-] mSB - slave-minimata => loop (claimed) 2011-06-05 04:10:25+0200 [-] mSB - slave-minimata => loop (started) 2011-06-05 04:10:25+0200 [-] mSB - slave-minimata => loop DONE 2011-06-05 04:10:25+0200 [-] mSBO - loop; pending_builders = ['os- leopard'] 2011-06-05 04:10:25+0200 [-] mSBO - loop; calling mSB for os-leopard 2011-06-05 04:10:25+0200 [-] mSB - os-leopard 2011-06-05 04:10:25+0200 [-] mSBO - adding; pending_builders = ['py25-tw1100'] 2011-06-05 04:10:25+0200 [-] mSB - os-leopard => loop (-, -) 2011-06-05 04:10:25+0200 [-] mSB - os-leopard => loop (cm-bbot- leopard-001, _) 2011-06-05 04:10:25+0200 [-] mSB - os-leopard => loop (cm-bbot- leopard-001, {'complete_at': None, 'submitted_at': datetime.datetime(2011, 6, 5, 2, 10, 24, 483381, tzinfo=), 'buildername': u'os-leopard', 'claimed_at': None, 'mine': False, 'results': -1, 'priority': 0, 'complete': False, 'claimed': False, 'brid': 21557, 'buildsetid': 1316}) 2011-06-05 04:10:25+0200 [-] mSBO - adding; pending_builders = ['py27-tw0900'] 2011-06-05 04:10:25+0200 [-] mSBO - adding; pending_builders = ['linty'] 2011-06-05 04:10:25+0200 [-] mSBO - adding; pending_builders = ['py26-tw0900'] 2011-06-05 04:10:25+0200 [-] mSBO - adding; pending_builders = ['coverage'] 2011-06-05 04:10:25+0200 [-] mSBO - adding; pending_builders = ['py26-tw0820'] 2011-06-05 04:10:25+0200 [-] mSBO - adding; pending_builders = ['py27-tw0820'] 2011-06-05 04:10:25+0200 [-] mSBO - adding; pending_builders = ['py24-tw0900'] 2011-06-05 04:10:25+0200 [-] mSBO - adding; pending_builders = ['py26-tw1020'] 2011-06-05 04:10:25+0200 [-] mSB - os-leopard => loop (claimed) 2011-06-05 04:10:25+0200 [-] mSBO - adding; pending_builders = ['py25-tw0810'] 2011-06-05 04:10:25+0200 [-] mSB - os-leopard => loop (started) 2011-06-05 04:10:25+0200 [-] mSB - os-leopard => loop DONE 2011-06-05 04:10:25+0200 [-] mSBO - loop; pending_builders = ['py25-tw0810'] }}} -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Jun 5 04:23:49 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 4 Jun 2011 21:23:49 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 04c98f: pass a workdir in the GitPoller example Message-ID: <20110605042349.623F542566@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 04c98f6b8e253ff103dc49e0a5fc69c298548cf7 https://github.com/buildbot/buildbot/commit/04c98f6b8e253ff103dc49e0a5fc69c298548cf7 Author: Dustin J. Mitchell Date: 2011-06-04 (Sat, 04 Jun 2011) Changed paths: M master/docs/cfg-changesources.texinfo Log Message: ----------- pass a workdir in the GitPoller example Commit: 92d210c50f8019507a356f5caa3b29ca845faea3 https://github.com/buildbot/buildbot/commit/92d210c50f8019507a356f5caa3b29ca845faea3 Author: Dustin J. Mitchell Date: 2011-06-04 (Sat, 04 Jun 2011) Changed paths: M master/buildbot/process/builder.py Log Message: ----------- bail early if no unclaimed buildRequests are available Commit: c892a85b9b8b11a4841788828b88248e447e7f79 https://github.com/buildbot/buildbot/commit/c892a85b9b8b11a4841788828b88248e447e7f79 Author: Dustin J. Mitchell Date: 2011-06-04 (Sat, 04 Jun 2011) Changed paths: M master/buildbot/process/builder.py Log Message: ----------- call bldr.updateBigStatus more often This should fix "stale" status appearing in various status displays - Fixes #1980. Commit: 692dfceea280690c6d0d4236032585e70bdba721 https://github.com/buildbot/buildbot/commit/692dfceea280690c6d0d4236032585e70bdba721 Author: Dustin J. Mitchell Date: 2011-06-04 (Sat, 04 Jun 2011) Changed paths: M master/buildbot/process/botmaster.py M master/buildbot/test/unit/test_process_botmaster_BuildRequestDistributor.py Log Message: ----------- fix locking in BuildRequestDistributor Previous locking was incorrect, as shown by a new test. The tests are a bit unreliable because the _quiet method is not a very good way of determining that the entire test is finished - if there are outstanding DeferredCalls, it will terminate early. But this works for now. Compare: https://github.com/buildbot/buildbot/compare/8d0b868...692dfce From nobody at buildbot.net Sun Jun 5 04:23:57 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 05 Jun 2011 04:23:57 -0000 Subject: [Buildbot-commits] [Buildbot] #1980: updateBigStatus not called enough? In-Reply-To: <038.4985705335d7247968eef968f1dad004@buildbot.net> References: <038.4985705335d7247968eef968f1dad004@buildbot.net> Message-ID: <053.a2ef910f75b6481edb556cb8681b7aff@buildbot.net> #1980: updateBigStatus not called enough? ---------------------+--------------------- Reporter: dustin | Owner: Type: defect | Status: closed Priority: blocker | Milestone: 0.8.4 Version: master | Resolution: fixed Keywords: database | ---------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: call bldr.updateBigStatus more often This should fix "stale" status appearing in various status displays - Fixes #1980. Changeset: c892a85b9b8b11a4841788828b88248e447e7f79 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jun 5 04:25:06 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 05 Jun 2011 04:25:06 -0000 Subject: [Buildbot-commits] [Buildbot] #1979: maybeStartBuild not called often enough In-Reply-To: <038.5b57ba9dc5654c7b945f11f7c5f539ac@buildbot.net> References: <038.5b57ba9dc5654c7b945f11f7c5f539ac@buildbot.net> Message-ID: <053.b8bab06141cc2cd0629998febb22fcda@buildbot.net> #1979: maybeStartBuild not called often enough ---------------------+--------------------- Reporter: dustin | Owner: dustin Type: defect | Status: new Priority: blocker | Milestone: 0.8.4 Version: master | Resolution: Keywords: database | ---------------------+--------------------- Comment (by dustin): The !BuildRequestDistributor was just in bad shape. Should be fixed in [692dfceea280690c6d0d4236032585e70bdba721]. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jun 5 04:30:34 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 05 Jun 2011 04:30:34 -0000 Subject: [Buildbot-commits] [Buildbot] #1979: maybeStartBuild not called often enough In-Reply-To: <038.5b57ba9dc5654c7b945f11f7c5f539ac@buildbot.net> References: <038.5b57ba9dc5654c7b945f11f7c5f539ac@buildbot.net> Message-ID: <053.6aeddb12cf956c98af7a6926c67f9afb@buildbot.net> #1979: maybeStartBuild not called often enough ---------------------+--------------------- Reporter: dustin | Owner: dustin Type: defect | Status: closed Priority: blocker | Milestone: 0.8.4 Version: master | Resolution: fixed Keywords: database | ---------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: Yes, that seems to have fixed it. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jun 5 04:36:30 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 05 Jun 2011 04:36:30 -0000 Subject: [Buildbot-commits] [Buildbot] #1981: default configuration (sample.cfg) uses branch=None Message-ID: <038.22b8b923d6860fe95c8c35fc64764cda@buildbot.net> #1981: default configuration (sample.cfg) uses branch=None -------------------+------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.4 Version: master | Keywords: -------------------+------------------- In #1773 we want to get rid of default branches, yet the default configuration uses one. That's just wrong! The tutorial, too, may use a default branch. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Jun 5 04:50:30 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 4 Jun 2011 21:50:30 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 15a2f0: print more useful things when a change is added to... Message-ID: <20110605045030.B01AF42599@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 15a2f02e3d9dcd0fc849465d1f95f911e1285abe https://github.com/buildbot/buildbot/commit/15a2f02e3d9dcd0fc849465d1f95f911e1285abe Author: Dustin J. Mitchell Date: 2011-06-04 (Sat, 04 Jun 2011) Changed paths: M master/buildbot/changes/changes.py Log Message: ----------- print more useful things when a change is added to the db Commit: 2bd1380b775f529ef4894b9e78e7328234190e02 https://github.com/buildbot/buildbot/commit/2bd1380b775f529ef4894b9e78e7328234190e02 Author: Dustin J. Mitchell Date: 2011-06-04 (Sat, 04 Jun 2011) Changed paths: M master/buildbot/scripts/sample.cfg Log Message: ----------- update sample.cfg to something that works Mostly, don't use branch=None on the Scheduler, which misses changes with branch="master" (Fixes #1981). But also, use the new SingleBranchScheduler name. Compare: https://github.com/buildbot/buildbot/compare/692dfce...2bd1380 From nobody at buildbot.net Sun Jun 5 04:50:36 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 05 Jun 2011 04:50:36 -0000 Subject: [Buildbot-commits] [Buildbot] #1981: default configuration (sample.cfg) uses branch=None In-Reply-To: <038.22b8b923d6860fe95c8c35fc64764cda@buildbot.net> References: <038.22b8b923d6860fe95c8c35fc64764cda@buildbot.net> Message-ID: <053.0576ee3182aff21ccac8b189e4ecd3d0@buildbot.net> #1981: default configuration (sample.cfg) uses branch=None -------------------+--------------------- Reporter: dustin | Owner: Type: defect | Status: closed Priority: minor | Milestone: 0.8.4 Version: master | Resolution: fixed Keywords: | -------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: update sample.cfg to something that works Mostly, don't use branch=None on the Scheduler, which misses changes with branch="master" (Fixes #1981). But also, use the new SingleBranchScheduler name. Changeset: 2bd1380b775f529ef4894b9e78e7328234190e02 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jun 5 04:51:06 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 05 Jun 2011 04:51:06 -0000 Subject: [Buildbot-commits] [Buildbot] #1977: transitions between working / broken not computed per-branch In-Reply-To: <041.02daa6178728651fb513ff2c7280e668@buildbot.net> References: <041.02daa6178728651fb513ff2c7280e668@buildbot.net> Message-ID: <056.8f01c78eeb06282227f71e2ee2ec5094@buildbot.net> #1977: transitions between working / broken not computed per-branch ----------------------+-------------------- Reporter: dabrahams | Owner: Type: defect | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.3p1 | Resolution: Keywords: database | ----------------------+-------------------- Changes (by dustin): * keywords: status => database * milestone: undecided => 0.9.+ Comment: This kind of historical analysis is currently extremely difficult, since the data is buried in pickles. When we have builds in the db, this will be much easier. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jun 5 04:52:05 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 05 Jun 2011 04:52:05 -0000 Subject: [Buildbot-commits] [Buildbot] #76: add mercurial RSS poller change source In-Reply-To: <045.fc42a2ae1dbf5132f47e73265343ba32@buildbot.net> References: <045.fc42a2ae1dbf5132f47e73265343ba32@buildbot.net> Message-ID: <060.25911a076bdbb1e3b8bc78757963a9de@buildbot.net> #76: add mercurial RSS poller change source --------------------------+--------------------- Reporter: TedMielczarek | Owner: warner Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.7.5 | Resolution: Keywords: hg | --------------------------+--------------------- Comment (by dustin): Ted, ben, any chance this is still going to happen, or should we close this as wontfix? -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Jun 5 05:27:50 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 4 Jun 2011 22:27:50 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 21a612: Add moveToCurDir to MaildirService, call it, and t... Message-ID: <20110605052750.2CAAD425A0@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 21a61291b4a780941c78dc4fdcc632a5612eccee https://github.com/buildbot/buildbot/commit/21a61291b4a780941c78dc4fdcc632a5612eccee Author: Dustin J. Mitchell Date: 2011-06-04 (Sat, 04 Jun 2011) Changed paths: M master/buildbot/changes/mail.py M master/buildbot/schedulers/trysched.py M master/buildbot/test/unit/test_util_maildir.py M master/buildbot/util/maildir.py Log Message: ----------- Add moveToCurDir to MaildirService, call it, and test it Fixes #1819. From nobody at buildbot.net Sun Jun 5 05:27:55 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 05 Jun 2011 05:27:55 -0000 Subject: [Buildbot-commits] [Buildbot] #1819: MailDirService should handle renaming files, rather than subclasses In-Reply-To: <038.b654d701e23765a7d909f3ce73410d09@buildbot.net> References: <038.b654d701e23765a7d909f3ce73410d09@buildbot.net> Message-ID: <053.b95d192c07dc9e149623763fa69c82c6@buildbot.net> #1819: MailDirService should handle renaming files, rather than subclasses ------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: 0.8.4 Version: master | Resolution: fixed Keywords: | ------------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Add moveToCurDir to MaildirService, call it, and test it Fixes #1819. Changeset: 21a61291b4a780941c78dc4fdcc632a5612eccee -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Jun 6 14:54:40 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 6 Jun 2011 07:54:40 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 331a42: Fix typo that prevents upgrading existing master Message-ID: <20110606145440.327AC4248A@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 331a4291f2d8410b8917c14e2a25eb4a026044dd https://github.com/buildbot/buildbot/commit/331a4291f2d8410b8917c14e2a25eb4a026044dd Author: Dmitry Nezhevenko Date: 2011-06-06 (Mon, 06 Jun 2011) Changed paths: M master/buildbot/scripts/runner.py Log Message: ----------- Fix typo that prevents upgrading existing master Commit: 9b5368ec70c009a88c6353cac7e9375eed11c106 https://github.com/buildbot/buildbot/commit/9b5368ec70c009a88c6353cac7e9375eed11c106 Author: Dustin J. Mitchell Date: 2011-06-06 (Mon, 06 Jun 2011) Changed paths: M master/buildbot/scripts/runner.py Log Message: ----------- Merge pull request #146 from dionorgua/quickfix Fix typo that prevents upgrading existing master Compare: https://github.com/buildbot/buildbot/compare/21a6129...9b5368e From nobody at buildbot.net Tue Jun 7 06:34:53 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 07 Jun 2011 06:34:53 -0000 Subject: [Buildbot-commits] [Buildbot] #1685: build properties support in IRC bot In-Reply-To: <036.284a346d8cdf7ba69b3302921f831dc0@buildbot.net> References: <036.284a346d8cdf7ba69b3302921f831dc0@buildbot.net> Message-ID: <051.bfecfea1bd813252a0842031568911ec@buildbot.net> #1685: build properties support in IRC bot -------------------------------+-------------------- Reporter: strk | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.2 | Resolution: Keywords: irc, redheadphones | -------------------------------+-------------------- Changes (by redheadphones): * keywords: irc => irc, redheadphones -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jun 7 06:35:12 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 07 Jun 2011 06:35:12 -0000 Subject: [Buildbot-commits] [Buildbot] #998: git_buildbot.py ignores tags In-Reply-To: <036.92225bad6a92f142c6531bf660f7d90a@buildbot.net> References: <036.92225bad6a92f142c6531bf660f7d90a@buildbot.net> Message-ID: <051.d3ac6ef0a8deb41c6d989d47585a9435@buildbot.net> #998: git_buildbot.py ignores tags -------------------------------+-------------------- Reporter: chrb | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.1 | Resolution: Keywords: git, redheadphones | -------------------------------+-------------------- Changes (by redheadphones): * keywords: git => git, redheadphones -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jun 7 06:35:30 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 07 Jun 2011 06:35:30 -0000 Subject: [Buildbot-commits] [Buildbot] #896: Try should capture and send e-mail address of the submitter so that notifications can be sent In-Reply-To: <039.dd16e9ce5631939f93c8f0c0bcaebc2b@buildbot.net> References: <039.dd16e9ce5631939f93c8f0c0bcaebc2b@buildbot.net> Message-ID: <054.9344ec069c9806cee08f439764d43813@buildbot.net> #896: Try should capture and send e-mail address of the submitter so that notifications can be sent -------------------------------+-------------------- Reporter: marcusl | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.8.0 | Resolution: Keywords: try, redheadphones | -------------------------------+-------------------- Changes (by redheadphones): * keywords: try => try, redheadphones -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jun 7 06:35:42 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 07 Jun 2011 06:35:42 -0000 Subject: [Buildbot-commits] [Buildbot] #806: Need branch name display In-Reply-To: <041.0b6e5b0e15b3da9bf4fde730b1cd2597@buildbot.net> References: <041.0b6e5b0e15b3da9bf4fde730b1cd2597@buildbot.net> Message-ID: <056.376fddbb28f59df7bf5aeca571ee28ab@buildbot.net> #806: Need branch name display -------------------------------+-------------------- Reporter: dabrahams | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.7.12 | Resolution: Keywords: web, redheadphones | -------------------------------+-------------------- Changes (by redheadphones): * keywords: web => web, redheadphones -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jun 7 06:38:04 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 07 Jun 2011 06:38:04 -0000 Subject: [Buildbot-commits] [Buildbot] #75: IM status targets In-Reply-To: <038.077cde644a25b8ae82acb2a21287d86e@buildbot.net> References: <038.077cde644a25b8ae82acb2a21287d86e@buildbot.net> Message-ID: <053.9a174d8e69a42f5b33a9ca45a15b8017@buildbot.net> #75: IM status targets --------------------------+--------------------- Reporter: warner | Owner: warner Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.7.5 | Resolution: Keywords: redheadphones | --------------------------+--------------------- Changes (by redheadphones): * keywords: => redheadphones -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jun 7 06:38:11 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 07 Jun 2011 06:38:11 -0000 Subject: [Buildbot-commits] [Buildbot] #1850: Possibility to display the branch of the changes in the changes waterfall column In-Reply-To: <040.126db59196919bc45475d560861b1e4b@buildbot.net> References: <040.126db59196919bc45475d560861b1e4b@buildbot.net> Message-ID: <055.4ad5ca5337e5652264500510dcabeddd@buildbot.net> #1850: Possibility to display the branch of the changes in the changes waterfall column -------------------------------+-------------------- Reporter: ykoehler | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.3 | Resolution: Keywords: web, redheadphones | -------------------------------+-------------------- Changes (by redheadphones): * keywords: web => web, redheadphones -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jun 7 06:35:59 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 07 Jun 2011 06:35:59 -0000 Subject: [Buildbot-commits] [Buildbot] #571: MailNotifier to send emails on build exceptions In-Reply-To: <037.06f30f4c940adcd363cfd1cef03c419c@buildbot.net> References: <037.06f30f4c940adcd363cfd1cef03c419c@buildbot.net> Message-ID: <052.5ac6e0725d221b48192a70f910e697b1@buildbot.net> #571: MailNotifier to send emails on build exceptions --------------------------------+--------------------- Reporter: toddw | Owner: warner Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.7.10 | Resolution: Keywords: mail, redheadphones | --------------------------------+--------------------- Changes (by redheadphones): * keywords: mail => mail, redheadphones -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jun 7 06:38:34 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 07 Jun 2011 06:38:34 -0000 Subject: [Buildbot-commits] [Buildbot] #1849: Possibility to display either the Project or Branch being build in the waterfall display In-Reply-To: <040.afccff6d7759f7ed17044cc1186378be@buildbot.net> References: <040.afccff6d7759f7ed17044cc1186378be@buildbot.net> Message-ID: <055.20f080a6ce1286b302c1423b381c781d@buildbot.net> #1849: Possibility to display either the Project or Branch being build in the waterfall display -------------------------------+-------------------- Reporter: ykoehler | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.3 | Resolution: Keywords: web, redheadphones | -------------------------------+-------------------- Changes (by redheadphones): * keywords: web => web, redheadphones -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jun 7 06:38:46 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 07 Jun 2011 06:38:46 -0000 Subject: [Buildbot-commits] [Buildbot] #1970: IRC status notifier is reconnecting too fast In-Reply-To: <037.f93a33de7d321ac6aed00eaf68e15f66@buildbot.net> References: <037.f93a33de7d321ac6aed00eaf68e15f66@buildbot.net> Message-ID: <052.a6ddaef47c22e53aa97428c0d3b03b12@buildbot.net> #1970: IRC status notifier is reconnecting too fast --------------------------+------------------------ Reporter: Almad | Owner: Type: enhancement | Status: new Priority: major | Milestone: undecided Version: 0.8.0 | Resolution: Keywords: redheadphones | --------------------------+------------------------ Changes (by redheadphones): * keywords: => redheadphones -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Fri Jun 10 15:21:04 2011 From: noreply at github.com (noreply at github.com) Date: Fri, 10 Jun 2011 08:21:04 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 0edfba: Update master/contrib/buildbot_json.py to v1.1 Message-ID: <20110610152104.8043942596@smtp1.rs.github.com> Branch: refs/heads/buildbot_json Home: https://github.com/buildbot/buildbot Commit: 0edfba7d544c6e245cd4d46c545af8af065c14ac https://github.com/buildbot/buildbot/commit/0edfba7d544c6e245cd4d46c545af8af065c14ac Author: Marc-Antoine Ruel Date: 2011-06-10 (Fri, 10 Jun 2011) Changed paths: M master/contrib/buildbot_json.py Log Message: ----------- Update master/contrib/buildbot_json.py to v1.1 From noreply at github.com Fri Jun 10 15:21:58 2011 From: noreply at github.com (noreply at github.com) Date: Fri, 10 Jun 2011 08:21:58 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 0edfba: Update master/contrib/buildbot_json.py to v1.1 Message-ID: <20110610152158.3560342564@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 0edfba7d544c6e245cd4d46c545af8af065c14ac https://github.com/buildbot/buildbot/commit/0edfba7d544c6e245cd4d46c545af8af065c14ac Author: Marc-Antoine Ruel Date: 2011-06-10 (Fri, 10 Jun 2011) Changed paths: M master/contrib/buildbot_json.py Log Message: ----------- Update master/contrib/buildbot_json.py to v1.1 From nobody at buildbot.net Fri Jun 10 17:39:45 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 10 Jun 2011 17:39:45 -0000 Subject: [Buildbot-commits] [Buildbot] #1982: handle UnauthorizedLogin exceptions on the slave Message-ID: <038.49b407b112985b94d46c112a32adfa15@buildbot.net> #1982: handle UnauthorizedLogin exceptions on the slave ------------------------+------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.3p1 | Keywords: ------------------------+------------------- Right now, these are unhandled failures and cause the slave to stop re- trying. They should be handled, and the slave should retry using its normal backoff schedule - as often as not, the slave's password is wrong (or missing) on the master, so retrying can help. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Jun 10 18:22:46 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 10 Jun 2011 18:22:46 -0000 Subject: [Buildbot-commits] [Buildbot] #1982: handle UnauthorizedLogin exceptions on the slave In-Reply-To: <038.49b407b112985b94d46c112a32adfa15@buildbot.net> References: <038.49b407b112985b94d46c112a32adfa15@buildbot.net> Message-ID: <053.103b94c84cc45d361e50d02587caa913@buildbot.net> #1982: handle UnauthorizedLogin exceptions on the slave ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.3p1 | Resolution: Keywords: | ------------------------+-------------------- Comment (by dustin): In branch 'bug1982' in my repo - waiting for the 0.8.4 branch to push. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Jun 11 04:18:24 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 11 Jun 2011 04:18:24 -0000 Subject: [Buildbot-commits] [Buildbot] #1976: Git build step fails after SVN step In-Reply-To: <036.3f77dd3bb4bc7a720ea33ca14f012359@buildbot.net> References: <036.3f77dd3bb4bc7a720ea33ca14f012359@buildbot.net> Message-ID: <051.844a2c7d52a8b8540baeec348b4c061f@buildbot.net> #1976: Git build step fails after SVN step --------------------+------------------------- Reporter: karl | Owner: Type: defect | Status: closed Priority: major | Milestone: undecided Version: 0.8.3p1 | Resolution: worksforme Keywords: svn git | --------------------+------------------------- Changes (by dustin): * status: new => closed * resolution: => worksforme Comment: Source steps currently expect to the only such step in the factory, and expect information corresponding to their version control system. Your workaround is actually pretty elegant! -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Jun 11 19:16:13 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 11 Jun 2011 12:16:13 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 320651: clean up pyflakes (one of which was a real bug) Message-ID: <20110611191613.B228A424EC@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 320651e0a18938d95fd9295239c016c862f16f70 https://github.com/buildbot/buildbot/commit/320651e0a18938d95fd9295239c016c862f16f70 Author: Dustin J. Mitchell Date: 2011-06-11 (Sat, 11 Jun 2011) Changed paths: M master/buildbot/process/mtrlogobserver.py M master/buildbot/steps/source.py Log Message: ----------- clean up pyflakes (one of which was a real bug) Commit: b67d40cba82581592ed1720d9bf59f6713d70d2d https://github.com/buildbot/buildbot/commit/b67d40cba82581592ed1720d9bf59f6713d70d2d Author: Dustin J. Mitchell Date: 2011-06-11 (Sat, 11 Jun 2011) Changed paths: M master/buildbot/interfaces.py M master/buildbot/process/build.py M master/buildbot/process/buildstep.py M master/buildbot/process/mtrlogobserver.py M master/buildbot/process/properties.py M master/buildbot/status/mail.py M master/buildbot/status/tinderbox.py M master/buildbot/steps/master.py M master/buildbot/steps/shell.py M master/buildbot/steps/slave.py M master/buildbot/steps/source.py M master/buildbot/steps/transfer.py M master/buildbot/steps/trigger.py M master/buildbot/test/unit/test_process_properties.py M master/buildbot/test/unit/test_steps_source_Source.py Log Message: ----------- Merge branch 'prop' * prop: clean up pyflakes (one of which was a real bug) Move rendering of properties to BuildStep.startStep. Handle Source.computeRepositoryURL as a IRenderable. Clean up rendering of properties, and make it more general. Compare: https://github.com/buildbot/buildbot/compare/0edfba7...b67d40c From noreply at github.com Sat Jun 11 20:52:13 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 11 Jun 2011 13:52:13 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 86f27b: Merge branch 'fix_max_warnings' of git://github.co... Message-ID: <20110611205213.DA41242394@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 86f27ba9e1c7b4a01f2c72a0d15a22a9457821b8 https://github.com/buildbot/buildbot/commit/86f27ba9e1c7b4a01f2c72a0d15a22a9457821b8 Author: Dustin J. Mitchell Date: 2011-06-11 (Sat, 11 Jun 2011) Changed paths: M master/buildbot/steps/shell.py Log Message: ----------- Merge branch 'fix_max_warnings' of git://github.com/aslater/buildbot * 'fix_max_warnings' of git://github.com/aslater/buildbot: Added maxWarnCount to WarningCountingShellCommand's factory arguments From noreply at github.com Sun Jun 12 01:44:59 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 11 Jun 2011 18:44:59 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] fd7892: Document port number in IRC Bot section. Message-ID: <20110612014459.EBC82424BA@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: fd7892c3c90013f73f0a4b0042722d4a52a1b350 https://github.com/buildbot/buildbot/commit/fd7892c3c90013f73f0a4b0042722d4a52a1b350 Author: Pradeepkumar Gayam Date: 2011-06-11 (Sat, 11 Jun 2011) Changed paths: M master/docs/cfg-statustargets.texinfo Log Message: ----------- Document port number in IRC Bot section. Commit: facb3014c02f95925804b9409cbd7f4ceaeac192 https://github.com/buildbot/buildbot/commit/facb3014c02f95925804b9409cbd7f4ceaeac192 Author: Dustin J. Mitchell Date: 2011-06-11 (Sat, 11 Jun 2011) Changed paths: M master/docs/cfg-statustargets.texinfo Log Message: ----------- Merge branch 'master' of git://github.com/in3xes/buildbot * 'master' of git://github.com/in3xes/buildbot: Document port number in IRC Bot section. Compare: https://github.com/buildbot/buildbot/compare/86f27ba...facb301 From noreply at github.com Sun Jun 12 18:02:20 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 12 Jun 2011 11:02:20 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] c92fc6: Update and expand docs on reconfigs Message-ID: <20110612180219.F3E70423B3@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: c92fc6aafe67f571f4cc4b60b6198fd127af4b0a https://github.com/buildbot/buildbot/commit/c92fc6aafe67f571f4cc4b60b6198fd127af4b0a Author: Dustin J. Mitchell Date: 2011-06-12 (Sun, 12 Jun 2011) Changed paths: M master/docs/configuration.texinfo Log Message: ----------- Update and expand docs on reconfigs This points to dabraham's bbproto project, as well. Fixes #1930. From nobody at buildbot.net Sun Jun 12 18:02:32 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 12 Jun 2011 18:02:32 -0000 Subject: [Buildbot-commits] [Buildbot] #1930: Make large-scale modular configurations easier In-Reply-To: <041.b4d8007189866890bd28a11c17337bad@buildbot.net> References: <041.b4d8007189866890bd28a11c17337bad@buildbot.net> Message-ID: <056.5d4bf6da3a53af0bf2c891a10b6a6cfe@buildbot.net> #1930: Make large-scale modular configurations easier ------------------------+--------------------- Reporter: dabrahams | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: fixed Keywords: docs | ------------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Update and expand docs on reconfigs This points to dabraham's bbproto project, as well. Fixes #1930. Changeset: c92fc6aafe67f571f4cc4b60b6198fd127af4b0a -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jun 12 18:15:35 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 12 Jun 2011 18:15:35 -0000 Subject: [Buildbot-commits] [Buildbot] #1853: Honour change filter in build details page (option) In-Reply-To: <042.f730d172cf9bc7d3e7c4f9188ccea493@buildbot.net> References: <042.f730d172cf9bc7d3e7c4f9188ccea493@buildbot.net> Message-ID: <057.7efce1e7673c429c5a115ad07c7e960d@buildbot.net> #1853: Honour change filter in build details page (option) ------------------------+------------------------- Reporter: jollyroger | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.4 Version: 0.8.3p1 | Resolution: worksforme Keywords: | ------------------------+------------------------- Changes (by dustin): * status: new => closed * resolution: => worksforme Comment: I should have read this more closely when the bug was filed. This is normal behavior. You're using fileIsImportant, not a change filter. fileIsImportant just decides whether a particular change needs a build (that is, whether it should start the treeStableTimer countdown). If not, that change is batched up until the next important change. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jun 12 18:21:16 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 12 Jun 2011 18:21:16 -0000 Subject: [Buildbot-commits] [Buildbot] #1823: Verify interaction of Dependent scheduler with retried builds In-Reply-To: <038.9abe79edb4412b68e022bd51a0a2fcf0@buildbot.net> References: <038.9abe79edb4412b68e022bd51a0a2fcf0@buildbot.net> Message-ID: <053.677d5cc86334fb8241a4435313f3f397@buildbot.net> #1823: Verify interaction of Dependent scheduler with retried builds ------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: critical | Milestone: 0.8.4 Version: master | Resolution: fixed Keywords: | ------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: * Dependent works with a regular OK build * when upstream ends with RETRY, no dependent buildset is created * when the upstream build is retried, a dependent build is created So, all good! -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Jun 12 18:27:45 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 12 Jun 2011 11:27:45 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 609b39: mention lazy-reload Message-ID: <20110612182745.4D9854249B@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 609b39f03b3fff6e32ca38bf3f0f8c4e046d9c6e https://github.com/buildbot/buildbot/commit/609b39f03b3fff6e32ca38bf3f0f8c4e046d9c6e Author: Dustin J. Mitchell Date: 2011-06-12 (Sun, 12 Jun 2011) Changed paths: M master/docs/configuration.texinfo Log Message: ----------- mention lazy-reload From noreply at github.com Sun Jun 12 20:41:55 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 12 Jun 2011 13:41:55 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 261593: update 'Next Version' Message-ID: <20110612204155.4C9634224E@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 26159312864ed7aaea4c991347b051f449f6f339 https://github.com/buildbot/buildbot/commit/26159312864ed7aaea4c991347b051f449f6f339 Author: Dustin J. Mitchell Date: 2011-06-12 (Sun, 12 Jun 2011) Changed paths: M master/NEWS M slave/NEWS Log Message: ----------- update 'Next Version' Commit: b0b8528ea04d9d6212a635cb623d6a4d47b810c2 https://github.com/buildbot/buildbot/commit/b0b8528ea04d9d6212a635cb623d6a4d47b810c2 Author: Dustin J. Mitchell Date: 2011-06-12 (Sun, 12 Jun 2011) Changed paths: M master/NEWS M slave/NEWS Log Message: ----------- add 'Next Version' to NEWS Compare: https://github.com/buildbot/buildbot/compare/609b39f...b0b8528 From nobody at buildbot.net Mon Jun 13 16:08:14 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 13 Jun 2011 16:08:14 -0000 Subject: [Buildbot-commits] [Buildbot] #1983: Catch Stale Broker errors on duplicate notification Message-ID: <038.595cf1fa4cb733d4cef5f0375e68dd28@buildbot.net> #1983: Catch Stale Broker errors on duplicate notification -------------------+------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.2 | Keywords: -------------------+------------------- {{{ Traceback from remote host -- Traceback (most recent call last): File "/tools/buildbot-0.8.2/lib/python2.6/site- packages/twisted/spread/pb.py", line 1346, in remote_respond d = self.portal.login(self, mind, IPerspective) File "/tools/buildbot-0.8.2/lib/python2.6/site- packages/twisted/cred/portal.py", line 116, in login ).addCallback(self.realm.requestAvatar, mind, *interfaces File "/tools/buildbot-0.8.2/lib/python2.6/site- packages/twisted/internet/defer.py", line 260, in addCallback callbackKeywords=kw) File "/tools/buildbot-0.8.2/lib/python2.6/site- packages/twisted/internet/defer.py", line 249, in addCallbacks self._runCallbacks() --- --- File "/tools/buildbot-0.8.2/lib/python2.6/site- packages/twisted/internet/defer.py", line 441, in _runCallbacks self.result = callback(self.result, *args, **kw) File "/tools/buildbot-0.8.2/lib/python2.6/site- packages/buildbot-0.8.2_hg_509eed75bf25_production_0.8-py2.6.egg/buildbot/master.py", line 474, in requestAvatar p = self.botmaster.getPerspective(mind, avatarID) File "/tools/buildbot-0.8.2/lib/python2.6/site- packages/buildbot-0.8.2_hg_509eed75bf25_production_0.8-py2.6.egg/buildbot/master.py", line 344, in getPerspective d = sl.slave.callRemote("print", "master got a duplicate connection; keeping this one") File "/tools/buildbot-0.8.2/lib/python2.6/site- packages/twisted/spread/pb.py", line 328, in callRemote _name, args, kw) File "/tools/buildbot-0.8.2/lib/python2.6/site- packages/twisted/spread/pb.py", line 807, in _sendMessage raise DeadReferenceError("Calling Stale Broker") twisted.spread.pb.DeadReferenceError: Calling Stale Broker }}} This is pretty much an indication that we can immediately accept the new slave. I'll need to see if I can replicate this with a more recent master. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Jun 13 17:43:00 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 13 Jun 2011 10:43:00 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] d0d739: Test for mode=update for Mercurial. Message-ID: <20110613174300.B79E34229E@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: d0d739af1cbf45dc74471740583dcef128e88372 https://github.com/buildbot/buildbot/commit/d0d739af1cbf45dc74471740583dcef128e88372 Author: Pradeepkumar Gayam Date: 2011-06-12 (Sun, 12 Jun 2011) Changed paths: M slave/buildslave/test/unit/test_commands_hg.py Log Message: ----------- Test for mode=update for Mercurial. Commit: 31ed23357774b83aa9c8209dfc51cae6155cf7a3 https://github.com/buildbot/buildbot/commit/31ed23357774b83aa9c8209dfc51cae6155cf7a3 Author: Dustin J. Mitchell Date: 2011-06-13 (Mon, 13 Jun 2011) Changed paths: M slave/buildslave/test/unit/test_commands_hg.py Log Message: ----------- Merge branch 'master' of git://github.com/in3xes/buildbot * 'master' of git://github.com/in3xes/buildbot: Test for mode=update for Mercurial. Compare: https://github.com/buildbot/buildbot/compare/b0b8528...31ed233 From noreply at github.com Mon Jun 13 17:44:29 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 13 Jun 2011 10:44:29 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 6d62ed: fixed a few typos found while hacking Message-ID: <20110613174429.B9DBC4229E@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 6d62ed08db2609ea610ea6a2147bec42e08ae642 https://github.com/buildbot/buildbot/commit/6d62ed08db2609ea610ea6a2147bec42e08ae642 Author: Derek Hurley Date: 2011-06-13 (Mon, 13 Jun 2011) Changed paths: M master/buildbot/db/changes.py M master/buildbot/test/fake/fakedb.py M master/docs/cfg-schedulers.texinfo Log Message: ----------- fixed a few typos found while hacking Commit: 97c4c4c7c0be2d94654ac4a21bd8fb7326a6b229 https://github.com/buildbot/buildbot/commit/97c4c4c7c0be2d94654ac4a21bd8fb7326a6b229 Author: Dustin J. Mitchell Date: 2011-06-13 (Mon, 13 Jun 2011) Changed paths: M master/buildbot/db/changes.py M master/buildbot/test/fake/fakedb.py M master/docs/cfg-schedulers.texinfo Log Message: ----------- Merge branch 'some_typos' of git://github.com/dzhurley/buildbot * 'some_typos' of git://github.com/dzhurley/buildbot: fixed a few typos found while hacking Compare: https://github.com/buildbot/buildbot/compare/31ed233...97c4c4c From noreply at github.com Mon Jun 13 22:30:48 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 13 Jun 2011 15:30:48 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] af1441: _update2 will be call later in any case. Avoid cal... Message-ID: <20110613223048.EDAC5420CE@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: af1441591d3dd16ed41e4c848d8dd8958673eee6 https://github.com/buildbot/buildbot/commit/af1441591d3dd16ed41e4c848d8dd8958673eee6 Author: Pradeepkumar Gayam Date: 2011-06-13 (Mon, 13 Jun 2011) Changed paths: M slave/buildslave/commands/hg.py Log Message: ----------- _update2 will be call later in any case. Avoid calling it twice. And remove unused code. Commit: 6f5238605c8999a4b2e67d00d2ae57d6fe265fc0 https://github.com/buildbot/buildbot/commit/6f5238605c8999a4b2e67d00d2ae57d6fe265fc0 Author: Pradeepkumar Gayam Date: 2011-06-13 (Mon, 13 Jun 2011) Changed paths: M slave/buildslave/test/unit/test_commands_hg.py Log Message: ----------- Remove the redundant test. Add couple of more tests to mercurial command on slave. Commit: bb9f2456bd2d77e0474f443025d824086dbf6913 https://github.com/buildbot/buildbot/commit/bb9f2456bd2d77e0474f443025d824086dbf6913 Author: Dustin J. Mitchell Date: 2011-06-13 (Mon, 13 Jun 2011) Changed paths: M slave/buildslave/commands/hg.py M slave/buildslave/test/unit/test_commands_hg.py Log Message: ----------- Merge branch 'test_hg' of git://github.com/in3xes/buildbot * 'test_hg' of git://github.com/in3xes/buildbot: Remove the redundant test. Add couple of more tests to mercurial command on slave. _update2 will be call later in any case. Avoid calling it twice. And remove unused code. Compare: https://github.com/buildbot/buildbot/compare/97c4c4c...bb9f245 From noreply at github.com Tue Jun 14 02:56:49 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 13 Jun 2011 19:56:49 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] c8adb1: Re-added backwards compatibility for older masters Message-ID: <20110614025649.342EF421B8@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: c8adb12a3651d8d3c65a3c2d22d9e59f6f52cf76 https://github.com/buildbot/buildbot/commit/c8adb12a3651d8d3c65a3c2d22d9e59f6f52cf76 Author: aslater Date: 2011-06-13 (Mon, 13 Jun 2011) Changed paths: M master/buildbot/clients/tryclient.py M master/buildbot/db/migrate/versions/009_add_patch_author.py M master/buildbot/db/model.py M master/buildbot/db/sourcestamps.py M master/buildbot/schedulers/trysched.py M master/buildbot/test/unit/test_schedulers_trysched.py Log Message: ----------- Re-added backwards compatibility for older masters Changed default value of patch author and comment to "" rather than None Commit: 2fb8805d276d17de086cd713d6fbfbe7e3852bcb https://github.com/buildbot/buildbot/commit/2fb8805d276d17de086cd713d6fbfbe7e3852bcb Author: aslater Date: 2011-06-13 (Mon, 13 Jun 2011) Changed paths: M master/NEWS M master/buildbot/db/changes.py M master/buildbot/interfaces.py M master/buildbot/process/build.py M master/buildbot/process/buildstep.py M master/buildbot/process/mtrlogobserver.py M master/buildbot/process/properties.py M master/buildbot/scripts/runner.py M master/buildbot/status/mail.py M master/buildbot/status/tinderbox.py M master/buildbot/steps/master.py M master/buildbot/steps/shell.py M master/buildbot/steps/slave.py M master/buildbot/steps/source.py M master/buildbot/steps/transfer.py M master/buildbot/steps/trigger.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/unit/test_process_properties.py M master/buildbot/test/unit/test_steps_source_Source.py M master/contrib/buildbot_json.py M master/docs/cfg-schedulers.texinfo M master/docs/cfg-statustargets.texinfo M master/docs/configuration.texinfo M slave/NEWS M slave/buildslave/commands/hg.py M slave/buildslave/test/unit/test_commands_hg.py Log Message: ----------- Merge remote-tracking branch 'upstream/master' into try_comment Commit: 511556b1cf98b667016691e6bc32ea198282be8e https://github.com/buildbot/buildbot/commit/511556b1cf98b667016691e6bc32ea198282be8e Author: Dustin J. Mitchell Date: 2011-06-13 (Mon, 13 Jun 2011) Changed paths: M master/buildbot/clients/tryclient.py A master/buildbot/db/migrate/versions/009_add_patch_author.py M master/buildbot/db/model.py M master/buildbot/db/sourcestamps.py M master/buildbot/process/build.py M master/buildbot/schedulers/trysched.py M master/buildbot/scripts/runner.py M master/buildbot/sourcestamp.py M master/buildbot/status/mail.py M master/buildbot/test/fake/fakedb.py M master/buildbot/test/regressions/test_shell_command_properties.py M master/buildbot/test/unit/test_db_sourcestamps.py M master/buildbot/test/unit/test_process_build.py M master/buildbot/test/unit/test_schedulers_trysched.py M master/buildbot/test/unit/test_sourcestamp.py M master/docs/cfg-statustargets.texinfo M master/docs/concepts.texinfo M master/docs/cust-changesources.texinfo Log Message: ----------- Merge branch 'try_comment' of git://github.com/aslater/buildbot * 'try_comment' of git://github.com/aslater/buildbot: Re-added backwards compatibility for older masters Changed default value of patch author and comment to "" rather than None Tested try comments Removed debug prints and extraneous code Tested and fixed addition of try user to build blamelists Fixed a DB upgrade issue; runner.py:upgradeMaster explicitly creates a DB connector with master=None, so a master reference in the caching code was causing problems Added documentation Added patch author to interested users list for try builds; still need to add to documentation Add optional warning threshold to warning counting shell commands Commit: 67e5af854db418dd1a27f79c69245a8334779950 https://github.com/buildbot/buildbot/commit/67e5af854db418dd1a27f79c69245a8334779950 Author: Dustin J. Mitchell Date: 2011-06-13 (Mon, 13 Jun 2011) Changed paths: M master/docs/cfg-statustargets.texinfo Log Message: ----------- tabs to spaces in docs Compare: https://github.com/buildbot/buildbot/compare/bb9f245...67e5af8 From nobody at buildbot.net Tue Jun 14 03:15:54 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 14 Jun 2011 03:15:54 -0000 Subject: [Buildbot-commits] [Buildbot] #1983: Catch Stale Broker errors on duplicate notification In-Reply-To: <038.595cf1fa4cb733d4cef5f0375e68dd28@buildbot.net> References: <038.595cf1fa4cb733d4cef5f0375e68dd28@buildbot.net> Message-ID: <053.f924f17c25a475705180ac033a89e9a7@buildbot.net> #1983: Catch Stale Broker errors on duplicate notification -------------------+------------------------- Reporter: dustin | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.5 Version: 0.8.2 | Resolution: worksforme Keywords: | -------------------+------------------------- Changes (by dustin): * status: new => closed * resolution: => worksforme Comment: Whoops, this is part of the old, unreformed !DuplicateSlaveArbitrator. The new version correctly handles this case. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jun 14 04:55:08 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 14 Jun 2011 04:55:08 -0000 Subject: [Buildbot-commits] [Buildbot] #1984: fix RemoteCommand.commandCounter Message-ID: <038.a0bd76349300385273417edb3be02498@buildbot.net> #1984: fix RemoteCommand.commandCounter ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.4 | Keywords: simple ------------------------+-------------------- This is pretty sloppily handled in buildstep.py. No big deal, but needs some cleanup. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Tue Jun 14 13:59:24 2011 From: noreply at github.com (noreply at github.com) Date: Tue, 14 Jun 2011 06:59:24 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] cc69ba: Add a basic test framework for build steps Message-ID: <20110614135924.B971C423B8@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: cc69ba3e438d0d7436eb7e7f52967d59cc9a4284 https://github.com/buildbot/buildbot/commit/cc69ba3e438d0d7436eb7e7f52967d59cc9a4284 Author: Dustin J. Mitchell Date: 2011-06-14 (Tue, 14 Jun 2011) Changed paths: M master/buildbot/process/buildstep.py M master/buildbot/steps/shell.py A master/buildbot/test/fake/remotecommand.py A master/buildbot/test/unit/test_steps_shell.py A master/buildbot/test/util/steps.py Log Message: ----------- Add a basic test framework for build steps This only does a very basic test of ShellCommand, but gets things started. Logs are handled correctly, for steps that expect to be able to read the logged results. From nobody at buildbot.net Wed Jun 15 10:36:10 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 15 Jun 2011 10:36:10 -0000 Subject: [Buildbot-commits] [Buildbot] #1985: AttributeError: Sender instance has no attribute 'stop' Message-ID: <034.c7fa3215a8c9bfcd40264c4761188c7e@buildbot.net> #1985: AttributeError: Sender instance has no attribute 'stop' ----------------------+----------------------- Reporter: kb | Owner: Type: undecided | Status: new Priority: critical | Milestone: undecided Version: 0.8.4 | Keywords: ----------------------+----------------------- Mercurial hook fails with this stack trace: {{{ /usr/local/lib/python2.6/dist- packages/buildbot-0.8.4-py2.6.egg/buildbot/changes/hgbuildbot.pyc in hook(ui, repo, hooktype, node, source, **kwargs) 174 175 d.addCallbacks(_printSuccess, _printFailure) --> 176 d.addBoth(s.stop) 177 s.run() 178 AttributeError: Sender instance has no attribute 'stop' }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 15 14:15:52 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 15 Jun 2011 14:15:52 -0000 Subject: [Buildbot-commits] [Buildbot] #1985: AttributeError: Sender instance has no attribute 'stop' In-Reply-To: <034.c7fa3215a8c9bfcd40264c4761188c7e@buildbot.net> References: <034.c7fa3215a8c9bfcd40264c4761188c7e@buildbot.net> Message-ID: <049.96de9e582e3184b688009179a7923642@buildbot.net> #1985: AttributeError: Sender instance has no attribute 'stop' ----------------------+------------------------ Reporter: kb | Owner: Type: undecided | Status: new Priority: critical | Milestone: undecided Version: 0.8.4 | Resolution: Keywords: | ----------------------+------------------------ Comment (by dustin): Fix should be pretty straightforward: {{{ #!patch diff --git a/master/buildbot/changes/hgbuildbot.py b/master/buildbot/changes/hgbuildbot.py index 0cc36af..68cc2c5 100644 --- a/master/buildbot/changes/hgbuildbot.py +++ b/master/buildbot/changes/hgbuildbot.py @@ -173,7 +173,7 @@ def hook(ui, repo, hooktype, node=None, source=None, **kwargs): ui.warn(s.getFailureString(why) + '\n') d.addCallbacks(_printSuccess, _printFailure) - d.addBoth(s.stop) + d.addBoth(lambda _ : reactor.stop) s.run() if fork: }}} -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Jun 15 14:17:12 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 15 Jun 2011 07:17:12 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 011c73: fix typo Message-ID: <20110615141712.C64B5423DC@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 011c73ba362733f25d1c0a52c5b21f01b0c6280c https://github.com/buildbot/buildbot/commit/011c73ba362733f25d1c0a52c5b21f01b0c6280c Author: Dustin J. Mitchell Date: 2011-06-14 (Tue, 14 Jun 2011) Changed paths: M master/buildbot/steps/trigger.py Log Message: ----------- fix typo Commit: 75aa463ed0a35ea9c70b39879ae0008378d0ae06 https://github.com/buildbot/buildbot/commit/75aa463ed0a35ea9c70b39879ae0008378d0ae06 Author: Dustin J. Mitchell Date: 2011-06-15 (Wed, 15 Jun 2011) Changed paths: M master/buildbot/changes/hgbuildbot.py Log Message: ----------- Fix breakage in hgbuildbot due to 605ac9aa; Fixes #1985 Compare: https://github.com/buildbot/buildbot/compare/cc69ba3...75aa463 From nobody at buildbot.net Wed Jun 15 14:17:21 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 15 Jun 2011 14:17:21 -0000 Subject: [Buildbot-commits] [Buildbot] #1985: AttributeError: Sender instance has no attribute 'stop' In-Reply-To: <034.c7fa3215a8c9bfcd40264c4761188c7e@buildbot.net> References: <034.c7fa3215a8c9bfcd40264c4761188c7e@buildbot.net> Message-ID: <049.3c897e629be75ab0122e10c59b4e0d81@buildbot.net> #1985: AttributeError: Sender instance has no attribute 'stop' ----------------------+------------------------ Reporter: kb | Owner: Type: undecided | Status: closed Priority: critical | Milestone: undecided Version: 0.8.4 | Resolution: fixed Keywords: | ----------------------+------------------------ Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Fix breakage in hgbuildbot due to 605ac9aa; Fixes #1985 Changeset: 75aa463ed0a35ea9c70b39879ae0008378d0ae06 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 15 14:25:44 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 15 Jun 2011 14:25:44 -0000 Subject: [Buildbot-commits] [Buildbot] #1986: exceptions.TypeError: a float is required Message-ID: <034.92b7bffd0e0fe4c89d4f4c3864d3e1f2@buildbot.net> #1986: exceptions.TypeError: a float is required ----------------------+----------------------- Reporter: kb | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.4 | Keywords: ----------------------+----------------------- twisted.log of buildbot main process (on every commit) 2011-06-15 14:49:07+0300 [Broker,1,127.0.0.1] > didn't accept (... , 'when': None, 'comments': u'sorry, test', 'project': '', 'branch': None, 'revlink': '', 'properties': {}, 'revision': u'bf587514505bf9a55017d6e1b465b22e671848a1'},) and {} 2011-06-15 13:24:41+0300 [Broker,2,127.0.0.1] Unhandled Error Traceback (most recent call last): File "/usr/local/lib/python2.6/dist- packages/Twisted-11.0.0-py2.6-linux-x86_64.egg/twisted/spread/banana.py", line 153, in gotItem self.callExpressionReceived(item) File "/usr/local/lib/python2.6/dist- packages/Twisted-11.0.0-py2.6-linux-x86_64.egg/twisted/spread/banana.py", line 116, in callExpressionReceived self.expressionReceived(obj) File "/usr/local/lib/python2.6/dist- packages/Twisted-11.0.0-py2.6-linux-x86_64.egg/twisted/spread/pb.py", line 515, in expressionReceived method(*sexp[1:]) File "/usr/local/lib/python2.6/dist- packages/Twisted-11.0.0-py2.6-linux-x86_64.egg/twisted/spread/pb.py", line 827, in proto_message self._recvMessage(self.localObjectForID, requestID, objectID, message, answerRequired, netArgs, netKw) --- --- File "/usr/local/lib/python2.6/dist- packages/Twisted-11.0.0-py2.6-linux-x86_64.egg/twisted/spread/pb.py", line 841, in _recvMessage netResult = object.remoteMessageReceived(self, message, netArgs, netKw) File "/usr/local/lib/python2.6/dist- packages/Twisted-11.0.0-py2.6-linux-x86_64.egg/twisted/spread/pb.py", line 225, in perspectiveMessageReceived state = method(*args, **kw) File "/usr/local/lib/python2.6/dist- packages/buildbot-0.8.4-py2.6.egg/buildbot/changes/pb.py", line 59, in perspective_addChange changedict['when_timestamp'] = epoch2datetime(changedict['when']) File "/usr/local/lib/python2.6/dist- packages/buildbot-0.8.4-py2.6.egg/buildbot/util/__init__.py", line 165, in epoch2datetime return datetime.datetime.fromtimestamp(epoch, tz=UTC) exceptions.TypeError: a float is required -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 15 15:46:07 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 15 Jun 2011 15:46:07 -0000 Subject: [Buildbot-commits] [Buildbot] #1986: exceptions.TypeError: a float is required In-Reply-To: <034.92b7bffd0e0fe4c89d4f4c3864d3e1f2@buildbot.net> References: <034.92b7bffd0e0fe4c89d4f4c3864d3e1f2@buildbot.net> Message-ID: <049.9c47ae3bcd2d1299ec11d81c2c9c0132@buildbot.net> #1986: exceptions.TypeError: a float is required ----------------------+------------------------ Reporter: kb | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.4 | Resolution: Keywords: | ----------------------+------------------------ Description changed by dustin: Old description: > twisted.log of buildbot main process (on every commit) > > 2011-06-15 14:49:07+0300 [Broker,1,127.0.0.1] ChangePerspective.perspective_addChange of > > didn't > accept (... , 'when': None, 'comments': u'sorry, test', > 'project': '', 'branch': None, 'revlink': '', 'properties': {}, > 'revision': > u'bf587514505bf9a55017d6e1b465b22e671848a1'},) and {} > > 2011-06-15 13:24:41+0300 [Broker,2,127.0.0.1] Unhandled Error > Traceback (most recent call last): > File "/usr/local/lib/python2.6/dist- > packages/Twisted-11.0.0-py2.6-linux-x86_64.egg/twisted/spread/banana.py", > line 153, in gotItem > self.callExpressionReceived(item) > File "/usr/local/lib/python2.6/dist- > packages/Twisted-11.0.0-py2.6-linux-x86_64.egg/twisted/spread/banana.py", > line 116, in callExpressionReceived > self.expressionReceived(obj) > File "/usr/local/lib/python2.6/dist- > packages/Twisted-11.0.0-py2.6-linux-x86_64.egg/twisted/spread/pb.py", > line 515, in expressionReceived > method(*sexp[1:]) > File "/usr/local/lib/python2.6/dist- > packages/Twisted-11.0.0-py2.6-linux-x86_64.egg/twisted/spread/pb.py", > line 827, in proto_message > self._recvMessage(self.localObjectForID, requestID, objectID, > message, answerRequired, netArgs, netKw) > --- --- > File "/usr/local/lib/python2.6/dist- > packages/Twisted-11.0.0-py2.6-linux-x86_64.egg/twisted/spread/pb.py", > line 841, in _recvMessage > netResult = object.remoteMessageReceived(self, message, > netArgs, netKw) > File "/usr/local/lib/python2.6/dist- > packages/Twisted-11.0.0-py2.6-linux-x86_64.egg/twisted/spread/pb.py", > line 225, in perspectiveMessageReceived > state = method(*args, **kw) > File "/usr/local/lib/python2.6/dist- > packages/buildbot-0.8.4-py2.6.egg/buildbot/changes/pb.py", line 59, in > perspective_addChange > changedict['when_timestamp'] = > epoch2datetime(changedict['when']) > File "/usr/local/lib/python2.6/dist- > packages/buildbot-0.8.4-py2.6.egg/buildbot/util/__init__.py", line 165, > in epoch2datetime > return datetime.datetime.fromtimestamp(epoch, tz=UTC) > exceptions.TypeError: a float is required New description: twisted.log of buildbot main process (on every commit) {{{ 2011-06-15 14:49:07+0300 [Broker,1,127.0.0.1] > didn't accept (... , 'when': None, 'comments': u'sorry, test', 'project': '', 'branch': None, 'revlink': '', 'properties': {}, 'revision': u'bf587514505bf9a55017d6e1b465b22e671848a1'},) and {} 2011-06-15 13:24:41+0300 [Broker,2,127.0.0.1] Unhandled Error Traceback (most recent call last): File "/usr/local/lib/python2.6/dist- packages/Twisted-11.0.0-py2.6-linux-x86_64.egg/twisted/spread/banana.py", line 153, in gotItem self.callExpressionReceived(item) File "/usr/local/lib/python2.6/dist- packages/Twisted-11.0.0-py2.6-linux-x86_64.egg/twisted/spread/banana.py", line 116, in callExpressionReceived self.expressionReceived(obj) File "/usr/local/lib/python2.6/dist- packages/Twisted-11.0.0-py2.6-linux-x86_64.egg/twisted/spread/pb.py", line 515, in expressionReceived method(*sexp[1:]) File "/usr/local/lib/python2.6/dist- packages/Twisted-11.0.0-py2.6-linux-x86_64.egg/twisted/spread/pb.py", line 827, in proto_message self._recvMessage(self.localObjectForID, requestID, objectID, message, answerRequired, netArgs, netKw) --- --- File "/usr/local/lib/python2.6/dist- packages/Twisted-11.0.0-py2.6-linux-x86_64.egg/twisted/spread/pb.py", line 841, in _recvMessage netResult = object.remoteMessageReceived(self, message, netArgs, netKw) File "/usr/local/lib/python2.6/dist- packages/Twisted-11.0.0-py2.6-linux-x86_64.egg/twisted/spread/pb.py", line 225, in perspectiveMessageReceived state = method(*args, **kw) File "/usr/local/lib/python2.6/dist- packages/buildbot-0.8.4-py2.6.egg/buildbot/changes/pb.py", line 59, in perspective_addChange changedict['when_timestamp'] = epoch2datetime(changedict['when']) File "/usr/local/lib/python2.6/dist- packages/buildbot-0.8.4-py2.6.egg/buildbot/util/__init__.py", line 165, in epoch2datetime return datetime.datetime.fromtimestamp(epoch, tz=UTC) exceptions.TypeError: a float is required }}} -- -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 15 15:52:30 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 15 Jun 2011 15:52:30 -0000 Subject: [Buildbot-commits] [Buildbot] #1986: exceptions.TypeError: a float is required In-Reply-To: <034.92b7bffd0e0fe4c89d4f4c3864d3e1f2@buildbot.net> References: <034.92b7bffd0e0fe4c89d4f4c3864d3e1f2@buildbot.net> Message-ID: <049.22e830a7b15783d66c582e925d6f3d3f@buildbot.net> #1986: exceptions.TypeError: a float is required ----------------------+------------------------ Reporter: kb | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.4 | Resolution: Keywords: | ----------------------+------------------------ Comment (by dustin): What remote changesource is creating these changes? -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Jun 15 16:43:32 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 15 Jun 2011 09:43:32 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] ae7f64: Fix breakage in hgbuildbot due to 605ac9aa; Fixes ... Message-ID: <20110615164332.A9BD14238E@smtp1.rs.github.com> Branch: refs/heads/buildbot-0.8.4 Home: https://github.com/buildbot/buildbot Commit: ae7f646576a14090f6ec79afad27bd5c6b1f3192 https://github.com/buildbot/buildbot/commit/ae7f646576a14090f6ec79afad27bd5c6b1f3192 Author: Dustin J. Mitchell Date: 2011-06-15 (Wed, 15 Jun 2011) Changed paths: M master/buildbot/changes/hgbuildbot.py Log Message: ----------- Fix breakage in hgbuildbot due to 605ac9aa; Fixes #1985 From noreply at github.com Wed Jun 15 16:43:33 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 15 Jun 2011 09:43:33 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 52ac96: Set ss.patch_info to None if there is no patch Message-ID: <20110615164333.2159E42394@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 52ac966c169256e4af28d2fb35a6a84c07c2ea7b https://github.com/buildbot/buildbot/commit/52ac966c169256e4af28d2fb35a6a84c07c2ea7b Author: Dustin J. Mitchell Date: 2011-06-15 (Wed, 15 Jun 2011) Changed paths: M master/buildbot/sourcestamp.py Log Message: ----------- Set ss.patch_info to None if there is no patch Fixes failure of the web status. From nobody at buildbot.net Wed Jun 15 16:43:39 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 15 Jun 2011 16:43:39 -0000 Subject: [Buildbot-commits] [Buildbot] #1985: AttributeError: Sender instance has no attribute 'stop' In-Reply-To: <034.c7fa3215a8c9bfcd40264c4761188c7e@buildbot.net> References: <034.c7fa3215a8c9bfcd40264c4761188c7e@buildbot.net> Message-ID: <049.0882f16d30939e5e362504e5faf99634@buildbot.net> #1985: AttributeError: Sender instance has no attribute 'stop' ----------------------+------------------------ Reporter: kb | Owner: Type: undecided | Status: closed Priority: critical | Milestone: undecided Version: 0.8.4 | Resolution: fixed Keywords: | ----------------------+------------------------ Comment (by Dustin J. Mitchell): Fix breakage in hgbuildbot due to 605ac9aa; Fixes #1985 Changeset: ae7f646576a14090f6ec79afad27bd5c6b1f3192 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Jun 15 17:11:52 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 15 Jun 2011 10:11:52 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 0b5e59: add unit test to catch failure fixed in parent com... Message-ID: <20110615171153.106D1421A4@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 0b5e595f8b53461f4aacadf9247ca338bb6c02c5 https://github.com/buildbot/buildbot/commit/0b5e595f8b53461f4aacadf9247ca338bb6c02c5 Author: Dustin J. Mitchell Date: 2011-06-15 (Wed, 15 Jun 2011) Changed paths: M master/buildbot/test/unit/test_sourcestamp.py Log Message: ----------- add unit test to catch failure fixed in parent commit From nobody at buildbot.net Wed Jun 15 19:49:39 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 15 Jun 2011 19:49:39 -0000 Subject: [Buildbot-commits] [Buildbot] #1987: sendchange fails with TypeError Message-ID: <041.23f39b2444ff7042ce53d5688e90f75d@buildbot.net> #1987: sendchange fails with TypeError ----------------------+----------------------- Reporter: Underhand | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: master | Keywords: ----------------------+----------------------- With the latest version from the master branch, downloaded today from github, attempting to run sendchange gives the following error. -bash-4.2$ buildbot sendchange --master 'localhost:9989' --who testuser --branch test a b Traceback (most recent call last): File "/usr/pkg/bin/buildbot", line 4, in runner.run() File "/usr/pkg/lib/python2.6/site-packages/buildbot/scripts/runner.py", line 1234, in run if not sendchange(so, True): File "/usr/pkg/lib/python2.6/site-packages/buildbot/scripts/runner.py", line 898, in sendchange revlink=revlink) File "/usr/pkg/lib/python2.6/site- packages/buildbot/clients/sendchange.py", line 40, in send change['files'][i] = file.decode(self.encoding, 'replace') TypeError: 'tuple' object does not support item assignment Without specifying any files, I get this instead: -bash-4.2$ buildbot sendchange --master 'localhost:9989' --who testuser --branch test Traceback (most recent call last): File "/usr/pkg/bin/buildbot", line 4, in runner.run() File "/usr/pkg/lib/python2.6/site-packages/buildbot/scripts/runner.py", line 1234, in run if not sendchange(so, True): File "/usr/pkg/lib/python2.6/site-packages/buildbot/scripts/runner.py", line 904, in sendchange d.addCallbacks(s.printSuccess, failed) AttributeError: Sender instance has no attribute 'printSuccess' -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Jun 15 19:58:06 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 15 Jun 2011 12:58:06 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] fd4bb8: add dates to NEWS files Message-ID: <20110615195806.DA92742464@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: fd4bb8becd8b495cc5991aac2ba4e3194940eb67 https://github.com/buildbot/buildbot/commit/fd4bb8becd8b495cc5991aac2ba4e3194940eb67 Author: Dustin J. Mitchell Date: 2011-06-15 (Wed, 15 Jun 2011) Changed paths: M master/NEWS M slave/NEWS Log Message: ----------- add dates to NEWS files From noreply at github.com Wed Jun 15 19:58:06 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 15 Jun 2011 12:58:06 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 0f096d: add dates to NEWS files Message-ID: <20110615195806.83F294245D@smtp1.rs.github.com> Branch: refs/heads/buildbot-0.8.4 Home: https://github.com/buildbot/buildbot Commit: 0f096df579804ed12f9bf869073938981d9d0d7c https://github.com/buildbot/buildbot/commit/0f096df579804ed12f9bf869073938981d9d0d7c Author: Dustin J. Mitchell Date: 2011-06-15 (Wed, 15 Jun 2011) Changed paths: M master/NEWS M slave/NEWS Log Message: ----------- add dates to NEWS files From nobody at buildbot.net Wed Jun 15 20:00:42 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 15 Jun 2011 20:00:42 -0000 Subject: [Buildbot-commits] [Buildbot] #1987: sendchange fails with TypeError In-Reply-To: <041.23f39b2444ff7042ce53d5688e90f75d@buildbot.net> References: <041.23f39b2444ff7042ce53d5688e90f75d@buildbot.net> Message-ID: <056.0d599cc0aeeba83492f7bcd5fe86615f@buildbot.net> #1987: sendchange fails with TypeError ----------------------+-------------------- Reporter: Underhand | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: master | Resolution: Keywords: | ----------------------+-------------------- Changes (by dustin): * milestone: undecided => 0.8.5 Old description: > With the latest version from the master branch, downloaded today from > github, attempting to run sendchange gives the following error. > > -bash-4.2$ buildbot sendchange --master 'localhost:9989' --who testuser > --branch test a b > Traceback (most recent call last): > File "/usr/pkg/bin/buildbot", line 4, in > runner.run() > File "/usr/pkg/lib/python2.6/site-packages/buildbot/scripts/runner.py", > line 1234, in run > if not sendchange(so, True): > File "/usr/pkg/lib/python2.6/site-packages/buildbot/scripts/runner.py", > line 898, in sendchange > revlink=revlink) > File "/usr/pkg/lib/python2.6/site- > packages/buildbot/clients/sendchange.py", line 40, in send > change['files'][i] = file.decode(self.encoding, 'replace') > TypeError: 'tuple' object does not support item assignment > > Without specifying any files, I get this instead: > > -bash-4.2$ buildbot sendchange --master 'localhost:9989' --who testuser > --branch test > Traceback (most recent call last): > File "/usr/pkg/bin/buildbot", line 4, in > runner.run() > File "/usr/pkg/lib/python2.6/site-packages/buildbot/scripts/runner.py", > line 1234, in run > if not sendchange(so, True): > File "/usr/pkg/lib/python2.6/site-packages/buildbot/scripts/runner.py", > line 904, in sendchange > d.addCallbacks(s.printSuccess, failed) > AttributeError: Sender instance has no attribute 'printSuccess' New description: With the latest version from the master branch, downloaded today from github, attempting to run sendchange gives the following error. {{{ -bash-4.2$ buildbot sendchange --master 'localhost:9989' --who testuser --branch test a b Traceback (most recent call last): File "/usr/pkg/bin/buildbot", line 4, in runner.run() File "/usr/pkg/lib/python2.6/site-packages/buildbot/scripts/runner.py", line 1234, in run if not sendchange(so, True): File "/usr/pkg/lib/python2.6/site-packages/buildbot/scripts/runner.py", line 898, in sendchange revlink=revlink) File "/usr/pkg/lib/python2.6/site- packages/buildbot/clients/sendchange.py", line 40, in send change['files'][i] = file.decode(self.encoding, 'replace') TypeError: 'tuple' object does not support item assignment Without specifying any files, I get this instead: -bash-4.2$ buildbot sendchange --master 'localhost:9989' --who testuser --branch test Traceback (most recent call last): File "/usr/pkg/bin/buildbot", line 4, in runner.run() File "/usr/pkg/lib/python2.6/site-packages/buildbot/scripts/runner.py", line 1234, in run if not sendchange(so, True): File "/usr/pkg/lib/python2.6/site-packages/buildbot/scripts/runner.py", line 904, in sendchange d.addCallbacks(s.printSuccess, failed) AttributeError: Sender instance has no attribute 'printSuccess' }}} -- -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Jun 15 20:18:03 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 15 Jun 2011 13:18:03 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] cca26b: ensure that ch.files is a list before trying to mo... Message-ID: <20110615201803.C6E0B4248D@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: cca26b841cb3ffa042eabb69f82a9e0937bc1162 https://github.com/buildbot/buildbot/commit/cca26b841cb3ffa042eabb69f82a9e0937bc1162 Author: Dustin J. Mitchell Date: 2011-06-15 (Wed, 15 Jun 2011) Changed paths: M master/buildbot/clients/sendchange.py M master/buildbot/test/unit/test_clients_sendchange.py Log Message: ----------- ensure that ch.files is a list before trying to modify sendchange, in particular, gets tuples from getopt. Fixes #1987. Commit: 1f5d2574fb91ac9e4f000afead5d8f3746a6c5d6 https://github.com/buildbot/buildbot/commit/1f5d2574fb91ac9e4f000afead5d8f3746a6c5d6 Author: Dustin J. Mitchell Date: 2011-06-15 (Wed, 15 Jun 2011) Changed paths: M master/buildbot/scripts/runner.py Log Message: ----------- don't use now-missing methods from senchange.Sender Fixes #1987. Commit: 33cc1c8f57a2ace0b87ec295bd1dbbf9dcee456e https://github.com/buildbot/buildbot/commit/33cc1c8f57a2ace0b87ec295bd1dbbf9dcee456e Author: Dustin J. Mitchell Date: 2011-06-15 (Wed, 15 Jun 2011) Changed paths: M master/buildbot/changes/pb.py M master/buildbot/test/unit/test_changes_pb.py Log Message: ----------- perspective_addChange should handle when==None Fixes #1986. Compare: https://github.com/buildbot/buildbot/compare/fd4bb8b...33cc1c8 From nobody at buildbot.net Wed Jun 15 20:18:12 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 15 Jun 2011 20:18:12 -0000 Subject: [Buildbot-commits] [Buildbot] #1986: exceptions.TypeError: a float is required In-Reply-To: <034.92b7bffd0e0fe4c89d4f4c3864d3e1f2@buildbot.net> References: <034.92b7bffd0e0fe4c89d4f4c3864d3e1f2@buildbot.net> Message-ID: <049.7bec75d3f283ffd6de99bdbe89035c5c@buildbot.net> #1986: exceptions.TypeError: a float is required ----------------------+------------------------ Reporter: kb | Owner: Type: undecided | Status: closed Priority: major | Milestone: undecided Version: 0.8.4 | Resolution: fixed Keywords: | ----------------------+------------------------ Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: perspective_addChange should handle when==None Fixes #1986. Changeset: 33cc1c8f57a2ace0b87ec295bd1dbbf9dcee456e -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 15 20:18:11 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 15 Jun 2011 20:18:11 -0000 Subject: [Buildbot-commits] [Buildbot] #1987: sendchange fails with TypeError In-Reply-To: <041.23f39b2444ff7042ce53d5688e90f75d@buildbot.net> References: <041.23f39b2444ff7042ce53d5688e90f75d@buildbot.net> Message-ID: <056.4a48f2215b359504f9a1f6cdc3630b19@buildbot.net> #1987: sendchange fails with TypeError ----------------------+--------------------- Reporter: Underhand | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.5 Version: master | Resolution: fixed Keywords: | ----------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: ensure that ch.files is a list before trying to modify sendchange, in particular, gets tuples from getopt. Fixes #1987. Changeset: cca26b841cb3ffa042eabb69f82a9e0937bc1162 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 15 20:18:11 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 15 Jun 2011 20:18:11 -0000 Subject: [Buildbot-commits] [Buildbot] #1987: sendchange fails with TypeError In-Reply-To: <041.23f39b2444ff7042ce53d5688e90f75d@buildbot.net> References: <041.23f39b2444ff7042ce53d5688e90f75d@buildbot.net> Message-ID: <056.5695f5f5917b4d3a03c796ee1a21b4eb@buildbot.net> #1987: sendchange fails with TypeError ----------------------+--------------------- Reporter: Underhand | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.5 Version: master | Resolution: fixed Keywords: | ----------------------+--------------------- Comment (by Dustin J. Mitchell): don't use now-missing methods from senchange.Sender Fixes #1987. Changeset: 1f5d2574fb91ac9e4f000afead5d8f3746a6c5d6 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Jun 15 20:39:07 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 15 Jun 2011 13:39:07 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 835aa0: ensure that ch.files is a list before trying to mo... Message-ID: <20110615203907.150A7420D4@smtp1.rs.github.com> Branch: refs/heads/buildbot-0.8.4 Home: https://github.com/buildbot/buildbot Commit: 835aa01dc18843fc164807dd5a377e07be104f32 https://github.com/buildbot/buildbot/commit/835aa01dc18843fc164807dd5a377e07be104f32 Author: Dustin J. Mitchell Date: 2011-06-15 (Wed, 15 Jun 2011) Changed paths: M master/buildbot/clients/sendchange.py M master/buildbot/test/unit/test_clients_sendchange.py Log Message: ----------- ensure that ch.files is a list before trying to modify sendchange, in particular, gets tuples from getopt. Fixes #1987. Commit: 3481db11a5fda53fa79242427abb5faa92e5c600 https://github.com/buildbot/buildbot/commit/3481db11a5fda53fa79242427abb5faa92e5c600 Author: Dustin J. Mitchell Date: 2011-06-15 (Wed, 15 Jun 2011) Changed paths: M master/buildbot/scripts/runner.py Log Message: ----------- don't use now-missing methods from senchange.Sender Fixes #1987. Commit: ffd1f18f21b77e929ea0748ef0ad762dbaa1b066 https://github.com/buildbot/buildbot/commit/ffd1f18f21b77e929ea0748ef0ad762dbaa1b066 Author: Dustin J. Mitchell Date: 2011-06-15 (Wed, 15 Jun 2011) Changed paths: M master/buildbot/changes/pb.py M master/buildbot/test/unit/test_changes_pb.py Log Message: ----------- perspective_addChange should handle when==None Fixes #1986. Compare: https://github.com/buildbot/buildbot/compare/0f096df...ffd1f18 From nobody at buildbot.net Wed Jun 15 20:39:13 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 15 Jun 2011 20:39:13 -0000 Subject: [Buildbot-commits] [Buildbot] #1987: sendchange fails with TypeError In-Reply-To: <041.23f39b2444ff7042ce53d5688e90f75d@buildbot.net> References: <041.23f39b2444ff7042ce53d5688e90f75d@buildbot.net> Message-ID: <056.c90433bba1a7a1ce7f99725b1e0459e5@buildbot.net> #1987: sendchange fails with TypeError ----------------------+--------------------- Reporter: Underhand | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.5 Version: master | Resolution: fixed Keywords: | ----------------------+--------------------- Comment (by Dustin J. Mitchell): ensure that ch.files is a list before trying to modify sendchange, in particular, gets tuples from getopt. Fixes #1987. Changeset: 835aa01dc18843fc164807dd5a377e07be104f32 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 15 20:39:13 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 15 Jun 2011 20:39:13 -0000 Subject: [Buildbot-commits] [Buildbot] #1987: sendchange fails with TypeError In-Reply-To: <041.23f39b2444ff7042ce53d5688e90f75d@buildbot.net> References: <041.23f39b2444ff7042ce53d5688e90f75d@buildbot.net> Message-ID: <056.36c08dfcd8732aee57c55c972fe83070@buildbot.net> #1987: sendchange fails with TypeError ----------------------+--------------------- Reporter: Underhand | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.5 Version: master | Resolution: fixed Keywords: | ----------------------+--------------------- Comment (by Dustin J. Mitchell): don't use now-missing methods from senchange.Sender Fixes #1987. Changeset: 3481db11a5fda53fa79242427abb5faa92e5c600 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 15 20:39:13 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 15 Jun 2011 20:39:13 -0000 Subject: [Buildbot-commits] [Buildbot] #1986: exceptions.TypeError: a float is required In-Reply-To: <034.92b7bffd0e0fe4c89d4f4c3864d3e1f2@buildbot.net> References: <034.92b7bffd0e0fe4c89d4f4c3864d3e1f2@buildbot.net> Message-ID: <049.13b1eade1566b674497797b4bf17e552@buildbot.net> #1986: exceptions.TypeError: a float is required ----------------------+------------------------ Reporter: kb | Owner: Type: undecided | Status: closed Priority: major | Milestone: undecided Version: 0.8.4 | Resolution: fixed Keywords: | ----------------------+------------------------ Comment (by Dustin J. Mitchell): perspective_addChange should handle when==None Fixes #1986. Changeset: ffd1f18f21b77e929ea0748ef0ad762dbaa1b066 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Jun 15 20:45:10 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 15 Jun 2011 13:45:10 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 2f7cd3: Fix 'sendchange' to correctly exit after sending t... Message-ID: <20110615204510.DA02442464@smtp1.rs.github.com> Branch: refs/heads/buildbot-0.8.4 Home: https://github.com/buildbot/buildbot Commit: 2f7cd3c095630bde0752dd4864ff942c24771fc0 https://github.com/buildbot/buildbot/commit/2f7cd3c095630bde0752dd4864ff942c24771fc0 Author: Dustin J. Mitchell Date: 2011-06-15 (Wed, 15 Jun 2011) Changed paths: M master/buildbot/scripts/runner.py Log Message: ----------- Fix 'sendchange' to correctly exit after sending the change From noreply at github.com Wed Jun 15 20:45:11 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 15 Jun 2011 13:45:11 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] e5293d: Fix 'sendchange' to correctly exit after sending t... Message-ID: <20110615204511.9A85A424C5@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: e5293db2583e06b86df2b6dad779fccbfe51be75 https://github.com/buildbot/buildbot/commit/e5293db2583e06b86df2b6dad779fccbfe51be75 Author: Dustin J. Mitchell Date: 2011-06-15 (Wed, 15 Jun 2011) Changed paths: M master/buildbot/scripts/runner.py Log Message: ----------- Fix 'sendchange' to correctly exit after sending the change From noreply at github.com Wed Jun 15 21:58:39 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 15 Jun 2011 14:58:39 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] b2ab07: PBChangeSource should be tolerant of tuples, too Message-ID: <20110615215839.C383B424AE@smtp1.rs.github.com> Branch: refs/heads/buildbot-0.8.4 Home: https://github.com/buildbot/buildbot Commit: b2ab07d0f7295d5a298ccf81dcd1920f2ba61579 https://github.com/buildbot/buildbot/commit/b2ab07d0f7295d5a298ccf81dcd1920f2ba61579 Author: Dustin J. Mitchell Date: 2011-06-15 (Wed, 15 Jun 2011) Changed paths: M master/buildbot/changes/pb.py M master/buildbot/test/unit/test_changes_pb.py Log Message: ----------- PBChangeSource should be tolerant of tuples, too From noreply at github.com Wed Jun 15 21:58:39 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 15 Jun 2011 14:58:39 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] de82df: PBChangeSource should be tolerant of tuples, too Message-ID: <20110615215839.C7FF9424BE@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: de82df787f8bd3ab40d0c301c9cff484949130a0 https://github.com/buildbot/buildbot/commit/de82df787f8bd3ab40d0c301c9cff484949130a0 Author: Dustin J. Mitchell Date: 2011-06-15 (Wed, 15 Jun 2011) Changed paths: M master/buildbot/changes/pb.py M master/buildbot/test/unit/test_changes_pb.py Log Message: ----------- PBChangeSource should be tolerant of tuples, too From noreply at github.com Wed Jun 15 23:03:46 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 15 Jun 2011 16:03:46 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 10c413: fix typo Message-ID: <20110615230346.DBC5B4238E@smtp1.rs.github.com> Branch: refs/heads/buildbot-0.8.4 Home: https://github.com/buildbot/buildbot Commit: 10c4131775db9f84b2f99923d8fbb09ed583020c https://github.com/buildbot/buildbot/commit/10c4131775db9f84b2f99923d8fbb09ed583020c Author: Dustin J. Mitchell Date: 2011-06-15 (Wed, 15 Jun 2011) Changed paths: M master/buildbot/steps/trigger.py Log Message: ----------- fix typo From noreply at github.com Thu Jun 16 00:19:01 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 15 Jun 2011 17:19:01 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 199fd2: Add missing credit for Monotone support to NEWS Message-ID: <20110616001901.BA3FD424C3@smtp1.rs.github.com> Branch: refs/heads/buildbot-0.8.4 Home: https://github.com/buildbot/buildbot Commit: 199fd2b70edbd58e971d50b10b4f4744ff8d24be https://github.com/buildbot/buildbot/commit/199fd2b70edbd58e971d50b10b4f4744ff8d24be Author: Dustin J. Mitchell Date: 2011-06-15 (Wed, 15 Jun 2011) Changed paths: M master/NEWS M slave/NEWS Log Message: ----------- Add missing credit for Monotone support to NEWS From noreply at github.com Thu Jun 16 00:19:01 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 15 Jun 2011 17:19:01 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 17e791: Add missing credit for Monotone support to NEWS Message-ID: <20110616001901.8C4E0424BF@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 17e7911729d2a3a6976b657f891f74a874d7c248 https://github.com/buildbot/buildbot/commit/17e7911729d2a3a6976b657f891f74a874d7c248 Author: Dustin J. Mitchell Date: 2011-06-15 (Wed, 15 Jun 2011) Changed paths: M master/NEWS M slave/NEWS Log Message: ----------- Add missing credit for Monotone support to NEWS From noreply at github.com Thu Jun 16 03:08:48 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 15 Jun 2011 20:08:48 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 088853: Only add _ComputeRepositoryURL if svnurl is not No... Message-ID: <20110616030848.07C8C424B8@smtp1.rs.github.com> Branch: refs/heads/buildbot-0.8.4 Home: https://github.com/buildbot/buildbot Commit: 08885362aa8a82aa3ddb7d0df75db8174d45fafb https://github.com/buildbot/buildbot/commit/08885362aa8a82aa3ddb7d0df75db8174d45fafb Author: Dustin J. Mitchell Date: 2011-06-15 (Wed, 15 Jun 2011) Changed paths: M master/buildbot/steps/source.py Log Message: ----------- Only add _ComputeRepositoryURL if svnurl is not None Thanks to bdbaddog for reporting, and to tomprince for the fix From noreply at github.com Thu Jun 16 03:08:48 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 15 Jun 2011 20:08:48 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 40480c: Only add _ComputeRepositoryURL if svnurl is not No... Message-ID: <20110616030848.AAFFD424C6@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 40480c7aaca32c4d191decd40bb8d26b3c993f54 https://github.com/buildbot/buildbot/commit/40480c7aaca32c4d191decd40bb8d26b3c993f54 Author: Dustin J. Mitchell Date: 2011-06-15 (Wed, 15 Jun 2011) Changed paths: M master/buildbot/steps/source.py Log Message: ----------- Only add _ComputeRepositoryURL if svnurl is not None Thanks to bdbaddog for reporting, and to tomprince for the fix From noreply at github.com Thu Jun 16 05:17:00 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 15 Jun 2011 22:17:00 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] de7cd9: improve the buildstep testing framework Message-ID: <20110616051700.0E1CE4229C@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: de7cd98cdb529a12e0f6aa80462fcefbc3e717c2 https://github.com/buildbot/buildbot/commit/de7cd98cdb529a12e0f6aa80462fcefbc3e717c2 Author: Dustin J. Mitchell Date: 2011-06-15 (Wed, 15 Jun 2011) Changed paths: A master/buildbot/test/util/sourcesteps.py M master/buildbot/test/util/steps.py Log Message: ----------- improve the buildstep testing framework and add initial support for testing source steps From noreply at github.com Thu Jun 16 05:28:05 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 15 Jun 2011 22:28:05 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] f3734b: render schedulerNames, not scheduler, for Triggera... Message-ID: <20110616052805.04E5A42496@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: f3734be7f72ed63de5d1c88155142c20e26e0470 https://github.com/buildbot/buildbot/commit/f3734be7f72ed63de5d1c88155142c20e26e0470 Author: Dustin J. Mitchell Date: 2011-06-15 (Wed, 15 Jun 2011) Changed paths: M master/buildbot/steps/trigger.py Log Message: ----------- render schedulerNames, not scheduler, for Triggerable From nobody at buildbot.net Thu Jun 16 06:49:23 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 16 Jun 2011 06:49:23 -0000 Subject: [Buildbot-commits] [Buildbot] #1988: Incompatible change in svn_buildbot.py with steps/source.py Message-ID: <040.dbcad89f9d58e4909324601c276b2d89@buildbot.net> #1988: Incompatible change in svn_buildbot.py with steps/source.py ----------------------+----------------------- Reporter: abompard | Owner: Type: undecided | Status: new Priority: minor | Milestone: undecided Version: 0.8.4 | Keywords: svn ----------------------+----------------------- I'm not sure this is a bug, however it's a change worth mentioning somewhere. In the svn_buildbot.py script, which is supposed to be run on a post-commit hook, the change is creating with a "repository" attribute. This value is taken from a variable in the hook, which is the local path to the repository (for example /var/lib/svn/myproject). There's been a change in steps/source.py, where [https://github.com/buildbot/buildbot/blob/master/master/buildbot/steps/source.py#L41 on line 41] the repository attribute of the change is used if no value is provided to `_ComputeRepositoryURL`. And this class is called on both mandatory attributes of the SVN source step : svnurl and baseURL. As a result, if I want to use baseURL to build my URL, and not svnurl, it will fail because svnurl will be replaced by the repository attribute from the change (due to `_ComputeRepositoryURL`) and will thus override my baseURL parameter. Since it's a local path and not an SVN URL, builds will all fail. The only solution I have found to this is to remove the repository attribute from the svn_buildbot.py script. I'm not sure what the best course of action is: 1. fix the provided script, 2. fix the source.py module, 3. or just add a warning in the docs. In case 1. or 3., I think upgraders should be warned. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Jun 16 10:42:23 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 16 Jun 2011 10:42:23 -0000 Subject: [Buildbot-commits] [Buildbot] #1989: gitpoller: repo poll failed Message-ID: <047.15fe2481887f15aaa5d34e0dcb912e05@buildbot.net> #1989: gitpoller: repo poll failed ----------------------------+------------------- Reporter: sanlokenpatidar | Owner: Type: support-request | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.4 | Keywords: ----------------------------+------------------- Hi I am using buildbot 0.8.2 and GIT 1.7.4 version In master.cfg file i set scheduler for continuous integration and gave master as a default git branch. I made changes in GIT after that one CI build should be trigrred with update mode. But nothing is happening and in twisted log it showed - 2011-06-16 15:41:17+0530 [-] gitpoller: repo poll failed 2011-06-16 15:41:17+0530 [-] Unhandled Error Traceback (most recent call last): Failure: twisted.internet.utils._UnexpectedErrorOutput: got stderr: 'fatal: unrecognized argument: --format=%H\n' 2011-06-16 15:41:17+0530 [-] gitpoller: no changes, no catch_up 2011-06-16 15:41:22+0530 [Broker,0,10.99.94.51] slave 'git' attaching from IPv4Address(TCP, '10.99.94.51', 61758) 2011-06-16 15:41:22+0530 [Broker,0,10.99.94.51] Got slaveinfo from 'git' 2011-06-16 15:41:22+0530 [Broker,0,10.99.94.51] bot attached Can you suggest what to do in this case. i attached master.cfg file please review and give comments on same. it will be great helpout for me to go ahead. thanks in advance -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Jun 16 12:06:59 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 16 Jun 2011 12:06:59 -0000 Subject: [Buildbot-commits] [Buildbot] #1989: gitpoller: repo poll failed In-Reply-To: <047.15fe2481887f15aaa5d34e0dcb912e05@buildbot.net> References: <047.15fe2481887f15aaa5d34e0dcb912e05@buildbot.net> Message-ID: <062.04d2bd3fdea93a892019cc604ac93776@buildbot.net> #1989: gitpoller: repo poll failed ----------------------------+------------------------ Reporter: sanlokenpatidar | Owner: Type: support-request | Status: new Priority: major | Milestone: undecided Version: 0.8.2 | Resolution: Keywords: | ----------------------------+------------------------ Changes (by dustin): * version: 0.8.4 => 0.8.2 * milestone: 0.8.+ => undecided Comment: Does this work? {{{ git log --format=%H }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Jun 16 12:13:56 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 16 Jun 2011 12:13:56 -0000 Subject: [Buildbot-commits] [Buildbot] #1988: Incompatible change in svn_buildbot.py with steps/source.py In-Reply-To: <040.dbcad89f9d58e4909324601c276b2d89@buildbot.net> References: <040.dbcad89f9d58e4909324601c276b2d89@buildbot.net> Message-ID: <055.2d1a2cab769e58246289364054557020@buildbot.net> #1988: Incompatible change in svn_buildbot.py with steps/source.py ---------------------+---------------------- Reporter: abompard | Owner: Type: defect | Status: new Priority: blocker | Milestone: 0.8.4p1 Version: 0.8.4 | Resolution: Keywords: svn | ---------------------+---------------------- Changes (by dustin): * priority: minor => blocker * type: undecided => defect * milestone: undecided => 0.8.4p1 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Jun 16 12:19:11 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 16 Jun 2011 05:19:11 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] cbbf25: Change hgbuildbot according to changes made in sen... Message-ID: <20110616121911.44E5E42525@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: cbbf25888295c18d03719b04aeb6bc1a9ea7f84a https://github.com/buildbot/buildbot/commit/cbbf25888295c18d03719b04aeb6bc1a9ea7f84a Author: Pradeepkumar Gayam Date: 2011-06-16 (Thu, 16 Jun 2011) Changed paths: M master/buildbot/changes/hgbuildbot.py Log Message: ----------- Change hgbuildbot according to changes made in sendchange.py Commit: fbd63b7279d2adaef2254f976a19df95ffa706e1 https://github.com/buildbot/buildbot/commit/fbd63b7279d2adaef2254f976a19df95ffa706e1 Author: Dustin J. Mitchell Date: 2011-06-16 (Thu, 16 Jun 2011) Changed paths: M master/buildbot/changes/hgbuildbot.py Log Message: ----------- Merge branch 'hgbuildbot' of git://github.com/in3xes/buildbot * 'hgbuildbot' of git://github.com/in3xes/buildbot: Change hgbuildbot according to changes made in sendchange.py Compare: https://github.com/buildbot/buildbot/compare/f3734be...fbd63b7 From nobody at buildbot.net Thu Jun 16 12:47:41 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 16 Jun 2011 12:47:41 -0000 Subject: [Buildbot-commits] [Buildbot] #1989: gitpoller: repo poll failed In-Reply-To: <047.15fe2481887f15aaa5d34e0dcb912e05@buildbot.net> References: <047.15fe2481887f15aaa5d34e0dcb912e05@buildbot.net> Message-ID: <062.f9ba01009ce55e1aa6a132e349977434@buildbot.net> #1989: gitpoller: repo poll failed ----------------------------+------------------------ Reporter: sanlokenpatidar | Owner: Type: support-request | Status: new Priority: major | Milestone: undecided Version: 0.8.2 | Resolution: Keywords: | ----------------------------+------------------------ Comment (by sanlokenpatidar): Replying to [comment:1 dustin]: > Does this work? > {{{ > git log --format=%H > }}} After executing git log --format=%H command Now it is showing in twisted.log - 2011-06-16 18:08:12+0530 [-] gitpoller: repo poll failed 2011-06-16 18:08:12+0530 [-] Unhandled Error Traceback (most recent call last): Failure: twisted.internet.utils._UnexpectedErrorOutput: got stderr: 'fatal: unrecognized argument: --format=%H\n' 2011-06-16 18:08:12+0530 [-] gitpoller: no changes, no catch_up Unhandled error in Deferred: 2011-06-16 18:08:45+0530 [HTTPChannel,0,10.99.2.108] Unhandled Error Traceback (most recent call last): Failure: twisted.internet.error.ProcessTerminated: A process has ended with a probable error condition: process ended with exit code 128. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Jun 16 15:30:35 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 16 Jun 2011 08:30:35 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 0d2e02: fix bug (s.printFailure) in sendchange, tests Message-ID: <20110616153035.03A794250D@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 0d2e02b4f8d59c55c8f412c48b950e94343d214a https://github.com/buildbot/buildbot/commit/0d2e02b4f8d59c55c8f412c48b950e94343d214a Author: Dustin J. Mitchell Date: 2011-06-16 (Thu, 16 Jun 2011) Changed paths: M master/buildbot/scripts/runner.py A master/buildbot/test/unit/test_scripts_runner.py Log Message: ----------- fix bug (s.printFailure) in sendchange, tests This is mostly more tests, and fixes related to those tests. I can't test the |if runReactor| section, because I can't figure out how to test code that calls reactor.run or reactor.stop from tests. From noreply at github.com Thu Jun 16 16:18:53 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 16 Jun 2011 09:18:53 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 8b3612: render schedulerNames, not scheduler, for Triggera... Message-ID: <20110616161853.C15EF424B3@smtp1.rs.github.com> Branch: refs/heads/buildbot-0.8.4 Home: https://github.com/buildbot/buildbot Commit: 8b3612c05df4cdda7241c4270ed5b989c560b0e2 https://github.com/buildbot/buildbot/commit/8b3612c05df4cdda7241c4270ed5b989c560b0e2 Author: Dustin J. Mitchell Date: 2011-06-16 (Thu, 16 Jun 2011) Changed paths: M master/buildbot/steps/trigger.py Log Message: ----------- render schedulerNames, not scheduler, for Triggerable Commit: 0eb64f7339d62eba7b87ce05bbdff660d766cb2f https://github.com/buildbot/buildbot/commit/0eb64f7339d62eba7b87ce05bbdff660d766cb2f Author: Pradeepkumar Gayam Date: 2011-06-16 (Thu, 16 Jun 2011) Changed paths: M master/buildbot/changes/hgbuildbot.py Log Message: ----------- Change hgbuildbot according to changes made in sendchange.py Commit: be260dbb1b8785247247cc58bcf9c64635a10d46 https://github.com/buildbot/buildbot/commit/be260dbb1b8785247247cc58bcf9c64635a10d46 Author: Dustin J. Mitchell Date: 2011-06-16 (Thu, 16 Jun 2011) Changed paths: M master/buildbot/scripts/runner.py A master/buildbot/test/unit/test_scripts_runner.py Log Message: ----------- fix bug (s.printFailure) in sendchange, tests This is mostly more tests, and fixes related to those tests. I can't test the |if runReactor| section, because I can't figure out how to test code that calls reactor.run or reactor.stop from tests. Compare: https://github.com/buildbot/buildbot/compare/0888536...be260db From noreply at github.com Thu Jun 16 18:49:00 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 16 Jun 2011 11:49:00 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] eed60d: Handle subcommands with no options Message-ID: <20110616184900.42B7342584@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: eed60d55bce716609f6568a7974123272db735a0 https://github.com/buildbot/buildbot/commit/eed60d55bce716609f6568a7974123272db735a0 Author: Dustin J. Mitchell Date: 2011-06-16 (Thu, 16 Jun 2011) Changed paths: M master/buildbot/scripts/runner.py Log Message: ----------- Handle subcommands with no options In particular, checkConfig has no optParameters From noreply at github.com Thu Jun 16 18:49:00 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 16 Jun 2011 11:49:00 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 136fcd: Handle subcommands with no options Message-ID: <20110616184900.35C7042561@smtp1.rs.github.com> Branch: refs/heads/buildbot-0.8.4 Home: https://github.com/buildbot/buildbot Commit: 136fcd397e3185c671208418246d0f840decd4c1 https://github.com/buildbot/buildbot/commit/136fcd397e3185c671208418246d0f840decd4c1 Author: Dustin J. Mitchell Date: 2011-06-16 (Thu, 16 Jun 2011) Changed paths: M master/buildbot/scripts/runner.py Log Message: ----------- Handle subcommands with no options In particular, checkConfig has no optParameters From noreply at github.com Thu Jun 16 19:35:52 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 16 Jun 2011 12:35:52 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 91972b: call reactor.stop correctly in hgbuildbot Message-ID: <20110616193552.538E9425BD@smtp1.rs.github.com> Branch: refs/heads/buildbot-0.8.4 Home: https://github.com/buildbot/buildbot Commit: 91972b36d2970db77196c7a82a9b85e7204482bc https://github.com/buildbot/buildbot/commit/91972b36d2970db77196c7a82a9b85e7204482bc Author: Dustin J. Mitchell Date: 2011-06-16 (Thu, 16 Jun 2011) Changed paths: M master/buildbot/changes/hgbuildbot.py Log Message: ----------- call reactor.stop correctly in hgbuildbot From noreply at github.com Thu Jun 16 19:35:52 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 16 Jun 2011 12:35:52 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 1ba74c: call reactor.stop correctly in hgbuildbot Message-ID: <20110616193552.AE5C2425CA@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 1ba74c5b48ff5821bd286d98232afb4a90297c98 https://github.com/buildbot/buildbot/commit/1ba74c5b48ff5821bd286d98232afb4a90297c98 Author: Dustin J. Mitchell Date: 2011-06-16 (Thu, 16 Jun 2011) Changed paths: M master/buildbot/changes/hgbuildbot.py Log Message: ----------- call reactor.stop correctly in hgbuildbot From nobody at buildbot.net Thu Jun 16 21:01:57 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 16 Jun 2011 21:01:57 -0000 Subject: [Buildbot-commits] [Buildbot] #1990: Source steps falling back to complete re-initialization should not be mandatory Message-ID: <037.a8ad1401ad7ff566359b5a60a33f9e3e@buildbot.net> #1990: Source steps falling back to complete re-initialization should not be mandatory ------------------------+----------------------- Reporter: ayust | Owner: Type: enhancement | Status: new Priority: major | Milestone: undecided Version: 0.8.4 | Keywords: ------------------------+----------------------- Currently, if a source step fails to successfully update to a particular revision, it will always fall back to trying to re-initialize the repository. For some workflows, this is very bad, and it would be highly preferable for the build to just fail instead of nuking its repository and re-creating it. The fallback to a full re-clone (or the equivalent in whatever VCS is being used) should be an option (it's fine if it defaults to on) that can be disabled if necessary. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Jun 16 21:02:37 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 16 Jun 2011 21:02:37 -0000 Subject: [Buildbot-commits] [Buildbot] #1990: Source steps falling back to complete re-initialization should not be mandatory In-Reply-To: <037.a8ad1401ad7ff566359b5a60a33f9e3e@buildbot.net> References: <037.a8ad1401ad7ff566359b5a60a33f9e3e@buildbot.net> Message-ID: <052.cecd9ffb9b5695592d444f97778ffa6a@buildbot.net> #1990: Source steps falling back to complete re-initialization should not be mandatory ------------------------+-------------------- Reporter: ayust | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.4 | Resolution: Keywords: | ------------------------+-------------------- Changes (by dustin): * cc: in3xes (added) * milestone: undecided => 0.8.5 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Jun 17 04:25:08 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 17 Jun 2011 04:25:08 -0000 Subject: [Buildbot-commits] [Buildbot] #1991: connect caching config parameters with caches Message-ID: <038.fbe375da6421a9f61051f97d6be50c10@buildbot.net> #1991: connect caching config parameters with caches ------------------------+---------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.4p1 Version: 0.8.4 | Keywords: database ------------------------+---------------------- I implemented a generic caching system in 0.8.4, but didn't connect it to {{{c['changeCacheSize']}}} -- oops! -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Jun 17 04:25:51 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 17 Jun 2011 04:25:51 -0000 Subject: [Buildbot-commits] [Buildbot] #1992: master hangs on startup Message-ID: <038.f1eada51307e3e3bcc8741685c08d579@buildbot.net> #1992: master hangs on startup -------------------+--------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.4p1 Version: 0.8.4 | Keywords: -------------------+--------------------- Several people have observed this now, although I can't replicate it. The master hangs right after {{{ 2011-06-16 23:25:33-0500 [-] applying SQLite workaround from Buildbot bug #1810 }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Jun 17 04:49:33 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 17 Jun 2011 04:49:33 -0000 Subject: [Buildbot-commits] [Buildbot] #1992: master hangs on startup In-Reply-To: <038.f1eada51307e3e3bcc8741685c08d579@buildbot.net> References: <038.f1eada51307e3e3bcc8741685c08d579@buildbot.net> Message-ID: <053.cc70f00c117b69dca85bdfdb175d0ad9@buildbot.net> #1992: master hangs on startup -------------------+---------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.4p1 Version: 0.8.4 | Resolution: Keywords: | -------------------+---------------------- Comment (by dustin): In one of the logfiles, Buildbot seems to end up sitting in the reactor loop forever {{{ 357 2 python2.6 RET pread 1024/0x400 357 2 python2.6 CALL fcntl(9,8,0xba1fc928) 357 2 python2.6 RET fcntl 0 357 2 python2.6 CALL close(9) 357 2 python2.6 RET close 0 357 2 python2.6 CALL write(6,0xbb842a14,1) 357 2 python2.6 GIO fd 6 wrote 1 bytes "x" 357 2 python2.6 RET write 1 22245 1 python2.6 RET select 1 22245 1 python2.6 CALL read(5,0xbb1e4014,0x2000) 22245 1 python2.6 GIO fd 5 read 1 bytes "x" 22245 1 python2.6 RET read 1 22245 1 python2.6 CALL gettimeofday(0xbfbfd868,0) 22245 1 python2.6 RET gettimeofday 0 22245 1 python2.6 CALL gettimeofday(0xbfbfd868,0) 22245 1 python2.6 RET gettimeofday 0 22245 1 python2.6 CALL select(0xb,0xbfbfd808,0xbfbfd7e8,0xbfbfd7c8,0xbfbfd828) 357 2 python2.6 CALL _lwp_park(0,0,0xbab525d4,0xbab525d4) }}} The first bit is thread 2, pid 357. It finishes its work (database-y stuff), notifies the main thread (by writing an 'x' to a self-pipe), and parks itself. The parent thread gets this byte, then re-enters the select loop. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Jun 18 04:20:42 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 18 Jun 2011 04:20:42 -0000 Subject: [Buildbot-commits] [Buildbot] #1989: gitpoller: repo poll failed In-Reply-To: <047.15fe2481887f15aaa5d34e0dcb912e05@buildbot.net> References: <047.15fe2481887f15aaa5d34e0dcb912e05@buildbot.net> Message-ID: <062.1653f2c8770f817a931a42f20206bb33@buildbot.net> #1989: gitpoller: repo poll failed ----------------------------+------------------------ Reporter: sanlokenpatidar | Owner: Type: support-request | Status: new Priority: major | Milestone: undecided Version: 0.8.2 | Resolution: Keywords: | ----------------------------+------------------------ Comment (by dustin): I suspect that Buildbot is running a different version of git than you are running from the command line. Do you have multiple gits installed? -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Jun 18 04:25:11 2011 From: noreply at github.com (noreply at github.com) Date: Fri, 17 Jun 2011 21:25:11 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] df78cd: Merge branch 'test_hg' of git://github.com/in3xes/... Message-ID: <20110618042511.4002E42810@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: df78cd9091228b195f3829529563d5f8e35980bb https://github.com/buildbot/buildbot/commit/df78cd9091228b195f3829529563d5f8e35980bb Author: Dustin J. Mitchell Date: 2011-06-17 (Fri, 17 Jun 2011) Changed paths: M slave/buildslave/test/unit/test_commands_hg.py Log Message: ----------- Merge branch 'test_hg' of git://github.com/in3xes/buildbot * 'test_hg' of git://github.com/in3xes/buildbot: More tests!! From nobody at buildbot.net Sat Jun 18 04:45:44 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 18 Jun 2011 04:45:44 -0000 Subject: [Buildbot-commits] [Buildbot] #1985: AttributeError: Sender instance has no attribute 'stop' In-Reply-To: <034.c7fa3215a8c9bfcd40264c4761188c7e@buildbot.net> References: <034.c7fa3215a8c9bfcd40264c4761188c7e@buildbot.net> Message-ID: <049.6342ce0949d954f035b447d019053f57@buildbot.net> #1985: AttributeError: Sender instance has no attribute 'stop' ----------------------+---------------------- Reporter: kb | Owner: Type: undecided | Status: closed Priority: critical | Milestone: 0.8.4p1 Version: 0.8.4 | Resolution: fixed Keywords: | ----------------------+---------------------- Changes (by dustin): * milestone: undecided => 0.8.4p1 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Jun 18 04:46:27 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 18 Jun 2011 04:46:27 -0000 Subject: [Buildbot-commits] [Buildbot] #1985: AttributeError: Sender instance has no attribute 'stop' In-Reply-To: <034.c7fa3215a8c9bfcd40264c4761188c7e@buildbot.net> References: <034.c7fa3215a8c9bfcd40264c4761188c7e@buildbot.net> Message-ID: <049.814e5e211591a4baa6b34c18d0f367d7@buildbot.net> #1985: AttributeError: Sender instance has no attribute 'stop' ---------------------+---------------------- Reporter: kb | Owner: Type: defect | Status: closed Priority: critical | Milestone: 0.8.4p1 Version: 0.8.4 | Resolution: fixed Keywords: | ---------------------+---------------------- Changes (by dustin): * type: undecided => defect -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Jun 18 04:46:51 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 18 Jun 2011 04:46:51 -0000 Subject: [Buildbot-commits] [Buildbot] #1986: exceptions.TypeError: a float is required In-Reply-To: <034.92b7bffd0e0fe4c89d4f4c3864d3e1f2@buildbot.net> References: <034.92b7bffd0e0fe4c89d4f4c3864d3e1f2@buildbot.net> Message-ID: <049.e80c609e8d91e771b0dfeb0c90a6c4b6@buildbot.net> #1986: exceptions.TypeError: a float is required -------------------+---------------------- Reporter: kb | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.4p1 Version: 0.8.4 | Resolution: fixed Keywords: | -------------------+---------------------- Changes (by dustin): * type: undecided => defect * milestone: undecided => 0.8.4p1 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Jun 18 05:32:00 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 18 Jun 2011 05:32:00 -0000 Subject: [Buildbot-commits] [Buildbot] #1988: Incompatible change in svn_buildbot.py with steps/source.py In-Reply-To: <040.dbcad89f9d58e4909324601c276b2d89@buildbot.net> References: <040.dbcad89f9d58e4909324601c276b2d89@buildbot.net> Message-ID: <055.5bfa6c4f5c03d5b34f8f68655ce3546f@buildbot.net> #1988: Incompatible change in svn_buildbot.py with steps/source.py ---------------------+---------------------- Reporter: abompard | Owner: Type: defect | Status: closed Priority: blocker | Milestone: 0.8.4p1 Version: 0.8.4 | Resolution: fixed Keywords: svn | ---------------------+---------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: Trying to replicate this. The step is: {{{ f1.addStep(SVN(baseURL='http://svn.r.igoro.us/projects/toys/Processor/', defaultBranch='trunk')) }}} but I'm using a !GitPoller, so the change looks like {{{Change(revision=u'e0f3a1d454e0afb12400c0244b132a68a2e2674b', who=u'dustin at zmanda.com', branch=u'master', comments=u'changed', when=1308374007, category=None, project=u'foo', repository=u'/home/dustin/code/buildbot/t/testrepo/')}}} from what I understand of the bug, I would expect the source step to check out {{{/home/dustin/code/buildbot/t/testrepo/}}}, since that's the repository attribute that will override the svnurl. With Buidbot {{{v0.8.4}}} (the git tag), I do indeed see {{{/usr/bin/svn checkout --non-interactive --no-auth-cache --revision cb51672c9a78188ac99a936e539ca4437a9e6312 /home/dustin/code/buildbot/t/testrepo/@cb51672c9a78188ac99a936e539ca4437a9e6312 build}}} but with the current buildbot-0.8.4 branch (now at [91972b36d2970db77196c7a82a9b85e7204482bc], and which will become 0.8.4p1), I see {{{/usr/bin/svn checkout --non-interactive --no-auth-cache --revision cc81fdfd38308d1eddfb468f42c266f4c1c174ca http://svn.r.igoro.us/projects/toys/Processor/master at cc81fdfd38308d1eddfb468f42c266f4c1c174ca build}}} which is to say that it used the baseurl and appended the branch. I believe the fix was [08885362aa8a82aa3ddb7d0df75db8174d45fafb]. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Jun 18 06:01:13 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 18 Jun 2011 06:01:13 -0000 Subject: [Buildbot-commits] [Buildbot] #1992: master hangs on startup In-Reply-To: <038.f1eada51307e3e3bcc8741685c08d579@buildbot.net> References: <038.f1eada51307e3e3bcc8741685c08d579@buildbot.net> Message-ID: <053.5c78d97fc89c73c336a750dc49030974@buildbot.net> #1992: master hangs on startup -------------------+---------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.4p1 Version: 0.8.4 | Resolution: Keywords: | -------------------+---------------------- Comment (by dustin): Since I'm entirely incapable of replicating this, I need some help. The next thing that happens after the DBThreadPool is initialized (which logs the string in the bug description) is {{{model.is_current}}}. Can you add some print's to that method to see if it's called, and to {{{check_current}}} in {{{master/buildbot/master.py}}} to see that it returns? Also add some prints to {{{loadConfig}}} there. A good way to do that: {{{ #!python def dbg(r, msg): log.msg(msg) return r }}} Then just add something like {{{ #!python d.addCallback(dbg, "HERE 6") }}} to each place in the callback chain where you'd like to check for progress. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Jun 18 14:30:45 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 18 Jun 2011 07:30:45 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] fb2d0d: Remove unnecessary 'gc.collect()' when pruning bui... Message-ID: <20110618143045.746C2421BB@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: fb2d0d0b31308502d763dd8a915aeb8f2103354f https://github.com/buildbot/buildbot/commit/fb2d0d0b31308502d763dd8a915aeb8f2103354f Author: Dustin J. Mitchell Date: 2011-06-18 (Sat, 18 Jun 2011) Changed paths: M master/buildbot/status/builder.py Log Message: ----------- Remove unnecessary 'gc.collect()' when pruning builds This shouldn't be necessary, and at any rate causes synchronous hangs in the master. From nobody at buildbot.net Sun Jun 19 02:39:35 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 19 Jun 2011 02:39:35 -0000 Subject: [Buildbot-commits] [Buildbot] #1992: master hangs on startup In-Reply-To: <038.f1eada51307e3e3bcc8741685c08d579@buildbot.net> References: <038.f1eada51307e3e3bcc8741685c08d579@buildbot.net> Message-ID: <053.65d1bc738fecbc9a9f507a8f5546f01d@buildbot.net> #1992: master hangs on startup -------------------+---------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.4p1 Version: 0.8.4 | Resolution: Keywords: | -------------------+---------------------- Comment (by dustin): I've recorded some notes here: https://gist.github.com/1033514 basically, it looks like sometimes select() doesn't notice that a file descriptor is readable, which makes the selfpipe trick that Twisted uses to support callFromThread nonfunctional. This seems like an enormous bug either in the kernel or in Python. I can't narrow it down further because dtrace doesn't work very well on a Mac - in particular, it doesn't have a way to actually follow child processes (-f doesn't work). So I think that the fix, for now, to get 0.8.4p1 out the door, is to just add a busyloop into the DBThreadPool that runs every second - that will wake up select() and cause things to proceed as desired. It ain't pretty, but without more data, that's all I can do. Once that fix is in on the branch, I'll leave this bug open, to start to collect system statistics about where this occurs. So far, the common thread seems to be *BSD - I know of one NetBSD and two Mac OS X reproductions. I can't reproduce it on my mac. I can reproduce it on redheadphones' mac using Twisted-8.2.0, 9.0.0, and 11.0.0, all with Python-2.6.1. I've seen it replicated with Python-2.7, as well. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Jun 19 03:00:49 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 18 Jun 2011 20:00:49 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 361b81: Add awful hack for startup hangs. Message-ID: <20110619030049.AAA324288C@smtp1.rs.github.com> Branch: refs/heads/buildbot-0.8.4 Home: https://github.com/buildbot/buildbot Commit: 361b81b43fc7793b66facd4bac7abe0adb30f3d5 https://github.com/buildbot/buildbot/commit/361b81b43fc7793b66facd4bac7abe0adb30f3d5 Author: Dustin J. Mitchell Date: 2011-06-18 (Sat, 18 Jun 2011) Changed paths: M master/buildbot/db/pool.py Log Message: ----------- Add awful hack for startup hangs. Refs #1992. Commit: 917d82e85f2966310b7a00a7184de3127b5b9a09 https://github.com/buildbot/buildbot/commit/917d82e85f2966310b7a00a7184de3127b5b9a09 Author: Dustin J. Mitchell Date: 2011-06-18 (Sat, 18 Jun 2011) Changed paths: M master/buildbot/db/pool.py Log Message: ----------- Merge branch 'bug1992' into buildbot-0.8.4 * bug1992: Add awful hack for startup hangs. Compare: https://github.com/buildbot/buildbot/compare/91972b3...917d82e From nobody at buildbot.net Sun Jun 19 03:00:56 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 19 Jun 2011 03:00:56 -0000 Subject: [Buildbot-commits] [Buildbot] #1992: master hangs on startup In-Reply-To: <038.f1eada51307e3e3bcc8741685c08d579@buildbot.net> References: <038.f1eada51307e3e3bcc8741685c08d579@buildbot.net> Message-ID: <053.eaec243de6d369a5380fdfa774f80a5a@buildbot.net> #1992: master hangs on startup -------------------+---------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.4p1 Version: 0.8.4 | Resolution: Keywords: | -------------------+---------------------- Comment (by Dustin J. Mitchell): Add awful hack for startup hangs. Refs #1992. Changeset: 361b81b43fc7793b66facd4bac7abe0adb30f3d5 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Jun 19 03:43:42 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 18 Jun 2011 20:43:42 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] e18c5b: actually load cache configuration from master.cfg Message-ID: <20110619034342.D977C424F6@smtp1.rs.github.com> Branch: refs/heads/buildbot-0.8.4 Home: https://github.com/buildbot/buildbot Commit: e18c5b4673dc02c615fcbf85ee6eab1382cbbc04 https://github.com/buildbot/buildbot/commit/e18c5b4673dc02c615fcbf85ee6eab1382cbbc04 Author: Dustin J. Mitchell Date: 2011-06-18 (Sat, 18 Jun 2011) Changed paths: M master/buildbot/master.py Log Message: ----------- actually load cache configuration from master.cfg Commit: f8d6ec3181c55cbeb61b8bee198650d37ddc1bfc https://github.com/buildbot/buildbot/commit/f8d6ec3181c55cbeb61b8bee198650d37ddc1bfc Author: Dustin J. Mitchell Date: 2011-06-18 (Sat, 18 Jun 2011) Changed paths: M master/docs/cfg-global.texinfo Log Message: ----------- Document the new c['caches'] config Compare: https://github.com/buildbot/buildbot/compare/917d82e...f8d6ec3 From nobody at buildbot.net Sun Jun 19 03:47:45 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 19 Jun 2011 03:47:45 -0000 Subject: [Buildbot-commits] [Buildbot] #1992: master hangs on startup In-Reply-To: <038.f1eada51307e3e3bcc8741685c08d579@buildbot.net> References: <038.f1eada51307e3e3bcc8741685c08d579@buildbot.net> Message-ID: <053.eea179af682928ad8143ae16c07274b5@buildbot.net> #1992: master hangs on startup -------------------+-------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.4 | Resolution: Keywords: | -------------------+-------------------- Changes (by dustin): * milestone: 0.8.4p1 => 0.8.5 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jun 19 03:48:36 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 19 Jun 2011 03:48:36 -0000 Subject: [Buildbot-commits] [Buildbot] #1991: connect caching config parameters with caches In-Reply-To: <038.fbe375da6421a9f61051f97d6be50c10@buildbot.net> References: <038.fbe375da6421a9f61051f97d6be50c10@buildbot.net> Message-ID: <053.ed7a1d2bbc91ac2fa78cdad134c7de56@buildbot.net> #1991: connect caching config parameters with caches ------------------------+---------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.4p1 Version: 0.8.4 | Resolution: Keywords: database | ------------------------+---------------------- Comment (by dustin): [e18c5b4673dc02c615fcbf85ee6eab1382cbbc04] and [f8d6ec3181c55cbeb61b8bee198650d37ddc1bfc] take care of loading this config and documenting it, respectively, for 0.8.4p1. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jun 19 03:49:12 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 19 Jun 2011 03:49:12 -0000 Subject: [Buildbot-commits] [Buildbot] #1993: gather metrics on caches, move buildbot.cache to buildbot.process.cache Message-ID: <038.854b70c21a54c61567d5570d877938de@buildbot.net> #1993: gather metrics on caches, move buildbot.cache to buildbot.process.cache ------------------------+------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.4 | Keywords: ------------------------+------------------- -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Jun 19 04:47:43 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 18 Jun 2011 21:47:43 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 7f4527: update NEWS for 0.8.4p1 Message-ID: <20110619044743.EAF6C42758@smtp1.rs.github.com> Branch: refs/heads/buildbot-0.8.4 Home: https://github.com/buildbot/buildbot Commit: 7f4527fef5d427a11d6cdf9f47dcb6e5865fc421 https://github.com/buildbot/buildbot/commit/7f4527fef5d427a11d6cdf9f47dcb6e5865fc421 Author: Dustin J. Mitchell Date: 2011-06-18 (Sat, 18 Jun 2011) Changed paths: M master/NEWS Log Message: ----------- update NEWS for 0.8.4p1 From nobody at buildbot.net Sun Jun 19 05:47:51 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 19 Jun 2011 05:47:51 -0000 Subject: [Buildbot-commits] [Buildbot] #1994: means to add periodic metrics checks without modifying metrics.py Message-ID: <038.b56737ac909022111234e0752d46f619@buildbot.net> #1994: means to add periodic metrics checks without modifying metrics.py ------------------------+------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.5 Version: 0.8.4p1 | Keywords: ------------------------+------------------- It would be great to be able to register a particular metric for monitoring during the periodicCheck in metrics.py. In particular, I'd like to hook {{{master.caches.get_metrics()}}} up for periodic monitoring. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Jun 19 05:58:05 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 18 Jun 2011 22:58:05 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 0ee9e1: actually load cache configuration from master.cfg Message-ID: <20110619055805.C9219427A5@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 0ee9e11589910689665c30a341e765130746b50e https://github.com/buildbot/buildbot/commit/0ee9e11589910689665c30a341e765130746b50e Author: Dustin J. Mitchell Date: 2011-06-18 (Sat, 18 Jun 2011) Changed paths: M master/buildbot/master.py Log Message: ----------- actually load cache configuration from master.cfg Commit: c8d35b4205d46d86f9f368313b0e95ea56d5c6f1 https://github.com/buildbot/buildbot/commit/c8d35b4205d46d86f9f368313b0e95ea56d5c6f1 Author: Dustin J. Mitchell Date: 2011-06-18 (Sat, 18 Jun 2011) Changed paths: R master/buildbot/cache.py M master/buildbot/master.py A master/buildbot/process/cache.py R master/buildbot/test/unit/test_cache.py A master/buildbot/test/unit/test_process_cache.py M master/buildbot/util/lru.py Log Message: ----------- move buildbot.cache to buildbot.process.cache Adds another test and another key to the get_metrics method, too. Commit: e34a0d15e35749b57bf4b40ebcbb52ff364e08db https://github.com/buildbot/buildbot/commit/e34a0d15e35749b57bf4b40ebcbb52ff364e08db Author: Dustin J. Mitchell Date: 2011-06-18 (Sat, 18 Jun 2011) Changed paths: M master/docs/cfg-global.texinfo Log Message: ----------- Document the new c['caches'] config Commit: e5435ef9177a12d53ff2ffe3b62f1f32416eba54 https://github.com/buildbot/buildbot/commit/e5435ef9177a12d53ff2ffe3b62f1f32416eba54 Author: Dustin J. Mitchell Date: 2011-06-18 (Sat, 18 Jun 2011) Changed paths: M common/gcode-upload.sh Log Message: ----------- update gcode-upload to upload all files Commit: a1480b805115ad293b6bda0e4c78b52e2a6fac5a https://github.com/buildbot/buildbot/commit/a1480b805115ad293b6bda0e4c78b52e2a6fac5a Author: Dustin J. Mitchell Date: 2011-06-18 (Sat, 18 Jun 2011) Changed paths: R master/buildbot/cache.py M master/buildbot/master.py A master/buildbot/process/cache.py R master/buildbot/test/unit/test_cache.py A master/buildbot/test/unit/test_process_cache.py M master/buildbot/util/lru.py M master/docs/cfg-global.texinfo Log Message: ----------- Merge branch 'cacheconfig' * cacheconfig: Document the new c['caches'] config move buildbot.cache to buildbot.process.cache actually load cache configuration from master.cfg Fixes #1991. Compare: https://github.com/buildbot/buildbot/compare/fb2d0d0...a1480b8 From nobody at buildbot.net Sun Jun 19 05:58:15 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 19 Jun 2011 05:58:15 -0000 Subject: [Buildbot-commits] [Buildbot] #1991: connect caching config parameters with caches In-Reply-To: <038.fbe375da6421a9f61051f97d6be50c10@buildbot.net> References: <038.fbe375da6421a9f61051f97d6be50c10@buildbot.net> Message-ID: <053.f135cdd8a5d61d1f811b7426f4cc4ca5@buildbot.net> #1991: connect caching config parameters with caches ------------------------+---------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.4p1 Version: 0.8.4 | Resolution: fixed Keywords: database | ------------------------+---------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Merge branch 'cacheconfig' * cacheconfig: Document the new c['caches'] config move buildbot.cache to buildbot.process.cache actually load cache configuration from master.cfg Fixes #1991. Changeset: a1480b805115ad293b6bda0e4c78b52e2a6fac5a -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jun 19 17:52:17 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 19 Jun 2011 17:52:17 -0000 Subject: [Buildbot-commits] [Buildbot] #1995: suppressionFile causes traceback on slave Message-ID: <039.8d8fe69235940f39ee1d0cd2f8c50acd@buildbot.net> #1995: suppressionFile causes traceback on slave ----------------------+----------------------- Reporter: pworach | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.4p1 | Keywords: ----------------------+----------------------- 2011-06-19 16:23:22+0000 [-] command finished with signal None, exit code 0, elapsedTime: 22.841655 2011-06-19 16:23:22+0000 [-] SlaveBuilder.commandComplete 2011-06-19 16:23:22+0000 [Broker,client] Peer will receive following PB traceback: 2011-06-19 16:23:22+0000 [Broker,client] Unhandled Error Traceback (most recent call last): File "/usr/local/lib/python2.7/site- packages/twisted/spread/banana.py", line 153, in gotItem self.callExpressionReceived(item) File "/usr/local/lib/python2.7/site- packages/twisted/spread/banana.py", line 116, in callExpressionReceived self.expressionReceived(obj) File "/usr/local/lib/python2.7/site- packages/twisted/spread/pb.py", line 514, in expressionReceived method(*sexp[1:]) File "/usr/local/lib/python2.7/site- packages/twisted/spread/pb.py", line 826, in proto_message self._recvMessage(self.localObjectForID, requestID, objectID, message, answerRequired, netArgs, netKw) --- --- File "/usr/local/lib/python2.7/site- packages/twisted/spread/pb.py", line 840, in _recvMessage netResult = object.remoteMessageReceived(self, message, netArgs, netKw) File "/usr/local/lib/python2.7/site- packages/twisted/spread/flavors.py", line 114, in remoteMessageReceived state = method(*args, **kw) File "/usr/local/lib/python2.7/site-packages/buildslave/bot.py", line 136, in remote_startCommand self.command = factory(self, stepId, args) File "/usr/local/lib/python2.7/site- packages/buildslave/commands/base.py", line 135, in __init__ self.setup(args) File "/usr/local/lib/python2.7/site- packages/buildslave/commands/transfer.py", line 68, in setup self.keepstamp = args['keepstamp'] exceptions.KeyError: 'keepstamp' 2011-06-19 16:31:30+0000 [-] sending app-level keepalive The step is: WarningCountingShellCommand(name="compile-freebsd-world", command=["make", WithProperties("-j%(jobs)s"), " buildworld", "NO_WERROR=", "NO_CLEAN=", "WITHOUT_LIB32=", "WITHOUT_PROFILE="], env={'__MAKE_CONF' : '/dev/null', 'CC' : WithProperties("/data/buildslave/%(b uildername)s/obj/obj-llvm.2/Release+Asserts/bin/clang"), 'CXX' : WithProperties("/data/buildslave/%( buildername)s/obj/obj-llvm.2/Release+Asserts/bin/clang++"), 'MAKEOBJDIRPREFIX' : WithProperties("/data/ buildslave/%(buildername)s/obj/obj-freebsd"),}, workdir="src-freebsd", haltOnFailure=True, suppressionFile="../../warnings.supp", description=["compiling freebsd", "world"], descriptionDone=["compile freebsd", "world"]), -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jun 19 17:53:11 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 19 Jun 2011 17:53:11 -0000 Subject: [Buildbot-commits] [Buildbot] #1995: suppressionFile causes traceback on slave In-Reply-To: <039.8d8fe69235940f39ee1d0cd2f8c50acd@buildbot.net> References: <039.8d8fe69235940f39ee1d0cd2f8c50acd@buildbot.net> Message-ID: <054.65902e3c32a423c0ec19931487053d53@buildbot.net> #1995: suppressionFile causes traceback on slave --------------------+-------------------- Reporter: pworach | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: Keywords: | --------------------+-------------------- Changes (by dustin): * type: undecided => defect * milestone: undecided => 0.8.5 Old description: > 2011-06-19 16:23:22+0000 [-] command finished with signal None, exit code > 0, elapsedTime: 22.841655 > 2011-06-19 16:23:22+0000 [-] SlaveBuilder.commandComplete > > 2011-06-19 16:23:22+0000 [Broker,client] Peer will receive following PB > traceback: > 2011-06-19 16:23:22+0000 [Broker,client] Unhandled Error > Traceback (most recent call last): > File "/usr/local/lib/python2.7/site- > packages/twisted/spread/banana.py", line 153, in gotItem > self.callExpressionReceived(item) > File "/usr/local/lib/python2.7/site- > packages/twisted/spread/banana.py", line 116, in callExpressionReceived > self.expressionReceived(obj) > File "/usr/local/lib/python2.7/site- > packages/twisted/spread/pb.py", line 514, in expressionReceived > method(*sexp[1:]) > File "/usr/local/lib/python2.7/site- > packages/twisted/spread/pb.py", line 826, in proto_message > self._recvMessage(self.localObjectForID, requestID, objectID, > message, answerRequired, netArgs, netKw) > --- --- > File "/usr/local/lib/python2.7/site- > packages/twisted/spread/pb.py", line 840, in _recvMessage > netResult = object.remoteMessageReceived(self, message, > netArgs, netKw) > File "/usr/local/lib/python2.7/site- > packages/twisted/spread/flavors.py", line 114, in remoteMessageReceived > state = method(*args, **kw) > File "/usr/local/lib/python2.7/site- > packages/buildslave/bot.py", line 136, in remote_startCommand > self.command = factory(self, stepId, args) > File "/usr/local/lib/python2.7/site- > packages/buildslave/commands/base.py", line 135, in __init__ > self.setup(args) > File "/usr/local/lib/python2.7/site- > packages/buildslave/commands/transfer.py", line 68, in setup > self.keepstamp = args['keepstamp'] > exceptions.KeyError: 'keepstamp' > > 2011-06-19 16:31:30+0000 [-] sending app-level keepalive > > The step is: > WarningCountingShellCommand(name="compile-freebsd-world", > command=["make", > WithProperties("-j%(jobs)s"), " > buildworld", "NO_WERROR=", "NO_CLEAN=", "WITHOUT_LIB32=", > "WITHOUT_PROFILE="], > env={'__MAKE_CONF' : '/dev/null', > 'CC' : > WithProperties("/data/buildslave/%(b > uildername)s/obj/obj-llvm.2/Release+Asserts/bin/clang"), > 'CXX' : > WithProperties("/data/buildslave/%( > buildername)s/obj/obj-llvm.2/Release+Asserts/bin/clang++"), > 'MAKEOBJDIRPREFIX' : > WithProperties("/data/ > buildslave/%(buildername)s/obj/obj-freebsd"),}, > workdir="src-freebsd", > haltOnFailure=True, > suppressionFile="../../warnings.supp", > description=["compiling freebsd", > "world"], > descriptionDone=["compile freebsd", > "world"]), New description: {{{ 2011-06-19 16:23:22+0000 [-] command finished with signal None, exit code 0, elapsedTime: 22.841655 2011-06-19 16:23:22+0000 [-] SlaveBuilder.commandComplete 2011-06-19 16:23:22+0000 [Broker,client] Peer will receive following PB traceback: 2011-06-19 16:23:22+0000 [Broker,client] Unhandled Error Traceback (most recent call last): File "/usr/local/lib/python2.7/site- packages/twisted/spread/banana.py", line 153, in gotItem self.callExpressionReceived(item) File "/usr/local/lib/python2.7/site- packages/twisted/spread/banana.py", line 116, in callExpressionReceived self.expressionReceived(obj) File "/usr/local/lib/python2.7/site- packages/twisted/spread/pb.py", line 514, in expressionReceived method(*sexp[1:]) File "/usr/local/lib/python2.7/site- packages/twisted/spread/pb.py", line 826, in proto_message self._recvMessage(self.localObjectForID, requestID, objectID, message, answerRequired, netArgs, netKw) --- --- File "/usr/local/lib/python2.7/site- packages/twisted/spread/pb.py", line 840, in _recvMessage netResult = object.remoteMessageReceived(self, message, netArgs, netKw) File "/usr/local/lib/python2.7/site- packages/twisted/spread/flavors.py", line 114, in remoteMessageReceived state = method(*args, **kw) File "/usr/local/lib/python2.7/site-packages/buildslave/bot.py", line 136, in remote_startCommand self.command = factory(self, stepId, args) File "/usr/local/lib/python2.7/site- packages/buildslave/commands/base.py", line 135, in __init__ self.setup(args) File "/usr/local/lib/python2.7/site- packages/buildslave/commands/transfer.py", line 68, in setup self.keepstamp = args['keepstamp'] exceptions.KeyError: 'keepstamp' 2011-06-19 16:31:30+0000 [-] sending app-level keepalive }}} The step is: {{{ WarningCountingShellCommand(name="compile-freebsd-world", command=["make", WithProperties("-j%(jobs)s"), " buildworld", "NO_WERROR=", "NO_CLEAN=", "WITHOUT_LIB32=", "WITHOUT_PROFILE="], env={'__MAKE_CONF' : '/dev/null', 'CC' : WithProperties("/data/buildslave/%(b uildername)s/obj/obj-llvm.2/Release+Asserts/bin/clang"), 'CXX' : WithProperties("/data/buildslave/%( buildername)s/obj/obj-llvm.2/Release+Asserts/bin/clang++"), 'MAKEOBJDIRPREFIX' : WithProperties("/data/ buildslave/%(buildername)s/obj/obj-freebsd"),}, workdir="src-freebsd", haltOnFailure=True, suppressionFile="../../warnings.supp", description=["compiling freebsd", "world"], descriptionDone=["compile freebsd", "world"]), }}} -- -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jun 19 17:54:52 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 19 Jun 2011 17:54:52 -0000 Subject: [Buildbot-commits] [Buildbot] #1995: suppressionFile causes traceback on slave In-Reply-To: <039.8d8fe69235940f39ee1d0cd2f8c50acd@buildbot.net> References: <039.8d8fe69235940f39ee1d0cd2f8c50acd@buildbot.net> Message-ID: <054.ad2cc3fd2611d429d7f9d69716b1f17e@buildbot.net> #1995: suppressionFile causes traceback on slave --------------------+-------------------- Reporter: pworach | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: Keywords: | --------------------+-------------------- Comment (by dustin): It looks like [7c4eb59d6ef0db0de91f8d0673fe7793e7eb978c] {{{ Author: nate Date: Wed May 11 14:56:10 2011 -0400 Added optional keepstamp argument for FileUpload buildstep, that, when True, forces the timestamp of the destination file to match the source file. }}} should have made the argument optional on the slave side. Easy enough to fix, although this will still be a problem for 0.8.4 slaves. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Jun 19 17:57:30 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 19 Jun 2011 10:57:30 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 230e71: Make the keepstamp uploadFile argument optionsl Message-ID: <20110619175730.5999C42716@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 230e71d9329ab2d331c817ea8b0a063f4a41263f https://github.com/buildbot/buildbot/commit/230e71d9329ab2d331c817ea8b0a063f4a41263f Author: Dustin J. Mitchell Date: 2011-06-19 (Sun, 19 Jun 2011) Changed paths: M slave/buildslave/commands/transfer.py Log Message: ----------- Make the keepstamp uploadFile argument optionsl This command is used not just from UploadFile steps, but from WarningCountingShellCommand and, soon, from source steps. This was my fault for not being careful about protocol changes. Fixes #1995. From nobody at buildbot.net Sun Jun 19 17:57:38 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 19 Jun 2011 17:57:38 -0000 Subject: [Buildbot-commits] [Buildbot] #1995: suppressionFile causes traceback on slave In-Reply-To: <039.8d8fe69235940f39ee1d0cd2f8c50acd@buildbot.net> References: <039.8d8fe69235940f39ee1d0cd2f8c50acd@buildbot.net> Message-ID: <054.d86fb18a56da1f0bfd75e1e708460869@buildbot.net> #1995: suppressionFile causes traceback on slave --------------------+--------------------- Reporter: pworach | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: fixed Keywords: | --------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Make the keepstamp uploadFile argument optionsl This command is used not just from UploadFile steps, but from WarningCountingShellCommand and, soon, from source steps. This was my fault for not being careful about protocol changes. Fixes #1995. Changeset: 230e71d9329ab2d331c817ea8b0a063f4a41263f -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jun 19 18:47:40 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 19 Jun 2011 18:47:40 -0000 Subject: [Buildbot-commits] [Buildbot] #1996: Unit tests for all master-side step classes Message-ID: <038.fa889d5ae09b11a4ade895ae61216175@buildbot.net> #1996: Unit tests for all master-side step classes ------------------------+------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.4p1 | Keywords: ------------------------+------------------- This is *looong* overdue. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jun 19 18:48:35 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 19 Jun 2011 18:48:35 -0000 Subject: [Buildbot-commits] [Buildbot] #1997: Gather metrics on query times Message-ID: <038.4bd8ecf10d4329234239e94424221dc5@buildbot.net> #1997: Gather metrics on query times ------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.4p1 | Keywords: metrics ------------------------+--------------------- Add a decorator for DB connector components that can time how long a method takes and add a metric for it. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jun 19 18:48:51 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 19 Jun 2011 18:48:51 -0000 Subject: [Buildbot-commits] [Buildbot] #1993: gather metrics on caches, move buildbot.cache to buildbot.process.cache In-Reply-To: <038.854b70c21a54c61567d5570d877938de@buildbot.net> References: <038.854b70c21a54c61567d5570d877938de@buildbot.net> Message-ID: <053.88c2d02407bca572ba83a5f503659fa0@buildbot.net> #1993: gather metrics on caches, move buildbot.cache to buildbot.process.cache ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.4 | Resolution: Keywords: metrics | ------------------------+-------------------- Changes (by dustin): * keywords: => metrics -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jun 19 18:48:53 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 19 Jun 2011 18:48:53 -0000 Subject: [Buildbot-commits] [Buildbot] #1994: means to add periodic metrics checks without modifying metrics.py In-Reply-To: <038.b56737ac909022111234e0752d46f619@buildbot.net> References: <038.b56737ac909022111234e0752d46f619@buildbot.net> Message-ID: <053.276058d724d7784a6ff23663b1253eb4@buildbot.net> #1994: means to add periodic metrics checks without modifying metrics.py ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: Keywords: metrics | ------------------------+-------------------- Changes (by dustin): * keywords: => metrics -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jun 19 20:44:48 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 19 Jun 2011 20:44:48 -0000 Subject: [Buildbot-commits] [Buildbot] #1998: pageTitle not properly set in rss / atom feed Message-ID: <039.37367c826a60ee12aa02c5cf6eff61a0@buildbot.net> #1998: pageTitle not properly set in rss / atom feed ----------------------+----------------------- Reporter: pworach | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.4p1 | Keywords: ----------------------+----------------------- The RSS and ATOM feeds no longer set the pageTitle which results in the feed having a title of "Build status of None". Regression from 0.8.3. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Jun 20 04:19:00 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 20 Jun 2011 04:19:00 -0000 Subject: [Buildbot-commits] [Buildbot] #1945: add systemwide metrics support In-Reply-To: <038.0c124240b73136321a9564af7cffc13a@buildbot.net> References: <038.0c124240b73136321a9564af7cffc13a@buildbot.net> Message-ID: <053.9f248d9b4d2cf2832a151d0d975d5582@buildbot.net> #1945: add systemwide metrics support ------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: critical | Milestone: 0.8.5 Version: master | Resolution: fixed Keywords: performance | ------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: This has landed now. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Jun 20 04:30:33 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 20 Jun 2011 04:30:33 -0000 Subject: [Buildbot-commits] [Buildbot] #1999: Include full filename in warnings, if known Message-ID: <038.f221fd663ade2a5e8f70cee6b8df17c6@buildbot.net> #1999: Include full filename in warnings, if known ------------------------+------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.4p1 | Keywords: ------------------------+------------------- !WarningCountingShellCommand can collect full pathnames by minding the enter/leave dirs. However, the resulting "warnings (%d)" logfile does not include the full filename, and in fact also omits the enter/leave context that would help a human locate the warnings. The warnings log could be in HTML, and include the full pathname and line number gleaned from the processing of the compiler logs. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Jun 20 05:15:24 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 19 Jun 2011 22:15:24 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] d6b33a: Remove spurious deprecation warning Message-ID: <20110620051524.D27F24280D@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: d6b33ade2275e6560a7de65bed96b2b7733b0c20 https://github.com/buildbot/buildbot/commit/d6b33ade2275e6560a7de65bed96b2b7733b0c20 Author: Dave Abrahams Date: 2011-06-19 (Sun, 19 Jun 2011) Changed paths: M master/buildbot/schedulers/basic.py Log Message: ----------- Remove spurious deprecation warning Commit: 3008834ffab837383fb8464ce1aed44851e9a8d4 https://github.com/buildbot/buildbot/commit/3008834ffab837383fb8464ce1aed44851e9a8d4 Author: Dustin J. Mitchell Date: 2011-06-19 (Sun, 19 Jun 2011) Changed paths: M master/buildbot/schedulers/basic.py Log Message: ----------- Merge branch 'master' of git://github.com/dabrahams/buildbot * 'master' of git://github.com/dabrahams/buildbot: Remove spurious deprecation warning Compare: https://github.com/buildbot/buildbot/compare/230e71d...3008834 From noreply at github.com Mon Jun 20 05:43:19 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 19 Jun 2011 22:43:19 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 50caae: better handling of command identifiers Message-ID: <20110620054319.B67C842716@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 50caae91eb49fc387ad2e2f1f07c6bd7c78e9a8d https://github.com/buildbot/buildbot/commit/50caae91eb49fc387ad2e2f1f07c6bd7c78e9a8d Author: Dustin J. Mitchell Date: 2011-06-19 (Sun, 19 Jun 2011) Changed paths: M master/buildbot/process/buildstep.py Log Message: ----------- better handling of command identifiers Fixes #1984. From nobody at buildbot.net Mon Jun 20 05:43:31 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 20 Jun 2011 05:43:31 -0000 Subject: [Buildbot-commits] [Buildbot] #1984: fix RemoteCommand.commandCounter In-Reply-To: <038.a0bd76349300385273417edb3be02498@buildbot.net> References: <038.a0bd76349300385273417edb3be02498@buildbot.net> Message-ID: <053.efa511f91ea23e35256163ba1fb15172@buildbot.net> #1984: fix RemoteCommand.commandCounter ------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.5 Version: 0.8.4 | Resolution: fixed Keywords: simple | ------------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: better handling of command identifiers Fixes #1984. Changeset: 50caae91eb49fc387ad2e2f1f07c6bd7c78e9a8d -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Jun 20 05:45:07 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 19 Jun 2011 22:45:07 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] ec09a0: Merge branch 'bug1982' Message-ID: <20110620054507.C3027428CD@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: ec09a04a6f32668aa3ca893a190f231e51b808db https://github.com/buildbot/buildbot/commit/ec09a04a6f32668aa3ca893a190f231e51b808db Author: Dustin J. Mitchell Date: 2011-06-19 (Sun, 19 Jun 2011) Changed paths: M slave/buildslave/pbutil.py Log Message: ----------- Merge branch 'bug1982' * bug1982: Retry on UnauthorizedLogin From nobody at buildbot.net Mon Jun 20 05:46:39 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 20 Jun 2011 05:46:39 -0000 Subject: [Buildbot-commits] [Buildbot] #1830: Add a warning for logfiles if the log file does not exist or is not found (was: ER : Add a warning for logfiles if the log file does not exist or is not found) In-Reply-To: <039.372e33a57b836ef962d4796cba2c0ee3@buildbot.net> References: <039.372e33a57b836ef962d4796cba2c0ee3@buildbot.net> Message-ID: <054.e3264d390992d03260cd922a1f3aa958@buildbot.net> #1830: Add a warning for logfiles if the log file does not exist or is not found ------------------------+-------------------- Reporter: darshie | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.3 | Resolution: Keywords: | ------------------------+-------------------- -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Jun 20 05:48:26 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 20 Jun 2011 05:48:26 -0000 Subject: [Buildbot-commits] [Buildbot] #1982: handle UnauthorizedLogin exceptions on the slave In-Reply-To: <038.49b407b112985b94d46c112a32adfa15@buildbot.net> References: <038.49b407b112985b94d46c112a32adfa15@buildbot.net> Message-ID: <053.44413c6af1f207387e8f2cef389db3ff@buildbot.net> #1982: handle UnauthorizedLogin exceptions on the slave ------------------------+--------------------- Reporter: dustin | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.5 Version: 0.8.3p1 | Resolution: fixed Keywords: | ------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: merged - [ec09a04a6f32668aa3ca893a190f231e51b808db] -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Jun 20 16:16:33 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 20 Jun 2011 16:16:33 -0000 Subject: [Buildbot-commits] [Buildbot] #2000: "alwaysUseLatest" doesn't do what it says Message-ID: <041.16f29ce554aad5e31a1a961ab126f0d3@buildbot.net> #2000: "alwaysUseLatest" doesn't do what it says ----------------------+----------------------- Reporter: dabrahams | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4p1 | Keywords: git ----------------------+----------------------- I have a project that uses 3 git repos with "alwaysUseLatest" set. ?The fetch failed because when I checked in on a new branch in one repo, it tried to fetch that branch in the other repos as well, but no branch with that name exists there. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Jun 20 17:57:27 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 20 Jun 2011 17:57:27 -0000 Subject: [Buildbot-commits] [Buildbot] #2001: check docs for WithProperties and callables Message-ID: <038.f19ca37e2589bca9efff39d61a4c48ef@buildbot.net> #2001: check docs for WithProperties and callables ------------------------+------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.4p1 | Keywords: docs ------------------------+------------------- The object passed to a callable for WithProperties has changed - it's now a Build instance and not a Properties instance. Check that it was updated in the docs, and that the "normal" behavior (x.getProperty(..)) still works. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Jun 20 17:59:12 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 20 Jun 2011 17:59:12 -0000 Subject: [Buildbot-commits] [Buildbot] #2001: check docs for WithProperties and callables In-Reply-To: <038.f19ca37e2589bca9efff39d61a4c48ef@buildbot.net> References: <038.f19ca37e2589bca9efff39d61a4c48ef@buildbot.net> Message-ID: <053.3477870575d056d5c540f319d4f72215@buildbot.net> #2001: check docs for WithProperties and callables ------------------------+-------------------- Reporter: dustin | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: Keywords: docs | ------------------------+-------------------- Comment (by dabrahams): Replying to [ticket:2001 dustin]: > and that the "normal" behavior (x.getProperty(..)) still works. Check that it works with self and two other arguments (it doesn't for me) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Jun 20 19:59:02 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 20 Jun 2011 19:59:02 -0000 Subject: [Buildbot-commits] [Buildbot] #2002: fatal: Could not parse object ... Message-ID: <041.c21b140f847f382869047b89968a3b37@buildbot.net> #2002: fatal: Could not parse object ... ----------------------+----------------------- Reporter: dabrahams | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4p1 | Keywords: git ----------------------+----------------------- This problem with Git has occurred with other projects, e.g. [https://github.com/capistrano/capistrano/commit/15e9ed54d8b2db039fbe7dd76413ad92db40fb9a Capistrano] and [https://github.com/valodzka/chef/commit/e5ee68982a55adba6709f1f322a34a9e3863dc44 Chef]. The problem appears to be the {{{-t}}} [https://github.com/buildbot/buildbot/blob/master/slave/buildslave/commands/git.py#L149 here], which is unfortunate... but it should be possible to fix this entirely on the master side by making the slave side run ordinary shell commands, shouldn't it? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Jun 20 20:26:25 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 20 Jun 2011 20:26:25 -0000 Subject: [Buildbot-commits] [Buildbot] #2002: fatal: Could not parse object ... In-Reply-To: <041.c21b140f847f382869047b89968a3b37@buildbot.net> References: <041.c21b140f847f382869047b89968a3b37@buildbot.net> Message-ID: <056.ff0ff46bf03f3d49db615dee766f793d@buildbot.net> #2002: fatal: Could not parse object ... ----------------------+------------------------ Reporter: dabrahams | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4p1 | Resolution: Keywords: git | ----------------------+------------------------ Comment (by dabrahams): Background: * {{{git fetch -t}}} is the same as {{{git fetch --tags}}} * the links labeled Capistrano and Chef actually point at the tickets where those projects explain and fixed the same problem * see http://bbot.boostpro.com/builders/Boost.Modularize-x-Modularize/builds/69/steps/Git(boost)/logs/stdio for an example of the problem's effects -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Jun 20 20:43:56 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 20 Jun 2011 20:43:56 -0000 Subject: [Buildbot-commits] [Buildbot] #2003: SingleBranchScheduler not available from buildbot.scheduler Message-ID: <043.8d2d386e3d0fc85e6ac3cbd5ef6adb21@buildbot.net> #2003: SingleBranchScheduler not available from buildbot.scheduler ------------------------+----------------------- Reporter: adamcollard | Owner: Type: undecided | Status: new Priority: minor | Milestone: undecided Version: 0.8.4p1 | Keywords: ------------------------+----------------------- After upgrading to 0.8.4, I fixed the WARNINGs from a reconfig and renamed Scheduler to SingleBranchScheduler. This didn't work, since Scheduler came from buildbot.scheduler, and SingleBranchScheduler is only available in buildbot.schedulers.basic. This could either be a case for enhancing the docs to highlight the difference, or (preferred from my point of view) adding SingleBranchScheduler to buildbot.scheduler -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Jun 20 20:48:02 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 20 Jun 2011 20:48:02 -0000 Subject: [Buildbot-commits] [Buildbot] #2004: Documentation still refers to deprecated Scheduler Message-ID: <043.8a07e0e8d07d7cafeb352270831102f3@buildbot.net> #2004: Documentation still refers to deprecated Scheduler ------------------------+----------------------- Reporter: adamcollard | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: 0.8.4p1 | Keywords: docs ------------------------+----------------------- http://buildbot.net/buildbot/docs/latest/Configuring-Schedulers.html #Configuring-Schedulers Note that someone naively following the documentation here would end up creating a configuration with a deprecated name for SingleBranchScheduler -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jun 21 02:17:00 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 21 Jun 2011 02:17:00 -0000 Subject: [Buildbot-commits] [Buildbot] #2003: SingleBranchScheduler not available from buildbot.scheduler In-Reply-To: <043.8d2d386e3d0fc85e6ac3cbd5ef6adb21@buildbot.net> References: <043.8d2d386e3d0fc85e6ac3cbd5ef6adb21@buildbot.net> Message-ID: <058.f8d7a97bfe87bc740b1f50eef733d042@buildbot.net> #2003: SingleBranchScheduler not available from buildbot.scheduler ------------------------+------------------------ Reporter: adamcollard | Owner: Type: undecided | Status: new Priority: minor | Milestone: undecided Version: 0.8.4p1 | Resolution: Keywords: | ------------------------+------------------------ Comment (by dustin): I'd actually rather improve the docs and the error message - I don't want folks importing from {{{buildbot.scheduler}}} anymore. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jun 21 02:17:22 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 21 Jun 2011 02:17:22 -0000 Subject: [Buildbot-commits] [Buildbot] #2003: SingleBranchScheduler not available from buildbot.scheduler In-Reply-To: <043.8d2d386e3d0fc85e6ac3cbd5ef6adb21@buildbot.net> References: <043.8d2d386e3d0fc85e6ac3cbd5ef6adb21@buildbot.net> Message-ID: <058.e17ae262693a5485852026dae887eff2@buildbot.net> #2003: SingleBranchScheduler not available from buildbot.scheduler ------------------------+-------------------- Reporter: adamcollard | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: Keywords: | ------------------------+-------------------- Changes (by dustin): * type: undecided => defect * milestone: undecided => 0.8.5 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Tue Jun 21 02:24:00 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 20 Jun 2011 19:24:00 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] a19642: s/Scheduler/SingleBranchScheduler/. Fixes #2004 Message-ID: <20110621022400.BADBF428E0@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: a1964220dd4cc4cce97849261e9d4c691103d885 https://github.com/buildbot/buildbot/commit/a1964220dd4cc4cce97849261e9d4c691103d885 Author: Adam Collard Date: 2011-06-20 (Mon, 20 Jun 2011) Changed paths: M master/docs/cfg-schedulers.texinfo Log Message: ----------- s/Scheduler/SingleBranchScheduler/. Fixes #2004 Commit: a17b1833c8d0afead53b01dc14805d8581f4cb6d https://github.com/buildbot/buildbot/commit/a17b1833c8d0afead53b01dc14805d8581f4cb6d Author: Dustin J. Mitchell Date: 2011-06-20 (Mon, 20 Jun 2011) Changed paths: M master/buildbot/schedulers/basic.py M master/docs/cfg-schedulers.texinfo Log Message: ----------- Point to new import location in warning for Scheduler This gives better hints to lead users to find the new SingleBranchScheduler in buildbot.schedulers.basic rather than buildbot.scheduler. Fixes #2003. Commit: 1108444399ac92fa36181b5bcfaec6cbc4c8e6df https://github.com/buildbot/buildbot/commit/1108444399ac92fa36181b5bcfaec6cbc4c8e6df Author: Dustin J. Mitchell Date: 2011-06-20 (Mon, 20 Jun 2011) Changed paths: M master/docs/cfg-schedulers.texinfo Log Message: ----------- Merge branch 'bug_2004' of git://github.com/SparkieGeek/buildbot * 'bug_2004' of git://github.com/SparkieGeek/buildbot: s/Scheduler/SingleBranchScheduler/. Fixes #2004 Compare: https://github.com/buildbot/buildbot/compare/ec09a04...1108444 From nobody at buildbot.net Tue Jun 21 02:24:08 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 21 Jun 2011 02:24:08 -0000 Subject: [Buildbot-commits] [Buildbot] #2004: Documentation still refers to deprecated Scheduler In-Reply-To: <043.8a07e0e8d07d7cafeb352270831102f3@buildbot.net> References: <043.8a07e0e8d07d7cafeb352270831102f3@buildbot.net> Message-ID: <058.750a93fcd0aabc337507d71d3ec2f815@buildbot.net> #2004: Documentation still refers to deprecated Scheduler ------------------------+------------------------ Reporter: adamcollard | Owner: Type: defect | Status: closed Priority: minor | Milestone: undecided Version: 0.8.4p1 | Resolution: fixed Keywords: docs | ------------------------+------------------------ Changes (by Adam Collard): * status: new => closed * resolution: => fixed Comment: s/Scheduler/SingleBranchScheduler/. Fixes #2004 Changeset: a1964220dd4cc4cce97849261e9d4c691103d885 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jun 21 02:24:08 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 21 Jun 2011 02:24:08 -0000 Subject: [Buildbot-commits] [Buildbot] #2003: SingleBranchScheduler not available from buildbot.scheduler In-Reply-To: <043.8d2d386e3d0fc85e6ac3cbd5ef6adb21@buildbot.net> References: <043.8d2d386e3d0fc85e6ac3cbd5ef6adb21@buildbot.net> Message-ID: <058.7f55d799acb3d3bf18d1d515b3c1eaf3@buildbot.net> #2003: SingleBranchScheduler not available from buildbot.scheduler ------------------------+--------------------- Reporter: adamcollard | Owner: Type: defect | Status: closed Priority: minor | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: fixed Keywords: | ------------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Point to new import location in warning for Scheduler This gives better hints to lead users to find the new SingleBranchScheduler in buildbot.schedulers.basic rather than buildbot.scheduler. Fixes #2003. Changeset: a17b1833c8d0afead53b01dc14805d8581f4cb6d -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jun 21 02:24:09 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 21 Jun 2011 02:24:09 -0000 Subject: [Buildbot-commits] [Buildbot] #2004: Documentation still refers to deprecated Scheduler In-Reply-To: <043.8a07e0e8d07d7cafeb352270831102f3@buildbot.net> References: <043.8a07e0e8d07d7cafeb352270831102f3@buildbot.net> Message-ID: <058.f1b0529b3cd274c94773c5ad7a995791@buildbot.net> #2004: Documentation still refers to deprecated Scheduler ------------------------+------------------------ Reporter: adamcollard | Owner: Type: defect | Status: closed Priority: minor | Milestone: undecided Version: 0.8.4p1 | Resolution: fixed Keywords: docs | ------------------------+------------------------ Comment (by Dustin J. Mitchell): Merge branch 'bug_2004' of git://github.com/SparkieGeek/buildbot * 'bug_2004' of git://github.com/SparkieGeek/buildbot: s/Scheduler/SingleBranchScheduler/. Fixes #2004 Changeset: 1108444399ac92fa36181b5bcfaec6cbc4c8e6df -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jun 21 02:34:25 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 21 Jun 2011 02:34:25 -0000 Subject: [Buildbot-commits] [Buildbot] #2002: fatal: Could not parse object ... In-Reply-To: <041.c21b140f847f382869047b89968a3b37@buildbot.net> References: <041.c21b140f847f382869047b89968a3b37@buildbot.net> Message-ID: <056.61ab702a05126fb47c390a545e66da4f@buildbot.net> #2002: fatal: Could not parse object ... ----------------------+------------------------ Reporter: dabrahams | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4p1 | Resolution: Keywords: git | ----------------------+------------------------ Comment (by dustin): OK, so it looks like it's possible that the rev being built is only reachable from a branch, and not from a tag, in which case fetch --tags doesn't fetch the relevant commit. I see the comments on the stackoverflow thread, too. However, I think that the use of '+master' fixes this. At least, it does for me. In a repository that was somewhat behind upstream, I ran {{{ dustin at euclid ~/code/amanda/t/amanda [master] $ git fetch --tags zmanda +master remote: Counting objects: 153, done. remote: Compressing objects: 100% (52/52), done. remote: Total 114 (delta 92), reused 80 (delta 62) Receiving objects: 100% (114/114), 32.75 KiB, done. Resolving deltas: 100% (92/92), completed with 35 local objects. From http://github.com/zmanda/amanda * branch master -> FETCH_HEAD dustin at euclid ~/code/amanda/t/amanda [master] $ git reset --hard dcf864 HEAD is now at dcf8647 * perl/Amanda/Taper/Scribe.pm: Correcly make label with meta and barcode }}} where dcf864 is the current rev of master at zmanda/amanda, and was a commit that wasn't in my repo before that time. That rev is also not referenced by any tags in my repo or zmanda/amanda. So there's something about this problem that I'm still missing here - any idea how to explain what I'm seeing? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jun 21 02:36:52 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 21 Jun 2011 02:36:52 -0000 Subject: [Buildbot-commits] [Buildbot] #2002: fatal: Could not parse object ... In-Reply-To: <041.c21b140f847f382869047b89968a3b37@buildbot.net> References: <041.c21b140f847f382869047b89968a3b37@buildbot.net> Message-ID: <056.0aed6ac677ad17bcd0deb6fdbacf5e34@buildbot.net> #2002: fatal: Could not parse object ... ----------------------+------------------------ Reporter: dabrahams | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4p1 | Resolution: Keywords: git | ----------------------+------------------------ Comment (by dabrahams): Maybe the problem is that I'm interested in all the branches, not just master? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jun 21 02:38:56 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 21 Jun 2011 02:38:56 -0000 Subject: [Buildbot-commits] [Buildbot] #2002: fatal: Could not parse object ... In-Reply-To: <041.c21b140f847f382869047b89968a3b37@buildbot.net> References: <041.c21b140f847f382869047b89968a3b37@buildbot.net> Message-ID: <056.db86961405a4d471aa6a7493a572830b@buildbot.net> #2002: fatal: Could not parse object ... ----------------------+------------------------ Reporter: dabrahams | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4p1 | Resolution: Keywords: git | ----------------------+------------------------ Comment (by dustin): The commit you linked to was on master - or at least, the change says so. If the change contains incorrect information, I think all bets are off.. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jun 21 04:02:38 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 21 Jun 2011 04:02:38 -0000 Subject: [Buildbot-commits] [Buildbot] #2002: fatal: Could not parse object ... In-Reply-To: <041.c21b140f847f382869047b89968a3b37@buildbot.net> References: <041.c21b140f847f382869047b89968a3b37@buildbot.net> Message-ID: <056.607779db4f91e021c05251060d082ab7@buildbot.net> #2002: fatal: Could not parse object ... ----------------------+------------------------ Reporter: dabrahams | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4p1 | Resolution: Keywords: git | ----------------------+------------------------ Comment (by dabrahams): regardless, anything you do that's specific to master (like adding {{{+master}}}) can't possibly constitute a general fix, can it? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jun 21 09:50:51 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 21 Jun 2011 09:50:51 -0000 Subject: [Buildbot-commits] [Buildbot] #2005: SQLAlchemy Operational errors with SQLite: Database is locked Message-ID: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net> #2005: SQLAlchemy Operational errors with SQLite: Database is locked ----------------------+----------------------- Reporter: abompard | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.4 | Keywords: database ----------------------+----------------------- Since the switch to SQLAlchemy in 0.8.4, I get many tracebacks in the log such as: {{{ 2011-06-21 11:04:46+0200 [-] while marking build requests as completed Traceback (most recent call last): File "/usr/lib64/python2.5/site- packages/twisted/internet/defer.py", line 269, in errback self._startRunCallbacks(fail) File "/usr/lib64/python2.5/site- packages/twisted/internet/defer.py", line 312, in _startRunCallbacks self._runCallbacks() File "/usr/lib64/python2.5/site- packages/twisted/internet/defer.py", line 328, in _runCallbacks self.result = callback(self.result, *args, **kw) File "/usr/lib64/python2.5/site- packages/twisted/internet/defer.py", line 614, in gotResult _deferGenerator(g, deferred) --- --- File "/usr/lib64/python2.5/site- packages/twisted/internet/defer.py", line 589, in _deferGenerator result = g.next() File "/usr/lib/python2.5/site- packages/buildbot/process/builder.py", line 583, in _maybeBuildsetsComplete wfd.getResult() File "/usr/lib64/python2.5/site- packages/twisted/internet/defer.py", line 568, in getResult self.result.raiseException() File "/usr/lib64/python2.5/site- packages/twisted/internet/defer.py", line 589, in _deferGenerator result = g.next() File "/usr/lib/python2.5/site-packages/buildbot/master.py", line 974, in maybeBuildsetComplete brdicts = wfd.getResult() File "/usr/lib64/python2.5/site- packages/twisted/internet/defer.py", line 568, in getResult self.result.raiseException() File "/usr/lib/python2.5/site-packages/buildbot/db/pool.py", line 127, in thd rv = callable(conn, *args, **kwargs) File "/usr/lib/python2.5/site- packages/buildbot/db/buildrequests.py", line 140, in thd res = conn.execute(q) File "/usr/lib/python2.5/site- packages/sqlalchemy/engine/base.py", line 1191, in execute params) File "/usr/lib/python2.5/site- packages/sqlalchemy/engine/base.py", line 1271, in _execute_clauseelement return self.__execute_context(context) File "/usr/lib/python2.5/site- packages/sqlalchemy/engine/base.py", line 1302, in __execute_context context.parameters[0], context=context) File "/usr/lib/python2.5/site- packages/sqlalchemy/engine/base.py", line 1401, in _cursor_execute context) File "/usr/lib/python2.5/site- packages/sqlalchemy/engine/base.py", line 1394, in _cursor_execute context) File "/usr/lib/python2.5/site- packages/sqlalchemy/engine/default.py", line 299, in do_execute cursor.execute(statement, parameters) sqlalchemy.exc.OperationalError: (OperationalError) database is locked u'SELECT buildrequests.id, buildrequests.buildsetid, buildrequests.buildername, buildrequests.priority, buildrequests.claimed_at, buildrequests.claimed_by_name, buildrequests.claimed_by_incarnation, buildrequests.complete, buildrequests.results, buildrequests.submitted_at, buildrequests.complete_at \nFROM buildrequests \nWHERE buildrequests.buildsetid = ?' (20438,) }}} or {{{ in maybeStartBuild for Traceback (most recent call last): Failure: twisted.internet.defer.FirstError: FirstError(>, 7) 2011-06-21 11:09:03+0200 [-] Unhandled error in Deferred: 2011-06-21 11:09:03+0200 [-] Unhandled Error Traceback (most recent call last): File "/usr/lib64/python2.5/site- packages/twisted/internet/defer.py", line 269, in errback self._startRunCallbacks(fail) File "/usr/lib64/python2.5/site- packages/twisted/internet/defer.py", line 312, in _startRunCallbacks self._runCallbacks() File "/usr/lib64/python2.5/site- packages/twisted/internet/defer.py", line 328, in _runCallbacks self.result = callback(self.result, *args, **kw) File "/usr/lib64/python2.5/site- packages/twisted/internet/defer.py", line 614, in gotResult _deferGenerator(g, deferred) --- --- File "/usr/lib64/python2.5/site- packages/twisted/internet/defer.py", line 589, in _deferGenerator result = g.next() File "/usr/lib/python2.5/site- packages/buildbot/process/buildrequest.py", line 108, in _make_br buildset = wfd.getResult() File "/usr/lib64/python2.5/site- packages/twisted/internet/defer.py", line 568, in getResult self.result.raiseException() File "/usr/lib/python2.5/site-packages/buildbot/db/pool.py", line 127, in thd rv = callable(conn, *args, **kwargs) File "/usr/lib/python2.5/site- packages/buildbot/db/buildsets.py", line 157, in thd res = conn.execute(q) File "/usr/lib/python2.5/site- packages/sqlalchemy/engine/base.py", line 1191, in execute params) File "/usr/lib/python2.5/site- packages/sqlalchemy/engine/base.py", line 1271, in _execute_clauseelement return self.__execute_context(context) File "/usr/lib/python2.5/site- packages/sqlalchemy/engine/base.py", line 1302, in __execute_context context.parameters[0], context=context) File "/usr/lib/python2.5/site- packages/sqlalchemy/engine/base.py", line 1401, in _cursor_execute context) File "/usr/lib/python2.5/site- packages/sqlalchemy/engine/base.py", line 1394, in _cursor_execute context) File "/usr/lib/python2.5/site- packages/sqlalchemy/engine/default.py", line 299, in do_execute cursor.execute(statement, parameters) sqlalchemy.exc.OperationalError: (OperationalError) database is locked u'SELECT buildsets.id, buildsets.external_idstring, buildsets.reason, buildsets.sourcestampid, buildsets.submitted_at, buildsets.complete, buildsets.complete_at, buildsets.results \nFROM buildsets \nWHERE buildsets.id = ?' (20448,) }}} I'll attach my (anonymized) log to this ticket for further investigation. It looks like it can cause the builds to be re-tried lated, on buildbot restart for example. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jun 21 14:13:49 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 21 Jun 2011 14:13:49 -0000 Subject: [Buildbot-commits] [Buildbot] #2002: fatal: Could not parse object ... In-Reply-To: <041.c21b140f847f382869047b89968a3b37@buildbot.net> References: <041.c21b140f847f382869047b89968a3b37@buildbot.net> Message-ID: <056.36492d4cfc968a70088715b6e2440192@buildbot.net> #2002: fatal: Could not parse object ... ----------------------+------------------------ Reporter: dabrahams | Owner: Type: defect | Status: closed Priority: major | Milestone: undecided Version: 0.8.4p1 | Resolution: invalid Keywords: git | ----------------------+------------------------ Changes (by dabrahams): * status: new => closed * resolution: => invalid Comment: While I think comment:5 is worth thinking about, I'm happy/sorry to report that I think this is all a result of a multi-repository configuration where we're trying to check out the changes for one repo from a different repo. I'll have to backtrack and implement the more-principled multi-repo approach I've been designing. Sorry for the trouble. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jun 21 15:37:21 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 21 Jun 2011 15:37:21 -0000 Subject: [Buildbot-commits] [Buildbot] #2006: AnyBranchScheduler derives from Scheduler and gives warning Message-ID: <043.5b5fb66bbbf0c5e847f6256d94fc690a@buildbot.net> #2006: AnyBranchScheduler derives from Scheduler and gives warning ------------------------+----------------------- Reporter: adamcollard | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: 0.8.4p1 | Keywords: ------------------------+----------------------- Using an AnyBranchScheduler gets you warnings in the logs about use of the deprecated Scheduler name. This is due to an incorrect inheritance (it should probably derive from BaseBasicScheduler. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jun 21 15:51:01 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 21 Jun 2011 15:51:01 -0000 Subject: [Buildbot-commits] [Buildbot] #2006: AnyBranchScheduler derives from Scheduler and gives warning In-Reply-To: <043.5b5fb66bbbf0c5e847f6256d94fc690a@buildbot.net> References: <043.5b5fb66bbbf0c5e847f6256d94fc690a@buildbot.net> Message-ID: <058.59e0755e767a0260838a128d74edaf89@buildbot.net> #2006: AnyBranchScheduler derives from Scheduler and gives warning ------------------------+--------------------- Reporter: adamcollard | Owner: Type: defect | Status: closed Priority: minor | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: fixed Keywords: | ------------------------+--------------------- Changes (by adamcollard): * status: new => closed * resolution: => fixed * milestone: undecided => 0.8.5 Comment: Looks like this was fixed by d6b33ade2275e6560a7de65bed96b2b7733b0c20 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jun 21 16:20:24 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 21 Jun 2011 16:20:24 -0000 Subject: [Buildbot-commits] [Buildbot] #2007: Try --wait reports 'no build' Message-ID: <039.a614a418fd328270547a8a19952a239c@buildbot.net> #2007: Try --wait reports 'no build' --------------------+----------------------- Reporter: aslater | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4p1 | Keywords: --------------------+----------------------- When submitting a 'try' build with the --wait option, the client shows : no build for all builds and does not stop waiting when the builds complete. The builds appear to be submitted and run correctly. Command, output, and .buildbot\options attached. (also, I'm using version 0.8.4 converted to a Windows .exe with py2exe) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jun 21 16:27:39 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 21 Jun 2011 16:27:39 -0000 Subject: [Buildbot-commits] [Buildbot] #2002: fatal: Could not parse object ... In-Reply-To: <041.c21b140f847f382869047b89968a3b37@buildbot.net> References: <041.c21b140f847f382869047b89968a3b37@buildbot.net> Message-ID: <056.07a91f8f58ad5348fc9e48aa66f9e099@buildbot.net> #2002: fatal: Could not parse object ... ----------------------+------------------------ Reporter: dabrahams | Owner: Type: defect | Status: closed Priority: major | Milestone: undecided Version: 0.8.4p1 | Resolution: invalid Keywords: git | ----------------------+------------------------ Comment (by dustin): It doesn't add {{{+master}}} automatically - that's the branch from the change/sourcestamp. But yes, I think that this is one of the places where multi-repo builds don't work well. Sorry about that :( -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jun 21 20:07:46 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 21 Jun 2011 20:07:46 -0000 Subject: [Buildbot-commits] [Buildbot] #2007: Try --wait reports 'no build' In-Reply-To: <039.a614a418fd328270547a8a19952a239c@buildbot.net> References: <039.a614a418fd328270547a8a19952a239c@buildbot.net> Message-ID: <054.16063bb845635f015f4a09bc58913641@buildbot.net> #2007: Try --wait reports 'no build' --------------------+------------------------ Reporter: aslater | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4p1 | Resolution: Keywords: | --------------------+------------------------ Comment (by aslater): Poking around a little bit more, it looks like status.buildrequest.BuildRequestStatus.subscribe isn't getting called from status.client.RemoteBuildRequest.remote_subscribe, but I don't know twisted well enough to say why that could be. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jun 21 21:31:06 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 21 Jun 2011 21:31:06 -0000 Subject: [Buildbot-commits] [Buildbot] #2008: mergeRequests globally or per builder seems to not function Message-ID: <040.4bf85a14c9e3218a9b32c5f6c04b01f7@buildbot.net> #2008: mergeRequests globally or per builder seems to not function ---------------------+---------------------------------- Reporter: bdbaddog | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4 | Keywords: trigger,mergeRequest ---------------------+---------------------------------- I have an example where one builder fires off 20 triggers into another builder. The global c['mergeRequests'] is set to False (or a function which returns false) and it still merges the builds. I'll attach example master.cfg -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 22 02:09:26 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 22 Jun 2011 02:09:26 -0000 Subject: [Buildbot-commits] [Buildbot] #2009: twisted dependency is out dated Message-ID: <041.da002753fdcdd3bd18924d7657017ad0@buildbot.net> #2009: twisted dependency is out dated ----------------------+----------------------- Reporter: liucougar | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: master | Keywords: ----------------------+----------------------- twisted.words is used by trunk buildbot, but the dependency as specified in setup.py is: twisted >= 8.0.0 I have twisted 9.0, but it does not have twisted.words, so I could not run the buildbot test suite I installed twisted 11.0, and that seems to fix it I think the twisted dependency in setup.py should be updated to include the first version of twisted which contains twisted.words -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Jun 22 04:02:43 2011 From: noreply at github.com (noreply at github.com) Date: Tue, 21 Jun 2011 21:02:43 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] e0d985: inherit from BaseBasicScheduler (peer to SingleBra... Message-ID: <20110622040243.ACBAE42632@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: e0d985ef2a622fb695f36afd7fd45e5e8f8c5dcc https://github.com/buildbot/buildbot/commit/e0d985ef2a622fb695f36afd7fd45e5e8f8c5dcc Author: Dustin J. Mitchell Date: 2011-06-21 (Tue, 21 Jun 2011) Changed paths: M master/buildbot/schedulers/basic.py Log Message: ----------- inherit from BaseBasicScheduler (peer to SingleBranchScheduler) From nobody at buildbot.net Wed Jun 22 04:32:15 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 22 Jun 2011 04:32:15 -0000 Subject: [Buildbot-commits] [Buildbot] #2009: twisted dependency is out dated In-Reply-To: <041.da002753fdcdd3bd18924d7657017ad0@buildbot.net> References: <041.da002753fdcdd3bd18924d7657017ad0@buildbot.net> Message-ID: <056.6d3be8b3e05e0afc0384227987cecc16@buildbot.net> #2009: twisted dependency is out dated ----------------------+------------------------- Reporter: liucougar | Owner: Type: defect | Status: closed Priority: minor | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: worksforme Keywords: | ----------------------+------------------------- Changes (by dustin): * status: new => closed * version: master => 0.8.4p1 * resolution: => worksforme * milestone: undecided => 0.8.5 Comment: with a brand-new virtualenv: {{{ dustin at euclid ~/tmp/ve $ bin/pip install twisted==9.0.0 Downloading/unpacking twisted==9.0.0 Using download cache from /home/dustin/tmp/pkg- cache/http%3A%2F%2Fpypi.python.org%2Fpackages%2Fsource%2FT%2FTwisted%2FTwisted-9.0.0.tar.bz2 Running setup.py egg_info for package twisted Requirement already satisfied (use --upgrade to upgrade): zope.interface in /usr/lib64/python2.7/site-packages (from twisted==9.0.0) Requirement already satisfied (use --upgrade to upgrade): setuptools in ./lib/python2.7/site-packages/setuptools-0.6c11-py2.7.egg (from zope.interface->twisted==9.0.0) Installing collected packages: twisted Found existing installation: Twisted 11.0.0 Not uninstalling Twisted at /usr/lib64/python2.7/site-packages, outside environment /home/dustin/tmp/ve Running setup.py install for twisted x86_64-pc-linux-gnu-gcc -pthread -fPIC -I/usr/include/python2.7 -c conftest.c -o conftest.o x86_64-pc-linux-gnu-gcc -pthread -fPIC -I/usr/include/python2.7 -c conftest.c -o conftest.o building 'twisted.runner.portmap' extension x86_64-pc-linux-gnu-gcc -pthread -fPIC -I/usr/include/python2.7 -c twisted/runner/portmap.c -o build/temp.linux- x86_64-2.7/twisted/runner/portmap.o x86_64-pc-linux-gnu-gcc -pthread -shared build/temp.linux- x86_64-2.7/twisted/runner/portmap.o -L/usr/lib64 -lpython2.7 -o build/lib .linux-x86_64-2.7/twisted/runner/portmap.so building 'twisted.protocols._c_urlarg' extension x86_64-pc-linux-gnu-gcc -pthread -fPIC -I/usr/include/python2.7 -c twisted/protocols/_c_urlarg.c -o build/temp.linux- x86_64-2.7/twisted/protocols/_c_urlarg.o x86_64-pc-linux-gnu-gcc -pthread -shared build/temp.linux- x86_64-2.7/twisted/protocols/_c_urlarg.o -L/usr/lib64 -lpython2.7 -o build/lib.linux-x86_64-2.7/twisted/protocols/_c_urlarg.so building 'twisted.test.raiser' extension x86_64-pc-linux-gnu-gcc -pthread -fPIC -I/usr/include/python2.7 -c twisted/test/raiser.c -o build/temp.linux-x86_64-2.7/twisted/test/raiser.o x86_64-pc-linux-gnu-gcc -pthread -shared build/temp.linux- x86_64-2.7/twisted/test/raiser.o -L/usr/lib64 -lpython2.7 -o build/lib .linux-x86_64-2.7/twisted/test/raiser.so building 'twisted.python._epoll' extension x86_64-pc-linux-gnu-gcc -pthread -fPIC -I/usr/include/python2.7 -c twisted/python/_epoll.c -o build/temp.linux- x86_64-2.7/twisted/python/_epoll.o x86_64-pc-linux-gnu-gcc -pthread -shared build/temp.linux- x86_64-2.7/twisted/python/_epoll.o -L/usr/lib64 -lpython2.7 -o build/lib .linux-x86_64-2.7/twisted/python/_epoll.so changing mode of build/scripts-2.7/pyhtmlizer from 644 to 755 changing mode of build/scripts-2.7/twistd from 644 to 755 changing mode of build/scripts-2.7/tapconvert from 644 to 755 changing mode of build/scripts-2.7/tap2rpm from 644 to 755 changing mode of build/scripts-2.7/mktap from 644 to 755 changing mode of build/scripts-2.7/manhole from 644 to 755 changing mode of build/scripts-2.7/tap2deb from 644 to 755 changing mode of build/scripts-2.7/trial from 644 to 755 changing mode of build/scripts-2.7/lore from 644 to 755 changing mode of build/scripts-2.7/cftp from 644 to 755 changing mode of build/scripts-2.7/conch from 644 to 755 changing mode of build/scripts-2.7/tkconch from 644 to 755 changing mode of build/scripts-2.7/ckeygen from 644 to 755 changing mode of build/scripts-2.7/mailmail from 644 to 755 changing mode of /home/dustin/tmp/ve/bin/pyhtmlizer to 755 changing mode of /home/dustin/tmp/ve/bin/twistd to 755 changing mode of /home/dustin/tmp/ve/bin/tapconvert to 755 changing mode of /home/dustin/tmp/ve/bin/tap2rpm to 755 changing mode of /home/dustin/tmp/ve/bin/mktap to 755 changing mode of /home/dustin/tmp/ve/bin/manhole to 755 changing mode of /home/dustin/tmp/ve/bin/tap2deb to 755 changing mode of /home/dustin/tmp/ve/bin/trial to 755 changing mode of /home/dustin/tmp/ve/bin/lore to 755 changing mode of /home/dustin/tmp/ve/bin/cftp to 755 changing mode of /home/dustin/tmp/ve/bin/conch to 755 changing mode of /home/dustin/tmp/ve/bin/tkconch to 755 changing mode of /home/dustin/tmp/ve/bin/ckeygen to 755 changing mode of /home/dustin/tmp/ve/bin/mailmail to 755 Successfully installed twisted Cleaning up... dustin at euclid ~/tmp/ve $ bin/python Python 2.7.1 (r271:86832, Jun 6 2011, 00:28:00) [GCC 4.4.5] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> from twisted import words >>> }}} in the 8.x.0 days, Twisted still shipped in pieces, so maybe you only had some of those pieces installed? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 22 04:34:09 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 22 Jun 2011 04:34:09 -0000 Subject: [Buildbot-commits] [Buildbot] #2008: mergeRequests globally or per builder seems to not function In-Reply-To: <040.4bf85a14c9e3218a9b32c5f6c04b01f7@buildbot.net> References: <040.4bf85a14c9e3218a9b32c5f6c04b01f7@buildbot.net> Message-ID: <055.d039aaf5b87abc229fc8549bfdab66e3@buildbot.net> #2008: mergeRequests globally or per builder seems to not function ---------------------+-------------------- Reporter: bdbaddog | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.4 | Resolution: Keywords: | ---------------------+-------------------- Changes (by dustin): * keywords: trigger,mergeRequest => * milestone: undecided => 0.8.5 Old description: > I have an example where one builder fires off 20 triggers into another > builder. > The global c['mergeRequests'] is set to False (or a function which > returns false) and it still merges the builds. > > I'll attach example master.cfg New description: I have an example where one builder fires off 20 triggers into another builder. The global {{{c['mergeRequests']}}} is set to False (or a function which returns false) and it still merges the builds. I'll attach example {{{master.cfg}}} -- -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 22 04:39:37 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 22 Jun 2011 04:39:37 -0000 Subject: [Buildbot-commits] [Buildbot] #2009: twisted dependency is out dated In-Reply-To: <041.da002753fdcdd3bd18924d7657017ad0@buildbot.net> References: <041.da002753fdcdd3bd18924d7657017ad0@buildbot.net> Message-ID: <056.296f1bd3ee591626c17b03b1d371740e@buildbot.net> #2009: twisted dependency is out dated ----------------------+------------------------- Reporter: liucougar | Owner: Type: defect | Status: closed Priority: minor | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: worksforme Keywords: | ----------------------+------------------------- Comment (by liucougar): you are right, i do not have dev-python/twisted-words package installed sorry for the noise -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 22 05:24:19 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 22 Jun 2011 05:24:19 -0000 Subject: [Buildbot-commits] [Buildbot] #2007: Try --wait reports 'no build' In-Reply-To: <039.a614a418fd328270547a8a19952a239c@buildbot.net> References: <039.a614a418fd328270547a8a19952a239c@buildbot.net> Message-ID: <054.137b65420df15c64397d908686b22812@buildbot.net> #2007: Try --wait reports 'no build' ---------------------+-------------------- Reporter: aslater | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: Keywords: try | ---------------------+-------------------- Changes (by dustin): * keywords: => try * priority: major => critical * milestone: undecided => 0.8.5 Comment: Huh, I'm surprised that {{{--wait}}} works at all. How have you configured the statusClient? This is going to take some fixing -- the status client needs to be integrated with the pbmanager, and probably some tests added. Long-term, this should be done over the same PB connection through which the original try request is scheduled. As for your invesigations: {{{ #!python def remote_subscribe(self, observer): """The observer's remote_newbuild method will be called (with two arguments: the RemoteBuild object, and our builderName) for each new Build that is created to handle this BuildRequest.""" self.observers.append(observer) def send(bs): d = observer.callRemote("newbuild", IRemote(bs), self.b.getBuilderName()) d.addErrback(lambda err: None) reactor.callLater(0, self.b.subscribe, send) }}} if you change the {{{lambda err : None}}} to {{{twlog.err}}} you might get some better information about what's wrong. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 22 05:44:20 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 22 Jun 2011 05:44:20 -0000 Subject: [Buildbot-commits] [Buildbot] #2008: mergeRequests globally or per builder seems to not function In-Reply-To: <040.4bf85a14c9e3218a9b32c5f6c04b01f7@buildbot.net> References: <040.4bf85a14c9e3218a9b32c5f6c04b01f7@buildbot.net> Message-ID: <055.fe10a8a09a40b9b71016599a2dcc0667@buildbot.net> #2008: mergeRequests globally or per builder seems to not function ---------------------+------------------------ Reporter: bdbaddog | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4 | Resolution: Keywords: | ---------------------+------------------------ Changes (by bdbaddog): * milestone: 0.8.5 => undecided Comment: Partial fix here: https://github.com/bdbaddog/buildbot/commit/6ebcfa982c47706002151e2e29c25d9fffd815df Still has a lot of my debugging code. This only addresses the mergeRequests arg to {{{BuildConfig()}}} and not the global. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 22 06:41:07 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 22 Jun 2011 06:41:07 -0000 Subject: [Buildbot-commits] [Buildbot] #2007: Try --wait reports 'no build' In-Reply-To: <039.a614a418fd328270547a8a19952a239c@buildbot.net> References: <039.a614a418fd328270547a8a19952a239c@buildbot.net> Message-ID: <054.a4872396812ba9f9b8b7ca38770bb7c6@buildbot.net> #2007: Try --wait reports 'no build' ---------------------+-------------------- Reporter: aslater | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: Keywords: try | ---------------------+-------------------- Comment (by aslater): About my setup, the command line and .buildbot/options file I'm using are attached to this ticket (I'm actually using try_wait = True in the options file rather than --wait on the command line)[[BR]] About debugging, it doesn't seem to be even making it into send, so messing with the errback doesn't seem to do much. However, after yet more digging, it looks like the root problem is that process.builder.Builder.startBuildFor is calling self.master.status.build_started before build.startBuild; eventually (in Status.build_started), it tries to call getBuild before the build has been added to the currentBuilds list, returning None, so no observers are notified.[[BR]] It seems like this might be related to commit daa9ff73 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 22 09:59:27 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 22 Jun 2011 09:59:27 -0000 Subject: [Buildbot-commits] [Buildbot] #2010: ProgrammingError using PostgreSQL Message-ID: <040.a4ac386bacd7452f5eb2134e2526224a@buildbot.net> #2010: ProgrammingError using PostgreSQL ----------------------+----------------------- Reporter: abompard | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.4p1 | Keywords: database ----------------------+----------------------- I have migrated to Builbot 0.8.4p1, and switched the database backend to PostgreSQL using buildbot upgrade-master. Now I get these messages in the log : {{{ 2011-06-22 11:46:03+0200 [-] in maybeStartBuild for Traceback (most recent call last): File "/usr/lib64/python2.5/site- packages/twisted/internet/defer.py", line 269, in errback self._startRunCallbacks(fail) File "/usr/lib64/python2.5/site- packages/twisted/internet/defer.py", line 312, in _startRunCallbacks self._runCallbacks() File "/usr/lib64/python2.5/site- packages/twisted/internet/defer.py", line 328, in _runCallbacks self.result = callback(self.result, *args, **kw) File "/usr/lib64/python2.5/site- packages/twisted/internet/defer.py", line 614, in gotResult _deferGenerator(g, deferred) --- --- File "/usr/lib64/python2.5/site- packages/twisted/internet/defer.py", line 589, in _deferGenerator result = g.next() File "/usr/lib/python2.5/site- packages/buildbot/process/builder.py", line 689, in maybeStartBuild wfd.getResult() File "/usr/lib64/python2.5/site- packages/twisted/internet/defer.py", line 568, in getResult self.result.raiseException() File "/usr/lib/python2.5/site-packages/buildbot/db/pool.py", line 150, in thd rv = callable(conn, *args, **kwargs) File "/usr/lib/python2.5/site- packages/buildbot/db/buildrequests.py", line 217, in thd tmp.create() File "/usr/lib/python2.5/site-packages/sqlalchemy/schema.py", line 477, in create bind.create(self, checkfirst=checkfirst) File "/usr/lib/python2.5/site- packages/sqlalchemy/engine/base.py", line 1437, in create return self.engine.create(entity, connection=self, **kwargs) File "/usr/lib/python2.5/site- packages/sqlalchemy/engine/base.py", line 1698, in create connection=connection, **kwargs) File "/usr/lib/python2.5/site- packages/sqlalchemy/engine/base.py", line 1740, in _run_visitor **kwargs).traverse_single(element) File "/usr/lib/python2.5/site- packages/sqlalchemy/sql/visitors.py", line 86, in traverse_single return meth(obj, **kw) File "/usr/lib/python2.5/site- packages/sqlalchemy/engine/ddl.py", line 58, in visit_table self.connection.execute(schema.CreateTable(table)) File "/usr/lib/python2.5/site- packages/sqlalchemy/engine/base.py", line 1191, in execute params) File "/usr/lib/python2.5/site- packages/sqlalchemy/engine/base.py", line 1244, in _execute_ddl return self.__execute_context(context) File "/usr/lib/python2.5/site- packages/sqlalchemy/engine/base.py", line 1302, in __execute_context context.parameters[0], context=context) File "/usr/lib/python2.5/site- packages/sqlalchemy/engine/base.py", line 1401, in _cursor_execute context) File "/usr/lib/python2.5/site- packages/sqlalchemy/engine/base.py", line 1394, in _cursor_execute context) File "/usr/lib/python2.5/site- packages/sqlalchemy/engine/default.py", line 299, in do_execute cursor.execute(statement, parameters) sqlalchemy.exc.ProgrammingError: (ProgrammingError) relation "bbtmp_claim_ids" already exists '\nCREATE TEMPORARY TABLE bbtmp_claim_ids (\n\tbrid INTEGER\n)\n\n' {} }}} When I look in the database using the command-line client, I see no bbtmp_claim_ids table. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 22 12:35:41 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 22 Jun 2011 12:35:41 -0000 Subject: [Buildbot-commits] [Buildbot] #2011: Traceback popping from empty deque in addChange Message-ID: <043.d8d65df3cbcab5d1c78890f8f371eff1@buildbot.net> #2011: Traceback popping from empty deque in addChange ------------------------+----------------------- Reporter: adamcollard | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4p1 | Keywords: ------------------------+----------------------- Got an error this morning in response to an addChange which then caused the Waterfall page to not display (HTTP requests were hanging). The setup we have is a post_commit hook of SVN calling svn_buildbot.py using a PB change source. {{{ 2011-06-22 07:55:07+0100 [Broker,43,192.168.20.202] perspective_addChange called 2011-06-22 07:55:07+0100 [-] Unhandled Error Traceback (most recent call last): File "/usr/lib/python2.7/dist- packages/twisted/internet/base.py", line 1167, in mainLoop self.runUntilCurrent() File "/usr/lib/python2.7/dist- packages/twisted/internet/base.py", line 762, in runUntilCurrent f(*a, **kw) File "/usr/lib/python2.7/dist- packages/twisted/internet/defer.py", line 361, in callback self._startRunCallbacks(result) File "/usr/lib/python2.7/dist- packages/twisted/internet/defer.py", line 455, in _startRunCallbacks self._runCallbacks() --- --- File "/usr/lib/python2.7/dist- packages/twisted/internet/defer.py", line 542, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/usr/lib/python2.7/dist-packages/buildbot/util/lru.py", line 154, in handle_result self._purge() File "/usr/lib/python2.7/dist-packages/buildbot/util/lru.py", line 190, in _purge k = queue.popleft() exceptions.IndexError: pop from an empty deque }}} The "fix" was to restart the master, and resubmit the change (which proceeded as normal) -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Jun 22 19:54:33 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 22 Jun 2011 12:54:33 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 714f5b: Merge branch 'docs_spelling_cleanup' of git://gith... Message-ID: <20110622195433.6E4384252F@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 714f5b2a2b4ef1b523e101de3363d1af420259f4 https://github.com/buildbot/buildbot/commit/714f5b2a2b4ef1b523e101de3363d1af420259f4 Author: Dustin J. Mitchell Date: 2011-06-22 (Wed, 22 Jun 2011) Changed paths: M master/docs/cfg-buildslaves.texinfo M master/docs/cfg-schedulers.texinfo Log Message: ----------- Merge branch 'docs_spelling_cleanup' of git://github.com/SparkieGeek/buildbot * 'docs_spelling_cleanup' of git://github.com/SparkieGeek/buildbot: * Fix spelling of Master * Delete unnecessary whitespace in list literal Only one space in import line From nobody at buildbot.net Thu Jun 23 06:53:17 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 23 Jun 2011 06:53:17 -0000 Subject: [Buildbot-commits] [Buildbot] #2008: mergeRequests globally or per builder seems to not function In-Reply-To: <040.4bf85a14c9e3218a9b32c5f6c04b01f7@buildbot.net> References: <040.4bf85a14c9e3218a9b32c5f6c04b01f7@buildbot.net> Message-ID: <055.fd20ca56f66f06b8b3688913bf905a71@buildbot.net> #2008: mergeRequests globally or per builder seems to not function ---------------------+------------------------ Reporter: bdbaddog | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4 | Resolution: Keywords: | ---------------------+------------------------ Comment (by bdbaddog): Sent pull request. Changes are all in: https://github.com/bdbaddog/buildbot/commit/1e09bf84d254aff1adeef5915d28d4100ce520a9 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Jun 23 14:27:18 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 23 Jun 2011 14:27:18 -0000 Subject: [Buildbot-commits] [Buildbot] #2012: SetProperty text status may fill WebStatus waterfall Message-ID: <036.2556c5dd889450efa718834425167186@buildbot.net> #2012: SetProperty text status may fill WebStatus waterfall ------------------------+-------------------------------------- Reporter: ed10 | Owner: Type: enhancement | Status: new Priority: trivial | Milestone: undecided Version: 0.8.4p1 | Keywords: properties web waterfall ------------------------+-------------------------------------- When setting many properties at once in a `SetProperty` step, the status text reported in `WebStatus` waterfall may overfill space on the grid causing other steps to disappear down (see attached screenshot). Instead of having the whole list of properties set (always available following the 'property changes' link), a more compact information (like the number of properties set) could benefit overall output quality. Attached screenshot shows how the status of the same step appears is rendered by the original code (on the left) and when the attached patch has been applied (on the right). -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Jun 23 17:56:07 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 23 Jun 2011 17:56:07 -0000 Subject: [Buildbot-commits] [Buildbot] #2013: Description of "installdir" parameter for Visual Studio step is unclear Message-ID: <043.e1ad12301a26278fdc60f83882b164c9@buildbot.net> #2013: Description of "installdir" parameter for Visual Studio step is unclear ------------------------+--------------------------- Reporter: mitcholiver | Owner: Type: enhancement | Status: new Priority: minor | Milestone: undecided Version: 0.8.4p1 | Keywords: documentation ------------------------+--------------------------- I would suggest the following description to clarify: Base Visual Studio installation directory. For example, C:\Program Files\Microsoft Visual Studio 8 for Visual Studio 2005. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Jun 24 00:08:28 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 24 Jun 2011 00:08:28 -0000 Subject: [Buildbot-commits] [Buildbot] #2008: mergeRequests globally or per builder seems to not function In-Reply-To: <040.4bf85a14c9e3218a9b32c5f6c04b01f7@buildbot.net> References: <040.4bf85a14c9e3218a9b32c5f6c04b01f7@buildbot.net> Message-ID: <055.2b9b684d16d818426904c8de51bcab47@buildbot.net> #2008: mergeRequests globally or per builder seems to not function ---------------------+-------------------- Reporter: bdbaddog | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.4 | Resolution: Keywords: | ---------------------+-------------------- Changes (by dustin): * milestone: undecided => 0.8.5 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Jun 24 10:24:27 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 24 Jun 2011 10:24:27 -0000 Subject: [Buildbot-commits] [Buildbot] #2014: The MailNotifier's subject can't be overriden anymore with a function Message-ID: <040.5c1e4db7d95c5a7da5ff76c569eddde4@buildbot.net> #2014: The MailNotifier's subject can't be overriden anymore with a function ----------------------+------------------------ Reporter: abompard | Owner: Type: undecided | Status: new Priority: major | Milestone: undecided Version: 0.8.4p1 | Keywords: mail patch ----------------------+------------------------ The `MailNotifier`'s documentation states that the `messageFormatter` function may set a "subject" key, to override the default mail subject. However, this is not possible anymore with Buildbot 0.8.4 (and p1, and today's master) because there is a line missing in `buildMessage()`. The patch is so small I'm pasting it here: {{{ #!diff --- /usr/lib/python2.5/site-packages/buildbot/status/mail.py.orig 2011-06-24 12:11:42.000000000 +0200 +++ /usr/lib/python2.5/site-packages/buildbot/status/mail.py 2011-06-24 12:12:29.000000000 +0200 @@ -588,6 +588,8 @@ msgdict['body'] += tmp['body'] msgdict['body'] += '\n\n' msgdict['type'] = tmp['type'] + if "subject" in tmp: + msgdict['subject'] = tmp['subject'] m = self.createEmail(msgdict, name, self.master_status.getTitle(), results, builds, patches, logs) }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Jun 24 15:19:58 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 24 Jun 2011 15:19:58 -0000 Subject: [Buildbot-commits] [Buildbot] #2015: master.cfg can not be provisioned with adjacent cfg files as of 0.8.4p1 Message-ID: <042.ad792e73baaa0aa8299c123a28eff712@buildbot.net> #2015: master.cfg can not be provisioned with adjacent cfg files as of 0.8.4p1 -----------------------+----------------------- Reporter: garmstrong | Owner: Type: defect | Status: new Priority: critical | Milestone: undecided Version: 0.8.4p1 | Keywords: -----------------------+----------------------- The fix for Ticket#1928 breaks the testing/loading of a master.cfg file which requires reading in external configuration data from files external to BuildBot's master.cfg file but which reside in the same directory. The culprit can be found here. https://github.com/buildbot/buildbot/commit/e2d9ba79dd2d205d26ad6018d8d97d53a8e28d92/Buildbot I have a setup which uses Python ConfigObj to read in configuration data to my master.cfg. This allows generalization of my master.cfg using ini style data found in the SIMULAP_external.cfg listed below. This setup worked successful for BuildBot 0.7.8 - > 0.8.3p1. {{{ $ ll total 76 drwxrwxr-x. 6 gareth gareth 4096 Jun 24 15:29 ./ drwxrwxr-x. 12 gareth gareth 4096 Jun 9 10:22 ../ -rw-rw-r--. 1 gareth gareth 4239 Apr 12 16:56 fabfile.py drwxrwxr-x. 4 gareth gareth 4096 Apr 21 15:09 .hg/ -rw-rw-r--. 1 gareth gareth 156 Feb 25 15:50 .hgignore -rw-rw-r--. 1 gareth gareth 32820 Jun 24 15:29 master.cfg drwxrwxr-x. 2 gareth gareth 4096 Mar 18 2010 scripts/ -rw-rw-r--. 1 gareth gareth 3592 Feb 25 14:06 SIMULAP_external.cfg drwxrwxr-x. 2 gareth gareth 4096 Feb 25 00:29 templates/ }}} The following code fixes the issue: {{{ #!diff $ git diff diff --git a/master/buildbot/scripts/checkconfig.py b/master/buildbot/scripts/checkconfig.py index b661fe3..9223d61 100644 --- a/master/buildbot/scripts/checkconfig.py +++ b/master/buildbot/scripts/checkconfig.py @@ -35,6 +35,14 @@ class ConfigLoader(object): # builder directories self.tempdir = mkdtemp() copy(self.configFileName, self.tempdir) + to_copy = [f for f in os.listdir(".") + if os.path.isfile(f) and + not f.startswith("http.log") and + not f.startswith("state.sqlite") and + not f.startswith("twistd.log") and + not f.startswith("twistd.pid")] + for entry in to_copy: + copy(entry, self.tempdir) }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Jun 24 23:10:38 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 24 Jun 2011 23:10:38 -0000 Subject: [Buildbot-commits] [Buildbot] #2005: SQLAlchemy Operational errors with SQLite: Database is locked In-Reply-To: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net> References: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net> Message-ID: <055.e47210c91bf633ba99feca81725cd7c5@buildbot.net> #2005: SQLAlchemy Operational errors with SQLite: Database is locked ---------------------+-------------------- Reporter: abompard | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.5 Version: 0.8.4 | Resolution: Keywords: database | ---------------------+-------------------- Changes (by dustin): * priority: major => critical * type: undecided => defect * milestone: undecided => 0.8.5 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Jun 24 23:19:48 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 24 Jun 2011 23:19:48 -0000 Subject: [Buildbot-commits] [Buildbot] #2010: ProgrammingError using PostgreSQL In-Reply-To: <040.a4ac386bacd7452f5eb2134e2526224a@buildbot.net> References: <040.a4ac386bacd7452f5eb2134e2526224a@buildbot.net> Message-ID: <055.cf0d8b3566b6a30eea89fa50bc3b570a@buildbot.net> #2010: ProgrammingError using PostgreSQL ---------------------+-------------------- Reporter: abompard | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: Keywords: database | ---------------------+-------------------- Changes (by dustin): * priority: major => critical * type: undecided => defect * milestone: undecided => 0.8.5 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Jun 24 23:20:28 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 24 Jun 2011 23:20:28 -0000 Subject: [Buildbot-commits] [Buildbot] #2011: Traceback popping from empty deque in addChange In-Reply-To: <043.d8d65df3cbcab5d1c78890f8f371eff1@buildbot.net> References: <043.d8d65df3cbcab5d1c78890f8f371eff1@buildbot.net> Message-ID: <058.e6bf8e5e77982384e97370af23b6567b@buildbot.net> #2011: Traceback popping from empty deque in addChange ------------------------+-------------------- Reporter: adamcollard | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: Keywords: | ------------------------+-------------------- Changes (by dustin): * priority: major => critical * milestone: undecided => 0.8.5 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Jun 24 23:22:18 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 24 Jun 2011 23:22:18 -0000 Subject: [Buildbot-commits] [Buildbot] #2012: SetProperty text status may fill WebStatus waterfall In-Reply-To: <036.2556c5dd889450efa718834425167186@buildbot.net> References: <036.2556c5dd889450efa718834425167186@buildbot.net> Message-ID: <051.caac1874b2f98d614470dcb30a7071ad@buildbot.net> #2012: SetProperty text status may fill WebStatus waterfall ------------------------+-------------------- Reporter: ed10 | Owner: Type: enhancement | Status: new Priority: trivial | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: Keywords: web | ------------------------+-------------------- Changes (by dustin): * keywords: properties web waterfall => web * milestone: undecided => 0.8.5 Comment: I like this - however, it'd be nice to have the name of the property set if only one was set. Can you adjust it so that it prints the number if there are >1 properties set, otherwise the name? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Jun 24 23:22:56 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 24 Jun 2011 23:22:56 -0000 Subject: [Buildbot-commits] [Buildbot] #2013: Description of "installdir" parameter for Visual Studio step is unclear In-Reply-To: <043.e1ad12301a26278fdc60f83882b164c9@buildbot.net> References: <043.e1ad12301a26278fdc60f83882b164c9@buildbot.net> Message-ID: <058.32b192ba9bbf10ab42ccdc893165eea9@buildbot.net> #2013: Description of "installdir" parameter for Visual Studio step is unclear ------------------------+-------------------- Reporter: mitcholiver | Owner: Type: enhancement | Status: new Priority: trivial | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: Keywords: docs | ------------------------+-------------------- Changes (by dustin): * keywords: documentation => docs * priority: minor => trivial * milestone: undecided => 0.8.5 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Jun 24 23:24:38 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 24 Jun 2011 23:24:38 -0000 Subject: [Buildbot-commits] [Buildbot] #2004: Documentation still refers to deprecated Scheduler In-Reply-To: <043.8a07e0e8d07d7cafeb352270831102f3@buildbot.net> References: <043.8a07e0e8d07d7cafeb352270831102f3@buildbot.net> Message-ID: <058.5fcd743cf45c9d7940fdca8c51f8b76c@buildbot.net> #2004: Documentation still refers to deprecated Scheduler ------------------------+--------------------- Reporter: adamcollard | Owner: Type: defect | Status: closed Priority: minor | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: fixed Keywords: docs | ------------------------+--------------------- Changes (by dustin): * milestone: undecided => 0.8.5 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Jun 24 23:25:31 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 24 Jun 2011 23:25:31 -0000 Subject: [Buildbot-commits] [Buildbot] #2014: The MailNotifier's subject can't be overriden anymore with a function In-Reply-To: <040.5c1e4db7d95c5a7da5ff76c569eddde4@buildbot.net> References: <040.5c1e4db7d95c5a7da5ff76c569eddde4@buildbot.net> Message-ID: <055.84b1cf48d7fe7b0db170c15d3038db0b@buildbot.net> #2014: The MailNotifier's subject can't be overriden anymore with a function ---------------------+-------------------- Reporter: abompard | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: Keywords: mail | ---------------------+-------------------- Changes (by dustin): * keywords: mail patch => mail * type: undecided => defect * milestone: undecided => 0.8.5 Comment: Ah, this patch is correct, although the pull request is not. I'll get it merged. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Jun 24 23:28:29 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 24 Jun 2011 23:28:29 -0000 Subject: [Buildbot-commits] [Buildbot] #2015: master.cfg can not be provisioned with adjacent cfg files as of 0.8.4p1 In-Reply-To: <042.ad792e73baaa0aa8299c123a28eff712@buildbot.net> References: <042.ad792e73baaa0aa8299c123a28eff712@buildbot.net> Message-ID: <057.3fed9216d85849750877f36da02485a6@buildbot.net> #2015: master.cfg can not be provisioned with adjacent cfg files as of 0.8.4p1 -----------------------+-------------------- Reporter: garmstrong | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: Keywords: | -----------------------+-------------------- Changes (by dustin): * priority: critical => major * milestone: undecided => 0.8.5 Comment: We should probably just stop trying to copy things to a temporary directory? Surely we could convince {{{loadConfig}}} to not create directories when checking.. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Jun 24 23:35:12 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 24 Jun 2011 23:35:12 -0000 Subject: [Buildbot-commits] [Buildbot] #189: Rewrite Buildbot docs in Sphinx In-Reply-To: <039.a8def7e36e19b169a2efad013e9f5094@buildbot.net> References: <039.a8def7e36e19b169a2efad013e9f5094@buildbot.net> Message-ID: <054.160500988cd7194d24b9a58b2affb2fe@buildbot.net> #189: Rewrite Buildbot docs in Sphinx -------------------------+-------------------- Reporter: ludovic | Owner: Type: defect | Status: new Priority: minor | Milestone: 0.8.+ Version: 0.7.6 | Resolution: Keywords: docs, sprint | -------------------------+-------------------- Changes (by ayust): * milestone: 0.8.5 => 0.8.+ -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Jun 24 23:38:21 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 24 Jun 2011 23:38:21 -0000 Subject: [Buildbot-commits] [Buildbot] #985: wierd behaviour for some custom property values from force build page In-Reply-To: <039.9c19da66cfd0d81bd21cbb22407290df@buildbot.net> References: <039.9c19da66cfd0d81bd21cbb22407290df@buildbot.net> Message-ID: <054.ba0e061a1b08d71c949cd83a304b1743@buildbot.net> #985: wierd behaviour for some custom property values from force build page --------------------+-------------------- Reporter: rmdugal | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: 0.7.12 | Resolution: Keywords: web | --------------------+-------------------- Comment (by ayust): Probably the simplest and most straightforward solution to this for now is to just add a configuration option for a different regex to use, so that people can override it as long as they're aware of what's going on. Caveat emptor. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Fri Jun 24 23:41:09 2011 From: nobody at buildbot.net (Buildbot) Date: Fri, 24 Jun 2011 23:41:09 -0000 Subject: [Buildbot-commits] [Buildbot] #1864: Nightly scheduler don't trigger builds if last_build is in future In-Reply-To: <036.48435b958e958b75fab97d8f12d01fe4@buildbot.net> References: <036.48435b958e958b75fab97d8f12d01fe4@buildbot.net> Message-ID: <051.04c3c57f89b6620bbab4f72edaa6380e@buildbot.net> #1864: Nightly scheduler don't trigger builds if last_build is in future --------------------+-------------------- Reporter: dion | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: | --------------------+-------------------- Changes (by ayust): * milestone: 0.8.5 => 0.8.+ Comment: Is this ticket still valid? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Jun 25 09:08:19 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 25 Jun 2011 09:08:19 -0000 Subject: [Buildbot-commits] [Buildbot] #2012: SetProperty text status may fill WebStatus waterfall In-Reply-To: <036.2556c5dd889450efa718834425167186@buildbot.net> References: <036.2556c5dd889450efa718834425167186@buildbot.net> Message-ID: <051.eb885524e16d594f0e6be573fa9e996a@buildbot.net> #2012: SetProperty text status may fill WebStatus waterfall ------------------------+-------------------- Reporter: ed10 | Owner: Type: enhancement | Status: new Priority: trivial | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: Keywords: web | ------------------------+-------------------- Comment (by ed10): Replying to [comment:1 dustin]: > I like this - however, it'd be nice to have the name of the property set if only one was set. Can you adjust it so that it prints the number if there are >1 properties set, otherwise the name? [attachment:setproperty-status-2.patch] :) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Jun 25 17:35:41 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 25 Jun 2011 17:35:41 -0000 Subject: [Buildbot-commits] [Buildbot] #1998: pageTitle not properly set in rss / atom feed In-Reply-To: <039.37367c826a60ee12aa02c5cf6eff61a0@buildbot.net> References: <039.37367c826a60ee12aa02c5cf6eff61a0@buildbot.net> Message-ID: <054.c10ddd1a0082c03e26e4862a43456027@buildbot.net> #1998: pageTitle not properly set in rss / atom feed --------------------+-------------------- Reporter: pworach | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: Keywords: | --------------------+-------------------- Changes (by dustin): * type: undecided => defect * milestone: undecided => 0.8.5 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Jun 25 19:10:07 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 25 Jun 2011 19:10:07 -0000 Subject: [Buildbot-commits] [Buildbot] #2008: mergeRequests globally or per builder seems to not function In-Reply-To: <040.4bf85a14c9e3218a9b32c5f6c04b01f7@buildbot.net> References: <040.4bf85a14c9e3218a9b32c5f6c04b01f7@buildbot.net> Message-ID: <055.e6b60d71a4cd7cb8de6e6653e87abba0@buildbot.net> #2008: mergeRequests globally or per builder seems to not function ---------------------+--------------------- Reporter: bdbaddog | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.5 Version: 0.8.4 | Resolution: fixed Keywords: | ---------------------+--------------------- Comment (by Dustin J. Mitchell): Allow c['mergeRequests'] = True This is the default, and therefore unnecessary, but it shouldn't be explicitly disallowed. Refs #2008. Changeset: 7928163ee56f657ea7bbd3791af5271ac04a87af -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Jun 25 19:10:07 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 25 Jun 2011 19:10:07 -0000 Subject: [Buildbot-commits] [Buildbot] #2008: mergeRequests globally or per builder seems to not function In-Reply-To: <040.4bf85a14c9e3218a9b32c5f6c04b01f7@buildbot.net> References: <040.4bf85a14c9e3218a9b32c5f6c04b01f7@buildbot.net> Message-ID: <055.8dd072bd1db0a0d0b4d5804e422ec944@buildbot.net> #2008: mergeRequests globally or per builder seems to not function ---------------------+--------------------- Reporter: bdbaddog | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.5 Version: 0.8.4 | Resolution: fixed Keywords: | ---------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Builder configuration should default mergeRequests to None, not True Without this change, mergeRequests is True regardless of the global setting, unless specifically set to something else in the BuilderConfig. This also fixes an error in _getMergeRequestFn, which was looking at self.master.mergeRequests, not self.botmaster.mergeRequests, and updates the tests to match and to have somewhat more readable inputs. Fixes #2008. Changeset: 984c004a6b04d616e727f6d984e179126fdc9cde -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Jun 25 19:10:06 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 25 Jun 2011 19:10:06 -0000 Subject: [Buildbot-commits] [Buildbot] #2008: mergeRequests globally or per builder seems to not function In-Reply-To: <040.4bf85a14c9e3218a9b32c5f6c04b01f7@buildbot.net> References: <040.4bf85a14c9e3218a9b32c5f6c04b01f7@buildbot.net> Message-ID: <055.5de768a1e0da8b1e511f8bcbf6b286e0@buildbot.net> #2008: mergeRequests globally or per builder seems to not function ---------------------+-------------------- Reporter: bdbaddog | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.4 | Resolution: Keywords: | ---------------------+-------------------- Comment (by Dustin J. Mitchell): remove unused BotMaster.shouldMergeRequests Refs #2008 Changeset: 29c9de940d34a0de8268f83a3b7b4f4229d25657 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sat Jun 25 19:09:59 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 25 Jun 2011 12:09:59 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 29c9de: remove unused BotMaster.shouldMergeRequests Message-ID: <20110625190959.9A91A424E3@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 29c9de940d34a0de8268f83a3b7b4f4229d25657 https://github.com/buildbot/buildbot/commit/29c9de940d34a0de8268f83a3b7b4f4229d25657 Author: Dustin J. Mitchell Date: 2011-06-25 (Sat, 25 Jun 2011) Changed paths: M master/buildbot/process/botmaster.py Log Message: ----------- remove unused BotMaster.shouldMergeRequests Refs #2008 Commit: 984c004a6b04d616e727f6d984e179126fdc9cde https://github.com/buildbot/buildbot/commit/984c004a6b04d616e727f6d984e179126fdc9cde Author: Dustin J. Mitchell Date: 2011-06-25 (Sat, 25 Jun 2011) Changed paths: M master/buildbot/process/builder.py M master/buildbot/test/unit/test_process_builder.py Log Message: ----------- Builder configuration should default mergeRequests to None, not True Without this change, mergeRequests is True regardless of the global setting, unless specifically set to something else in the BuilderConfig. This also fixes an error in _getMergeRequestFn, which was looking at self.master.mergeRequests, not self.botmaster.mergeRequests, and updates the tests to match and to have somewhat more readable inputs. Fixes #2008. Commit: 7928163ee56f657ea7bbd3791af5271ac04a87af https://github.com/buildbot/buildbot/commit/7928163ee56f657ea7bbd3791af5271ac04a87af Author: Dustin J. Mitchell Date: 2011-06-25 (Sat, 25 Jun 2011) Changed paths: M master/buildbot/master.py Log Message: ----------- Allow c['mergeRequests'] = True This is the default, and therefore unnecessary, but it shouldn't be explicitly disallowed. Refs #2008. Compare: https://github.com/buildbot/buildbot/compare/714f5b2...7928163 From noreply at github.com Sat Jun 25 19:19:57 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 25 Jun 2011 12:19:57 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 71f21a: Fix error in atom/rss feed titles Message-ID: <20110625191957.E7BF442507@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 71f21adaffc63e41a8bf40543ba1761a30c6c0db https://github.com/buildbot/buildbot/commit/71f21adaffc63e41a8bf40543ba1761a30c6c0db Author: Dustin J. Mitchell Date: 2011-06-25 (Sat, 25 Jun 2011) Changed paths: M master/buildbot/status/web/feeds.py Log Message: ----------- Fix error in atom/rss feed titles fix typo displaying 'None' instead of title in atom/rss feeds. Fixes #1998. From noreply at github.com Sat Jun 25 19:19:57 2011 From: noreply at github.com (noreply at github.com) Date: Sat, 25 Jun 2011 12:19:57 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] f44c2e: remove unused BotMaster.shouldMergeRequests Message-ID: <20110625191957.86F2B424E8@smtp1.rs.github.com> Branch: refs/heads/buildbot-0.8.4 Home: https://github.com/buildbot/buildbot Commit: f44c2e9fc13cda9e0e15f6bb4daf72cc7906dafd https://github.com/buildbot/buildbot/commit/f44c2e9fc13cda9e0e15f6bb4daf72cc7906dafd Author: Dustin J. Mitchell Date: 2011-06-25 (Sat, 25 Jun 2011) Changed paths: M master/buildbot/process/botmaster.py Log Message: ----------- remove unused BotMaster.shouldMergeRequests Refs #2008 Commit: 977eb41f40215a65215b6e74beac66a9f46b1801 https://github.com/buildbot/buildbot/commit/977eb41f40215a65215b6e74beac66a9f46b1801 Author: Dustin J. Mitchell Date: 2011-06-25 (Sat, 25 Jun 2011) Changed paths: M master/buildbot/process/builder.py M master/buildbot/test/unit/test_process_builder.py Log Message: ----------- Builder configuration should default mergeRequests to None, not True Without this change, mergeRequests is True regardless of the global setting, unless specifically set to something else in the BuilderConfig. This also fixes an error in _getMergeRequestFn, which was looking at self.master.mergeRequests, not self.botmaster.mergeRequests, and updates the tests to match and to have somewhat more readable inputs. Fixes #2008. Commit: 88931660eb8d30d9f4515d6ae7b23486d9f9c15b https://github.com/buildbot/buildbot/commit/88931660eb8d30d9f4515d6ae7b23486d9f9c15b Author: Dustin J. Mitchell Date: 2011-06-25 (Sat, 25 Jun 2011) Changed paths: M master/buildbot/master.py Log Message: ----------- Allow c['mergeRequests'] = True This is the default, and therefore unnecessary, but it shouldn't be explicitly disallowed. Refs #2008. Compare: https://github.com/buildbot/buildbot/compare/7f4527f...8893166 From nobody at buildbot.net Sat Jun 25 19:20:03 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 25 Jun 2011 19:20:03 -0000 Subject: [Buildbot-commits] [Buildbot] #1998: pageTitle not properly set in rss / atom feed In-Reply-To: <039.37367c826a60ee12aa02c5cf6eff61a0@buildbot.net> References: <039.37367c826a60ee12aa02c5cf6eff61a0@buildbot.net> Message-ID: <054.7a17deb52d1cb30c696dd93084305fa1@buildbot.net> #1998: pageTitle not properly set in rss / atom feed --------------------+--------------------- Reporter: pworach | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: fixed Keywords: | --------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Fix error in atom/rss feed titles fix typo displaying 'None' instead of title in atom/rss feeds. Fixes #1998. Changeset: 71f21adaffc63e41a8bf40543ba1761a30c6c0db -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Jun 25 19:20:20 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 25 Jun 2011 19:20:20 -0000 Subject: [Buildbot-commits] [Buildbot] #2008: mergeRequests globally or per builder seems to not function In-Reply-To: <040.4bf85a14c9e3218a9b32c5f6c04b01f7@buildbot.net> References: <040.4bf85a14c9e3218a9b32c5f6c04b01f7@buildbot.net> Message-ID: <055.7cfc6b27259d6b8a384f3197fd7487c4@buildbot.net> #2008: mergeRequests globally or per builder seems to not function ---------------------+--------------------- Reporter: bdbaddog | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.5 Version: 0.8.4 | Resolution: fixed Keywords: | ---------------------+--------------------- Comment (by Dustin J. Mitchell): remove unused BotMaster.shouldMergeRequests Refs #2008 Changeset: f44c2e9fc13cda9e0e15f6bb4daf72cc7906dafd -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Jun 25 19:20:21 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 25 Jun 2011 19:20:21 -0000 Subject: [Buildbot-commits] [Buildbot] #2008: mergeRequests globally or per builder seems to not function In-Reply-To: <040.4bf85a14c9e3218a9b32c5f6c04b01f7@buildbot.net> References: <040.4bf85a14c9e3218a9b32c5f6c04b01f7@buildbot.net> Message-ID: <055.a50e573c3b9663bd05bf0670f94016e1@buildbot.net> #2008: mergeRequests globally or per builder seems to not function ---------------------+--------------------- Reporter: bdbaddog | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.5 Version: 0.8.4 | Resolution: fixed Keywords: | ---------------------+--------------------- Comment (by Dustin J. Mitchell): Builder configuration should default mergeRequests to None, not True Without this change, mergeRequests is True regardless of the global setting, unless specifically set to something else in the BuilderConfig. This also fixes an error in _getMergeRequestFn, which was looking at self.master.mergeRequests, not self.botmaster.mergeRequests, and updates the tests to match and to have somewhat more readable inputs. Fixes #2008. Changeset: 977eb41f40215a65215b6e74beac66a9f46b1801 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sat Jun 25 19:20:22 2011 From: nobody at buildbot.net (Buildbot) Date: Sat, 25 Jun 2011 19:20:22 -0000 Subject: [Buildbot-commits] [Buildbot] #2008: mergeRequests globally or per builder seems to not function In-Reply-To: <040.4bf85a14c9e3218a9b32c5f6c04b01f7@buildbot.net> References: <040.4bf85a14c9e3218a9b32c5f6c04b01f7@buildbot.net> Message-ID: <055.6b3a1c587dabb12f4967441d7059e2a7@buildbot.net> #2008: mergeRequests globally or per builder seems to not function ---------------------+--------------------- Reporter: bdbaddog | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.5 Version: 0.8.4 | Resolution: fixed Keywords: | ---------------------+--------------------- Comment (by Dustin J. Mitchell): Allow c['mergeRequests'] = True This is the default, and therefore unnecessary, but it shouldn't be explicitly disallowed. Refs #2008. Changeset: 88931660eb8d30d9f4515d6ae7b23486d9f9c15b -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jun 26 02:23:44 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 26 Jun 2011 02:23:44 -0000 Subject: [Buildbot-commits] [Buildbot] #2008: mergeRequests globally or per builder seems to not function In-Reply-To: <040.4bf85a14c9e3218a9b32c5f6c04b01f7@buildbot.net> References: <040.4bf85a14c9e3218a9b32c5f6c04b01f7@buildbot.net> Message-ID: <055.0db7a431aba387408b94f8c8e13887cc@buildbot.net> #2008: mergeRequests globally or per builder seems to not function ---------------------+--------------------- Reporter: bdbaddog | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.5 Version: 0.8.4 | Resolution: fixed Keywords: | ---------------------+--------------------- Comment (by dustin): The actual fix here is in [984c004a6b04d616e727f6d984e179126fdc9cde], and is the one you had identified - an incorrect default value used when getting {{{mergeRequests}} from the builder's config dictionary. My patch reverts behavior to the previous behavior, rather than changing documentation and tests to match new (incorrect) behavior. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jun 26 02:32:06 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 26 Jun 2011 02:32:06 -0000 Subject: [Buildbot-commits] [Buildbot] #2005: SQLAlchemy Operational errors with SQLite: Database is locked In-Reply-To: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net> References: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net> Message-ID: <055.b772066a44c5752d9f6494b196036f24@buildbot.net> #2005: SQLAlchemy Operational errors with SQLite: Database is locked ---------------------+-------------------- Reporter: abompard | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.5 Version: 0.8.4 | Resolution: Keywords: database | ---------------------+-------------------- Comment (by dustin): This error generally means that something else has held a write lock on the database for too long. It's hard to tell from your logs what that might be - all of the queries that timed out are read-only queries (getBuildset and getBuildRequests). Does this still occur after a master restart? If so, can you try it with a clean state.sqlite file? (Just remove the file and run 'buildbot upgrade-master' again) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jun 26 02:48:35 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 26 Jun 2011 02:48:35 -0000 Subject: [Buildbot-commits] [Buildbot] #2005: SQLAlchemy Operational errors with SQLite: Database is locked In-Reply-To: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net> References: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net> Message-ID: <055.c390144b8e1b80aa11499639dc7de787@buildbot.net> #2005: SQLAlchemy Operational errors with SQLite: Database is locked ---------------------+-------------------- Reporter: abompard | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.5 Version: 0.8.4 | Resolution: Keywords: database | ---------------------+-------------------- Comment (by dustin): Aurelian, can you try applying https://github.com/djmitche/buildbot/commit/8910cba714ddb93a8c0ea90d314aabc7896eb037.patch locally and reproducing these errors, then supplying a sufficiently complete logfile that I can see what operations are still ongoing when the lock expires? Thanks! -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Jun 26 15:51:03 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 26 Jun 2011 08:51:03 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] ad897b: add a test for cache miss_fn raising an exception Message-ID: <20110626155103.82E8E424D1@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: ad897b1709b5af02fd30205a47b4c45a3d726815 https://github.com/buildbot/buildbot/commit/ad897b1709b5af02fd30205a47b4c45a3d726815 Author: Dustin J. Mitchell Date: 2011-06-25 (Sat, 25 Jun 2011) Changed paths: M master/buildbot/test/unit/test_util_lru.py Log Message: ----------- add a test for cache miss_fn raising an exception Commit: 8ce6ff13a4ffb86a05220a3e3aa7e67f6ade4bbe https://github.com/buildbot/buildbot/commit/8ce6ff13a4ffb86a05220a3e3aa7e67f6ade4bbe Author: Dustin J. Mitchell Date: 2011-06-26 (Sun, 26 Jun 2011) Changed paths: M master/buildbot/db/pool.py M master/buildbot/test/unit/test_db_pool.py Log Message: ----------- add debug mode for db pool This can be turned on for users having database problems, and the logs sent along to a developer. Its output is *very* verbose, but it can find overlapping and long queries, among other benefits. Commit: 9391fb46dc77c30861eea121e07451358f2a5fbb https://github.com/buildbot/buildbot/commit/9391fb46dc77c30861eea121e07451358f2a5fbb Author: Dustin J. Mitchell Date: 2011-06-26 (Sun, 26 Jun 2011) Changed paths: M master/buildbot/db/pool.py M master/buildbot/test/unit/test_db_pool.py Log Message: ----------- Merge branch 'bug2005' * bug2005: add debug mode for db pool Compare: https://github.com/buildbot/buildbot/compare/71f21ad...9391fb4 From noreply at github.com Sun Jun 26 16:44:40 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 26 Jun 2011 09:44:40 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] bb765d: test to replicate #2010 - postgres can't create bb... Message-ID: <20110626164440.A5E85424AB@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: bb765dbf6930b75c6543679b4f786781cb2cfdb9 https://github.com/buildbot/buildbot/commit/bb765dbf6930b75c6543679b4f786781cb2cfdb9 Author: Dustin J. Mitchell Date: 2011-06-26 (Sun, 26 Jun 2011) Changed paths: M master/buildbot/test/unit/test_db_buildrequests.py Log Message: ----------- test to replicate #2010 - postgres can't create bbtmp_claim_ids Refs #2010. Commit: 3f6b61e8f5f03b29b8393cd912f06b09906c02fc https://github.com/buildbot/buildbot/commit/3f6b61e8f5f03b29b8393cd912f06b09906c02fc Author: Dustin J. Mitchell Date: 2011-06-26 (Sun, 26 Jun 2011) Changed paths: M master/buildbot/db/buildrequests.py Log Message: ----------- Fix postgres problems with bbtmp_claim_ids Fixes #2010. Compare: https://github.com/buildbot/buildbot/compare/9391fb4...3f6b61e From nobody at buildbot.net Sun Jun 26 16:44:46 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 26 Jun 2011 16:44:46 -0000 Subject: [Buildbot-commits] [Buildbot] #2010: ProgrammingError using PostgreSQL In-Reply-To: <040.a4ac386bacd7452f5eb2134e2526224a@buildbot.net> References: <040.a4ac386bacd7452f5eb2134e2526224a@buildbot.net> Message-ID: <055.1e3838e4647edab0dfd1e3e109b019ab@buildbot.net> #2010: ProgrammingError using PostgreSQL ---------------------+--------------------- Reporter: abompard | Owner: Type: defect | Status: closed Priority: critical | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: fixed Keywords: database | ---------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Fix postgres problems with bbtmp_claim_ids Fixes #2010. Changeset: 3f6b61e8f5f03b29b8393cd912f06b09906c02fc -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jun 26 16:44:46 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 26 Jun 2011 16:44:46 -0000 Subject: [Buildbot-commits] [Buildbot] #2010: ProgrammingError using PostgreSQL In-Reply-To: <040.a4ac386bacd7452f5eb2134e2526224a@buildbot.net> References: <040.a4ac386bacd7452f5eb2134e2526224a@buildbot.net> Message-ID: <055.9420d4bc956687c28dc06fd9c1687265@buildbot.net> #2010: ProgrammingError using PostgreSQL ---------------------+-------------------- Reporter: abompard | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: Keywords: database | ---------------------+-------------------- Comment (by Dustin J. Mitchell): test to replicate #2010 - postgres can't create bbtmp_claim_ids Refs #2010. Changeset: bb765dbf6930b75c6543679b4f786781cb2cfdb9 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Jun 26 16:45:37 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 26 Jun 2011 09:45:37 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] ba9ddd: Fix postgres problems with bbtmp_claim_ids Message-ID: <20110626164537.6FB9D424AB@smtp1.rs.github.com> Branch: refs/heads/buildbot-0.8.4 Home: https://github.com/buildbot/buildbot Commit: ba9ddd59e8d8e8026e46d3c3bb83a39cddb15500 https://github.com/buildbot/buildbot/commit/ba9ddd59e8d8e8026e46d3c3bb83a39cddb15500 Author: Dustin J. Mitchell Date: 2011-06-26 (Sun, 26 Jun 2011) Changed paths: M master/buildbot/db/buildrequests.py Log Message: ----------- Fix postgres problems with bbtmp_claim_ids Fixes #2010. From nobody at buildbot.net Sun Jun 26 16:45:47 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 26 Jun 2011 16:45:47 -0000 Subject: [Buildbot-commits] [Buildbot] #2010: ProgrammingError using PostgreSQL In-Reply-To: <040.a4ac386bacd7452f5eb2134e2526224a@buildbot.net> References: <040.a4ac386bacd7452f5eb2134e2526224a@buildbot.net> Message-ID: <055.8aa2d78a4b060d14e931eb1dc59b9ace@buildbot.net> #2010: ProgrammingError using PostgreSQL ---------------------+--------------------- Reporter: abompard | Owner: Type: defect | Status: closed Priority: critical | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: fixed Keywords: database | ---------------------+--------------------- Comment (by Dustin J. Mitchell): Fix postgres problems with bbtmp_claim_ids Fixes #2010. Changeset: ba9ddd59e8d8e8026e46d3c3bb83a39cddb15500 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jun 26 18:47:00 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 26 Jun 2011 18:47:00 -0000 Subject: [Buildbot-commits] [Buildbot] #2011: Traceback popping from empty deque in addChange In-Reply-To: <043.d8d65df3cbcab5d1c78890f8f371eff1@buildbot.net> References: <043.d8d65df3cbcab5d1c78890f8f371eff1@buildbot.net> Message-ID: <058.b241a6ef8fc340d0a95493491d024922@buildbot.net> #2011: Traceback popping from empty deque in addChange ------------------------+-------------------- Reporter: adamcollard | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: Keywords: | ------------------------+-------------------- Comment (by dustin): So I can't see how this could have occurred. If you're willing to do a bit of debugging, I can provide a new version of {{{lru.py}}} to try (attached). Otherwise, a fix is: {{{ #!patch diff --git a/master/buildbot/util/lru.py b/master/buildbot/util/lru.py index 7e19906..d13df75 100644 --- a/master/buildbot/util/lru.py +++ b/master/buildbot/util/lru.py @@ -186,7 +186,7 @@ class AsyncLRUCache(object): # purge least recently used entries, using refcount # to count repeatedly-used entries while len(cache) > max_size: - refc = 1 + refc = len(queue) while refc: k = queue.popleft() refc = refcount[k] = refcount[k] - 1 }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Sun Jun 26 18:52:53 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 26 Jun 2011 18:52:53 -0000 Subject: [Buildbot-commits] [Buildbot] #2011: Traceback popping from empty deque in addChange In-Reply-To: <043.d8d65df3cbcab5d1c78890f8f371eff1@buildbot.net> References: <043.d8d65df3cbcab5d1c78890f8f371eff1@buildbot.net> Message-ID: <058.a2a2ba30ad3d1881354813d64e6550e4@buildbot.net> #2011: Traceback popping from empty deque in addChange ------------------------+-------------------- Reporter: adamcollard | Owner: Type: defect | Status: new Priority: critical | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: Keywords: | ------------------------+-------------------- Comment (by dustin): Replace your lru.py with this version, and then look for "INV" in your twistd.log. Let me know what you see. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Jun 26 18:53:48 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 26 Jun 2011 11:53:48 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 0355f1: more LRU tests Message-ID: <20110626185348.EC8BB424A2@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 0355f174e861dc85a89afa479d7a46abbc6c3873 https://github.com/buildbot/buildbot/commit/0355f174e861dc85a89afa479d7a46abbc6c3873 Author: Dustin J. Mitchell Date: 2011-06-26 (Sun, 26 Jun 2011) Changed paths: M master/buildbot/test/unit/test_util_lru.py Log Message: ----------- more LRU tests Commit: 5fbbed210f47671fc738639c2500bf818ae4897e https://github.com/buildbot/buildbot/commit/5fbbed210f47671fc738639c2500bf818ae4897e Author: Dustin J. Mitchell Date: 2011-06-26 (Sun, 26 Jun 2011) Changed paths: M master/buildbot/util/lru.py Log Message: ----------- correctly use defaultdict in AsyncLRUCache Commit: a1f545a85e6ef8d4aa598478b1e986a4bdb1e719 https://github.com/buildbot/buildbot/commit/a1f545a85e6ef8d4aa598478b1e986a4bdb1e719 Author: Dustin J. Mitchell Date: 2011-06-26 (Sun, 26 Jun 2011) Changed paths: M master/buildbot/util/lru.py Log Message: ----------- only reference non-None keys Commit: 4b4dffd5784376777ae9bad8fcf35972010bef00 https://github.com/buildbot/buildbot/commit/4b4dffd5784376777ae9bad8fcf35972010bef00 Author: Dustin J. Mitchell Date: 2011-06-26 (Sun, 26 Jun 2011) Changed paths: M master/buildbot/util/lru.py Log Message: ----------- add (un-called) invariant-checking method to AsyncLRUCache Commit: ef2eee64cad0e3af27a269b91338443564e1cd44 https://github.com/buildbot/buildbot/commit/ef2eee64cad0e3af27a269b91338443564e1cd44 Author: Dustin J. Mitchell Date: 2011-06-26 (Sun, 26 Jun 2011) Changed paths: M master/buildbot/process/buildstep.py M master/buildbot/steps/python_twisted.py M master/buildbot/steps/shell.py M master/buildbot/test/fake/remotecommand.py M master/buildbot/test/unit/test_steps_shell.py M master/buildbot/test/util/steps.py M master/docs/cfg-buildsteps.texinfo Log Message: ----------- Merge branch 'shelltests' * shelltests: use an option to silence command updates remove funny overriding of workdir in WarningCountingShellCommand new tests for WarningCountingShellCommands add test for shell.Configure add tests for SetProperty step tests for TreeSize Add fake addHTMLLog and addCompleteLog Remove compatibility with buildbot-0.7.3 slaves Complete (almost) tests for ShellCommand Compare: https://github.com/buildbot/buildbot/compare/3f6b61e...ef2eee6 From noreply at github.com Sun Jun 26 18:59:05 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 26 Jun 2011 11:59:05 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 8554fe: Allow MailNotifier subject to be overridden Message-ID: <20110626185905.D74EB424E0@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 8554fed2e3630200b373b0e98e81a240ba3cd6c2 https://github.com/buildbot/buildbot/commit/8554fed2e3630200b373b0e98e81a240ba3cd6c2 Author: Aurelian Bompard Date: 2011-06-26 (Sun, 26 Jun 2011) Changed paths: M master/buildbot/status/mail.py Log Message: ----------- Allow MailNotifier subject to be overridden Fixes #2014. From nobody at buildbot.net Sun Jun 26 18:59:12 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 26 Jun 2011 18:59:12 -0000 Subject: [Buildbot-commits] [Buildbot] #2014: The MailNotifier's subject can't be overriden anymore with a function In-Reply-To: <040.5c1e4db7d95c5a7da5ff76c569eddde4@buildbot.net> References: <040.5c1e4db7d95c5a7da5ff76c569eddde4@buildbot.net> Message-ID: <055.09bf6839181351f248c869f4a95cd020@buildbot.net> #2014: The MailNotifier's subject can't be overriden anymore with a function ---------------------+--------------------- Reporter: abompard | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: fixed Keywords: mail | ---------------------+--------------------- Changes (by Aurelian Bompard): * status: new => closed * resolution: => fixed Comment: Allow MailNotifier subject to be overridden Fixes #2014. Changeset: 8554fed2e3630200b373b0e98e81a240ba3cd6c2 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Jun 26 19:01:19 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 26 Jun 2011 12:01:19 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 2bcdc8: adjust docs for vstudio.py's installdir Message-ID: <20110626190119.55B3B424E0@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 2bcdc8f7543abbac19d0deabea0899e51a808e77 https://github.com/buildbot/buildbot/commit/2bcdc8f7543abbac19d0deabea0899e51a808e77 Author: Dustin J. Mitchell Date: 2011-06-26 (Sun, 26 Jun 2011) Changed paths: M master/docs/cfg-buildsteps.texinfo Log Message: ----------- adjust docs for vstudio.py's installdir Fixes #2013. From nobody at buildbot.net Sun Jun 26 19:01:27 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 26 Jun 2011 19:01:27 -0000 Subject: [Buildbot-commits] [Buildbot] #2013: Description of "installdir" parameter for Visual Studio step is unclear In-Reply-To: <043.e1ad12301a26278fdc60f83882b164c9@buildbot.net> References: <043.e1ad12301a26278fdc60f83882b164c9@buildbot.net> Message-ID: <058.c01629a8f4e8a5cec6fa2b3750c171f9@buildbot.net> #2013: Description of "installdir" parameter for Visual Studio step is unclear ------------------------+--------------------- Reporter: mitcholiver | Owner: Type: enhancement | Status: closed Priority: trivial | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: fixed Keywords: docs | ------------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: adjust docs for vstudio.py's installdir Fixes #2013. Changeset: 2bcdc8f7543abbac19d0deabea0899e51a808e77 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Jun 26 20:00:33 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 26 Jun 2011 13:00:33 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] de6eb2: Abbreviate property lists from SetProperty Message-ID: <20110626200033.4475242462@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: de6eb274cf7da3d3080be92d9656e8d0d9da50dc https://github.com/buildbot/buildbot/commit/de6eb274cf7da3d3080be92d9656e8d0d9da50dc Author: Dustin J. Mitchell Date: 2011-06-26 (Sun, 26 Jun 2011) Changed paths: M master/buildbot/steps/shell.py M master/buildbot/test/unit/test_steps_shell.py Log Message: ----------- Abbreviate property lists from SetProperty Fixes #2012. From nobody at buildbot.net Sun Jun 26 20:00:39 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 26 Jun 2011 20:00:39 -0000 Subject: [Buildbot-commits] [Buildbot] #2012: SetProperty text status may fill WebStatus waterfall In-Reply-To: <036.2556c5dd889450efa718834425167186@buildbot.net> References: <036.2556c5dd889450efa718834425167186@buildbot.net> Message-ID: <051.efd731744c9e0152c0065c110156fd05@buildbot.net> #2012: SetProperty text status may fill WebStatus waterfall ------------------------+--------------------- Reporter: ed10 | Owner: Type: enhancement | Status: closed Priority: trivial | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: fixed Keywords: web | ------------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Abbreviate property lists from SetProperty Fixes #2012. Changeset: de6eb274cf7da3d3080be92d9656e8d0d9da50dc -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Jun 26 20:01:17 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 26 Jun 2011 13:01:17 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] c6bc46: Merge branch 'features/svn-script-parameters' of g... Message-ID: <20110626200117.E788542483@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: c6bc46755c2383f395e51a44e036439891b4a6dc https://github.com/buildbot/buildbot/commit/c6bc46755c2383f395e51a44e036439891b4a6dc Author: Dustin J. Mitchell Date: 2011-06-26 (Sun, 26 Jun 2011) Changed paths: M master/contrib/svn_buildbot.py Log Message: ----------- Merge branch 'features/svn-script-parameters' of git://github.com/smarr/buildbot * 'features/svn-script-parameters' of git://github.com/smarr/buildbot: Added project parameter and added an option to give a different repo for the slaves to access. From nobody at buildbot.net Sun Jun 26 20:31:04 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 26 Jun 2011 20:31:04 -0000 Subject: [Buildbot-commits] [Buildbot] #1990: Source steps falling back to complete re-initialization should not be mandatory In-Reply-To: <037.a8ad1401ad7ff566359b5a60a33f9e3e@buildbot.net> References: <037.a8ad1401ad7ff566359b5a60a33f9e3e@buildbot.net> Message-ID: <052.0b5666a2b1681edc461a77b4db2235a3@buildbot.net> #1990: Source steps falling back to complete re-initialization should not be mandatory ------------------------+-------------------- Reporter: ayust | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.4 | Resolution: Keywords: | ------------------------+-------------------- Changes (by pworach): * cc: pawel.worach@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Jun 26 21:43:27 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 26 Jun 2011 14:43:27 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] ebb637: added onlyImportant attribute to BaseBasicSchedule... Message-ID: <20110626214327.812E8422F8@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: ebb637e91583e1339773d12c312e363be828d23e https://github.com/buildbot/buildbot/commit/ebb637e91583e1339773d12c312e363be828d23e Author: Derek Hurley Date: 2011-06-26 (Sun, 26 Jun 2011) Changed paths: M master/buildbot/schedulers/base.py M master/buildbot/schedulers/basic.py M master/buildbot/schedulers/timed.py M master/buildbot/test/unit/test_schedulers_base.py M master/buildbot/test/unit/test_schedulers_basic.py M master/buildbot/test/unit/test_schedulers_timed_Nightly.py M master/docs/cfg-schedulers.texinfo Log Message: ----------- added onlyImportant attribute to BaseBasicScheduler and Nightly schedulers The onlyImportant attribute, when True, only adds changes deemed important by fileIsImportant to a buildset. fixes ticket #1957 Commit: b1c9b0d0aa39a355d2e184e7ba8069168af94523 https://github.com/buildbot/buildbot/commit/b1c9b0d0aa39a355d2e184e7ba8069168af94523 Author: Dustin J. Mitchell Date: 2011-06-26 (Sun, 26 Jun 2011) Changed paths: M master/buildbot/schedulers/base.py M master/buildbot/schedulers/basic.py M master/buildbot/schedulers/timed.py M master/buildbot/test/unit/test_schedulers_base.py M master/buildbot/test/unit/test_schedulers_basic.py M master/buildbot/test/unit/test_schedulers_timed_Nightly.py M master/docs/cfg-schedulers.texinfo Log Message: ----------- Merge branch 'ticket_1957' of git://github.com/dzhurley/buildbot * 'ticket_1957' of git://github.com/dzhurley/buildbot: added onlyImportant attribute to BaseBasicScheduler and Nightly schedulers Fixes #1957. Compare: https://github.com/buildbot/buildbot/compare/c6bc467...b1c9b0d From nobody at buildbot.net Sun Jun 26 21:43:33 2011 From: nobody at buildbot.net (Buildbot) Date: Sun, 26 Jun 2011 21:43:33 -0000 Subject: [Buildbot-commits] [Buildbot] #1957: Expand blamelist only by 'interested users' that are relevant for the build. In-Reply-To: <041.c8c3a27c9095e765e20f8885cd5613d6@buildbot.net> References: <041.c8c3a27c9095e765e20f8885cd5613d6@buildbot.net> Message-ID: <056.b55864ed6609c573b663457ad66d78cf@buildbot.net> #1957: Expand blamelist only by 'interested users' that are relevant for the build. --------------------------+--------------------- Reporter: rgoergens | Owner: Type: enhancement | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: fixed Keywords: redheadphones | --------------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Merge branch 'ticket_1957' of git://github.com/dzhurley/buildbot * 'ticket_1957' of git://github.com/dzhurley/buildbot: added onlyImportant attribute to BaseBasicScheduler and Nightly schedulers Fixes #1957. Changeset: b1c9b0d0aa39a355d2e184e7ba8069168af94523 -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Sun Jun 26 21:46:52 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 26 Jun 2011 14:46:52 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 4692e1: test for and supply the right number of arguments ... Message-ID: <20110626214652.D5F37424C3@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 4692e18f52a4a7099ee5d20288f871a6b151234e https://github.com/buildbot/buildbot/commit/4692e18f52a4a7099ee5d20288f871a6b151234e Author: Dustin J. Mitchell Date: 2011-06-26 (Sun, 26 Jun 2011) Changed paths: M master/buildbot/process/builder.py M master/buildbot/test/unit/test_process_builder.py Log Message: ----------- test for and supply the right number of arguments to mergeRequests functions From noreply at github.com Sun Jun 26 21:47:04 2011 From: noreply at github.com (noreply at github.com) Date: Sun, 26 Jun 2011 14:47:04 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] de9ffe: test for and supply the right number of arguments ... Message-ID: <20110626214704.E05C0424C3@smtp1.rs.github.com> Branch: refs/heads/buildbot-0.8.4 Home: https://github.com/buildbot/buildbot Commit: de9ffe22577f703863236cbc9b9819fdb8998321 https://github.com/buildbot/buildbot/commit/de9ffe22577f703863236cbc9b9819fdb8998321 Author: Dustin J. Mitchell Date: 2011-06-26 (Sun, 26 Jun 2011) Changed paths: M master/buildbot/process/builder.py M master/buildbot/test/unit/test_process_builder.py Log Message: ----------- test for and supply the right number of arguments to mergeRequests functions From nobody at buildbot.net Mon Jun 27 05:13:17 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 27 Jun 2011 05:13:17 -0000 Subject: [Buildbot-commits] [Buildbot] #2015: master.cfg can not be provisioned with adjacent cfg files as of 0.8.4p1 In-Reply-To: <042.ad792e73baaa0aa8299c123a28eff712@buildbot.net> References: <042.ad792e73baaa0aa8299c123a28eff712@buildbot.net> Message-ID: <057.ecbc9ffeb4b30a1dbe1541a0ea0f4356@buildbot.net> #2015: master.cfg can not be provisioned with adjacent cfg files as of 0.8.4p1 -----------------------+-------------------- Reporter: garmstrong | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: Keywords: | -----------------------+-------------------- Comment (by dustin): Gareth, what do you think of https://github.com/djmitche/buildbot/commit/5b06af641790af9866039dafc51643c2221c01d2 as a fix for this? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Jun 27 13:10:11 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 27 Jun 2011 13:10:11 -0000 Subject: [Buildbot-commits] [Buildbot] #2015: master.cfg can not be provisioned with adjacent cfg files as of 0.8.4p1 In-Reply-To: <042.ad792e73baaa0aa8299c123a28eff712@buildbot.net> References: <042.ad792e73baaa0aa8299c123a28eff712@buildbot.net> Message-ID: <057.f84c686ee76337fee4b49bd2e9a72a52@buildbot.net> #2015: master.cfg can not be provisioned with adjacent cfg files as of 0.8.4p1 -----------------------+-------------------- Reporter: garmstrong | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: Keywords: | -----------------------+-------------------- Comment (by garmstrong): Replying to [comment:2 dustin]: Thanks Dustin, the changeset looks good. I gave it a spin and it works just fine with my config layout. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Jun 27 15:41:59 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 27 Jun 2011 15:41:59 -0000 Subject: [Buildbot-commits] [Buildbot] #1942: Store passwords in hashed form In-Reply-To: <041.ab8723608c9e5208d80dd1a487892b28@buildbot.net> References: <041.ab8723608c9e5208d80dd1a487892b28@buildbot.net> Message-ID: <056.dc4ed2bb625e28bcc1e7ca7f388cd310@buildbot.net> #1942: Store passwords in hashed form -------------------------+-------------------- Reporter: dabrahams | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: redheaphones | -------------------------+-------------------- Changes (by dustin): * milestone: undecided => 0.8.+ -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Mon Jun 27 15:42:05 2011 From: noreply at github.com (noreply at github.com) Date: Mon, 27 Jun 2011 08:42:05 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 5b06af: Run checkconfig right there in the master director... Message-ID: <20110627154205.5BFFB42353@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 5b06af641790af9866039dafc51643c2221c01d2 https://github.com/buildbot/buildbot/commit/5b06af641790af9866039dafc51643c2221c01d2 Author: Dustin J. Mitchell Date: 2011-06-26 (Sun, 26 Jun 2011) Changed paths: M master/buildbot/scripts/checkconfig.py M master/buildbot/scripts/runner.py A master/buildbot/test/unit/test_scripts_checkconfig.py M master/buildbot/test/unit/test_scripts_runner.py Log Message: ----------- Run checkconfig right there in the master directory ..rather than copying the contents of the directory somewhere. This includes tests that verify, among other things, that builder directories are not unnecessarily created. From nobody at buildbot.net Mon Jun 27 15:43:26 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 27 Jun 2011 15:43:26 -0000 Subject: [Buildbot-commits] [Buildbot] #2015: master.cfg can not be provisioned with adjacent cfg files as of 0.8.4p1 In-Reply-To: <042.ad792e73baaa0aa8299c123a28eff712@buildbot.net> References: <042.ad792e73baaa0aa8299c123a28eff712@buildbot.net> Message-ID: <057.25e3cd9511e8b45104246465ab402a92@buildbot.net> #2015: master.cfg can not be provisioned with adjacent cfg files as of 0.8.4p1 -----------------------+--------------------- Reporter: garmstrong | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: fixed Keywords: | -----------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: Excellent - merged. Thanks! -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Jun 27 16:13:24 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 27 Jun 2011 16:13:24 -0000 Subject: [Buildbot-commits] [Buildbot] #1927: buildbot: commit notification crashes with Unicode characters in git commit logs In-Reply-To: <042.62a01509157b131a211691437b81f8c0@buildbot.net> References: <042.62a01509157b131a211691437b81f8c0@buildbot.net> Message-ID: <057.1e0149a2366955d111572437eedcdc75@buildbot.net> #1927: buildbot: commit notification crashes with Unicode characters in git commit logs -----------------------+------------------------ Reporter: edwintorok | Owner: Type: defect | Status: closed Priority: major | Milestone: undecided Version: 0.8.3p1 | Resolution: fixed Keywords: | -----------------------+------------------------ Changes (by dustin): * status: new => closed * resolution: => fixed Comment: As of [605ac9aaf644613a43f076fd25ddcbef93a6c087], Sender has an encoding parameter, so I believe this is fixed. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Mon Jun 27 16:35:18 2011 From: nobody at buildbot.net (Buildbot) Date: Mon, 27 Jun 2011 16:35:18 -0000 Subject: [Buildbot-commits] [Buildbot] #1937: Exceptions in Logfile.merge (called from LogFile.addEntry) aren't handled, causing the step to fail, without finishing the build In-Reply-To: <042.e9e88b46f278bd6178d32ba8472e71e1@buildbot.net> References: <042.e9e88b46f278bd6178d32ba8472e71e1@buildbot.net> Message-ID: <057.888662ce78bb427935058104a1372f27@buildbot.net> #1937: Exceptions in Logfile.merge (called from LogFile.addEntry) aren't handled, causing the step to fail, without finishing the build -----------------------+-------------------- Reporter: tom.prince | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.3p1 | Resolution: Keywords: | -----------------------+-------------------- Changes (by dustin): * milestone: undecided => 0.8.5 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jun 28 10:49:04 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 28 Jun 2011 10:49:04 -0000 Subject: [Buildbot-commits] [Buildbot] #2016: upgrade-master errror: local variable conn1 referenced before assignment Message-ID: <039.80f57d0b806c72443eb0ad31915359ba@buildbot.net> #2016: upgrade-master errror: local variable conn1 referenced before assignment --------------------+----------------------- Reporter: cortana | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4p1 | Keywords: --------------------+----------------------- The fix for #1810 has broken upgrade-master on my system: {{{ $ buildbot upgrade-master /srv/buildbot upgrading basedir /srv/buildbot/public_html/default.css has old/modified contents writing new contents to /srv/buildbot/public_html/default.css.new /srv/buildbot/master.cfg.sample has old/modified contents overwriting it with new contents checking master.cfg /usr/lib/python2.6/dist-packages/twisted/mail/smtp.py:10: DeprecationWarning: the MimeWriter module is deprecated; use the email package instead import MimeWriter, tempfile, rfc822 upgrading database Traceback (most recent call last): File "/usr/lib/python2.6/dist-packages/twisted/internet/base.py", line 426, in _continueFiring callable(*args, **kwargs) File "/usr/lib/python2.6/dist-packages/buildbot/scripts/runner.py", line 36, in async d = defer.maybeDeferred(f, *args, **kwargs) File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line 125, in maybeDeferred result = f(*args, **kw) File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line 837, in unwindGenerator return _deferGenerator(f(*args, **kwargs), Deferred()) --- --- File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line 739, in _deferGenerator result = g.next() File "/usr/lib/python2.6/dist-packages/buildbot/scripts/runner.py", line 499, in upgradeMaster basedir=config['basedir']) File "/usr/lib/python2.6/dist-packages/buildbot/db/connector.py", line 43, in __init__ self.pool = pool.DBThreadPool(self._engine) File "/usr/lib/python2.6/dist-packages/buildbot/db/pool.py", line 73, in __init__ self.__broken_sqlite = self.detect_bug1810() File "/usr/lib/python2.6/dist-packages/buildbot/db/pool.py", line 210, in detect_bug1810 test() File "/usr/lib/python2.6/dist-packages/buildbot/db/pool.py", line 205, in test conn1.close() exceptions.UnboundLocalError: local variable 'conn1' referenced before assignment }}} I'm guessing that line 193 throws while connecting to dbfile, thus conn1 is never assigned to. I'm using Python 2.6.6 on Debian with SQLAlchemy 0.6.3 and sqlalchemy- migrate 0.6. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jun 28 11:11:00 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 28 Jun 2011 11:11:00 -0000 Subject: [Buildbot-commits] [Buildbot] #2016: upgrade-master errror: local variable conn1 referenced before assignment In-Reply-To: <039.80f57d0b806c72443eb0ad31915359ba@buildbot.net> References: <039.80f57d0b806c72443eb0ad31915359ba@buildbot.net> Message-ID: <054.54d02477aaeacffc53e345e43ef8fdcd@buildbot.net> #2016: upgrade-master errror: local variable conn1 referenced before assignment --------------------+------------------------ Reporter: cortana | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4p1 | Resolution: Keywords: | --------------------+------------------------ Comment (by cortana): This was caused because the test database was being created in the current directory, which the buildbot user did not have access to. I suggest creating the test database within a directory created by calling tempfile.mkdtemp. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Tue Jun 28 15:43:03 2011 From: noreply at github.com (noreply at github.com) Date: Tue, 28 Jun 2011 08:43:03 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 177bd4: Mercurial source steps completed Message-ID: <20110628154303.A9A5A42503@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 177bd4da6c516dedc6850a3f1018fd4b7e7ef377 https://github.com/buildbot/buildbot/commit/177bd4da6c516dedc6850a3f1018fd4b7e7ef377 Author: Pradeepkumar Gayam Date: 2011-06-28 (Tue, 28 Jun 2011) Changed paths: R master/buildbot/steps/source.py A master/buildbot/steps/source/__init__.py A master/buildbot/steps/source/mercurial.py A master/buildbot/steps/source/oldsource.py A master/buildbot/test/unit/test_steps_source_mercurial.py M master/buildbot/test/util/sourcesteps.py M master/docs/cfg-buildsteps.texinfo Log Message: ----------- Mercurial source steps completed Commit: dec10f354c3edd66c668125b5a3e33ca3d094b0f https://github.com/buildbot/buildbot/commit/dec10f354c3edd66c668125b5a3e33ca3d094b0f Author: Dustin J. Mitchell Date: 2011-06-28 (Tue, 28 Jun 2011) Changed paths: M master/docs/cfg-buildsteps.texinfo Log Message: ----------- reorg docs for new source steps Commit: b6071c0976be4931354772b03addc190bafa54a4 https://github.com/buildbot/buildbot/commit/b6071c0976be4931354772b03addc190bafa54a4 Author: Dustin J. Mitchell Date: 2011-06-28 (Tue, 28 Jun 2011) Changed paths: M master/buildbot/steps/source/__init__.py M master/buildbot/test/util/sourcesteps.py Log Message: ----------- fix pyflakes Commit: e46136f1b4cc8ce190f29a777c4f371f5f8a20da https://github.com/buildbot/buildbot/commit/e46136f1b4cc8ce190f29a777c4f371f5f8a20da Author: Dustin J. Mitchell Date: 2011-06-28 (Tue, 28 Jun 2011) Changed paths: R master/buildbot/steps/source.py A master/buildbot/steps/source/__init__.py A master/buildbot/steps/source/mercurial.py A master/buildbot/steps/source/oldsource.py A master/buildbot/test/unit/test_steps_source_mercurial.py M master/buildbot/test/util/sourcesteps.py M master/docs/cfg-buildsteps.texinfo Log Message: ----------- Merge branch 'gsoc_commit' * gsoc_commit: fix pyflakes reorg docs for new source steps Mercurial source steps completed Compare: https://github.com/buildbot/buildbot/compare/5b06af6...e46136f From noreply at github.com Tue Jun 28 15:53:52 2011 From: noreply at github.com (noreply at github.com) Date: Tue, 28 Jun 2011 08:53:52 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 7aac17: Create the bug-test DB in a temporary dir Message-ID: <20110628155352.657DA422D6@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 7aac17fe5e1f8bbfe794ecec1db99d7b7528d8b0 https://github.com/buildbot/buildbot/commit/7aac17fe5e1f8bbfe794ecec1db99d7b7528d8b0 Author: Dustin J. Mitchell Date: 2011-06-28 (Tue, 28 Jun 2011) Changed paths: M master/buildbot/db/pool.py Log Message: ----------- Create the bug-test DB in a temporary dir Fixes #2016. From nobody at buildbot.net Tue Jun 28 15:53:58 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 28 Jun 2011 15:53:58 -0000 Subject: [Buildbot-commits] [Buildbot] #2016: upgrade-master errror: local variable conn1 referenced before assignment In-Reply-To: <039.80f57d0b806c72443eb0ad31915359ba@buildbot.net> References: <039.80f57d0b806c72443eb0ad31915359ba@buildbot.net> Message-ID: <054.4ad0a307d3de93ee57aa9eaab360ff2c@buildbot.net> #2016: upgrade-master errror: local variable conn1 referenced before assignment --------------------+------------------------ Reporter: cortana | Owner: Type: defect | Status: closed Priority: major | Milestone: undecided Version: 0.8.4p1 | Resolution: fixed Keywords: | --------------------+------------------------ Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Create the bug-test DB in a temporary dir Fixes #2016. Changeset: 7aac17fe5e1f8bbfe794ecec1db99d7b7528d8b0 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jun 28 20:35:41 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 28 Jun 2011 20:35:41 -0000 Subject: [Buildbot-commits] [Buildbot] #2017: attaching logs to build mail is broken in 0.8.4p1 Message-ID: <039.1ea156c78f375eaf0d545e5150f38270@buildbot.net> #2017: attaching logs to build mail is broken in 0.8.4p1 --------------------+----------------------- Reporter: dberger | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4p1 | Keywords: --------------------+----------------------- 2011-06-28 13:03:43-0700 [-] Exception caught notifying of buildFinished event 2011-06-28 13:03:43-0700 [-] Unhandled Error Traceback (most recent call last): File "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\build.py", line 288, in buildFinished w.callback(self) File "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line 361, in callback self._startRunCallbacks(result) File "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line 455, in _startRunCallbacks self._runCallbacks() File "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line 542, in _runCallbacks current.result = callback(current.result, *args, **kw) --- --- File "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\builder.py", line 541, in _buildFinished w.buildFinished(name, s, results) File "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\mail.py", line 410, in buildFinished return self.buildMessage(name, [build], results) File "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\mail.py", line 593, in buildMessage results, builds, patches, logs) File "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\mail.py", line 529, in createEmail name = "%s.%s" % (log.getStep().getName(), exceptions.AttributeError: 'list' object has no attribute 'getStep' It looks like this change may be related: 2ad09c73 Adam Added the ability to only send a single summary email from a MailNotif... May 29, 2011 I think changing logs.append(build.getLogs()) to logs.extend(build.getLogs()) on mail.py:583 is more correct, but I'm waiting for our master to shutdown so I can test. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jun 28 20:36:35 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 28 Jun 2011 20:36:35 -0000 Subject: [Buildbot-commits] [Buildbot] #2017: attaching logs to build mail is broken in 0.8.4p1 In-Reply-To: <039.1ea156c78f375eaf0d545e5150f38270@buildbot.net> References: <039.1ea156c78f375eaf0d545e5150f38270@buildbot.net> Message-ID: <054.0e77cf31c8e9a1a7328fb80764ed3091@buildbot.net> #2017: attaching logs to build mail is broken in 0.8.4p1 --------------------+------------------------ Reporter: dberger | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4p1 | Resolution: Keywords: | --------------------+------------------------ Comment (by dberger): Oh, missed the first line in the log chunk: 2011-06-28 13:03:40-0700 [-] 'LOG: [[]]' note the double brackets (i.e. logs is a list of lists) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jun 28 21:51:42 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 28 Jun 2011 21:51:42 -0000 Subject: [Buildbot-commits] [Buildbot] #2018: build mail breakage in 0.8.4p1 Message-ID: <039.4ffe5a1269bfe42b9e47dcd875e1538c@buildbot.net> #2018: build mail breakage in 0.8.4p1 --------------------+----------------------- Reporter: dberger | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4p1 | Keywords: --------------------+----------------------- the fix I mention in ticket 2017 moves the error further into the mail code. 2011-06-28 14:36:40-0700 [-] Exception caught notifying of buildFinished event 2011-06-28 14:36:40-0700 [-] Unhandled Error Traceback (most recent call last): File "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\build.py", line 288, in buildFinished w.callback(self) File "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line 361, in callback self._startRunCallbacks(result) File "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line 455, in _startRunCallbacks self._runCallbacks() File "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line 542, in _runCallbacks current.result = callback(current.result, *args, **kw) --- --- File "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\builder.py", line 541, in _buildFinished w.buildFinished(name, s, results) File "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\mail.py", line 410, in buildFinished return self.buildMessage(name, [build], results) File "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\mail.py", line 593, in buildMessage results, builds, patches, logs) File "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\mail.py", line 544, in createEmail if len(builds == 1): exceptions.TypeError: object of type 'bool' has no len() -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jun 28 23:52:39 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 28 Jun 2011 23:52:39 -0000 Subject: [Buildbot-commits] [Buildbot] #2017: attaching logs to build mail is broken in 0.8.4p1 In-Reply-To: <039.1ea156c78f375eaf0d545e5150f38270@buildbot.net> References: <039.1ea156c78f375eaf0d545e5150f38270@buildbot.net> Message-ID: <054.a7e5bcde90239408ec44063ca629f0bb@buildbot.net> #2017: attaching logs to build mail is broken in 0.8.4p1 --------------------+-------------------- Reporter: dberger | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: Keywords: | --------------------+-------------------- Changes (by dustin): * milestone: undecided => 0.8.5 Old description: > 2011-06-28 13:03:43-0700 [-] Exception caught notifying > of > buildFinished event > 2011-06-28 13:03:43-0700 [-] Unhandled Error > Traceback (most recent call last): > File > "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\build.py", > line 288, in buildFinished > w.callback(self) > File > "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line > 361, in callback > self._startRunCallbacks(result) > File > "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line > 455, in _startRunCallbacks > self._runCallbacks() > File > "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line > 542, in _runCallbacks > current.result = callback(current.result, *args, **kw) > --- --- > File > "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\builder.py", > line 541, in _buildFinished > w.buildFinished(name, s, results) > File > "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\mail.py", line > 410, in buildFinished > return self.buildMessage(name, [build], results) > File > "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\mail.py", line > 593, in buildMessage > results, builds, patches, logs) > File > "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\mail.py", line > 529, in createEmail > name = "%s.%s" % (log.getStep().getName(), > exceptions.AttributeError: 'list' object has no attribute > 'getStep' > > It looks like this change may be related: > > 2ad09c73 Adam Added the ability to only send a single summary > email from a MailNotif... May 29, 2011 > > I think changing logs.append(build.getLogs()) to > logs.extend(build.getLogs()) on mail.py:583 is more correct, but I'm > waiting for our master to shutdown so I can test. New description: {{{ 2011-06-28 13:03:43-0700 [-] Exception caught notifying of buildFinished event 2011-06-28 13:03:43-0700 [-] Unhandled Error Traceback (most recent call last): File "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\build.py", line 288, in buildFinished w.callback(self) File "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line 361, in callback self._startRunCallbacks(result) File "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line 455, in _startRunCallbacks self._runCallbacks() File "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line 542, in _runCallbacks current.result = callback(current.result, *args, **kw) --- --- File "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\builder.py", line 541, in _buildFinished w.buildFinished(name, s, results) File "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\mail.py", line 410, in buildFinished return self.buildMessage(name, [build], results) File "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\mail.py", line 593, in buildMessage results, builds, patches, logs) File "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\mail.py", line 529, in createEmail name = "%s.%s" % (log.getStep().getName(), exceptions.AttributeError: 'list' object has no attribute 'getStep' }}} It looks like this change may be related: {{{ 2ad09c73 Adam Added the ability to only send a single summary email from a MailNotif... May 29, 2011 }}} I think changing logs.append(build.getLogs()) to logs.extend(build.getLogs()) on mail.py:583 is more correct, but I'm waiting for our master to shutdown so I can test. -- -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Tue Jun 28 23:52:55 2011 From: nobody at buildbot.net (Buildbot) Date: Tue, 28 Jun 2011 23:52:55 -0000 Subject: [Buildbot-commits] [Buildbot] #2018: build mail breakage in 0.8.4p1 In-Reply-To: <039.4ffe5a1269bfe42b9e47dcd875e1538c@buildbot.net> References: <039.4ffe5a1269bfe42b9e47dcd875e1538c@buildbot.net> Message-ID: <054.61b4075a16980ecc1a794c425ebcd9aa@buildbot.net> #2018: build mail breakage in 0.8.4p1 --------------------+-------------------- Reporter: dberger | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: Keywords: | --------------------+-------------------- Changes (by dustin): * milestone: undecided => 0.8.5 Old description: > the fix I mention in ticket 2017 moves the error further into the mail > code. > > 2011-06-28 14:36:40-0700 [-] Exception caught notifying > of > buildFinished event > 2011-06-28 14:36:40-0700 [-] Unhandled Error > Traceback (most recent call last): > File > "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\build.py", > line 288, in buildFinished > w.callback(self) > File > "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line > 361, in callback > self._startRunCallbacks(result) > File > "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line > 455, in _startRunCallbacks > self._runCallbacks() > File > "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line > 542, in _runCallbacks > current.result = callback(current.result, *args, **kw) > --- --- > File > "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\builder.py", > line 541, in _buildFinished > w.buildFinished(name, s, results) > File > "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\mail.py", line > 410, in buildFinished > return self.buildMessage(name, [build], results) > File > "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\mail.py", line > 593, in buildMessage > results, builds, patches, logs) > File > "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\mail.py", line > 544, in createEmail > if len(builds == 1): > exceptions.TypeError: object of type 'bool' has no len() New description: the fix I mention in #2017 moves the error further into the mail code. {{{ 2011-06-28 14:36:40-0700 [-] Exception caught notifying of buildFinished event 2011-06-28 14:36:40-0700 [-] Unhandled Error Traceback (most recent call last): File "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\build.py", line 288, in buildFinished w.callback(self) File "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line 361, in callback self._startRunCallbacks(result) File "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line 455, in _startRunCallbacks self._runCallbacks() File "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line 542, in _runCallbacks current.result = callback(current.result, *args, **kw) --- --- File "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\builder.py", line 541, in _buildFinished w.buildFinished(name, s, results) File "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\mail.py", line 410, in buildFinished return self.buildMessage(name, [build], results) File "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\mail.py", line 593, in buildMessage results, builds, patches, logs) File "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\mail.py", line 544, in createEmail if len(builds == 1): exceptions.TypeError: object of type 'bool' has no len() }}} -- -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 00:03:25 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 00:03:25 -0000 Subject: [Buildbot-commits] [Buildbot] #2017: attaching logs to build mail is broken in 0.8.4p1 In-Reply-To: <039.1ea156c78f375eaf0d545e5150f38270@buildbot.net> References: <039.1ea156c78f375eaf0d545e5150f38270@buildbot.net> Message-ID: <054.123a7e4e26c1a0663a33b66ded611bfd@buildbot.net> #2017: attaching logs to build mail is broken in 0.8.4p1 --------------------+-------------------- Reporter: dberger | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: Keywords: | --------------------+-------------------- Comment (by dustin): As per #2018, the fix in the description produces errors further down the line. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 00:03:48 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 00:03:48 -0000 Subject: [Buildbot-commits] [Buildbot] #2018: build mail breakage in 0.8.4p1 In-Reply-To: <039.4ffe5a1269bfe42b9e47dcd875e1538c@buildbot.net> References: <039.4ffe5a1269bfe42b9e47dcd875e1538c@buildbot.net> Message-ID: <054.16fba89029553f082f958ef335443ec9@buildbot.net> #2018: build mail breakage in 0.8.4p1 --------------------+------------------------ Reporter: dberger | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: duplicate Keywords: | --------------------+------------------------ Changes (by dustin): * status: new => closed * resolution: => duplicate Comment: duped to #2017 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 00:42:34 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 00:42:34 -0000 Subject: [Buildbot-commits] [Buildbot] #2017: attaching logs to build mail is broken in 0.8.4p1 In-Reply-To: <039.1ea156c78f375eaf0d545e5150f38270@buildbot.net> References: <039.1ea156c78f375eaf0d545e5150f38270@buildbot.net> Message-ID: <054.ab758d10f3cafd513987ded0fa0fa8a3@buildbot.net> #2017: attaching logs to build mail is broken in 0.8.4p1 --------------------+-------------------- Reporter: dberger | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: Keywords: | --------------------+-------------------- Comment (by dberger): re: 2018 - looks like a typo mail.py:544 and mail.py:552 both say this: if len(builds ==1): and I'm pretty sure they mean this: if len(builds) == 1: -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 00:44:41 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 00:44:41 -0000 Subject: [Buildbot-commits] [Buildbot] #2017: attaching logs to build mail is broken in 0.8.4p1 In-Reply-To: <039.1ea156c78f375eaf0d545e5150f38270@buildbot.net> References: <039.1ea156c78f375eaf0d545e5150f38270@buildbot.net> Message-ID: <054.befcdfb78e1fa3f7b460a6b13b67c3eb@buildbot.net> #2017: attaching logs to build mail is broken in 0.8.4p1 --------------------+-------------------- Reporter: dberger | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: Keywords: | --------------------+-------------------- Comment (by dustin): Argh, I have a mental block on that particular typo! You'd think I'd learn (for the record, I didn't write this code, but I reviewed and merged it). I'm writing some tests now, but that's definitely the fix. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 01:03:10 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 01:03:10 -0000 Subject: [Buildbot-commits] [Buildbot] #2019: graceful shutdown and triggered builds don't play as expected (0.8.4p1) Message-ID: <039.1df5e0ed3d0c636c0cfad3244068609f@buildbot.net> #2019: graceful shutdown and triggered builds don't play as expected (0.8.4p1) --------------------+----------------------- Reporter: dberger | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4p1 | Keywords: --------------------+----------------------- we have several builders that act as coordinators for a set of triggered builds (so that binaries across platforms can be submitted in a single changelist). we noticed that if you hit graceful shutdown after the coordinator has started, but before it triggers the sub-builds, you're stuck - the sub- builders stay pending, and the triggering builder never proceeds, so you never shut down, but you stop doing work. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Jun 29 01:16:06 2011 From: noreply at github.com (noreply at github.com) Date: Tue, 28 Jun 2011 18:16:06 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 4df603: Fix typos in MailNotifier's support for buildsets Message-ID: <20110629011606.6151642570@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 4df603e64be38839214606cb52bc8fa850313360 https://github.com/buildbot/buildbot/commit/4df603e64be38839214606cb52bc8fa850313360 Author: Dustin J. Mitchell Date: 2011-06-28 (Tue, 28 Jun 2011) Changed paths: M master/buildbot/status/mail.py M master/buildbot/test/unit/test_status_mail_MailNotifier.py Log Message: ----------- Fix typos in MailNotifier's support for buildsets Fixes #2017. This adds some pretty ugly tests, too, to detect these failures. From nobody at buildbot.net Wed Jun 29 01:16:14 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 01:16:14 -0000 Subject: [Buildbot-commits] [Buildbot] #2017: attaching logs to build mail is broken in 0.8.4p1 In-Reply-To: <039.1ea156c78f375eaf0d545e5150f38270@buildbot.net> References: <039.1ea156c78f375eaf0d545e5150f38270@buildbot.net> Message-ID: <054.0f7daae700a2ccc1f3d7bea8844e86c5@buildbot.net> #2017: attaching logs to build mail is broken in 0.8.4p1 --------------------+--------------------- Reporter: dberger | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: fixed Keywords: | --------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Fix typos in MailNotifier's support for buildsets Fixes #2017. This adds some pretty ugly tests, too, to detect these failures. Changeset: 4df603e64be38839214606cb52bc8fa850313360 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 01:21:48 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 01:21:48 -0000 Subject: [Buildbot-commits] [Buildbot] #2020: can't run the debugclient in 0.8.4p1 Message-ID: <039.4de1c00b5dfe841fa352fc1b6972a997@buildbot.net> #2020: can't run the debugclient in 0.8.4p1 --------------------+----------------------- Reporter: dberger | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4p1 | Keywords: --------------------+----------------------- Traceback (most recent call last): File "/home/rackadmin/buildbot/buildbot/../external/buildbot-0.8.4p1/bin/buildbot", line 4, in runner.run() File "/home/rackadmin/buildbot/external/buildbot-0.8.4p1/buildbot/scripts/runner.py", line 1246, in run debugclient(so) File "/home/rackadmin/buildbot/external/buildbot-0.8.4p1/buildbot/scripts/runner.py", line 742, in debugclient from buildbot.clients import debug File "/home/rackadmin/buildbot/external/buildbot-0.8.4p1/buildbot/clients/debug.py", line 18, in gtk2reactor.install() File "/home/rackadmin/buildbot/external/Twisted-11.0.0/twisted/internet/gtk2reactor.py", line 379, in install installReactor(reactor) File "/home/rackadmin/buildbot/external/Twisted-11.0.0/twisted/internet/main.py", line 30, in installReactor raise error.ReactorAlreadyInstalledError("reactor already installed") twisted.internet.error.ReactorAlreadyInstalledError: reactor already installed this is particularly problematic to us as we run our buildmaster on windows, so we've effectively lost the ability to dynamically reconfigure it. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 01:28:05 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 01:28:05 -0000 Subject: [Buildbot-commits] [Buildbot] #1931: EC2LatentBuildSlave does not terminate EBS-backed instances In-Reply-To: <039.22b73804c67d3b129c8dbad66797bc75@buildbot.net> References: <039.22b73804c67d3b129c8dbad66797bc75@buildbot.net> Message-ID: <054.b71c9522a20eb8b40edf392db453d9cc@buildbot.net> #1931: EC2LatentBuildSlave does not terminate EBS-backed instances ---------------------------+-------------------- Reporter: mback2k | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.3p1 | Resolution: Keywords: virtualization | ---------------------------+-------------------- Changes (by dustin): * keywords: => virtualization * milestone: undecided => 0.8.5 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 01:29:10 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 01:29:10 -0000 Subject: [Buildbot-commits] [Buildbot] #1948: WithProperties doesn't interact properly with reconfig In-Reply-To: <041.537f4449c6c3fce9ae209d184140932f@buildbot.net> References: <041.537f4449c6c3fce9ae209d184140932f@buildbot.net> Message-ID: <056.9caf174860c7c07ac002107f67dd9633@buildbot.net> #1948: WithProperties doesn't interact properly with reconfig ----------------------+-------------------- Reporter: dabrahams | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: | ----------------------+-------------------- Changes (by dustin): * milestone: undecided => 0.8.+ -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 01:31:08 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 01:31:08 -0000 Subject: [Buildbot-commits] [Buildbot] #1963: FileUpload creates truncated file when buildslave is not on localhost In-Reply-To: <038.d8aba18af3dd124e6fb92915e876c160@buildbot.net> References: <038.d8aba18af3dd124e6fb92915e876c160@buildbot.net> Message-ID: <053.f6a8f075a3d19bb670a21255787f84a5@buildbot.net> #1963: FileUpload creates truncated file when buildslave is not on localhost ---------------------+-------------------- Reporter: landry | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: transfer | ---------------------+-------------------- Changes (by dustin): * keywords: => transfer * type: undecided => defect * milestone: undecided => 0.8.+ Comment: Any progress on this? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 01:32:08 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 01:32:08 -0000 Subject: [Buildbot-commits] [Buildbot] #1970: IRC status notifier is reconnecting too fast In-Reply-To: <037.f93a33de7d321ac6aed00eaf68e15f66@buildbot.net> References: <037.f93a33de7d321ac6aed00eaf68e15f66@buildbot.net> Message-ID: <052.ee18f252d5c7657f281cbd4ca0cc308b@buildbot.net> #1970: IRC status notifier is reconnecting too fast --------------------------+-------------------- Reporter: Almad | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.0 | Resolution: Keywords: redheadphones | --------------------------+-------------------- Changes (by dustin): * milestone: undecided => 0.8.+ -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 01:38:48 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 01:38:48 -0000 Subject: [Buildbot-commits] [Buildbot] #2000: "alwaysUseLatest" doesn't do what it says In-Reply-To: <041.16f29ce554aad5e31a1a961ab126f0d3@buildbot.net> References: <041.16f29ce554aad5e31a1a961ab126f0d3@buildbot.net> Message-ID: <056.bde5aa41c28d54ec50d5210903a4b6ea@buildbot.net> #2000: "alwaysUseLatest" doesn't do what it says --------------------------+-------------------- Reporter: dabrahams | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.4p1 | Resolution: Keywords: git, projrepo | --------------------------+-------------------- Changes (by dustin): * keywords: git => git, projrepo * milestone: undecided => 0.8.+ Comment: I think this has to do with general projrepo support, and I don't think this is expected to be working yet. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 01:45:55 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 01:45:55 -0000 Subject: [Buildbot-commits] [Buildbot] #2019: graceful shutdown and triggered builds don't play as expected (0.8.4p1) In-Reply-To: <039.1df5e0ed3d0c636c0cfad3244068609f@buildbot.net> References: <039.1df5e0ed3d0c636c0cfad3244068609f@buildbot.net> Message-ID: <054.57a0b4aa826044a4e0e16e47dc12a0df@buildbot.net> #2019: graceful shutdown and triggered builds don't play as expected (0.8.4p1) --------------------+-------------------- Reporter: dberger | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.4p1 | Resolution: Keywords: | --------------------+-------------------- Changes (by dustin): * milestone: undecided => 0.8.+ Comment: Hm, how would we fix this? It's essentially a deadlock. I think that the "right" answer is to run the triggered builds anyway, but that's pretty difficult. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 01:48:03 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 01:48:03 -0000 Subject: [Buildbot-commits] [Buildbot] #1908: Warn users of about changing db_url during an upgrade. (was: Warn users of configuration keys that need changing during an upgrade.) In-Reply-To: <036.b968338e20d9405c26e52c9555016f56@buildbot.net> References: <036.b968338e20d9405c26e52c9555016f56@buildbot.net> Message-ID: <051.6837290892e122f0fcc9b9bb3742e7d9@buildbot.net> #1908: Warn users of about changing db_url during an upgrade. --------------------------+------------------------- Reporter: verm | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: 0.8.5 Version: master | Resolution: worksforme Keywords: redheadphones | --------------------------+------------------------- Changes (by dustin): * keywords: upgrade, redheadphones => redheadphones * status: new => closed * resolution: => worksforme * milestone: undecided => 0.8.5 Comment: ipv6guru - the default value is {{{sqlite:///state.sqlite}}}, so if you're using sqlite, you don't actually need to set the parameter in master.cfg. If you specify a --db= to upgrade-master, then you *do*, but there are warnings for that. There are no other parameters that must be changed, so I think that the more general subject of this ticket is not required. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 01:49:04 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 01:49:04 -0000 Subject: [Buildbot-commits] [Buildbot] #1919: Display revision in waterfall build box In-Reply-To: <038.fd9a512a18ffaf0154a7906a42789ffd@buildbot.net> References: <038.fd9a512a18ffaf0154a7906a42789ffd@buildbot.net> Message-ID: <053.59a9e357f421f4ac394a621ec6d7ec75@buildbot.net> #1919: Display revision in waterfall build box ------------------------+-------------------- Reporter: cpeyer | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.8.5 Version: 0.8.3p1 | Resolution: Keywords: | ------------------------+-------------------- Changes (by dustin): * milestone: undecided => 0.8.5 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 01:49:54 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 01:49:54 -0000 Subject: [Buildbot-commits] [Buildbot] #1955: Suboptimal default for submodules In-Reply-To: <041.8b7585719df8a41d43b4694a8ea41155@buildbot.net> References: <041.8b7585719df8a41d43b4694a8ea41155@buildbot.net> Message-ID: <056.be00663205319fe24a19e88fde9efb9e@buildbot.net> #1955: Suboptimal default for submodules ------------------------+-------------------- Reporter: dabrahams | Owner: Type: enhancement | Status: new Priority: trivial | Milestone: 0.8.5 Version: 0.8.3p1 | Resolution: Keywords: git | ------------------------+-------------------- Changes (by dustin): * type: undecided => enhancement * milestone: undecided => 0.8.5 Comment: Is there any actionable work here? What should the default value be? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 01:50:53 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 01:50:53 -0000 Subject: [Buildbot-commits] [Buildbot] #2020: can't run the debugclient in 0.8.4p1 In-Reply-To: <039.4de1c00b5dfe841fa352fc1b6972a997@buildbot.net> References: <039.4de1c00b5dfe841fa352fc1b6972a997@buildbot.net> Message-ID: <054.4a906d5f2d4138a76ff4f29f9cf41558@buildbot.net> #2020: can't run the debugclient in 0.8.4p1 --------------------+-------------------- Reporter: dberger | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: Keywords: | --------------------+-------------------- Changes (by dustin): * milestone: undecided => 0.8.5 Old description: > Traceback (most recent call last): > File > "/home/rackadmin/buildbot/buildbot/../external/buildbot-0.8.4p1/bin/buildbot", > line 4, in > runner.run() > File > "/home/rackadmin/buildbot/external/buildbot-0.8.4p1/buildbot/scripts/runner.py", > line 1246, in run > debugclient(so) > File > "/home/rackadmin/buildbot/external/buildbot-0.8.4p1/buildbot/scripts/runner.py", > line 742, in debugclient > from buildbot.clients import debug > File > "/home/rackadmin/buildbot/external/buildbot-0.8.4p1/buildbot/clients/debug.py", > line 18, in > gtk2reactor.install() > File > "/home/rackadmin/buildbot/external/Twisted-11.0.0/twisted/internet/gtk2reactor.py", > line 379, in install > installReactor(reactor) > File > "/home/rackadmin/buildbot/external/Twisted-11.0.0/twisted/internet/main.py", > line 30, in installReactor > raise error.ReactorAlreadyInstalledError("reactor already installed") > twisted.internet.error.ReactorAlreadyInstalledError: reactor already > installed > > this is particularly problematic to us as we run our buildmaster on > windows, so we've effectively lost the ability to dynamically reconfigure > it. New description: {{{ Traceback (most recent call last): File "/home/rackadmin/buildbot/buildbot/../external/buildbot-0.8.4p1/bin/buildbot", line 4, in runner.run() File "/home/rackadmin/buildbot/external/buildbot-0.8.4p1/buildbot/scripts/runner.py", line 1246, in run debugclient(so) File "/home/rackadmin/buildbot/external/buildbot-0.8.4p1/buildbot/scripts/runner.py", line 742, in debugclient from buildbot.clients import debug File "/home/rackadmin/buildbot/external/buildbot-0.8.4p1/buildbot/clients/debug.py", line 18, in gtk2reactor.install() File "/home/rackadmin/buildbot/external/Twisted-11.0.0/twisted/internet/gtk2reactor.py", line 379, in install installReactor(reactor) File "/home/rackadmin/buildbot/external/Twisted-11.0.0/twisted/internet/main.py", line 30, in installReactor raise error.ReactorAlreadyInstalledError("reactor already installed") twisted.internet.error.ReactorAlreadyInstalledError: reactor already installed }}} this is particularly problematic to us as we run our buildmaster on windows, so we've effectively lost the ability to dynamically reconfigure it. -- -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 01:52:13 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 01:52:13 -0000 Subject: [Buildbot-commits] [Buildbot] #2020: can't run the debugclient in 0.8.4p1 In-Reply-To: <039.4de1c00b5dfe841fa352fc1b6972a997@buildbot.net> References: <039.4de1c00b5dfe841fa352fc1b6972a997@buildbot.net> Message-ID: <054.5333124703b725ddfd0ee4eeed27d61a@buildbot.net> #2020: can't run the debugclient in 0.8.4p1 --------------------+-------------------- Reporter: dberger | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: Keywords: | --------------------+-------------------- Comment (by dustin): Hm, I didn't realize that debugclient was useful for reconfigs. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 01:59:39 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 01:59:39 -0000 Subject: [Buildbot-commits] [Buildbot] #1814: Make Buildbot more awesome. In-Reply-To: <037.ab1167a7230acbc697f72ef23bfaa5ba@buildbot.net> References: <037.ab1167a7230acbc697f72ef23bfaa5ba@buildbot.net> Message-ID: <052.b1a1f5b2e3192ccab8bb4ff68fbc53e8@buildbot.net> #1814: Make Buildbot more awesome. ------------------------+----------------------- Reporter: ayust | Owner: djmitche Type: enhancement | Status: closed Priority: critical | Milestone: ongoing Version: master | Resolution: fixed Keywords: | ------------------------+----------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: I think 0.8.4 took care of this.. 0.8.4p1 at least. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 02:01:58 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 02:01:58 -0000 Subject: [Buildbot-commits] [Buildbot] #1969: How can I config GerritChangeSource trigger building? In-Reply-To: <037.93871fe205ab7159e963d8beed138b2d@buildbot.net> References: <037.93871fe205ab7159e963d8beed138b2d@buildbot.net> Message-ID: <052.1bdc0af0263c79a6f01f62dd68b5e230@buildbot.net> #1969: How can I config GerritChangeSource trigger building? ----------------------------+---------------------- Reporter: clino | Owner: Type: support-request | Status: new Priority: major | Milestone: ongoing Version: master | Resolution: Keywords: gerrit | ----------------------------+---------------------- Comment (by dustin): Any results? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 02:02:51 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 02:02:51 -0000 Subject: [Buildbot-commits] [Buildbot] #1841: mozilla slaves failing in 'git' In-Reply-To: <038.7e62b7cc167bd5b9e57aef033cdda169@buildbot.net> References: <038.7e62b7cc167bd5b9e57aef033cdda169@buildbot.net> Message-ID: <053.704f5026acf5924eed31e7d9b9676811@buildbot.net> #1841: mozilla slaves failing in 'git' -------------------+---------------------- Reporter: dustin | Owner: Type: defect | Status: closed Priority: major | Milestone: ongoing Version: master | Resolution: fixed Keywords: | -------------------+---------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: This isn't a problem anymore - adding retries has helped. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 02:03:42 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 02:03:42 -0000 Subject: [Buildbot-commits] [Buildbot] #1911: Cannot checkout from default branch trunk when creating a Scheduler that uses SVN repository. Failure by using keyword None as branch In-Reply-To: <039.8112b27cb69f91b9f8b466fb87e8e70a@buildbot.net> References: <039.8112b27cb69f91b9f8b466fb87e8e70a@buildbot.net> Message-ID: <054.61b095bd7b4433f385e9b20131e6cf12@buildbot.net> #1911: Cannot checkout from default branch trunk when creating a Scheduler that uses SVN repository. Failure by using keyword None as branch ----------------------------+---------------------- Reporter: rodrigo | Owner: Type: support-request | Status: closed Priority: critical | Milestone: ongoing Version: 0.7.12 | Resolution: invalid Keywords: svn | ----------------------------+---------------------- Changes (by dustin): * status: new => closed * resolution: => invalid Comment: hm, no response. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 02:08:22 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 02:08:22 -0000 Subject: [Buildbot-commits] [Buildbot] #2020: can't run the debugclient in 0.8.4p1 In-Reply-To: <039.4de1c00b5dfe841fa352fc1b6972a997@buildbot.net> References: <039.4de1c00b5dfe841fa352fc1b6972a997@buildbot.net> Message-ID: <054.b311a79c7cd1d8f6097dfa258a7c543a@buildbot.net> #2020: can't run the debugclient in 0.8.4p1 --------------------+-------------------- Reporter: dberger | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: Keywords: | --------------------+-------------------- Comment (by dustin): Ugh, this is a problem with importing reactor earlier than it needs to be -- *really* hard to test for, since trial imports the reactor itself. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Jun 29 02:11:14 2011 From: noreply at github.com (noreply at github.com) Date: Tue, 28 Jun 2011 19:11:14 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 760bd6: Don't import reactor in runner.py Message-ID: <20110629021114.7CDA0425B7@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 760bd6d2cc21c4c44272ce0b2640f2879aaa9a33 https://github.com/buildbot/buildbot/commit/760bd6d2cc21c4c44272ce0b2640f2879aaa9a33 Author: Dustin J. Mitchell Date: 2011-06-28 (Tue, 28 Jun 2011) Changed paths: M master/buildbot/scripts/runner.py Log Message: ----------- Don't import reactor in runner.py This was introduced by yours truly in #1987. This commit fixes #2020. From nobody at buildbot.net Wed Jun 29 02:11:20 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 02:11:20 -0000 Subject: [Buildbot-commits] [Buildbot] #2020: can't run the debugclient in 0.8.4p1 In-Reply-To: <039.4de1c00b5dfe841fa352fc1b6972a997@buildbot.net> References: <039.4de1c00b5dfe841fa352fc1b6972a997@buildbot.net> Message-ID: <054.f2522639e752ccda6bc70ed5a6a0a247@buildbot.net> #2020: can't run the debugclient in 0.8.4p1 --------------------+--------------------- Reporter: dberger | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: fixed Keywords: | --------------------+--------------------- Changes (by Dustin J. Mitchell): * status: new => closed * resolution: => fixed Comment: Don't import reactor in runner.py This was introduced by yours truly in #1987. This commit fixes #2020. Changeset: 760bd6d2cc21c4c44272ce0b2640f2879aaa9a33 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 05:38:36 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 05:38:36 -0000 Subject: [Buildbot-commits] [Buildbot] #1963: FileUpload creates truncated file when buildslave is not on localhost In-Reply-To: <038.d8aba18af3dd124e6fb92915e876c160@buildbot.net> References: <038.d8aba18af3dd124e6fb92915e876c160@buildbot.net> Message-ID: <053.22f1e2ebcbace7b4f49bfcbefd05c055@buildbot.net> #1963: FileUpload creates truncated file when buildslave is not on localhost ---------------------+-------------------- Reporter: landry | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: transfer | ---------------------+-------------------- Comment (by landry): Yes... interestingly, since i added the debug print of the file size, it works. ie in _writeBlock : {{{ if self.debug: # log.msg('file size is %d' % os.fstat(self.fp.fileno())[ST_SIZE]) log.msg('SlaveFileUploadCommand._writeBlock(): '+ 'allowed=%d readlen=%d' % (length, len(data))) }}} In the log, i'm getting : {{{ 2011-06-29 07:27:48+0200 [-] file size is 14319421 2011-06-29 07:27:48+0200 [-] SlaveFileUploadCommand._writeBlock(): allowed=16384 readlen=16384 2011-06-29 07:27:48+0200 [Broker,client] file size is 14319421 2011-06-29 07:27:48+0200 [Broker,client] SlaveFileUploadCommand._writeBlock(): allowed=16384 readlen=16384 2011-06-29 07:27:48+0200 [Broker,client] file size is 14319421 }}} I've removed the debug printf and will see tomorrow if it failed again... which would be 'interesting'. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 05:42:20 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 05:42:20 -0000 Subject: [Buildbot-commits] [Buildbot] #1963: FileUpload creates truncated file when buildslave is not on localhost In-Reply-To: <038.d8aba18af3dd124e6fb92915e876c160@buildbot.net> References: <038.d8aba18af3dd124e6fb92915e876c160@buildbot.net> Message-ID: <053.40b55dfbd68711938cd502680418059e@buildbot.net> #1963: FileUpload creates truncated file when buildslave is not on localhost ---------------------+-------------------- Reporter: landry | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: transfer | ---------------------+-------------------- Comment (by dustin): May you live in interesting times :) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 09:56:46 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 09:56:46 -0000 Subject: [Buildbot-commits] [Buildbot] #716: Add parent-rev to change and use this in console In-Reply-To: <039.81698b2ccba200d5a6bf1ef015c57e28@buildbot.net> References: <039.81698b2ccba200d5a6bf1ef015c57e28@buildbot.net> Message-ID: <054.c09588e2746535291fa94dc5b99e6b3d@buildbot.net> #716: Add parent-rev to change and use this in console -------------------------+-------------------- Reporter: marcusl | Owner: Type: enhancement | Status: new Priority: major | Milestone: 0.8.+ Version: master | Resolution: Keywords: git hg darcs | -------------------------+-------------------- Changes (by cortana): * cc: sam@? (added) -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Wed Jun 29 13:21:45 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 29 Jun 2011 06:21:45 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 858e22: Fix typos in MailNotifier's support for buildsets Message-ID: <20110629132145.945A9425B4@smtp1.rs.github.com> Branch: refs/heads/buildbot-0.8.4 Home: https://github.com/buildbot/buildbot Commit: 858e226fb54d990a23b54765d49f93fbb2a39d66 https://github.com/buildbot/buildbot/commit/858e226fb54d990a23b54765d49f93fbb2a39d66 Author: Dustin J. Mitchell Date: 2011-06-29 (Wed, 29 Jun 2011) Changed paths: M master/buildbot/status/mail.py M master/buildbot/test/unit/test_status_mail_MailNotifier.py Log Message: ----------- Fix typos in MailNotifier's support for buildsets Fixes #2017. This adds some pretty ugly tests, too, to detect these failures. Commit: 3bb19ec1156e9cdd63aedcb444db0fd4f2e8cb53 https://github.com/buildbot/buildbot/commit/3bb19ec1156e9cdd63aedcb444db0fd4f2e8cb53 Author: Dustin J. Mitchell Date: 2011-06-29 (Wed, 29 Jun 2011) Changed paths: M master/buildbot/scripts/runner.py Log Message: ----------- Don't import reactor in runner.py This was introduced by yours truly in #1987. This commit fixes #2020. Compare: https://github.com/buildbot/buildbot/compare/de9ffe2...3bb19ec From noreply at github.com Wed Jun 29 13:21:45 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 29 Jun 2011 06:21:45 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 7414ee: Handle displaying of non-ASCII properties Message-ID: <20110629132145.EFF45425C7@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 7414ee46f67e6426ae12387da22323333ce6a67a https://github.com/buildbot/buildbot/commit/7414ee46f67e6426ae12387da22323333ce6a67a Author: Aur?lien Bompard Date: 2011-06-29 (Wed, 29 Jun 2011) Changed paths: M master/buildbot/status/web/build.py Log Message: ----------- Handle displaying of non-ASCII properties Commit: 2a993ecfcf0f489e1df4a6937b3b8e9f0ec1367b https://github.com/buildbot/buildbot/commit/2a993ecfcf0f489e1df4a6937b3b8e9f0ec1367b Author: Dustin J. Mitchell Date: 2011-06-29 (Wed, 29 Jun 2011) Changed paths: M master/buildbot/status/web/build.py Log Message: ----------- Merge branch 'master' of git://github.com/abompard/buildbot * 'master' of git://github.com/abompard/buildbot: Handle displaying of non-ASCII properties Commit: 53c8cbe5c4eae72465aba41c730f6d1b553432bd https://github.com/buildbot/buildbot/commit/53c8cbe5c4eae72465aba41c730f6d1b553432bd Author: Dustin J. Mitchell Date: 2011-06-29 (Wed, 29 Jun 2011) Changed paths: M master/NEWS Log Message: ----------- add new source steps to NEWS Commit: 61cc2551bd0c061e82402d47cda22a0b6aa09c0f https://github.com/buildbot/buildbot/commit/61cc2551bd0c061e82402d47cda22a0b6aa09c0f Author: Dustin J. Mitchell Date: 2011-06-29 (Wed, 29 Jun 2011) Changed paths: M master/NEWS M slave/NEWS Log Message: ----------- update NEWS Compare: https://github.com/buildbot/buildbot/compare/760bd6d...61cc255 From nobody at buildbot.net Wed Jun 29 13:22:12 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 13:22:12 -0000 Subject: [Buildbot-commits] [Buildbot] #2017: attaching logs to build mail is broken in 0.8.4p1 In-Reply-To: <039.1ea156c78f375eaf0d545e5150f38270@buildbot.net> References: <039.1ea156c78f375eaf0d545e5150f38270@buildbot.net> Message-ID: <054.1b1b1fb34c6beea9cd0307397dd2d12a@buildbot.net> #2017: attaching logs to build mail is broken in 0.8.4p1 --------------------+--------------------- Reporter: dberger | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: fixed Keywords: | --------------------+--------------------- Comment (by Dustin J. Mitchell): Fix typos in MailNotifier's support for buildsets Fixes #2017. This adds some pretty ugly tests, too, to detect these failures. Changeset: 858e226fb54d990a23b54765d49f93fbb2a39d66 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 13:22:13 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 13:22:13 -0000 Subject: [Buildbot-commits] [Buildbot] #2020: can't run the debugclient in 0.8.4p1 In-Reply-To: <039.4de1c00b5dfe841fa352fc1b6972a997@buildbot.net> References: <039.4de1c00b5dfe841fa352fc1b6972a997@buildbot.net> Message-ID: <054.3655fcfc4f391f9f3cfa0993ec8c445e@buildbot.net> #2020: can't run the debugclient in 0.8.4p1 --------------------+--------------------- Reporter: dberger | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: fixed Keywords: | --------------------+--------------------- Comment (by Dustin J. Mitchell): Don't import reactor in runner.py This was introduced by yours truly in #1987. This commit fixes #2020. Changeset: 3bb19ec1156e9cdd63aedcb444db0fd4f2e8cb53 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 14:46:44 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 14:46:44 -0000 Subject: [Buildbot-commits] [Buildbot] #2021: (more) email breakage in 0.8.4p1 Message-ID: <039.31ff56233f87e846ac56ead92ff55c15@buildbot.net> #2021: (more) email breakage in 0.8.4p1 --------------------+----------------------- Reporter: dberger | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4p1 | Keywords: --------------------+----------------------- 2011-06-29 07:45:22-0700 [-] Exception caught notifying of buildFinished event 2011-06-29 07:45:22-0700 [-] Unhandled Error Traceback (most recent call last): File "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\build.py", line 288, in buildFinished w.callback(self) File "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line 361, in callback self._startRunCallbacks(result) File "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line 455, in _startRunCallbacks self._runCallbacks() File "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line 542, in _runCallbacks current.result = callback(current.result, *args, **kw) --- --- File "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\builder.py", line 541, in _buildFinished w.buildFinished(name, s, results) File "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\mail.py", line 410, in buildFinished return self.buildMessage(name, [build], results) File "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\mail.py", line 593, in buildMessage results, builds, patches, logs) File "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\mail.py", line 545, in createEmail k = builds[0].render(k) exceptions.AttributeError: BuildStatus instance has no attribute 'render' -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 14:49:37 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 14:49:37 -0000 Subject: [Buildbot-commits] [Buildbot] #2021: (more) email breakage in 0.8.4p1 In-Reply-To: <039.31ff56233f87e846ac56ead92ff55c15@buildbot.net> References: <039.31ff56233f87e846ac56ead92ff55c15@buildbot.net> Message-ID: <054.ebd55adc2397300b1cdb837db8ffe601@buildbot.net> #2021: (more) email breakage in 0.8.4p1 --------------------+-------------------- Reporter: dberger | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: Keywords: mail | --------------------+-------------------- Changes (by dustin): * keywords: => mail * milestone: undecided => 0.8.5 Comment: Sigh. This is what comes of modifying un-tested (or, in this case, badly- tested) code. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 14:52:18 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 14:52:18 -0000 Subject: [Buildbot-commits] [Buildbot] #2019: graceful shutdown and triggered builds don't play as expected (0.8.4p1) In-Reply-To: <039.1df5e0ed3d0c636c0cfad3244068609f@buildbot.net> References: <039.1df5e0ed3d0c636c0cfad3244068609f@buildbot.net> Message-ID: <054.09442778d8c176b053a904e2b286454c@buildbot.net> #2019: graceful shutdown and triggered builds don't play as expected (0.8.4p1) --------------------+-------------------- Reporter: dberger | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.4p1 | Resolution: Keywords: | --------------------+-------------------- Comment (by dberger): I agree that the right answer seems to be anyone in before the shutdown button should finish - but the "easier" answer may be to have the trigger recognize that it can't trigger builds and fail. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 14:53:40 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 14:53:40 -0000 Subject: [Buildbot-commits] [Buildbot] #2021: (more) email breakage in 0.8.4p1 In-Reply-To: <039.31ff56233f87e846ac56ead92ff55c15@buildbot.net> References: <039.31ff56233f87e846ac56ead92ff55c15@buildbot.net> Message-ID: <054.78495e08c6bcbd7e9055cbb50a768d8b@buildbot.net> #2021: (more) email breakage in 0.8.4p1 --------------------+-------------------- Reporter: dberger | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: Keywords: mail | --------------------+-------------------- Comment (by dberger): it looks like the author expects that to be a Build object (rather than a BuildStatus) object - but I don't see a way to get from what he's got to what he wants. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 14:57:09 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 14:57:09 -0000 Subject: [Buildbot-commits] [Buildbot] #2019: graceful shutdown and triggered builds don't play as expected (0.8.4p1) In-Reply-To: <039.1df5e0ed3d0c636c0cfad3244068609f@buildbot.net> References: <039.1df5e0ed3d0c636c0cfad3244068609f@buildbot.net> Message-ID: <054.117e82a03618d2528571612beaf85433@buildbot.net> #2019: graceful shutdown and triggered builds don't play as expected (0.8.4p1) --------------------+-------------------- Reporter: dberger | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.4p1 | Resolution: Keywords: | --------------------+-------------------- Comment (by dustin): I could implement that relatively quickly - maybe for 0.8.5, and then try to do the more correct option later. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 16:11:16 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 16:11:16 -0000 Subject: [Buildbot-commits] [Buildbot] #2022: Stale Broker errors not caught on reconfig Message-ID: <038.381285500e2095ef29e1264f09ac6406@buildbot.net> #2022: Stale Broker errors not caught on reconfig -------------------+---------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.2 | Keywords: reconfig -------------------+---------------------- We're seeing reconfigs "wedged", meaning they never complete. As I understand it, here's what's happening: Due to bad luck, a !BuildSlave.slave reference is stale when the reconfig begins. I think that this could be minimized, but not avoided entirely, since the attach/detach process is not quite atomic at this point. Given that we reboot a slave every few seconds, it's not surprising. When this happens, the {{{setBuilderList}}} remote call fails with {{{twisted.spread.pb.DeadReferenceError}}}, which is not handled anywhere. As a result, the {{{setBuilderList}}} call effectively never completes, and the reconfig stalls. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 18:11:23 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 18:11:23 -0000 Subject: [Buildbot-commits] [Buildbot] #1955: Suboptimal default for submodules In-Reply-To: <041.8b7585719df8a41d43b4694a8ea41155@buildbot.net> References: <041.8b7585719df8a41d43b4694a8ea41155@buildbot.net> Message-ID: <056.fc4275b0576c8f59e38eb556a365566d@buildbot.net> #1955: Suboptimal default for submodules ------------------------+-------------------- Reporter: dabrahams | Owner: Type: enhancement | Status: new Priority: trivial | Milestone: 0.8.5 Version: 0.8.3p1 | Resolution: Keywords: git | ------------------------+-------------------- Comment (by dabrahams): Umm... it's a boolean. So you could choose any one from among the vast array of other possible default values ;-) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 18:23:36 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 18:23:36 -0000 Subject: [Buildbot-commits] [Buildbot] #2000: "alwaysUseLatest" doesn't do what it says In-Reply-To: <041.16f29ce554aad5e31a1a961ab126f0d3@buildbot.net> References: <041.16f29ce554aad5e31a1a961ab126f0d3@buildbot.net> Message-ID: <056.8f361900edb25b04556a0d5c1a15d8f8@buildbot.net> #2000: "alwaysUseLatest" doesn't do what it says --------------------------+-------------------- Reporter: dabrahams | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.4p1 | Resolution: Keywords: git, projrepo | --------------------------+-------------------- Comment (by dabrahams): Then please consider this a documentation bug, and also please tell me what projrepo means! -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 18:27:24 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 18:27:24 -0000 Subject: [Buildbot-commits] [Buildbot] #2023: RemoteShellCommand undocumented Message-ID: <041.cd5a8776020f25009f80ace70131fa13@buildbot.net> #2023: RemoteShellCommand undocumented ----------------------+----------------------- Reporter: dabrahams | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4p1 | Keywords: docs ----------------------+----------------------- ...and yet it seems to be essential to writing any build step that runs a shell command on the slave -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 18:35:32 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 18:35:32 -0000 Subject: [Buildbot-commits] [Buildbot] #1963: FileUpload creates truncated file when buildslave is not on localhost In-Reply-To: <038.d8aba18af3dd124e6fb92915e876c160@buildbot.net> References: <038.d8aba18af3dd124e6fb92915e876c160@buildbot.net> Message-ID: <053.e64dc71ef321ab3c17dec94d94180795@buildbot.net> #1963: FileUpload creates truncated file when buildslave is not on localhost ---------------------+-------------------- Reporter: landry | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: Keywords: transfer | ---------------------+-------------------- Comment (by landry): And now it seems i can't reproduce it - will reinstall stock buildslave to be sure i don't have local modifications at all, and report back. I'm definitely puzzled. Of course that's without any 'sleep 10' in the buildsteps.. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 18:59:12 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 18:59:12 -0000 Subject: [Buildbot-commits] [Buildbot] #1955: Suboptimal default for submodules In-Reply-To: <041.8b7585719df8a41d43b4694a8ea41155@buildbot.net> References: <041.8b7585719df8a41d43b4694a8ea41155@buildbot.net> Message-ID: <056.00de98a5bdac2fa498fa49aba4b151dc@buildbot.net> #1955: Suboptimal default for submodules ------------------------+--------------------- Reporter: dabrahams | Owner: Type: enhancement | Status: closed Priority: trivial | Milestone: 0.8.5 Version: 0.8.3p1 | Resolution: fixed Keywords: git | ------------------------+--------------------- Changes (by dustin): * status: new => closed * resolution: => fixed Comment: OK, well, as you state, nothing we can change. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 19:00:08 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 19:00:08 -0000 Subject: [Buildbot-commits] [Buildbot] #2023: RemoteShellCommand undocumented In-Reply-To: <041.cd5a8776020f25009f80ace70131fa13@buildbot.net> References: <041.cd5a8776020f25009f80ace70131fa13@buildbot.net> Message-ID: <056.68b94401114c11c1f28c0c7683f9413d@buildbot.net> #2023: RemoteShellCommand undocumented ----------------------+-------------------- Reporter: dabrahams | Owner: Type: defect | Status: new Priority: major | Milestone: 0.9.+ Version: 0.8.4p1 | Resolution: Keywords: docs | ----------------------+-------------------- Changes (by dustin): * milestone: undecided => 0.9.+ Comment: The things you need to know to write shell steps are not yet documented. That's a long-term goal. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 19:01:59 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 19:01:59 -0000 Subject: [Buildbot-commits] [Buildbot] #1963: FileUpload creates truncated file when buildslave is not on localhost In-Reply-To: <038.d8aba18af3dd124e6fb92915e876c160@buildbot.net> References: <038.d8aba18af3dd124e6fb92915e876c160@buildbot.net> Message-ID: <053.3c473ea25a821f61fd381d545d3b4364@buildbot.net> #1963: FileUpload creates truncated file when buildslave is not on localhost ---------------------+------------------------- Reporter: landry | Owner: Type: defect | Status: closed Priority: major | Milestone: 0.8.+ Version: 0.8.3p1 | Resolution: worksforme Keywords: transfer | ---------------------+------------------------- Changes (by dustin): * status: new => closed * resolution: => worksforme Comment: Re-open if you can reproduce? -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 20:28:34 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 20:28:34 -0000 Subject: [Buildbot-commits] [Buildbot] #2024: Documentation for "WithProperties" is incorrect Message-ID: <043.6d711bed6236155c07ac5a0a82d6f719@buildbot.net> #2024: Documentation for "WithProperties" is incorrect ------------------------+----------------------- Reporter: mitcholiver | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: 0.8.4p1 | Keywords: ------------------------+----------------------- The example for using a callable with WithProperites includes an example function. This function does not work. The current code: def determine_foo(props): if props.has_key('bar'): return props['bar'] elif props.has_key('baz'): return props['baz'] return 'qux' WithProperties('%(foo)s', foo=determine_foo) will fail, as the parameter is of type Build. Use this instead: def determine_foo(build): props = build.getProperties() if props.has_key('bar'): return props['bar'] elif props.has_key('baz'): return props['baz'] return 'qux' WithProperties('%(foo)s', foo=determine_foo) -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 23:20:34 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 23:20:34 -0000 Subject: [Buildbot-commits] [Buildbot] #2025: If global and/or per builder mergeRequests is not set, the default mergeRequests handler expects only two arguments not the provided 3 Message-ID: <040.41ef4e477a988d57c3ea32b1c401d71a@buildbot.net> #2025: If global and/or per builder mergeRequests is not set, the default mergeRequests handler expects only two arguments not the provided 3 ---------------------+------------------- Reporter: bdbaddog | Owner: Type: defect | Status: new Priority: blocker | Milestone: 0.8.5 Version: 0.8.4p1 | Keywords: ---------------------+------------------- If global and/or per builder mergeRequests is not set, the default mergeRequests handler expects only two arguments not the provided 3 Stacktrace here: {{{ 2011-06-29 15:31:51-0700 [-] in maybeStartBuild for Traceback (most recent call last): File "/Users/bdbaddog/devel/buildbot/sandbox/lib/python2.6/site- packages/twisted/internet/defer.py", line 542, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/Users/bdbaddog/devel/buildbot/sandbox/lib/python2.6/site- packages/twisted/internet/defer.py", line 891, in gotResult _deferGenerator(g, deferred) File "/Users/bdbaddog/devel/buildbot/sandbox/lib/python2.6/site- packages/twisted/internet/defer.py", line 866, in _deferGenerator result = g.next() File "/Users/bdbaddog/devel/buildbot/master/buildbot/process/builder.py", line 810, in _mergeRequests defer.maybeDeferred(lambda : --- --- File "/Users/bdbaddog/devel/buildbot/sandbox/lib/python2.6/site- packages/twisted/internet/defer.py", line 133, in maybeDeferred result = f(*args, **kw) File "/Users/bdbaddog/devel/buildbot/master/buildbot/process/builder.py", line 811, in mergeRequests_fn(self, breq_object, other_breq_object))) exceptions.TypeError: unbound method canBeMergedWith() must be called with BuildRequest instance as first argument (got Builder instance instead) }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 23:29:13 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 23:29:13 -0000 Subject: [Buildbot-commits] [Buildbot] #2026: svnpoller logs with "svnPoller:" and "SVNPoller": Message-ID: <040.80d5c6e154638482104559595213374a@buildbot.net> #2026: svnpoller logs with "svnPoller:" and "SVNPoller": ----------------------+----------------------- Reporter: bdbaddog | Owner: Type: undecided | Status: new Priority: trivial | Milestone: undecided Version: 0.8.4p1 | Keywords: svn ----------------------+----------------------- Minor nit but the logs look like: {{{ 2011-06-29 16:26:55-0700 [-] svnPoller: no changes 2011-06-29 16:26:55-0700 [-] svnPoller: _process_changes 110 .. 110 2011-06-29 16:26:55-0700 [-] SVNPoller finished polling None 2011-06-29 16:26:56-0700 [-] SVNPoller polling 2011-06-29 16:26:56-0700 [-] SVNPoller: svnurl=file:///Users/bdbaddog/devel/buildbot/sandbox/test/svn, root=file:///Users/bdbaddog/devel/buildbot/sandbox/test/svn, so prefix= }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Wed Jun 29 23:44:52 2011 From: nobody at buildbot.net (Buildbot) Date: Wed, 29 Jun 2011 23:44:52 -0000 Subject: [Buildbot-commits] [Buildbot] #2026: svnpoller logs with "svnPoller:" and "SVNPoller": In-Reply-To: <040.80d5c6e154638482104559595213374a@buildbot.net> References: <040.80d5c6e154638482104559595213374a@buildbot.net> Message-ID: <055.5b0b4ca4b4220df3c7605040a78599d5@buildbot.net> #2026: svnpoller logs with "svnPoller:" and "SVNPoller": ----------------------+------------------------ Reporter: bdbaddog | Owner: Type: undecided | Status: new Priority: trivial | Milestone: undecided Version: 0.8.4p1 | Resolution: Keywords: svn | ----------------------+------------------------ Comment (by bdbaddog): Fix in pull request: https://github.com/buildbot/buildbot/pull/171 -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Jun 30 00:13:07 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 30 Jun 2011 00:13:07 -0000 Subject: [Buildbot-commits] [Buildbot] #2027: Unhandled error in Deferred (0.8.4p1) Message-ID: <039.0fb62fd6e28281a78e5682a6e439200f@buildbot.net> #2027: Unhandled error in Deferred (0.8.4p1) --------------------+----------------------- Reporter: dberger | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4p1 | Keywords: --------------------+----------------------- I see this frequently in the buildmaster logs, though I haven't yet been able to correlate it with user-visible event(s) 2011-06-29 17:08:03-0700 [-] Unhandled error in Deferred: 2011-06-29 17:08:03-0700 [-] Unhandled Error Traceback (most recent call last): File "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line 542, in _runCallbacks current.result = callback(current.result, *args, **kw) File "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line 791, in _cbDeferred self.callback(self.resultList) File "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line 361, in callback self._startRunCallbacks(result) File "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line 455, in _startRunCallbacks self._runCallbacks() --- --- File "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line 542, in _runCallbacks current.result = callback(current.result, *args, **kw) File "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\web\base.py", line 319, in ok request.finish() File "E:\build_master\external\Twisted-11.0.0\twisted\web\http.py", line 866, in finish "Request.finish called on a request after its connection was lost; " exceptions.RuntimeError: Request.finish called on a request after its connection was lost; use Request.notifyFinish to keep track of this. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Jun 30 00:27:28 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 30 Jun 2011 00:27:28 -0000 Subject: [Buildbot-commits] [Buildbot] #2028: startBuild failing with assertion, causes builder to never fire. Message-ID: <040.1ac5c37d32929b0ca70f04cc5594a03f@buildbot.net> #2028: startBuild failing with assertion, causes builder to never fire. ---------------------+----------------------- Reporter: bdbaddog | Owner: Type: defect | Status: new Priority: major | Milestone: undecided Version: 0.8.4p1 | Keywords: ---------------------+----------------------- Here's the stack trace. djmitche sugguests that it's likely the right thing to remove the assertion in question as this might be caused by firing off a large number of the same builder in a row. {{{ 2011-06-28 14:48:24-0700 [-] .startBuild 2011-06-28 14:48:24-0700 [-] Unhandled error in Deferred: 2011-06-28 14:48:24-0700 [-] Unhandled Error Traceback (most recent call last): File "/export/buildbot/bb_06_23_2011/lib/python2.5/site- packages/twisted/internet/defer.py", line 361, in callback self._startRunCallbacks(result) File "/export/buildbot/bb_06_23_2011/lib/python2.5/site- packages/twisted/internet/defer.py", line 455, in _startRunCallbacks self._runCallbacks() File "/export/buildbot/bb_06_23_2011/lib/python2.5/site- packages/twisted/internet/defer.py", line 542, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/export/buildbot/bb_06_23_2011/lib/python2.5/site- packages/twisted/internet/defer.py", line 891, in gotResult _deferGenerator(g, deferred) --- --- File "/export/buildbot/bb_06_23_2011/lib/python2.5/site- packages/twisted/internet/defer.py", line 866, in _deferGenerator result = g.next() File "/export/buildbot/bb_06_23_2011/lib/python2.5/site-packages /buildbot-latest-py2.5.egg/buildbot/process/builder.py", line 514, in _startBuildFor d = build.startBuild(bs, self.expectations, slavebuilder) File "/export/buildbot/bb_06_23_2011/lib/python2.5/site-packages /buildbot-latest-py2.5.egg/buildbot/process/build.py", line 268, in startBuild self.build_status.buildStarted(self) File "/export/buildbot/bb_06_23_2011/lib/python2.5/site-packages /buildbot-latest-py2.5.egg/buildbot/status/build.py", line 265, in buildStarted self.builder.buildStarted(self) File "/export/buildbot/bb_06_23_2011/lib/python2.5/site-packages /buildbot-latest-py2.5.egg/buildbot/status/builder.py", line 507, in buildStarted assert s.number == self.nextBuildNumber - 1 exceptions.AssertionError: }}} -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Jun 30 04:34:53 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 30 Jun 2011 04:34:53 -0000 Subject: [Buildbot-commits] [Buildbot] #2029: inconsistent state for a builder Message-ID: <038.0ec0eedaf7f7533481c7654bf20f43b9@buildbot.net> #2029: inconsistent state for a builder --------------------+------------------- Reporter: dustin | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.5 Version: 0.8.4p1 | Keywords: --------------------+------------------- The metabuildbot currently has py27-tw0280 completely idle, but with six slaves available. The builder display (http://buildbot.buildbot.net/builders/py27-tw0820) correctly reflects this, but the builders page (http://buildbot.buildbot.net/builders) lists it as still building. Time to don my hard hat. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Jun 30 04:56:46 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 30 Jun 2011 04:56:46 -0000 Subject: [Buildbot-commits] [Buildbot] #2000: "alwaysUseLatest" doesn't do what it says In-Reply-To: <041.16f29ce554aad5e31a1a961ab126f0d3@buildbot.net> References: <041.16f29ce554aad5e31a1a961ab126f0d3@buildbot.net> Message-ID: <056.8fab8a2f257d7ac3b81f5c617a1acfa9@buildbot.net> #2000: "alwaysUseLatest" doesn't do what it says --------------------------+-------------------- Reporter: dabrahams | Owner: Type: defect | Status: new Priority: major | Milestone: 0.8.+ Version: 0.8.4p1 | Resolution: Keywords: git, projrepo | --------------------------+-------------------- Comment (by dustin): 'projrepo' is the tag for project and repository support - basically support for multiple projects in the same buildmaster instance. It works well for completely unrelated projects, but things don't work when you try to inter-mingle them, for example trying to build from three git repositories in the same build set. I'm not sure where this would fit in the docs, but it is a [wiki:FAQ] entry (in fact, the first). If that's not clear or forceful enough (reading it now, it doesn't sound very forceful), please edit it? -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Jun 30 05:00:09 2011 From: noreply at github.com (noreply at github.com) Date: Wed, 29 Jun 2011 22:00:09 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 66e1b8: bug_2026 fixes Message-ID: <20110630050009.5F9B1425A9@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 66e1b81e4698711ddae27e679fd0168622c5db73 https://github.com/buildbot/buildbot/commit/66e1b81e4698711ddae27e679fd0168622c5db73 Author: William Deegan Date: 2011-06-29 (Wed, 29 Jun 2011) Changed paths: M master/NEWS M master/buildbot/changes/svnpoller.py Log Message: ----------- bug_2026 fixes Commit: 501a7a7ce6bc507b2e8ffe3e67600cf13e080e4d https://github.com/buildbot/buildbot/commit/501a7a7ce6bc507b2e8ffe3e67600cf13e080e4d Author: Dustin J. Mitchell Date: 2011-06-29 (Wed, 29 Jun 2011) Changed paths: M master/NEWS M master/buildbot/changes/svnpoller.py Log Message: ----------- Merge branch 'bug_2026' of git://github.com/bdbaddog/buildbot * 'bug_2026' of git://github.com/bdbaddog/buildbot: bug_2026 fixes Compare: https://github.com/buildbot/buildbot/compare/61cc255...501a7a7 From nobody at buildbot.net Thu Jun 30 05:04:55 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 30 Jun 2011 05:04:55 -0000 Subject: [Buildbot-commits] [Buildbot] #2027: Unhandled error in Deferred (0.8.4p1) In-Reply-To: <039.0fb62fd6e28281a78e5682a6e439200f@buildbot.net> References: <039.0fb62fd6e28281a78e5682a6e439200f@buildbot.net> Message-ID: <054.66b426ea16908fffaf047851f86b651c@buildbot.net> #2027: Unhandled error in Deferred (0.8.4p1) --------------------+-------------------- Reporter: dberger | Owner: Type: defect | Status: new Priority: trivial | Milestone: 0.8.5 Version: 0.8.4p1 | Resolution: Keywords: web | --------------------+-------------------- Changes (by dustin): * keywords: => web * priority: major => trivial * milestone: undecided => 0.8.5 Old description: > I see this frequently in the buildmaster logs, though I haven't yet been > able to correlate it with user-visible event(s) > > 2011-06-29 17:08:03-0700 [-] Unhandled error in Deferred: > 2011-06-29 17:08:03-0700 [-] Unhandled Error > Traceback (most recent call last): > File > "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line > 542, in _runCallbacks > current.result = callback(current.result, *args, **kw) > File > "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line > 791, in _cbDeferred > self.callback(self.resultList) > File > "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line > 361, in callback > self._startRunCallbacks(result) > File > "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line > 455, in _startRunCallbacks > self._runCallbacks() > --- --- > File > "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line > 542, in _runCallbacks > current.result = callback(current.result, *args, **kw) > File > "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\web\base.py", > line 319, in ok > request.finish() > File > "E:\build_master\external\Twisted-11.0.0\twisted\web\http.py", line 866, > in finish > "Request.finish called on a request after its connection was > lost; " > exceptions.RuntimeError: Request.finish called on a request after > its connection was lost; use Request.notifyFinish to keep track of this. New description: I see this frequently in the buildmaster logs, though I haven't yet been able to correlate it with user-visible event(s) {{{ 2011-06-29 17:08:03-0700 [-] Unhandled error in Deferred: 2011-06-29 17:08:03-0700 [-] Unhandled Error Traceback (most recent call last): File "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line 542, in _runCallbacks current.result = callback(current.result, *args, **kw) File "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line 791, in _cbDeferred self.callback(self.resultList) File "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line 361, in callback self._startRunCallbacks(result) File "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line 455, in _startRunCallbacks self._runCallbacks() --- --- File "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line 542, in _runCallbacks current.result = callback(current.result, *args, **kw) File "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\web\base.py", line 319, in ok request.finish() File "E:\build_master\external\Twisted-11.0.0\twisted\web\http.py", line 866, in finish "Request.finish called on a request after its connection was lost; " exceptions.RuntimeError: Request.finish called on a request after its connection was lost; use Request.notifyFinish to keep track of this. }}} -- Comment: This is common, and harmless. Basically what's happening is that the browser is severing the connection before Buildbot has finished producing data. You can reproduce it by clicking a button (e.g., force build) repeatedly. I'm not sure what the best way is to avoid the traceback. -- Ticket URL: Buildbot Buildbot: build/test automation From noreply at github.com Thu Jun 30 13:35:39 2011 From: noreply at github.com (noreply at github.com) Date: Thu, 30 Jun 2011 06:35:39 -0700 Subject: [Buildbot-commits] [buildbot/buildbot] 58c4d5: Fix *_PREFIXCMD usage in init scripts (Debian bug ... Message-ID: <20110630133539.B542D424BA@smtp1.rs.github.com> Branch: refs/heads/master Home: https://github.com/buildbot/buildbot Commit: 58c4d5758453aa049509cde9d6b257146375e4cd https://github.com/buildbot/buildbot/commit/58c4d5758453aa049509cde9d6b257146375e4cd Author: Andriy Senkovych Date: 2011-06-30 (Thu, 30 Jun 2011) Changed paths: M master/contrib/init-scripts/buildmaster.init.sh M slave/contrib/init-scripts/buildslave.init.sh Log Message: ----------- Fix *_PREFIXCMD usage in init scripts (Debian bug #627918). Originally reported and patched by Andreas Beckmann. See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=627918 Commit: 200db5021490c11aaebbd30f8ca66f12fdebaa9f https://github.com/buildbot/buildbot/commit/200db5021490c11aaebbd30f8ca66f12fdebaa9f Author: Dustin J. Mitchell Date: 2011-06-30 (Thu, 30 Jun 2011) Changed paths: M master/contrib/init-scripts/buildmaster.init.sh M slave/contrib/init-scripts/buildslave.init.sh Log Message: ----------- Merge branch 'deb-bug-627918' of git://github.com/jollyroger/buildbot * 'deb-bug-627918' of git://github.com/jollyroger/buildbot: Fix *_PREFIXCMD usage in init scripts (Debian bug #627918). Compare: https://github.com/buildbot/buildbot/compare/501a7a7...200db50 From nobody at buildbot.net Thu Jun 30 15:35:21 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 30 Jun 2011 15:35:21 -0000 Subject: [Buildbot-commits] [Buildbot] #2030: Build Properties should clarify the order in which properties are applied Message-ID: <043.4427ee79b6c1c80d601f3f04a748ddc8@buildbot.net> #2030: Build Properties should clarify the order in which properties are applied ------------------------+----------------------- Reporter: mitcholiver | Owner: Type: enhancement | Status: new Priority: trivial | Milestone: undecided Version: 0.8.4p1 | Keywords: ------------------------+----------------------- Build properties are applied with a certain precedence, which is not explicitly stated. The precedence corresponds to the order (lowest to highest) in which the locations of their setting is documented here: http://buildbot.net/buildbot/docs/latest/full.html#Build-Properties The documentation should be clarified to note this precedence. -- Ticket URL: Buildbot Buildbot: build/test automation From nobody at buildbot.net Thu Jun 30 22:40:16 2011 From: nobody at buildbot.net (Buildbot) Date: Thu, 30 Jun 2011 22:40:16 -0000 Subject: [Buildbot-commits] [Buildbot] #2031: buildbot try --with-properties truncates property vals with '=' Message-ID: <040.737e859dcecd94c0148ae10f7a14cf8c@buildbot.net> #2031: buildbot try --with-properties truncates property vals with '=' ---------------------+-------------------------- Reporter: rmorison | Owner: Type: defect | Status: new Priority: minor | Milestone: undecided Version: 0.8.4p1 | Keywords: try property ---------------------+-------------------------- E.g. --with-properties=FLAGS=V=1 passes 'FLAGS':'V', instead of 'FLAGS':'V=1' Simple patch fixes this: {{{ --- scripts/runner.py 2011-06-30 15:20:42.690032071 -0700 +++ scripts/runner-fix.py 2011-06-30 15:16:33.970031595 -0700 @@ -1042,7 +1042,7 @@ propertylist = option.split(",") for i in range(0,len(propertylist)): print propertylist[i] - splitproperty = propertylist[i].split("=") + splitproperty = propertylist[i].split("=", 1) properties[splitproperty[0]] = splitproperty[1] self['properties'] = properties }}} -- Ticket URL: Buildbot Buildbot: build/test automation