[Buildbot-commits] [Buildbot] #1684: Buildbot doesn't detect a broken configuration file

Buildbot nobody at buildbot.net
Sat Jul 30 23:30:52 UTC 2011


#1684: Buildbot doesn't detect a broken configuration file
------------------------+--------------------
Reporter:  kostja       |       Owner:
    Type:  enhancement  |      Status:  new
Priority:  major        |   Milestone:  0.8.+
 Version:  0.8.2        |  Resolution:
Keywords:  simple       |
------------------------+--------------------
Changes (by dustin):

 * cc: bill@… (added)


Comment:

 So this would be fixed in master/buildbot/master.py, in the loadConfig
 method.

 The straightforward way to do this would be to look for any !WebStatus
 instances in {{{status}}}, and check that their ports do not overlap (a
 Python set might be useful for the check).

 The more flexible way to do this might be to add a {{{checkConfig}}}
 method to {{{IStatusReceiver}}}, and pass it the entire list of other
 status receivers.  Then the !WebStatus {{{checkConfig}}} method could scan
 the list for other {{{WebStatus}}} instances with the same port.

 The latter solution would be good for change sources, too - we have a lot
 of bugs where multiple !GitPoller instances are using the same repository
 directory, presenting almost exactly the same problem -- just a different
 parameter name!

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1684#comment:5>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation


More information about the Commits mailing list