[Buildbot-commits] [Buildbot] #1725: GerritStatusPush: add filters on builderName, project, branch

[Buildbot]

#1725: GerritStatusPush: add filters on builderName, project, branch
------------------------+--------------------------
Reporter:  PiotrSikora  |       Owner:  PiotrSikora
    Type:  enhancement  |      Status:  new
Priority:  major        |   Milestone:  0.8.5
 Version:  0.8.2        |  Resolution:
Keywords:  gerrit       |
------------------------+--------------------------

Comment (by deignacio):

 I could see this being useful for all StatusReceiver subclasses.
 i don't think you could use a ChangeFilter, because that has a bunch of
 code that is specific to changes, where as this is filtering
 BuildStatuses.
 in buildbot.status.builder whenever you do something like
 for w in self.watchers:
     try:
         if not w.filter(name, s, ...):
             continue
         w.someStep(name, s, ...)
     except:
         ....

 i think this would be super useful as you can have a configuration where
 not all builds are triggered by gerrit.  (think gerrit change source and
 github change notifications).

 how's your progress on this?  i could probably put in some work into this
 if you wanted.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1725#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation