[Buildbot-commits] [Buildbot] #2053: Too much code in try block

Buildbot nobody at buildbot.net
Fri Jul 15 18:54:28 UTC 2011


#2053: Too much code in try block
----------------------+-----------------------
Reporter:  dabrahams  |      Owner:
    Type:  defect     |     Status:  new
Priority:  major      |  Milestone:  undecided
 Version:  0.8.4p1    |   Keywords:
----------------------+-----------------------
 [https://github.com/buildbot/buildbot/blob/26bdbcec654a1f3517fedd9a78512221ebaca04d/master/buildbot/master.py#L328
 in master.py], you are checking for KeyError and reporting something
 specific but there's a huge block of code in the try block.  I'm sure
 you're going to mask/misreport other issues

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2053>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation


More information about the Commits mailing list