[Buildbot-commits] [Buildbot] #1052: blamelist lost via trigger

[Buildbot]

#1052: blamelist lost via trigger
--------------------+-----------------------
Reporter:  qzhwang  |       Owner:
    Type:  defect   |      Status:  reopened
Priority:  major    |   Milestone:  0.8.2
 Version:  0.8.1    |  Resolution:
Keywords:           |
--------------------+-----------------------

Comment (by dberger):

 I believe this got regressed by
 https://github.com/buildbot/buildbot/commit/247e60aadbb53f508fa53c21f798bf80757e7fb1
 - updateSourceStamp is always being set to true, 'cause of this boolean
 logic:

 self.updateSourceStamp = updateSourceStamp or not (alwaysUseLatest or
 sourceStamp)

 so if I give it updateSourceStamp = False, alwaysUseLatest = False,
 sourceStamp = None

 False or not ( False or None ) = False or not ( False ) = False or True =
 True

 exactly the opposite of the intended/desired behavior.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1052#comment:7>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation