From noreply at github.com  Fri Jul  1 00:01:26 2011
From: noreply at github.com (noreply at github.com)
Date: Thu, 30 Jun 2011 17:01:26 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 231000: fix typo: _waiters
	vs waiters
Message-ID: <20110701000126.CA53D426E3@smtp1.rs.github.com>

  Branch: refs/heads/buildbot-0.8.4
  Home:   https://github.com/buildbot/buildbot

  Commit: 2310000ab98cda758b22d2b779f4e1f569da1f07
      https://github.com/buildbot/buildbot/commit/2310000ab98cda758b22d2b779f4e1f569da1f07
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-06-30 (Thu, 30 Jun 2011)

  Changed paths:
    M master/buildbot/schedulers/triggerable.py

  Log Message:
  -----------
  fix typo: _waiters vs waiters





From noreply at github.com  Fri Jul  1 00:01:27 2011
From: noreply at github.com (noreply at github.com)
Date: Thu, 30 Jun 2011 17:01:27 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] a34f22: fix typo: _waiters
	vs waiters
Message-ID: <20110701000127.1B6BD426E4@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: a34f223f98bf11e39b01508566276d3df622def3
      https://github.com/buildbot/buildbot/commit/a34f223f98bf11e39b01508566276d3df622def3
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-06-30 (Thu, 30 Jun 2011)

  Changed paths:
    M master/buildbot/schedulers/triggerable.py

  Log Message:
  -----------
  fix typo: _waiters vs waiters





From nobody at buildbot.net  Fri Jul  1 00:07:42 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 01 Jul 2011 00:07:42 -0000
Subject: [Buildbot-commits] [Buildbot] #2032: Log tracebacks in seperate
 logfile (not in twistd.log)
Message-ID: <040.44f394313b3e8aab92ed7143cac39f9c@buildbot.net>

#2032: Log tracebacks in seperate logfile (not in twistd.log)
------------------------+-----------------------
Reporter:  bdbaddog     |      Owner:
    Type:  enhancement  |     Status:  new
Priority:  minor        |  Milestone:  undecided
 Version:  0.8.4p1      |   Keywords:
------------------------+-----------------------
 It would be useful to log tracebacks in a separate file.
 Rather than having to grep for them from the twistd.log's

 So perhaps: traceback.log or exceptions.log

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2032>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Jul  1 13:41:11 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 01 Jul 2011 13:41:11 -0000
Subject: [Buildbot-commits] [Buildbot] #2033: MergeRequest_fn brocken in
	1.8.4 branch
Message-ID: <038.1efe5a8c7c234cd71d3bdf525603714b@buildbot.net>

#2033: MergeRequest_fn brocken in 1.8.4 branch
----------------------+-----------------------
Reporter:  tardyp     |      Owner:
    Type:  undecided  |     Status:  new
Priority:  major      |  Milestone:  undecided
 Version:  0.8.4p1    |   Keywords:
----------------------+-----------------------
 I got this trace since I rebased yesterday to the latest version of 1.8.4

 I dont have c['MergeRequest'] in my config...


 2011-07-01 15:29:47+0200 [-] in maybeStartBuild for <Builder ''acs-
 mfld_cdk'' at 155602732>
         Traceback (most recent call last):
           File "/usr/local/lib/python2.6/dist-
 packages/Twisted-11.0.0-py2.6-linux-i686.egg/twisted/internet/defer.py",
 line 542, in _runCallbacks
             current.result = callback(current.result, *args, **kw)
           File "/usr/local/lib/python2.6/dist-
 packages/Twisted-11.0.0-py2.6-linux-i686.egg/twisted/internet/defer.py",
 line 891, in gotResult
             _deferGenerator(g, deferred)
           File "/usr/local/lib/python2.6/dist-
 packages/Twisted-11.0.0-py2.6-linux-i686.egg/twisted/internet/defer.py",
 line 866, in _deferGenerator
             result = g.next()
           File "/buildbot/buildbot/master/buildbot/process/builder.py",
 line 810, in _mergeRequests
             defer.maybeDeferred(lambda :
         --- <exception caught here> ---
           File "/usr/local/lib/python2.6/dist-
 packages/Twisted-11.0.0-py2.6-linux-i686.egg/twisted/internet/defer.py",
 line 133, in maybeDeferred
             result = f(*args, **kw)
           File "/buildbot/buildbot/master/buildbot/process/builder.py",
 line 811, in <lambda>
             mergeRequests_fn(self, breq_object, other_breq_object)))
         exceptions.TypeError: unbound method canBeMergedWith() must be
 called with BuildRequest instance as first argument (got Builder instance
 instead)

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2033>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Jul  1 13:44:10 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 01 Jul 2011 13:44:10 -0000
Subject: [Buildbot-commits] [Buildbot] #2033: MergeRequest_fn brocken in
	1.8.4 branch
In-Reply-To: <038.1efe5a8c7c234cd71d3bdf525603714b@buildbot.net>
References: <038.1efe5a8c7c234cd71d3bdf525603714b@buildbot.net>
Message-ID: <053.b9bd4bbd3a447849c42c4e0787f080e1@buildbot.net>

#2033: MergeRequest_fn brocken in 1.8.4 branch
----------------------+------------------------
Reporter:  tardyp     |       Owner:
    Type:  undecided  |      Status:  new
Priority:  major      |   Milestone:  undecided
 Version:  0.8.4p1    |  Resolution:
Keywords:             |
----------------------+------------------------

Comment (by tardyp):

 Note that adding following to config file fixes the issue.:


 c['mergeRequests'] = myMergeRequests

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2033#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Jul  1 14:16:14 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 01 Jul 2011 14:16:14 -0000
Subject: [Buildbot-commits] [Buildbot] #2033: MergeRequest_fn broken in
 0.8.4 branch (was: MergeRequest_fn brocken in 1.8.4 branch)
In-Reply-To: <038.1efe5a8c7c234cd71d3bdf525603714b@buildbot.net>
References: <038.1efe5a8c7c234cd71d3bdf525603714b@buildbot.net>
Message-ID: <053.718c3b7b527ce180e14ba9796bf682d4@buildbot.net>

#2033: MergeRequest_fn broken in 0.8.4 branch
--------------------+------------------------
Reporter:  tardyp   |       Owner:
    Type:  defect   |      Status:  closed
Priority:  major    |   Milestone:  0.8.5
 Version:  0.8.4p1  |  Resolution:  duplicate
Keywords:           |
--------------------+------------------------
Changes (by dustin):

 * status:  new => closed
 * resolution:   => duplicate
 * milestone:  undecided => 0.8.5
 * type:  undecided => defect


Old description:

> I got this trace since I rebased yesterday to the latest version of 1.8.4
>
> I dont have c['MergeRequest'] in my config...
>

> 2011-07-01 15:29:47+0200 [-] in maybeStartBuild for <Builder ''acs-
> mfld_cdk'' at 155602732>
>         Traceback (most recent call last):
>           File "/usr/local/lib/python2.6/dist-
> packages/Twisted-11.0.0-py2.6-linux-i686.egg/twisted/internet/defer.py",
> line 542, in _runCallbacks
>             current.result = callback(current.result, *args, **kw)
>           File "/usr/local/lib/python2.6/dist-
> packages/Twisted-11.0.0-py2.6-linux-i686.egg/twisted/internet/defer.py",
> line 891, in gotResult
>             _deferGenerator(g, deferred)
>           File "/usr/local/lib/python2.6/dist-
> packages/Twisted-11.0.0-py2.6-linux-i686.egg/twisted/internet/defer.py",
> line 866, in _deferGenerator
>             result = g.next()
>           File "/buildbot/buildbot/master/buildbot/process/builder.py",
> line 810, in _mergeRequests
>             defer.maybeDeferred(lambda :
>         --- <exception caught here> ---
>           File "/usr/local/lib/python2.6/dist-
> packages/Twisted-11.0.0-py2.6-linux-i686.egg/twisted/internet/defer.py",
> line 133, in maybeDeferred
>             result = f(*args, **kw)
>           File "/buildbot/buildbot/master/buildbot/process/builder.py",
> line 811, in <lambda>
>             mergeRequests_fn(self, breq_object, other_breq_object)))
>         exceptions.TypeError: unbound method canBeMergedWith() must be
> called with BuildRequest instance as first argument (got Builder instance
> instead)

New description:

 I got this trace since I rebased yesterday to the latest version of 0.8.4

 I dont have c['MergeRequest'] in my config...

 {{{
 2011-07-01 15:29:47+0200 [-] in maybeStartBuild for <Builder ''acs-
 mfld_cdk'' at 155602732>
         Traceback (most recent call last):
           File "/usr/local/lib/python2.6/dist-
 packages/Twisted-11.0.0-py2.6-linux-i686.egg/twisted/internet/defer.py",
 line 542, in _runCallbacks
             current.result = callback(current.result, *args, **kw)
           File "/usr/local/lib/python2.6/dist-
 packages/Twisted-11.0.0-py2.6-linux-i686.egg/twisted/internet/defer.py",
 line 891, in gotResult
             _deferGenerator(g, deferred)
           File "/usr/local/lib/python2.6/dist-
 packages/Twisted-11.0.0-py2.6-linux-i686.egg/twisted/internet/defer.py",
 line 866, in _deferGenerator
             result = g.next()
           File "/buildbot/buildbot/master/buildbot/process/builder.py",
 line 810, in _mergeRequests
             defer.maybeDeferred(lambda :
         --- <exception caught here> ---
           File "/usr/local/lib/python2.6/dist-
 packages/Twisted-11.0.0-py2.6-linux-i686.egg/twisted/internet/defer.py",
 line 133, in maybeDeferred
             result = f(*args, **kw)
           File "/buildbot/buildbot/master/buildbot/process/builder.py",
 line 811, in <lambda>
             mergeRequests_fn(self, breq_object, other_breq_object)))
         exceptions.TypeError: unbound method canBeMergedWith() must be
 called with BuildRequest instance as first argument (got Builder instance
 instead)
 }}}

--

Comment:

 I think this is the same as #2025 - at any rate, it has the same fix.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2033#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Jul  1 18:16:12 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 01 Jul 2011 18:16:12 -0000
Subject: [Buildbot-commits] [Buildbot] #2028: startBuild failing with
 assertion, causes builder to never fire.
In-Reply-To: <040.1ac5c37d32929b0ca70f04cc5594a03f@buildbot.net>
References: <040.1ac5c37d32929b0ca70f04cc5594a03f@buildbot.net>
Message-ID: <055.9c1b3e04a264195ca2a913844e0a0710@buildbot.net>

#2028: startBuild failing with assertion, causes builder to never fire.
---------------------+------------------------
Reporter:  bdbaddog  |       Owner:
    Type:  defect    |      Status:  new
Priority:  major     |   Milestone:  undecided
 Version:  0.8.4p1   |  Resolution:
Keywords:            |
---------------------+------------------------

Comment (by bdbaddog):

 Another stacktrace with info on s.number vs self.nextBuildNumber

 {{{
 2011-07-01 07:54:35-0700 [-] DEEGAN: s.number:768 s.nextBuildNumber:769
 ...
 2011-07-01 07:54:37-0700 [-] DEEGAN: s.number:769 s.nextBuildNumber:770
 ...
 2011-07-01 07:54:39-0700 [-] <Build verify_trunk>.startBuild
 2011-07-01 07:54:39-0700 [-] DEEGAN: s.number:770 s.nextBuildNumber:772
 2011-07-01 07:54:39-0700 [-] Unhandled error in Deferred:
 2011-07-01 07:54:39-0700 [-] Unhandled Error
     Traceback (most recent call last):
       File "/export/buildbot/bb_06_23_2011/lib/python2.5/site-
 packages/twisted/internet/defer.py", line 361, in callback
         self._startRunCallbacks(result)
       File "/export/buildbot/bb_06_23_2011/lib/python2.5/site-
 packages/twisted/internet/defer.py", line 455, in _startRunCallbacks
         self._runCallbacks()
       File "/export/buildbot/bb_06_23_2011/lib/python2.5/site-
 packages/twisted/internet/defer.py", line 542, in _runCallbacks
         current.result = callback(current.result, *args, **kw)
       File "/export/buildbot/bb_06_23_2011/lib/python2.5/site-
 packages/twisted/internet/defer.py", line 891, in gotResult
         _deferGenerator(g, deferred)
     --- <exception caught here> ---
       File "/export/buildbot/bb_06_23_2011/lib/python2.5/site-
 packages/twisted/internet/defer.py", line 866, in _deferGenerator
         result = g.next()
       File "/export/buildbot/bb_06_23_2011/lib/python2.5/site-packages
 /buildbot-latest-py2.5.egg/buildbot/process/builder.py", line 514, in
 _startBuildFor
         d = build.startBuild(bs, self.expectations, slavebuilder)
       File "/export/buildbot/bb_06_23_2011/lib/python2.5/site-packages
 /buildbot-latest-py2.5.egg/buildbot/process/build.py", line 268, in
 startBuild
         self.build_status.buildStarted(self)
       File "/export/buildbot/bb_06_23_2011/lib/python2.5/site-packages
 /buildbot-latest-py2.5.egg/buildbot/status/build.py", line 265, in
 buildStarted
         self.builder.buildStarted(self)
       File "/export/buildbot/bb_06_23_2011/lib/python2.5/site-packages
 /buildbot-latest-py2.5.egg/buildbot/status/builder.py", line 508, in
 buildStarted
         assert s.number == self.nextBuildNumber - 1
     exceptions.AssertionError:

 2011-07-01 07:54:40-0700 [-] <Build verify_trunk>.startBuild
 2011-07-01 07:54:40-0700 [-] DEEGAN: s.number:771 s.nextBuildNumber:772
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2028#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Jul  1 18:31:41 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 01 Jul 2011 18:31:41 -0000
Subject: [Buildbot-commits] [Buildbot] #2028: startBuild failing with
 assertion, causes builder to never fire.
In-Reply-To: <040.1ac5c37d32929b0ca70f04cc5594a03f@buildbot.net>
References: <040.1ac5c37d32929b0ca70f04cc5594a03f@buildbot.net>
Message-ID: <055.a1456b2797bb9c1e14df6f8ec2396124@buildbot.net>

#2028: startBuild failing with assertion, causes builder to never fire.
---------------------+------------------------
Reporter:  bdbaddog  |       Owner:
    Type:  defect    |      Status:  new
Priority:  major     |   Milestone:  undecided
 Version:  0.8.4p1   |  Resolution:
Keywords:            |
---------------------+------------------------

Comment (by dustin):

 That confirms what I thought - this assertion assumes that newBuild and
 startBuild will be called back-to-back, and in this case that doesn't
 happen.  So removing the assertion is the correct fix.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2028#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Jul  2 22:11:39 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 02 Jul 2011 22:11:39 -0000
Subject: [Buildbot-commits] [Buildbot] #2021: (more) email breakage in
	0.8.4p1
In-Reply-To: <039.31ff56233f87e846ac56ead92ff55c15@buildbot.net>
References: <039.31ff56233f87e846ac56ead92ff55c15@buildbot.net>
Message-ID: <054.9e2ddd5186c6e1e63d242b610365e211@buildbot.net>

#2021: (more) email breakage in 0.8.4p1
--------------------+--------------------
Reporter:  dberger  |       Owner:
    Type:  defect   |      Status:  new
Priority:  major    |   Milestone:  0.8.5
 Version:  0.8.4p1  |  Resolution:
Keywords:  mail     |
--------------------+--------------------
Description changed by dustin:

Old description:

> 2011-06-29 07:45:22-0700 [-] Exception caught notifying
> <buildbot.status.mail.MailNotifier instance at 0x02CA7350> of
> buildFinished event
> 2011-06-29 07:45:22-0700 [-] Unhandled Error
>         Traceback (most recent call last):
>           File
> "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\build.py",
> line 288, in buildFinished
>             w.callback(self)
>           File
> "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line
> 361, in callback
>             self._startRunCallbacks(result)
>           File
> "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line
> 455, in _startRunCallbacks
>             self._runCallbacks()
>           File
> "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line
> 542, in _runCallbacks
>             current.result = callback(current.result, *args, **kw)
>         --- <exception caught here> ---
>           File
> "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\builder.py",
> line 541, in _buildFinished
>             w.buildFinished(name, s, results)
>           File
> "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\mail.py", line
> 410, in buildFinished
>             return self.buildMessage(name, [build], results)
>           File
> "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\mail.py", line
> 593, in buildMessage
>             results, builds, patches, logs)
>           File
> "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\mail.py", line
> 545, in createEmail
>             k = builds[0].render(k)
>         exceptions.AttributeError: BuildStatus instance has no attribute
> 'render'

New description:

 {{{
 2011-06-29 07:45:22-0700 [-] Exception caught notifying
 <buildbot.status.mail.MailNotifier instance at 0x02CA7350> of
 buildFinished event
 2011-06-29 07:45:22-0700 [-] Unhandled Error
         Traceback (most recent call last):
           File
 "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\build.py", line
 288, in buildFinished
             w.callback(self)
           File
 "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line
 361, in callback
             self._startRunCallbacks(result)
           File
 "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line
 455, in _startRunCallbacks
             self._runCallbacks()
           File
 "E:\build_master\external\Twisted-11.0.0\twisted\internet\defer.py", line
 542, in _runCallbacks
             current.result = callback(current.result, *args, **kw)
         --- <exception caught here> ---
           File
 "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\builder.py",
 line 541, in _buildFinished
             w.buildFinished(name, s, results)
           File
 "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\mail.py", line
 410, in buildFinished
             return self.buildMessage(name, [build], results)
           File
 "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\mail.py", line
 593, in buildMessage
             results, builds, patches, logs)
           File
 "E:\build_master\external\buildbot-0.8.4p1\buildbot\status\mail.py", line
 545, in createEmail
             k = builds[0].render(k)
         exceptions.AttributeError: BuildStatus instance has no attribute
 'render'
 }}}

--

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2021#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Jul  2 22:11:45 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 02 Jul 2011 22:11:45 -0000
Subject: [Buildbot-commits] [Buildbot] #2024: Documentation for
 "WithProperties" is incorrect
In-Reply-To: <043.6d711bed6236155c07ac5a0a82d6f719@buildbot.net>
References: <043.6d711bed6236155c07ac5a0a82d6f719@buildbot.net>
Message-ID: <058.9ff829995a7a462ba5ad1d676d69702a@buildbot.net>

#2024: Documentation for "WithProperties" is incorrect
------------------------+--------------------
Reporter:  mitcholiver  |       Owner:
    Type:  defect       |      Status:  new
Priority:  minor        |   Milestone:  0.8.5
 Version:  0.8.4p1      |  Resolution:
Keywords:               |
------------------------+--------------------
Changes (by dustin):

 * milestone:  undecided => 0.8.5


Old description:

> The example for using a callable with WithProperites includes an example
> function.  This function does not work.
>
> The current code:
>      def determine_foo(props):
>          if props.has_key('bar'):
>              return props['bar']
>          elif props.has_key('baz'):
>              return props['baz']
>          return 'qux'
>
>      WithProperties('%(foo)s', foo=determine_foo)
>
> will fail, as the parameter is of type Build.  Use this instead:
>      def determine_foo(build):
>          props = build.getProperties()
>          if props.has_key('bar'):
>              return props['bar']
>          elif props.has_key('baz'):
>              return props['baz']
>          return 'qux'
>
>      WithProperties('%(foo)s', foo=determine_foo)

New description:

 The example for using a callable with WithProperites includes an example
 function.  This function does not work.

 The current code:
 {{{
 #!python
      def determine_foo(props):
          if props.has_key('bar'):
              return props['bar']
          elif props.has_key('baz'):
              return props['baz']
          return 'qux'

      WithProperties('%(foo)s', foo=determine_foo)
 }}}

 will fail, as the parameter is of type Build.  Use this instead:

 {{{
 #!python
      def determine_foo(build):
          props = build.getProperties()
          if props.has_key('bar'):
              return props['bar']
          elif props.has_key('baz'):
              return props['baz']
          return 'qux'

      WithProperties('%(foo)s', foo=determine_foo)
 }}}

--

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2024#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Jul  2 22:11:48 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 02 Jul 2011 22:11:48 -0000
Subject: [Buildbot-commits] [Buildbot] #2030: Build Properties should
 clarify the order in which properties are applied
In-Reply-To: <043.4427ee79b6c1c80d601f3f04a748ddc8@buildbot.net>
References: <043.4427ee79b6c1c80d601f3f04a748ddc8@buildbot.net>
Message-ID: <058.ec48e0d5bcf256e25d5e04b61fdf0510@buildbot.net>

#2030: Build Properties should clarify the order in which properties are applied
------------------------+--------------------
Reporter:  mitcholiver  |       Owner:
    Type:  enhancement  |      Status:  new
Priority:  trivial      |   Milestone:  0.8.5
 Version:  0.8.4p1      |  Resolution:
Keywords:  docs         |
------------------------+--------------------
Changes (by dustin):

 * keywords:   => docs
 * milestone:  undecided => 0.8.5


-- 
Ticket URL: <http://trac.buildbot.net/ticket/2030#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Jul  2 22:11:50 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 02 Jul 2011 22:11:50 -0000
Subject: [Buildbot-commits] [Buildbot] #2031: buildbot try
 --with-properties truncates property vals with '='
In-Reply-To: <040.737e859dcecd94c0148ae10f7a14cf8c@buildbot.net>
References: <040.737e859dcecd94c0148ae10f7a14cf8c@buildbot.net>
Message-ID: <055.8fb5483cceee031bbe26fbcde20af7b5@buildbot.net>

#2031: buildbot try --with-properties truncates property vals with '='
---------------------+--------------------
Reporter:  rmorison  |       Owner:
    Type:  defect    |      Status:  new
Priority:  minor     |   Milestone:  0.8.5
 Version:  0.8.4p1   |  Resolution:
Keywords:            |
---------------------+--------------------
Changes (by dustin):

 * keywords:  try property =>
 * milestone:  undecided => 0.8.5


-- 
Ticket URL: <http://trac.buildbot.net/ticket/2031#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Jul  2 22:35:23 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 02 Jul 2011 22:35:23 -0000
Subject: [Buildbot-commits] [Buildbot] #2005: SQLAlchemy Operational
 errors with SQLite: Database is locked
In-Reply-To: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net>
References: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net>
Message-ID: <055.a5dcbead0b7bba1ba71cd640b01b2c63@buildbot.net>

#2005: SQLAlchemy Operational errors with SQLite: Database is locked
---------------------+--------------------
Reporter:  abompard  |       Owner:
    Type:  defect    |      Status:  new
Priority:  critical  |   Milestone:  0.8.5
 Version:  0.8.4     |  Resolution:
Keywords:  database  |
---------------------+--------------------

Comment (by dustin):

 Hmm, I don't see any logging from that patch - are you sure it was applied
 in the right place?  There should be log lines regarding "database
 operation".

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2005#comment:4>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Sat Jul  2 22:39:44 2011
From: noreply at github.com (noreply at github.com)
Date: Sat, 2 Jul 2011 15:39:44 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 78bea1: Use a
	properly-formed default mergeRequests functi...
Message-ID: <20110702223944.C5F98423F6@smtp1.rs.github.com>

  Branch: refs/heads/buildbot-0.8.4
  Home:   https://github.com/buildbot/buildbot

  Commit: 78bea192df2fa04472181e4de030785545d6ffbd
      https://github.com/buildbot/buildbot/commit/78bea192df2fa04472181e4de030785545d6ffbd
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-01 (Fri, 01 Jul 2011)

  Changed paths:
    M master/buildbot/process/builder.py
  M master/buildbot/test/unit/test_process_builder.py

  Log Message:
  -----------
  Use a properly-formed default mergeRequests function

This function takes the requisite three arguments (builder, req1, req2),
and calls through to the BuildRequest.canBeMergedWith method.

Fixes #2025.


  Commit: e258afa1db70efcea9522657b33f9fb5a3bf3149
      https://github.com/buildbot/buildbot/commit/e258afa1db70efcea9522657b33f9fb5a3bf3149
  Author: Aurelian Bompard <aurelien at bompard.org>
  Date:   2011-07-02 (Sat, 02 Jul 2011)

  Changed paths:
    M master/buildbot/status/mail.py

  Log Message:
  -----------
  Allow MailNotifier subject to be overridden

Fixes #2014.


  Commit: ee833ea79f42dfb182a98b86e068d62510098a79
      https://github.com/buildbot/buildbot/commit/ee833ea79f42dfb182a98b86e068d62510098a79
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-02 (Sat, 02 Jul 2011)

  Changed paths:
    M master/buildbot/process/build.py
  M master/buildbot/status/mail.py
  M master/buildbot/test/unit/test_process_builder.py
  M master/docs/cfg-buildsteps.texinfo
  M master/docs/cfg-statustargets.texinfo

  Log Message:
  -----------
  0.8.4 Branch fixups for properties

Do not render properties in MailNotifier extraHeaders (Refs #2021)

Make the WithProperties callable example work (Refs #2024)


  Commit: 37f64f5476e0da77ac5e1e5485657a456ab19290
      https://github.com/buildbot/buildbot/commit/37f64f5476e0da77ac5e1e5485657a456ab19290
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-02 (Sat, 02 Jul 2011)

  Changed paths:
    M master/buildbot/status/builder.py

  Log Message:
  -----------
  remove incorrect assertion

Fixes #2028.


Compare: https://github.com/buildbot/buildbot/compare/2310000...37f64f5



From noreply at github.com  Sat Jul  2 22:39:44 2011
From: noreply at github.com (noreply at github.com)
Date: Sat, 2 Jul 2011 15:39:44 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 78da9f: Allow try
	--properties with '=' in value
Message-ID: <20110702223944.D526D42407@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 78da9f9e7d52b7cf851d9d019c5560939d20a784
      https://github.com/buildbot/buildbot/commit/78da9f9e7d52b7cf851d9d019c5560939d20a784
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-01 (Fri, 01 Jul 2011)

  Changed paths:
    M master/buildbot/clients/tryclient.py
  M master/buildbot/scripts/runner.py
  M master/buildbot/test/unit/test_scripts_runner.py

  Log Message:
  -----------
  Allow try --properties with '=' in value

And add a whole mess of tests, and clean up option handling
significantly.  Fixes #2031.


  Commit: dc01a4db73d39c33babcb576e5517b7666288830
      https://github.com/buildbot/buildbot/commit/dc01a4db73d39c33babcb576e5517b7666288830
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-01 (Fri, 01 Jul 2011)

  Changed paths:
    M master/docs/concepts.texinfo

  Log Message:
  -----------
  Describe property precedence explicitly

Fixes #2030.


  Commit: 0987c3b051463f4e982b0c0cc465cbb86916f485
      https://github.com/buildbot/buildbot/commit/0987c3b051463f4e982b0c0cc465cbb86916f485
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-01 (Fri, 01 Jul 2011)

  Changed paths:
    M master/buildbot/process/builder.py
  M master/buildbot/test/unit/test_process_builder.py

  Log Message:
  -----------
  Use a properly-formed default mergeRequests function

This function takes the requisite three arguments (builder, req1, req2),
and calls through to the BuildRequest.canBeMergedWith method.

Fixes #2025.


  Commit: 5468cc2fb22a0559bf0fd2cfc51ecd17c2b511e7
      https://github.com/buildbot/buildbot/commit/5468cc2fb22a0559bf0fd2cfc51ecd17c2b511e7
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-02 (Sat, 02 Jul 2011)

  Changed paths:
    M master/buildbot/interfaces.py
  M master/buildbot/process/build.py
  M master/buildbot/process/properties.py
  M master/buildbot/status/build.py
  M master/buildbot/status/mail.py
  M master/buildbot/test/unit/test_process_build.py
  M master/buildbot/test/unit/test_process_builder.py
  M master/buildbot/test/unit/test_process_properties.py
  A master/buildbot/test/unit/test_status_build.py
  A master/buildbot/test/unit/test_status_mail.py
  R master/buildbot/test/unit/test_status_mail_MailNotifier.py
  M master/docs/cfg-buildsteps.texinfo
  M master/docs/cfg-statustargets.texinfo

  Log Message:
  -----------
  Add a hasProperties method to builds

This better-defines the interface of the object passed to WithProperties
callables, including a hasProperties method; fixes MailNotifier to
render properties properly in extraHeaders; and adds a lot of tests.

Fixes #2024 and Fixes #2021.


  Commit: fea9229d523a3942f3ace9af48796882d375eaa3
      https://github.com/buildbot/buildbot/commit/fea9229d523a3942f3ace9af48796882d375eaa3
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-02 (Sat, 02 Jul 2011)

  Changed paths:
    M master/buildbot/status/builder.py

  Log Message:
  -----------
  remove incorrect assertion

Fixes #2028.


Compare: https://github.com/buildbot/buildbot/compare/a34f223...fea9229



From nobody at buildbot.net  Sat Jul  2 22:39:51 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 02 Jul 2011 22:39:51 -0000
Subject: [Buildbot-commits] [Buildbot] #2031: buildbot try
 --with-properties truncates property vals with '='
In-Reply-To: <040.737e859dcecd94c0148ae10f7a14cf8c@buildbot.net>
References: <040.737e859dcecd94c0148ae10f7a14cf8c@buildbot.net>
Message-ID: <055.382bda8fd258ecb7feb8453fac7e99c7@buildbot.net>

#2031: buildbot try --with-properties truncates property vals with '='
---------------------+---------------------
Reporter:  rmorison  |       Owner:
    Type:  defect    |      Status:  closed
Priority:  minor     |   Milestone:  0.8.5
 Version:  0.8.4p1   |  Resolution:  fixed
Keywords:            |
---------------------+---------------------
Changes (by Dustin J. Mitchell):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Allow try --properties with '=' in value

 And add a whole mess of tests, and clean up option handling
 significantly.  Fixes #2031.
  Changeset: 78da9f9e7d52b7cf851d9d019c5560939d20a784

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2031#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Jul  2 22:39:51 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 02 Jul 2011 22:39:51 -0000
Subject: [Buildbot-commits] [Buildbot] #2025: If global and/or per
 builder mergeRequests is not set,
 the default mergeRequests handler expects only two arguments not the
 provided 3
In-Reply-To: <040.41ef4e477a988d57c3ea32b1c401d71a@buildbot.net>
References: <040.41ef4e477a988d57c3ea32b1c401d71a@buildbot.net>
Message-ID: <055.35c443e9cc42e46e9af6d859a5a31b6c@buildbot.net>

#2025: If global and/or per builder mergeRequests is not set, the default
mergeRequests handler expects only two arguments not the provided 3
---------------------+---------------------
Reporter:  bdbaddog  |       Owner:
    Type:  defect    |      Status:  closed
Priority:  blocker   |   Milestone:  0.8.5
 Version:  0.8.4p1   |  Resolution:  fixed
Keywords:            |
---------------------+---------------------
Changes (by Dustin J. Mitchell):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Use a properly-formed default mergeRequests function

 This function takes the requisite three arguments (builder, req1, req2),
 and calls through to the BuildRequest.canBeMergedWith method.

 Fixes #2025.
  Changeset: 0987c3b051463f4e982b0c0cc465cbb86916f485

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2025#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Jul  2 22:39:51 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 02 Jul 2011 22:39:51 -0000
Subject: [Buildbot-commits] [Buildbot] #2030: Build Properties should
 clarify the order in which properties are applied
In-Reply-To: <043.4427ee79b6c1c80d601f3f04a748ddc8@buildbot.net>
References: <043.4427ee79b6c1c80d601f3f04a748ddc8@buildbot.net>
Message-ID: <058.2e34187701a2308e34503bf801e297b5@buildbot.net>

#2030: Build Properties should clarify the order in which properties are applied
------------------------+---------------------
Reporter:  mitcholiver  |       Owner:
    Type:  enhancement  |      Status:  closed
Priority:  trivial      |   Milestone:  0.8.5
 Version:  0.8.4p1      |  Resolution:  fixed
Keywords:  docs         |
------------------------+---------------------
Changes (by Dustin J. Mitchell):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Describe property precedence explicitly

 Fixes #2030.
  Changeset: dc01a4db73d39c33babcb576e5517b7666288830

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2030#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Jul  2 22:39:52 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 02 Jul 2011 22:39:52 -0000
Subject: [Buildbot-commits] [Buildbot] #2021: (more) email breakage in
	0.8.4p1
In-Reply-To: <039.31ff56233f87e846ac56ead92ff55c15@buildbot.net>
References: <039.31ff56233f87e846ac56ead92ff55c15@buildbot.net>
Message-ID: <054.4da2b4df7019dd98edd0e3563fab34c0@buildbot.net>

#2021: (more) email breakage in 0.8.4p1
--------------------+---------------------
Reporter:  dberger  |       Owner:
    Type:  defect   |      Status:  closed
Priority:  major    |   Milestone:  0.8.5
 Version:  0.8.4p1  |  Resolution:  fixed
Keywords:  mail     |
--------------------+---------------------
Changes (by Dustin J. Mitchell):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Add a hasProperties method to builds

 This better-defines the interface of the object passed to WithProperties
 callables, including a hasProperties method; fixes MailNotifier to
 render properties properly in extraHeaders; and adds a lot of tests.

 Fixes #2024 and Fixes #2021.
  Changeset: 5468cc2fb22a0559bf0fd2cfc51ecd17c2b511e7

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2021#comment:4>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Jul  2 22:39:52 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 02 Jul 2011 22:39:52 -0000
Subject: [Buildbot-commits] [Buildbot] #2024: Documentation for
 "WithProperties" is incorrect
In-Reply-To: <043.6d711bed6236155c07ac5a0a82d6f719@buildbot.net>
References: <043.6d711bed6236155c07ac5a0a82d6f719@buildbot.net>
Message-ID: <058.ae5fd47ca39ab3bad868ca359726bf7f@buildbot.net>

#2024: Documentation for "WithProperties" is incorrect
------------------------+---------------------
Reporter:  mitcholiver  |       Owner:
    Type:  defect       |      Status:  closed
Priority:  minor        |   Milestone:  0.8.5
 Version:  0.8.4p1      |  Resolution:  fixed
Keywords:               |
------------------------+---------------------
Changes (by Dustin J. Mitchell):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Add a hasProperties method to builds

 This better-defines the interface of the object passed to WithProperties
 callables, including a hasProperties method; fixes MailNotifier to
 render properties properly in extraHeaders; and adds a lot of tests.

 Fixes #2024 and Fixes #2021.
  Changeset: 5468cc2fb22a0559bf0fd2cfc51ecd17c2b511e7

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2024#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Jul  2 22:39:52 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 02 Jul 2011 22:39:52 -0000
Subject: [Buildbot-commits] [Buildbot] #2028: startBuild failing with
 assertion, causes builder to never fire.
In-Reply-To: <040.1ac5c37d32929b0ca70f04cc5594a03f@buildbot.net>
References: <040.1ac5c37d32929b0ca70f04cc5594a03f@buildbot.net>
Message-ID: <055.0a5d1e81d5b68ee7132c24a1118d44e8@buildbot.net>

#2028: startBuild failing with assertion, causes builder to never fire.
---------------------+------------------------
Reporter:  bdbaddog  |       Owner:
    Type:  defect    |      Status:  closed
Priority:  major     |   Milestone:  undecided
 Version:  0.8.4p1   |  Resolution:  fixed
Keywords:            |
---------------------+------------------------
Changes (by Dustin J. Mitchell):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 remove incorrect assertion

 Fixes #2028.
  Changeset: fea9229d523a3942f3ace9af48796882d375eaa3

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2028#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Jul  2 22:40:07 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 02 Jul 2011 22:40:07 -0000
Subject: [Buildbot-commits] [Buildbot] #2025: If global and/or per
 builder mergeRequests is not set,
 the default mergeRequests handler expects only two arguments not the
 provided 3
In-Reply-To: <040.41ef4e477a988d57c3ea32b1c401d71a@buildbot.net>
References: <040.41ef4e477a988d57c3ea32b1c401d71a@buildbot.net>
Message-ID: <055.3208f7822fbb73b379105f3d2fc04978@buildbot.net>

#2025: If global and/or per builder mergeRequests is not set, the default
mergeRequests handler expects only two arguments not the provided 3
---------------------+---------------------
Reporter:  bdbaddog  |       Owner:
    Type:  defect    |      Status:  closed
Priority:  blocker   |   Milestone:  0.8.5
 Version:  0.8.4p1   |  Resolution:  fixed
Keywords:            |
---------------------+---------------------

Comment (by Dustin J. Mitchell):

 Use a properly-formed default mergeRequests function

 This function takes the requisite three arguments (builder, req1, req2),
 and calls through to the BuildRequest.canBeMergedWith method.

 Fixes #2025.
  Changeset: 78bea192df2fa04472181e4de030785545d6ffbd

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2025#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Jul  2 22:40:08 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 02 Jul 2011 22:40:08 -0000
Subject: [Buildbot-commits] [Buildbot] #2014: The MailNotifier's subject
 can't be overriden anymore with a function
In-Reply-To: <040.5c1e4db7d95c5a7da5ff76c569eddde4@buildbot.net>
References: <040.5c1e4db7d95c5a7da5ff76c569eddde4@buildbot.net>
Message-ID: <055.b741b26bfbbb256718da09050af4b8e6@buildbot.net>

#2014: The MailNotifier's subject can't be overriden anymore with a function
---------------------+---------------------
Reporter:  abompard  |       Owner:
    Type:  defect    |      Status:  closed
Priority:  major     |   Milestone:  0.8.5
 Version:  0.8.4p1   |  Resolution:  fixed
Keywords:  mail      |
---------------------+---------------------

Comment (by Aurelian Bompard):

 Allow MailNotifier subject to be overridden

 Fixes #2014.
  Changeset: e258afa1db70efcea9522657b33f9fb5a3bf3149

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2014#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Jul  2 22:40:09 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 02 Jul 2011 22:40:09 -0000
Subject: [Buildbot-commits] [Buildbot] #2024: Documentation for
 "WithProperties" is incorrect
In-Reply-To: <043.6d711bed6236155c07ac5a0a82d6f719@buildbot.net>
References: <043.6d711bed6236155c07ac5a0a82d6f719@buildbot.net>
Message-ID: <058.147c931f8a3c421ee59fd15c59ff4699@buildbot.net>

#2024: Documentation for "WithProperties" is incorrect
------------------------+---------------------
Reporter:  mitcholiver  |       Owner:
    Type:  defect       |      Status:  closed
Priority:  minor        |   Milestone:  0.8.5
 Version:  0.8.4p1      |  Resolution:  fixed
Keywords:               |
------------------------+---------------------

Comment (by Dustin J. Mitchell):

 0.8.4 Branch fixups for properties

 Do not render properties in MailNotifier extraHeaders (Refs #2021)

 Make the WithProperties callable example work (Refs #2024)
  Changeset: ee833ea79f42dfb182a98b86e068d62510098a79

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2024#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Jul  2 22:40:09 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 02 Jul 2011 22:40:09 -0000
Subject: [Buildbot-commits] [Buildbot] #2021: (more) email breakage in
	0.8.4p1
In-Reply-To: <039.31ff56233f87e846ac56ead92ff55c15@buildbot.net>
References: <039.31ff56233f87e846ac56ead92ff55c15@buildbot.net>
Message-ID: <054.399c2512c9cd58f058ee87ff35eebbdf@buildbot.net>

#2021: (more) email breakage in 0.8.4p1
--------------------+---------------------
Reporter:  dberger  |       Owner:
    Type:  defect   |      Status:  closed
Priority:  major    |   Milestone:  0.8.5
 Version:  0.8.4p1  |  Resolution:  fixed
Keywords:  mail     |
--------------------+---------------------

Comment (by Dustin J. Mitchell):

 0.8.4 Branch fixups for properties

 Do not render properties in MailNotifier extraHeaders (Refs #2021)

 Make the WithProperties callable example work (Refs #2024)
  Changeset: ee833ea79f42dfb182a98b86e068d62510098a79

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2021#comment:5>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Jul  2 22:40:10 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 02 Jul 2011 22:40:10 -0000
Subject: [Buildbot-commits] [Buildbot] #2028: startBuild failing with
 assertion, causes builder to never fire.
In-Reply-To: <040.1ac5c37d32929b0ca70f04cc5594a03f@buildbot.net>
References: <040.1ac5c37d32929b0ca70f04cc5594a03f@buildbot.net>
Message-ID: <055.a8de9183738df0306e2866a0e7f713ec@buildbot.net>

#2028: startBuild failing with assertion, causes builder to never fire.
---------------------+------------------------
Reporter:  bdbaddog  |       Owner:
    Type:  defect    |      Status:  closed
Priority:  major     |   Milestone:  undecided
 Version:  0.8.4p1   |  Resolution:  fixed
Keywords:            |
---------------------+------------------------

Comment (by Dustin J. Mitchell):

 remove incorrect assertion

 Fixes #2028.
  Changeset: 37f64f5476e0da77ac5e1e5485657a456ab19290

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2028#comment:4>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Sun Jul  3 01:00:52 2011
From: noreply at github.com (noreply at github.com)
Date: Sat, 2 Jul 2011 18:00:52 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 7da09d: handle early
	disconnects from web clients
Message-ID: <20110703010052.A1CA54243E@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 7da09de40563e364f9498a7661609f9163f3487c
      https://github.com/buildbot/buildbot/commit/7da09de40563e364f9498a7661609f9163f3487c
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-02 (Sat, 02 Jul 2011)

  Changed paths:
    M master/buildbot/status/web/base.py

  Log Message:
  -----------
  handle early disconnects from web clients

Fixes #2027.





From nobody at buildbot.net  Sun Jul  3 01:00:58 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 03 Jul 2011 01:00:58 -0000
Subject: [Buildbot-commits] [Buildbot] #2027: Unhandled error in
	Deferred (0.8.4p1)
In-Reply-To: <039.0fb62fd6e28281a78e5682a6e439200f@buildbot.net>
References: <039.0fb62fd6e28281a78e5682a6e439200f@buildbot.net>
Message-ID: <054.2ccfbb7c13176a709d88b2157df77f51@buildbot.net>

#2027: Unhandled error in Deferred (0.8.4p1)
--------------------+---------------------
Reporter:  dberger  |       Owner:
    Type:  defect   |      Status:  closed
Priority:  trivial  |   Milestone:  0.8.5
 Version:  0.8.4p1  |  Resolution:  fixed
Keywords:  web      |
--------------------+---------------------
Changes (by Dustin J. Mitchell):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 handle early disconnects from web clients

 Fixes #2027.
  Changeset: 7da09de40563e364f9498a7661609f9163f3487c

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2027#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sun Jul  3 01:30:03 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 03 Jul 2011 01:30:03 -0000
Subject: [Buildbot-commits] [Buildbot] #1052: blamelist lost via trigger
In-Reply-To: <039.c1a1ed20af5a431c7d00e91345a91371@buildbot.net>
References: <039.c1a1ed20af5a431c7d00e91345a91371@buildbot.net>
Message-ID: <054.1ef7f757bd885d3a707df5fb58500c35@buildbot.net>

#1052: blamelist lost via trigger
--------------------+-----------------------
Reporter:  qzhwang  |       Owner:
    Type:  defect   |      Status:  reopened
Priority:  major    |   Milestone:  0.8.2
 Version:  0.8.1    |  Resolution:
Keywords:           |
--------------------+-----------------------
Changes (by dberger):

 * cc: dberger@? (added)
 * priority:  minor => major
 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 we're seeing the same problem in 0.8.4p1 - triggered builds (with
 updateSourceStamp False) no longer have changes or blamelist associated.

 the problem this presents (for us) is that we have an "all platforms"
 builder that triggers builds on each platform - the all platforms builder
 mails on success, but the individual platform builders mail on failure (as
 they have the actual compile output and can include the errors).

 due to this defect, the failure email no longer lists blame correctly, and
 may not even be being sent.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1052#comment:6>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sun Jul  3 02:05:28 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 03 Jul 2011 02:05:28 -0000
Subject: [Buildbot-commits] [Buildbot] #2007: Try --wait reports 'no
	build'
In-Reply-To: <039.a614a418fd328270547a8a19952a239c@buildbot.net>
References: <039.a614a418fd328270547a8a19952a239c@buildbot.net>
Message-ID: <054.4cf4ab495c30a9363c4e35131a32e098@buildbot.net>

#2007: Try --wait reports 'no build'
---------------------+--------------------
Reporter:  aslater   |       Owner:
    Type:  defect    |      Status:  new
Priority:  critical  |   Milestone:  0.8.5
 Version:  0.8.4p1   |  Resolution:
Keywords:  try       |
---------------------+--------------------

Comment (by dustin):

 I'm seeing two behaviors so far: without specifying {{{--builder}}}, I see
 {{{
 using 'pb' connect method
 job created
 Delivering job; comment= None
 job has been delivered
 builder: no build
 }}}
 where the last line repeats.

 If I specify {{{--builder}}} with a valid builder, I see the same.  If I
 specify {{{--builder}}} with an invalid builder, I get an
 !UnauthorizedLogin for the user "statusClient".

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2007#comment:4>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sun Jul  3 05:43:07 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 03 Jul 2011 05:43:07 -0000
Subject: [Buildbot-commits] [Buildbot] #1767: SVNPoller does not support
	logEnviron
In-Reply-To: <037.723f28971a56e2d4357bf3c11dc762f0@buildbot.net>
References: <037.723f28971a56e2d4357bf3c11dc762f0@buildbot.net>
Message-ID: <052.2a933ec22785ccfc250a213b5c6ec4d3@buildbot.net>

#1767: SVNPoller does not support logEnviron
------------------------+--------------------
Reporter:  fgsch        |       Owner:
    Type:  enhancement  |      Status:  new
Priority:  minor        |   Milestone:  0.8.5
 Version:  0.8.3p1      |  Resolution:
Keywords:  svn          |
------------------------+--------------------

Comment (by bdbaddog):

 Sent pull request with patch:

 https://github.com/buildbot/buildbot/pull/173

 Not sure how to create a unit test to cover this.
 Please let me know if there is a method to do so already defined.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1767#comment:4>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sun Jul  3 07:44:50 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 03 Jul 2011 07:44:50 -0000
Subject: [Buildbot-commits] [Buildbot] #2005: SQLAlchemy Operational
 errors with SQLite: Database is locked
In-Reply-To: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net>
References: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net>
Message-ID: <055.8bd07d90d9feb9503443e9377fa3ffe7@buildbot.net>

#2005: SQLAlchemy Operational errors with SQLite: Database is locked
---------------------+--------------------
Reporter:  abompard  |       Owner:
    Type:  defect    |      Status:  new
Priority:  critical  |   Milestone:  0.8.5
 Version:  0.8.4     |  Resolution:
Keywords:  database  |
---------------------+--------------------

Comment (by abompard):

 OK, I found out why : I'm using twisted 0.8.1, so I had to add the debug
 lines to the 0.8.1-specific functions in pool.py.

 I've reproduced the error, so I'm attaching a new log file from buildbot
 start to the log rotation. It contains one "database is locked" traceback
 towards the end. I hope there will be enough context, if not I can send
 you the next log.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2005#comment:5>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sun Jul  3 10:36:47 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 03 Jul 2011 10:36:47 -0000
Subject: [Buildbot-commits] [Buildbot] #2034: web interface renders strange
 in gtkwebkit-based browsers
Message-ID: <038.c698624be25d79c4a20598fba3802d8f@buildbot.net>

#2034: web interface renders strange in gtkwebkit-based browsers
----------------------+-----------------------
Reporter:  landry     |      Owner:
    Type:  undecided  |     Status:  new
Priority:  major      |  Milestone:  undecided
 Version:  0.8.4p1    |   Keywords:
----------------------+-----------------------
 try browsing the web ui for some buildbots in webkitgtk-based browsers
 (tried with midori, xxxterm, both with webkitgtk 1.4.0), the rendering is
 ... see attached screenshot. Probably a css thing ?

 It renders fine in mozilla based browsers or qtwebkit based browsers.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2034>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sun Jul  3 10:39:47 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 03 Jul 2011 10:39:47 -0000
Subject: [Buildbot-commits] [Buildbot] #2034: web interface renders
 strange in gtkwebkit-based browsers
In-Reply-To: <038.c698624be25d79c4a20598fba3802d8f@buildbot.net>
References: <038.c698624be25d79c4a20598fba3802d8f@buildbot.net>
Message-ID: <053.bc1ad8ed083cc5f28c459199057cf7db@buildbot.net>

#2034: web interface renders strange in gtkwebkit-based browsers
----------------------+------------------------
Reporter:  landry     |       Owner:
    Type:  undecided  |      Status:  new
Priority:  major      |   Milestone:  undecided
 Version:  0.8.4p1    |  Resolution:
Keywords:             |
----------------------+------------------------

Comment (by landry):

 Oh and i've tried with buildbot.xfce.org, my own buildbot running 0.8.3p1,
 buildbot.twistedmatrix.com, buildbot.videolan.org....

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2034#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Sun Jul  3 13:30:43 2011
From: noreply at github.com (noreply at github.com)
Date: Sun, 3 Jul 2011 06:30:43 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 344e2b: Handle 'buildbot
	try' without --who
Message-ID: <20110703133043.BE617424C3@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 344e2bdb9d62f7661731f8b894657e96e40275e6
      https://github.com/buildbot/buildbot/commit/344e2bdb9d62f7661731f8b894657e96e40275e6
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-02 (Sat, 02 Jul 2011)

  Changed paths:
    M master/buildbot/schedulers/trysched.py

  Log Message:
  -----------
  Handle 'buildbot try' without --who





From nobody at buildbot.net  Sun Jul  3 14:12:25 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 03 Jul 2011 14:12:25 -0000
Subject: [Buildbot-commits] [Buildbot] #2034: web interface renders
 strange in gtkwebkit-based browsers
In-Reply-To: <038.c698624be25d79c4a20598fba3802d8f@buildbot.net>
References: <038.c698624be25d79c4a20598fba3802d8f@buildbot.net>
Message-ID: <053.f81bb9940688ca7f34dc3c6bf2d7256d@buildbot.net>

#2034: web interface renders strange in gtkwebkit-based browsers
--------------------+--------------------
Reporter:  landry   |       Owner:
    Type:  defect   |      Status:  new
Priority:  major    |   Milestone:  0.8.+
 Version:  0.8.4p1  |  Resolution:
Keywords:           |
--------------------+--------------------
Changes (by dustin):

 * type:  undecided => defect
 * milestone:  undecided => 0.8.+


Comment:

 Any idea what the fix is?  It's not like we're using complex character-
 positioning.  It's a simple 'ul' element with some 'li' elements.  Are you
 sure this isn't a webkit bug?

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2034#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sun Jul  3 14:47:21 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 03 Jul 2011 14:47:21 -0000
Subject: [Buildbot-commits] [Buildbot] #1767: SVNPoller does not support
	logEnviron
In-Reply-To: <037.723f28971a56e2d4357bf3c11dc762f0@buildbot.net>
References: <037.723f28971a56e2d4357bf3c11dc762f0@buildbot.net>
Message-ID: <052.9cbb1bf8f482504b2e93fd1479fc3d8f@buildbot.net>

#1767: SVNPoller does not support logEnviron
------------------------+--------------------
Reporter:  fgsch        |       Owner:
    Type:  enhancement  |      Status:  new
Priority:  minor        |   Milestone:  0.8.5
 Version:  0.8.3p1      |  Resolution:
Keywords:  svn          |
------------------------+--------------------

Comment (by dustin):

 Comments on the pull req.  There's not a good way to test this particular
 change.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1767#comment:5>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sun Jul  3 22:06:51 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 03 Jul 2011 22:06:51 -0000
Subject: [Buildbot-commits] [Buildbot] #2005: SQLAlchemy Operational
 errors with SQLite: Database is locked
In-Reply-To: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net>
References: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net>
Message-ID: <055.365669780c0cdaa0991027e1efef53a3@buildbot.net>

#2005: SQLAlchemy Operational errors with SQLite: Database is locked
---------------------+--------------------
Reporter:  abompard  |       Owner:
    Type:  defect    |      Status:  new
Priority:  critical  |   Milestone:  0.8.5
 Version:  0.8.4     |  Resolution:
Keywords:  database  |
---------------------+--------------------

Comment (by dustin):

 (For the record, that's Twisted-8.1.0..)

 Ah, I've been thinking of SQLITE_BUSY all this time - the error is
 SQLITE_LOCKED.  See http://www.sqlite.org/cvstrac/wiki?p=DatabaseIsLocked.
 In particular, I bet this is

  Trying to write to a table while a SELECT is active on that same table.

 which was fixed in sqlite version 3.3.7.  Are you using a version that
 old?

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2005#comment:6>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Sun Jul  3 22:08:10 2011
From: noreply at github.com (noreply at github.com)
Date: Sun, 3 Jul 2011 15:08:10 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 6bd279: print sqlite version
	when pool is loaded
Message-ID: <20110703220810.1767F42493@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 6bd279caf945e51882a1126288355528db68c769
      https://github.com/buildbot/buildbot/commit/6bd279caf945e51882a1126288355528db68c769
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-03 (Sun, 03 Jul 2011)

  Changed paths:
    M master/buildbot/db/pool.py

  Log Message:
  -----------
  print sqlite version when pool is loaded

This also checks for and logs about concurrency problems in older
versions of SQLite.  Refs #2005.





From nobody at buildbot.net  Sun Jul  3 22:08:15 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 03 Jul 2011 22:08:15 -0000
Subject: [Buildbot-commits] [Buildbot] #2005: SQLAlchemy Operational
 errors with SQLite: Database is locked
In-Reply-To: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net>
References: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net>
Message-ID: <055.86aefadb11555cb71032e7e29df3636a@buildbot.net>

#2005: SQLAlchemy Operational errors with SQLite: Database is locked
---------------------+--------------------
Reporter:  abompard  |       Owner:
    Type:  defect    |      Status:  new
Priority:  critical  |   Milestone:  0.8.5
 Version:  0.8.4     |  Resolution:
Keywords:  database  |
---------------------+--------------------

Comment (by Dustin J. Mitchell):

 print sqlite version when pool is loaded

 This also checks for and logs about concurrency problems in older
 versions of SQLite.  Refs #2005.
  Changeset: 6bd279caf945e51882a1126288355528db68c769

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2005#comment:7>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sun Jul  3 22:09:37 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 03 Jul 2011 22:09:37 -0000
Subject: [Buildbot-commits] [Buildbot] #2005: SQLAlchemy Operational
 errors with SQLite: Database is locked
In-Reply-To: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net>
References: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net>
Message-ID: <055.10a7fc86185d87c2b4753b4e6df9db80@buildbot.net>

#2005: SQLAlchemy Operational errors with SQLite: Database is locked
---------------------+--------------------
Reporter:  abompard  |       Owner:
    Type:  defect    |      Status:  new
Priority:  critical  |   Milestone:  0.8.5
 Version:  0.8.4     |  Resolution:
Keywords:  database  |
---------------------+--------------------

Comment (by dustin):

 I bet you can fix this problem by adding {{{?pool_size=1}}} to the end of
 your db_url - want to try that?

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2005#comment:8>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Jul  4 01:13:03 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 04 Jul 2011 01:13:03 -0000
Subject: [Buildbot-commits] [Buildbot] #2007: Try --wait reports 'no
	build'
In-Reply-To: <039.a614a418fd328270547a8a19952a239c@buildbot.net>
References: <039.a614a418fd328270547a8a19952a239c@buildbot.net>
Message-ID: <054.329b2d64a6258bd37bbd4e6819ca6ceb@buildbot.net>

#2007: Try --wait reports 'no build'
---------------------+--------------------
Reporter:  aslater   |       Owner:
    Type:  defect    |      Status:  new
Priority:  critical  |   Milestone:  0.8.5
 Version:  0.8.4p1   |  Resolution:
Keywords:  try       |
---------------------+--------------------

Comment (by dustin):

 So after a job is submitted, the pb method tries to get the
 !BuildSetStatus object, and failing that tries to connect to the
 statuclient on the same port.  The ssh method just tries to connect to the
 statusclient.

 It looks like it's the former case that is failing here.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2007#comment:5>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Jul  4 02:10:09 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 04 Jul 2011 02:10:09 -0000
Subject: [Buildbot-commits] [Buildbot] #2035: _ComputeRepositoryURL requires
 more info than IProperties makes available
Message-ID: <038.404f84516979f12f2deabf2552822446@buildbot.net>

#2035: _ComputeRepositoryURL requires more info than IProperties makes available
--------------------+-------------------
Reporter:  dustin   |      Owner:
    Type:  defect   |     Status:  new
Priority:  major    |  Milestone:  0.8.5
 Version:  0.8.4p1  |   Keywords:
--------------------+-------------------
 In 0.8.4, the class of the object passed to getRenderingFor methods was
 somewhat vague - a Build in some cases, !BuildStatus in others.

 I changed that in [5468cc2fb22a0559bf0fd2cfc51ecd17c2b511e7], where I
 defined the interface (IProperties) of the object passed to
 getRenderingFor (and, more importantly, for !WithProperties callables).

 Problem is, the getRenderingFor for _ComputeRepositoryURL expects a build,
 and calls {{{build.getSourceStamp}}}.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2035>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Jul  4 02:40:07 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 04 Jul 2011 02:40:07 -0000
Subject: [Buildbot-commits] [Buildbot] #2007: Try --wait reports 'no
	build'
In-Reply-To: <039.a614a418fd328270547a8a19952a239c@buildbot.net>
References: <039.a614a418fd328270547a8a19952a239c@buildbot.net>
Message-ID: <054.7ea40d0b19b6f77c7092abbd65e9a428@buildbot.net>

#2007: Try --wait reports 'no build'
---------------------+--------------------
Reporter:  aslater   |       Owner:
    Type:  defect    |      Status:  new
Priority:  critical  |   Milestone:  0.8.5
 Version:  0.8.4p1   |  Resolution:
Keywords:  try       |
---------------------+--------------------

Comment (by dustin):

 Having chased this down a little bit, the problem seems to be that
 _buildreq_observers are only called for *started* builds, not *finished*,
 which is what is needed here.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2007#comment:6>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Jul  4 02:57:04 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 04 Jul 2011 02:57:04 -0000
Subject: [Buildbot-commits] [Buildbot] #2035: _ComputeRepositoryURL
 requires more info than IProperties makes available
In-Reply-To: <038.404f84516979f12f2deabf2552822446@buildbot.net>
References: <038.404f84516979f12f2deabf2552822446@buildbot.net>
Message-ID: <053.b5756a0e5d56067302b2205f64101501@buildbot.net>

#2035: _ComputeRepositoryURL requires more info than IProperties makes available
--------------------+--------------------
Reporter:  dustin   |       Owner:
    Type:  defect   |      Status:  new
Priority:  major    |   Milestone:  0.8.5
 Version:  0.8.4p1  |  Resolution:
Keywords:           |
--------------------+--------------------

Comment (by dustin):

 Traceback is something along the lines of
 {{{
           File
 "/Users/derekhurley/Documents/Dropbox/gsoc/bbot/src/master/buildbot/steps/source/oldsource.py",
 line 37, in getRenderingFor
             s = build.getSourceStamp()
         exceptions.AttributeError: Properties instance has no attribute
 'getSourceStamp'
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2035#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Jul  4 03:07:09 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 04 Jul 2011 03:07:09 -0000
Subject: [Buildbot-commits] [Buildbot] #2007: Try --wait reports 'no
	build'
In-Reply-To: <039.a614a418fd328270547a8a19952a239c@buildbot.net>
References: <039.a614a418fd328270547a8a19952a239c@buildbot.net>
Message-ID: <054.840a906de30d6b2c96958d1e8ef8681a@buildbot.net>

#2007: Try --wait reports 'no build'
---------------------+--------------------
Reporter:  aslater   |       Owner:
    Type:  defect    |      Status:  new
Priority:  critical  |   Milestone:  0.8.5
 Version:  0.8.4p1   |  Resolution:
Keywords:  try       |
---------------------+--------------------

Comment (by dustin):

 Ugh, this is ugly and complex.  Previous comment is incorrect.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2007#comment:7>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Jul  4 06:21:39 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 04 Jul 2011 06:21:39 -0000
Subject: [Buildbot-commits] [Buildbot] #2005: SQLAlchemy Operational
 errors with SQLite: Database is locked
In-Reply-To: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net>
References: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net>
Message-ID: <055.cebfc8a4b7cf6357e1087dda224debd9@buildbot.net>

#2005: SQLAlchemy Operational errors with SQLite: Database is locked
---------------------+--------------------
Reporter:  abompard  |       Owner:
    Type:  defect    |      Status:  new
Priority:  critical  |   Milestone:  0.8.5
 Version:  0.8.4     |  Resolution:
Keywords:  database  |
---------------------+--------------------

Comment (by abompard):

 I'm using version 3.6.23.1. When adding pool_size=1, !BuibBot wont start
 and I get this message :
 {{{
 exceptions.TypeError: Invalid argument(s) 'pool_size' sent to
 create_engine(), using configuration
 SQLiteDialect_pysqlite/NullPool/TLEngine.  Please check that the keyword
 arguments are appropriate for this combination of components.
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2005#comment:9>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Mon Jul  4 23:39:46 2011
From: noreply at github.com (noreply at github.com)
Date: Mon, 4 Jul 2011 16:39:46 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 9a861e: Add getBuild to
	IProperties
Message-ID: <20110704233946.8D3C84238D@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 9a861eb624264659c05990ed3720fffc4eb361e6
      https://github.com/buildbot/buildbot/commit/9a861eb624264659c05990ed3720fffc4eb361e6
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-04 (Mon, 04 Jul 2011)

  Changed paths:
    M master/buildbot/interfaces.py
  M master/buildbot/process/build.py
  M master/buildbot/process/properties.py
  M master/buildbot/steps/source/oldsource.py
  M master/buildbot/test/unit/test_process_properties.py
  M master/buildbot/test/unit/test_steps_source_Source.py

  Log Message:
  -----------
  Add getBuild to IProperties

This lets users get access to the running build object, although that's
not advisable except in special events.


  Commit: e22c2adb2ac8272b958f0cf86bbd9789d9a8b818
      https://github.com/buildbot/buildbot/commit/e22c2adb2ac8272b958f0cf86bbd9789d9a8b818
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-04 (Mon, 04 Jul 2011)

  Changed paths:
    R master/buildbot/test/unit/test_steps_source_Repo.py
  R master/buildbot/test/unit/test_steps_source_Source.py
  A master/buildbot/test/unit/test_steps_source_oldsource_Repo.py
  A master/buildbot/test/unit/test_steps_source_oldsource_Source.py

  Log Message:
  -----------
  Rename tests for new source paths


  Commit: cd696cf64eb22549c93dd97e559c950f37a38859
      https://github.com/buildbot/buildbot/commit/cd696cf64eb22549c93dd97e559c950f37a38859
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-04 (Mon, 04 Jul 2011)

  Changed paths:
    M master/buildbot/test/regressions/test_oldpaths.py

  Log Message:
  -----------
  add oldpaths tests for old source step imports


Compare: https://github.com/buildbot/buildbot/compare/6bd279c...cd696cf



From nobody at buildbot.net  Tue Jul  5 08:15:19 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 05 Jul 2011 08:15:19 -0000
Subject: [Buildbot-commits] [Buildbot] #2036: sqlalchemy-migrate == 0.6 in
	master/setup.py
Message-ID: <040.0ee00df665de776536ff6c47cd19910c@buildbot.net>

#2036: sqlalchemy-migrate == 0.6 in master/setup.py
---------------------+-----------------------
Reporter:  makowski  |      Owner:
    Type:  defect    |     Status:  new
Priority:  major     |  Milestone:  undecided
 Version:  0.8.4p1   |   Keywords:
---------------------+-----------------------
 is sqlalchemy-migrate == 0.6 really mandatory ? or can it be sqlalchemy-
 migrate >= 0.6 ?

 because I package it for Mageia, and we have python-sqlalchemy-
 migrate-0.7.1

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2036>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Jul  5 10:10:45 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 05 Jul 2011 10:10:45 -0000
Subject: [Buildbot-commits] [Buildbot] #2034: web interface renders
 strange in gtkwebkit-based browsers
In-Reply-To: <038.c698624be25d79c4a20598fba3802d8f@buildbot.net>
References: <038.c698624be25d79c4a20598fba3802d8f@buildbot.net>
Message-ID: <053.15b7520c7b4c6b27a4cd41669ed8b9a1@buildbot.net>

#2034: web interface renders strange in gtkwebkit-based browsers
--------------------+--------------------
Reporter:  landry   |       Owner:
    Type:  defect   |      Status:  new
Priority:  major    |   Milestone:  0.8.+
 Version:  0.8.4p1  |  Resolution:
Keywords:           |
--------------------+--------------------

Comment (by landry):

 The issue seems to be on the css of a links. Any link renders garbled.
 Looking in gtkwebkit inspector, the computed css for links has :

 {{{
 background-attachment: scroll;
 background-clip: border-box;
 background-color: transparent;
 background-image: none;
 background-origin: padding-box;
 color: #444;
 cursor: auto;
 display: inline;
 font-family: Verdana, Cursor;
 font-size: 10px;
 font-weight: bold;
 height: 0px;
 margin-bottom: 0px;
 margin-left: 0px;
 margin-right: 0px;
 margin-top: 0px;
 padding-bottom: 0px;
 padding-left: 0px;
 padding-right: 0px;
 padding-top: 0px;
 text-decoration: underline;
 width: 0px;
 }}}

 width=0 might be the bug, but i don't see where it comes from in the css.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2034#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Jul  5 13:18:57 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 05 Jul 2011 13:18:57 -0000
Subject: [Buildbot-commits] [Buildbot] #2034: web interface renders
 strange in gtkwebkit-based browsers
In-Reply-To: <038.c698624be25d79c4a20598fba3802d8f@buildbot.net>
References: <038.c698624be25d79c4a20598fba3802d8f@buildbot.net>
Message-ID: <053.76837954d40a37122994a06b0982eadb@buildbot.net>

#2034: web interface renders strange in gtkwebkit-based browsers
--------------------+--------------------
Reporter:  landry   |       Owner:
    Type:  defect   |      Status:  new
Priority:  major    |   Milestone:  0.8.+
 Version:  0.8.4p1  |  Resolution:
Keywords:           |
--------------------+--------------------

Comment (by dustin):

 'width' is a box-model attribute, and a link is not a box element (pardon
 my incorrect terminology).  Firebug shows it as 'auto' for a link.

 Just to check, can you have a look at http://buildbot.buildbot.net/ and
 verify that it looks the same?

 This looks OK for me in Safari, but that's qtwebkit, right?  Why would the
 rendering backend make a difference in how the CSS is parsed?

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2034#comment:4>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Jul  5 14:59:43 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 05 Jul 2011 14:59:43 -0000
Subject: [Buildbot-commits] [Buildbot] #2034: web interface renders
 strange in gtkwebkit-based browsers
In-Reply-To: <038.c698624be25d79c4a20598fba3802d8f@buildbot.net>
References: <038.c698624be25d79c4a20598fba3802d8f@buildbot.net>
Message-ID: <053.ff76a76d4ab4cb322cafdd8b78e1989f@buildbot.net>

#2034: web interface renders strange in gtkwebkit-based browsers
--------------------+--------------------
Reporter:  landry   |       Owner:
    Type:  defect   |      Status:  new
Priority:  major    |   Milestone:  0.8.+
 Version:  0.8.4p1  |  Resolution:
Keywords:           |
--------------------+--------------------

Comment (by landry):

 http://buildbot.buildbot.net looks garbled too in midori.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2034#comment:5>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul  6 00:45:19 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 06 Jul 2011 00:45:19 -0000
Subject: [Buildbot-commits] [Buildbot] #2037: config reload events don't
 appear in waterfall (0.8.4p1)
Message-ID: <039.6ae46850a22f2b00923532cf8a0c8b97@buildbot.net>

#2037: config reload events don't appear in waterfall (0.8.4p1)
--------------------+-----------------------
Reporter:  dberger  |      Owner:
    Type:  defect   |     Status:  new
Priority:  minor    |  Milestone:  undecided
 Version:  0.8.4p1  |   Keywords:
--------------------+-----------------------
 we're using the debug client to reload the config, and formerly, we'd see
 a "config reloaded" in the waterfall.  in 0.8.4p1 this doesn't appear -
 leaving the operator to wonder if the operation worked.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2037>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul  6 01:06:55 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 06 Jul 2011 01:06:55 -0000
Subject: [Buildbot-commits] [Buildbot] #2035: _ComputeRepositoryURL
 requires more info than IProperties makes available
In-Reply-To: <038.404f84516979f12f2deabf2552822446@buildbot.net>
References: <038.404f84516979f12f2deabf2552822446@buildbot.net>
Message-ID: <053.12f44fbd4a67186c6f6d5f81bf4234dd@buildbot.net>

#2035: _ComputeRepositoryURL requires more info than IProperties makes available
--------------------+---------------------
Reporter:  dustin   |       Owner:
    Type:  defect   |      Status:  closed
Priority:  major    |   Milestone:  0.8.5
 Version:  0.8.4p1  |  Resolution:  fixed
Keywords:           |
--------------------+---------------------
Changes (by dustin):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 I fixed this in [9a861eb624264659c05990ed3720fffc4eb361e6] by adding a
 {{{getBuild}}} method to IProperties.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2035#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Wed Jul  6 01:09:25 2011
From: noreply at github.com (noreply at github.com)
Date: Tue, 5 Jul 2011 18:09:25 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 3e7f1b: Bugfixes for try's
	monitoring of builds in progres...
Message-ID: <20110706010925.E730D4230D@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 3e7f1be5398cc418c61153c6bdac8b99cecae732
      https://github.com/buildbot/buildbot/commit/3e7f1be5398cc418c61153c6bdac8b99cecae732
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-05 (Tue, 05 Jul 2011)

  Changed paths:
    M master/buildbot/process/builder.py
  M master/buildbot/status/buildrequest.py
  M master/buildbot/status/client.py
  M master/buildbot/status/master.py

  Log Message:
  -----------
  Bugfixes for try's monitoring of builds in progress

Fixes #2007.

Simplify Status.build_started to take the BuildStatus object, rather
than trying to look it up before its pickle is written to disk.

Correctly handle bdict's returned from db.builds.getBuildsForRequest.

Correctly handle remote errors in newbuild


  Commit: 38197545c0ee5737c7d179a236f92dbc7383d73f
      https://github.com/buildbot/buildbot/commit/38197545c0ee5737c7d179a236f92dbc7383d73f
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-05 (Tue, 05 Jul 2011)

  Changed paths:
    M master/buildbot/status/client.py

  Log Message:
  -----------
  Fix RemoteBuildRequest's unsubscription support

(although I don't believe this is ever called?)

Refs #2007


  Commit: b0aacce09d2a64acd56655c099adeaae0639063c
      https://github.com/buildbot/buildbot/commit/b0aacce09d2a64acd56655c099adeaae0639063c
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-05 (Tue, 05 Jul 2011)

  Changed paths:
    M master/buildbot/steps/shell.py
  M master/buildbot/test/unit/test_steps_shell.py

  Log Message:
  -----------
  add more tests for buildbot.steps.shell


Compare: https://github.com/buildbot/buildbot/compare/cd696cf...b0aacce



From nobody at buildbot.net  Wed Jul  6 01:09:32 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 06 Jul 2011 01:09:32 -0000
Subject: [Buildbot-commits] [Buildbot] #2007: Try --wait reports 'no
	build'
In-Reply-To: <039.a614a418fd328270547a8a19952a239c@buildbot.net>
References: <039.a614a418fd328270547a8a19952a239c@buildbot.net>
Message-ID: <054.fcfbeb599620e9caecb9d4adb77ef19a@buildbot.net>

#2007: Try --wait reports 'no build'
---------------------+---------------------
Reporter:  aslater   |       Owner:
    Type:  defect    |      Status:  closed
Priority:  critical  |   Milestone:  0.8.5
 Version:  0.8.4p1   |  Resolution:  fixed
Keywords:  try       |
---------------------+---------------------

Comment (by Dustin J. Mitchell):

 Fix RemoteBuildRequest's unsubscription support

 (although I don't believe this is ever called?)

 Refs #2007
  Changeset: 38197545c0ee5737c7d179a236f92dbc7383d73f

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2007#comment:9>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul  6 01:09:32 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 06 Jul 2011 01:09:32 -0000
Subject: [Buildbot-commits] [Buildbot] #2007: Try --wait reports 'no
	build'
In-Reply-To: <039.a614a418fd328270547a8a19952a239c@buildbot.net>
References: <039.a614a418fd328270547a8a19952a239c@buildbot.net>
Message-ID: <054.95df45e913eadef7e11ba889990f75cc@buildbot.net>

#2007: Try --wait reports 'no build'
---------------------+---------------------
Reporter:  aslater   |       Owner:
    Type:  defect    |      Status:  closed
Priority:  critical  |   Milestone:  0.8.5
 Version:  0.8.4p1   |  Resolution:  fixed
Keywords:  try       |
---------------------+---------------------
Changes (by Dustin J. Mitchell):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Bugfixes for try's monitoring of builds in progress

 Fixes #2007.

 Simplify Status.build_started to take the BuildStatus object, rather
 than trying to look it up before its pickle is written to disk.

 Correctly handle bdict's returned from db.builds.getBuildsForRequest.

 Correctly handle remote errors in newbuild
  Changeset: 3e7f1be5398cc418c61153c6bdac8b99cecae732

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2007#comment:8>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul  6 01:17:15 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 06 Jul 2011 01:17:15 -0000
Subject: [Buildbot-commits] [Buildbot] #2034: web interface renders
 strange in gtkwebkit-based browsers
In-Reply-To: <038.c698624be25d79c4a20598fba3802d8f@buildbot.net>
References: <038.c698624be25d79c4a20598fba3802d8f@buildbot.net>
Message-ID: <053.dc0c794221ef8da8edf606fae2153bc7@buildbot.net>

#2034: web interface renders strange in gtkwebkit-based browsers
--------------------+-------------------------
Reporter:  landry   |       Owner:
    Type:  defect   |      Status:  closed
Priority:  major    |   Milestone:  0.8.+
 Version:  0.8.4p1  |  Resolution:  worksforme
Keywords:           |
--------------------+-------------------------
Changes (by dustin):

 * status:  new => closed
 * resolution:   => worksforme


Comment:

 Well, AFAICT it's not a Buildbot bug, but a webkit bug.  Perhaps file it
 with them?  If you can point to the incorrect CSS, I'm happy to fix it,
 but as you said, there doesn't seem to be an obvious culprit.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2034#comment:6>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul  6 12:34:42 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 06 Jul 2011 12:34:42 -0000
Subject: [Buildbot-commits] [Buildbot] #2038: detect_bug1810.db appears to
	be missing
Message-ID: <041.86536ccdd8a90dbe0ab54b3e3a7e191b@buildbot.net>

#2038: detect_bug1810.db appears to be missing
----------------------+-----------------------
Reporter:  NateBragg  |      Owner:
    Type:  defect     |     Status:  new
Priority:  minor      |  Milestone:  undecided
 Version:  0.8.4p1    |   Keywords:  migration
----------------------+-----------------------
 when migrating from master 0.8.3p1 to 0.8.4p1 using buildbot upgrade-
 master, I get the traceback at bottom.

 It appears that it might be caused by a missing 'detect_bug1810.db'
 required by the test.


 {{{
 C:\>buildbot upgrade-master BuildBot
 upgrading basedir
 C:\BuildBot\public_html\default.css has old/modified contents
  writing new contents to C:\BuildBot\public_html\default.css.new
 checking master.cfg
 upgrading database
 Traceback (most recent call last):
   File "C:\Python27\lib\site-packages\twisted\internet\base.py", line 426,
 in _continueFiring
     callable(*args, **kwargs)
   File "C:\Python27\lib\site-
 packages\buildbot-0.8.4p1-py2.7.egg\buildbot\scripts\runner.py", line 36,
 in async
     d = defer.maybeDeferred(f, *args, **kwargs)
   File "C:\Python27\lib\site-packages\twisted\internet\defer.py", line
 133, in maybeDeferred
     result = f(*args, **kw)
   File "C:\Python27\lib\site-packages\twisted\internet\defer.py", line
 964, in unwindGenerator
     return _deferGenerator(f(*args, **kwargs), Deferred())
 --- <exception caught here> ---
   File "C:\Python27\lib\site-packages\twisted\internet\defer.py", line
 866, in _deferGenerator
     result = g.next()
   File "C:\Python27\lib\site-
 packages\buildbot-0.8.4p1-py2.7.egg\buildbot\scripts\runner.py", line 499,
 in upgradeMaste

     basedir=config['basedir'])
   File "C:\Python27\lib\site-
 packages\buildbot-0.8.4p1-py2.7.egg\buildbot\db\connector.py", line 43, in
 __init__
     self.pool = pool.DBThreadPool(self._engine)
   File "C:\Python27\lib\site-
 packages\buildbot-0.8.4p1-py2.7.egg\buildbot\db\pool.py", line 73, in
 __init__
     self.__broken_sqlite = self.detect_bug1810()
   File "C:\Python27\lib\site-
 packages\buildbot-0.8.4p1-py2.7.egg\buildbot\db\pool.py", line 210, in
 detect_bug1810
     test()
   File "C:\Python27\lib\site-
 packages\buildbot-0.8.4p1-py2.7.egg\buildbot\db\pool.py", line 205, in
 test
     conn1.close()
 exceptions.UnboundLocalError: local variable 'conn1' referenced before
 assignment
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2038>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul  6 13:13:53 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 06 Jul 2011 13:13:53 -0000
Subject: [Buildbot-commits] [Buildbot] #2038: detect_bug1810.db appears
	to be missing
In-Reply-To: <041.86536ccdd8a90dbe0ab54b3e3a7e191b@buildbot.net>
References: <041.86536ccdd8a90dbe0ab54b3e3a7e191b@buildbot.net>
Message-ID: <056.b7945d45b79c4d63ded1ea84dab8b04a@buildbot.net>

#2038: detect_bug1810.db appears to be missing
----------------------+------------------------
Reporter:  NateBragg  |       Owner:
    Type:  defect     |      Status:  closed
Priority:  minor      |   Milestone:  undecided
 Version:  0.8.4p1    |  Resolution:  duplicate
Keywords:  migration  |
----------------------+------------------------
Changes (by dustin):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 Actually, it's a permissions problem - #2016

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2038#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul  6 15:08:25 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 06 Jul 2011 15:08:25 -0000
Subject: [Buildbot-commits] [Buildbot] #2037: config reload events don't
 appear in waterfall (0.8.4p1)
In-Reply-To: <039.6ae46850a22f2b00923532cf8a0c8b97@buildbot.net>
References: <039.6ae46850a22f2b00923532cf8a0c8b97@buildbot.net>
Message-ID: <054.5a7fe420070d657eed5a9bbd6c007547@buildbot.net>

#2037: config reload events don't appear in waterfall (0.8.4p1)
--------------------+------------------------
Reporter:  dberger  |       Owner:
    Type:  defect   |      Status:  closed
Priority:  minor    |   Milestone:  undecided
 Version:  0.8.4p1  |  Resolution:  invalid
Keywords:           |
--------------------+------------------------
Changes (by dberger):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 RTFM'd

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2037#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul  6 15:08:56 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 06 Jul 2011 15:08:56 -0000
Subject: [Buildbot-commits] [Buildbot] #2039: rmdir slaveside command return
	0 even if it fails
Message-ID: <038.56d9b51ea9a24a4c7d33d12bbed7fa00@buildbot.net>

#2039: rmdir slaveside command return 0 even if it fails
----------------------+-----------------------
Reporter:  in3xes     |      Owner:
    Type:  undecided  |     Status:  new
Priority:  minor      |  Milestone:  undecided
 Version:  0.8.4p1    |   Keywords:
----------------------+-----------------------
 https://github.com/buildbot/buildbot/blob/master/slave/buildslave/commands/fs.py#L91

 Ideally it should send whatever the command returns.

 after digging little deeper, _abandonOnFailure is also not catching it.
 because of '-f' on argument in 'rm -rf' returns 0 if path of the file
 specified is invalid.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2039>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul  6 15:08:59 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 06 Jul 2011 15:08:59 -0000
Subject: [Buildbot-commits] [Buildbot] #2037: config reload events don't
 appear in waterfall (0.8.4p1)
In-Reply-To: <039.6ae46850a22f2b00923532cf8a0c8b97@buildbot.net>
References: <039.6ae46850a22f2b00923532cf8a0c8b97@buildbot.net>
Message-ID: <054.f14104492006592855129e9225f3ecc9@buildbot.net>

#2037: config reload events don't appear in waterfall (0.8.4p1)
--------------------+------------------------
Reporter:  dberger  |       Owner:
    Type:  defect   |      Status:  closed
Priority:  minor    |   Milestone:  undecided
 Version:  0.8.4p1  |  Resolution:  invalid
Keywords:           |
--------------------+------------------------

Comment (by dberger):

 (for others who might find this bug - add show_events=true as a query
 param to the waterfall view to get back all the non-build events.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2037#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul  6 18:54:41 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 06 Jul 2011 18:54:41 -0000
Subject: [Buildbot-commits] [Buildbot] #2040: .buildbot-sourcedata sometimes
 contains unicode strings, causes full resync during builds
Message-ID: <039.e2dfc7e03f4bac40bf542d88dc6c9bb4@buildbot.net>

#2040: .buildbot-sourcedata sometimes contains unicode strings, causes full resync
during builds
--------------------+-----------------------
Reporter:  dberger  |      Owner:
    Type:  defect   |     Status:  new
Priority:  major    |  Milestone:  undecided
 Version:  0.8.4p1  |   Keywords:
--------------------+-----------------------
 we don't have a perfect repro yet, but we noticed that some of our
 upgraded builders (0.7.11p3 -> 0.8.4p1) like to do full resyncs on force
 builds and after build failures.  a newly created builder hasn't exhibited
 this problem.

 we're using perforce.

 after much tracking down, it looks like the common thread is that the
 misbehaving builders have u'/perforce/branch/path' in their buildbot-
 sourcedata file, rather than '/perforce/branch/path' - which suggests that
 args['branch'] is coming in unicode, and being written to the file that
 way.

 If/as we learn more, I'll update the ticket.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2040>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul  6 19:10:55 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 06 Jul 2011 19:10:55 -0000
Subject: [Buildbot-commits] [Buildbot] #2040: .buildbot-sourcedata
 sometimes contains unicode strings, causes full resync during builds
In-Reply-To: <039.e2dfc7e03f4bac40bf542d88dc6c9bb4@buildbot.net>
References: <039.e2dfc7e03f4bac40bf542d88dc6c9bb4@buildbot.net>
Message-ID: <054.1a1add84d90537e0da864c2bdd65e672@buildbot.net>

#2040: .buildbot-sourcedata sometimes contains unicode strings, causes full resync
during builds
--------------------+------------------------
Reporter:  dberger  |       Owner:
    Type:  defect   |      Status:  new
Priority:  major    |   Milestone:  undecided
 Version:  0.8.4p1  |  Resolution:
Keywords:           |
--------------------+------------------------

Comment (by dberger):

 we manually fixed a couple buildbot-sourceinfo files on windows builders,
 and they didn't force-sync on a force build.  performing the same
 transformation on linux/mac builders didn't fix it, so there's more going
 on here.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2040#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Thu Jul  7 17:01:35 2011
From: nobody at buildbot.net (Buildbot)
Date: Thu, 07 Jul 2011 17:01:35 -0000
Subject: [Buildbot-commits] [Buildbot] #921: buildmaster logging should
	be more segregated
In-Reply-To: <040.f26eb6b5fa73609c33c0d37dc50714a3@buildbot.net>
References: <040.f26eb6b5fa73609c33c0d37dc50714a3@buildbot.net>
Message-ID: <055.9d80c80152be78e479f3b8f5682ac0bb@buildbot.net>

#921: buildmaster logging should be more segregated
------------------------+--------------------
Reporter:  bhearsum     |       Owner:
    Type:  enhancement  |      Status:  new
Priority:  major        |   Milestone:  0.8.+
 Version:  0.8.0        |  Resolution:
Keywords:               |
------------------------+--------------------

Comment (by dustin):

 This is pretty hard to do, and would make correlating events even harder,
 since you only get second-level granularity in the logfiles.

 I think a better fix is to adjust the kind of logging that builds do.
 Right now, there's a lot of redundant information about which methods are
 being called, and very little useful information.  That could probably be
 condensed down to one line (starting step 'foo' of 'buildername' build
 #NNN), which would make things a bit easier to follow.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/921#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Thu Jul  7 17:05:50 2011
From: nobody at buildbot.net (Buildbot)
Date: Thu, 07 Jul 2011 17:05:50 -0000
Subject: [Buildbot-commits] [Buildbot] #1958: Monkey-patch Twisted
	memory leak
In-Reply-To: <038.72b04799a36bfce9741b72578a235918@buildbot.net>
References: <038.72b04799a36bfce9741b72578a235918@buildbot.net>
Message-ID: <053.354d0e79bfd8c2edf75a37c1cf107fe6@buildbot.net>

#1958: Monkey-patch Twisted memory leak
------------------------+---------------------
Reporter:  dustin       |       Owner:  dustin
    Type:  enhancement  |      Status:  closed
Priority:  major        |   Milestone:  0.8.+
 Version:  master       |  Resolution:  fixed
Keywords:  performance  |
------------------------+---------------------
Changes (by dustin):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 I haven't seen any problems, so let's call it fixed.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1958#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Thu Jul  7 17:51:21 2011
From: nobody at buildbot.net (Buildbot)
Date: Thu, 07 Jul 2011 17:51:21 -0000
Subject: [Buildbot-commits] [Buildbot] #1052: blamelist lost via trigger
In-Reply-To: <039.c1a1ed20af5a431c7d00e91345a91371@buildbot.net>
References: <039.c1a1ed20af5a431c7d00e91345a91371@buildbot.net>
Message-ID: <054.d250730e9475c245ca1189344692649d@buildbot.net>

#1052: blamelist lost via trigger
--------------------+-----------------------
Reporter:  qzhwang  |       Owner:
    Type:  defect   |      Status:  reopened
Priority:  major    |   Milestone:  0.8.2
 Version:  0.8.1    |  Resolution:
Keywords:           |
--------------------+-----------------------

Comment (by dberger):

 I believe this got regressed by
 https://github.com/buildbot/buildbot/commit/247e60aadbb53f508fa53c21f798bf80757e7fb1
 - updateSourceStamp is always being set to true, 'cause of this boolean
 logic:

 self.updateSourceStamp = updateSourceStamp or not (alwaysUseLatest or
 sourceStamp)

 so if I give it updateSourceStamp = False, alwaysUseLatest = False,
 sourceStamp = None

 False or not ( False or None ) = False or not ( False ) = False or True =
 True

 exactly the opposite of the intended/desired behavior.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1052#comment:7>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Thu Jul  7 18:12:10 2011
From: noreply at github.com (noreply at github.com)
Date: Thu, 7 Jul 2011 11:12:10 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 2ed4b9: fix typo in tutorial
Message-ID: <20110707181210.153B44219D@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 2ed4b9a201f71c12886115e12e47929d4b7d8ae6
      https://github.com/buildbot/buildbot/commit/2ed4b9a201f71c12886115e12e47929d4b7d8ae6
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-07 (Thu, 07 Jul 2011)

  Changed paths:
    M master/docs/tutorial/firstrun.txt

  Log Message:
  -----------
  fix typo in tutorial





From nobody at buildbot.net  Fri Jul  8 10:48:16 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 08 Jul 2011 10:48:16 -0000
Subject: [Buildbot-commits] [Buildbot] #971: Build a windows installer
In-Reply-To: <038.6c763d0f053bc258fcb2f8f99b00326c@buildbot.net>
References: <038.6c763d0f053bc258fcb2f8f99b00326c@buildbot.net>
Message-ID: <053.a4038a943b989cde1959d13cf78bd5a2@buildbot.net>

#971: Build a windows installer
------------------------+-----------------------
Reporter:  dustin       |       Owner:  fatman2
    Type:  enhancement  |      Status:  accepted
Priority:  major        |   Milestone:  0.8.+
 Version:               |  Resolution:
Keywords:  windows      |
------------------------+-----------------------
Changes (by jollyroger):

 * cc: jolly_roger@? (added)


Comment:

 Just in case we didn't missed the thing. We can use
 {{{
 python.exe setup.py bdist --format=msi
 }}}
 to get an correct msi installer right from our sources with no significant
 effort! However there is a problem with minor versions and nightly builds:
 version should be in format `[0-9.]+` so I managed build installer for
 0.8.4 but could not build it for 0.8.3p1.

 Installer correctly detects installed Python versions and can be installed
 into custom path too (e.g. you will be available to install it under
 virtualenv, but just once). The installer also doesn't detect
 dependencies. Uninstaller in this case removes all installed buildbot
 instances at once, so I recommend to install buildslave only system-wide
 with this method.

 I won't attach the installer itself ? you'll be able to build it on any
 windows box having buildbot sources and installed Python.

 If we need more complicated installer, than NSIS is the right choice. But
 at least we could suggest developers of Zope.Interface and other our
 dependencies and useful tools to make binary builds and publish them OR we
 could download such dependencies' sources, build installer during
 installation and install them. The latter method is already tested by
 myself for virtualenv and Zope.Interface. This will surely work for pure
 python packages and even twisted creates such installers (the msi ones,
 not exe) but binary modules is another talk.

 I also tried to build installer under wine and it works under wine ONLY.
 However nsis installers built under linux work in windows fine.

 '''fatman''', if you're working on this still and you're not against
 someone's help, please get in touch with me to cooperate on this task (my
 nickname on github is the same as here).

-- 
Ticket URL: <http://trac.buildbot.net/ticket/971#comment:16>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Jul  8 20:38:20 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 08 Jul 2011 20:38:20 -0000
Subject: [Buildbot-commits] [Buildbot] #971: Build a windows installer
In-Reply-To: <038.6c763d0f053bc258fcb2f8f99b00326c@buildbot.net>
References: <038.6c763d0f053bc258fcb2f8f99b00326c@buildbot.net>
Message-ID: <053.67de041dc00cbf76beaefa2b96e7c8ae@buildbot.net>

#971: Build a windows installer
------------------------+-----------------------
Reporter:  dustin       |       Owner:  fatman2
    Type:  enhancement  |      Status:  accepted
Priority:  major        |   Milestone:  0.8.+
 Version:               |  Resolution:
Keywords:  windows      |
------------------------+-----------------------

Comment (by dustin):

 I'd love to see this moving forward, and I think that the MSI strategy is
 much more likely to lead to success quickly than NSIS.  I think that
 getting support from all of the upstream projects to create MSIs will not
 be possible, so bundling the deps into the MSI is probably the best idea.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/971#comment:17>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Fri Jul  8 23:08:22 2011
From: noreply at github.com (noreply at github.com)
Date: Fri, 8 Jul 2011 16:08:22 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] ae840d: Create the bug-test
	DB in a temporary dir
Message-ID: <20110708230822.A5B9C424F8@smtp1.rs.github.com>

  Branch: refs/heads/buildbot-0.8.4
  Home:   https://github.com/buildbot/buildbot

  Commit: ae840d30e7dd3313ad26d129e3f463d55907bd3c
      https://github.com/buildbot/buildbot/commit/ae840d30e7dd3313ad26d129e3f463d55907bd3c
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-08 (Fri, 08 Jul 2011)

  Changed paths:
    M master/buildbot/db/pool.py

  Log Message:
  -----------
  Create the bug-test DB in a temporary dir

Fixes #2016.

Conflicts in merge to buildbot-0.8.4:
	master/buildbot/db/pool.py





From nobody at buildbot.net  Fri Jul  8 23:08:28 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 08 Jul 2011 23:08:28 -0000
Subject: [Buildbot-commits] [Buildbot] #2016: upgrade-master errror:
 local variable conn1 referenced before assignment
In-Reply-To: <039.80f57d0b806c72443eb0ad31915359ba@buildbot.net>
References: <039.80f57d0b806c72443eb0ad31915359ba@buildbot.net>
Message-ID: <054.e0a356a50ae2db62abd49ae71cc6b006@buildbot.net>

#2016: upgrade-master errror: local variable conn1 referenced before assignment
--------------------+------------------------
Reporter:  cortana  |       Owner:
    Type:  defect   |      Status:  closed
Priority:  major    |   Milestone:  undecided
 Version:  0.8.4p1  |  Resolution:  fixed
Keywords:           |
--------------------+------------------------

Comment (by Dustin J. Mitchell):

 Create the bug-test DB in a temporary dir

 Fixes #2016.

 Conflicts in merge to buildbot-0.8.4:
         master/buildbot/db/pool.py
  Changeset: ae840d30e7dd3313ad26d129e3f463d55907bd3c

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2016#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Fri Jul  8 23:29:14 2011
From: noreply at github.com (noreply at github.com)
Date: Fri, 8 Jul 2011 16:29:14 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 9b032e: Git source steps
	completed
Message-ID: <20110708232914.3C0E642405@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 9b032e6ac17575841032c3a3c8a0def5da7fe569
      https://github.com/buildbot/buildbot/commit/9b032e6ac17575841032c3a3c8a0def5da7fe569
  Author: Pradeepkumar Gayam <in3xes at gmail.com>
  Date:   2011-07-07 (Thu, 07 Jul 2011)

  Changed paths:
    A master/buildbot/steps/source/git.py
  A master/buildbot/test/unit/test_steps_source_git.py
  M master/docs/cfg-buildsteps.texinfo

  Log Message:
  -----------
  Git source steps completed


  Commit: d17481bcd4ab9deb8a8d93fb58b73852ec7b22dd
      https://github.com/buildbot/buildbot/commit/d17481bcd4ab9deb8a8d93fb58b73852ec7b22dd
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-08 (Fri, 08 Jul 2011)

  Changed paths:
    M master/buildbot/steps/source/git.py

  Log Message:
  -----------
  fix pyflakes


  Commit: e2a8cf40eef19f2d78887a684f3ecf85caeafbb1
      https://github.com/buildbot/buildbot/commit/e2a8cf40eef19f2d78887a684f3ecf85caeafbb1
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-08 (Fri, 08 Jul 2011)

  Changed paths:
    A master/buildbot/steps/source/git.py
  A master/buildbot/test/unit/test_steps_source_git.py
  M master/docs/cfg-buildsteps.texinfo

  Log Message:
  -----------
  Merge branch 'gsoc_commit'

* gsoc_commit:
  fix pyflakes
  Git source steps completed


Compare: https://github.com/buildbot/buildbot/compare/2ed4b9a...e2a8cf4



From noreply at github.com  Fri Jul  8 23:34:27 2011
From: noreply at github.com (noreply at github.com)
Date: Fri, 8 Jul 2011 16:34:27 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] ccf6c1: gerritchangesource:
	use gerrit's changeid as the b...
Message-ID: <20110708233427.3E05B423E4@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: ccf6c117ca8c93fc9723b3b9c382f50c8086445d
      https://github.com/buildbot/buildbot/commit/ccf6c117ca8c93fc9723b3b9c382f50c8086445d
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2011-07-08 (Fri, 08 Jul 2011)

  Changed paths:
    M master/buildbot/changes/gerritchangesource.py
  M master/buildbot/test/unit/test_changes_gerritchangesource.py

  Log Message:
  -----------
  gerritchangesource: use gerrit's changeid as the branch

in order to make one build by change (and not concatenate)
also update the unittest

Signed-off-by: Pierre Tardy <pierre.tardy at intel.com>





From noreply at github.com  Fri Jul  8 23:36:13 2011
From: noreply at github.com (noreply at github.com)
Date: Fri, 8 Jul 2011 16:36:13 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] d9ebe7: status_gerrit:
	replace quotes by double quotes in ...
Message-ID: <20110708233612.F1B9B4250A@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: d9ebe7348eb50fa400f3b6ce514acc5b58d62b7e
      https://github.com/buildbot/buildbot/commit/d9ebe7348eb50fa400f3b6ce514acc5b58d62b7e
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2011-07-08 (Fri, 08 Jul 2011)

  Changed paths:
    M master/buildbot/status/status_gerrit.py

  Log Message:
  -----------
  status_gerrit: replace quotes by double quotes in message

having quotes in message will confuse the ssh server





From noreply at github.com  Fri Jul  8 23:36:45 2011
From: noreply at github.com (noreply at github.com)
Date: Fri, 8 Jul 2011 16:36:45 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] f591d3: Trigger: dont fail
	if copied property does not exi...
Message-ID: <20110708233645.ADDAA424E9@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: f591d3369270b7897989c242fa7b827ca58b07b7
      https://github.com/buildbot/buildbot/commit/f591d3369270b7897989c242fa7b827ca58b07b7
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2011-07-08 (Fri, 08 Jul 2011)

  Changed paths:
    M master/buildbot/steps/trigger.py

  Log Message:
  -----------
  Trigger: dont fail if copied property does not exist

user might want to inherit properties that are only set in certain condition,
e.g forced_builds.

So there is no reason to force failure if copy property does not exist

Signed-off-by: Pierre Tardy <pierre.tardy at intel.com>





From noreply at github.com  Fri Jul  8 23:38:21 2011
From: noreply at github.com (noreply at github.com)
Date: Fri, 8 Jul 2011 16:38:21 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] abf8b6: slave/repo: dont
	clobber if cherry-pick fails
Message-ID: <20110708233821.2101B424DB@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: abf8b6d0a38cd942a84675459a726462343964a5
      https://github.com/buildbot/buildbot/commit/abf8b6d0a38cd942a84675459a726462343964a5
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2011-07-08 (Fri, 08 Jul 2011)

  Changed paths:
    M slave/buildslave/commands/repo.py

  Log Message:
  -----------
  slave/repo: dont clobber if cherry-pick fails

we rather print the git diff for everything to get a change to find out what does not merge

Signed-off-by: Pierre Tardy <pierre.tardy at intel.com>





From noreply at github.com  Fri Jul  8 23:39:25 2011
From: noreply at github.com (noreply at github.com)
Date: Fri, 8 Jul 2011 16:39:25 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 57d5ee: slave/repo: reset
	the tree in case some cherry-pic...
Message-ID: <20110708233925.DECB8423A1@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 57d5ee1d03b4b46660b64c8b86203e4db3c7a836
      https://github.com/buildbot/buildbot/commit/57d5ee1d03b4b46660b64c8b86203e4db3c7a836
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2011-07-08 (Fri, 08 Jul 2011)

  Changed paths:
    M slave/buildslave/commands/repo.py

  Log Message:
  -----------
  slave/repo: reset the tree in case some cherry-picked failed before

git clean is not enough if there are unmerged change in the repo :-(

Signed-off-by: Pierre Tardy <pierre.tardy at intel.com>





From noreply at github.com  Fri Jul  8 23:43:08 2011
From: noreply at github.com (noreply at github.com)
Date: Fri, 8 Jul 2011 16:43:08 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] ecef1b: gerritchangesource:
	factorize to allow subclassing
Message-ID: <20110708234308.8AA0F424E9@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: ecef1b02ffb3c26928e0dba3928fbee522244504
      https://github.com/buildbot/buildbot/commit/ecef1b02ffb3c26928e0dba3928fbee522244504
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2011-07-08 (Fri, 08 Jul 2011)

  Changed paths:
    M master/buildbot/changes/gerritchangesource.py

  Log Message:
  -----------
  gerritchangesource: factorize to allow subclassing

its not possible to customize what to do on gerrit events
We refactor a bit the code, in order to call different method of
the class for each event type.

Old behaviour is still working

Signed-off-by: Pierre Tardy <pierre.tardy at intel.com>


  Commit: 8f95de90351be00f59df3caf4997830adfc72e2a
      https://github.com/buildbot/buildbot/commit/8f95de90351be00f59df3caf4997830adfc72e2a
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2011-07-08 (Fri, 08 Jul 2011)

  Changed paths:
    M master/buildbot/steps/source/oldsource.py

  Log Message:
  -----------
  repo_source: added buildDownloadList method

This method can be overidden by config file,
so that the config file can query some databases
(like gerrit or bugzilla)
in order to find out dependancies for a particular change

Signed-off-by: Pierre Tardy <pierre.tardy at intel.com>


Compare: https://github.com/buildbot/buildbot/compare/57d5ee1...8f95de9



From nobody at buildbot.net  Sat Jul  9 00:06:39 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 09 Jul 2011 00:06:39 -0000
Subject: [Buildbot-commits] [Buildbot] #2005: SQLAlchemy Operational
 errors with SQLite: Database is locked
In-Reply-To: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net>
References: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net>
Message-ID: <055.7ed3e0a77fb9fb28158e7c6a96f048cd@buildbot.net>

#2005: SQLAlchemy Operational errors with SQLite: Database is locked
---------------------+--------------------
Reporter:  abompard  |       Owner:
    Type:  defect    |      Status:  new
Priority:  critical  |   Milestone:  0.8.5
 Version:  0.8.4     |  Resolution:
Keywords:  database  |
---------------------+--------------------

Comment (by dustin):

 I wonder if this is possibility number 4?
   fcntl(3, F_SETLK call on DB file fails. This could be caused by an NFS
 locking issue, for example. One solution for this issue, is to mv the DB
 away, and copy it back so that it has a new Inode value.

 I really can't see any other way to get this error in such a modern
 version.

 I'm working on a way to specify the concurrency level -- pool_size was not
 it, sorry.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2005#comment:10>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Sat Jul  9 00:14:42 2011
From: noreply at github.com (noreply at github.com)
Date: Fri, 8 Jul 2011 17:14:42 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 2c58b9: Add the ability to
	specify serialized access in sq...
Message-ID: <20110709001442.E858042448@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 2c58b952ae93c45ee5bfe37f6cf70043da8b5d70
      https://github.com/buildbot/buildbot/commit/2c58b952ae93c45ee5bfe37f6cf70043da8b5d70
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-08 (Fri, 08 Jul 2011)

  Changed paths:
    M master/buildbot/db/enginestrategy.py
  M master/docs/cfg-global.texinfo

  Log Message:
  -----------
  Add the ability to specify serialized access in sqlite

(Refs #2005) this can be useful for database-locked errors.





From nobody at buildbot.net  Sat Jul  9 00:14:50 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 09 Jul 2011 00:14:50 -0000
Subject: [Buildbot-commits] [Buildbot] #2005: SQLAlchemy Operational
 errors with SQLite: Database is locked
In-Reply-To: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net>
References: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net>
Message-ID: <055.736a85fda717ee37666f3a27f71f130b@buildbot.net>

#2005: SQLAlchemy Operational errors with SQLite: Database is locked
---------------------+--------------------
Reporter:  abompard  |       Owner:
    Type:  defect    |      Status:  new
Priority:  critical  |   Milestone:  0.8.5
 Version:  0.8.4     |  Resolution:
Keywords:  database  |
---------------------+--------------------

Comment (by Dustin J. Mitchell):

 Add the ability to specify serialized access in sqlite

 (Refs #2005) this can be useful for database-locked errors.
  Changeset: 2c58b952ae93c45ee5bfe37f6cf70043da8b5d70

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2005#comment:11>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Sat Jul  9 00:17:52 2011
From: noreply at github.com (noreply at github.com)
Date: Fri, 8 Jul 2011 17:17:52 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 75c722: Bugfixes for try's
	monitoring of builds in progres...
Message-ID: <20110709001752.C4B6142448@smtp1.rs.github.com>

  Branch: refs/heads/buildbot-0.8.4
  Home:   https://github.com/buildbot/buildbot

  Commit: 75c7229de6af939df2e06c04d4c870f1e2d53f83
      https://github.com/buildbot/buildbot/commit/75c7229de6af939df2e06c04d4c870f1e2d53f83
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-08 (Fri, 08 Jul 2011)

  Changed paths:
    M master/buildbot/process/builder.py
  M master/buildbot/status/buildrequest.py
  M master/buildbot/status/client.py
  M master/buildbot/status/master.py

  Log Message:
  -----------
  Bugfixes for try's monitoring of builds in progress

Fixes #2007.

Simplify Status.build_started to take the BuildStatus object, rather
than trying to look it up before its pickle is written to disk.

Correctly handle bdict's returned from db.builds.getBuildsForRequest.

Correctly handle remote errors in newbuild


  Commit: 49a0d1d7565f7c477e48ed4c43d125e0bde0d7a4
      https://github.com/buildbot/buildbot/commit/49a0d1d7565f7c477e48ed4c43d125e0bde0d7a4
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-08 (Fri, 08 Jul 2011)

  Changed paths:
    M master/buildbot/status/client.py

  Log Message:
  -----------
  Fix RemoteBuildRequest's unsubscription support

(although I don't believe this is ever called?)

Refs #2007


Compare: https://github.com/buildbot/buildbot/compare/ae840d3...49a0d1d



From nobody at buildbot.net  Sat Jul  9 00:18:00 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 09 Jul 2011 00:18:00 -0000
Subject: [Buildbot-commits] [Buildbot] #2007: Try --wait reports 'no
	build'
In-Reply-To: <039.a614a418fd328270547a8a19952a239c@buildbot.net>
References: <039.a614a418fd328270547a8a19952a239c@buildbot.net>
Message-ID: <054.1dd03221d6c147943b494b9ae35c62dd@buildbot.net>

#2007: Try --wait reports 'no build'
---------------------+---------------------
Reporter:  aslater   |       Owner:
    Type:  defect    |      Status:  closed
Priority:  critical  |   Milestone:  0.8.5
 Version:  0.8.4p1   |  Resolution:  fixed
Keywords:  try       |
---------------------+---------------------

Comment (by Dustin J. Mitchell):

 Bugfixes for try's monitoring of builds in progress

 Fixes #2007.

 Simplify Status.build_started to take the BuildStatus object, rather
 than trying to look it up before its pickle is written to disk.

 Correctly handle bdict's returned from db.builds.getBuildsForRequest.

 Correctly handle remote errors in newbuild
  Changeset: 75c7229de6af939df2e06c04d4c870f1e2d53f83

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2007#comment:10>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Jul  9 00:18:01 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 09 Jul 2011 00:18:01 -0000
Subject: [Buildbot-commits] [Buildbot] #2007: Try --wait reports 'no
	build'
In-Reply-To: <039.a614a418fd328270547a8a19952a239c@buildbot.net>
References: <039.a614a418fd328270547a8a19952a239c@buildbot.net>
Message-ID: <054.c1373ebc82dfdf0b04731a2227d7e16b@buildbot.net>

#2007: Try --wait reports 'no build'
---------------------+---------------------
Reporter:  aslater   |       Owner:
    Type:  defect    |      Status:  closed
Priority:  critical  |   Milestone:  0.8.5
 Version:  0.8.4p1   |  Resolution:  fixed
Keywords:  try       |
---------------------+---------------------

Comment (by Dustin J. Mitchell):

 Fix RemoteBuildRequest's unsubscription support

 (although I don't believe this is ever called?)

 Refs #2007
  Changeset: 49a0d1d7565f7c477e48ed4c43d125e0bde0d7a4

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2007#comment:11>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Jul  9 01:03:16 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 09 Jul 2011 01:03:16 -0000
Subject: [Buildbot-commits] [Buildbot] #2029: inconsistent state for a
	builder
In-Reply-To: <038.0ec0eedaf7f7533481c7654bf20f43b9@buildbot.net>
References: <038.0ec0eedaf7f7533481c7654bf20f43b9@buildbot.net>
Message-ID: <053.82df30917eb94b5bd3d81ff821ce61a4@buildbot.net>

#2029: inconsistent state for a builder
--------------------+--------------------
Reporter:  dustin   |       Owner:
    Type:  defect   |      Status:  new
Priority:  major    |   Milestone:  0.8.5
 Version:  0.8.4p1  |  Resolution:
Keywords:           |
--------------------+--------------------

Comment (by dustin):

 OK, it looks like this happens when the pre-build ping fails.  It would
 probably also happen if the remote startBuild method fails.  Some
 refactoring of {{{_startBuildFor}}} is called for.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2029#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Jul  9 07:15:42 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 09 Jul 2011 07:15:42 -0000
Subject: [Buildbot-commits] [Buildbot] #2005: SQLAlchemy Operational
 errors with SQLite: Database is locked
In-Reply-To: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net>
References: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net>
Message-ID: <055.242144454b627c991148b02bc84514d9@buildbot.net>

#2005: SQLAlchemy Operational errors with SQLite: Database is locked
---------------------+--------------------
Reporter:  abompard  |       Owner:
    Type:  defect    |      Status:  new
Priority:  critical  |   Milestone:  0.8.5
 Version:  0.8.4     |  Resolution:
Keywords:  database  |
---------------------+--------------------

Comment (by abompard):

 Well, I have migrated to PostgreSQL, so this bug can be closed, unless you
 want me to investigate some more (since apparently I'm the only one able
 to reproduce it...)

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2005#comment:12>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Jul  9 14:41:20 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 09 Jul 2011 14:41:20 -0000
Subject: [Buildbot-commits] [Buildbot] #2005: SQLAlchemy Operational
 errors with SQLite: Database is locked
In-Reply-To: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net>
References: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net>
Message-ID: <055.9afc1d4afd01e7d6f28c356345eacbe1@buildbot.net>

#2005: SQLAlchemy Operational errors with SQLite: Database is locked
---------------------+-------------------------
Reporter:  abompard  |       Owner:
    Type:  defect    |      Status:  closed
Priority:  critical  |   Milestone:  0.8.5
 Version:  0.8.4     |  Resolution:  worksforme
Keywords:  database  |
---------------------+-------------------------
Changes (by dustin):

 * status:  new => closed
 * resolution:   => worksforme


Comment:

 That sounds like a great solution!  I'll call it worksforme, but if others
 see it, let's re-open.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2005#comment:13>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Sat Jul  9 14:42:47 2011
From: noreply at github.com (noreply at github.com)
Date: Sat, 9 Jul 2011 07:42:47 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 9ddc43: refactor
	_startBuildFor to handle failure better
Message-ID: <20110709144247.1C3744252A@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 9ddc435937fc6114459a7535a94a8ece4b8f92b1
      https://github.com/buildbot/buildbot/commit/9ddc435937fc6114459a7535a94a8ece4b8f92b1
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-08 (Fri, 08 Jul 2011)

  Changed paths:
    M master/buildbot/process/builder.py
  M master/buildbot/test/unit/test_process_builder.py

  Log Message:
  -----------
  refactor _startBuildFor to handle failure better

When the ping fails, this now properly clears out the partially-set-up
build, which would otherwise hang around forever.  Fixes #2029.





From nobody at buildbot.net  Sat Jul  9 14:42:52 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 09 Jul 2011 14:42:52 -0000
Subject: [Buildbot-commits] [Buildbot] #2029: inconsistent state for a
	builder
In-Reply-To: <038.0ec0eedaf7f7533481c7654bf20f43b9@buildbot.net>
References: <038.0ec0eedaf7f7533481c7654bf20f43b9@buildbot.net>
Message-ID: <053.11a166b8eb695a8084e576be3eb84714@buildbot.net>

#2029: inconsistent state for a builder
--------------------+---------------------
Reporter:  dustin   |       Owner:
    Type:  defect   |      Status:  closed
Priority:  major    |   Milestone:  0.8.5
 Version:  0.8.4p1  |  Resolution:  fixed
Keywords:           |
--------------------+---------------------
Changes (by Dustin J. Mitchell):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 refactor _startBuildFor to handle failure better

 When the ping fails, this now properly clears out the partially-set-up
 build, which would otherwise hang around forever.  Fixes #2029.
  Changeset: 9ddc435937fc6114459a7535a94a8ece4b8f92b1

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2029#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Jul  9 19:07:10 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 09 Jul 2011 19:07:10 -0000
Subject: [Buildbot-commits] [Buildbot] #2022: Stale Broker errors not
	caught on reconfig
In-Reply-To: <038.381285500e2095ef29e1264f09ac6406@buildbot.net>
References: <038.381285500e2095ef29e1264f09ac6406@buildbot.net>
Message-ID: <053.d978677165a5aa0b58c5130046809ee6@buildbot.net>

#2022: Stale Broker errors not caught on reconfig
---------------------+--------------------
Reporter:  dustin    |       Owner:
    Type:  defect    |      Status:  new
Priority:  major     |   Milestone:  0.8.5
 Version:  0.8.2     |  Resolution:
Keywords:  reconfig  |
---------------------+--------------------

Comment (by dustin):

 So this does not appear to be the case.

 {{{
 #!python
 class BuildSlave(AbstractBuildSlave):

     def sendBuilderList(self):
         d = AbstractBuildSlave.sendBuilderList(self)
         def _sent(slist):
             # Nothing has changed, so don't need to re-attach to
 everything
             if not slist:
                 return
             dl = []
             for name, remote in slist.items():
                 # use get() since we might have changed our mind since
 then
                 b = self.botmaster.builders.get(name)
                 if b:
                     d1 = b.attached(self, remote, self.slave_commands)
                     dl.append(d1)
             return defer.DeferredList(dl)
         def _set_failed(why):
             log.msg("BuildSlave.sendBuilderList (%s) failed" % self)
             log.err(why)
             # TODO: hang up on them?, without setBuilderList we can't use
             # them
         d.addCallbacks(_sent, _set_failed)
         return d
 }}}

 so the {{{sendBuilderList}}} call itself is adequately protected against
 failures, and the Deferred it returns will never errback.

 I also can't reproduce this either by fiddling with things to raise
 Failures at the right point, or by repeatedly reconfig'ing a master while
 killing and restarting a slave.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2022#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Sat Jul  9 21:44:26 2011
From: noreply at github.com (noreply at github.com)
Date: Sat, 9 Jul 2011 14:44:26 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 5aaf45: add some more
	documentation and NEWS for metrics
Message-ID: <20110709214426.C5295421A2@smtp1.rs.github.com>

  Branch: refs/heads/buildbot-0.8.4
  Home:   https://github.com/buildbot/buildbot

  Commit: 5aaf459fc97bab739774bd906363c8eaa4f2ecbe
      https://github.com/buildbot/buildbot/commit/5aaf459fc97bab739774bd906363c8eaa4f2ecbe
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-09 (Sat, 09 Jul 2011)

  Changed paths:
    M master/NEWS
  M master/docs/cfg-global.texinfo

  Log Message:
  -----------
  add some more documentation and NEWS for metrics





From noreply at github.com  Sat Jul  9 21:44:27 2011
From: noreply at github.com (noreply at github.com)
Date: Sat, 9 Jul 2011 14:44:27 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 5ffe6a: re-activate
	40dd647aaee3c8b5680146d5a0cb752e9fa23b...
Message-ID: <20110709214427.63DE9421F4@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 5ffe6a61d9dd4f7dd60596af9a792e1c574c810f
      https://github.com/buildbot/buildbot/commit/5ffe6a61d9dd4f7dd60596af9a792e1c574c810f
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-09 (Sat, 09 Jul 2011)

  Changed paths:
    M master/buildbot/buildslave.py

  Log Message:
  -----------
  re-activate 40dd647aaee3c8b5680146d5a0cb752e9fa23bbf

This was accidentally commented out in
e1a03cb88ccfe5ac55aea3929fd1e0081fd2e263


  Commit: cea9873e7fbe793720e55043c1c7fc4aebff0bd9
      https://github.com/buildbot/buildbot/commit/cea9873e7fbe793720e55043c1c7fc4aebff0bd9
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-09 (Sat, 09 Jul 2011)

  Changed paths:
    M master/NEWS
  M master/buildbot/config.py
  M master/buildbot/master.py
  M master/buildbot/status/web/base.py
  M master/buildbot/status/web/builder.py
  M master/buildbot/status/words.py
  M master/docs/cfg-global.texinfo

  Log Message:
  -----------
  Allow users to customize the sanity-checking regexes

This doesn't add security, but at least allows users to open up the
regexes where it's safe to do so.  Fixes #985.

Tested by hand.


  Commit: 78b31cb47147cf6c79a3c77e467bbca8d937c981
      https://github.com/buildbot/buildbot/commit/78b31cb47147cf6c79a3c77e467bbca8d937c981
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-09 (Sat, 09 Jul 2011)

  Changed paths:
    M master/NEWS
  M master/docs/cfg-global.texinfo

  Log Message:
  -----------
  add some more documentation and NEWS for metrics


Compare: https://github.com/buildbot/buildbot/compare/9ddc435...78b31cb



From nobody at buildbot.net  Sat Jul  9 21:44:50 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 09 Jul 2011 21:44:50 -0000
Subject: [Buildbot-commits] [Buildbot] #985: wierd behaviour for some
 custom property values from force build page
In-Reply-To: <039.9c19da66cfd0d81bd21cbb22407290df@buildbot.net>
References: <039.9c19da66cfd0d81bd21cbb22407290df@buildbot.net>
Message-ID: <054.048eefd5907f88ee00e53038c55d8dcc@buildbot.net>

#985: wierd behaviour for some custom property values from force build page
--------------------+---------------------
Reporter:  rmdugal  |       Owner:
    Type:  defect   |      Status:  closed
Priority:  major    |   Milestone:  0.8.5
 Version:  0.7.12   |  Resolution:  fixed
Keywords:  web      |
--------------------+---------------------
Changes (by Dustin J. Mitchell):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Allow users to customize the sanity-checking regexes

 This doesn't add security, but at least allows users to open up the
 regexes where it's safe to do so.  Fixes #985.

 Tested by hand.
  Changeset: cea9873e7fbe793720e55043c1c7fc4aebff0bd9

-- 
Ticket URL: <http://trac.buildbot.net/ticket/985#comment:7>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Jul  9 21:55:00 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 09 Jul 2011 21:55:00 -0000
Subject: [Buildbot-commits] [Buildbot] #2032: Log tracebacks in separate
 logfile (not in twistd.log) (was: Log tracebacks in seperate logfile (not
 in twistd.log))
In-Reply-To: <040.44f394313b3e8aab92ed7143cac39f9c@buildbot.net>
References: <040.44f394313b3e8aab92ed7143cac39f9c@buildbot.net>
Message-ID: <055.f27f348969a6a7d11f38c7a72e955e51@buildbot.net>

#2032: Log tracebacks in separate logfile (not in twistd.log)
------------------------+--------------------
Reporter:  bdbaddog     |       Owner:
    Type:  enhancement  |      Status:  new
Priority:  minor        |   Milestone:  0.8.+
 Version:  0.8.4p1      |  Resolution:
Keywords:               |
------------------------+--------------------
Changes (by dustin):

 * milestone:  undecided => 0.8.+


Comment:

 This is a good idea, but I probably won't work on it myself.  Anyone else?

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2032#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Jul  9 22:01:41 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 09 Jul 2011 22:01:41 -0000
Subject: [Buildbot-commits] [Buildbot] #2026: svnpoller logs with
 "svnPoller:" and "SVNPoller":
In-Reply-To: <040.80d5c6e154638482104559595213374a@buildbot.net>
References: <040.80d5c6e154638482104559595213374a@buildbot.net>
Message-ID: <055.65b9e077f4476db4c7d1352438de50da@buildbot.net>

#2026: svnpoller logs with "svnPoller:" and "SVNPoller":
------------------------+---------------------
Reporter:  bdbaddog     |       Owner:
    Type:  enhancement  |      Status:  closed
Priority:  trivial      |   Milestone:  0.8.5
 Version:  0.8.4p1      |  Resolution:  fixed
Keywords:  svn          |
------------------------+---------------------
Changes (by dustin):

 * status:  new => closed
 * type:  undecided => enhancement
 * resolution:   => fixed
 * milestone:  undecided => 0.8.5


Comment:

 Merged:
 {{{
 commit 66e1b81e4698711ddae27e679fd0168622c5db73
 Author: William Deegan <bill at baddogconsulting.com>
 Date:   Wed Jun 29 16:41:06 2011 -0700

     bug_2026 fixes
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2026#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Jul  9 22:02:26 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 09 Jul 2011 22:02:26 -0000
Subject: [Buildbot-commits] [Buildbot] #1989: gitpoller: repo poll failed
In-Reply-To: <047.15fe2481887f15aaa5d34e0dcb912e05@buildbot.net>
References: <047.15fe2481887f15aaa5d34e0dcb912e05@buildbot.net>
Message-ID: <062.009bcbce18bf80040eeeea2a8ccdd899@buildbot.net>

#1989: gitpoller: repo poll failed
----------------------------+----------------------
Reporter:  sanlokenpatidar  |       Owner:
    Type:  support-request  |      Status:  new
Priority:  major            |   Milestone:  ongoing
 Version:  0.8.2            |  Resolution:
Keywords:                   |
----------------------------+----------------------
Changes (by dustin):

 * milestone:  undecided => ongoing


-- 
Ticket URL: <http://trac.buildbot.net/ticket/1989#comment:4>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Jul  9 22:05:09 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 09 Jul 2011 22:05:09 -0000
Subject: [Buildbot-commits] [Buildbot] #2040: .buildbot-sourcedata
 sometimes contains unicode strings, causes full resync during builds
In-Reply-To: <039.e2dfc7e03f4bac40bf542d88dc6c9bb4@buildbot.net>
References: <039.e2dfc7e03f4bac40bf542d88dc6c9bb4@buildbot.net>
Message-ID: <054.7546fd18d30736d876b608de540ced2a@buildbot.net>

#2040: .buildbot-sourcedata sometimes contains unicode strings, causes full resync
during builds
--------------------+--------------------
Reporter:  dberger  |       Owner:
    Type:  defect   |      Status:  new
Priority:  major    |   Milestone:  0.8.5
 Version:  0.8.4p1  |  Resolution:
Keywords:  p4       |
--------------------+--------------------
Changes (by dustin):

 * keywords:   => p4
 * milestone:  undecided => 0.8.5


Comment:

 Any further progress?  Python will compare u'...' as equal to '...' (by
 casting the latter to unicode).

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2040#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Jul  9 22:19:28 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 09 Jul 2011 22:19:28 -0000
Subject: [Buildbot-commits] [Buildbot] #2039: rmdir slaveside command
 return 0 even if it fails
In-Reply-To: <038.56d9b51ea9a24a4c7d33d12bbed7fa00@buildbot.net>
References: <038.56d9b51ea9a24a4c7d33d12bbed7fa00@buildbot.net>
Message-ID: <053.44c076b13cf5aa1c105d6be931e89d81@buildbot.net>

#2039: rmdir slaveside command return 0 even if it fails
----------------------+------------------------
Reporter:  in3xes     |       Owner:
    Type:  undecided  |      Status:  new
Priority:  minor      |   Milestone:  undecided
 Version:  0.8.4p1    |  Resolution:
Keywords:             |
----------------------+------------------------

Comment (by dustin):

 Probably the right error-handling technique is to test for existence of
 the pathname after 'rm' returns, and set rc=1 if the pathname still
 exists.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2039#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Jul  9 22:59:03 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 09 Jul 2011 22:59:03 -0000
Subject: [Buildbot-commits] [Buildbot] #2036: sqlalchemy-migrate == 0.6
	in master/setup.py
In-Reply-To: <040.0ee00df665de776536ff6c47cd19910c@buildbot.net>
References: <040.0ee00df665de776536ff6c47cd19910c@buildbot.net>
Message-ID: <055.56253329eee04ff0211847f702f258c8@buildbot.net>

#2036: sqlalchemy-migrate == 0.6 in master/setup.py
---------------------+--------------------
Reporter:  makowski  |       Owner:
    Type:  defect    |      Status:  new
Priority:  major     |   Milestone:  0.8.5
 Version:  0.8.4p1   |  Resolution:
Keywords:            |
---------------------+--------------------
Changes (by dustin):

 * milestone:  undecided => 0.8.5


-- 
Ticket URL: <http://trac.buildbot.net/ticket/2036#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Sat Jul  9 22:59:50 2011
From: noreply at github.com (noreply at github.com)
Date: Sat, 9 Jul 2011 15:59:50 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] a3abed: Allow
	sqlalchemy-migrate-0.7 as well
Message-ID: <20110709225950.701C0424B8@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: a3abed70546b3742964994517bb27556e06f6e20
      https://github.com/buildbot/buildbot/commit/a3abed70546b3742964994517bb27556e06f6e20
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-09 (Sat, 09 Jul 2011)

  Changed paths:
    M master/setup.py

  Log Message:
  -----------
  Allow sqlalchemy-migrate-0.7 as well

This works in my testing, at least.  Fixes #2036.





From nobody at buildbot.net  Sat Jul  9 22:59:56 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 09 Jul 2011 22:59:56 -0000
Subject: [Buildbot-commits] [Buildbot] #2036: sqlalchemy-migrate == 0.6
	in master/setup.py
In-Reply-To: <040.0ee00df665de776536ff6c47cd19910c@buildbot.net>
References: <040.0ee00df665de776536ff6c47cd19910c@buildbot.net>
Message-ID: <055.ba04a956cc06e1a1c8c8a6890ef6788e@buildbot.net>

#2036: sqlalchemy-migrate == 0.6 in master/setup.py
---------------------+---------------------
Reporter:  makowski  |       Owner:
    Type:  defect    |      Status:  closed
Priority:  major     |   Milestone:  0.8.5
 Version:  0.8.4p1   |  Resolution:  fixed
Keywords:            |
---------------------+---------------------
Changes (by Dustin J. Mitchell):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Allow sqlalchemy-migrate-0.7 as well

 This works in my testing, at least.  Fixes #2036.
  Changeset: a3abed70546b3742964994517bb27556e06f6e20

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2036#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sun Jul 10 00:34:42 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 10 Jul 2011 00:34:42 -0000
Subject: [Buildbot-commits] [Buildbot] #1061: Buildbot locks downloaded
	files
In-Reply-To: <039.3caf071a0bf60c4df27fb569d19d0709@buildbot.net>
References: <039.3caf071a0bf60c4df27fb569d19d0709@buildbot.net>
Message-ID: <054.55d203720276da881a6e4b5f7fa1039b@buildbot.net>

#1061: Buildbot locks downloaded files
--------------------+--------------------
Reporter:  parshin  |       Owner:
    Type:  defect   |      Status:  new
Priority:  major    |   Milestone:  0.8.5
 Version:  0.8.2    |  Resolution:
Keywords:  windows  |
--------------------+--------------------

Comment (by dustin):

 Hm, spawnProcess is frustrating!  The same probably happens on POSIX, but
 of course, on POSIX holding a file open does not "lock" it.  I think your
 solution is a good one, but it needs to be written in such a way that it
 will work on POSIX systems, too - it can't be merged as-is.  Can you
 update it to do so?

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1061#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sun Jul 10 00:37:39 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 10 Jul 2011 00:37:39 -0000
Subject: [Buildbot-commits] [Buildbot] #2041: use consumeErrors for all
	gatherResults calls
Message-ID: <038.bbed7febfd6ab9b9ebbf4afc55e309e1@buildbot.net>

#2041: use consumeErrors for all gatherResults calls
------------------------+-------------------
Reporter:  dustin       |      Owner:
    Type:  enhancement  |     Status:  new
Priority:  major        |  Milestone:  0.8.5
 Version:  0.8.4p1      |   Keywords:
------------------------+-------------------
 gatherResults does not, by default, pass consumeErrors to the underlying
 !DeferredList.  But http://twistedmatrix.com/trac/ticket/5159 would add
 this as a parameter.  When (if) that gets merged, Buildbot should monkey-
 patch it into older versions of Twisted, and use it universally.

 This will prevent unnecessary "unhandled exception" logs, where we *have*
 handled the exception as part of the gathered results.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2041>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sun Jul 10 05:20:30 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 10 Jul 2011 05:20:30 -0000
Subject: [Buildbot-commits] [Buildbot] #2040: .buildbot-sourcedata
 sometimes contains unicode strings, causes full resync during builds
In-Reply-To: <039.e2dfc7e03f4bac40bf542d88dc6c9bb4@buildbot.net>
References: <039.e2dfc7e03f4bac40bf542d88dc6c9bb4@buildbot.net>
Message-ID: <054.0a4d7647d7bac31d183d4ed771d4a3af@buildbot.net>

#2040: .buildbot-sourcedata sometimes contains unicode strings, causes full resync
during builds
--------------------+--------------------
Reporter:  dberger  |       Owner:
    Type:  defect   |      Status:  new
Priority:  major    |   Milestone:  0.8.5
 Version:  0.8.4p1  |  Resolution:
Keywords:  p4       |
--------------------+--------------------

Comment (by dberger):

 It won't when the comparison is against str([list, of, values]) and some
 of the values are unicode - you end up comparing '["foo","bar"]' against
 '["foo",u"bar"]' - and they're different.

 I believe we've gotten all the builders happy by manually modifying their
 on disk soucedata files - I'll confirm when I'm back in the office Monday.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2040#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Sun Jul 10 14:09:48 2011
From: noreply at github.com (noreply at github.com)
Date: Sun, 10 Jul 2011 07:09:48 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] f6b2fc: Merge branch 'rmdir'
	of git://github.com/in3xes/bu...
Message-ID: <20110710140948.3DBCD422DD@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: f6b2fc739b3e1ecf9e64669bd4e46d20d0c12a6e
      https://github.com/buildbot/buildbot/commit/f6b2fc739b3e1ecf9e64669bd4e46d20d0c12a6e
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-10 (Sun, 10 Jul 2011)

  Changed paths:
    M slave/buildslave/commands/base.py
  M slave/buildslave/commands/fs.py
  M slave/buildslave/test/unit/test_commands_fs.py

  Log Message:
  -----------
  Merge branch 'rmdir' of git://github.com/in3xes/buildbot

* 'rmdir' of git://github.com/in3xes/buildbot:
  Modify rmdir to remove multiple directories





From noreply at github.com  Sun Jul 10 14:13:34 2011
From: noreply at github.com (noreply at github.com)
Date: Sun, 10 Jul 2011 07:13:34 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] ae28d7: Merge branch
	'bug_1767' of git://github.com/bdbadd...
Message-ID: <20110710141334.21B584253B@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: ae28d7993a21b0781c9574133323720a8ac05015
      https://github.com/buildbot/buildbot/commit/ae28d7993a21b0781c9574133323720a8ac05015
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-10 (Sun, 10 Jul 2011)

  Changed paths:
    M master/buildbot/steps/source/oldsource.py
  M master/docs/cfg-buildsteps.texinfo
  M slave/buildslave/commands/base.py
  M slave/buildslave/commands/bk.py
  M slave/buildslave/commands/bzr.py
  M slave/buildslave/commands/cvs.py
  M slave/buildslave/commands/darcs.py
  M slave/buildslave/commands/fs.py
  M slave/buildslave/commands/git.py
  M slave/buildslave/commands/hg.py
  M slave/buildslave/commands/mtn.py
  M slave/buildslave/commands/p4.py
  M slave/buildslave/commands/repo.py
  M slave/buildslave/commands/svn.py

  Log Message:
  -----------
  Merge branch 'bug_1767' of git://github.com/bdbaddog/buildbot

* 'bug_1767' of git://github.com/bdbaddog/buildbot:
  add logEnviron to fs build steps to fix broken tests
  fix typo in buildsteps documentation
  added a default value for logEnviron on the slave side
  added logEnviron argument to all source steps (fixes #1767)


  Commit: 486f4c16137b9a095d40eec1b70d1626f0e236da
      https://github.com/buildbot/buildbot/commit/486f4c16137b9a095d40eec1b70d1626f0e236da
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-10 (Sun, 10 Jul 2011)

  Changed paths:
    M master/NEWS

  Log Message:
  -----------
  add NEWS about logEnviron for source steps


Compare: https://github.com/buildbot/buildbot/compare/f6b2fc7...486f4c1



From nobody at buildbot.net  Sun Jul 10 14:13:41 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 10 Jul 2011 14:13:41 -0000
Subject: [Buildbot-commits] [Buildbot] #1767: SVNPoller does not support
	logEnviron
In-Reply-To: <037.723f28971a56e2d4357bf3c11dc762f0@buildbot.net>
References: <037.723f28971a56e2d4357bf3c11dc762f0@buildbot.net>
Message-ID: <052.64a86e75c7ed79750257f2b2fb8297b6@buildbot.net>

#1767: SVNPoller does not support logEnviron
------------------------+---------------------
Reporter:  fgsch        |       Owner:
    Type:  enhancement  |      Status:  closed
Priority:  minor        |   Milestone:  0.8.5
 Version:  0.8.3p1      |  Resolution:  fixed
Keywords:  svn          |
------------------------+---------------------
Changes (by Dustin J. Mitchell):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Merge branch 'bug_1767' of git://github.com/bdbaddog/buildbot

 * 'bug_1767' of git://github.com/bdbaddog/buildbot:
   add logEnviron to fs build steps to fix broken tests
   fix typo in buildsteps documentation
   added a default value for logEnviron on the slave side
   added logEnviron argument to all source steps (fixes #1767)
  Changeset: ae28d7993a21b0781c9574133323720a8ac05015

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1767#comment:6>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Sun Jul 10 14:16:31 2011
From: noreply at github.com (noreply at github.com)
Date: Sun, 10 Jul 2011 07:16:31 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 209b67: Merge branch
	'gsoc_commit' of git://github.com/in3...
Message-ID: <20110710141631.5C1A84253B@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 209b67030e2a823870fbe5855ea5bdf08ff2fc16
      https://github.com/buildbot/buildbot/commit/209b67030e2a823870fbe5855ea5bdf08ff2fc16
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-10 (Sun, 10 Jul 2011)

  Changed paths:
    M master/buildbot/steps/source/git.py
  M master/buildbot/steps/source/mercurial.py
  M master/buildbot/steps/source/oldsource.py
  M master/buildbot/test/unit/test_steps_source_git.py
  M master/buildbot/test/unit/test_steps_source_mercurial.py

  Log Message:
  -----------
  Merge branch 'gsoc_commit' of git://github.com/in3xes/buildbot

* 'gsoc_commit' of git://github.com/in3xes/buildbot:
  Remove unnecessarily variables
  Minor changes to Git, Mercurial. Check for installation on slave





From nobody at buildbot.net  Sun Jul 10 14:30:48 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 10 Jul 2011 14:30:48 -0000
Subject: [Buildbot-commits] [Buildbot] #2040: .buildbot-sourcedata
 sometimes contains unicode strings, causes full resync during builds
In-Reply-To: <039.e2dfc7e03f4bac40bf542d88dc6c9bb4@buildbot.net>
References: <039.e2dfc7e03f4bac40bf542d88dc6c9bb4@buildbot.net>
Message-ID: <054.032563a0f8dd029a8cc545c3a11409ff@buildbot.net>

#2040: .buildbot-sourcedata sometimes contains unicode strings, causes full resync
during builds
--------------------+--------------------
Reporter:  dberger  |       Owner:
    Type:  defect   |      Status:  new
Priority:  major    |   Milestone:  0.8.5
 Version:  0.8.4p1  |  Resolution:
Keywords:  p4       |
--------------------+--------------------

Comment (by dustin):

 Ah, yes, the u'..' gets encoded there, then.  Hrm.  Can you suggest a test
 and subsequent code fix for this?  I don't think Buildbot has too many P4
 users, but I'd hate for all of them to have to make this change manually.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2040#comment:4>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Sun Jul 10 16:46:18 2011
From: noreply at github.com (noreply at github.com)
Date: Sun, 10 Jul 2011 09:46:18 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 753ce2: Merge branch
	'docs_spelling_cleanup' of git://gith...
Message-ID: <20110710164618.3F28642380@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 753ce290e617a62e693ca710e1376cb94a78f021
      https://github.com/buildbot/buildbot/commit/753ce290e617a62e693ca710e1376cb94a78f021
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-10 (Sun, 10 Jul 2011)

  Changed paths:
    M master/docs/cfg-buildsteps.texinfo
  M master/docs/cfg-changesources.texinfo
  M master/docs/cfg-statustargets.texinfo
  M master/docs/configuration.texinfo

  Log Message:
  -----------
  Merge branch 'docs_spelling_cleanup' of git://github.com/SparkieGeek/buildbot

* 'docs_spelling_cleanup' of git://github.com/SparkieGeek/buildbot:
  Fix spelling of associated
  Fix capitalisation of GitHub in status hooks
  Fix capitalisation of GitHub
  Fix URL of project's git repo on GitHub
  s/mater/master/
  s/Frobinfy/Frobnify/g


  Commit: a4fc2e5ff53b6df05ae032abe10624205615d80e
      https://github.com/buildbot/buildbot/commit/a4fc2e5ff53b6df05ae032abe10624205615d80e
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-10 (Sun, 10 Jul 2011)

  Changed paths:
    M master/docs/buildbot.texinfo
  M master/docs/cfg-buildfactories.texinfo
  M master/docs/cfg-statustargets.texinfo
  M master/docs/introduction.texinfo

  Log Message:
  -----------
  s/BuildBot/buildbot/g, with some cleanup


Compare: https://github.com/buildbot/buildbot/compare/209b670...a4fc2e5



From nobody at buildbot.net  Sun Jul 10 17:20:24 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 10 Jul 2011 17:20:24 -0000
Subject: [Buildbot-commits] [Buildbot] #1052: blamelist lost via trigger
In-Reply-To: <039.c1a1ed20af5a431c7d00e91345a91371@buildbot.net>
References: <039.c1a1ed20af5a431c7d00e91345a91371@buildbot.net>
Message-ID: <054.3ec6be6d37a8dbf3a00a6c203aac0289@buildbot.net>

#1052: blamelist lost via trigger
--------------------+-----------------------
Reporter:  qzhwang  |       Owner:
    Type:  defect   |      Status:  reopened
Priority:  major    |   Milestone:  0.8.2
 Version:  0.8.1    |  Resolution:
Keywords:           |
--------------------+-----------------------
Changes (by dustin):

 * cc: tomprince (added)


Comment:

 Maybe tomprince can take a look..

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1052#comment:8>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sun Jul 10 19:15:18 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 10 Jul 2011 19:15:18 -0000
Subject: [Buildbot-commits] [Buildbot] #2042: remove schedulers.state column
Message-ID: <038.093465493dc77fd489f2a277fa8cc1a7@buildbot.net>

#2042: remove schedulers.state column
------------------------+----------------------
Reporter:  dustin       |      Owner:
    Type:  enhancement  |     Status:  new
Priority:  major        |  Milestone:  0.8.5
 Version:  0.8.4p1      |   Keywords:  database
------------------------+----------------------
 This is no longer used - schedulers now store their state in the
 object_state table.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2042>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sun Jul 10 20:03:06 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 10 Jul 2011 20:03:06 -0000
Subject: [Buildbot-commits] [Buildbot] #2043: Upgrades from 0.8.3 get column
	lengths wrong
Message-ID: <038.b1409418041fd7a569bce481ce2e2aca@buildbot.net>

#2043: Upgrades from 0.8.3 get column lengths wrong
---------------------+----------------------
Reporter:  dustin    |      Owner:
    Type:  defect    |     Status:  new
Priority:  critical  |  Milestone:  0.8.5
 Version:  0.8.4p1   |   Keywords:  database
---------------------+----------------------
 From 0.8.3:
 {{{
 ===============================================================================
 [FAIL]
 Traceback (most recent call last):
   File
 "/home/dustin/code/buildbot/t/buildbot/master/buildbot/test/integration/test_upgrade.py",
 line 91, in check
     self.fail(str(diff))
 twisted.trial.unittest.FailTest: Schema diffs:
   tables missing from model: sqlite_sequence
   tables missing from database: version
   table with differences: changes
     column with differences: branch
          model: Column('branch', String(length=256, convert_unicode=False,
 assert_unicode=None, unicode_error=None, _warn_on_bytestring=False),
 table=<changes>)
       database: Column(u'branch', VARCHAR(length=1024,
 convert_unicode=False, assert_unicode=None, unicode_error=None,
 _warn_on_bytestring=False), table=<changes>)
     column with differences: author
          model: Column('author', String(length=256, convert_unicode=False,
 assert_unicode=None, unicode_error=None, _warn_on_bytestring=False),
 table=<changes>, nullable=False)
       database: Column(u'author', VARCHAR(length=1024,
 convert_unicode=False, assert_unicode=None, unicode_error=None,
 _warn_on_bytestring=False), table=<changes>, nullable=False)
   table with differences: schedulers
     column with differences: class_name
          model: Column('class_name', String(length=128,
 convert_unicode=False, assert_unicode=None, unicode_error=None,
 _warn_on_bytestring=False), table=<schedulers>, nullable=False)
       database: Column(u'class_name', VARCHAR(length=100,
 convert_unicode=False, assert_unicode=None, unicode_error=None,
 _warn_on_bytestring=False), table=<schedulers>, nullable=False)
     column with differences: name
          model: Column('name', String(length=128, convert_unicode=False,
 assert_unicode=None, unicode_error=None, _warn_on_bytestring=False),
 table=<schedulers>, nullable=False)
       database: Column(u'name', VARCHAR(length=100, convert_unicode=False,
 assert_unicode=None, unicode_error=None, _warn_on_bytestring=False),
 table=<schedulers>, nullable=False)

 buildbot.test.integration.test_upgrade.UpgradeTestV083.test_test
 -------------------------------------------------------------------------------
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2043>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sun Jul 10 22:40:13 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 10 Jul 2011 22:40:13 -0000
Subject: [Buildbot-commits] [Buildbot] #2044: Make buildbot high-scores board
Message-ID: <038.7f98eee44f6077290763dc4e3c1c63c7@buildbot.net>

#2044: Make buildbot high-scores board
-------------------+---------------------
Reporter:  dustin  |      Owner:
    Type:  task    |     Status:  new
Priority:  major   |  Milestone:  ongoing
 Version:          |   Keywords:  admin
-------------------+---------------------
 refs:
  * http://twistedmatrix.com/highscores/
  * https://github.com/leereilly/github-high-scores

 I think that this would be a fun way to motivate contributors.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2044>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Mon Jul 11 02:37:57 2011
From: noreply at github.com (noreply at github.com)
Date: Sun, 10 Jul 2011 19:37:57 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 2e3a20: fix comment in
	009_add_patch_author.py
Message-ID: <20110711023757.C11BE4244C@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 2e3a2000e5d0a363c5d8c6e7399725d743de4576
      https://github.com/buildbot/buildbot/commit/2e3a2000e5d0a363c5d8c6e7399725d743de4576
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-10 (Sun, 10 Jul 2011)

  Changed paths:
    M master/buildbot/db/migrate/versions/009_add_patch_author.py

  Log Message:
  -----------
  fix comment in 009_add_patch_author.py


  Commit: 7610f4a67f374dabf80b32be7508bea283bd3e78
      https://github.com/buildbot/buildbot/commit/7610f4a67f374dabf80b32be7508bea283bd3e78
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-10 (Sun, 10 Jul 2011)

  Changed paths:
    M master/buildbot/db/model.py
  M master/buildbot/test/integration/test_upgrade.py

  Log Message:
  -----------
  test_upgrade improvements

Better support for comparing the db to the model, including a
monkeypatch for a bug in sqlalchemy-migrate.


Compare: https://github.com/buildbot/buildbot/compare/a4fc2e5...7610f4a



From noreply at github.com  Mon Jul 11 02:50:39 2011
From: noreply at github.com (noreply at github.com)
Date: Sun, 10 Jul 2011 19:50:39 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] c9d763: Set correct column
	sizes on changes and schedulers...
Message-ID: <20110711025039.908A64240F@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: c9d763658ca922d4659b978874dc1c5824686bfb
      https://github.com/buildbot/buildbot/commit/c9d763658ca922d4659b978874dc1c5824686bfb
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-10 (Sun, 10 Jul 2011)

  Changed paths:
    A master/buildbot/db/migrate/versions/010_fix_column_lengths.py
  M master/buildbot/test/integration/test_upgrade.py
  A master/buildbot/test/integration/v082-README.txt
  A master/buildbot/test/integration/v082.tgz
  A master/buildbot/test/integration/v083-README.txt
  A master/buildbot/test/integration/v083.tgz

  Log Message:
  -----------
  Set correct column sizes on changes and schedulers tables

These were set incorrectly by the old upgrade scripts.  This commit also
adds tests for upgrades from 0.8.2 and 0.8.3.





From nobody at buildbot.net  Mon Jul 11 17:00:31 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 11 Jul 2011 17:00:31 -0000
Subject: [Buildbot-commits] [Buildbot] #971: Build a windows installer
In-Reply-To: <038.6c763d0f053bc258fcb2f8f99b00326c@buildbot.net>
References: <038.6c763d0f053bc258fcb2f8f99b00326c@buildbot.net>
Message-ID: <053.eeb53c8ee64a6d3f5b438952cf30aebb@buildbot.net>

#971: Build a windows installer
------------------------+-----------------------
Reporter:  dustin       |       Owner:  fatman2
    Type:  enhancement  |      Status:  accepted
Priority:  major        |   Milestone:  0.8.+
 Version:               |  Resolution:
Keywords:  windows      |
------------------------+-----------------------

Comment (by fatman2):

 {{{
 the MSI strategy is much more likely to lead to success quickly than NSIS
 }}}

 Why do people always think this about NSIS? It's a much simpler concept
 than MSI.

 {{{
 fatman, if you're working on this still and you're not against someone's
 help, please get in touch with me to cooperate on this task (my nickname
 on github is the same as here).
 }}}

 Just stalled a bit. What do you need? I don't use github at all.

 The source is downloadable as plain text (if you don't like Fossil) from
 the same link I posted before. The .nsi file is the whole thing.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/971#comment:18>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Jul 11 17:05:10 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 11 Jul 2011 17:05:10 -0000
Subject: [Buildbot-commits] [Buildbot] #971: Build a windows installer
In-Reply-To: <038.6c763d0f053bc258fcb2f8f99b00326c@buildbot.net>
References: <038.6c763d0f053bc258fcb2f8f99b00326c@buildbot.net>
Message-ID: <053.3164a5b6d70eaa30c1e98192107e6dbf@buildbot.net>

#971: Build a windows installer
------------------------+-----------------------
Reporter:  dustin       |       Owner:  fatman2
    Type:  enhancement  |      Status:  accepted
Priority:  major        |   Milestone:  0.8.+
 Version:               |  Resolution:
Keywords:  windows      |
------------------------+-----------------------

Comment (by dustin):

 Replying to [comment:18 fatman2]:
 > {{{
 > the MSI strategy is much more likely to lead to success quickly than
 NSIS
 > }}}
 >
 > Why do people always think this about NSIS? It's a much simpler concept
 than MSI.

 Well, this bug is 11 months old, so that's not very fast :)  Also, NSIS
 requires additional software on the build host, while MSI doesn't.  So if
 we use NSIS we'll need to figure out whether to build it on buildslaves,
 or have you build things by hand for each release.

 That said, I'm happy with whatever solution can meet both of these
 criteria:

  1. done
  1. functional

-- 
Ticket URL: <http://trac.buildbot.net/ticket/971#comment:19>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Mon Jul 11 17:14:44 2011
From: noreply at github.com (noreply at github.com)
Date: Mon, 11 Jul 2011 10:14:44 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 8e2350: only check that the
	model matches with sqlalchemy-...
Message-ID: <20110711171444.3D22A42407@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 8e2350368e9b57b12feeeb4130c9c2fc365014c6
      https://github.com/buildbot/buildbot/commit/8e2350368e9b57b12feeeb4130c9c2fc365014c6
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-10 (Sun, 10 Jul 2011)

  Changed paths:
    M master/buildbot/test/integration/test_upgrade.py

  Log Message:
  -----------
  only check that the model matches with sqlalchemy-migrate==0.7.x





From noreply at github.com  Mon Jul 11 17:14:43 2011
From: noreply at github.com (noreply at github.com)
Date: Mon, 11 Jul 2011 10:14:43 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 2da130: Run checkconfig
	right there in the master director...
Message-ID: <20110711171443.E609542401@smtp1.rs.github.com>

  Branch: refs/heads/buildbot-0.8.4
  Home:   https://github.com/buildbot/buildbot

  Commit: 2da13034b4d880aca294f003d89f985cf9ed6ed6
      https://github.com/buildbot/buildbot/commit/2da13034b4d880aca294f003d89f985cf9ed6ed6
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-11 (Mon, 11 Jul 2011)

  Changed paths:
    M master/buildbot/scripts/checkconfig.py
  M master/buildbot/scripts/runner.py
  A master/buildbot/test/unit/test_scripts_checkconfig.py
  M master/buildbot/test/unit/test_scripts_runner.py

  Log Message:
  -----------
  Run checkconfig right there in the master directory

..rather than copying the contents of the directory somewhere.  This
includes tests that verify, among other things, that builder directories
are not unnecessarily created.


  Commit: a1dcb30f13c2fff8de35606102218694c126bdef
      https://github.com/buildbot/buildbot/commit/a1dcb30f13c2fff8de35606102218694c126bdef
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-11 (Mon, 11 Jul 2011)

  Changed paths:
    M master/NEWS

  Log Message:
  -----------
  update NEWS for 0.8.4p2


Compare: https://github.com/buildbot/buildbot/compare/5aaf459...a1dcb30



From nobody at buildbot.net  Mon Jul 11 17:15:49 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 11 Jul 2011 17:15:49 -0000
Subject: [Buildbot-commits] [Buildbot] #971: Build a windows installer
In-Reply-To: <038.6c763d0f053bc258fcb2f8f99b00326c@buildbot.net>
References: <038.6c763d0f053bc258fcb2f8f99b00326c@buildbot.net>
Message-ID: <053.82c476e6313920aa22638659e4a2893a@buildbot.net>

#971: Build a windows installer
------------------------+-----------------------
Reporter:  dustin       |       Owner:  fatman2
    Type:  enhancement  |      Status:  accepted
Priority:  major        |   Milestone:  0.8.+
 Version:               |  Resolution:
Keywords:  windows      |
------------------------+-----------------------

Comment (by fatman2):

 > > Why do people always think this about NSIS? It's a much simpler
 concept than MSI.
 >
 > Well, this bug is 11 months old, so that's not very fast :)

 Blame Fatman, not NSIS. :P

 > Also, NSIS requires additional software on the build host,

 Eh? What additional software? Unless you mean the NSIS compiler itself,
 makensis.exe? Actually, if you use CMake as the build system, you don't
 even need makensis.exe, as CMake's built-in CPack module has NSIS support.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/971#comment:20>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Jul 11 17:17:36 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 11 Jul 2011 17:17:36 -0000
Subject: [Buildbot-commits] [Buildbot] #971: Build a windows installer
In-Reply-To: <038.6c763d0f053bc258fcb2f8f99b00326c@buildbot.net>
References: <038.6c763d0f053bc258fcb2f8f99b00326c@buildbot.net>
Message-ID: <053.5eb2daef4ba089a8a4952623114203dc@buildbot.net>

#971: Build a windows installer
------------------------+-----------------------
Reporter:  dustin       |       Owner:  fatman2
    Type:  enhancement  |      Status:  accepted
Priority:  major        |   Milestone:  0.8.+
 Version:               |  Resolution:
Keywords:  windows      |
------------------------+-----------------------

Comment (by dustin):

 Oh, I read the description as applying to NSIS.  Sounds like NSIS is a
 good option, then!

-- 
Ticket URL: <http://trac.buildbot.net/ticket/971#comment:21>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Jul 11 17:29:39 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 11 Jul 2011 17:29:39 -0000
Subject: [Buildbot-commits] [Buildbot] #1034: REQ: Fossil support
In-Reply-To: <039.f7b5158abdc8df351f45766124df3974@buildbot.net>
References: <039.f7b5158abdc8df351f45766124df3974@buildbot.net>
Message-ID: <054.174bc2a7d90f6153a98179f5958f0416@buildbot.net>

#1034: REQ: Fossil support
------------------------+--------------------
Reporter:  fatman2      |       Owner:
    Type:  enhancement  |      Status:  new
Priority:  major        |   Milestone:  0.8.+
 Version:  0.8.1        |  Resolution:
Keywords:               |
------------------------+--------------------

Comment (by fatman2):

 Replying to [comment:10 dustin]:
 > I had a chat with some folks here at !PyCon (lvh_ in particular) about
 Fossil support.  It sounds like there is very little chance of creating a
 Fossil hook, but a poller might be possible.
 >
 > Is this still something you're interested in seeing?

 Yeah, sure is. The folks on the Fossil mailing list (paleontologists?)
 said the same to me, all convinced I couldn't figure out a way to get the
 "client" Fossil to signal the "server" Fossil to run a command. I admit my
 solution was a bit rough around the edges, but the concept worked. It's
 easy to say "it can't be done" until someone actually does it! ;)

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1034#comment:11>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Mon Jul 11 17:32:03 2011
From: noreply at github.com (noreply at github.com)
Date: Mon, 11 Jul 2011 10:32:03 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] b8b527: Add tests for
	upgrades from v0.8.4.
Message-ID: <20110711173203.D11CB421F7@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: b8b5273563d780e8a1978bf8965459f2da0129d3
      https://github.com/buildbot/buildbot/commit/b8b5273563d780e8a1978bf8965459f2da0129d3
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-11 (Mon, 11 Jul 2011)

  Changed paths:
    M master/buildbot/test/integration/test_upgrade.py
  A master/buildbot/test/integration/v084-README.txt
  A master/buildbot/test/integration/v084.tgz

  Log Message:
  -----------
  Add tests for upgrades from v0.8.4.





From noreply at github.com  Mon Jul 11 18:00:20 2011
From: noreply at github.com (noreply at github.com)
Date: Mon, 11 Jul 2011 11:00:20 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 1ba5a8: Add tests for
	upgrades from v0.8.4.
Message-ID: <20110711180020.E655E42462@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 1ba5a87cc1f8721f4db8c8a7d9ca7344cbdd5993
      https://github.com/buildbot/buildbot/commit/1ba5a87cc1f8721f4db8c8a7d9ca7344cbdd5993
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-11 (Mon, 11 Jul 2011)

  Changed paths:
    M master/buildbot/test/integration/test_upgrade.py
  A master/buildbot/test/integration/v084-README.txt
  A master/buildbot/test/integration/v084.tgz

  Log Message:
  -----------
  Add tests for upgrades from v0.8.4.





From noreply at github.com  Mon Jul 11 18:21:05 2011
From: noreply at github.com (noreply at github.com)
Date: Mon, 11 Jul 2011 11:21:05 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] ba0bea: support
	sqlalchemy-migrate 0.6.0, 0.6.1, 0.7.0, an...
Message-ID: <20110711182105.416544247A@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: ba0bea7ac4407d17f6d65938a2977c4c417bc434
      https://github.com/buildbot/buildbot/commit/ba0bea7ac4407d17f6d65938a2977c4c417bc434
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-11 (Mon, 11 Jul 2011)

  Changed paths:
    M master/setup.py

  Log Message:
  -----------
  support sqlalchemy-migrate 0.6.0, 0.6.1, 0.7.0, and 0.7.1





From nobody at buildbot.net  Mon Jul 11 19:11:45 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 11 Jul 2011 19:11:45 -0000
Subject: [Buildbot-commits] [Buildbot] #2045: Implicit limit of 1000
	builders per slave
Message-ID: <035.55d811d1be045ddf3ef52ca4764c3b95@buildbot.net>

#2045: Implicit limit of 1000 builders per slave
----------------------+-----------------------
Reporter:  xrg        |      Owner:
    Type:  undecided  |     Status:  new
Priority:  minor      |  Milestone:  undecided
 Version:  0.8.4      |   Keywords:
----------------------+-----------------------
 It has been noted that when > ~1000 builders are configured for a single
 slave, the slave cannot go online.
 This /must be/ due to a protocol packet size limit, PB transmission size.

 The message noted at logs is:
           File ".../site-packages/buildbot-0.8.4_pre_741_g2089c5b-
 py2.6.egg/build
 bot/process/slavebuilder.py", line 107, in <lambda>
             self.remote.callRemote("setMaster", self))
 ...
           File ".../twisted/spread/flavors.py", line 127, in jellyFor
             return "remote", jellier.invoker.registerReference(self)
           File ".../twisted/spread/pb.py", line 666, in registerReference
             raise Error("Maximum PB reference count exceeded.")
         twisted.spread.pb.Error: Maximum PB reference count exceeded.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2045>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Mon Jul 11 20:18:34 2011
From: noreply at github.com (noreply at github.com)
Date: Mon, 11 Jul 2011 13:18:34 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 4f5915: fix stupid typo in
	validating revisions in force b...
Message-ID: <20110711201834.7BE0D42486@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 4f5915aefa108c0a922ebc6cf891cd3f5a5d4e11
      https://github.com/buildbot/buildbot/commit/4f5915aefa108c0a922ebc6cf891cd3f5a5d4e11
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-11 (Mon, 11 Jul 2011)

  Changed paths:
    M master/buildbot/status/web/builder.py

  Log Message:
  -----------
  fix stupid typo in validating revisions in force build





From nobody at buildbot.net  Tue Jul 12 04:43:34 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 12 Jul 2011 04:43:34 -0000
Subject: [Buildbot-commits] [Buildbot] #2046: patch_author and patch_comment
 make MySQL dialect less than happy
Message-ID: <038.cbb3e234ca3728ad6c35e5f101cb6ba6@buildbot.net>

#2046: patch_author and patch_comment make MySQL dialect less than happy
--------------------+----------------------
Reporter:  dustin   |      Owner:
    Type:  defect   |     Status:  new
Priority:  minor    |  Milestone:  0.8.5
 Version:  0.8.4p1  |   Keywords:  database
--------------------+----------------------
 {{{
 /home/dustin/code/buildbot/t/buildbot/sand27/lib/python2.7/site-
 packages/sqlalchemy/engine/default.py:325: Warning: BLOB/TEXT column
 'patch_author' can't have a default value
 /home/dustin/code/buildbot/t/buildbot/sand27/lib/python2.7/site-
 packages/sqlalchemy/engine/default.py:325: Warning: BLOB/TEXT column
 'patch_comment' can't have a default value
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2046>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Jul 12 04:44:40 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 12 Jul 2011 04:44:40 -0000
Subject: [Buildbot-commits] [Buildbot] #2047: incorporate
 buildbot.master.LogRotation into buildbot.config
Message-ID: <038.30a5cc03c86d7fd70209d2f44c1c9c3e@buildbot.net>

#2047: incorporate buildbot.master.LogRotation into buildbot.config
------------------------+-------------------
Reporter:  dustin       |      Owner:
    Type:  enhancement  |     Status:  new
Priority:  minor        |  Milestone:  0.8.5
 Version:  0.8.4p1      |   Keywords:
------------------------+-------------------
 This is a little lump of configuration that was made before the
 !BuildbotConfig was standardized.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2047>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Jul 12 16:38:59 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 12 Jul 2011 16:38:59 -0000
Subject: [Buildbot-commits] [Buildbot] #2048: Also adding 'committer' to
 interested users for MailNotifier
Message-ID: <036.ddab455e872e0cf7c0f4c1546cd25fe3@buildbot.net>

#2048: Also adding 'committer' to interested users for MailNotifier
------------------------+-----------------------
Reporter:  deng         |      Owner:
    Type:  enhancement  |     Status:  new
Priority:  minor        |  Milestone:  undecided
 Version:  0.8.4p1      |   Keywords:
------------------------+-----------------------
 It would be nice if Buildbot could notify both the author as well as the
 committer of a change via the MailNotifier. I'm currently using the
 buildbot.py post-merge script for git; in this script, the 'author' is
 used as the person responsible for the change and inserted into 'who'.
 While I can easily change this script to use the committer instead, I'd
 still like to notify both directly, by using the MailNotifier with
 sendToInterestedUsers=true. Currently this isn't possible since the
 change's 'who' field is restricted to one user.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2048>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul 13 07:29:53 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 13 Jul 2011 07:29:53 -0000
Subject: [Buildbot-commits] [Buildbot] #827: ChangeSources may produce
 changes containing non-ascii bytestrings
In-Reply-To: <038.ae761c4a7372f16842cdf0af25f40038@buildbot.net>
References: <038.ae761c4a7372f16842cdf0af25f40038@buildbot.net>
Message-ID: <053.766346725d9afd688e11837a4024eec4@buildbot.net>

#827: ChangeSources may produce changes containing non-ascii bytestrings
------------------------------+---------------------
Reporter:  dustin             |       Owner:
    Type:  defect             |      Status:  closed
Priority:  critical           |   Milestone:  0.8.+
 Version:  0.7.12             |  Resolution:  fixed
Keywords:  encoding database  |
------------------------------+---------------------

Comment (by birbilakos):

 I'm having a similar issue with 0.8.4p1 and P4 changesource:

           File "/usr/local/lib/python2.6/site-
 packages/SQLAlchemy-0.7.1-py2.6-linux-i686.egg/sqlalchemy/engine/base.py",
 line 1491, in _execute_clauseelement
             compiled_sql, distilled_params
           File "/usr/local/lib/python2.6/site-
 packages/SQLAlchemy-0.7.1-py2.6-linux-i686.egg/sqlalchemy/engine/base.py",
 line 1599, in _execute_context
             context)
           File "/usr/local/lib/python2.6/site-
 packages/SQLAlchemy-0.7.1-py2.6-linux-i686.egg/sqlalchemy/engine/base.py",
 line 1592, in _execute_context
             context)
           File "/usr/local/lib/python2.6/site-
 packages/SQLAlchemy-0.7.1-py2.6-linux-i686.egg/sqlalchemy/engine/default.py",
 line 325, in do_execute
             cursor.execute(statement, parameters)
         sqlalchemy.exc.ProgrammingError: (ProgrammingError) You must not
 use 8-bit bytestrings unless you use a text_factory that can interpret
 8-bit bytestrings (like text_factory = str). It is highly recommended that
 you instead just switch your application to Unicode strings. u'INSERT INTO
 changes (author, comments, is_dir, branch, revision, revlink,
 when_timestamp, category, repository, project) VALUES (?, ?, ?, ?, ?, ?,
 ?, ?, ?, ?)' ('aluo', 'Change 83431 by uname_1.1 on 2011/07/12
 02:13:52\n\n\tbug39265: - there should be warning message for changing
 System IP.\n\t\n\nJobs fixed ...\n\nbug39265 by uname at company.com
 *RESOLVED-FIXED*\n\n\t- there should be warning message for changing
 \x93System IP\x94.\n\n', 0, '1.1', '83431', '', 1310462032, None, '', '')

 I think the special characters: \x93\x94 are causing these issues.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/827#comment:14>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul 13 12:57:53 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 13 Jul 2011 12:57:53 -0000
Subject: [Buildbot-commits] [Buildbot] #2049: Broken parsing in pylint
Message-ID: <038.bab043cd287493eb31492d51ea347ce0@buildbot.net>

#2049: Broken parsing in pylint
--------------------+-----------------------
Reporter:  dwyerk   |      Owner:
    Type:  defect   |     Status:  new
Priority:  major    |  Milestone:  undecided
 Version:  0.8.4p1  |   Keywords:
--------------------+-----------------------
 The change shown here
 https://github.com/buildbot/buildbot/commit/d013e2ce85aaf8a8e5378edb716f72abf3cef76b
 breaks pylint when using the option include-ids=yes in your pylintrc. What
 you really want is to make those \d{4}'s optional.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2049>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul 13 16:59:35 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 13 Jul 2011 16:59:35 -0000
Subject: [Buildbot-commits] [Buildbot] #2049: Broken parsing in pylint
In-Reply-To: <038.bab043cd287493eb31492d51ea347ce0@buildbot.net>
References: <038.bab043cd287493eb31492d51ea347ce0@buildbot.net>
Message-ID: <053.ccb7921bbf9cb112669d3a7e5f337f36@buildbot.net>

#2049: Broken parsing in pylint
--------------------+------------------------
Reporter:  dwyerk   |       Owner:
    Type:  defect   |      Status:  new
Priority:  major    |   Milestone:  undecided
 Version:  0.8.4p1  |  Resolution:
Keywords:           |
--------------------+------------------------

Comment (by dustin):

 Can you give some example strings so that we can test this?

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2049#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul 13 16:59:52 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 13 Jul 2011 16:59:52 -0000
Subject: [Buildbot-commits] [Buildbot] #2049: Broken parsing in pylint
In-Reply-To: <038.bab043cd287493eb31492d51ea347ce0@buildbot.net>
References: <038.bab043cd287493eb31492d51ea347ce0@buildbot.net>
Message-ID: <053.d8b91db2a025d7e3d15927a13f330483@buildbot.net>

#2049: Broken parsing in pylint
--------------------+--------------------
Reporter:  dwyerk   |       Owner:
    Type:  defect   |      Status:  new
Priority:  minor    |   Milestone:  0.8.5
 Version:  0.8.4p1  |  Resolution:
Keywords:           |
--------------------+--------------------
Changes (by dustin):

 * priority:  major => minor
 * milestone:  undecided => 0.8.5


-- 
Ticket URL: <http://trac.buildbot.net/ticket/2049#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul 13 17:04:43 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 13 Jul 2011 17:04:43 -0000
Subject: [Buildbot-commits] [Buildbot] #2043: Upgrades from 0.8.3 get
	column lengths wrong
In-Reply-To: <038.b1409418041fd7a569bce481ce2e2aca@buildbot.net>
References: <038.b1409418041fd7a569bce481ce2e2aca@buildbot.net>
Message-ID: <053.278b9354740bfbb0a82e8d6819f802bc@buildbot.net>

#2043: Upgrades from 0.8.3 get column lengths wrong
---------------------+---------------------
Reporter:  dustin    |       Owner:
    Type:  defect    |      Status:  closed
Priority:  critical  |   Milestone:  0.8.5
 Version:  0.8.4p1   |  Resolution:  fixed
Keywords:  database  |
---------------------+---------------------
Changes (by dustin):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Fixed:
 {{{
 commit c9d763658ca922d4659b978874dc1c5824686bfb
 Author: Dustin J. Mitchell <dustin at mozilla.com>
 Date:   Sun Jul 10 15:03:39 2011 -0500

     Set correct column sizes on changes and schedulers tables

     These were set incorrectly by the old upgrade scripts.  This commit
 also
     adds tests for upgrades from 0.8.2 and 0.8.3.
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2043#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul 13 18:17:34 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 13 Jul 2011 18:17:34 -0000
Subject: [Buildbot-commits] [Buildbot] #2049: Broken parsing in pylint
In-Reply-To: <038.bab043cd287493eb31492d51ea347ce0@buildbot.net>
References: <038.bab043cd287493eb31492d51ea347ce0@buildbot.net>
Message-ID: <053.c4ccb1d59f031984b15b1bc8e3d3f895@buildbot.net>

#2049: Broken parsing in pylint
--------------------+--------------------
Reporter:  dwyerk   |       Owner:
    Type:  defect   |      Status:  new
Priority:  minor    |   Milestone:  0.8.5
 Version:  0.8.4p1  |  Resolution:
Keywords:           |
--------------------+--------------------

Comment (by dwyerk):

 include-ids=yes, output-format=parseable
 {{{
 test.py:1: [C0103, whatABadFunctionName] Invalid name
 "whatABadFunctionName" (should match [a-z_][a-z0-9_]{2,30}$)
 }}}

 include-ids=no, output-format=parseable
 {{{
 test.py:1: [C, whatABadFunctionName] Invalid name "whatABadFunctionName"
 (should match [a-z_][a-z0-9_]{2,30}$)
 }}}

 include-ids=yes, output-format=text
 {{{
 C0103:  1:whatABadFunctionName: Invalid name "whatABadFunctionName"
 (should match [a-z_][a-z0-9_]{2,30}$)
 }}}

 include-ids=no, output-format=text
 {{{
 C:  1:whatABadFunctionName: Invalid name "whatABadFunctionName" (should
 match [a-z_][a-z0-9_]{2,30}$)
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2049#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Wed Jul 13 20:00:53 2011
From: noreply at github.com (noreply at github.com)
Date: Wed, 13 Jul 2011 13:00:53 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] ae7fa9: Fix bug introduced
	in 91bd1d7
Message-ID: <20110713200053.42CB64244F@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: ae7fa9de3390b955bfb97eb300040bf878d038e0
      https://github.com/buildbot/buildbot/commit/ae7fa9de3390b955bfb97eb300040bf878d038e0
  Author: Pradeepkumar Gayam <in3xes at gmail.com>
  Date:   2011-07-13 (Wed, 13 Jul 2011)

  Changed paths:
    M master/buildbot/steps/source/git.py
  M master/buildbot/steps/source/mercurial.py

  Log Message:
  -----------
  Fix bug introduced in 91bd1d7


  Commit: e5d06ade6d9e5365b1688bcce9743454e935e035
      https://github.com/buildbot/buildbot/commit/e5d06ade6d9e5365b1688bcce9743454e935e035
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-13 (Wed, 13 Jul 2011)

  Changed paths:
    M master/buildbot/steps/source/git.py
  M master/buildbot/steps/source/mercurial.py

  Log Message:
  -----------
  Merge branch 'source_bug' of git://github.com/in3xes/buildbot

* 'source_bug' of git://github.com/in3xes/buildbot:
  Fix bug introduced in 91bd1d7


Compare: https://github.com/buildbot/buildbot/compare/4f5915a...e5d06ad



From nobody at buildbot.net  Wed Jul 13 20:34:02 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 13 Jul 2011 20:34:02 -0000
Subject: [Buildbot-commits] [Buildbot] #2045: Implicit limit of 1000
	builders per slave
In-Reply-To: <035.55d811d1be045ddf3ef52ca4764c3b95@buildbot.net>
References: <035.55d811d1be045ddf3ef52ca4764c3b95@buildbot.net>
Message-ID: <050.af88aa154503cbb3907f0e672c62db2b@buildbot.net>

#2045: Implicit limit of 1000 builders per slave
------------------------+--------------------
Reporter:  xrg          |       Owner:
    Type:  defect       |      Status:  new
Priority:  minor        |   Milestone:  0.8.+
 Version:  0.8.4        |  Resolution:
Keywords:  performance  |
------------------------+--------------------
Changes (by dustin):

 * keywords:   => performance
 * type:  undecided => defect
 * milestone:  undecided => 0.8.+


-- 
Ticket URL: <http://trac.buildbot.net/ticket/2045#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul 13 20:36:02 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 13 Jul 2011 20:36:02 -0000
Subject: [Buildbot-commits] [Buildbot] #2050: Use metrics to start
 benchmarking Buildbot's performance in metabuildbot
Message-ID: <038.c297aa9733e4a8fd3ee6bc2bdebf3725@buildbot.net>

#2050: Use metrics to start benchmarking Buildbot's performance in metabuildbot
--------------------+-------------------------
Reporter:  dustin   |      Owner:
    Type:  task     |     Status:  new
Priority:  major    |  Milestone:  0.8.+
 Version:  0.8.4p1  |   Keywords:  performance
--------------------+-------------------------
 We should start gathering data on buildbot's performance on a per-checkin
 basis.  Metrics can provide the data, so this just requires coming up with
 suitable scripts to exercise badly-performing parts of Buildbot, and
 building a framework within the metabuildbot to run those scripts and
 gather the results.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2050>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Thu Jul 14 07:25:14 2011
From: nobody at buildbot.net (Buildbot)
Date: Thu, 14 Jul 2011 07:25:14 -0000
Subject: [Buildbot-commits] [Buildbot] #1992: master hangs on startup
In-Reply-To: <038.f1eada51307e3e3bcc8741685c08d579@buildbot.net>
References: <038.f1eada51307e3e3bcc8741685c08d579@buildbot.net>
Message-ID: <053.036927bd3fafd6b8001b97b84ed42bc2@buildbot.net>

#1992: master hangs on startup
------------------------+--------------------
Reporter:  dustin       |       Owner:
    Type:  defect       |      Status:  new
Priority:  major        |   Milestone:  0.8.5
 Version:  0.8.4        |  Resolution:
Keywords:  performance  |
------------------------+--------------------
Changes (by dustin):

 * keywords:   => performance


-- 
Ticket URL: <http://trac.buildbot.net/ticket/1992#comment:6>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Thu Jul 14 20:57:05 2011
From: noreply at github.com (noreply at github.com)
Date: Thu, 14 Jul 2011 13:57:05 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 6ec2f8: add caching for
	objectids
Message-ID: <20110714205705.94DCF421D4@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 6ec2f89e69334dc5928fd92e3dd55ab72abf6d84
      https://github.com/buildbot/buildbot/commit/6ec2f89e69334dc5928fd92e3dd55ab72abf6d84
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-14 (Thu, 14 Jul 2011)

  Changed paths:
    M master/buildbot/db/state.py
  M master/docs/cfg-global.texinfo

  Log Message:
  -----------
  add caching for objectids





From nobody at buildbot.net  Thu Jul 14 22:47:42 2011
From: nobody at buildbot.net (Buildbot)
Date: Thu, 14 Jul 2011 22:47:42 -0000
Subject: [Buildbot-commits] [Buildbot] #2051: Triggerable exception on
	shutdown
Message-ID: <038.4696c7f4abfd378d2827cf1dedbab34d@buildbot.net>

#2051: Triggerable exception on shutdown
--------------------+-------------------
Reporter:  dustin   |      Owner:
    Type:  defect   |     Status:  new
Priority:  major    |  Milestone:  0.8.5
 Version:  0.8.4p1  |   Keywords:
--------------------+-------------------
 {{{
 2011-07-13 17:22:26-0700 [-] Received SIGTERM, shutting down.
 2011-07-13 17:22:26-0700 [-] Unhandled error in Deferred:
 2011-07-13 17:22:26-0700 [-] Unhandled Error
         Traceback (most recent call last):
           File "/usr/lib/python2.7/site-
 packages/twisted/internet/defer.py", line 133, in maybeDeferred
             result = f(*args, **kw)
           File "/usr/lib/python2.7/site-
 packages/twisted/application/service.py", line 285, in stopService
             l.append(defer.maybeDeferred(service.stopService))
           File "/usr/lib/python2.7/site-
 packages/twisted/internet/defer.py", line 133, in maybeDeferred
             result = f(*args, **kw)
           File "/usr/lib/python2.7/site-
 packages/twisted/application/service.py", line 285, in stopService
             l.append(defer.maybeDeferred(service.stopService))
         --- <exception caught here> ---
           File "/usr/lib/python2.7/site-
 packages/twisted/internet/defer.py", line 133, in maybeDeferred
             result = f(*args, **kw)
           File "/var/lib/buildbot/prod_084/lib/python2.7/site-
 packages/buildbot/schedulers/triggerable.py", line 66, in stopService
             d.errback(failure.Failure(RuntimeError(msg)))
         exceptions.AttributeError: 'int' object has no attribute 'errback'

 2011-07-13 17:22:26-0700 [-] (TCP Port 8080 Closed)
 2011-07-13 17:22:26-0700 [-] Stopping factory
 <buildbot.status.web.baseweb.RotateLogSite instance at 0x2872d40>
 2011-07-13 17:22:26-0700 [-] (TCP Port 9998 Closed)
 2011-07-13 17:22:26-0700 [-] Stopping factory
 <twisted.conch.manhole_ssh.ConchFactory instance at 0x2e47128>
 2011-07-13 17:22:26-0700 [-] (TCP Port 9989 Closed)
 2011-07-13 17:22:26-0700 [-] Stopping factory
 <twisted.spread.pb.PBServerFactory instance at 0x2e5c1b8>

 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2051>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Thu Jul 14 22:56:14 2011
From: noreply at github.com (noreply at github.com)
Date: Thu, 14 Jul 2011 15:56:14 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 26bdbc: Correctly notify
	waiters when a Triggerable shuts ...
Message-ID: <20110714225615.0079542528@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 26bdbcec654a1f3517fedd9a78512221ebaca04d
      https://github.com/buildbot/buildbot/commit/26bdbcec654a1f3517fedd9a78512221ebaca04d
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-14 (Thu, 14 Jul 2011)

  Changed paths:
    M master/buildbot/schedulers/triggerable.py

  Log Message:
  -----------
  Correctly notify waiters when a Triggerable shuts down

Fixes #2051





From nobody at buildbot.net  Thu Jul 14 22:56:29 2011
From: nobody at buildbot.net (Buildbot)
Date: Thu, 14 Jul 2011 22:56:29 -0000
Subject: [Buildbot-commits] [Buildbot] #2051: Triggerable exception on
	shutdown
In-Reply-To: <038.4696c7f4abfd378d2827cf1dedbab34d@buildbot.net>
References: <038.4696c7f4abfd378d2827cf1dedbab34d@buildbot.net>
Message-ID: <053.806e8e202b520429e383b1dee5021044@buildbot.net>

#2051: Triggerable exception on shutdown
--------------------+---------------------
Reporter:  dustin   |       Owner:
    Type:  defect   |      Status:  closed
Priority:  major    |   Milestone:  0.8.5
 Version:  0.8.4p1  |  Resolution:  fixed
Keywords:           |
--------------------+---------------------
Changes (by Dustin J. Mitchell):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Correctly notify waiters when a Triggerable shuts down

 Fixes #2051
  Changeset: 26bdbcec654a1f3517fedd9a78512221ebaca04d

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2051#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Thu Jul 14 22:59:29 2011
From: noreply at github.com (noreply at github.com)
Date: Thu, 14 Jul 2011 15:59:29 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] c8bcb2: Correctly notify
	waiters when a Triggerable shuts ...
Message-ID: <20110714225929.BD29D422ED@smtp1.rs.github.com>

  Branch: refs/heads/buildbot-0.8.4
  Home:   https://github.com/buildbot/buildbot

  Commit: c8bcb29d2a240087a3db2bee42abf986989887a1
      https://github.com/buildbot/buildbot/commit/c8bcb29d2a240087a3db2bee42abf986989887a1
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-14 (Thu, 14 Jul 2011)

  Changed paths:
    M master/buildbot/schedulers/triggerable.py

  Log Message:
  -----------
  Correctly notify waiters when a Triggerable shuts down

Fixes #2051





From nobody at buildbot.net  Thu Jul 14 22:59:35 2011
From: nobody at buildbot.net (Buildbot)
Date: Thu, 14 Jul 2011 22:59:35 -0000
Subject: [Buildbot-commits] [Buildbot] #2051: Triggerable exception on
	shutdown
In-Reply-To: <038.4696c7f4abfd378d2827cf1dedbab34d@buildbot.net>
References: <038.4696c7f4abfd378d2827cf1dedbab34d@buildbot.net>
Message-ID: <053.c281148c52c8617d3100a1f09cc8e907@buildbot.net>

#2051: Triggerable exception on shutdown
--------------------+---------------------
Reporter:  dustin   |       Owner:
    Type:  defect   |      Status:  closed
Priority:  major    |   Milestone:  0.8.5
 Version:  0.8.4p1  |  Resolution:  fixed
Keywords:           |
--------------------+---------------------

Comment (by Dustin J. Mitchell):

 Correctly notify waiters when a Triggerable shuts down

 Fixes #2051
  Changeset: c8bcb29d2a240087a3db2bee42abf986989887a1

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2051#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Jul 15 01:03:30 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 15 Jul 2011 01:03:30 -0000
Subject: [Buildbot-commits] [Buildbot] #827: ChangeSources may produce
 changes containing non-ascii bytestrings
In-Reply-To: <038.ae761c4a7372f16842cdf0af25f40038@buildbot.net>
References: <038.ae761c4a7372f16842cdf0af25f40038@buildbot.net>
Message-ID: <053.f48d7e5764e6b6e4ac60241c884deacb@buildbot.net>

#827: ChangeSources may produce changes containing non-ascii bytestrings
------------------------------+---------------------
Reporter:  dustin             |       Owner:
    Type:  defect             |      Status:  closed
Priority:  critical           |   Milestone:  0.8.+
 Version:  0.7.12             |  Resolution:  fixed
Keywords:  encoding database  |
------------------------------+---------------------

Comment (by dustin):

 Can you paste the whole traceback?  Thanks

-- 
Ticket URL: <http://trac.buildbot.net/ticket/827#comment:15>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Jul 15 02:52:14 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 15 Jul 2011 02:52:14 -0000
Subject: [Buildbot-commits] [Buildbot] #2052: Apparent bug in
	WarningCountingShellCommand
Message-ID: <041.78cccc217ccd51c99fbb9ed037f80299@buildbot.net>

#2052: Apparent bug in WarningCountingShellCommand
----------------------+-----------------------
Reporter:  dabrahams  |      Owner:
    Type:  defect     |     Status:  new
Priority:  major      |  Milestone:  undecided
 Version:  0.8.4p1    |   Keywords:  steps
----------------------+-----------------------
 I'm getting this traceback:

 {{{
 (view as text)
 Traceback (most recent call last):
   File "/usr/lib/python2.6/site-packages/twisted/internet/defer.py", line
 286, in addCallbacks
     self._runCallbacks()
   File "/usr/lib/python2.6/site-packages/twisted/internet/defer.py", line
 542, in _runCallbacks
     current.result = callback(current.result, *args, **kw)
   File "/usr/lib/python2.6/site-packages/twisted/internet/defer.py", line
 361, in callback
     self._startRunCallbacks(result)
   File "/usr/lib/python2.6/site-packages/twisted/internet/defer.py", line
 455, in _startRunCallbacks
     self._runCallbacks()
 --- <exception caught here> ---
   File "/usr/lib/python2.6/site-packages/twisted/internet/defer.py", line
 542, in _runCallbacks
     current.result = callback(current.result, *args, **kw)
   File "/usr/lib/python2.6/site-packages/buildbot-0.8.5_pre_172_g26bdbce-
 py2.6.egg/buildbot/process/buildstep.py", line 1135, in <lambda>
     d.addCallback(lambda res: self.createSummary(cmd.logs['stdio']))
   File "/usr/lib/python2.6/site-packages/buildbot-0.8.5_pre_172_g26bdbce-
 py2.6.egg/buildbot/steps/shell.py", line 551, in createSummary
     self.setProperty("warnings-count", old_count + self.warnCount,
 "WarningCountingShellCommand")
 exceptions.TypeError: unsupported operand type(s) for +: 'NoneType' and
 'int'
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2052>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Jul 15 11:30:24 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 15 Jul 2011 11:30:24 -0000
Subject: [Buildbot-commits] [Buildbot] #827: ChangeSources may produce
 changes containing non-ascii bytestrings
In-Reply-To: <038.ae761c4a7372f16842cdf0af25f40038@buildbot.net>
References: <038.ae761c4a7372f16842cdf0af25f40038@buildbot.net>
Message-ID: <053.0069d2456bfd665a8a5d54de34c3b154@buildbot.net>

#827: ChangeSources may produce changes containing non-ascii bytestrings
------------------------------+---------------------
Reporter:  dustin             |       Owner:
    Type:  defect             |      Status:  closed
Priority:  critical           |   Milestone:  0.8.+
 Version:  0.7.12             |  Resolution:  fixed
Keywords:  encoding database  |
------------------------------+---------------------

Comment (by birbilakos):

 Sure,

 Here's a full traceback of this issue. It happens every day depending on
 the special characters that get passed to the Perforce changelists.

 2011-07-15 12:31:01+0300 [-] P4 poll failed
         Traceback (most recent call last):
           File "/usr/local/lib/python2.6/site-
 packages/twisted/internet/defer.py", line 269, in errback
             self._startRunCallbacks(fail)
           File "/usr/local/lib/python2.6/site-
 packages/twisted/internet/defer.py", line 312, in _startRunCallbacks
             self._runCallbacks()
           File "/usr/local/lib/python2.6/site-
 packages/twisted/internet/defer.py", line 328, in _runCallbacks
             self.result = callback(self.result, *args, **kw)
           File "/usr/local/lib/python2.6/site-
 packages/twisted/internet/defer.py", line 630, in gotResult
             _deferGenerator(g, deferred)
         --- <exception caught here> ---
           File "/usr/local/lib/python2.6/site-
 packages/twisted/internet/defer.py", line 605, in _deferGenerator
             result = g.next()
           File "/usr/local/lib/python2.6/site-
 packages/buildbot-0.8.4p1-py2.6.egg/buildbot/changes/p4poller.py", line
 186, in _poll
             wfd.getResult()
           File "/usr/local/lib/python2.6/site-
 packages/twisted/internet/defer.py", line 584, in getResult
             self.result.raiseException()
           File "/usr/local/lib/python2.6/site-
 packages/twisted/python/threadpool.py", line 210, in _worker
             result = context.call(ctx, function, *args, **kwargs)
           File "/usr/local/lib/python2.6/site-
 packages/twisted/python/context.py", line 59, in callWithContext
             return self.currentContext().callWithContext(ctx, func, *args,
 **kw)
           File "/usr/local/lib/python2.6/site-
 packages/twisted/python/context.py", line 37, in callWithContext
             return func(*args,**kw)
           File "/usr/local/lib/python2.6/site-
 packages/buildbot-0.8.4p1-py2.6.egg/buildbot/db/pool.py", line 112, in thd
             rv = callable(conn, *args, **kwargs)
           File "/usr/local/lib/python2.6/site-
 packages/buildbot-0.8.4p1-py2.6.egg/buildbot/db/changes.py", line 141, in
 thd
             project=project))
           File "/usr/local/lib/python2.6/site-
 packages/SQLAlchemy-0.7.1-py2.6-linux-i686.egg/sqlalchemy/engine/base.py",
 line 1358, in execute
             params)
           File "/usr/local/lib/python2.6/site-
 packages/SQLAlchemy-0.7.1-py2.6-linux-i686.egg/sqlalchemy/engine/base.py",
 line 1491, in _execute_clauseelement
             compiled_sql, distilled_params
           File "/usr/local/lib/python2.6/site-
 packages/SQLAlchemy-0.7.1-py2.6-linux-i686.egg/sqlalchemy/engine/base.py",
 line 1599, in _execute_context
             context)
           File "/usr/local/lib/python2.6/site-
 packages/SQLAlchemy-0.7.1-py2.6-linux-i686.egg/sqlalchemy/engine/base.py",
 line 1592, in _execute_context
             context)
           File "/usr/local/lib/python2.6/site-
 packages/SQLAlchemy-0.7.1-py2.6-linux-i686.egg/sqlalchemy/engine/default.py",
 line 325, in do_execute
             cursor.execute(statement, parameters)
         sqlalchemy.exc.ProgrammingError: (ProgrammingError) You must not
 use 8-bit bytestrings unless you use a text_factory that can interpret
 8-bit bytestrings (like text_factory = str). It is highly recommended that
 you instead just switch your application to Unicode strings. u'INSERT INTO
 changes (author, comments, is_dir, branch, revision, revlink,
 when_timestamp, category, repository, project) VALUES (?, ?, ?, ?, ?, ?,
 ?, ?, ?, ?)' ('build', 'Change 83699 by build at build1.1 on 2011/07/14
 03:37:24\n\n\tIntegrating //depot/1.1_maint/... to //depot/1.1/... as of
 change 83680\n\nJobs fixed ...\n\nbug31060 by relengr
 *REOPENED*\n\n\Release Bug\n\nbug36707 by xxx *VERIFIED-
 FIXED*\n\n\tPlayback fails for MBM file
 http://sph_breast_MBM.mp4\n\nbug36759 by xxx *VERIFIED-FIXED*\n\n\tChanges
 needed in Flexible Redirection to support Day Pass at Alltel.\n\nbug36767
 by xxx *VERIFIED-FIXED*\n\n\t\x91307\x92 responses from the server are
 sent to the client as \x91206\x92.\n\nbug36796 by xxx *RESOLVED-
 FIXED*\n\n\tRadius enhancement to be able to handle and log the ULI
 VSA\n\nbug36833 by xxx *VERIFIED-FIXED*\n\n\tKPI report inconsistent
 throughput with KPI Parser log errors\n\nbug36972 by xxx *RESOLVED-
 FIXED*\n\n\tWrong value for 3GPP-User-Location-Info registered in the
 sdb\n\n', '83699', '', 1310639844, None, '', '')

-- 
Ticket URL: <http://trac.buildbot.net/ticket/827#comment:16>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Jul 15 18:54:28 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 15 Jul 2011 18:54:28 -0000
Subject: [Buildbot-commits] [Buildbot] #2053: Too much code in try block
Message-ID: <041.cdb215f0bef975ce364ad3e6f376678d@buildbot.net>

#2053: Too much code in try block
----------------------+-----------------------
Reporter:  dabrahams  |      Owner:
    Type:  defect     |     Status:  new
Priority:  major      |  Milestone:  undecided
 Version:  0.8.4p1    |   Keywords:
----------------------+-----------------------
 [https://github.com/buildbot/buildbot/blob/26bdbcec654a1f3517fedd9a78512221ebaca04d/master/buildbot/master.py#L328
 in master.py], you are checking for KeyError and reporting something
 specific but there's a huge block of code in the try block.  I'm sure
 you're going to mask/misreport other issues

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2053>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Fri Jul 15 21:06:58 2011
From: noreply at github.com (noreply at github.com)
Date: Fri, 15 Jul 2011 14:06:58 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 894819: Account for new
	.steps.source subpackage in setup....
Message-ID: <20110715210658.E800042581@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 8948191461a6558d0caa135535533cf5a28c50a9
      https://github.com/buildbot/buildbot/commit/8948191461a6558d0caa135535533cf5a28c50a9
  Author: Dave Abrahams <dave at boostpro.com>
  Date:   2011-07-14 (Thu, 14 Jul 2011)

  Changed paths:
    M master/setup.py

  Log Message:
  -----------
  Account for new .steps.source subpackage in setup.py


  Commit: 5fa1f10a30f0da05b0da8453f2a15dc88a3a3a59
      https://github.com/buildbot/buildbot/commit/5fa1f10a30f0da05b0da8453f2a15dc88a3a3a59
  Author: Dustin J. Mitchell <dustin at v.igoro.us>
  Date:   2011-07-15 (Fri, 15 Jul 2011)

  Changed paths:
    M master/setup.py

  Log Message:
  -----------
  Merge pull request #182 from dabrahams/setup.py-fix

Account for new .steps.source subpackage in setup.py


Compare: https://github.com/buildbot/buildbot/compare/26bdbce...5fa1f10



From nobody at buildbot.net  Sat Jul 16 01:00:37 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 16 Jul 2011 01:00:37 -0000
Subject: [Buildbot-commits] [Buildbot] #832: remove XMLRPC support
In-Reply-To: <038.3ddbbe7959b90dcacacebefe37c6c02d@buildbot.net>
References: <038.3ddbbe7959b90dcacacebefe37c6c02d@buildbot.net>
Message-ID: <053.48cd9d91dbf7166494cab35137271188@buildbot.net>

#832: remove XMLRPC support
------------------------+---------------------
Reporter:  dustin       |       Owner:  dustin
    Type:  enhancement  |      Status:  closed
Priority:  major        |   Milestone:  0.8.2
 Version:  0.8.0        |  Resolution:  fixed
Keywords:               |
------------------------+---------------------

Comment (by dabrahams):

 Sadly, this change broke a
 [http://www.redmine.org/plugins/redmine_buildbot cool Redmine plugin].
 Where should one begin in making code that used the XMLRPC interface
 compatible again?

-- 
Ticket URL: <http://trac.buildbot.net/ticket/832#comment:4>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Jul 16 08:27:20 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 16 Jul 2011 08:27:20 -0000
Subject: [Buildbot-commits] [Buildbot] #832: remove XMLRPC support
In-Reply-To: <038.3ddbbe7959b90dcacacebefe37c6c02d@buildbot.net>
References: <038.3ddbbe7959b90dcacacebefe37c6c02d@buildbot.net>
Message-ID: <053.7171ef8b1af20dfb3176e1cb19787583@buildbot.net>

#832: remove XMLRPC support
------------------------+---------------------
Reporter:  dustin       |       Owner:  dustin
    Type:  enhancement  |      Status:  closed
Priority:  major        |   Milestone:  0.8.2
 Version:  0.8.0        |  Resolution:  fixed
Keywords:               |
------------------------+---------------------

Comment (by unexist):

 Hum, when you removed the XMLRPC support, is the REST API useable now?
 Didn't know about this ticket. :o

-- 
Ticket URL: <http://trac.buildbot.net/ticket/832#comment:5>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Sun Jul 17 17:48:15 2011
From: noreply at github.com (noreply at github.com)
Date: Sun, 17 Jul 2011 10:48:15 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 8b1cee: Use atomic inserts
	to claim build requests
Message-ID: <20110717174815.0F43D425AB@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 8b1cee84683fd185d46aea193a01f2b42b4f5503
      https://github.com/buildbot/buildbot/commit/8b1cee84683fd185d46aea193a01f2b42b4f5503
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-17 (Sun, 17 Jul 2011)

  Changed paths:
    M master/NEWS
  M master/buildbot/db/buildrequests.py
  A master/buildbot/db/migrate/versions/011_add_buildrequest_claims.py
  M master/buildbot/db/model.py
  M master/buildbot/master.py
  M master/buildbot/process/builder.py
  M master/buildbot/test/fake/fakedb.py
  M master/buildbot/test/fake/fakemaster.py
  M master/buildbot/test/integration/test_upgrade.py
  M master/buildbot/test/unit/test_db_buildrequests.py
  M master/buildbot/test/unit/test_db_buildsets.py
  M master/buildbot/test/unit/test_master.py
  M master/buildbot/test/unit/test_process_builder.py
  M master/buildbot/test/unit/test_schedulers_basic.py
  M master/buildbot/test/unit/test_status_mail.py
  M master/buildbot/test/util/db.py
  A master/buildbot/util/sautils.py

  Log Message:
  -----------
  Use atomic inserts to claim build requests

This differs from the previous practice of trying to update rows to
reflect a claim, which is not possible in an atomic fashion across all
database engines.  This brings a few non-compatible changes:

The db.buildrequests.claimBuildRequests method can no longer re-claim
already-claimed requests; use reclaimBuildRequests instead.  The
database no longer tracks master instances, so the
unclaimOldIncarnationRequests method has been removed.  Note that
several of the methods in this module now perform fewer consistency
checks, for efficiency.

Requests are now claimed to a particular master, but not to a particular
"incarnation" of that master.  The identity of the master is drawn from
the existing objects table.

This commit upgrades the database to version 11.  Fixes #1036.


  Commit: 7918ef351cd1aa406036523d0b9a4af7cfade29a
      https://github.com/buildbot/buildbot/commit/7918ef351cd1aa406036523d0b9a4af7cfade29a
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-17 (Sun, 17 Jul 2011)

  Changed paths:
    M master/buildbot/db/state.py
  M master/buildbot/test/fake/fakemaster.py

  Log Message:
  -----------
  Test that cached db values are weakref-able


Compare: https://github.com/buildbot/buildbot/compare/5fa1f10...7918ef3



From nobody at buildbot.net  Sun Jul 17 17:48:20 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 17 Jul 2011 17:48:20 -0000
Subject: [Buildbot-commits] [Buildbot] #1036: buildrequest can be
	multiply claimed on MySQL
In-Reply-To: <038.e7f6e2904c75db40ead925b3fbd5d384@buildbot.net>
References: <038.e7f6e2904c75db40ead925b3fbd5d384@buildbot.net>
Message-ID: <053.bd805a33f121277bb1bc15c77b26c8a1@buildbot.net>

#1036: buildrequest can be multiply claimed on MySQL
---------------------+---------------------
Reporter:  dustin    |       Owner:
    Type:  defect    |      Status:  closed
Priority:  blocker   |   Milestone:  0.8.5
 Version:  0.8.1     |  Resolution:  fixed
Keywords:  database  |
---------------------+---------------------
Changes (by Dustin J. Mitchell):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Use atomic inserts to claim build requests

 This differs from the previous practice of trying to update rows to
 reflect a claim, which is not possible in an atomic fashion across all
 database engines.  This brings a few non-compatible changes:

 The db.buildrequests.claimBuildRequests method can no longer re-claim
 already-claimed requests; use reclaimBuildRequests instead.  The
 database no longer tracks master instances, so the
 unclaimOldIncarnationRequests method has been removed.  Note that
 several of the methods in this module now perform fewer consistency
 checks, for efficiency.

 Requests are now claimed to a particular master, but not to a particular
 "incarnation" of that master.  The identity of the master is drawn from
 the existing objects table.

 This commit upgrades the database to version 11.  Fixes #1036.
  Changeset: 8b1cee84683fd185d46aea193a01f2b42b4f5503

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1036#comment:6>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Sun Jul 17 19:56:15 2011
From: noreply at github.com (noreply at github.com)
Date: Sun, 17 Jul 2011 12:56:15 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] b3f7c7: Merge branch
	'trigger' of git://github.com/tomprin...
Message-ID: <20110717195616.09174425A8@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: b3f7c7bb8d2797d1c92fa97de718fe18febd7627
      https://github.com/buildbot/buildbot/commit/b3f7c7bb8d2797d1c92fa97de718fe18febd7627
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-17 (Sun, 17 Jul 2011)

  Changed paths:
    M master/buildbot/steps/trigger.py

  Log Message:
  -----------
  Merge branch 'trigger' of git://github.com/tomprince/buildbot

* 'trigger' of git://github.com/tomprince/buildbot:
  Fix Trigger step when updateSourceStamp == False.

Fixes #1052





From nobody at buildbot.net  Sun Jul 17 19:56:23 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 17 Jul 2011 19:56:23 -0000
Subject: [Buildbot-commits] [Buildbot] #1052: blamelist lost via trigger
In-Reply-To: <039.c1a1ed20af5a431c7d00e91345a91371@buildbot.net>
References: <039.c1a1ed20af5a431c7d00e91345a91371@buildbot.net>
Message-ID: <054.90eeef905a6d8954a406453c72946482@buildbot.net>

#1052: blamelist lost via trigger
--------------------+---------------------
Reporter:  qzhwang  |       Owner:
    Type:  defect   |      Status:  closed
Priority:  major    |   Milestone:  0.8.2
 Version:  0.8.1    |  Resolution:  fixed
Keywords:           |
--------------------+---------------------
Changes (by Dustin J. Mitchell):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 Merge branch 'trigger' of git://github.com/tomprince/buildbot

 * 'trigger' of git://github.com/tomprince/buildbot:
   Fix Trigger step when updateSourceStamp == False.

 Fixes #1052
  Changeset: b3f7c7bb8d2797d1c92fa97de718fe18febd7627

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1052#comment:9>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Mon Jul 18 02:18:53 2011
From: noreply at github.com (noreply at github.com)
Date: Sun, 17 Jul 2011 19:18:53 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 24047d: Merge pull request
	#184 from tomprince/source
Message-ID: <20110718021855.BCB1E425C9@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 24047dba6338a084b628ccedf5cff63fcfe59d51
      https://github.com/buildbot/buildbot/commit/24047dba6338a084b628ccedf5cff63fcfe59d51
  Author: Dustin J. Mitchell <dustin at v.igoro.us>
  Date:   2011-07-17 (Sun, 17 Jul 2011)

  Changed paths:
    M master/buildbot/steps/source/git.py
  M master/buildbot/steps/source/mercurial.py

  Log Message:
  -----------
  Merge pull request #184 from tomprince/source

Get rid of _ComputeRepositoryURL from new source steps.

>From Tom's description of the pull request:

The reason for this is that _ComputeRepositoryURL has a bunch of magic to be backwards compatible with a bunch of different ways of specifying the repository. With the new renderable support, one can write code to explicitly specify any of the behaviours exposed by _ComputeRepositoryURL, with out relying on the right backwards compatibility code. I thought since we are not making the new steps entirely compatible with the old ones, it would be a good chance to get rid of the backwards compatibility magic in _ComputeRepositoryURL.





From noreply at github.com  Mon Jul 18 02:59:40 2011
From: noreply at github.com (noreply at github.com)
Date: Sun, 17 Jul 2011 19:59:40 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 90da4d: Make all
	getProperties calls use the same signatur...
Message-ID: <20110718025940.A407142581@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 90da4d9b7b2f0e0a77a9d61ca845bf98cac128a1
      https://github.com/buildbot/buildbot/commit/90da4d9b7b2f0e0a77a9d61ca845bf98cac128a1
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-17 (Sun, 17 Jul 2011)

  Changed paths:
    M master/buildbot/interfaces.py
  M master/buildbot/process/buildstep.py
  M master/buildbot/process/mtrlogobserver.py
  M master/buildbot/process/properties.py
  M master/buildbot/status/status_gerrit.py
  M master/buildbot/status/web/base.py
  M master/buildbot/status/web/build.py
  M master/buildbot/status/web/builder.py
  M master/buildbot/status/web/console.py
  M master/buildbot/status/web/feeds.py
  M master/buildbot/steps/shell.py
  M master/buildbot/steps/source/oldsource.py
  A master/buildbot/test/fake/fakebuild.py
  M master/buildbot/test/unit/test_process_buildstep.py
  M master/buildbot/test/unit/test_process_properties.py
  M master/buildbot/test/util/steps.py

  Log Message:
  -----------
  Make all getProperties calls use the same signature

This fixes the remaining implementations of getProperty that still
raised KeyError (a la dict.__getitem__) instead of returning a default
value (a la dict.get): IBuildStatus (which was simply incorrect) and
BuildStep (which now uses PropertiesMixin).

All uses of getProperties are cleaned up to expect None on a missing
property, rather than KeyError.

Fixes #2052.





From nobody at buildbot.net  Mon Jul 18 02:59:46 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 18 Jul 2011 02:59:46 -0000
Subject: [Buildbot-commits] [Buildbot] #2052: Apparent bug in
	WarningCountingShellCommand
In-Reply-To: <041.78cccc217ccd51c99fbb9ed037f80299@buildbot.net>
References: <041.78cccc217ccd51c99fbb9ed037f80299@buildbot.net>
Message-ID: <056.ddfb02e4a3045df52bb67e75d282fd3c@buildbot.net>

#2052: Apparent bug in WarningCountingShellCommand
----------------------+------------------------
Reporter:  dabrahams  |       Owner:
    Type:  defect     |      Status:  closed
Priority:  major      |   Milestone:  undecided
 Version:  0.8.4p1    |  Resolution:  fixed
Keywords:  steps      |
----------------------+------------------------
Changes (by Dustin J. Mitchell):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Make all getProperties calls use the same signature

 This fixes the remaining implementations of getProperty that still
 raised KeyError (a la dict.__getitem__) instead of returning a default
 value (a la dict.get): IBuildStatus (which was simply incorrect) and
 BuildStep (which now uses PropertiesMixin).

 All uses of getProperties are cleaned up to expect None on a missing
 property, rather than KeyError.

 Fixes #2052.
  Changeset: 90da4d9b7b2f0e0a77a9d61ca845bf98cac128a1

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2052#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Jul 18 03:04:21 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 18 Jul 2011 03:04:21 -0000
Subject: [Buildbot-commits] [Buildbot] #2052: Apparent bug in
	WarningCountingShellCommand
In-Reply-To: <041.78cccc217ccd51c99fbb9ed037f80299@buildbot.net>
References: <041.78cccc217ccd51c99fbb9ed037f80299@buildbot.net>
Message-ID: <056.533ede804ab9f59db589e830af55b6b3@buildbot.net>

#2052: Apparent bug in WarningCountingShellCommand
----------------------+------------------------
Reporter:  dabrahams  |       Owner:
    Type:  defect     |      Status:  closed
Priority:  major      |   Milestone:  undecided
 Version:  0.8.4p1    |  Resolution:  fixed
Keywords:  steps      |
----------------------+------------------------

Comment (by dustin):

 There's some good information on this bug at
   https://github.com/buildbot/buildbot/pull/187

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2052#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Jul 18 03:14:57 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 18 Jul 2011 03:14:57 -0000
Subject: [Buildbot-commits] [Buildbot] #2053: Too much code in try block
In-Reply-To: <041.cdb215f0bef975ce364ad3e6f376678d@buildbot.net>
References: <041.cdb215f0bef975ce364ad3e6f376678d@buildbot.net>
Message-ID: <056.07c488f8a1425a38b29f228c56f912ce@buildbot.net>

#2053: Too much code in try block
----------------------+--------------------
Reporter:  dabrahams  |       Owner:
    Type:  defect     |      Status:  new
Priority:  major      |   Milestone:  0.8.5
 Version:  0.8.4p2    |  Resolution:
Keywords:  simple     |
----------------------+--------------------
Changes (by dustin):

 * keywords:   => simple
 * version:  0.8.4p1 => 0.8.4p2
 * milestone:  undecided => 0.8.5


-- 
Ticket URL: <http://trac.buildbot.net/ticket/2053#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Jul 18 03:15:27 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 18 Jul 2011 03:15:27 -0000
Subject: [Buildbot-commits] [Buildbot] #2039: rmdir slaveside command
 return 0 even if it fails
In-Reply-To: <038.56d9b51ea9a24a4c7d33d12bbed7fa00@buildbot.net>
References: <038.56d9b51ea9a24a4c7d33d12bbed7fa00@buildbot.net>
Message-ID: <053.af2a63b18c6f8f9d2a609b38b5daf921@buildbot.net>

#2039: rmdir slaveside command return 0 even if it fails
--------------------+--------------------
Reporter:  in3xes   |       Owner:
    Type:  defect   |      Status:  new
Priority:  minor    |   Milestone:  0.8.5
 Version:  0.8.4p1  |  Resolution:
Keywords:           |
--------------------+--------------------
Changes (by dustin):

 * type:  undecided => defect
 * milestone:  undecided => 0.8.5


-- 
Ticket URL: <http://trac.buildbot.net/ticket/2039#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Jul 18 03:16:10 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 18 Jul 2011 03:16:10 -0000
Subject: [Buildbot-commits] [Buildbot] #2048: Also adding 'committer' to
 interested users for MailNotifier
In-Reply-To: <036.ddab455e872e0cf7c0f4c1546cd25fe3@buildbot.net>
References: <036.ddab455e872e0cf7c0f4c1546cd25fe3@buildbot.net>
Message-ID: <051.f74f219e95f29a679547b7db64b528c0@buildbot.net>

#2048: Also adding 'committer' to interested users for MailNotifier
------------------------+--------------------
Reporter:  deng         |       Owner:
    Type:  enhancement  |      Status:  new
Priority:  minor        |   Milestone:  0.8.+
 Version:  0.8.4p1      |  Resolution:
Keywords:               |
------------------------+--------------------
Changes (by dustin):

 * cc: redheadphones (added)
 * milestone:  undecided => 0.8.+


Comment:

 Derek (redheadphones) is working on support for this in the new user-
 object code.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2048#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Jul 18 03:18:26 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 18 Jul 2011 03:18:26 -0000
Subject: [Buildbot-commits] [Buildbot] #832: remove XMLRPC support
In-Reply-To: <038.3ddbbe7959b90dcacacebefe37c6c02d@buildbot.net>
References: <038.3ddbbe7959b90dcacacebefe37c6c02d@buildbot.net>
Message-ID: <053.04c46092dc25cb0878b98a97c4d9d499@buildbot.net>

#832: remove XMLRPC support
------------------------+---------------------
Reporter:  dustin       |       Owner:  dustin
    Type:  enhancement  |      Status:  closed
Priority:  major        |   Milestone:  0.8.2
 Version:  0.8.0        |  Resolution:  fixed
Keywords:               |
------------------------+---------------------

Comment (by dustin):

 The JSON interface is the only HTTP interface available.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/832#comment:6>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Jul 18 05:33:12 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 18 Jul 2011 05:33:12 -0000
Subject: [Buildbot-commits] [Buildbot] #2005: SQLAlchemy Operational
 errors with SQLite: Database is locked
In-Reply-To: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net>
References: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net>
Message-ID: <055.93775d22a284d3ac4ccaa51a2ddf1de4@buildbot.net>

#2005: SQLAlchemy Operational errors with SQLite: Database is locked
---------------------+-------------------------
Reporter:  abompard  |       Owner:
    Type:  defect    |      Status:  closed
Priority:  critical  |   Milestone:  0.8.5
 Version:  0.8.4p1   |  Resolution:  worksforme
Keywords:  database  |
---------------------+-------------------------
Changes (by dustin):

 * version:  0.8.4 => 0.8.4p1


Comment:

 I tried reproducing by writing to a table that's open in a read cursor, in
 the same thread:
 {{{
 #!python
     def test_busy(self):
         meta = sa.MetaData()
         tbl = sa.Table("tbl", meta, sa.Column("a", sa.INTEGER))
         def add(conn):
             meta.bind = conn
             tbl.create()
             conn.execute(tbl.insert(), [ dict(a=i) for i in xrange(1000)
 ])
             for r in conn.execute(tbl.select()):
                 if r.a == 0:
                     conn.execute(tbl.insert(), a=9999)
         d = self.pool.do(add)
         return d
 }}}
 but this works fine (I'm on 3.7.6.3).

 However, this fails:
 {{{
 #!python
     def test_busy(self):
         meta = sa.MetaData()
         tbl = sa.Table("tbl", meta, sa.Column("a", sa.INTEGER))
         def add(conn):
             print "add"
             meta.bind = conn
             tbl.create()
             conn.execute(tbl.insert(), [ dict(a=i) for i in xrange(100) ])
             for r in conn.execute(tbl.select()):
                 time.sleep(0.1)
         def foo(conn):
             print "foo"
             time.sleep(1)
             meta.bind = conn
             conn.execute(tbl.insert(), [ dict(a=i) for i in xrange(100) ])
         d = defer.gatherResults([self.pool.do(add), self.pool.do(foo)])
         return d
 }}}
 In particular, the insert in {{{foo}}} fails 5 seconds after it begins.  I
 think we *are* dealing with SQLITE_BUSY here, and it's being reported as
 "database is locked".  5 seconds is the default wait timeout for locking
 in sqlite3.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2005#comment:14>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Mon Jul 18 05:52:11 2011
From: noreply at github.com (noreply at github.com)
Date: Sun, 17 Jul 2011 22:52:11 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 4050c5: Set journal mode to
	WAL for SQLite
Message-ID: <20110718055211.CA2E5424D5@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 4050c5e7a2641df56f792b06fc1aea6c16221e8f
      https://github.com/buildbot/buildbot/commit/4050c5e7a2641df56f792b06fc1aea6c16221e8f
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-17 (Sun, 17 Jul 2011)

  Changed paths:
    M master/buildbot/db/enginestrategy.py

  Log Message:
  -----------
  Set journal mode to WAL for SQLite

This mode allows *much* greater concurrency, and should fix
DatabaseLocked errors (which are really SQLITE_BUSY).  Refs #2005.





From nobody at buildbot.net  Mon Jul 18 05:52:18 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 18 Jul 2011 05:52:18 -0000
Subject: [Buildbot-commits] [Buildbot] #2005: SQLAlchemy Operational
 errors with SQLite: Database is locked
In-Reply-To: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net>
References: <040.08a071a74acf7400775dd33a90e10ace@buildbot.net>
Message-ID: <055.5d11329b350bed8d5eba36ac969f5091@buildbot.net>

#2005: SQLAlchemy Operational errors with SQLite: Database is locked
---------------------+-------------------------
Reporter:  abompard  |       Owner:
    Type:  defect    |      Status:  closed
Priority:  critical  |   Milestone:  0.8.5
 Version:  0.8.4p1   |  Resolution:  worksforme
Keywords:  database  |
---------------------+-------------------------

Comment (by Dustin J. Mitchell):

 Set journal mode to WAL for SQLite

 This mode allows *much* greater concurrency, and should fix
 DatabaseLocked errors (which are really SQLITE_BUSY).  Refs #2005.
  Changeset: 4050c5e7a2641df56f792b06fc1aea6c16221e8f

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2005#comment:15>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Jul 18 18:26:57 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 18 Jul 2011 18:26:57 -0000
Subject: [Buildbot-commits] [Buildbot] #2054: buildbot/github post-receive
	URL timestamp problem
Message-ID: <038.a995ae39f282abfdaa9e1c30bf9b6676@buildbot.net>

#2054: buildbot/github post-receive URL timestamp problem
--------------------+-----------------------
Reporter:  mmorse   |      Owner:
    Type:  defect   |     Status:  new
Priority:  major    |  Milestone:  undecided
 Version:  0.8.4p1  |   Keywords:  git
--------------------+-----------------------
 I'm trying to trigger a buildbot run whenever there's a change to a github
 repo. I've added a post-receive URL service hook to the repo, and verified
 that the POST is making it back to my buildmaster. However, an exception
 is raised when that POST is processed:

 {{{
 2011-07-12 11:32:18-0700 [HTTPChannel,0,17.226.192.60] Attempting to load
 module buildbot.status.web.hooks.github
 2011-07-12 11:32:18-0700 [HTTPChannel,0,17.226.192.60] in process_change
 2011-07-12 11:32:18-0700 [HTTPChannel,0,17.226.192.60]
 ERROR:root:Encountered an exception:
 2011-07-12 11:32:18-0700 [HTTPChannel,0,17.226.192.60]
 ERROR:root:Traceback (most recent call last):
 2011-07-12 11:32:18-0700 [HTTPChannel,0,17.226.192.60] ERROR:root:File
 "/Library/Python/2.6/site-packages/buildbot/status/web/hooks/github.py",
 line 100, in getChanges
 2011-07-12 11:32:18-0700 [HTTPChannel,0,17.226.192.60]     changes =
 process_change(payload, user, repo, repo_url, project)
 2011-07-12 11:32:18-0700 [HTTPChannel,0,17.226.192.60] ERROR:root:File
 "/Library/Python/2.6/site-packages/buildbot/status/web/hooks/github.py",
 line 139, in process_change
 2011-07-12 11:32:18-0700 [HTTPChannel,0,17.226.192.60]     when =
 convertTime( commit['timestamp'])
 2011-07-12 11:32:18-0700 [HTTPChannel,0,17.226.192.60] ERROR:root:File
 "/Library/Python/2.6/site-packages/buildbot/status/web/hooks/github.py",
 line 63, in convertTime
 2011-07-12 11:32:18-0700 [HTTPChannel,0,17.226.192.60]     result.groups()
 2011-07-12 11:32:18-0700 [HTTPChannel,0,17.226.192.60]
 ERROR:root:AttributeError: 'NoneType' object has no attribute 'groups'
 2011-07-12 11:32:18-0700 [HTTPChannel,0,17.226.192.60] Got the following
 changes None
 }}}

 From what I can determine, the problem is that the timestamp coming from
 the github repo looks like this:

 {{{
 "timestamp":"2011-07-12T18:32:05Z"
 }}}

 ...but module buildbot.status.web.hooks.github is looking for something in
 the format:

 {{{
 "timestamp":"1970-01-01T00:00:00+00:00"
 }}}
 Here's the code
 (http://buildbot.net/buildbot/docs/0.8.3/reference/buildbot.status.web.hooks
 .github-pysrc.html):

 {{{
 59 def convertTime(myTestTimestamp):
 60      #"1970-01-01T00:00:00+00:00"
 61      matcher =
 re.compile(r'(\d\d\d\d)-(\d\d)-(\d\d)T(\d\d):(\d\d):(\d\d)([-+])(\d\d):(\d\d)')
 62      result  = matcher.match(myTestTimestamp)
 63      (year, month, day, hour, minute, second, offsetsign, houroffset,
 minoffset) = \
 64          result.groups()
 }}}


 Here's the configuration of the build master
 {{{
 System Version: Mac OS X Server 10.6.8 (10K540)
   Server Configuration: Advanced
   Kernel Version:       Darwin 10.8.0
   Boot Volume:  SnowLeopardServer
   Boot Mode:    Normal
   Computer Name:        DevPubsContinuousIntegration
   User Name:    BuildMaster (buildmaster)
   Secure Virtual Memory:        Not Enabled
   64-bit Kernel and Extensions: No
   Time since boot:      1 day6:37

 Buildbot version: 0.8.4p1
 Twisted version: 11.0.0

 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2054>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Mon Jul 18 18:33:03 2011
From: noreply at github.com (noreply at github.com)
Date: Mon, 18 Jul 2011 11:33:03 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 99baba: NEWS for previous
	commit
Message-ID: <20110718183303.B1170425F8@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 99babaf99b166523e12a19d3cec8714bbe446a26
      https://github.com/buildbot/buildbot/commit/99babaf99b166523e12a19d3cec8714bbe446a26
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-17 (Sun, 17 Jul 2011)

  Changed paths:
    M master/NEWS

  Log Message:
  -----------
  NEWS for previous commit


  Commit: 9cc86814796840bba577cca3927ef668ed98ddab
      https://github.com/buildbot/buildbot/commit/9cc86814796840bba577cca3927ef668ed98ddab
  Author: Dave Abrahams <dave at boostpro.com>
  Date:   2011-07-18 (Mon, 18 Jul 2011)

  Changed paths:
    M master/buildbot/status/status_gerrit.py
  M master/buildbot/steps/source/oldsource.py

  Log Message:
  -----------
  BUGFIXES: not A or not B ==> not (A and B), handle missed KeyError checks

Addresses https://github.com/buildbot/buildbot/commit/90da4d9b7b2f0e0a77a9d61ca845bf98cac128a1#master/buildbot/status/status_gerrit.py-P6 and one more in oldsource.py


  Commit: 245361b41d0e3fd6d126a6bc26bf88e8db5122c4
      https://github.com/buildbot/buildbot/commit/245361b41d0e3fd6d126a6bc26bf88e8db5122c4
  Author: Dave Abrahams <dave at boostpro.com>
  Date:   2011-07-18 (Mon, 18 Jul 2011)

  Changed paths:
    M master/buildbot/process/mtrlogobserver.py
  M master/buildbot/status/web/base.py
  M master/buildbot/status/web/console.py

  Log Message:
  -----------
  Minor cleanups made possible by 90da4d9


  Commit: 33dcefcf8cc7d03d92a5885f4dd743a586d23d32
      https://github.com/buildbot/buildbot/commit/33dcefcf8cc7d03d92a5885f4dd743a586d23d32
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-18 (Mon, 18 Jul 2011)

  Changed paths:
    M master/buildbot/process/mtrlogobserver.py
  M master/buildbot/status/status_gerrit.py
  M master/buildbot/status/web/base.py
  M master/buildbot/status/web/console.py
  M master/buildbot/steps/source/oldsource.py

  Log Message:
  -----------
  Merge branch 'volatile/keyerror2' of git://github.com/dabrahams/buildbot

* 'volatile/keyerror2' of git://github.com/dabrahams/buildbot:
  Minor cleanups made possible by 90da4d9
  BUGFIXES: not A or not B ==> not (A and B), handle missed KeyError checks


Compare: https://github.com/buildbot/buildbot/compare/4050c5e...33dcefc



From nobody at buildbot.net  Mon Jul 18 18:52:01 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 18 Jul 2011 18:52:01 -0000
Subject: [Buildbot-commits] [Buildbot] #832: remove XMLRPC support
In-Reply-To: <038.3ddbbe7959b90dcacacebefe37c6c02d@buildbot.net>
References: <038.3ddbbe7959b90dcacacebefe37c6c02d@buildbot.net>
Message-ID: <053.604969a82466fd450e689eae94998d01@buildbot.net>

#832: remove XMLRPC support
------------------------+---------------------
Reporter:  dustin       |       Owner:  dustin
    Type:  enhancement  |      Status:  closed
Priority:  major        |   Milestone:  0.8.2
 Version:  0.8.0        |  Resolution:  fixed
Keywords:               |
------------------------+---------------------

Comment (by unexist):

 Is there any doc about this? Cannot find anything related to JSON besides
 the note what module to load.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/832#comment:7>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Jul 18 19:57:19 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 18 Jul 2011 19:57:19 -0000
Subject: [Buildbot-commits] [Buildbot] #2055: buildmaster spins when build
	starts
Message-ID: <038.7c5d837314c12cddc1ef74bf0334dab5@buildbot.net>

#2055: buildmaster spins when build starts
--------------------+-----------------------
Reporter:  mmorse   |      Owner:
    Type:  defect   |     Status:  new
Priority:  major    |  Milestone:  undecided
 Version:  0.8.4p2  |   Keywords:
--------------------+-----------------------
 My buildmaster starts properly and I can access its web pages. The
 buildslave attaches properly. But, when I force a build, the build
 master's webpage stops responding and the CPU usage on the buildmaster
 host goes to 70% and stays there. Here's the description in more detail--
 an annotated log:



 Start buildmaster:
 {{{
 2011-07-18 12:23:38-0700 [-] Log opened.
 2011-07-18 12:23:38-0700 [-] twistd 11.0.0
 (/Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/Python
 2.7.2) starting up.
 2011-07-18 12:23:38-0700 [-] reactor class:
 twisted.internet.selectreactor.SelectReactor.
 2011-07-18 12:23:38-0700 [-] Applying patch for
 http://twistedmatrix.com/trac/ticket/5079
 2011-07-18 12:23:38-0700 [-] Creating BuildMaster -- buildbot.version:
 0.8.4p2
 2011-07-18 12:23:38-0700 [-] loading configuration from
 /Users/buildmaster/BuildMasters/Bookshelf/master.cfg
 2011-07-18 12:23:38-0700 [-] configuration update started
 2011-07-18 12:23:38-0700 [-] unable to import dnotify, so Maildir will use
 polling instead
 2011-07-18 12:23:38-0700 [-] WARNING: the name 'Scheduler' is deprecated;
 use SingleBranchScheduler instead
 2011-07-18 12:23:38-0700 [-] WARNING: the name 'Scheduler' is deprecated;
 use SingleBranchScheduler instead
 2011-07-18 12:23:39-0700 [-] applying SQLite workaround from Buildbot bug
 #1810
 2011-07-18 12:23:39-0700 [-] twisted.spread.pb.PBServerFactory starting on
 9987
 2011-07-18 12:23:39-0700 [-] Starting factory
 <twisted.spread.pb.PBServerFactory instance at 0x10290af38>
 2011-07-18 12:23:39-0700 [-] adding new builder Lagos-Setup-Lion for
 category None
 2011-07-18 12:23:39-0700 [-] trying to load status pickle from
 /Users/buildmaster/BuildMasters/Bookshelf/Lagos-Setup-Lion/builder
 2011-07-18 12:23:39-0700 [-] no saved status pickle, creating a new one
 2011-07-18 12:23:39-0700 [-] added builder Lagos-Setup-Lion in category
 None
 2011-07-18 12:23:39-0700 [-] adding new builder Bookshelf-Lion for
 category None
 2011-07-18 12:23:39-0700 [-] trying to load status pickle from
 /Users/buildmaster/BuildMasters/Bookshelf/Bookshelf-Lion/builder
 2011-07-18 12:23:39-0700 [-] no saved status pickle, creating a new one
 2011-07-18 12:23:39-0700 [-] added builder Bookshelf-Lion in category None
 2011-07-18 12:23:39-0700 [-] setBuilders._add:
 [<buildbot.process.botmaster.BuildRequestDistributor instance at
 0x10221d6c8>, <BuildSlave 'BookshelfTester-Lion', current builders: >]
 ['Lagos-Setup-Lion', 'Bookshelf-Lion']
 2011-07-18 12:23:39-0700 [-] adding IStatusReceiver <WebStatus on port
 tcp:8013 at 0x10237c200>
 2011-07-18 12:23:39-0700 [-] buildbot.status.web.baseweb.RotateLogSite
 starting on 8013
 2011-07-18 12:23:39-0700 [-] Starting factory
 <buildbot.status.web.baseweb.RotateLogSite instance at 0x102915cf8>
 2011-07-18 12:23:39-0700 [-] Setting up http.log rotating 10 files of
 1000000 bytes each
 2011-07-18 12:23:39-0700 [-] WebStatus using
 (/Users/buildmaster/BuildMasters/Bookshelf/public_html)
 2011-07-18 12:23:39-0700 [-] adding IStatusReceiver
 <buildbot.status.mail.MailNotifier instance at 0x1028fb878>
 2011-07-18 12:23:39-0700 [-] removing 0 old schedulers, updating 0, and
 adding 3
 2011-07-18 12:23:39-0700 [-] adding 1 new changesources, removing 0
 2011-07-18 12:23:39-0700 [-] configuration update complete
 }}}

 Slave attaches:
 {{{

 2011-07-18 12:24:44-0700 [Broker,0,17.226.12.156] slave 'BookshelfTester-
 Lion' attaching from IPv4Address(TCP, '17.226.12.156', 60215)
 2011-07-18 12:24:44-0700 [Broker,0,17.226.12.156] Starting buildslave
 keepalive timer for 'BookshelfTester-Lion'
 2011-07-18 12:24:44-0700 [Broker,0,17.226.12.156] Got slaveinfo from
 'BookshelfTester-Lion'
 2011-07-18 12:24:44-0700 [Broker,0,17.226.12.156] bot attached
 2011-07-18 12:24:44-0700 [Broker,0,17.226.12.156] Buildslave
 BookshelfTester-Lion attached to Lagos-Setup-Lion
 2011-07-18 12:24:44-0700 [Broker,0,17.226.12.156] Buildslave
 BookshelfTester-Lion attached to Bookshelf-Lion
 }}}

 I force a build:
 {{{

 2011-07-18 12:26:28-0700 [HTTPChannel,1,17.226.15.231] web forcebuild of
 builder 'Lagos-Setup-Lion', branch='', revision='', repository='',
 project='' by user 'mmorse '
 2011-07-18 12:26:28-0700 [-] added buildset 2 to database
 2011-07-18 12:26:28-0700 [-] starting build <Build Lagos-Setup-Lion> using
 slave <SlaveBuilder builder='Lagos-Setup-Lion' slave='BookshelfTester-
 Lion'>
 2011-07-18 12:26:28-0700 [-] acquireLocks(slave <BuildSlave
 'BookshelfTester-Lion', current builders: Lagos-Setup-Lion,Bookshelf-
 Lion>, locks [])
 2011-07-18 12:26:28-0700 [-] starting build <Build Lagos-Setup-Lion>..
 pinging the slave <SlaveBuilder builder='Lagos-Setup-Lion' slave
 ='BookshelfTester-Lion'>
 2011-07-18 12:26:28-0700 [-] sending ping
 2011-07-18 12:26:28-0700 [Broker,0,17.226.12.156] ping finished: success
 2011-07-18 12:26:28-0700 [-] <Build Lagos-Setup-Lion>.startBuild
 2011-07-18 12:26:28-0700 [-] ShellCommand.startCommand(cmd=<RemoteCommand
 'git' at 4338127432>)
 2011-07-18 12:26:28-0700 [-]   cmd.args = {'ignore_ignores': None,
 'retry': None, 'branch': 'master', 'reference': None, 'submodules': False,
 'shallow': False, 'patch': None, 'repourl': 'ssh://devpubs-
 bot at git.apple.com/git/DevPubs/Lagos/lagos-setup', 'workdir': 'build',
 'mode': 'clobber', 'timeout': 1200, 'progress': False, 'revision': None}
 2011-07-18 12:26:28-0700 [-] Warning: Overwriting old serialized Build at
 /Users/buildmaster/BuildMasters/Bookshelf/Lagos-Setup-Lion/0-log-git-stdio
 2011-07-18 12:26:28-0700 [-] <RemoteCommand 'git' at 4338127432>:
 RemoteCommand.run [0]
 2011-07-18 12:26:28-0700 [-] LoggedRemoteCommand.start
 2011-07-18 12:26:37-0700 [Broker,0,17.226.12.156] <RemoteCommand 'git' at
 4338127432> rc=0
 2011-07-18 12:26:37-0700 [-] closing log <buildbot.status.logfile.LogFile
 instance at 0x10291c710>
 }}}
 -----

 At this point, I notice:

 - the buildmaster's CPU usage going to about 70% and staying there (I
 killed the process after 10 minutes--the build should take considerably
 less time than that).
 - that I can no longer load the waterfall page for that buildmaster
 (although other buildmasters running on that machine are still
 responsive).
 - the process that's running out of control is Python itself. I've
 attached the sample (PythonSample.txt ) to this report.

 Killing the slave doesn't cause the master to recover. If I 'make stop'
 the buildmaster, the twistd.pid file is not removed, and the CPU usage is
 still pegged. I have to 'kill -9 <pid>' to reset things.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2055>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Jul 18 20:09:40 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 18 Jul 2011 20:09:40 -0000
Subject: [Buildbot-commits] [Buildbot] #2055: buildmaster spins when
	build starts
In-Reply-To: <038.7c5d837314c12cddc1ef74bf0334dab5@buildbot.net>
References: <038.7c5d837314c12cddc1ef74bf0334dab5@buildbot.net>
Message-ID: <053.e747493cd53344648c13f7742827dd1d@buildbot.net>

#2055: buildmaster spins when build starts
------------------------+--------------------
Reporter:  mmorse       |       Owner:
    Type:  defect       |      Status:  new
Priority:  major        |   Milestone:  0.8.5
 Version:  0.8.4p2      |  Resolution:
Keywords:  performance  |
------------------------+--------------------
Changes (by dustin):

 * keywords:   => performance
 * milestone:  undecided => 0.8.5


Comment:

 I suspect that it's actually loading the waterfall that's killing your
 performance - if you try it without any web access, how does it do?

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2055#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Jul 18 22:12:32 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 18 Jul 2011 22:12:32 -0000
Subject: [Buildbot-commits] [Buildbot] #1843: LibVirtSlave fails to
 destroy domain on buildFinished
In-Reply-To: <037.d89d89e9b5680b1588413adcb0628a19@buildbot.net>
References: <037.d89d89e9b5680b1588413adcb0628a19@buildbot.net>
Message-ID: <052.48b10ceed22c6aecafb11b583e768e63@buildbot.net>

#1843: LibVirtSlave fails to destroy domain on buildFinished
---------------------------+--------------------
Reporter:  fr4nk           |       Owner:
    Type:  defect          |      Status:  new
Priority:  major           |   Milestone:  0.8.+
 Version:  0.8.3p1         |  Resolution:
Keywords:  virtualization  |
---------------------------+--------------------

Comment (by nlmills):

 I have uploaded a patch that fixes this bug into my github repository at
 nlmills/buildbot on branch fix-1843. I have also sent a pull request for
 this patch to buildbot/buildbot.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1843#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Jul 18 23:41:35 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 18 Jul 2011 23:41:35 -0000
Subject: [Buildbot-commits] [Buildbot] #2055: buildmaster spins when
	build starts
In-Reply-To: <038.7c5d837314c12cddc1ef74bf0334dab5@buildbot.net>
References: <038.7c5d837314c12cddc1ef74bf0334dab5@buildbot.net>
Message-ID: <053.ea5bf94f974e9bce4e9cdbd79c0dba25@buildbot.net>

#2055: buildmaster spins when build starts
------------------------+--------------------
Reporter:  mmorse       |       Owner:
    Type:  defect       |      Status:  new
Priority:  major        |   Milestone:  0.8.5
 Version:  0.8.4p2      |  Resolution:
Keywords:  performance  |
------------------------+--------------------

Comment (by mmorse):

 Here's what I tried:
 - I restarted the build master and build slave and made sure. Accessed the
 waterfall to make sure the save had reconnected--there were no problems.
 - Clicked a builder to switch to the page where I could force a build, and
 forced one. I did not return to the waterfall page.
 - Observed that the Python process, which had been quiescent before I
 clicked "Force Build", was not taking about 70% CPU.

 I'm not sure how to do what you ask without any web access, so that's why
 I took the steps above. However, I doubt loading the web page is the
 problem since this page has just two columns, and used to load without
 problem. I have other build masters whose waterfalls have many columns and
 can't be seen all at once on a regular screen, and they load well, if a
 bit slowly.

 Let me know if there's a better way to run the test you suggest. Thanks.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2055#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Jul 19 03:20:41 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 19 Jul 2011 03:20:41 -0000
Subject: [Buildbot-commits] [Buildbot] #2055: buildmaster spins when
	build starts
In-Reply-To: <038.7c5d837314c12cddc1ef74bf0334dab5@buildbot.net>
References: <038.7c5d837314c12cddc1ef74bf0334dab5@buildbot.net>
Message-ID: <053.142f0008e87aeb2c95ec8c7510992595@buildbot.net>

#2055: buildmaster spins when build starts
------------------------+--------------------
Reporter:  mmorse       |       Owner:
    Type:  defect       |      Status:  new
Priority:  major        |   Milestone:  0.8.5
 Version:  0.8.4p2      |  Resolution:
Keywords:  performance  |
------------------------+--------------------

Comment (by mmorse):

 Sorry for the typos above (most importantly:'not' taking about 70% CPU
 should be 'now' taking...).

 The gist is: Python started using 70%+ CPU even though I didn't access the
 waterfall display.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2055#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul 20 00:29:26 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 20 Jul 2011 00:29:26 -0000
Subject: [Buildbot-commits] [Buildbot] #2056: builders sometimes stay in an
	idle, plus 1 state
Message-ID: <039.edd4dfa8d7509af4ad0134bd0de2f704@buildbot.net>

#2056: builders sometimes stay in an idle, plus 1 state
----------------------+-----------------------
Reporter:  dwlocks    |      Owner:
    Type:  undecided  |     Status:  new
Priority:  major      |  Milestone:  undecided
 Version:  0.8.4p2    |   Keywords:
----------------------+-----------------------
 sometimes builders sit "idle, plus #" even when there are available
 slaves.

 The bug seems to happen when many builds are running, and builders must
 wait for a slave to become available.

 Restarting either the master or the slave seems start builds, but usually
 not *all* builds.

 If many builders are waiting for the same slave, and there's a restart,
 one may build, but the others will stay idle.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2056>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul 20 02:10:54 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 20 Jul 2011 02:10:54 -0000
Subject: [Buildbot-commits] [Buildbot] #2057: AnyBranchScheduler should
 inherit from SingleBranchScheduler
Message-ID: <039.52e653e6f7431796378b31dfa1fa46f5@buildbot.net>

#2057: AnyBranchScheduler should inherit from SingleBranchScheduler
----------------------+-----------------------
Reporter:  dwlocks    |      Owner:
    Type:  undecided  |     Status:  new
Priority:  trivial    |  Milestone:  undecided
 Version:  0.8.4p2    |   Keywords:
----------------------+-----------------------
 right now it inherits from Scheduler, which means there are Deprecation
 warnings on every startup.

 buildbot/schedulers/basic.py:
 line 232:
 class AnyBranchScheduler(Scheduler):

 instead use:
 class AnyBranchScheduler(SingleBranchScheduler):

 Yay! no more deprecation warnings.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2057>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul 20 06:03:42 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 20 Jul 2011 06:03:42 -0000
Subject: [Buildbot-commits] [Buildbot] #2042: remove schedulers.state
	column
In-Reply-To: <038.093465493dc77fd489f2a277fa8cc1a7@buildbot.net>
References: <038.093465493dc77fd489f2a277fa8cc1a7@buildbot.net>
Message-ID: <053.dffacec1867db2159a72a51676c7df6a@buildbot.net>

#2042: remove schedulers.state column
-----------------------------+--------------------
Reporter:  dustin            |       Owner:
    Type:  enhancement       |      Status:  new
Priority:  major             |   Milestone:  0.8.5
 Version:  0.8.4p2           |  Resolution:
Keywords:  database, simple  |
-----------------------------+--------------------
Changes (by dustin):

 * keywords:  database => database, simple
 * version:  0.8.4p1 => 0.8.4p2


-- 
Ticket URL: <http://trac.buildbot.net/ticket/2042#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul 20 07:18:14 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 20 Jul 2011 07:18:14 -0000
Subject: [Buildbot-commits] [Buildbot] #2058: SVN docs are too prescriptive,
	wrong
Message-ID: <038.096b02a71a7fbfb3291d9a4cf56dc849@buildbot.net>

#2058: SVN docs are too prescriptive, wrong
------------------------+-------------------
Reporter:  dustin       |      Owner:
    Type:  enhancement  |     Status:  new
Priority:  major        |  Milestone:  0.8.5
 Version:  0.8.4p2      |   Keywords:  docs
------------------------+-------------------
 The docs for the SVN step get into setting up change sources, schedulers,
 and so on.  And they're even wrong (claiming that !AnyBranchScheduler
 can't do things it very well can do).

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2058>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Wed Jul 20 07:26:58 2011
From: noreply at github.com (noreply at github.com)
Date: Wed, 20 Jul 2011 00:26:58 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] a0be22: Fix #1843.
Message-ID: <20110720072658.E8635425C1@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: a0be2288a88fa05a34c9aaaa9f9b9086151b0b1b
      https://github.com/buildbot/buildbot/commit/a0be2288a88fa05a34c9aaaa9f9b9086151b0b1b
  Author: Nick Mills <millsnl at ornl.gov>
  Date:   2011-07-18 (Mon, 18 Jul 2011)

  Changed paths:
    M master/buildbot/libvirtbuildslave.py

  Log Message:
  -----------
  Fix #1843.

The `domain' member of LibVirtSlave was incorrectly initialized.


  Commit: e8e2f0b3f10214c54583615f6b6f397b9f71c791
      https://github.com/buildbot/buildbot/commit/e8e2f0b3f10214c54583615f6b6f397b9f71c791
  Author: Pradeepkumar Gayam <in3xes at gmail.com>
  Date:   2011-07-19 (Tue, 19 Jul 2011)

  Changed paths:
    M master/buildbot/steps/source/mercurial.py

  Log Message:
  -----------
  Simple mercurial fix


  Commit: 708e5d04aa2b7ac2f0c333df238c101f7fe95e1e
      https://github.com/buildbot/buildbot/commit/708e5d04aa2b7ac2f0c333df238c101f7fe95e1e
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-20 (Wed, 20 Jul 2011)

  Changed paths:
    M master/buildbot/steps/source/mercurial.py

  Log Message:
  -----------
  Merge branch 'source_bug' of git://github.com/in3xes/buildbot

* 'source_bug' of git://github.com/in3xes/buildbot:
  Simple mercurial fix


  Commit: 7872eb696a6ab81b87785b24807be49f66702124
      https://github.com/buildbot/buildbot/commit/7872eb696a6ab81b87785b24807be49f66702124
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-20 (Wed, 20 Jul 2011)

  Changed paths:
    M master/buildbot/libvirtbuildslave.py

  Log Message:
  -----------
  Merge branch 'fix-1843' of git://github.com/nlmills/buildbot

* 'fix-1843' of git://github.com/nlmills/buildbot:
  Fix #1843.


Compare: https://github.com/buildbot/buildbot/compare/33dcefc...7872eb6



From nobody at buildbot.net  Wed Jul 20 07:27:05 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 20 Jul 2011 07:27:05 -0000
Subject: [Buildbot-commits] [Buildbot] #1843: LibVirtSlave fails to
 destroy domain on buildFinished
In-Reply-To: <037.d89d89e9b5680b1588413adcb0628a19@buildbot.net>
References: <037.d89d89e9b5680b1588413adcb0628a19@buildbot.net>
Message-ID: <052.3f8a0e9d0b0d0e56bd63758d2e5204d7@buildbot.net>

#1843: LibVirtSlave fails to destroy domain on buildFinished
---------------------------+---------------------
Reporter:  fr4nk           |       Owner:
    Type:  defect          |      Status:  closed
Priority:  major           |   Milestone:  0.8.+
 Version:  0.8.3p1         |  Resolution:  fixed
Keywords:  virtualization  |
---------------------------+---------------------
Changes (by Nick Mills):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Fix #1843.

 The `domain' member of LibVirtSlave was incorrectly initialized.
  Changeset: a0be2288a88fa05a34c9aaaa9f9b9086151b0b1b

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1843#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul 20 07:27:06 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 20 Jul 2011 07:27:06 -0000
Subject: [Buildbot-commits] [Buildbot] #1843: LibVirtSlave fails to
 destroy domain on buildFinished
In-Reply-To: <037.d89d89e9b5680b1588413adcb0628a19@buildbot.net>
References: <037.d89d89e9b5680b1588413adcb0628a19@buildbot.net>
Message-ID: <052.c935fb94b5b6a5722930f5b771ccce22@buildbot.net>

#1843: LibVirtSlave fails to destroy domain on buildFinished
---------------------------+---------------------
Reporter:  fr4nk           |       Owner:
    Type:  defect          |      Status:  closed
Priority:  major           |   Milestone:  0.8.+
 Version:  0.8.3p1         |  Resolution:  fixed
Keywords:  virtualization  |
---------------------------+---------------------

Comment (by Dustin J. Mitchell):

 Merge branch 'fix-1843' of git://github.com/nlmills/buildbot

 * 'fix-1843' of git://github.com/nlmills/buildbot:
   Fix #1843.
  Changeset: 7872eb696a6ab81b87785b24807be49f66702124

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1843#comment:4>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul 20 07:29:20 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 20 Jul 2011 07:29:20 -0000
Subject: [Buildbot-commits] [Buildbot] #2057: AnyBranchScheduler should
 inherit from SingleBranchScheduler
In-Reply-To: <039.52e653e6f7431796378b31dfa1fa46f5@buildbot.net>
References: <039.52e653e6f7431796378b31dfa1fa46f5@buildbot.net>
Message-ID: <054.dff30a2701bb5f89ab9d2023b58ff1a5@buildbot.net>

#2057: AnyBranchScheduler should inherit from SingleBranchScheduler
------------------------+---------------------
Reporter:  dwlocks      |       Owner:
    Type:  enhancement  |      Status:  closed
Priority:  trivial      |   Milestone:  0.8.5
 Version:  0.8.4p2      |  Resolution:  fixed
Keywords:               |
------------------------+---------------------
Changes (by dustin):

 * status:  new => closed
 * type:  undecided => enhancement
 * resolution:   => fixed
 * milestone:  undecided => 0.8.5


Comment:

 This was fixed a while back:

 {{{
 commit e0d985ef2a622fb695f36afd7fd45e5e8f8c5dcc
 Author: Dustin J. Mitchell <dustin at mozilla.com>
 Date:   Tue Jun 21 22:57:11 2011 -0500

     inherit from BaseBasicScheduler (peer to SingleBranchScheduler)
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2057#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul 20 07:42:22 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 20 Jul 2011 07:42:22 -0000
Subject: [Buildbot-commits] [Buildbot] #832: remove XMLRPC support
In-Reply-To: <038.3ddbbe7959b90dcacacebefe37c6c02d@buildbot.net>
References: <038.3ddbbe7959b90dcacacebefe37c6c02d@buildbot.net>
Message-ID: <053.c86a579b699495a80df08baf242da1ce@buildbot.net>

#832: remove XMLRPC support
------------------------+---------------------
Reporter:  dustin       |       Owner:  dustin
    Type:  enhancement  |      Status:  closed
Priority:  major        |   Milestone:  0.8.2
 Version:  0.8.0        |  Resolution:  fixed
Keywords:               |
------------------------+---------------------

Comment (by dustin):

 Look at /json/help for online help - the only mention in the docs right
 now is in the WebStatus section.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/832#comment:8>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul 20 07:42:57 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 20 Jul 2011 07:42:57 -0000
Subject: [Buildbot-commits] [Buildbot] #2059: document JSON status
Message-ID: <038.47ba00c2c9dfdda3e64cee9c54b9fd4d@buildbot.net>

#2059: document JSON status
------------------------+-------------------
Reporter:  dustin       |      Owner:
    Type:  enhancement  |     Status:  new
Priority:  minor        |  Milestone:  0.8.5
 Version:  0.8.4p2      |   Keywords:  docs
------------------------+-------------------
 "Where is the JSON documented?" is fast becoming a FAQ - #832 is the
 latest example.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2059>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul 20 07:44:11 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 20 Jul 2011 07:44:11 -0000
Subject: [Buildbot-commits] [Buildbot] #2054: buildbot/github
 post-receive URL timestamp problem
In-Reply-To: <038.a995ae39f282abfdaa9e1c30bf9b6676@buildbot.net>
References: <038.a995ae39f282abfdaa9e1c30bf9b6676@buildbot.net>
Message-ID: <053.bf89ab50558b55037ed60ccc62cffcd6@buildbot.net>

#2054: buildbot/github post-receive URL timestamp problem
---------------------+--------------------
Reporter:  mmorse    |       Owner:
    Type:  defect    |      Status:  new
Priority:  critical  |   Milestone:  0.8.5
 Version:  0.8.4p1   |  Resolution:
Keywords:  git       |
---------------------+--------------------
Changes (by dustin):

 * priority:  major => critical
 * milestone:  undecided => 0.8.5


Comment:

 Thanks!  I wonder when Github changed this?  I suppose we should be
 liberal in what we accept, and allow both the old and new formats.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2054#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul 20 08:02:22 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 20 Jul 2011 08:02:22 -0000
Subject: [Buildbot-commits] [Buildbot] #2056: builders sometimes stay in
 an idle, plus 1 state
In-Reply-To: <039.edd4dfa8d7509af4ad0134bd0de2f704@buildbot.net>
References: <039.edd4dfa8d7509af4ad0134bd0de2f704@buildbot.net>
Message-ID: <054.e751d3f787270c0ff8d3c8e1a8739837@buildbot.net>

#2056: builders sometimes stay in an idle, plus 1 state
---------------------+--------------------
Reporter:  dwlocks   |       Owner:
    Type:  defect    |      Status:  new
Priority:  major     |   Milestone:  0.8.5
 Version:  0.8.4p2   |  Resolution:
Keywords:  database  |
---------------------+--------------------
Changes (by dustin):

 * keywords:   => database
 * type:  undecided => defect
 * milestone:  undecided => 0.8.5


Comment:

 I think this is fixed.  I'll look up the commits, and see if I can
 reproduce.  Do you have some way to indicate to me the precise version of
 the code you're running?  A tarball of your checkout, in private email,
 would do in a pinch.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2056#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul 20 08:03:58 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 20 Jul 2011 08:03:58 -0000
Subject: [Buildbot-commits] [Buildbot] #2055: buildmaster spins when
	build starts
In-Reply-To: <038.7c5d837314c12cddc1ef74bf0334dab5@buildbot.net>
References: <038.7c5d837314c12cddc1ef74bf0334dab5@buildbot.net>
Message-ID: <053.df8064189a06b68ec786c8f9dec19de8@buildbot.net>

#2055: buildmaster spins when build starts
------------------------+--------------------
Reporter:  mmorse       |       Owner:
    Type:  defect       |      Status:  new
Priority:  major        |   Milestone:  0.8.5
 Version:  0.8.4p2      |  Resolution:
Keywords:  performance  |
------------------------+--------------------

Comment (by dustin):

 The reason I asked about the web display is that I saw access to lots of
 web-related template files during the periods you described as high load,
 and the web pages are a known source of high load.

 Can you verify by watching httpd.log that nothing else is hitting the web
 status while you're monitoring the CPU?

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2055#comment:4>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul 20 14:59:51 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 20 Jul 2011 14:59:51 -0000
Subject: [Buildbot-commits] [Buildbot] #2057: AnyBranchScheduler should
 inherit from SingleBranchScheduler
In-Reply-To: <039.52e653e6f7431796378b31dfa1fa46f5@buildbot.net>
References: <039.52e653e6f7431796378b31dfa1fa46f5@buildbot.net>
Message-ID: <054.bbafa9db9578a3146f4ef85d6e11edb5@buildbot.net>

#2057: AnyBranchScheduler should inherit from SingleBranchScheduler
------------------------+---------------------
Reporter:  dwlocks      |       Owner:
    Type:  enhancement  |      Status:  closed
Priority:  trivial      |   Milestone:  0.8.5
 Version:  0.8.4p2      |  Resolution:  fixed
Keywords:               |
------------------------+---------------------

Comment (by dwlocks):

 It is fixed in master, but not in 0.8.4.  Of course you can also just say
 it's not worth fixing in the branch.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2057#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul 20 15:06:31 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 20 Jul 2011 15:06:31 -0000
Subject: [Buildbot-commits] [Buildbot] #2056: builders sometimes stay in
 an idle, plus 1 state
In-Reply-To: <039.edd4dfa8d7509af4ad0134bd0de2f704@buildbot.net>
References: <039.edd4dfa8d7509af4ad0134bd0de2f704@buildbot.net>
Message-ID: <054.35a30cf95d63f9c4cc48c2dcd37eae29@buildbot.net>

#2056: builders sometimes stay in an idle, plus 1 state
---------------------+--------------------
Reporter:  dwlocks   |       Owner:
    Type:  defect    |      Status:  new
Priority:  major     |   Milestone:  0.8.5
 Version:  0.8.4p2   |  Resolution:
Keywords:  database  |
---------------------+--------------------

Comment (by dwlocks):

 I'm running buildbot-0.8.4 branch HEAD, with an extra commit for
 svnpoller.  So if it's fixed, it's not fixed in the branch.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2056#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Thu Jul 21 03:13:45 2011
From: nobody at buildbot.net (Buildbot)
Date: Thu, 21 Jul 2011 03:13:45 -0000
Subject: [Buildbot-commits] [Buildbot] #2055: buildmaster spins when
	build starts
In-Reply-To: <038.7c5d837314c12cddc1ef74bf0334dab5@buildbot.net>
References: <038.7c5d837314c12cddc1ef74bf0334dab5@buildbot.net>
Message-ID: <053.e7345fbaa1931b82e51e4907fe0ee4ec@buildbot.net>

#2055: buildmaster spins when build starts
------------------------+--------------------
Reporter:  mmorse       |       Owner:
    Type:  defect       |      Status:  new
Priority:  major        |   Milestone:  0.8.5
 Version:  0.8.4p2      |  Resolution:
Keywords:  performance  |
------------------------+--------------------

Comment (by mmorse):

 There's nothing in the http.log file--it's zero length.

 I've been commenting out various parts of my master.cfg file to try to
 locate the part that starts Python spinning. I've found that when I
 uncomment even one of the 'deliverator_builder-*' items in the 'builders'
 array below, I get a spin. I've even tried commenting out the one build
 step (deliverator_ck_out), so that the build factory does nothing, and it
 still spins.

 If I comment out both deliverator_builders as below, then the site works
 fine, and the http.log file show access when I access the waterfall
 display.

 -------------------------------------------------------------
 {{{

 deliverator_build_steps = [
     deliverator_ck_out,
 ]

 deliverator_factory = factory.BuildFactory()
 deliverator_factory.addSteps( deliverator_build_steps )

 ## configure builders
 lagos_setup_builder_Lion = {
       'name': "Lagos-Setup-Deliverator-Lion",
       'slavename': "DeliveratorTester-Lion",
       'builddir': "Lagos-Setup-Deliverator-Lion-Build",
       'factory': lagos_setup_factory,
       }

 lagos_setup_builder_SL = {
       'name': "Lagos-Setup-Deliverator-SL",
       'slavename': "DeliveratorTester-SL",
       'builddir': "Lagos-Setup-Deliverator-SL-Build",
       'factory': lagos_setup_factory,
       }

 deliverator_builder_Lion = {
       'name': "Deliverator-Lion",
       'slavename': "DeliveratorTester-Lion",
       'builddir': "Deliverator-Lion-Build",
       'factory': deliverator_factory,
       }

 deliverator_builder_SL = {
       'name': "Deliverator-SL",
       'slavename': "DeliveratorTester-SL",
       'builddir': "Deliverator-SL-Build",
       'factory': deliverator_factory,
       }


 c['builders'] =     [
                         lagos_setup_builder_Lion,
                         lagos_setup_builder_SL,
                         # deliverator_builder_Lion,
                         # deliverator_builder_SL,
                     ]
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2055#comment:5>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Thu Jul 21 21:02:42 2011
From: nobody at buildbot.net (Buildbot)
Date: Thu, 21 Jul 2011 21:02:42 -0000
Subject: [Buildbot-commits] [Buildbot] #2055: buildmaster spins when
	build starts
In-Reply-To: <038.7c5d837314c12cddc1ef74bf0334dab5@buildbot.net>
References: <038.7c5d837314c12cddc1ef74bf0334dab5@buildbot.net>
Message-ID: <053.eda6698705a36399c436e3077b791f8a@buildbot.net>

#2055: buildmaster spins when build starts
------------------------+--------------------
Reporter:  mmorse       |       Owner:
    Type:  defect       |      Status:  new
Priority:  major        |   Milestone:  0.8.5
 Version:  0.8.4p2      |  Resolution:
Keywords:  performance  |
------------------------+--------------------

Comment (by mmorse):

 More information:
 Looks like the clue I reported above (commenting out one or more builders)
 is a red herring. I've found a reliable workaround for the issue, but it
 involves how twistd is started.

 If I start the build master with '      twistd --nodaemon --no_save -y
 buildbot.tac', I don't see the problem. If I omit the '--nodaemon', I see
 the problem (python starts to spin) as soon as I try to access the
 waterfall.

 The machine has both twisted versions 11.0.0 and 8.2.0, and the problem
 occurs with either version. I also see the problem with python 2.6 and
 2.7. I'm not sure how long this issue has been present, since I normally
 start and stop the build masters by loading/unloading the launchd plist,
 which specifies --nodaemon. I began seeing this when I set up a new
 buildmaster and used 'make start', which doesn't include the --nodaemon
 switch.

 So, I have a reliable workaround, but I'm not sure where the problem lies
 --twistd, python, Mac OS X.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2055#comment:6>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Jul 22 03:53:37 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 22 Jul 2011 03:53:37 -0000
Subject: [Buildbot-commits] [Buildbot] #1871: Goofy quoting/space
 handling in buildbot_service.py
In-Reply-To: <041.01b11010e70edfcc9095f4da89015f6c@buildbot.net>
References: <041.01b11010e70edfcc9095f4da89015f6c@buildbot.net>
Message-ID: <056.dbf0975e6bf2ceaf1af4431c4528e3f7@buildbot.net>

#1871: Goofy quoting/space handling in buildbot_service.py
----------------------+-----------------------
Reporter:  dabrahams  |       Owner:
    Type:  defect     |      Status:  assigned
Priority:  major      |   Milestone:  0.8.+
 Version:  0.8.3p1    |  Resolution:
Keywords:  windows    |
----------------------+-----------------------
Changes (by dustin):

 * keywords:  docs => windows
 * milestone:  0.8.5 => 0.8.+


Comment:

 There's still a bug to fix here - any windows devs are welcome to pick it
 up!  I suspect it has to do with cmd.exe parsing, which I do not
 understand.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1871#comment:9>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Jul 22 03:53:41 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 22 Jul 2011 03:53:41 -0000
Subject: [Buildbot-commits] [Buildbot] #1866: on reload config,
 running builds become idle in builders page
In-Reply-To: <035.ea0ea93289c89331efbd823f0ee1be0f@buildbot.net>
References: <035.ea0ea93289c89331efbd823f0ee1be0f@buildbot.net>
Message-ID: <050.8068a5acaec76f1bafbbd863937e39f5@buildbot.net>

#1866: on reload config, running builds become idle in builders page
-------------------+---------------------
Reporter:  gg0     |       Owner:
    Type:  defect  |      Status:  closed
Priority:  major   |   Milestone:  0.8.5
 Version:  0.8.3   |  Resolution:  fixed
Keywords:          |
-------------------+---------------------
Changes (by dustin):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 This status tracking has been completely rewritten in 0.8.4, so I suspect
 that this particular problem has gone away (although some very similar
 problems were added..).  Please verify if you can, and re-open if you're
 still seeing this (exact) problem.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1866#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Jul 22 03:53:47 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 22 Jul 2011 03:53:47 -0000
Subject: [Buildbot-commits] [Buildbot] #1772: vstudio.py misses compile
 errors and doesn't check for exit status
In-Reply-To: <041.e84e795e122ec83abcea86b809814a63@buildbot.net>
References: <041.e84e795e122ec83abcea86b809814a63@buildbot.net>
Message-ID: <056.dc487f364590c7e15ae0da3b88e6e785@buildbot.net>

#1772: vstudio.py misses compile errors and doesn't check for exit status
----------------------+-----------------------
Reporter:  philippem  |       Owner:
    Type:  defect     |      Status:  reopened
Priority:  major      |   Milestone:  0.8.5
 Version:  0.8.3      |  Resolution:
Keywords:  windows    |
----------------------+-----------------------

Comment (by dustin):

 phillipem - any progress here?

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1772#comment:15>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Jul 22 14:43:21 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 22 Jul 2011 14:43:21 -0000
Subject: [Buildbot-commits] [Buildbot] #2060: Trial's tests parameter
 doesn't accept Property objects
Message-ID: <038.7d397327e7d0f1d3642172069aea0921@buildbot.net>

#2060: Trial's tests parameter doesn't accept Property objects
----------------------+-----------------------
Reporter:  dwyerk     |      Owner:
    Type:  undecided  |     Status:  new
Priority:  minor      |  Milestone:  undecided
 Version:  0.8.4p1    |   Keywords:
----------------------+-----------------------
 buildbot.steps.python_twisted.Trial(tests=Property('my_tests')) causes an
 exception at python_twisted.py:411 in start():

     self.command.extend(self.tests)
 exceptions.TypeError: iteration over non-sequence

 I was able to work around it by subclassing Trial and defining a
 renderables class variable that appended "tests" to Trial.renderables, but
 I can't tell if that's the appropriate fix.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2060>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Jul 22 15:57:39 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 22 Jul 2011 15:57:39 -0000
Subject: [Buildbot-commits] [Buildbot] #1866: on reload config,
 running builds become idle in builders page
In-Reply-To: <035.ea0ea93289c89331efbd823f0ee1be0f@buildbot.net>
References: <035.ea0ea93289c89331efbd823f0ee1be0f@buildbot.net>
Message-ID: <050.4c9378705700ac97b536ff2513695504@buildbot.net>

#1866: on reload config, running builds become idle in builders page
-------------------+-----------------------
Reporter:  gg0     |       Owner:
    Type:  defect  |      Status:  reopened
Priority:  major   |   Milestone:  0.8.5
 Version:  0.8.3   |  Resolution:
Keywords:          |
-------------------+-----------------------
Changes (by dberger):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 still happens in 0.8.4p1

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1866#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Jul 22 16:56:32 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 22 Jul 2011 16:56:32 -0000
Subject: [Buildbot-commits] [Buildbot] #971: Build a windows installer
In-Reply-To: <038.6c763d0f053bc258fcb2f8f99b00326c@buildbot.net>
References: <038.6c763d0f053bc258fcb2f8f99b00326c@buildbot.net>
Message-ID: <053.2fcb8e96c156ccb8daba405404c346d3@buildbot.net>

#971: Build a windows installer
------------------------+-----------------------
Reporter:  dustin       |       Owner:  fatman2
    Type:  enhancement  |      Status:  accepted
Priority:  major        |   Milestone:  0.8.+
 Version:               |  Resolution:
Keywords:  windows      |
------------------------+-----------------------

Comment (by jollyroger):

 Replying to [comment:18 fatman2]:
 >>fatman, if you're working on this still and you're not against someone's
 help, please get in touch with me to cooperate on this task (my nickname
 on github is the same as here).
 > Just stalled a bit. What do you need? I don't use github at all.
 >
 > The source is downloadable as plain text (if you don't like Fossil) from
 the same link I posted before. The .nsi file is the whole thing.

 I looked at your source code. I didn't understand the fossil idea
 currently, so I just downloaded zip archive. Unfortunately its currently
 FTBFS. Apart from this I've found that you implement user creation,
 service handling and similar stuff. I think it would be better to have
 corresponding icons in "buildbot" menu group rather then run these
 operations once in the installer. Also I've found that you're bundling
 software installations and use lots of hardcoded paths (for example you
 stick to Python 2.6 and some install paths in "Program Files"). Also, you
 use cmake to run one simple command. Isn't this too much (adding new
 unnecessary build dependency)?

 To my mind I would leave an installer only two functions:
   * install dependencies
   * install buildbot itself

 All other actions may be done more than once(both by users and admins),
 thus I'd like to see them as a separate commands in "buildbot" menu.

 I also have done some work myself. Would be glad if you take a look on it.
 Currently this is a reimplementation of an MSI installer (uninstaller
 still not implemented). I'll add dependencies in the nearest future.

 You may get the source code here:
 [https://github.com/jollyroger/buildbot/tree/master/installer.nsi]. Sample
 installer is available here:
 [https://github.com/downloads/jollyroger/buildbot/buildbot-0.8.4p1.exe].

-- 
Ticket URL: <http://trac.buildbot.net/ticket/971#comment:22>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Jul 22 17:40:59 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 22 Jul 2011 17:40:59 -0000
Subject: [Buildbot-commits] [Buildbot] #2061: patch: make P4Poller pick up
	where it left off
Message-ID: <039.102ff57836737161cb59529187ff8b02@buildbot.net>

#2061: patch: make P4Poller pick up where it left off
------------------------+-----------------------
Reporter:  dberger      |      Owner:
    Type:  enhancement  |     Status:  new
Priority:  major        |  Milestone:  undecided
 Version:  0.8.4p2      |   Keywords:
------------------------+-----------------------
 {{{
 $ p4 diff -du ../external/buildbot-0.8.4p1/...
 --- //main/tools/external/buildbot-0.8.4p1/buildbot/changes/p4poller.py
 2011-06-28 16:38:20.000000000 -0700
 +++
 /home/buildbot/buildbot/external/buildbot-0.8.4p1/buildbot/changes/p4poller.py
 2011-06-28 16:38:20.000000000 -0700
 @@ -44,8 +44,10 @@
      """This source will poll a perforce repository for changes and submit
      them to the change master."""

      compare_attrs = ["p4port", "p4user", "p4passwd", "p4base",
 -                     "p4bin", "pollInterval"]
 +                     "p4bin", "pollInterval",
 +                     "split_file"]

      env_vars = ["P4CLIENT", "P4PORT", "P4PASSWD", "P4USER",
                  "P4CHARSET"]
 @?@ -92,6 +94,35 @@

      @defer.deferredGenerator
      def _poll(self):
 +        if self.last_change is None:
 +            # try asking the master for it's most recent processed
 +            # change, turn that into a p4 change number, and start
 +            # there
 +            try:
 +                log.msg('P4Poller: asking buildmaster for latest
 changeid')
 +                wfd = defer.waitForDeferred(
 +                    self.master.db.changes.getLatestChangeid() )
 +                yield wfd
 +                latest_change_id =  wfd.getResult()
 +                log.msg('P4Poller: asking buildmaster about changeid =
 %s' % str(latest_change_id) )
 +                wfd = defer.waitForDeferred(
 +                    self.master.db.changes.getChange( latest_change_id )
 )
 +                yield wfd
 +                chDict = wfd.getResult()
 +                revision = int( chDict.get( 'revision', -1 ) )
 +                when_timestamp = int( chDict.get( 'when_timestamp', 0 ) )
 +                now = time.time()
 +                log.msg('P4Poller: last saw revision %d on %s' % (
 revision,
 +
 time.ctime( when_timestamp ) ) )
 +                if now - when_timestamp < 0 or now - when_timestamp >
 60*24:
 +                    log.msg('P4Poller: last seen revision was in the
 future, or more than a day ago, ignoring')
 +                else:
 +                    self.last_change = int( chDict.get( 'revision', None
 ) )
 +
 +            except Exception, e:
 +                print "couldn't determine last change, starting with the
 next one: ", e
 +
          args = []
          if self.p4port:
              args.extend(['-p', self.p4port])
 @@ -124,6 +155,16 @@
                  log.msg('P4Poller: starting at change %d' % num)
                  self.last_change = num
                  return
 +
 +            if ( num - last_change ) < 0 or ( num - last_change ) >
 10000:
 +                # if we suddenly go negative, or we've seen a crazy
 number
 +                # of changes, start on the change we just saw
 +                log.msg('P4Poller: saw a ridiculous number of changes,
 starting at change %d' % num)
 +                self.last_change = num
 +                return
 +
              changelists.append(num)
          changelists.reverse() # oldest first
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2061>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Jul 22 17:42:56 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 22 Jul 2011 17:42:56 -0000
Subject: [Buildbot-commits] [Buildbot] #2061: patch: make P4Poller pick
	up where it left off
In-Reply-To: <039.102ff57836737161cb59529187ff8b02@buildbot.net>
References: <039.102ff57836737161cb59529187ff8b02@buildbot.net>
Message-ID: <054.c8b60b0222476a24b8a2f26f279a1bb9@buildbot.net>

#2061: patch: make P4Poller pick up where it left off
------------------------+------------------------
Reporter:  dberger      |       Owner:
    Type:  enhancement  |      Status:  new
Priority:  major        |   Milestone:  undecided
 Version:  0.8.4p2      |  Resolution:
Keywords:               |
------------------------+------------------------

Comment (by dberger):

 By way of explanation - I finally got tired of having to restart buildbot
 to change our P4Poller split_file, so I added split_file to the compared
 attrs for the class, which then caused the source to be re-build on
 reconfig (good) but for the poller to lose it's place (bad).  so here's a
 fix that's "working for us."

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2061#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Jul 22 18:19:40 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 22 Jul 2011 18:19:40 -0000
Subject: [Buildbot-commits] [Buildbot] #2061: patch: make P4Poller pick
	up where it left off
In-Reply-To: <039.102ff57836737161cb59529187ff8b02@buildbot.net>
References: <039.102ff57836737161cb59529187ff8b02@buildbot.net>
Message-ID: <054.c6b8fa74897145c88c3a75acd8e71e85@buildbot.net>

#2061: patch: make P4Poller pick up where it left off
------------------------+------------------------
Reporter:  dberger      |       Owner:
    Type:  enhancement  |      Status:  new
Priority:  major        |   Milestone:  undecided
 Version:  0.8.4p2      |  Resolution:
Keywords:               |
------------------------+------------------------

Comment (by dberger):

 +                when_timestamp = int( chDict.get( 'when_timestamp', 0 ) )

 should be

 +                when_timestamp = chDict.get( 'when_timestamp', 0 )

 and

 +
 time.ctime( when_timestamp ) ) )

 should be

 +
 when_timestamp.ctime() ) )

 I apparently had the unfixed version in my clipboard when I pasted.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2061#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Jul 22 18:21:24 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 22 Jul 2011 18:21:24 -0000
Subject: [Buildbot-commits] [Buildbot] #2061: patch: make P4Poller pick
	up where it left off
In-Reply-To: <039.102ff57836737161cb59529187ff8b02@buildbot.net>
References: <039.102ff57836737161cb59529187ff8b02@buildbot.net>
Message-ID: <054.6c70171036bde86e3800c1fbb0b6b0c6@buildbot.net>

#2061: patch: make P4Poller pick up where it left off
------------------------+------------------------
Reporter:  dberger      |       Owner:
    Type:  enhancement  |      Status:  new
Priority:  major        |   Milestone:  undecided
 Version:  0.8.4p2      |  Resolution:
Keywords:               |
------------------------+------------------------

Comment (by dberger):

 Arg, there was at least one more change - how 'bout I just regenerate the
 working diff and attach it.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2061#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Jul 22 21:16:57 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 22 Jul 2011 21:16:57 -0000
Subject: [Buildbot-commits] [Buildbot] #2062:
 BaseBasicScheduler.stableTimerFired can return uncaught failures
Message-ID: <039.9dc0536d33c8ac6fdf3e4f9729655a25@buildbot.net>

#2062: BaseBasicScheduler.stableTimerFired can return uncaught failures
----------------------+-----------------------
Reporter:  dwlocks    |      Owner:
    Type:  undecided  |     Status:  new
Priority:  major      |  Milestone:  undecided
 Version:  0.8.4p2    |   Keywords:
----------------------+-----------------------
 found while overriding BaseScheduler.addBuildsetForChanges.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2062>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Sun Jul 24 05:09:46 2011
From: noreply at github.com (noreply at github.com)
Date: Sat, 23 Jul 2011 22:09:46 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] b7f94b: Remove unnecessary
	code, fix constructor
Message-ID: <20110724050946.95E51424F7@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: b7f94b9ea72efab6a9b2151970054ab416e08d90
      https://github.com/buildbot/buildbot/commit/b7f94b9ea72efab6a9b2151970054ab416e08d90
  Author: Pradeepkumar Gayam <in3xes at gmail.com>
  Date:   2011-07-23 (Sat, 23 Jul 2011)

  Changed paths:
    M master/buildbot/steps/source/git.py
  M master/buildbot/steps/source/mercurial.py

  Log Message:
  -----------
  Remove unnecessary code, fix constructor


  Commit: ddd828ba4cea5358cbc62663d869283e9c8e3e11
      https://github.com/buildbot/buildbot/commit/ddd828ba4cea5358cbc62663d869283e9c8e3e11
  Author: Dustin J. Mitchell <dustin at v.igoro.us>
  Date:   2011-07-23 (Sat, 23 Jul 2011)

  Changed paths:
    M master/buildbot/steps/source/git.py
  M master/buildbot/steps/source/mercurial.py

  Log Message:
  -----------
  Merge pull request #193 from in3xes/source_bug

Remove unnecessary code


Compare: https://github.com/buildbot/buildbot/compare/7872eb6...ddd828b



From noreply at github.com  Mon Jul 25 18:44:09 2011
From: noreply at github.com (noreply at github.com)
Date: Mon, 25 Jul 2011 11:44:09 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 407ad3: Merge
	remote-tracking branch 'lorentz/master'
Message-ID: <20110725184409.AA91C42308@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 407ad39e2df8fa1bce91f9d5d07f29d0b6f2f49a
      https://github.com/buildbot/buildbot/commit/407ad39e2df8fa1bce91f9d5d07f29d0b6f2f49a
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-25 (Mon, 25 Jul 2011)

  Changed paths:
    M master/NEWS
  M master/buildbot/ec2buildslave.py
  M master/buildbot/status/build.py
  M master/buildbot/status/builder.py
  M master/buildbot/status/logfile.py
  M master/buildbot/test/unit/test_status_logfile.py

  Log Message:
  -----------
  Merge remote-tracking branch 'lorentz/master'

* lorentz/master:
  Tests for buildbot.status.logfile.LogFile (incomplete)
  Terminate EC2 instances instead of stopping them.





From nobody at buildbot.net  Mon Jul 25 19:14:03 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 25 Jul 2011 19:14:03 -0000
Subject: [Buildbot-commits] [Buildbot] #2022: Stale Broker errors not
	caught on reconfig
In-Reply-To: <038.381285500e2095ef29e1264f09ac6406@buildbot.net>
References: <038.381285500e2095ef29e1264f09ac6406@buildbot.net>
Message-ID: <053.54418691016e42566c610628155ff166@buildbot.net>

#2022: Stale Broker errors not caught on reconfig
---------------------+--------------------
Reporter:  dustin    |       Owner:
    Type:  defect    |      Status:  new
Priority:  major     |   Milestone:  0.8.5
 Version:  0.8.2     |  Resolution:
Keywords:  reconfig  |
---------------------+--------------------

Comment (by dustin):

 So {{{setBuilderList}}} is not the culprit here - the pinging of the old
 slave is the culprit.  The new {{{DuplicateSlaveArbitrator}}} *tries* to
 handle this, but sadly {{{callRemote}}} sometimes raises an exception
 instead of returning a failing Deferred.

 {{{
 #!python
         d = self.old_slave.slave.callRemote("print",
             "master got a duplicate connection from %s; keeping this one"
 % new_peer)
 }}}

 the deferred has errbacks attached to it, so we need to arrange for those
 to be called for an exception, too -- easily done with
 {{{defer.maybeDeferred}}}.

 However, this should have some testing (how?), as I don't particularly
 trust the code in start_new_slave that tries to call {{{loseConnection}}}
 on the old slave, but never actually calls its {{{detached}}} method.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2022#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Jul 25 20:09:57 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 25 Jul 2011 20:09:57 -0000
Subject: [Buildbot-commits] [Buildbot] #971: Build a windows installer
In-Reply-To: <038.6c763d0f053bc258fcb2f8f99b00326c@buildbot.net>
References: <038.6c763d0f053bc258fcb2f8f99b00326c@buildbot.net>
Message-ID: <053.6957a715a951f3f91b876aee6f506a33@buildbot.net>

#971: Build a windows installer
------------------------+-----------------------
Reporter:  dustin       |       Owner:  fatman2
    Type:  enhancement  |      Status:  accepted
Priority:  major        |   Milestone:  0.8.+
 Version:               |  Resolution:
Keywords:  windows      |
------------------------+-----------------------

Comment (by jollyroger):

 From today's conversation with Dustin on IRC:

  * Installer should install buildbot and its dependencies. Creating users,
 registering services and other similar operations are better performed
 with tools installed together with buildbot or by hand (untill such tools
 appear in the buildbot).
  * Dependencies are better installed by downloading and running
 correspondent installers rather than bundling into the installer itself.
 To achieve this, buildbot.net will host an INI file which contains
 download URLs for all needed dependencies for every supported platform.
 (Optionally) The downloads directory may be preserved after installation
 for future use.
  * Installer should be able to install buildbot for Python 2.x branch >=
 2.4 version (e.g. 2.4-2.7).

 I propose the following installer workflow:
  1. Detect available Python versions and buildbot's dependencies. List all
 possible Python versions and buildbot dependencies(listed as subsections
 to respective Python section). Note status of the dependencies for every
 Python section (installed/not installed). User selects Python versions
 where buildbot will be installed and goes to the next installation screen.
  2. The next step should be downloading dependencies and installing them.
 Installer downloads files and runs installations. If all dependencies are
 available, the step is skipped. If any of the dependencies' setup exited
 with failure, the users is asked wether to retry. After all installations
 finished successfully, we check again status of the dependencies(this is
 because some installations would allow to install Python packages to the
 several Python environments in one run) and notify user if those are not
 equal to what user requested. Here user may ask to install the forgotten
 dependencies or to drop buildbot installation for current Python section
 at all.
  3. Installing buildbot itself. This includes copying files and generating
 precompiled *.pyc files.
  4. Creating links and menu groups. Currently didn't go far into details.

 Currently I work on functions that will detect installed dependencies.
 These are needed anyway.

 Another question to discuss is the uninstaller. It is surely will be
 written, but I have doubts about where it should be located. Since we
 could install buildbot into several places at once, the uninstaller should
 have some common place or else we should generate uninstaller for every
 Python environment. The uninstaller's behavior is an open question though.
 Should it remove all installed files from all environments at once or just
 remove buildbot code from the corresponding Python environment? Ideas are
 welcome.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/971#comment:23>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Jul 26 00:28:23 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 26 Jul 2011 00:28:23 -0000
Subject: [Buildbot-commits] [Buildbot] #971: Build a windows installer
In-Reply-To: <038.6c763d0f053bc258fcb2f8f99b00326c@buildbot.net>
References: <038.6c763d0f053bc258fcb2f8f99b00326c@buildbot.net>
Message-ID: <053.e16f6fb33a128c9d4f4efbea9e748a73@buildbot.net>

#971: Build a windows installer
------------------------+-----------------------
Reporter:  dustin       |       Owner:  fatman2
    Type:  enhancement  |      Status:  accepted
Priority:  major        |   Milestone:  0.8.+
 Version:               |  Resolution:
Keywords:  windows      |
------------------------+-----------------------

Comment (by fatman2):

 Long post coming up!

 Replying to [comment:22 jollyroger]:
 > I looked at your source code. I didn't understand the fossil idea
 currently,

 Umm, yeah, that's probably my fault. I've misconfigured my Fossil repos
 somehow. Sorry.

 > so I just downloaded zip archive.

 Good, that part still works.

 > Unfortunately its currently FTBFS.

 Yes, I left it very much a work-in-progress for others to pick apart. And
 for me to come back to occasionally.

 > you implement user creation, service handling and similar ... better to
 have corresponding icons in "buildbot" menu

 I intended this to be a monolithic installer that would take the user from
 "no Buildbot installed" to "functional Buildbot up and running" as quickly
 as possible. Some parts of the install are painful even for an experienced
 Windows user and sysadmin, and it's easy to go wrong and not know why. In
 my opinion, the whole thing can and should be automated.

 > bundling software installations

 There isn't any particular reason for this. No one objected at the time.
 It can be changed if you want.

 > Python 2.6

 I could only get Buildbot working at all with Python 2.6. It simply won't
 install for me under Windows 7 with Python 2.7. I think the "howto"
 instructions are out of date to be honest. I'm just doing the best I can
 with what I've got. :)

 > hardcoded paths ... and some install paths in "Program Files"

 Yes, I don't like this either. I was intending to remove the hardcoded
 paths after I got the installer basically working. The "Program Files"
 problem isn't easy to solve because Windows has no single standard
 location for user programs like other operating systems do.

 > cmake ... Isn't this too much (adding new unnecessary build dependency)?

 There's no dependency. The Fossil repository is just an image of my own
 working directory. The NSIS scripts are the important thing. They don't
 depend on CMake at all. I happen to use CMake because I like it, but if
 you don't, then feel free to delete CMakeLists.txt and the cmake dir.
 Nothing bad will happen.

 > I would leave an installer only two functions:

 It certainly makes sense from a purist angle, but the problem is that
 Buildbot isn't an ordinary program. There are a lot of fiddly little tasks
 that need doing (set up a user, log on as that user, set up service, log
 out, etc) that could be done so much more easily with a script.

 > other actions may be done more than once ... separate commands in
 "buildbot" menu

 Good point. A simple installer can't take care of this. I suggest we need
 an administration program to take care of each "slave herd", but until we
 sort that out your menu icons might be the best way to go. The installer
 should install only one master or only one slave (or only one of each),
 plus your admin icons to add/delete slaves, etc. Does it make sense to
 have more than one master per machine? Yes, I think so.

 > done some work ... take a look

 Cool, I'll check it out.

 Replying to [comment:23 jollyroger]:
 >  * Installer should install buildbot and its dependencies.

 Agree.

 > Creating users, registering services ... tools installed together with
 buildbot or by hand

 Disagree very much for reasons stated above.

 >  * Dependencies are better installed by downloading ... buildbot.net
 will host an INI file

 Ooh, nifty. Agree very much.

 >  * Installer should be able to install buildbot for Python 2.x branch >=
 2.4

 Eeek! Have you tried this? Agreed it needs to be done. Stupid twisty
 Python. :P

 > I propose the following installer workflow:
 >  1. Detect available Python versions and buildbot's dependencies. List
 all possible Python versions and buildbot dependencies(listed as
 subsections to respective Python section). Note status of the dependencies
 for every Python section (installed/not installed). User selects Python
 versions where buildbot will be installed and goes to the next
 installation screen.

 Yes.

 >  2. The next step should be downloading dependencies and installing
 them. Installer downloads files and runs installations. If all
 dependencies are available, the step is skipped. If any of the
 dependencies' setup exited with failure, the users is asked wether to
 retry. After all installations finished successfully, we check again
 status of the dependencies(this is because some installations would allow
 to install Python packages to the several Python environments in one run)
 and notify user if those are not equal to what user requested. Here user
 may ask to install the forgotten dependencies or to drop buildbot
 installation for current Python section at all.

 Yes.

 >  3. Installing buildbot itself. This includes copying files and
 generating precompiled *.pyc files.

 Yes.

 >  4. Creating links and menu groups. Currently didn't go far into
 details.

 I suggest links for creating and destroying herds of masters and slaves.

 > Currently I work on functions that will detect installed dependencies.
 These are needed anyway.

 True.

 > Another question to discuss is the uninstaller. It is surely will be
 written, but I have doubts about where it should be located. Since we
 could install buildbot into several places at once, the uninstaller should
 have some common place or else we should generate uninstaller for every
 Python environment. The uninstaller's behavior is an open question though.
 Should it remove all installed files from all environments at once or just
 remove buildbot code from the corresponding Python environment? Ideas are
 welcome.

 Oh boy. This is a biggy. I have several opinions on this, all conflicting.
 More discussion needed.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/971#comment:24>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Jul 26 05:50:56 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 26 Jul 2011 05:50:56 -0000
Subject: [Buildbot-commits] [Buildbot] #827: ChangeSources may produce
 changes containing non-ascii bytestrings
In-Reply-To: <038.ae761c4a7372f16842cdf0af25f40038@buildbot.net>
References: <038.ae761c4a7372f16842cdf0af25f40038@buildbot.net>
Message-ID: <053.87a5e188bccd3b65ae22c001109dc480@buildbot.net>

#827: ChangeSources may produce changes containing non-ascii bytestrings
------------------------------+-----------------------
Reporter:  dustin             |       Owner:
    Type:  defect             |      Status:  reopened
Priority:  critical           |   Milestone:  0.8.5
 Version:  0.7.12             |  Resolution:
Keywords:  encoding database  |
------------------------------+-----------------------
Changes (by dustin):

 * status:  closed => reopened
 * resolution:  fixed =>
 * milestone:  0.8.+ => 0.8.5


-- 
Ticket URL: <http://trac.buildbot.net/ticket/827#comment:17>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Jul 26 05:51:35 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 26 Jul 2011 05:51:35 -0000
Subject: [Buildbot-commits] [Buildbot] #2057: AnyBranchScheduler should
 inherit from SingleBranchScheduler
In-Reply-To: <039.52e653e6f7431796378b31dfa1fa46f5@buildbot.net>
References: <039.52e653e6f7431796378b31dfa1fa46f5@buildbot.net>
Message-ID: <054.075e6d0a3aa6e0503b004f9f284c1af6@buildbot.net>

#2057: AnyBranchScheduler should inherit from SingleBranchScheduler
------------------------+---------------------
Reporter:  dwlocks      |       Owner:
    Type:  enhancement  |      Status:  closed
Priority:  trivial      |   Milestone:  0.8.5
 Version:  0.8.4p2      |  Resolution:  fixed
Keywords:               |
------------------------+---------------------

Comment (by dustin):

 There won't be any more 0.8.4 releases, so it's not worth fixing there.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2057#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Jul 26 05:56:07 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 26 Jul 2011 05:56:07 -0000
Subject: [Buildbot-commits] [Buildbot] #2055: buildmaster spins when
	build starts
In-Reply-To: <038.7c5d837314c12cddc1ef74bf0334dab5@buildbot.net>
References: <038.7c5d837314c12cddc1ef74bf0334dab5@buildbot.net>
Message-ID: <053.ba85bea5b6e82b9cfb97d4d0e09e5e0a@buildbot.net>

#2055: buildmaster spins when build starts
------------------------+--------------------
Reporter:  mmorse       |       Owner:
    Type:  defect       |      Status:  new
Priority:  major        |   Milestone:  0.8.5
 Version:  0.8.4p2      |  Resolution:
Keywords:  performance  |
------------------------+--------------------

Comment (by dustin):

 I bet this is related to launchd and mach contexts somehow..

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2055#comment:7>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Jul 26 05:58:27 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 26 Jul 2011 05:58:27 -0000
Subject: [Buildbot-commits] [Buildbot] #2060: Trial's tests parameter
 doesn't accept Property objects
In-Reply-To: <038.7d397327e7d0f1d3642172069aea0921@buildbot.net>
References: <038.7d397327e7d0f1d3642172069aea0921@buildbot.net>
Message-ID: <053.1398900e2ecbc2a77c3bb18baca15e84@buildbot.net>

#2060: Trial's tests parameter doesn't accept Property objects
----------------------+--------------------
Reporter:  dwyerk     |       Owner:
    Type:  undecided  |      Status:  new
Priority:  minor      |   Milestone:  0.8.5
 Version:  0.8.4p1    |  Resolution:
Keywords:  simple     |
----------------------+--------------------
Changes (by dustin):

 * keywords:   => simple
 * milestone:  undecided => 0.8.5


-- 
Ticket URL: <http://trac.buildbot.net/ticket/2060#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Jul 26 05:58:36 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 26 Jul 2011 05:58:36 -0000
Subject: [Buildbot-commits] [Buildbot] #2060: Trial's tests parameter
 doesn't accept Property objects
In-Reply-To: <038.7d397327e7d0f1d3642172069aea0921@buildbot.net>
References: <038.7d397327e7d0f1d3642172069aea0921@buildbot.net>
Message-ID: <053.26301702f8683fa1408114b533a37caa@buildbot.net>

#2060: Trial's tests parameter doesn't accept Property objects
------------------------+--------------------
Reporter:  dwyerk       |       Owner:
    Type:  enhancement  |      Status:  new
Priority:  minor        |   Milestone:  0.8.5
 Version:  0.8.4p1      |  Resolution:
Keywords:  simple       |
------------------------+--------------------
Changes (by dustin):

 * type:  undecided => enhancement


-- 
Ticket URL: <http://trac.buildbot.net/ticket/2060#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Tue Jul 26 06:38:56 2011
From: noreply at github.com (noreply at github.com)
Date: Mon, 25 Jul 2011 23:38:56 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 046b2d: Merge branch
	'trial_pythonpath_fix' of git://githu...
Message-ID: <20110726063856.D890442516@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 046b2db09673f59b4c85c85241f5f189ad2c67db
      https://github.com/buildbot/buildbot/commit/046b2db09673f59b4c85c85241f5f189ad2c67db
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-25 (Mon, 25 Jul 2011)

  Changed paths:
    M master/buildbot/steps/python_twisted.py
  A master/buildbot/test/unit/test_steps_python_twisted.py

  Log Message:
  -----------
  Merge branch 'trial_pythonpath_fix' of git://github.com/NateBragg/buildbot into trial_pythonpath_fix

* 'trial_pythonpath_fix' of git://github.com/NateBragg/buildbot:
  Unit test, union fix
  Fix trial step's handling of pythonpath


  Commit: 7c97db156427666174aa8f006d0dc4df062fded1
      https://github.com/buildbot/buildbot/commit/7c97db156427666174aa8f006d0dc4df062fded1
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-25 (Mon, 25 Jul 2011)

  Changed paths:
    M master/buildbot/steps/python_twisted.py
  M master/buildbot/test/unit/test_steps_python_twisted.py

  Log Message:
  -----------
  ensure that PYTHONPATH order does not change

This also updates the tests to use ExpectShell.log, and adds some more
tests.


  Commit: 22a0d692945d0442e4205f1604c6af65f15ad204
      https://github.com/buildbot/buildbot/commit/22a0d692945d0442e4205f1604c6af65f15ad204
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-25 (Mon, 25 Jul 2011)

  Changed paths:
    M master/buildbot/steps/python_twisted.py
  A master/buildbot/test/unit/test_steps_python_twisted.py

  Log Message:
  -----------
  Merge branch 'trial_pythonpath_fix'

* trial_pythonpath_fix:
  ensure that PYTHONPATH order does not change
  Unit test, union fix
  Fix trial step's handling of pythonpath


Compare: https://github.com/buildbot/buildbot/compare/407ad39...22a0d69



From nobody at buildbot.net  Tue Jul 26 09:57:04 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 26 Jul 2011 09:57:04 -0000
Subject: [Buildbot-commits] [Buildbot] #971: Build a windows installer
In-Reply-To: <038.6c763d0f053bc258fcb2f8f99b00326c@buildbot.net>
References: <038.6c763d0f053bc258fcb2f8f99b00326c@buildbot.net>
Message-ID: <053.2116b3a0459237605d12fd5ca5e18bd7@buildbot.net>

#971: Build a windows installer
------------------------+-----------------------
Reporter:  dustin       |       Owner:  fatman2
    Type:  enhancement  |      Status:  accepted
Priority:  major        |   Milestone:  0.8.+
 Version:               |  Resolution:
Keywords:  windows      |
------------------------+-----------------------

Comment (by jollyroger):

 Replying to [comment:24 fatman2]:
 > I intended this to be a monolithic installer that would take the user
 from "no Buildbot installed" to "functional Buildbot up and running" as
 quickly as possible. Some parts of the install are painful even for an
 experienced Windows user and sysadmin, and it's easy to go wrong and not
 know why. In my opinion, the whole thing can and should be automated.

 I'd like to propose some different alternative for this. What if we just
 leave just the installation and dependencies to the installer and run some
 "New buildbot instance" wizard right after the installation as some
 software under windows does (some antiviruses or software that needs to be
 configured anyway before it begins to work correctly). Also, this would be
 a common task, so there should be a link for it in "menu" group.

 > > hardcoded paths ... and some install paths in "Program Files"
 >
 > Yes, I don't like this either. I was intending to remove the hardcoded
 paths after I got the installer basically working. The "Program Files"
 problem isn't easy to solve because Windows has no single standard
 location for user programs like other operating systems do.

 Anyway every Python environment will write its $PYTHONDIR/Scripts into the
 $PATH variable. Futhermore, there is a common structure for binary
 distributions of Python modules (including buildbot). Look into "Compile-
 time preparations" section in my source code. The main idea there is to
 ask Python generate binary distribution, extract it to NSIS build
 directory and remove precompiled *.pyc (they would be generated again on a
 target box anyway for every Python installer where buildbot would be
 installed to). My code also generates installer in form
 "buildbot-$VERSION.exe".

 > > cmake ... Isn't this too much (adding new unnecessary build
 dependency)?
 >
 > There's no dependency. The Fossil repository is just an image of my own
 working directory. The NSIS scripts are the important thing. They don't
 depend on CMake at all. I happen to use CMake because I like it, but if
 you don't, then feel free to delete CMakeLists.txt and the cmake dir.
 Nothing bad will happen.

 I'm aware of this. I was at fist confused with build problems and thought
 that CMake infrastructure has something to do with this. But it happened
 that your CMakeLists.txt required cl.exe just to generate makefiles so I
 downloaded (in addition to cmake) express edition of Visual studio just to
 assure that I'm not doing anything wrong(though I should have looked into
 the CMakeLists.txt itself at first). That was not a good start and I think
 anyone willing to look on windows installer will in the end be much
 confused with this much of unneeded code and software required just to
 build an installer.

 > > I would leave an installer only two functions:
 > It certainly makes sense from a purist angle, but the problem is that
 Buildbot isn't an ordinary program. There are a lot of fiddly little tasks
 that need doing (set up a user, log on as that user, set up service, log
 out, etc) that could be done so much more easily with a script.

 See my thoughts on the wizard above.

 > > other actions may be done more than once ... separate commands in
 "buildbot" menu
 > Good point. A simple installer can't take care of this. I suggest we
 need an administration program to take care of each "slave herd", but
 until we sort that out your menu icons might be the best way to go. The
 installer should install only one master or only one slave (or only one of
 each), plus your admin icons to add/delete slaves, etc. Does it make sense
 to have more than one master per machine? Yes, I think so.

 Again, the wizard should solve this. On this stage you'll have already
 installed buildbot code (with no instances) and are in the process of
 creating a new instance. Even if you cancel this operation, this won't
 affect the installer since it has already exited. But you'll be able to
 run the operation again from the menu group.

 > > Creating users, registering services ... tools installed together with
 buildbot or by hand
 > Disagree very much for reasons stated above.
 Again, this should not be a part of the installer but some wizard.

 > >  * Installer should be able to install buildbot for Python 2.x branch
 >= 2.4
 > Eeek! Have you tried this? Agreed it needs to be done. Stupid twisty
 Python. :P

 See my code and maybe try my installer, I've already implemented
 installing buildbot to different installed Python versions at once.
 However this will be reworked to add dependencies subsections for each
 Python distribution.

 > > I propose the following installer workflow:
 > >  4. Creating links and menu groups. Currently didn't go far into
 details.
 >
 > I suggest links for creating and destroying herds of masters and slaves.
 The problem is that we can make Buildbot menu group overbloated with lots
 of options because there are lots of parameters to vary. I suggest to have
 "New master wizard" and "Uninstall master" menu options in the root of
 buildbot menu group together with "instances" directory. Each directory
 would have subdirectory in form "<bot name> (Python <PYTHONVERSION>)" with
 links to start, stop and remove bot (and maybe additional
 option:configure, if someone will write a gui someday, but this is a kind
 of silly).

 > > Another question to discuss is the uninstaller. It is surely will be
 written, but I have doubts about where it should be located. Since we
 could install buildbot into several places at once, the uninstaller should
 have some common place or else we should generate uninstaller for every
 Python environment. The uninstaller's behavior is an open question though.
 Should it remove all installed files from all environments at once or just
 remove buildbot code from the corresponding Python environment? Ideas are
 welcome.
 >
 > Oh boy. This is a biggy. I have several opinions on this, all
 conflicting. More discussion needed.
 Here what I'm thinking about this. Buildbot installs all its code inside
 the Python environment. This means we don't need an extra directory in
 Program Files. However there is only uninstaller that has nothing to go.
 It would be wrong to put uninstaller only in one Python environment,
 because all other Python environments are neither worse nor better.

 I mentioned two ways of uninstaller's logic: remove the buildbot code just
 from current Python environment or remove it at all. However, when I think
 about it, this may require to have lots of menu groups like "Buildbot for
 Python 2.4/2.5/2.6/2.7" or relative subgroups in general "Buildbot" menu
 which is not very great too.

 If we can write additional uninstaller page to give a possibility to
 remove buildbot code from desired Python environments, this would be uber
 great.

 NSIS can generate lots of equal uninstallers and I checked that already.
 All is left to do is to store install options to register during
 installation, read them during uninstall process, remove the buildbot code
 and all uninstallers that left behind.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/971#comment:25>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Jul 26 12:14:51 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 26 Jul 2011 12:14:51 -0000
Subject: [Buildbot-commits] [Buildbot] #2063: Documentation for IRC bot
	configuration is wrong
Message-ID: <035.0b4f6f289360a98c2fef3d53ed0d1f76@buildbot.net>

#2063: Documentation for IRC bot configuration is wrong
--------------------+--------------------------------
Reporter:  ajb      |      Owner:
    Type:  defect   |     Status:  new
Priority:  major    |  Milestone:  undecided
 Version:  0.8.3p1  |   Keywords:  documentation, irc
--------------------+--------------------------------
 The manual currently describes configuring the IRC bot as:

 {{{
     from buildbot.status import words
      irc = words.IRC("irc.example.org", "botnickname",
                      channels=[{"channel": "#example1"},
                                {"channel": "#example2",
                                 "password": "somesecretpassword"}],
                      password="mysecretnickservpassword",
                      notify_events={
                        'exception': 1,
                        'successToFailure': 1,
                        'failureToSuccess': 1,
                      })
 }}}

 This was resulting in a failure to logon with the following backtrace:

 {{{

 2011-07-25 16:25:26+0100 [IrcStatusBot,client] Unhandled Error
         Traceback (most recent call last):
           File "/usr/lib/python2.6/dist-packages/twisted/internet/tcp.py",
 line 460, in doRead
             return self.protocol.dataReceived(data)
           File "/usr/lib/python2.6/dist-
 packages/twisted/words/protocols/irc.py", line 2279, in dataReceived
             basic.LineReceiver.dataReceived(self, data.replace('\r', ''))
           File "/usr/lib/python2.6/dist-
 packages/twisted/protocols/basic.py", line 251, in dataReceived
             why = self.lineReceived(line)
           File "/usr/lib/python2.6/dist-
 packages/twisted/words/protocols/irc.py", line 2287, in lineReceived
             self.handleCommand(command, prefix, params)
         --- <exception caught here> ---
           File "/usr/lib/python2.6/dist-
 packages/twisted/words/protocols/irc.py", line 2331, in handleCommand
             method(prefix, params)
           File "/usr/lib/python2.6/dist-
 packages/twisted/words/protocols/irc.py", line 1726, in irc_RPL_WELCOME
             self.signedOn()
           File "/usr/lib/python2.6/dist-
 packages/buildbot/status/words.py", line 793, in signedOn
             self.join(c)
           File "/usr/lib/python2.6/dist-
 packages/twisted/words/protocols/irc.py", line 1327, in join
             if channel[0] not in CHANNEL_PREFIXES:
         exceptions.KeyError: 0

 }}}

 After examining the code it seems it's looking for a simple list of
 channels. For example:

 {{{

 from buildbot.status import words
 irc = words.IRC("localhost", "buildbot",
                 channels=["#eng"],
                 password="buildbot_nick_pw",
                 notify_events={
         'exception': 1,
         'successToFailure': 1,
         'failureToSuccess': 1,
         })
 c['status'].append(irc)
 }}}

 This configuration worked fine.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2063>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Jul 26 16:09:54 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 26 Jul 2011 16:09:54 -0000
Subject: [Buildbot-commits] [Buildbot] #971: Build a windows installer
In-Reply-To: <038.6c763d0f053bc258fcb2f8f99b00326c@buildbot.net>
References: <038.6c763d0f053bc258fcb2f8f99b00326c@buildbot.net>
Message-ID: <053.40f2de1660037fe29b9a92ace45f8e1f@buildbot.net>

#971: Build a windows installer
------------------------+-----------------------
Reporter:  dustin       |       Owner:  fatman2
    Type:  enhancement  |      Status:  accepted
Priority:  major        |   Milestone:  0.8.+
 Version:               |  Resolution:
Keywords:  windows      |
------------------------+-----------------------

Comment (by dustin):

 As far as how much to do in the installer: if the installer does
 everything, including setting up and starting/stopping masters and slaves,
 then it will make a lot of assumptions which may be invalid for some
 users' environments.  It's also a lot more work, a lot more decisions to
 make, and a lot more to support -- especially for a project that doesn't
 have a lot of windows users in IRC or on the mailing list.

 So I'd recommend keeping this bug limited to shipping a basic get-
 buildbot-installed installer that is simple and can be maintained by
 someone (me) who doesn't use windows.

 Once this is done, if you want to either make a "turnkey" installer, or
 add options to create/destroy masters, that can be another bug.

 Basically, I'm saying, let's keep it simple to start with.  Sound good?

-- 
Ticket URL: <http://trac.buildbot.net/ticket/971#comment:26>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Jul 26 16:56:07 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 26 Jul 2011 16:56:07 -0000
Subject: [Buildbot-commits] [Buildbot] #971: Build a windows installer
In-Reply-To: <038.6c763d0f053bc258fcb2f8f99b00326c@buildbot.net>
References: <038.6c763d0f053bc258fcb2f8f99b00326c@buildbot.net>
Message-ID: <053.8d4ec1d749e670a53cf9493b8fd752b3@buildbot.net>

#971: Build a windows installer
------------------------+-----------------------
Reporter:  dustin       |       Owner:  fatman2
    Type:  enhancement  |      Status:  accepted
Priority:  major        |   Milestone:  0.8.+
 Version:               |  Resolution:
Keywords:  windows      |
------------------------+-----------------------

Comment (by fatman2):

 Replying to [comment:25 jollyroger]:
 > Replying to [comment:24 fatman2]:
 > > monolithic installer ... the whole thing can and should be automated
 ... administration program ... admin icons
 >
 > run some "New buildbot instance" wizard right after the installation ...
 there should be a link for it in "menu" group ... wizard should solve
 this. On this stage you'll have already installed buildbot code (with no
 instances) and are in the process of creating a new instance. Even if you
 cancel this operation, this won't affect the installer since it has
 already exited. But you'll be able to run the operation again from the
 menu group.

 This is starting to sound good. The more I think about it, though, the
 more unhappy I become with the idea of the Start Menu as a place to put
 configuration icons. Surely we should be using the Control Panel instead?
 That's what it's designed for. Plus, a Control Panel would be more fun to
 code up. ;)

 > > hardcoded paths ... "Program Files" problem
 >
 > every Python environment will write its $PYTHONDIR/Scripts into the
 $PATH variable

 This raises the spectre of "version hell", which I suspect might have been
 part of the cause of my troubles installing. Suppose we have the Buildbot
 script installed in three Python versions and all the relevant paths in
 PATH. (I'm not sure why we'd do that, except for testing.) We'd have to be
 very careful to pick the right one every time.

 > there is a common structure for binary distributions of Python modules
 (including buildbot)

 I knew there was a reason I liked Python.

 > ask Python generate binary distribution

 Here's a random thought, since we're talking about binaries: is it
 possible to get Python to generate native PE binaries from scripts? It's
 usually done by embedding the needed scripts in a tiny redistributable
 interpreter stub, but I don't know if Python supports that. If we could do
 that, all the Python issues would go away.

 > > no dependency
 >
 > it happened that your CMakeLists.txt required cl.exe just to generate
 makefiles

 No, it doesn't. It's just that the default compiler selected by CMake on
 Windows is Visual Studio, a not unreasonable assumption given zero
 knowledge. You have to tell CMake what makefile generator to use, like so:

 {{{
 cmake -G "MinGW Makefiles" ..
 }}}

 If you try it now, CMake will complain. First you must delete... I think
 it is... the CMakeCache.txt file. Failing that, delete all the CMake-
 generated files.

 The double-dot, by the way, selects the CMakeLists.txt in the parent
 directory. I like to keep my CMake build files well away from the source,
 so I can delete the whole lot without deleting my entire source tree.
 (CMake has no equivalent of "make clean".) That's the purpose of the
 "cmake" dir you saw in my fossil. It's just there to catch all the files
 put out by CMake.

 > I think anyone willing to look on windows installer will in the end be
 much confused with this much of unneeded code and software required just
 to build an installer

 I don't understand what you mean. I've been through both the NSI scripts
 in the fossil and I can find no references to CMake. CMake is simply not
 required for my NSI scripts.

 > > needs to be done
 >
 > See my code and maybe try my installer, I've already implemented
 installing buildbot to different installed Python versions at once.
 However this will be reworked to add dependencies subsections for each
 Python distribution.

 Cool. Did you come up with a way to avoid version hell? We wouldn't want
 to uninstall the wrong Buildbot.

 > > creating and destroying herds
 > The problem is that we can make Buildbot menu group overbloated with
 lots of options

 Yes, this also worries me.

 > because there are lots of parameters to vary. I suggest to have "New
 master wizard" and "Uninstall master" menu options in the root of buildbot
 menu group together with "instances" directory. Each directory would have
 subdirectory in form "<bot name> (Python <PYTHONVERSION>)" with links to
 start, stop and remove bot (and maybe additional option:configure, if
 someone will write a gui someday, but this is a kind of silly).

 Maybe not so silly and not at all hard if we go with the Control Panel
 applet. For instance, we could make the applet contain a browser control
 and code up the options in HTML. That's just one idea.

 > > discussion needed
 > Here what I'm thinking about this. Buildbot installs all its code inside
 the Python environment. This means we don't need an extra directory in
 Program Files. However there is only uninstaller that has nothing to go.
 It would be wrong to put uninstaller only in one Python environment,
 because all other Python environments are neither worse nor better.

 It seems just as wrong to create a Program Files subdirectory just for an
 uninstaller. Even worse would be putting the uninstaller in C root, or in
 WINDIR. The Control Panel applet doesn't suffer from this, though. It
 could arrange to delete itself on next boot by using the RunOnce registry
 keys.

 > I mentioned two ways of uninstaller's logic: remove the buildbot code
 just from current Python environment or remove it at all. However, when I
 think about it, this may require to have lots of menu groups like
 "Buildbot for Python 2.4/2.5/2.6/2.7" or relative subgroups in general
 "Buildbot" menu which is not very great too.

 I think we have to consider the Buildbots themselves first and the
 versions second. Suppose I have these Buildbots installed:


 {{{
 Project: p1
 Type: Master
 Python: 2.7

 Project: p1
 Type: Slave
 Python: 2.6

 Project: p2
 Type: Slave
 Python: 2.5
 }}}

 With a few clicks, I should be able to uninstall a) all Buildbots, b)
 Buildbots working on project p1, c) Buildbots running in Python 2.5, d)
 all masters or all slaves, and e) individual Buildbots.

 > If we can write additional uninstaller page to give a possibility to
 remove buildbot code from desired Python environments, this would be uber
 great.

 I think this might be a wrong way to go. But I'm not sure.

 > NSIS can generate lots of equal uninstallers and I checked that already.
 All is left to do is to store install options to register during
 installation, read them during uninstall process, remove the buildbot code
 and all uninstallers that left behind.

 Yeah, NSIS is great for little self-destructing uninstallers. I'm still
 not sure how it can do that.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/971#comment:27>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Jul 26 17:07:55 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 26 Jul 2011 17:07:55 -0000
Subject: [Buildbot-commits] [Buildbot] #971: Build a windows installer
In-Reply-To: <038.6c763d0f053bc258fcb2f8f99b00326c@buildbot.net>
References: <038.6c763d0f053bc258fcb2f8f99b00326c@buildbot.net>
Message-ID: <053.8c9c5b4a8c4f127d2d90fed187d22626@buildbot.net>

#971: Build a windows installer
------------------------+-----------------------
Reporter:  dustin       |       Owner:  fatman2
    Type:  enhancement  |      Status:  accepted
Priority:  major        |   Milestone:  0.8.+
 Version:               |  Resolution:
Keywords:  windows      |
------------------------+-----------------------

Comment (by fatman2):

 Replying to [comment:26 dustin]:
 > it will make a lot of assumptions which may be invalid for some users'
 environments

 A valid point. The configuration method - be it Control Panel applet or
 wizard - should provide the ability to tweak all those assumptions.

 > It's also a lot more work, a lot more decisions to make, and a lot more
 to support

 When I started the NSI scripts, I didn't plan to burden you with the
 support. I hoped other users - like jollyroger here - would grab the ball
 and run, come up with new ideas.

 > Once this is done, if you want to either make a "turnkey" installer, or
 add options to create/destroy masters, that can be another bug.

 I thought that was this bug.

 > Basically, I'm saying, let's keep it simple to start with.  Sound good?

 Sorry, but that's no good to me. I need something I can deploy quickly.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/971#comment:28>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Jul 26 17:15:37 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 26 Jul 2011 17:15:37 -0000
Subject: [Buildbot-commits] [Buildbot] #971: Build a windows installer
In-Reply-To: <038.6c763d0f053bc258fcb2f8f99b00326c@buildbot.net>
References: <038.6c763d0f053bc258fcb2f8f99b00326c@buildbot.net>
Message-ID: <053.acd8df0c514b1a699b4f04ee12d37fd5@buildbot.net>

#971: Build a windows installer
------------------------+-----------------------
Reporter:  dustin       |       Owner:  fatman2
    Type:  enhancement  |      Status:  accepted
Priority:  major        |   Milestone:  0.8.+
 Version:               |  Resolution:
Keywords:  windows      |
------------------------+-----------------------

Comment (by dustin):

 OK, I don't mean to say "don't do that" - if the two of you are willing to
 stick with the project for the long term, answering questions and keeping
 the installers updated, then by all means, have at it!  Also, please add
 yourself to MAINTAINERS.txt in that case.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/971#comment:29>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul 27 00:53:23 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 27 Jul 2011 00:53:23 -0000
Subject: [Buildbot-commits] [Buildbot] #2061: patch: make P4Poller pick
	up where it left off
In-Reply-To: <039.102ff57836737161cb59529187ff8b02@buildbot.net>
References: <039.102ff57836737161cb59529187ff8b02@buildbot.net>
Message-ID: <054.084743fb5c31265178f305bc06dd2ac4@buildbot.net>

#2061: patch: make P4Poller pick up where it left off
------------------------+------------------------
Reporter:  dberger      |       Owner:
    Type:  enhancement  |      Status:  new
Priority:  major        |   Milestone:  undecided
 Version:  0.8.4p2      |  Resolution:
Keywords:               |
------------------------+------------------------

Comment (by dustin):

 Heh, I assume that's P4's spin on a "patch"? :)

 I'll get it merged..

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2061#comment:4>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul 27 01:06:40 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 27 Jul 2011 01:06:40 -0000
Subject: [Buildbot-commits] [Buildbot] #2061: patch: make P4Poller pick
	up where it left off
In-Reply-To: <039.102ff57836737161cb59529187ff8b02@buildbot.net>
References: <039.102ff57836737161cb59529187ff8b02@buildbot.net>
Message-ID: <054.30d70f4b7024b3a4cf5e5be96c672068@buildbot.net>

#2061: patch: make P4Poller pick up where it left off
------------------------+------------------------
Reporter:  dberger      |       Owner:
    Type:  enhancement  |      Status:  new
Priority:  major        |   Milestone:  undecided
 Version:  0.8.4p2      |  Resolution:
Keywords:               |
------------------------+------------------------

Comment (by dustin):

 Here's an updated version of the patch.  However, this doesn't pass the
 tests anymore, so I didn't merge it to buildbot.

 Also, please use log.msg instead of print.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2061#comment:5>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Wed Jul 27 01:23:35 2011
From: noreply at github.com (noreply at github.com)
Date: Tue, 26 Jul 2011 18:23:35 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 0f85cb: handle failures from
	stableTimerFired
Message-ID: <20110727012335.A245E425CA@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 0f85cb0a2d15a55a6fe32de6881373f41b10d319
      https://github.com/buildbot/buildbot/commit/0f85cb0a2d15a55a6fe32de6881373f41b10d319
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-26 (Tue, 26 Jul 2011)

  Changed paths:
    M master/buildbot/schedulers/basic.py

  Log Message:
  -----------
  handle failures from stableTimerFired

Fixes #2062.





From nobody at buildbot.net  Wed Jul 27 01:23:42 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 27 Jul 2011 01:23:42 -0000
Subject: [Buildbot-commits] [Buildbot] #2062:
 BaseBasicScheduler.stableTimerFired can return uncaught failures
In-Reply-To: <039.9dc0536d33c8ac6fdf3e4f9729655a25@buildbot.net>
References: <039.9dc0536d33c8ac6fdf3e4f9729655a25@buildbot.net>
Message-ID: <054.263304c0044caaf06699055f055ae04a@buildbot.net>

#2062: BaseBasicScheduler.stableTimerFired can return uncaught failures
----------------------+------------------------
Reporter:  dwlocks    |       Owner:
    Type:  undecided  |      Status:  closed
Priority:  major      |   Milestone:  undecided
 Version:  0.8.4p2    |  Resolution:  fixed
Keywords:             |
----------------------+------------------------
Changes (by Dustin J. Mitchell):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 handle failures from stableTimerFired

 Fixes #2062.
  Changeset: 0f85cb0a2d15a55a6fe32de6881373f41b10d319

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2062#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Wed Jul 27 01:30:09 2011
From: noreply at github.com (noreply at github.com)
Date: Tue, 26 Jul 2011 18:30:09 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] ae9fd6: Merge branch
	'gsoc_commit' of git://github.com/in3...
Message-ID: <20110727013009.0BEAD425CC@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: ae9fd6a63500ab9b5b397e0ab3801e8cbf6133c8
      https://github.com/buildbot/buildbot/commit/ae9fd6a63500ab9b5b397e0ab3801e8cbf6133c8
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-26 (Tue, 26 Jul 2011)

  Changed paths:
    A master/buildbot/steps/source/svn.py
  A master/buildbot/test/unit/test_steps_source_svn.py
  M master/docs/cfg-buildsteps.texinfo

  Log Message:
  -----------
  Merge branch 'gsoc_commit' of git://github.com/in3xes/buildbot

* 'gsoc_commit' of git://github.com/in3xes/buildbot:
  SVN completed





From nobody at buildbot.net  Wed Jul 27 05:24:11 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 27 Jul 2011 05:24:11 -0000
Subject: [Buildbot-commits] [Buildbot] #2063: Documentation for IRC bot
 configuration is wrong
In-Reply-To: <035.0b4f6f289360a98c2fef3d53ed0d1f76@buildbot.net>
References: <035.0b4f6f289360a98c2fef3d53ed0d1f76@buildbot.net>
Message-ID: <050.a9362f22a9f015326eeccba4d9ecb47a@buildbot.net>

#2063: Documentation for IRC bot configuration is wrong
-------------------------------+------------------------
Reporter:  ajb                 |       Owner:
    Type:  defect              |      Status:  closed
Priority:  major               |   Milestone:  undecided
 Version:  0.8.3p1             |  Resolution:  fixed
Keywords:  documentation, irc  |
-------------------------------+------------------------
Changes (by dustin):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Ah - support for that syntax was only added in 0.8.4.  From the line
 numbers it looks like you're running 0.8.3.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2063#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul 27 07:44:17 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 27 Jul 2011 07:44:17 -0000
Subject: [Buildbot-commits] [Buildbot] #2064: Buildbot no longer working
 after upgrade to 0.8.4p2
Message-ID: <046.c0b7b1b7cea9df52101edd57bd0d6d2b@buildbot.net>

#2064: Buildbot no longer working after upgrade to 0.8.4p2
---------------------------+-----------------------
Reporter:  materialdreams  |      Owner:
    Type:  undecided       |     Status:  new
Priority:  critical        |  Milestone:  undecided
 Version:  0.8.4p2         |   Keywords:
---------------------------+-----------------------
 To take advantage of some new features I just upgraded from 0.8.2 to
 0.8.4p2 but now my buildbot is no longer working.
 I have attached the logs from one of the slaves and the buildbot master.
 The key information seems to be the "2011-07-27 09:05:49+0200
 [Broker,client] ReconnectingPBClientFactory.failedToGetPerspective" error
 show in the log of the slave.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2064>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul 27 15:17:26 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 27 Jul 2011 15:17:26 -0000
Subject: [Buildbot-commits] [Buildbot] #76: add mercurial RSS poller
	change source
In-Reply-To: <045.fc42a2ae1dbf5132f47e73265343ba32@buildbot.net>
References: <045.fc42a2ae1dbf5132f47e73265343ba32@buildbot.net>
Message-ID: <060.75726c2892d56fcf18b270bbe95fa8c5@buildbot.net>

#76: add mercurial RSS poller change source
--------------------------+---------------------
Reporter:  TedMielczarek  |       Owner:  warner
    Type:  enhancement    |      Status:  new
Priority:  major          |   Milestone:  0.8.+
 Version:  0.7.5          |  Resolution:
Keywords:  hg             |
--------------------------+---------------------

Comment (by TedMielczarek):

 I don't think we're actually using this code anymore, so we can probably
 wontfix it.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/76#comment:20>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul 27 16:51:20 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 27 Jul 2011 16:51:20 -0000
Subject: [Buildbot-commits] [Buildbot] #2065: Error during setup of
 buildslave on Windows 7 64bit
Message-ID: <046.67e1d61ea2ba36f97b6d0597743e90a8@buildbot.net>

#2065: Error during setup of buildslave on Windows 7 64bit
---------------------------+-----------------------
Reporter:  materialdreams  |      Owner:
    Type:  undecided       |     Status:  new
Priority:  minor           |  Milestone:  undecided
 Version:  0.8.4p2         |   Keywords:
---------------------------+-----------------------
 Running "python setup.py build" resulted in the following error:
 ----------
 C:\Python\lib\distutils\dist.py:267: UserWarning: Unknown distribution
 option: 'zip_safe'
   warnings.warn(msg)
 running build
 running build_py
 running build_scripts
 ----------

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2065>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul 27 16:53:02 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 27 Jul 2011 16:53:02 -0000
Subject: [Buildbot-commits] [Buildbot] #1725: GerritStatusPush: add
 filters on builderName, project, branch
In-Reply-To: <043.b6be9d54d3cee8199a78e9ff41b4f4e4@buildbot.net>
References: <043.b6be9d54d3cee8199a78e9ff41b4f4e4@buildbot.net>
Message-ID: <058.40d35975cb02a0a2effcbad100500252@buildbot.net>

#1725: GerritStatusPush: add filters on builderName, project, branch
------------------------+--------------------------
Reporter:  PiotrSikora  |       Owner:  PiotrSikora
    Type:  enhancement  |      Status:  new
Priority:  major        |   Milestone:  0.8.5
 Version:  0.8.2        |  Resolution:
Keywords:  gerrit       |
------------------------+--------------------------

Comment (by deignacio):

 I could see this being useful for all StatusReceiver subclasses.
 i don't think you could use a ChangeFilter, because that has a bunch of
 code that is specific to changes, where as this is filtering
 BuildStatuses.
 in buildbot.status.builder whenever you do something like
 for w in self.watchers:
     try:
         if not w.filter(name, s, ...):
             continue
         w.someStep(name, s, ...)
     except:
         ....

 i think this would be super useful as you can have a configuration where
 not all builds are triggered by gerrit.  (think gerrit change source and
 github change notifications).

 how's your progress on this?  i could probably put in some work into this
 if you wanted.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1725#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul 27 21:58:26 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 27 Jul 2011 21:58:26 -0000
Subject: [Buildbot-commits] [Buildbot] #1772: vstudio.py misses compile
 errors and doesn't check for exit status
In-Reply-To: <041.e84e795e122ec83abcea86b809814a63@buildbot.net>
References: <041.e84e795e122ec83abcea86b809814a63@buildbot.net>
Message-ID: <056.e6495c61b4b871f4586ae38dad018a75@buildbot.net>

#1772: vstudio.py misses compile errors and doesn't check for exit status
----------------------+-----------------------
Reporter:  philippem  |       Owner:
    Type:  defect     |      Status:  reopened
Priority:  major      |   Milestone:  0.8.5
 Version:  0.8.3      |  Resolution:
Keywords:  windows    |
----------------------+-----------------------

Comment (by philippem):

 I went through my old build history and I have not seen the -1 output
 recently (is there a way to search quickly through all the old build
 logs?)
 It's not currently a problem for us, since the patch we are running counts
 and reports errors and warnings correctly, so I think you can delete the
 comment and close this ticket.

 thanks

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1772#comment:16>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul 27 22:22:12 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 27 Jul 2011 22:22:12 -0000
Subject: [Buildbot-commits] [Buildbot] #2065: Error during setup of
 buildslave on Windows 7 64bit
In-Reply-To: <046.67e1d61ea2ba36f97b6d0597743e90a8@buildbot.net>
References: <046.67e1d61ea2ba36f97b6d0597743e90a8@buildbot.net>
Message-ID: <061.d5be55d7dd7b3de6151c9d3562f2fcb5@buildbot.net>

#2065: Error during setup of buildslave on Windows 7 64bit
---------------------------+-------------------------
Reporter:  materialdreams  |       Owner:
    Type:  undecided       |      Status:  closed
Priority:  minor           |   Milestone:  undecided
 Version:  0.8.4p2         |  Resolution:  worksforme
Keywords:                  |
---------------------------+-------------------------
Changes (by materialdreams):

 * status:  new => closed
 * resolution:   => worksforme


-- 
Ticket URL: <http://trac.buildbot.net/ticket/2065#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul 27 22:23:10 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 27 Jul 2011 22:23:10 -0000
Subject: [Buildbot-commits] [Buildbot] #2065: Error during setup of
 buildslave on Windows 7 64bit
In-Reply-To: <046.67e1d61ea2ba36f97b6d0597743e90a8@buildbot.net>
References: <046.67e1d61ea2ba36f97b6d0597743e90a8@buildbot.net>
Message-ID: <061.4e7aebf074271b99167f323915cd37b8@buildbot.net>

#2065: Error during setup of buildslave on Windows 7 64bit
---------------------------+-------------------------
Reporter:  materialdreams  |       Owner:
    Type:  undecided       |      Status:  closed
Priority:  minor           |   Milestone:  undecided
 Version:  0.8.4p2         |  Resolution:  worksforme
Keywords:                  |
---------------------------+-------------------------

Comment (by materialdreams):

 It was a problem with Python 64 bit. Moving to the 32 bit version and
 reinstalling solved the problem.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2065#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul 27 22:33:46 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 27 Jul 2011 22:33:46 -0000
Subject: [Buildbot-commits] [Buildbot] #1725: GerritStatusPush: add
 filters on builderName, project, branch
In-Reply-To: <043.b6be9d54d3cee8199a78e9ff41b4f4e4@buildbot.net>
References: <043.b6be9d54d3cee8199a78e9ff41b4f4e4@buildbot.net>
Message-ID: <058.06c20d4f2427bab2bfcd496918cd8540@buildbot.net>

#1725: GerritStatusPush: add filters on builderName, project, branch
------------------------+--------------------------
Reporter:  PiotrSikora  |       Owner:  PiotrSikora
    Type:  enhancement  |      Status:  new
Priority:  major        |   Milestone:  0.8.5
 Version:  0.8.2        |  Resolution:
Keywords:  gerrit       |
------------------------+--------------------------

Comment (by PiotrSikora):

 Unfortunately, I'm a bit busy lately and I didn't touch Buildbot in
 months. Feel free to takeover this.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1725#comment:4>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Jul 27 22:51:33 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 27 Jul 2011 22:51:33 -0000
Subject: [Buildbot-commits] [Buildbot] #1772: vstudio.py misses compile
 errors and doesn't check for exit status
In-Reply-To: <041.e84e795e122ec83abcea86b809814a63@buildbot.net>
References: <041.e84e795e122ec83abcea86b809814a63@buildbot.net>
Message-ID: <056.c8e0e432ad94abfe914862e9c3ae6f37@buildbot.net>

#1772: vstudio.py misses compile errors and doesn't check for exit status
----------------------+-----------------------
Reporter:  philippem  |       Owner:
    Type:  defect     |      Status:  reopened
Priority:  major      |   Milestone:  0.8.5
 Version:  0.8.3      |  Resolution:
Keywords:  windows    |
----------------------+-----------------------

Comment (by philippem):

 I scanned all my old build logs from the master, and found exit code of -1
 from failed shell commands (python, exes) but I have not seen it in
 vstudio calls.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1772#comment:17>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Thu Jul 28 15:37:41 2011
From: nobody at buildbot.net (Buildbot)
Date: Thu, 28 Jul 2011 15:37:41 -0000
Subject: [Buildbot-commits] [Buildbot] #2011: Traceback popping from
 empty deque in addChange
In-Reply-To: <043.d8d65df3cbcab5d1c78890f8f371eff1@buildbot.net>
References: <043.d8d65df3cbcab5d1c78890f8f371eff1@buildbot.net>
Message-ID: <058.e6b51e2b9571ce208e2b333050f171fb@buildbot.net>

#2011: Traceback popping from empty deque in addChange
------------------------+--------------------
Reporter:  adamcollard  |       Owner:
    Type:  defect       |      Status:  new
Priority:  blocker      |   Milestone:  0.8.5
 Version:  0.8.4p1      |  Resolution:
Keywords:               |
------------------------+--------------------
Changes (by dustin):

 * priority:  critical => blocker


Comment:

 Well, metabuildbot ran into this on 7/11, and hasn't built anything since.
 Pretty bad.  I'll see if I can swap the new version in with manhole.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2011#comment:4>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Thu Jul 28 17:09:47 2011
From: nobody at buildbot.net (Buildbot)
Date: Thu, 28 Jul 2011 17:09:47 -0000
Subject: [Buildbot-commits] [Buildbot] #2011: Traceback popping from
 empty deque in addChange
In-Reply-To: <043.d8d65df3cbcab5d1c78890f8f371eff1@buildbot.net>
References: <043.d8d65df3cbcab5d1c78890f8f371eff1@buildbot.net>
Message-ID: <058.791f94bbc9510177f80afc016c308e5f@buildbot.net>

#2011: Traceback popping from empty deque in addChange
------------------------+--------------------
Reporter:  adamcollard  |       Owner:
    Type:  defect       |      Status:  new
Priority:  blocker      |   Milestone:  0.8.5
 Version:  0.8.4p1      |  Resolution:
Keywords:               |
------------------------+--------------------

Comment (by dustin):

 I don't think that this is related to the 7/11 failure, but it is related
 to this bug.

 {{{
 2011-07-27 13:32:44+0200 [-] Unhandled Error
         Traceback (most recent call last):
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/twisted/internet/base.py", line 1167, in mainLoop
             self.runUntilCurrent()
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/twisted/internet/base.py", line 762, in runUntilCurrent
             f(*a, **kw)
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/twisted/internet/defer.py", line 361, in callback
             self._startRunCallbacks(result)
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/twisted/internet/defer.py", line 455, in _startRunCallbacks
             self._runCallbacks()
         --- <exception caught here> ---
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/twisted/internet/defer.py", line 542, in _runCallbacks
             current.result = callback(current.result, *args, **kw)
           File
 "/home/buildbot/metabuildbot/src/master/buildbot/util/lru.py", line 154,
 in handle_result
             self._purge()
           File
 "/home/buildbot/metabuildbot/src/master/buildbot/util/lru.py", line 192,
 in _purge
             del cache[k]
         exceptions.KeyError: 194
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2011#comment:5>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Thu Jul 28 17:28:00 2011
From: nobody at buildbot.net (Buildbot)
Date: Thu, 28 Jul 2011 17:28:00 -0000
Subject: [Buildbot-commits] [Buildbot] #2022: Stale Broker errors not
	caught on reconfig
In-Reply-To: <038.381285500e2095ef29e1264f09ac6406@buildbot.net>
References: <038.381285500e2095ef29e1264f09ac6406@buildbot.net>
Message-ID: <053.4dffd0794e48dbdedd1e4080726884cc@buildbot.net>

#2022: Stale Broker errors not caught on reconfig
---------------------+--------------------
Reporter:  dustin    |       Owner:
    Type:  defect    |      Status:  new
Priority:  major     |   Milestone:  0.8.5
 Version:  0.8.2     |  Resolution:
Keywords:  reconfig  |
---------------------+--------------------

Comment (by dustin):

 Similar (although fundamentally unrelated) problems here:
 {{{
 2011-07-25 00:32:17+0200 [Broker,128,69.230.8.158] Unhandled Error
         Traceback (most recent call last):
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/twisted/internet/tcp.py", line 519, in connectionLost
             protocol.connectionLost(reason)
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/twisted/spread/pb.py", line 579, in connectionLost
             d.errback(failure.Failure(PBConnectionLost(reason)))
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/twisted/internet/defer.py", line 388, in errback
             self._startRunCallbacks(fail)
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/twisted/internet/defer.py", line 455, in _startRunCallbacks
             self._runCallbacks()
         --- <exception caught here> ---
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/twisted/internet/defer.py", line 542, in _runCallbacks
             current.result = callback(current.result, *args, **kw)
           File
 "/home/buildbot/metabuildbot/src/master/buildbot/buildslave.py", line 300,
 in _get_info
             d1 = bot.callRemote("getSlaveInfo")
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/twisted/spread/pb.py", line 328, in callRemote
             _name, args, kw)
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/twisted/spread/pb.py", line 807, in _sendMessage
             raise DeadReferenceError("Calling Stale Broker")
         twisted.spread.pb.DeadReferenceError: Calling Stale Broker
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2022#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Thu Jul 28 19:00:17 2011
From: noreply at github.com (noreply at github.com)
Date: Thu, 28 Jul 2011 12:00:17 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 71b899: fix syntax for
	Python-2.4
Message-ID: <20110728190017.9A168425D8@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 71b899d172e099b2f935e61165dd05121173d3d5
      https://github.com/buildbot/buildbot/commit/71b899d172e099b2f935e61165dd05121173d3d5
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-28 (Thu, 28 Jul 2011)

  Changed paths:
    M master/buildbot/db/buildrequests.py

  Log Message:
  -----------
  fix syntax for Python-2.4


  Commit: 56ab17a133768922b9deafe555642d9958fc64a5
      https://github.com/buildbot/buildbot/commit/56ab17a133768922b9deafe555642d9958fc64a5
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-28 (Thu, 28 Jul 2011)

  Changed paths:
    M master/buildbot/monkeypatches/__init__.py

  Log Message:
  -----------
  don't try to monkey-patch twisted #5079 on Twisted-8.1.0


Compare: https://github.com/buildbot/buildbot/compare/ae9fd6a...56ab17a



From noreply at github.com  Thu Jul 28 20:55:39 2011
From: noreply at github.com (noreply at github.com)
Date: Thu, 28 Jul 2011 13:55:39 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 7c82ef: close logfile before
	trying to clean up
Message-ID: <20110728205539.F09DD42638@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 7c82ef7ee2075aeee423dab1e960744145b2530a
      https://github.com/buildbot/buildbot/commit/7c82ef7ee2075aeee423dab1e960744145b2530a
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-28 (Thu, 28 Jul 2011)

  Changed paths:
    M master/buildbot/test/unit/test_status_logfile.py

  Log Message:
  -----------
  close logfile before trying to clean up





From noreply at github.com  Thu Jul 28 21:31:43 2011
From: noreply at github.com (noreply at github.com)
Date: Thu, 28 Jul 2011 14:31:43 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 407dde: include 'objects'
	dependency for buildrequest_clai...
Message-ID: <20110728213143.D1CD042645@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 407dde5c4fd40863468a27e481ebf15e5b09c49e
      https://github.com/buildbot/buildbot/commit/407dde5c4fd40863468a27e481ebf15e5b09c49e
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-28 (Thu, 28 Jul 2011)

  Changed paths:
    M master/buildbot/test/unit/test_db_buildrequests.py

  Log Message:
  -----------
  include 'objects' dependency for buildrequest_claims table





From nobody at buildbot.net  Fri Jul 29 20:42:49 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 29 Jul 2011 20:42:49 -0000
Subject: [Buildbot-commits] [Buildbot] #2066: Fix new source steps' URL
	handling
Message-ID: <038.4b2beb27a185303ae6bd92ef91a5b2d9@buildbot.net>

#2066: Fix new source steps' URL handling
------------------------+--------------------
Reporter:  in3xes       |      Owner:
    Type:  enhancement  |     Status:  new
Priority:  minor        |  Milestone:  0.8.5
 Version:  0.8.4p2      |   Keywords:  Source
------------------------+--------------------
 https://github.com/buildbot/buildbot/pull/179#issuecomment-1613478

 and https://github.com/buildbot/buildbot/pull/179#issuecomment-1631750

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2066>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Jul 29 20:55:40 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 29 Jul 2011 20:55:40 -0000
Subject: [Buildbot-commits] [Buildbot] #2056: builders sometimes stay in
 an idle, plus 1 state
In-Reply-To: <039.edd4dfa8d7509af4ad0134bd0de2f704@buildbot.net>
References: <039.edd4dfa8d7509af4ad0134bd0de2f704@buildbot.net>
Message-ID: <054.bd1ee604ab543f9da769c500b5f387c4@buildbot.net>

#2056: builders sometimes stay in an idle, plus 1 state
---------------------+--------------------
Reporter:  dwlocks   |       Owner:
    Type:  defect    |      Status:  new
Priority:  major     |   Milestone:  0.8.5
 Version:  0.8.4p2   |  Resolution:
Keywords:  database  |
---------------------+--------------------

Comment (by dwlocks):

 using manhole: executing botmaster.maybeStartBuildsForAllBuilders() makes
 the stuck builds go.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2056#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Jul 29 23:43:34 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 29 Jul 2011 23:43:34 -0000
Subject: [Buildbot-commits] [Buildbot] #2056: builders sometimes stay in
 an idle, plus 1 state
In-Reply-To: <039.edd4dfa8d7509af4ad0134bd0de2f704@buildbot.net>
References: <039.edd4dfa8d7509af4ad0134bd0de2f704@buildbot.net>
Message-ID: <054.fdcaf9af1f40893dee578b961d2e2a2c@buildbot.net>

#2056: builders sometimes stay in an idle, plus 1 state
---------------------+--------------------
Reporter:  dwlocks   |       Owner:
    Type:  defect    |      Status:  new
Priority:  major     |   Milestone:  0.8.5
 Version:  0.8.4p2   |  Resolution:
Keywords:  database  |
---------------------+--------------------

Comment (by dwlocks):

 but apparently not *all* the stuck builds, just a random assortment.
 calling botmaster.maybeStartBuildForSlave("slavename") reliably starts a
 waiting build.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2056#comment:4>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Jul 30 18:54:53 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 30 Jul 2011 18:54:53 -0000
Subject: [Buildbot-commits] [Buildbot] #2064: Buildbot 0.8.4p2
 incompatible with Twisted-8.1.0 (was: Buildbot no longer working after
 upgrade to 0.8.4p2)
In-Reply-To: <046.c0b7b1b7cea9df52101edd57bd0d6d2b@buildbot.net>
References: <046.c0b7b1b7cea9df52101edd57bd0d6d2b@buildbot.net>
Message-ID: <061.eee595ffb24ddb8c8ab34f43328eafb5@buildbot.net>

#2064: Buildbot 0.8.4p2 incompatible with Twisted-8.1.0
----------------------------+--------------------
Reporter:  materialdreams   |       Owner:
    Type:  support-request  |      Status:  new
Priority:  major            |   Milestone:  0.8.5
 Version:  0.8.4p2          |  Resolution:
Keywords:                   |
----------------------------+--------------------
Changes (by dustin):

 * priority:  critical => major
 * type:  undecided => support-request
 * milestone:  undecided => 0.8.5


Comment:

 This is because you're running the master on the (absolutely ancient!)
 Twisted-8.1.0.  The fix is pretty easy:
 https://github.com/buildbot/buildbot/commit/56ab17a133768922b9deafe555642d9958fc64a5
 or, really, just add {{{return}}} after line 30 of that file:
 {{{
 #!python
 def patch_bug5079():
     return
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2064#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Jul 30 19:22:47 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 30 Jul 2011 19:22:47 -0000
Subject: [Buildbot-commits] [Buildbot] #2064: Buildbot 0.8.4p2
 incompatible with Twisted-8.1.0
In-Reply-To: <046.c0b7b1b7cea9df52101edd57bd0d6d2b@buildbot.net>
References: <046.c0b7b1b7cea9df52101edd57bd0d6d2b@buildbot.net>
Message-ID: <061.20504c3de6af8f960d619768a0b100ab@buildbot.net>

#2064: Buildbot 0.8.4p2 incompatible with Twisted-8.1.0
----------------------------+---------------------
Reporter:  materialdreams   |       Owner:
    Type:  support-request  |      Status:  closed
Priority:  major            |   Milestone:  0.8.5
 Version:  0.8.4p2          |  Resolution:  fixed
Keywords:                   |
----------------------------+---------------------
Changes (by dustin):

 * status:  new => closed
 * resolution:   => fixed


-- 
Ticket URL: <http://trac.buildbot.net/ticket/2064#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Sat Jul 30 19:23:49 2011
From: noreply at github.com (noreply at github.com)
Date: Sat, 30 Jul 2011 12:23:49 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] b0beea: close logfile before
	trying to unlink it
Message-ID: <20110730192349.5129842574@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: b0beea4b1d3fa3dc3f2e67ae3d36740bc911bfb1
      https://github.com/buildbot/buildbot/commit/b0beea4b1d3fa3dc3f2e67ae3d36740bc911bfb1
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-30 (Sat, 30 Jul 2011)

  Changed paths:
    M master/buildbot/test/unit/test_status_logfile.py

  Log Message:
  -----------
  close logfile before trying to unlink it


  Commit: a6c07c569f54a9dbe6a00ffe8157b4b42cc67d9a
      https://github.com/buildbot/buildbot/commit/a6c07c569f54a9dbe6a00ffe8157b4b42cc67d9a
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-30 (Sat, 30 Jul 2011)

  Changed paths:
    M master/buildbot/db/buildrequests.py
  M master/buildbot/db/migrate/versions/011_add_buildrequest_claims.py
  M master/buildbot/test/unit/test_db_buildrequests.py

  Log Message:
  -----------
  fix compatibility with Postgres


Compare: https://github.com/buildbot/buildbot/compare/407dde5...a6c07c5



From noreply at github.com  Sat Jul 30 19:29:25 2011
From: noreply at github.com (noreply at github.com)
Date: Sat, 30 Jul 2011 12:29:25 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 09961e: Merge branch '1962'
	of git://github.com/in3xes/bui...
Message-ID: <20110730192925.478E642593@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 09961e82c9f952087faca92ead3dde924c5f15ae
      https://github.com/buildbot/buildbot/commit/09961e82c9f952087faca92ead3dde924c5f15ae
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-30 (Sat, 30 Jul 2011)

  Changed paths:
    M master/buildbot/steps/source/git.py
  M master/buildbot/steps/source/mercurial.py
  M master/buildbot/steps/source/oldsource.py
  M master/buildbot/steps/source/svn.py
  M master/buildbot/test/unit/test_steps_source_git.py
  M master/buildbot/test/unit/test_steps_source_mercurial.py
  M master/buildbot/test/unit/test_steps_source_svn.py
  M master/docs/cfg-buildsteps.texinfo

  Log Message:
  -----------
  Merge branch '1962' of git://github.com/in3xes/buildbot

* '1962' of git://github.com/in3xes/buildbot:
  Add env, logEnviron parameters to source steps. Fixes #1962





From nobody at buildbot.net  Sat Jul 30 19:29:33 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 30 Jul 2011 19:29:33 -0000
Subject: [Buildbot-commits] [Buildbot] #1962: Source steps should take
	an env paramater.
In-Reply-To: <042.bb3f08bde133c0fe0588df258091dcbb@buildbot.net>
References: <042.bb3f08bde133c0fe0588df258091dcbb@buildbot.net>
Message-ID: <057.a25197c195292a88a1c2dd8d51fc0c86@buildbot.net>

#1962: Source steps should take an env paramater.
--------------------------------------------------+---------------------
Reporter:  tom.prince                             |       Owner:
    Type:  enhancement                            |      Status:  closed
Priority:  minor                                  |   Milestone:  0.8.+
 Version:  0.8.3p1                                |  Resolution:  fixed
Keywords:  bk, bzr, cvs, darcs, git, hg, p4, svn  |
--------------------------------------------------+---------------------
Changes (by Dustin J. Mitchell):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Merge branch '1962' of git://github.com/in3xes/buildbot

 * '1962' of git://github.com/in3xes/buildbot:
   Add env, logEnviron parameters to source steps. Fixes #1962
  Changeset: 09961e82c9f952087faca92ead3dde924c5f15ae

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1962#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Sat Jul 30 21:02:11 2011
From: noreply at github.com (noreply at github.com)
Date: Sat, 30 Jul 2011 14:02:11 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] ec0c04: don't expect
	txn.rollback to work on mysql
Message-ID: <20110730210211.8493A42595@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: ec0c040f26625ad59b3789009a87ea259cc0b328
      https://github.com/buildbot/buildbot/commit/ec0c040f26625ad59b3789009a87ea259cc0b328
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-30 (Sat, 30 Jul 2011)

  Changed paths:
    M master/buildbot/test/unit/test_db_buildrequests.py

  Log Message:
  -----------
  don't expect txn.rollback to work on mysql


  Commit: 6b3dc3990b3c0d47bbf5c6239e899e22fa0d744b
      https://github.com/buildbot/buildbot/commit/6b3dc3990b3c0d47bbf5c6239e899e22fa0d744b
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-30 (Sat, 30 Jul 2011)

  Changed paths:
    M master/buildbot/db/migrate/versions/011_add_buildrequest_claims.py

  Log Message:
  -----------
  only cast NULL to an integer for postgres


Compare: https://github.com/buildbot/buildbot/compare/09961e8...6b3dc39



From nobody at buildbot.net  Sat Jul 30 21:18:30 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 30 Jul 2011 21:18:30 -0000
Subject: [Buildbot-commits] [Buildbot] #76: add mercurial RSS poller
	change source
In-Reply-To: <045.fc42a2ae1dbf5132f47e73265343ba32@buildbot.net>
References: <045.fc42a2ae1dbf5132f47e73265343ba32@buildbot.net>
Message-ID: <060.135507a5d6a78999b22155260f65d30c@buildbot.net>

#76: add mercurial RSS poller change source
--------------------------+----------------------
Reporter:  TedMielczarek  |       Owner:  warner
    Type:  enhancement    |      Status:  closed
Priority:  major          |   Milestone:  0.8.+
 Version:  0.7.5          |  Resolution:  wontfix
Keywords:  hg             |
--------------------------+----------------------
Changes (by dustin):

 * status:  new => closed
 * resolution:   => wontfix


-- 
Ticket URL: <http://trac.buildbot.net/ticket/76#comment:21>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Jul 30 21:31:25 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 30 Jul 2011 21:31:25 -0000
Subject: [Buildbot-commits] [Buildbot] #1772: vstudio.py misses compile
 errors and doesn't check for exit status
In-Reply-To: <041.e84e795e122ec83abcea86b809814a63@buildbot.net>
References: <041.e84e795e122ec83abcea86b809814a63@buildbot.net>
Message-ID: <056.541c83b308d3acdc66d67a73ee2733c7@buildbot.net>

#1772: vstudio.py misses compile errors and doesn't check for exit status
----------------------+---------------------
Reporter:  philippem  |       Owner:
    Type:  defect     |      Status:  closed
Priority:  major      |   Milestone:  0.8.5
 Version:  0.8.3      |  Resolution:  fixed
Keywords:  windows    |
----------------------+---------------------
Changes (by dustin):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 Sounds "fixed" to me :)

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1772#comment:18>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Jul 30 22:11:28 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 30 Jul 2011 22:11:28 -0000
Subject: [Buildbot-commits] [Buildbot] #2056: builders sometimes stay in
 an idle, plus 1 state
In-Reply-To: <039.edd4dfa8d7509af4ad0134bd0de2f704@buildbot.net>
References: <039.edd4dfa8d7509af4ad0134bd0de2f704@buildbot.net>
Message-ID: <054.a5595a9ee3e02f8fcfa354d73a6fdae7@buildbot.net>

#2056: builders sometimes stay in an idle, plus 1 state
---------------------+--------------------
Reporter:  dwlocks   |       Owner:
    Type:  defect    |      Status:  new
Priority:  major     |   Milestone:  0.8.5
 Version:  0.8.4p2   |  Resolution:
Keywords:  database  |
---------------------+--------------------

Comment (by dustin):

 I suspect that this has something to do with the {{{isAvailable}}}
 support, which Zmanda uses to limit slave concurrency..

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2056#comment:5>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Jul 30 22:37:43 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 30 Jul 2011 22:37:43 -0000
Subject: [Buildbot-commits] [Buildbot] #2056: builders sometimes stay in
 an idle, plus 1 state
In-Reply-To: <039.edd4dfa8d7509af4ad0134bd0de2f704@buildbot.net>
References: <039.edd4dfa8d7509af4ad0134bd0de2f704@buildbot.net>
Message-ID: <054.6fd772392997c4a53dca88c05e88b189@buildbot.net>

#2056: builders sometimes stay in an idle, plus 1 state
---------------------+--------------------
Reporter:  dwlocks   |       Owner:
    Type:  defect    |      Status:  new
Priority:  major     |   Milestone:  0.8.5
 Version:  0.8.4p2   |  Resolution:
Keywords:  database  |
---------------------+--------------------

Comment (by dustin):

 Yep, I can replicate this with three builders using a slave with
 max_builds=2.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2056#comment:6>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Jul 30 23:30:52 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 30 Jul 2011 23:30:52 -0000
Subject: [Buildbot-commits] [Buildbot] #1684: Buildbot doesn't detect a
 broken configuration file
In-Reply-To: <038.73dfe541d584cc91781ed4b83cbf58c0@buildbot.net>
References: <038.73dfe541d584cc91781ed4b83cbf58c0@buildbot.net>
Message-ID: <053.a697ec2a2ae41b2d867e63b21e044f48@buildbot.net>

#1684: Buildbot doesn't detect a broken configuration file
------------------------+--------------------
Reporter:  kostja       |       Owner:
    Type:  enhancement  |      Status:  new
Priority:  major        |   Milestone:  0.8.+
 Version:  0.8.2        |  Resolution:
Keywords:  simple       |
------------------------+--------------------
Changes (by dustin):

 * cc: bill@? (added)


Comment:

 So this would be fixed in master/buildbot/master.py, in the loadConfig
 method.

 The straightforward way to do this would be to look for any !WebStatus
 instances in {{{status}}}, and check that their ports do not overlap (a
 Python set might be useful for the check).

 The more flexible way to do this might be to add a {{{checkConfig}}}
 method to {{{IStatusReceiver}}}, and pass it the entire list of other
 status receivers.  Then the !WebStatus {{{checkConfig}}} method could scan
 the list for other {{{WebStatus}}} instances with the same port.

 The latter solution would be good for change sources, too - we have a lot
 of bugs where multiple !GitPoller instances are using the same repository
 directory, presenting almost exactly the same problem -- just a different
 parameter name!

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1684#comment:5>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Jul 30 23:44:17 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 30 Jul 2011 23:44:17 -0000
Subject: [Buildbot-commits] [Buildbot] #2056: builders sometimes stay in
 an idle, plus 1 state
In-Reply-To: <039.edd4dfa8d7509af4ad0134bd0de2f704@buildbot.net>
References: <039.edd4dfa8d7509af4ad0134bd0de2f704@buildbot.net>
Message-ID: <054.a3c23b5cf4905120414d4bb537f3c0d7@buildbot.net>

#2056: builders sometimes stay in an idle, plus 1 state
--------------------+---------------------
Reporter:  dwlocks  |       Owner:
    Type:  defect   |      Status:  new
Priority:  major    |   Milestone:  0.10.+
 Version:  0.8.4p2  |  Resolution:
Keywords:           |
--------------------+---------------------
Changes (by dustin):

 * keywords:  database =>
 * milestone:  0.8.5 => 0.10.+


Comment:

 That should be {{{canStartBuild}}}.  I think I can see what would cause
 exactly what you're seeing.

 Zmanda's {{{canStartBuild}}} looks at the total number of slaves running
 builds on each VM node; if N slaves on the node are running builds, then
 the N+1th slave returns False from {{{canStartBuild}}}.  However, when
 each of those N slaves finish their build, they call
 {{{maybeStartBuildsForSlave(slavename)}}} with their own name.  This
 function tries to start a build for each of the builders connected to that
 slave.  If the N+1th slave is not connected to any of those builders, then
 it will not get a chance to run.

 Once things are in this state, {{{maybeStartBuildsForAllBuilders}}} will
 start builds up to the configured N, but if more than N builds remain to
 be scheduled, then you'll see the "random assortment" you mention.
 However, calling {{{maybeStartBuildsForSlave("slavename")}}} for a "stuck"
 slave will unwedge it (assuming that fewer than N builds are running on
 that VM node).

 Dan, for you, the fix is to override the slave's {{{buildFinished}}}
 method, which you'll see in the parent class calling
 {{{maybeStartBuildsForSlave}}}.  Instead, in your subclass, call
 {{{maybeStartBuildsForAllBuilders}}}.  If you're feeling adventurous, you
 could just call {{{maybeStartBuildsForSlave}}} for every slave on the
 current slave's VM node.

 A general fix for this will wait until APIs are defined in 0.10.x.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2056#comment:6>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Sat Jul 30 23:45:11 2011
From: noreply at github.com (noreply at github.com)
Date: Sat, 30 Jul 2011 16:45:11 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 6fdf5f: Add notes for
	BuildSlave subclassers re: canStartB...
Message-ID: <20110730234511.EF9EC42618@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 6fdf5fbd64df69654394da64b8aa4767602ade33
      https://github.com/buildbot/buildbot/commit/6fdf5fbd64df69654394da64b8aa4767602ade33
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-30 (Sat, 30 Jul 2011)

  Changed paths:
    M master/buildbot/buildslave.py

  Log Message:
  -----------
  Add notes for BuildSlave subclassers re: canStartBuild

Refs #2056.





From nobody at buildbot.net  Sat Jul 30 23:45:19 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 30 Jul 2011 23:45:19 -0000
Subject: [Buildbot-commits] [Buildbot] #2056: builders sometimes stay in
 an idle, plus 1 state
In-Reply-To: <039.edd4dfa8d7509af4ad0134bd0de2f704@buildbot.net>
References: <039.edd4dfa8d7509af4ad0134bd0de2f704@buildbot.net>
Message-ID: <054.4c3086399d9710dc8656019d4fd6d6c2@buildbot.net>

#2056: builders sometimes stay in an idle, plus 1 state
--------------------+---------------------
Reporter:  dwlocks  |       Owner:
    Type:  defect   |      Status:  new
Priority:  major    |   Milestone:  0.10.+
 Version:  0.8.4p2  |  Resolution:
Keywords:           |
--------------------+---------------------

Comment (by Dustin J. Mitchell):

 Add notes for BuildSlave subclassers re: canStartBuild

 Refs #2056.
  Changeset: 6fdf5fbd64df69654394da64b8aa4767602ade33

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2056#comment:7>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Sun Jul 31 23:43:07 2011
From: noreply at github.com (noreply at github.com)
Date: Sun, 31 Jul 2011 16:43:07 -0700
Subject: [Buildbot-commits] [buildbot/buildbot] 0cb6f1: Better
	error-handling in DuplicateSlaveArbitrator
Message-ID: <20110731234307.EBF34422E4@smtp1.rs.github.com>

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 0cb6f1e83e10e023711b326ef77c216e3b0d5291
      https://github.com/buildbot/buildbot/commit/0cb6f1e83e10e023711b326ef77c216e3b0d5291
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-31 (Sun, 31 Jul 2011)

  Changed paths:
    M master/buildbot/process/botmaster.py
  A master/buildbot/test/unit/test_process_botmaster_DuplicateSlaveArbitrator.py

  Log Message:
  -----------
  Better error-handling in DuplicateSlaveArbitrator

This includes full tests for the arbitrator as well.
Refs #2022.


  Commit: 995a6a7f4a18fe5b59cf57cd2a4afe3ab6234fc7
      https://github.com/buildbot/buildbot/commit/995a6a7f4a18fe5b59cf57cd2a4afe3ab6234fc7
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-31 (Sun, 31 Jul 2011)

  Changed paths:
    M master/buildbot/buildslave.py
  M master/buildbot/pbmanager.py
  M master/buildbot/process/botmaster.py
  A master/buildbot/test/integration/test_slave_comm.py
  M master/buildbot/test/unit/test_process_botmaster_DuplicateSlaveArbitrator.py

  Log Message:
  -----------
  More thorough testing of DuplicateSlaveArbitrator

This adds a subscribeToDetach method to build slaves, which the
arbitrator can use to wait for the old slave to detach, so there's no
longer any need to poll slave.isConnected.  Fixes #2022.


Compare: https://github.com/buildbot/buildbot/compare/6fdf5fb...995a6a7



From nobody at buildbot.net  Sun Jul 31 23:43:16 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 31 Jul 2011 23:43:16 -0000
Subject: [Buildbot-commits] [Buildbot] #2022: Stale Broker errors not
	caught on reconfig
In-Reply-To: <038.381285500e2095ef29e1264f09ac6406@buildbot.net>
References: <038.381285500e2095ef29e1264f09ac6406@buildbot.net>
Message-ID: <053.32b570db533cb612b70b96e3d783bfaf@buildbot.net>

#2022: Stale Broker errors not caught on reconfig
---------------------+---------------------
Reporter:  dustin    |       Owner:
    Type:  defect    |      Status:  closed
Priority:  major     |   Milestone:  0.8.5
 Version:  0.8.2     |  Resolution:  fixed
Keywords:  reconfig  |
---------------------+---------------------
Changes (by Dustin J. Mitchell):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 More thorough testing of DuplicateSlaveArbitrator

 This adds a subscribeToDetach method to build slaves, which the
 arbitrator can use to wait for the old slave to detach, so there's no
 longer any need to poll slave.isConnected.  Fixes #2022.
  Changeset: 995a6a7f4a18fe5b59cf57cd2a4afe3ab6234fc7

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2022#comment:5>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sun Jul 31 23:43:16 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 31 Jul 2011 23:43:16 -0000
Subject: [Buildbot-commits] [Buildbot] #2022: Stale Broker errors not
	caught on reconfig
In-Reply-To: <038.381285500e2095ef29e1264f09ac6406@buildbot.net>
References: <038.381285500e2095ef29e1264f09ac6406@buildbot.net>
Message-ID: <053.bde2e42600715ae3c1d088a4512433fe@buildbot.net>

#2022: Stale Broker errors not caught on reconfig
---------------------+--------------------
Reporter:  dustin    |       Owner:
    Type:  defect    |      Status:  new
Priority:  major     |   Milestone:  0.8.5
 Version:  0.8.2     |  Resolution:
Keywords:  reconfig  |
---------------------+--------------------

Comment (by Dustin J. Mitchell):

 Better error-handling in DuplicateSlaveArbitrator

 This includes full tests for the arbitrator as well.
 Refs #2022.
  Changeset: 0cb6f1e83e10e023711b326ef77c216e3b0d5291

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2022#comment:4>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sun Jul 31 23:44:36 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 31 Jul 2011 23:44:36 -0000
Subject: [Buildbot-commits] [Buildbot] #1931: EC2LatentBuildSlave does
 not terminate EBS-backed instances
In-Reply-To: <039.22b73804c67d3b129c8dbad66797bc75@buildbot.net>
References: <039.22b73804c67d3b129c8dbad66797bc75@buildbot.net>
Message-ID: <054.81a361d82592bd1661f263cf0bd85888@buildbot.net>

#1931: EC2LatentBuildSlave does not terminate EBS-backed instances
---------------------------+---------------------
Reporter:  mback2k         |       Owner:
    Type:  defect          |      Status:  closed
Priority:  major           |   Milestone:  0.8.5
 Version:  0.8.3p1         |  Resolution:  fixed
Keywords:  virtualization  |
---------------------------+---------------------
Changes (by dustin):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 {{{
 commit d6870db981da78a55f5cae204a835cba5af88ff5
 Author: Dustin J. Mitchell <dustin at mozilla.com>
 Date:   Thu Jul 21 14:55:44 2011 -0700

     Terminate EC2 instances instead of stopping them.

     This will correctly delete the instance and associated storage, rather
     than leaving that storage allocated but unused as previous versions
 did.

     Fixes #1931.
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1931#comment:4>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation