[Buildbot-commits] [Buildbot] #1772: vstudio.py misses compile errors and doesn't check for exit status

[Buildbot]

#1772: vstudio.py misses compile errors and doesn't check for exit status
----------------------+-----------------------
Reporter:  philippem  |       Owner:
    Type:  defect     |      Status:  reopened
Priority:  major      |   Milestone:  0.8.+
 Version:  0.8.3      |  Resolution:
Keywords:  windows    |
----------------------+-----------------------

Comment (by philippem):

 I like this fix better (so far):

 {{{
 plm at TommyDevUbuntu1:~/buildbot-0.8.3/buildbot/steps$ !diff
 diff -c vstudio.py /usr/local/lib/python2.6/dist-
 packages/buildbot-0.8.3-py2.6.egg/buildbot/steps/vstudio.py
 *** vstudio.py  2010-12-19 15:50:22.000000000 -0800
 --- /usr/local/lib/python2.6/dist-
 packages/buildbot-0.8.3-py2.6.egg/buildbot/steps/vstudio.py   2011-01-25
 18:05:57.610744306 -0800
 ***************
 *** 38,45 ****

       _re_delimitor = re.compile(r'^(\d+>)?-{5}.+-{5}$')
       _re_file = re.compile(r'^(\d+>)?[^ ]+\.(cpp|c)$')
 !     _re_warning = re.compile(r' : warning [A-Z]+[0-9]+:')
 !     _re_error = re.compile(r' error [A-Z]+[0-9]+\s?: ')

       nbFiles = 0
       nbProjects = 0
 --- 38,45 ----

       _re_delimitor = re.compile(r'^(\d+>)?-{5}.+-{5}$')
       _re_file = re.compile(r'^(\d+>)?[^ ]+\.(cpp|c)$')
 !     _re_warning = re.compile(r' ?: warning [A-Z]+[0-9]+:')
 !     _re_error = re.compile(r' ?error ([A-Z]+[0-9]+)?\s?: ')

       nbFiles = 0
       nbProjects = 0
 ***************
 *** 182,187 ****
 --- 182,190 ----
           self.step_status.setStatistic('errors',
 self.logobserver.nbErrors)

       def evaluateCommand(self, cmd):
 + # sometimes it returns -1 when warnings occur, not sure why.
 +         if cmd.rc == 1:
 +             return FAILURE
           if self.logobserver.nbErrors > 0:
               return FAILURE
           if self.logobserver.nbWarnings > 0:
 plm at TommyDevUbuntu1:~/buildbot-0.8.3/buildbot/steps$


 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1772#comment:8>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation