[Buildbot-commits] [Buildbot] #1781: GitPoller default "workdir" should be relative to master

Buildbot nobody at buildbot.net
Wed Jan 26 22:24:56 UTC 2011


#1781: GitPoller default "workdir" should be relative to master
--------------------+-----------------------
Reporter:  tfogal   |      Owner:
    Type:  defect   |     Status:  new
Priority:  minor    |  Milestone:  undecided
 Version:  0.8.3p1  |   Keywords:  git
--------------------+-----------------------
 GitPoller's default is `<temp>/gitpoller_work`.

 {{{
         if self.workdir == None:
             self.workdir = tempfile.gettempdir() + '/gitpoller_work'
 }}}

 This is a poor choice, because it's a global directory and not in any way
 specific to the master.  This means that if the user runs two masters on
 the same server (say, for different projects) and both use a gitpoller,
 they're going to get hit by some sort of painful "gotcha".

 The default should be relative to the basedir.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1781>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation


More information about the Commits mailing list