[Buildbot-commits] [Buildbot] #1772: vstudio.py misses compile errors and doesn't check for exit status

[Buildbot]

#1772: vstudio.py misses compile errors and doesn't check for exit status
----------------------+--------------------
Reporter:  philippem  |       Owner:
    Type:  defect     |      Status:  new
Priority:  major      |   Milestone:  0.8.+
 Version:  0.8.3      |  Resolution:
Keywords:  windows    |
----------------------+--------------------

Comment (by philippem):

 he following patch fixes the problem for me. I've tested both paths
 (failure due to cmd.rc !=0, add regexp matching errors.

 {{{
 diff -c vstudio.py ~plm/buildbot-0.8.3/buildbot/steps/vstudio.py
 *** vstudio.py  2011-01-18 16:25:58.007055399 -0800
 --- /home/plm/buildbot-0.8.3/buildbot/steps/vstudio.py  2010-12-19
 15:50:22.000000000 -0800
 ***************
 *** 39,45 ****
       _re_delimitor = re.compile(r'^(\d+>)?-{5}.+-{5}$')
       _re_file = re.compile(r'^(\d+>)?[^ ]+\.(cpp|c)$')
       _re_warning = re.compile(r' : warning [A-Z]+[0-9]+:')
 !     _re_error = re.compile(r' ?error [A-Z]+[0-9]+\s?: ')

       nbFiles = 0
       nbProjects = 0
 --- 39,45 ----
       _re_delimitor = re.compile(r'^(\d+>)?-{5}.+-{5}$')
       _re_file = re.compile(r'^(\d+>)?[^ ]+\.(cpp|c)$')
       _re_warning = re.compile(r' : warning [A-Z]+[0-9]+:')
 !     _re_error = re.compile(r' error [A-Z]+[0-9]+\s?: ')

       nbFiles = 0
       nbProjects = 0
 ***************
 *** 182,189 ****
           self.step_status.setStatistic('errors',
 self.logobserver.nbErrors)

       def evaluateCommand(self, cmd):
 -         if cmd.rc != 0:
 -             return FAILURE
           if self.logobserver.nbErrors > 0:
               return FAILURE
           if self.logobserver.nbWarnings > 0:
 --- 182,187 ----
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1772#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation