[Buildbot-commits] [Buildbot] #1772: vstudio.py misses compile errors and doesn't check for exit status

[Buildbot]

#1772: vstudio.py misses compile errors and doesn't check for exit status
----------------------+-----------------------
Reporter:  philippem  |      Owner:
    Type:  defect     |     Status:  new
Priority:  major      |  Milestone:  undecided
 Version:  0.8.3      |   Keywords:  VC9 XP
----------------------+-----------------------
 - slave on xp, buildbot 0.8.3
 - devenv compile fails, error message in log is:

 {{{
 33>C:\WINDOWS\Microsoft.NET\Framework\v3.5\Csc.exe /noconfig
 /nowarn:1701,1702 /platform:x86 /errorreport:prompt /warn:4
 /define:TRACE;DEBUG /reference:C:\buildbot-slave\trunk-
 continuous\build\XXX\Caches\bin\Debug\Caches.dll /reference:C:\buildbot-
 slave\trunk-continuous\build\XXX\Common\bin\Debug\Common.dll /reference:C
 :\buildbot-slave\trunk-
 continuous\build\XXX\CommonAPI\bin\Debug\CommonAPI.dll /reference:C
 :\buildbot-slave\trunk-
 continuous\build\XXX\CommonCore\bin\Debug\CommonCore.dll /reference:C
 :\buildbot-slave\trunk-
 continuous\build\XXX\Database\bin\Debug\Database.dll /reference:C
 :\buildbot-slave\trunk-
 continuous\build\XXX\DBCaches\bin\Debug\DBCaches.dll /reference:C
 :\buildbot-slave\trunk-
 continuous\build\XXX\EventQueue\bin\Debug\EventQueue.dll /reference:C
 :\buildbot-slave\trunk-
 continuous\build\XXX\FluorineFx\bin\Debug\FluorineFx.dll /reference:C
 :\buildbot-slave\trunk-continuous\build\XXX\INDMA\bin\INDMA.dll
 /reference:C:\buildbot-slave\trunk-
 continuous\build\XXX\INDMA.Entities\bin\Debug\INDMA.Entities.dll
 /reference:C:\buildbot-slave\trunk-
 continuous\build\XXX\INEventPlugin\bin\Debug\INEventPlugin.dll
 /reference:C:\buildbot-slave\trunk-
 continuous\build\XXX\MediaFields\bin\Debug\MediaFields.dll
 /reference:..\Resources\SqlServer2005\Microsoft.AnalysisServices.AdomdClient.dll
 /reference:C:\buildbot-slave\trunk-
 continuous\build\XXX\Sessions\bin\Debug\Sessions.dll /reference:C
 :\buildbot-slave\trunk-
 continuous\build\XXX\SQLServer\bin\Debug\SQLServer.dll
 /reference:C:\WINDOWS\Microsoft.NET\Framework\v2.0.50727\System.configuration.dll
 /reference:"C:\Program Files\Reference
 Assemblies\Microsoft\Framework\v3.5\System.Core.dll"
 /reference:"C:\Program Files\Reference
 Assemblies\Microsoft\Framework\v3.5\System.Data.DataSetExtensions.dll"
 /reference:C:\WINDOWS\Microsoft.NET\Framework\v2.0.50727\System.Data.dll
 /reference:C:\WINDOWS\Microsoft.NET\Framework\v2.0.50727\System.dll
 /reference:C:\WINDOWS\Microsoft.NET\Framework\v2.0.50727\System.Drawing.dll
 /reference:C:\WINDOWS\Microsoft.NET\Framework\v2.0.50727\System.Web.dll
 /reference:C:\WINDOWS\Microsoft.NET\Framework\v2.0.50727\System.Windows.Forms.dll
 /reference:C:\WINDOWS\Microsoft.NET\Framework\v2.0.50727\System.Xml.dll
 /reference:"C:\Program Files\Reference
 Assemblies\Microsoft\Framework\v3.5\System.Xml.Linq.dll" /debug+
 /debug:full /optimize- /out:obj\Debug\API.dll
 /resource:obj\Debug\API.Platform.resources /target:library /warnaserror+
 AdminConsole\Distribution.cs API.cs AssetImporterAPI.cs
 BackgroundTaskAPI.cs ClientConsole\Catalog.cs ClientConsole\Alerts.cs
 ClientConsole\Menu.cs ClientConsole\Partner.cs
 ClientConsole\ProfilePresentation.cs CommonAPI.cs FileAccessAPI.cs
 Logging.cs MarketplaceAPI.cs MusicServiceAPI.cs OneDigital.cs
 Properties\AssemblyInfo.cs SchedulerAPI.cs SchedulerUtilities.cs
 SyndicationUtilities.cs WebnerAPI.cs WebnerSchedulerAPI.cs
 error CS1504: Source file 'C:\buildbot-slave\trunk-
 continuous\build\XXX\API\SyndicationUtilities.cs' could not be opened
 ('Unspecified error ')
 }}}

 build step is:
 {{{
 f1.addStep(VC9( projectfile="c:\\Source\\XXX\\XXX.sln", config="Debug",
 workdir="C:\\Source", mode="build", name="XXXcompile"));
 }}}

 This build step succeeds, however, it should fail. It appears to be due to
 two things:

 1) the regexp has a leading space, perhaps it should be optional or
 absent:
 https://github.com/djmitche/buildbot/blob/master/master/buildbot/steps/vstudio.py#L42

 (perhaps vc9 has a different error format than earlier versions, not sure)

 2) the exit status of the shell command is not considered when evaluating
 the success of the step, only the number of errors, which is computed by
 the log observer:

 https://github.com/djmitche/buildbot/blob/master/master/buildbot/steps/vstudio.py#L184

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1772>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation