[Buildbot-commits] [Buildbot] #1753: MailNotifier's __init__ has mode values hardcoded in __init__

[Buildbot]

#1753: MailNotifier's __init__ has mode values hardcoded in __init__
----------------------+-----------------------
Reporter:  fgsch      |      Owner:  ayust
    Type:  undecided  |     Status:  new
Priority:  minor      |  Milestone:  undecided
 Version:  0.8.3      |   Keywords:
----------------------+-----------------------
 MailNotifier's __init__ has mode values hardcoded in __init__ so makes it
 difficult to implement new values without overriding __init__.
 It'd be better if the values are moved to class attributes or the assert
 removed entirely:

         assert mode in ('all', 'failing', 'problem', 'change', 'passing')

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1753>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation