[Buildbot-commits] [Buildbot] #1833: test for left-open database cursors

[Buildbot]

#1833: test for left-open database cursors
----------------------------+---------------------
Reporter:  dustin           |       Owner:  dustin
    Type:  defect           |      Status:  closed
Priority:  critical         |   Milestone:  0.8.4
 Version:  master           |  Resolution:  fixed
Keywords:  database, tests  |
----------------------------+---------------------
Changes (by dustin):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 I think this is already effectively tested: the only conflict is to try to
 DROP while a SELECT is in progress.  This is, indeed, what we saw with the
 {{{changeEventGenerator}}}, but since the tests drop all tables after each
 test completes, problems with left-open statements will cause test
 failures.

 I verified this assertion by adding a deliberately left-open statement:
 {{{
 self.r = sometable.select()
 }}}
 into the thd() method in a test.  The result was lots of
 {{{
 sqlalchemy.exc.OperationalError: (OperationalError) database is locked
 u'\nDROP TABLE sourcestamp_changes' ()
 }}}
 and
 {{{
 sqlalchemy.exc.OperationalError: (OperationalError) database table is
 locked u'\nDROP TABLE sourcestamp_changes' ()
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1833#comment:4>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation