[Buildbot-commits] [buildbot/buildbot] d74ae9: Fix reading "change_properties" from the database.

[noreply at github.com]

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: d74ae9e181a16aecbd8e8b40004a0775dd73efd6
    https://github.com/buildbot/buildbot/commit/d74ae9e181a16aecbd8e8b40004a0775dd73efd6
Author: Piotr Sikora <piotr.sikora at frickle.com>
Date:   2011-02-23 (Wed, 23 Feb 2011)

Changed paths:
  M master/buildbot/db/connector.py

Log Message:
-----------
Fix reading "change_properties" from the database.

Current code assumes that all properties are in ["value", "source"]
format, which is true for "buildset_properties" but isn't true for
"change_properties".

This means that builds for changes with properties (like everything
from GerritChangeSource) won't be executed.

It's actually more of a work-around than a fix.


Commit: f2739d6c7f69b59c8f590d6626378094cbbd794f
    https://github.com/buildbot/buildbot/commit/f2739d6c7f69b59c8f590d6626378094cbbd794f
Author: Piotr Sikora <piotr.sikora at frickle.com>
Date:   2011-02-23 (Wed, 23 Feb 2011)

Changed paths:
  M master/buildbot/db/connector.py

Log Message:
-----------
Remove surrounding quotes from value properties.


Commit: fb2150a9ff651357db0a0634432115cfd254f460
    https://github.com/buildbot/buildbot/commit/fb2150a9ff651357db0a0634432115cfd254f460
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-23 (Wed, 23 Feb 2011)

Changed paths:
  M master/buildbot/db/connector.py

Log Message:
-----------
Merge branch 'props-workaround' of git://github.com/PiotrSikora/buildbot

* 'props-workaround' of git://github.com/PiotrSikora/buildbot:
  Remove surrounding quotes from value properties.
  Fix reading "change_properties" from the database.


Commit: 23b015b54cbdf94d5ca723a241ffda1679131051
    https://github.com/buildbot/buildbot/commit/23b015b54cbdf94d5ca723a241ffda1679131051
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-23 (Wed, 23 Feb 2011)

Changed paths:
  M master/buildbot/db/connector.py
  M master/buildbot/test/unit/test_db_connector.py

Log Message:
-----------
fix workaround to not just strip quotes; add tests