[Buildbot-commits] [Buildbot] #1829: PBChangeSource loses string encodings

[Buildbot]

#1829: PBChangeSource loses string encodings
---------------------+--------------------
Reporter:  dustin    |       Owner:
    Type:  defect    |      Status:  new
Priority:  minor     |   Milestone:  0.8.4
 Version:  master    |  Resolution:
Keywords:  encoding  |
---------------------+--------------------

Comment (by dustin):

 I suspect that the right solution here is to allow the sendchange user to
 specify an encoding for the command line (defaulting to the Python
 filesystem encoding?), and decode from that encoding to unicode strings
 before sending to PBChangeSource.

 I don't recall how well PB handles unicode, so that should be tested in a
 unit test that will detect any failures in older versions.

 PBChangeSource should be resilient by trying to decode any raw bytestrings
 it receives as ascii with replacement.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1829#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation