[Buildbot-commits] [Buildbot] #1829: PBChangeSource loses string encodings

[Buildbot]

#1829: PBChangeSource loses string encodings
-------------------+----------------------
Reporter:  dustin  |      Owner:
    Type:  defect  |     Status:  new
Priority:  minor   |  Milestone:  0.8.4
 Version:  master  |   Keywords:  encoding
-------------------+----------------------
 If you run 'buildbot sendchange' and pass utf-8 strings on the command
 line, they will arrive as bytestrings on the PBChangeSource, and great
 sadness will ensue:

 {{{
 2011-02-22 13:46:58+0000 [Broker,5,172.31.17.193] perspective_addChange
 called
 2011-02-22 13:46:58+0000 [Broker,5,172.31.17.193] Peer will receive
 following PB
  traceback:
 2011-02-22 13:46:58+0000 [Broker,5,172.31.17.193] Unhandled Error
         Traceback (most recent call last):
           File "/usr/lib/python2.6/dist-
 packages/twisted/spread/banana.py", line
  153, in gotItem
             self.callExpressionReceived(item)
           File "/usr/lib/python2.6/dist-
 packages/twisted/spread/banana.py", line
  116, in callExpressionReceived
             self.expressionReceived(obj)
           File "/usr/lib/python2.6/dist-packages/twisted/spread/pb.py",
 line 514
 , in expressionReceived
             method(*sexp[1:])
           File "/usr/lib/python2.6/dist-packages/twisted/spread/pb.py",
 line 826
 , in proto_message
             self._recvMessage(self.localObjectForID, requestID, objectID,
 messag
 e, answerRequired, netArgs, netKw)
         --- <exception caught here> ---
           File "/usr/lib/python2.6/dist-packages/twisted/spread/pb.py",
 line 840
 , in _recvMessage
             netResult = object.remoteMessageReceived(self, message,
 netArgs, net
 Kw)
           File "/usr/lib/python2.6/dist-packages/twisted/spread/pb.py",
 line 225
 , in perspectiveMessageReceived
             state = method(*args, **kw)
           File "/usr/local/lib/python2.6/dist-
 packages/buildbot/changes/pb.py",
 line 58, in perspective_addChange
             self.changemaster.addChange(change)
           File "/usr/local/lib/python2.6/dist-
 packages/buildbot/changes/manager.
 py", line 82, in addChange
             change.comments, change.category, change.project))
         exceptions.UnicodeDecodeError: 'ascii' codec can't decode byte
 0xc3 in p
 osition 27: ordinal not in range(128)

 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1829>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation