[Buildbot-commits] [buildbot/buildbot] 49f19a: Refactor DB test code

[noreply at github.com]

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 49f19a02c387cd2db86387b41f1bf57d436e7909
    https://github.com/buildbot/buildbot/commit/49f19a02c387cd2db86387b41f1bf57d436e7909
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-14 (Mon, 14 Feb 2011)

Changed paths:
  M master/buildbot/test/fake/fakedb.py
  M master/buildbot/test/integration/test_upgrade.py
  M master/buildbot/test/regressions/test_import_unicode_changes.py
  M master/buildbot/test/unit/test_db_buildsets.py
  M master/buildbot/test/unit/test_db_changes.py
  M master/buildbot/test/unit/test_db_connector.py
  M master/buildbot/test/unit/test_db_model.py
  M master/buildbot/test/unit/test_db_schedulers.py
  M master/buildbot/test/unit/test_db_sourcestamps.py
  R master/buildbot/test/unit/test_schedulers_timed_Nightly.py
  M master/buildbot/test/util/change_import.py
  M master/buildbot/test/util/connector_component.py
  M master/buildbot/test/util/db.py

Log Message:
-----------
Refactor DB test code

This factors the RealDatabaseMixin and fakedb code to allow test classes
to specify test data that should be inserted into the database before
the test is run.  This accomplishes two things: first, rows can be
inserted in proper dependency order, which is important for Postgres.
Second, it opens the possibility of using the same test scripts (e.g.,
test_db_changes.py) to test the fake database connectors used in testing
the higher-level parts of Buildbot.

Database cleanup is also improved, at the cost of making the database
test depend on the accuracy of buildbot.db.model.


Commit: b68c44d3c6e162a79e5bdd76f6d96d4b5c5936a0
    https://github.com/buildbot/buildbot/commit/b68c44d3c6e162a79e5bdd76f6d96d4b5c5936a0
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-14 (Mon, 14 Feb 2011)

Changed paths:
  M master/buildbot/db/schedulers.py
  M master/buildbot/test/unit/test_db_connector.py
  M master/buildbot/test/unit/test_db_schedulers.py

Log Message:
-----------
Make tests pass for postgres

This involves getting column types right and making sure that
prerequisite rows are inserted first