[Buildbot-commits] [buildbot/buildbot] 12319a: do not schedule a backup timeout if runprocess is ...

[noreply at github.com]

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 12319a700bc79da7943387510463c28eb53b9a02
    https://github.com/buildbot/buildbot/commit/12319a700bc79da7943387510463c28eb53b9a02
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-05 (Sat, 05 Feb 2011)

Changed paths:
  M slave/buildslave/runprocess.py

Log Message:
-----------
do not schedule a backup timeout if runprocess is done

This can happen when the runprocess has finished itself but kill() gets
called anyway.  It should be handled gracefully.


Commit: d2e949f1a16b5b11c85f8b43c5a1d7827ce8d0bc
    https://github.com/buildbot/buildbot/commit/d2e949f1a16b5b11c85f8b43c5a1d7827ce8d0bc
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-06 (Sun, 06 Feb 2011)

Changed paths:
  A slave/buildslave/test/unit/runprocess-scripts.py
  M slave/buildslave/test/unit/test_runprocess.py

Log Message:
-----------
Better tests for killing processes


Commit: a8a5c8ba4d98a8aba186a615109ba6b91ee3558b
    https://github.com/buildbot/buildbot/commit/a8a5c8ba4d98a8aba186a615109ba6b91ee3558b
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-06 (Sun, 06 Feb 2011)

Changed paths:
  M slave/buildslave/commands/base.py
  M slave/buildslave/commands/shell.py
  M slave/buildslave/runprocess.py
  M slave/buildslave/test/fake/runprocess.py
  M slave/buildslave/test/unit/runprocess-scripts.py
  M slave/buildslave/test/unit/test_runprocess.py

Log Message:
-----------
Remove unused keepStdinOpen option

This option is never passed from the master, and has defaulted to False
(meaning that stdin gets closed).  Upon investigation of Twisted, the
pp.closeStdin method only has an effect when usePTY=True:

  http://twistedmatrix.com/trac/browser/tags/releases/twisted-10.2.0/twisted/internet/process.py#L930

So with this patch, stdin is always closed, potentially after writing
the required input.  Tests verify this.

Fixes #1797


Commit: 8ab6e28691b9b3b2fa9734e1dd1780e8381b3373
    https://github.com/buildbot/buildbot/commit/8ab6e28691b9b3b2fa9734e1dd1780e8381b3373
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-06 (Sun, 06 Feb 2011)

Changed paths:
  M slave/buildslave/runprocess.py
  M slave/buildslave/test/unit/test_runprocess.py

Log Message:
-----------
Kill entire process groups

This is technically configurable, but the option is not currently
exposed to users - that can be added later, if it becomes necessary.

Fixes #1796


Commit: 1d3d8f7655b175932d476b2b728885725ed37b47
    https://github.com/buildbot/buildbot/commit/1d3d8f7655b175932d476b2b728885725ed37b47
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-06 (Sun, 06 Feb 2011)

Changed paths:
  M master/docs/cfg-buildsteps.texinfo
  M slave/NEWS

Log Message:
-----------
Be more stern in advising against usePTY

Fixes #1798.