[Buildbot-commits] [Buildbot] #1797: default keepStdinOpen=True when usePTY=True

[Buildbot]

#1797: default keepStdinOpen=True when usePTY=True
------------------------+--------------------
Reporter:  dustin       |      Owner:  dustin
    Type:  enhancement  |     Status:  new
Priority:  major        |  Milestone:  0.8.4
 Version:  0.8.3p1      |   Keywords:  kill
------------------------+--------------------
 Lots of commands don't work well with usePTY=True.  I think that *part* of
 the problem is a race condition with closing the process's stdin, which
 triggers a SIGHUP of the process.  It leads to things like

 {{{
  argv: ['rm', '-rf', 'tools']
  environment:
   CVS_RSH=ssh
 ...
   _=/home/cltbld/bin/python
  closing stdin
  using PTY: True
 process killed by signal 1
 }}}

 where "signal 1" is SIGHUP.  This has caused a lot of pain in the past -
 #158, #284, #198, #255 - and the solution has been, in general, to not use
 usePTY for things that don't actually need a terminal.

 However, it would be helpful to also not close stdin in these cases, since
 generally a terminal's stdin is not closed.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1797>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation