[Buildbot-commits] [Buildbot] #1787: SVN revision is set to string None instead if "force build" button is clicked for a builder

[Buildbot]

#1787: SVN revision is set to string None instead if "force build" button is
clicked for a builder
----------------------+-----------------------
Reporter:  liucougar  |      Owner:
    Type:  defect     |     Status:  new
Priority:  major      |  Milestone:  undecided
 Version:  0.8.3p1    |   Keywords:
----------------------+-----------------------
 if a builder uses SVN to checkout source code, and "force build" button is
 clicked on the web ui for the builder, revision property will be set to
 str(None) instead of python None. this causes something like
 !WithProperty("%(revision)s") fail because it returns "None" instead of ""

 this is a regression (at least 0.8.0 works as expected)

 the fix is one liner: in file
 https://github.com/buildbot/buildbot/blob/master/master/buildbot/steps/source.py,
 insert line "if revision is not None:" before line
 'self.setProperty('revision', str(revision), "Source")'

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1787>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation