From nobody at buildbot.net  Wed Feb  2 01:07:59 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 02 Feb 2011 01:07:59 -0000
Subject: [Buildbot-commits] [Buildbot] #1787: SVN revision is set to string
 None instead if "force build" button is clicked for a builder
Message-ID: <041.9309711cfa9cfd9834a4b553dde0c0ca@buildbot.net>

#1787: SVN revision is set to string None instead if "force build" button is
clicked for a builder
----------------------+-----------------------
Reporter:  liucougar  |      Owner:
    Type:  defect     |     Status:  new
Priority:  major      |  Milestone:  undecided
 Version:  0.8.3p1    |   Keywords:
----------------------+-----------------------
 if a builder uses SVN to checkout source code, and "force build" button is
 clicked on the web ui for the builder, revision property will be set to
 str(None) instead of python None. this causes something like
 !WithProperty("%(revision)s") fail because it returns "None" instead of ""

 this is a regression (at least 0.8.0 works as expected)

 the fix is one liner: in file
 https://github.com/buildbot/buildbot/blob/master/master/buildbot/steps/source.py,
 insert line "if revision is not None:" before line
 'self.setProperty('revision', str(revision), "Source")'

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1787>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Feb  2 01:08:33 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 02 Feb 2011 01:08:33 -0000
Subject: [Buildbot-commits] [Buildbot] #1787: SVN revision is set to
 string None if "force build" button is clicked for a builder (was: SVN
 revision is set to string None instead if "force build" button is clicked
 for a builder)
In-Reply-To: <041.9309711cfa9cfd9834a4b553dde0c0ca@buildbot.net>
References: <041.9309711cfa9cfd9834a4b553dde0c0ca@buildbot.net>
Message-ID: <056.1021d912fd671b22ed37fb0dfe839066@buildbot.net>

#1787: SVN revision is set to string None if "force build" button is clicked for a
builder
----------------------+------------------------
Reporter:  liucougar  |       Owner:
    Type:  defect     |      Status:  new
Priority:  major      |   Milestone:  undecided
 Version:  0.8.3p1    |  Resolution:
Keywords:             |
----------------------+------------------------

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1787#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Feb  2 03:25:56 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 02 Feb 2011 03:25:56 -0000
Subject: [Buildbot-commits] [Buildbot] #1786: master fails to send mail
	with TLS on windows
In-Reply-To: <041.17c065ce0b4b102fac9a5d0fd4a17072@buildbot.net>
References: <041.17c065ce0b4b102fac9a5d0fd4a17072@buildbot.net>
Message-ID: <056.fad43498ea55fc9d6f6abee55f4f0b91@buildbot.net>

#1786: master fails to send mail with TLS on windows
----------------------+------------------------
Reporter:  philippem  |       Owner:
    Type:  defect     |      Status:  new
Priority:  major      |   Milestone:  undecided
 Version:  0.8.3p1    |  Resolution:
Keywords:  windows    |
----------------------+------------------------

Comment (by dustin):

 That particular ticket looks unrelated, but at any rate I think this is a
 problem within Twisted.  I assume you're using 10.2.0 on Windows?

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1786#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Wed Feb  2 03:41:41 2011
From: noreply at github.com (noreply at github.com)
Date: Tue, 1 Feb 2011 19:41:41 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] dcf667: Don't set revision
	to "None"
Message-ID: <20110202034141.5536E422AB@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: dcf667ae0d873b8f145f5f5d9e73429fbcb53265
    https://github.com/buildbot/buildbot/commit/dcf667ae0d873b8f145f5f5d9e73429fbcb53265
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-01 (Tue, 01 Feb 2011)

Changed paths:
  M master/buildbot/steps/source.py

Log Message:
-----------
Don't set revision to "None"

As suggested by liucougar.  Fixes #1787.





From nobody at buildbot.net  Wed Feb  2 03:41:48 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 02 Feb 2011 03:41:48 -0000
Subject: [Buildbot-commits] [Buildbot] #1787: SVN revision is set to
 string None if "force build" button is clicked for a builder
In-Reply-To: <041.9309711cfa9cfd9834a4b553dde0c0ca@buildbot.net>
References: <041.9309711cfa9cfd9834a4b553dde0c0ca@buildbot.net>
Message-ID: <056.eb762e21b54e264e5e330f10510023d0@buildbot.net>

#1787: SVN revision is set to string None if "force build" button is clicked for a
builder
----------------------+------------------------
Reporter:  liucougar  |       Owner:
    Type:  defect     |      Status:  closed
Priority:  major      |   Milestone:  undecided
 Version:  0.8.3p1    |  Resolution:  fixed
Keywords:             |
----------------------+------------------------
Changes (by Dustin J. Mitchell):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Don't set revision to "None"

 As suggested by liucougar.  Fixes #1787.
  Changeset: dcf667ae0d873b8f145f5f5d9e73429fbcb53265

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1787#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Feb  2 03:42:22 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 02 Feb 2011 03:42:22 -0000
Subject: [Buildbot-commits] [Buildbot] #1786: master fails to send mail
	with TLS on windows
In-Reply-To: <041.17c065ce0b4b102fac9a5d0fd4a17072@buildbot.net>
References: <041.17c065ce0b4b102fac9a5d0fd4a17072@buildbot.net>
Message-ID: <056.83c24f17990dbcf838a3beab7106d74b@buildbot.net>

#1786: master fails to send mail with TLS on windows
----------------------+------------------------
Reporter:  philippem  |       Owner:
    Type:  defect     |      Status:  new
Priority:  major      |   Milestone:  undecided
 Version:  0.8.3p1    |  Resolution:
Keywords:  windows    |
----------------------+------------------------

Comment (by philippem):

 yes 10.2.0 on xp

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1786#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Feb  2 03:43:05 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 02 Feb 2011 03:43:05 -0000
Subject: [Buildbot-commits] [Buildbot] #1786: master fails to send mail
	with TLS on windows
In-Reply-To: <041.17c065ce0b4b102fac9a5d0fd4a17072@buildbot.net>
References: <041.17c065ce0b4b102fac9a5d0fd4a17072@buildbot.net>
Message-ID: <056.473d270c22fd121c711b8e686156b115@buildbot.net>

#1786: master fails to send mail with TLS on windows
----------------------+------------------------
Reporter:  philippem  |       Owner:
    Type:  defect     |      Status:  new
Priority:  major      |   Milestone:  undecided
 Version:  0.8.3p1    |  Resolution:
Keywords:  windows    |
----------------------+------------------------

Comment (by philippem):

 sorry, 10.2.0 on windows server 2008 r2

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1786#comment:4>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Feb  2 04:34:56 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 02 Feb 2011 04:34:56 -0000
Subject: [Buildbot-commits] [Buildbot] #1786: master fails to send mail
	with TLS on windows
In-Reply-To: <041.17c065ce0b4b102fac9a5d0fd4a17072@buildbot.net>
References: <041.17c065ce0b4b102fac9a5d0fd4a17072@buildbot.net>
Message-ID: <056.b2740c0685760da43fdbc455831a5d16@buildbot.net>

#1786: master fails to send mail with TLS on windows
----------------------+------------------------
Reporter:  philippem  |       Owner:
    Type:  defect     |      Status:  new
Priority:  major      |   Milestone:  undecided
 Version:  0.8.3p1    |  Resolution:
Keywords:  windows    |
----------------------+------------------------

Comment (by dustin):

 From a brief look at the code, I bet you're exactly right about the line
 endings.  It uses {{{.splitlines}}} to split the response into distinct
 lines, and I bet that expects native line endings.

 Can you make a small test program to test this out, and file a Twisted bug
 if it doesn't work?

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1786#comment:5>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Feb  2 19:37:41 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 02 Feb 2011 19:37:41 -0000
Subject: [Buildbot-commits] [Buildbot] #1787: SVN revision is set to
 string None if "force build" button is clicked for a builder
In-Reply-To: <041.9309711cfa9cfd9834a4b553dde0c0ca@buildbot.net>
References: <041.9309711cfa9cfd9834a4b553dde0c0ca@buildbot.net>
Message-ID: <056.ee69909521397ea8eea2b6247081f018@buildbot.net>

#1787: SVN revision is set to string None if "force build" button is clicked for a
builder
----------------------+---------------------
Reporter:  liucougar  |       Owner:
    Type:  defect     |      Status:  closed
Priority:  major      |   Milestone:  0.8.4
 Version:  0.8.3p1    |  Resolution:  fixed
Keywords:             |
----------------------+---------------------
Changes (by liucougar):

 * milestone:  undecided => 0.8.4


-- 
Ticket URL: <http://trac.buildbot.net/ticket/1787#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Feb  2 21:12:40 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 02 Feb 2011 21:12:40 -0000
Subject: [Buildbot-commits] [Buildbot] #1788: MQ options
Message-ID: <038.562d4de9cecd700250275a2eb5a51f11@buildbot.net>

#1788: MQ options
------------------------+--------------------
Reporter:  dustin       |      Owner:
    Type:  enhancement  |     Status:  new
Priority:  major        |  Milestone:  0.10.+
 Version:  0.8.3p1      |   Keywords:
------------------------+--------------------
 When Buildbot adopts an MQ framework, there are a number of choices.
 Among them:

  * http://morbidq.com/
  * http://code.google.com/p/coilmq/
  * zeromq

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1788>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Thu Feb  3 02:28:17 2011
From: noreply at github.com (noreply at github.com)
Date: Wed, 2 Feb 2011 18:28:17 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] 83b24d: Ignore repo changes
	for Git sourcedataMatches()
Message-ID: <20110203022817.DAE234234F@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 83b24dcc9b478a6589bd8df9250110bf5e7f0ebd
    https://github.com/buildbot/buildbot/commit/83b24dcc9b478a6589bd8df9250110bf5e7f0ebd
Author: Amber Yust <ayust at yelp.com>
Date:   2011-02-02 (Wed, 02 Feb 2011)

Changed paths:
  M slave/buildslave/commands/git.py

Log Message:
-----------
Ignore repo changes for Git sourcedataMatches()

Git is more than willing to fetch branches from completely unrelated
repositories into the same local repository (it'll give a warning about
'no related commits', but that's not a problem). There's no reason to
throw away the current repository and re-clone just because the repo
changed (and it saves a lot of time if the different remotes are
actually just different clones of the same project).





From noreply at github.com  Thu Feb  3 02:30:39 2011
From: noreply at github.com (noreply at github.com)
Date: Wed, 2 Feb 2011 18:30:39 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] ceec0d: Fix pyflakes warning
Message-ID: <20110203023039.5BEA74234F@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: ceec0d61d0e0d1cd43b581182336fc6d24d6f998
    https://github.com/buildbot/buildbot/commit/ceec0d61d0e0d1cd43b581182336fc6d24d6f998
Author: Amber Yust <ayust at yelp.com>
Date:   2011-02-02 (Wed, 02 Feb 2011)

Changed paths:
  M slave/buildslave/commands/git.py

Log Message:
-----------
Fix pyflakes warning





From noreply at github.com  Thu Feb  3 03:09:16 2011
From: noreply at github.com (noreply at github.com)
Date: Wed, 2 Feb 2011 19:09:16 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] 75d8fe: add test for old path
Message-ID: <20110203030916.E017D42302@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 75d8feefbf67301d3262789588a75eeffabec5ab
    https://github.com/buildbot/buildbot/commit/75d8feefbf67301d3262789588a75eeffabec5ab
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-02 (Wed, 02 Feb 2011)

Changed paths:
  M master/buildbot/test/unit/test_oldpaths.py

Log Message:
-----------
add test for old path


Commit: 179a9e7e66d061e96501f6eb3735b4612931451c
    https://github.com/buildbot/buildbot/commit/179a9e7e66d061e96501f6eb3735b4612931451c
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-02 (Wed, 02 Feb 2011)

Changed paths:
  M master/buildbot/master.py
  A master/buildbot/test/unit/test_master.py
  A master/buildbot/test/unit/test_util_subscriptions.py
  A master/buildbot/util/subscription.py

Log Message:
-----------
add support for subscribing to changes via the master


Commit: f11463668e9af59267bc0e9d456f0f6f1361ad60
    https://github.com/buildbot/buildbot/commit/f11463668e9af59267bc0e9d456f0f6f1361ad60
Author: Dustin J. Mitchell <dustin at v.igoro.us>
Date:   2011-02-02 (Wed, 02 Feb 2011)

Changed paths:
  M master/buildbot/process/properties.py
  M master/buildbot/test/unit/test_process_properties.py

Log Message:
-----------
add and test Properties asDict method


Commit: 8a142586336a35625faba996e6d7a8a7b215d95e
    https://github.com/buildbot/buildbot/commit/8a142586336a35625faba996e6d7a8a7b215d95e
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-02 (Wed, 02 Feb 2011)

Changed paths:
  M common/coveragerc

Log Message:
-----------
don't try to cover conditionals on twisted versions


Commit: 5285a240659ae405b02f7193c4993336441b0172
    https://github.com/buildbot/buildbot/commit/5285a240659ae405b02f7193c4993336441b0172
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-02 (Wed, 02 Feb 2011)

Changed paths:
  M master/buildbot/db/changes.py

Log Message:
-----------
docstring improvements





From nobody at buildbot.net  Thu Feb  3 09:09:15 2011
From: nobody at buildbot.net (Buildbot)
Date: Thu, 03 Feb 2011 09:09:15 -0000
Subject: [Buildbot-commits] [Buildbot] #1789: TypeError:
 makeDbgPerspective() takes no arguments (2 given)
Message-ID: <040.a60f833a3d19967c7d593c389ac6db45@buildbot.net>

#1789: TypeError: makeDbgPerspective() takes no arguments (2 given)
---------------------+-----------------------
Reporter:  bsavelev  |      Owner:
    Type:  defect    |     Status:  new
Priority:  major     |  Milestone:  undecided
 Version:  0.8.3p1   |   Keywords:
---------------------+-----------------------
 upgrade from 0.8.1 to 0.8.3p1 broke debugclient for me

 twisted 8.1.0-4

 I run `buildbot debugclient -m localhost:9989 -pdebugpw`
 When I click 'connect' button in buildbot master print to log:
 {{{
 2011-02-03 12:03:49+0300 [Broker,3,127.0.0.1] Peer will receive following
 PB traceback:
 2011-02-03 12:03:49+0300 [Broker,3,127.0.0.1] Unhandled Error
         Traceback (most recent call last):
           File "/usr/lib/python2.5/site-
 packages/twisted/internet/defer.py", line 195, in addCallback
             callbackKeywords=kw)
           File "/usr/lib/python2.5/site-
 packages/twisted/internet/defer.py", line 186, in addCallbacks
             self._runCallbacks()
           File "/usr/lib/python2.5/site-
 packages/twisted/internet/defer.py", line 328, in _runCallbacks
             self.result = callback(self.result, *args, **kw)
           File "/usr/lib/python2.5/site-packages/buildbot/pbmanager.py",
 line 138, in requestAvatar
             d = defer.maybeDeferred(afactory, mind, username)
         --- <exception caught here> ---
           File "/usr/lib/python2.5/site-
 packages/twisted/internet/defer.py", line 106, in maybeDeferred
             result = f(*args, **kw)
         exceptions.TypeError: makeDbgPerspective() takes no arguments (2
 given)

 }}}

 client failed to connect

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1789>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Thu Feb  3 13:06:32 2011
From: nobody at buildbot.net (Buildbot)
Date: Thu, 03 Feb 2011 13:06:32 -0000
Subject: [Buildbot-commits] [Buildbot] #1784: Buildmaster blocks
In-Reply-To: <040.b9bf7390b4609c7970b110cd158d5cf1@buildbot.net>
References: <040.b9bf7390b4609c7970b110cd158d5cf1@buildbot.net>
Message-ID: <055.05882c6085efbcfa346dc1167960d8b2@buildbot.net>

#1784: Buildmaster blocks
---------------------+--------------------
Reporter:  Schenker  |       Owner:
    Type:  defect    |      Status:  new
Priority:  major     |   Milestone:  0.8.4
 Version:  0.8.0     |  Resolution:
Keywords:            |
---------------------+--------------------

Comment (by Schenker):

 I ran strace on the master process. As I mentioned above - during the time
 when the master is frozen the web page cannot be opened and there's no
 activity marked in the twistd.log (I notice that there's no activity in
 the twistd.log because every 2 minutes the master checks the SVN for the
 latest revision and that is written in the log - when the master is frozen
 there's no such activity in the log). But in that time the strace shows
 output, including the SVN polling:


 {{{
 select(12, [3 5 6 8 9 11], [], [], {0, 687206}) = 0 (Timeout)
 write(4, "2011-02-03 14:07:00+0200 [-] SVN"..., 47) = 47
 pipe([12, 13])                          = 0
 pipe([14, 15])                          = 0
 pipe([16, 17])                          = 0
 clone(child_stack=0,
 flags=CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD,
 child_tidptr=0x2ab3ffba5ff0) = 19642
 close(12)                               = 0
 fcntl(13, F_GETFL)                      = 0x1 (flags O_WRONLY)
 fcntl(13, F_SETFL, O_WRONLY|O_NONBLOCK) = 0
 fstat(13, {st_mode=S_IFIFO|0600, st_size=0, ...}) = 0
 close(15)                               = 0
 fcntl(14, F_GETFL)                      = 0 (flags O_RDONLY)
 fcntl(14, F_SETFL, O_RDONLY|O_NONBLOCK) = 0
 close(17)                               = 0
 fcntl(16, F_GETFL)                      = 0 (flags O_RDONLY)
 fcntl(16, F_SETFL, O_RDONLY|O_NONBLOCK) = 0
 wait4(19642, 0x7fffb3a25b64, WNOHANG, NULL) = 0
 select(17, [3 5 6 8 9 11 13 14 16], [], [], {0, 306986}) = 1 (in [14],
 left {0, 294000})
 read(14, "<?xml version=\"1.0\"?>\n<log>\n", 8192) = 28
 select(17, [3 5 6 8 9 11 13 14 16], [], [], {0, 293722}) = 1 (in [14],
 left {0, 232000})
 read(14, "<logentry\n   revision=\"37510\">\n<"..., 8192) = 1039
 select(17, [3 5 6 8 9 11 13 14 16], [], [], {0, 230957}) = 1 (in [14],
 left {0, 230957})
 read(14, "<logentry\n   revision=\"37501\">\n<"..., 8192) = 4016
 select(17, [3 5 6 8 9 11 13 14 16], [], [], {0, 230740}) = 1 (in [14],
 left {0, 230740})
 read(14, "<logentry\n   revision=\"37489\">\n<"..., 8192) = 1196
 select(17, [3 5 6 8 9 11 13 14 16], [], [], {0, 230546}) = 3 (in [13 14
 16], left {0, 228000})
 --- SIGCHLD (Child exited) @ 0 (0) ---
 write(10, "x", 1)                       = 1
 rt_sigreturn(0x2)                       = 3
 read(14, "", 8192)                      = 0
 close(14)                               = 0
 fcntl(13, F_GETFL)                      = 0x801 (flags
 O_WRONLY|O_NONBLOCK)
 fcntl(13, F_SETFL, O_WRONLY)            = 0
 close(13)                               = 0
 read(16, "", 8192)                      = 0
 close(16)                               = 0
 wait4(19642, [{WIFEXITED(s) && WEXITSTATUS(s) == 0}], WNOHANG, NULL) =
 19642
 write(4, "2011-02-03 14:07:00+0200 [-] svn"..., 85) = 85
 write(4, "2011-02-03 14:07:00+0200 [-] svn"..., 72) = 72
 write(4, "2011-02-03 14:07:00+0200 [-] SVN"..., 56) = 56
 write(4, "2011-02-03 14:07:00+0200 [-] _fi"..., 46) = 46
 select(12, [3 5 6 8 9 11], [], [], {0, 218745}) = 1 (in [3], left {0,
 218745})
 read(3, "x", 8192)                      = 1
 select(12, [3 5 6 8 9 11], [], [], {0, 218513}) = 0 (Timeout)
 select(12, [3 5 6 8 9 11], [], [], {0, 17}) = 0 (Timeout)
 select(12, [3 5 6 8 9 11], [], [], {0, 999948}) = 0 (Timeout)
 }}}

 So ... obviously the master is not entirely blocked ... but the result is
 the same - about 20 minutes after the master stops resonding the slave is
 detached and the build - interrupted with the following output:


 {{{
 [Failure instance: Traceback (failure with no frames): <class
 'twisted.internet.error.ConnectionLost'>: Connection to the other side was
 lost in a non-clean fashion.
 ]
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1784#comment:6>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Thu Feb  3 17:53:33 2011
From: nobody at buildbot.net (Buildbot)
Date: Thu, 03 Feb 2011 17:53:33 -0000
Subject: [Buildbot-commits] [Buildbot] #1790: Option to turn off
	hacky_HA_mode in schedulers
Message-ID: <035.292c6bc21dbda0cafa9d366bfc8f411e@buildbot.net>

#1790: Option to turn off hacky_HA_mode in schedulers
----------------------+-----------------------
Reporter:  aki        |      Owner:
    Type:  undecided  |     Status:  new
Priority:  major      |  Milestone:  undecided
 Version:  0.8.3p1    |   Keywords:
----------------------+-----------------------
 As Dustin explains it, the scheduler is "being durable in the face of
 downtime" by looking at the next scheduled build and scheduling it
 immediately if it happens in the past.

 This may be a feature for some, but it is definitely a bug for others.
 In the case of "We don't want nightlies to fire at all until 9:30am
 tomorrow, so delay our 3am nightly scheduled time", there is currently no
 option to do that other than disabling the schedulers until 9:30am.

 There should be a way to turn this behavior off.  Currently I'm thinking
 schedulers should have a hackyHAMode=False or something.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1790>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Thu Feb  3 18:00:41 2011
From: nobody at buildbot.net (Buildbot)
Date: Thu, 03 Feb 2011 18:00:41 -0000
Subject: [Buildbot-commits] [Buildbot] #1790: Nightly scheduler should
 have an option to not re-schedule missed builds (was: Option to turn off
 hacky_HA_mode in schedulers)
In-Reply-To: <035.292c6bc21dbda0cafa9d366bfc8f411e@buildbot.net>
References: <035.292c6bc21dbda0cafa9d366bfc8f411e@buildbot.net>
Message-ID: <050.0ebf7474474a7cc6a7eeb1db8aadb29e@buildbot.net>

#1790: Nightly scheduler should have an option to not re-schedule missed builds
------------------------+--------------------
Reporter:  aki          |       Owner:
    Type:  enhancement  |      Status:  new
Priority:  major        |   Milestone:  0.8.+
 Version:  0.8.2        |  Resolution:
Keywords:               |
------------------------+--------------------
Changes (by dustin):

 * type:  undecided => enhancement
 * version:  0.8.3p1 => 0.8.2
 * milestone:  undecided => 0.8.+


Comment:

 To be fair, this is also a feature at Mozilla, so by adding an option to
 disable this, we'll run the risk of missing nightlies if a master is in
 the midst of a reconfig at the time the nightlies should fire.

 That's a much smaller risk, of course.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1790#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Thu Feb  3 18:04:44 2011
From: nobody at buildbot.net (Buildbot)
Date: Thu, 03 Feb 2011 18:04:44 -0000
Subject: [Buildbot-commits] [Buildbot] #1790: Nightly scheduler should
 have an option to not re-schedule missed builds
In-Reply-To: <035.292c6bc21dbda0cafa9d366bfc8f411e@buildbot.net>
References: <035.292c6bc21dbda0cafa9d366bfc8f411e@buildbot.net>
Message-ID: <050.66106579a742f013b4077204504f10de@buildbot.net>

#1790: Nightly scheduler should have an option to not re-schedule missed builds
------------------------+--------------------
Reporter:  aki          |       Owner:
    Type:  enhancement  |      Status:  new
Priority:  major        |   Milestone:  0.8.+
 Version:  0.8.2        |  Resolution:
Keywords:               |
------------------------+--------------------

Comment (by aki):

 I'm not going to read that as "I'm not going to provide an option, for
 your own protection" :)

 If we decide we really want this HA feature 99% of the time, having the
 option still means we can turn this off whenever we delay a nightly, and
 go back to default when we set it back.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1790#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Thu Feb  3 18:46:11 2011
From: nobody at buildbot.net (Buildbot)
Date: Thu, 03 Feb 2011 18:46:11 -0000
Subject: [Buildbot-commits] [Buildbot] #1790: Nightly scheduler should
 have an option to not re-schedule missed builds
In-Reply-To: <035.292c6bc21dbda0cafa9d366bfc8f411e@buildbot.net>
References: <035.292c6bc21dbda0cafa9d366bfc8f411e@buildbot.net>
Message-ID: <050.c3f93e2528b60b4ea6fcfa680aebe576@buildbot.net>

#1790: Nightly scheduler should have an option to not re-schedule missed builds
------------------------+--------------------
Reporter:  aki          |       Owner:
    Type:  enhancement  |      Status:  new
Priority:  major        |   Milestone:  0.8.+
 Version:  0.8.2        |  Resolution:
Keywords:               |
------------------------+--------------------

Comment (by dustin):

 That reading is incorrect.  Note that the bug is still open.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1790#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Thu Feb  3 18:58:17 2011
From: noreply at github.com (noreply at github.com)
Date: Thu, 3 Feb 2011 10:58:17 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] 384d9d: fix model defaults,
	add docs
Message-ID: <20110203185817.11D66422DF@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 384d9df838b2b76120acb1335114c9926f086a5f
    https://github.com/buildbot/buildbot/commit/384d9df838b2b76120acb1335114c9926f086a5f
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-03 (Thu, 03 Feb 2011)

Changed paths:
  M master/buildbot/db/model.py

Log Message:
-----------
fix model defaults, add docs

The old default was the string "NULL", rather than an actual NULL.


Commit: d0a3f5b6a48e524bd4c110394d676179306c9c65
    https://github.com/buildbot/buildbot/commit/d0a3f5b6a48e524bd4c110394d676179306c9c65
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-03 (Thu, 03 Feb 2011)

Changed paths:
  A master/buildbot/db/buildsets.py
  M master/buildbot/db/connector.py
  A master/buildbot/test/unit/test_db_buildsets.py

Log Message:
-----------
add buildbot.db.buildsets

A database connector component to handle buildsets and their component
buildrequests, along with tests.


Commit: a675d1fe55227f8077cf7642352e0fd92a59f999
    https://github.com/buildbot/buildbot/commit/a675d1fe55227f8077cf7642352e0fd92a59f999
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-03 (Thu, 03 Feb 2011)

Changed paths:
  M master/buildbot/db/connector.py
  A master/buildbot/db/schedulers.py
  A master/buildbot/test/unit/test_db_schedulers.py

Log Message:
-----------
add master.buildbot.db.schedulers

Database connector component that handles state management for
schedulers.  This re-implements existing database functionality
from previous versions, even where that functionality doesn't
make much sense.


Commit: 14cbf827897f92218ebcb52d3d3d4bbbe1285e47
    https://github.com/buildbot/buildbot/commit/14cbf827897f92218ebcb52d3d3d4bbbe1285e47
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-03 (Thu, 03 Feb 2011)

Changed paths:
  M master/buildbot/db/connector.py
  A master/buildbot/db/sourcestamps.py
  A master/buildbot/test/unit/test_db_sourcestamps.py

Log Message:
-----------
add master.db.sourcestamps

A database connector component to handle sourcestamps


Commit: 2d421120c6b75d7dd1ed7245c87ca7d84c8d73f2
    https://github.com/buildbot/buildbot/commit/2d421120c6b75d7dd1ed7245c87ca7d84c8d73f2
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-03 (Thu, 03 Feb 2011)

Changed paths:
  M master/NEWS
  A master/buildbot/changes/filter.py
  M master/buildbot/schedulers/filter.py
  A master/buildbot/test/unit/test_changes_filter.py
  M master/buildbot/test/unit/test_oldpaths.py
  R master/buildbot/test/unit/test_schedulers_filter.py
  M master/docs/cfg-schedulers.texinfo

Log Message:
-----------
move buildbot.schedulers.filter to buildbot.changes.filter

The old name still works





From nobody at buildbot.net  Fri Feb  4 03:16:04 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 04 Feb 2011 03:16:04 -0000
Subject: [Buildbot-commits] [Buildbot] #1791: ComparableMixin should just
 return "not equal" if compare_attrs differ
Message-ID: <038.eb1aa2bb0aa8dd735767fb0052c95a9c@buildbot.net>

#1791: ComparableMixin should just return "not equal" if compare_attrs differ
------------------------+----------------------
Reporter:  dustin       |      Owner:
    Type:  enhancement  |     Status:  new
Priority:  major        |  Milestone:  0.8.4
 Version:  0.8.3p1      |   Keywords:  reconfig
------------------------+----------------------
 We're seeing a case at Mozilla where when a reconfig occurs and a
 reconfig'able class (a status plugin) has changed its {{{compare_attrs}}},
 {{{__cmp__}}} fails with an assertion error.  The more correct thing to do
 would be to say "nope, those objects are not the same".

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1791>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Feb  4 14:23:21 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 04 Feb 2011 14:23:21 -0000
Subject: [Buildbot-commits] [Buildbot] #1792: BuildStep timeout detection
 does not kill child processes
Message-ID: <039.14cf233d06aa59ee47095ab92db24314@buildbot.net>

#1792: BuildStep timeout detection does not kill child processes
--------------------+-----------------------
Reporter:  cortana  |      Owner:
    Type:  defect   |     Status:  new
Priority:  major    |  Milestone:  undecided
 Version:  0.8.2    |   Keywords:
--------------------+-----------------------
 I have noticed my buildslave machine becoming overloaded several times
 recently. I believe this is caused by the following sequence of events:

  1. 'make check' is run as part of a build
  2. buildbot sends SIGKILL to the build process because it takes too long
  3. only the top-level process is killed: child processes are not killed,
 so the test suite continues to run!
  4. buildbot kicks off another build...

 The result is 8-9 copies of the test suite from improperly killed-off
 builds hanging around, until I SSH in and kill all buildslave processes by
 hand.

 Possible solutions:

  * when killing a BuildStep, issue it a SIGINT, instead of SIGKILL. In my
 case, this would have allowed make to kill off all child processes
 properly, as if I had hit Ctrl+C in a terminal.
  * to guard against buggy build systems, however, you probably want to
 send a SIGINT, then wait 10 seconds, then send a SIGKILL to the buildstep
 *and all its child processes*. Either by hand, or using some kind of
 session group magic from POSIX.
  * I believe that in modern Linux kernels, the same can be achieved with
 'cgroups'. Each build would go into its own cgroup, and then the
 buildslave can kill all processes in a cgroup at once.

 Workaround: increase 'timeout' property of the 'make check' BuildStep.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1792>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Feb  4 16:22:55 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 04 Feb 2011 16:22:55 -0000
Subject: [Buildbot-commits] [Buildbot] #1792: BuildStep timeout
 detection does not kill child processes
In-Reply-To: <039.14cf233d06aa59ee47095ab92db24314@buildbot.net>
References: <039.14cf233d06aa59ee47095ab92db24314@buildbot.net>
Message-ID: <054.12312d672e3f397f915de1113462b002@buildbot.net>

#1792: BuildStep timeout detection does not kill child processes
------------------------+--------------------
Reporter:  cortana      |       Owner:
    Type:  enhancement  |      Status:  new
Priority:  major        |   Milestone:  0.8.+
 Version:  0.8.2        |  Resolution:
Keywords:  kill         |
------------------------+--------------------
Changes (by dustin):

 * keywords:   => kill
 * type:  defect => enhancement
 * milestone:  undecided => 0.8.+


Comment:

 Yes, in general, killing is very difficult to get right, particularly
 across platforms.  It's not very configurable right now, and that should
 be improved.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1792#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Feb  4 16:26:22 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 04 Feb 2011 16:26:22 -0000
Subject: [Buildbot-commits] [Buildbot] #751: Sending SIGTERM before
 SIGKILL to a remote shell command that has timed out
In-Reply-To: <039.dcb9a7fb11f75338b8ab2d3a879a747e@buildbot.net>
References: <039.dcb9a7fb11f75338b8ab2d3a879a747e@buildbot.net>
Message-ID: <054.619610708eb9180d94a38f30f89ad469@buildbot.net>

#751: Sending SIGTERM before SIGKILL to a remote shell command that has timed out
------------------------+------------------------
Reporter:  Fabrice      |       Owner:
    Type:  enhancement  |      Status:  reopened
Priority:  minor        |   Milestone:  undecided
 Version:  0.7.12       |  Resolution:
Keywords:  kill         |
------------------------+------------------------
Changes (by dustin):

 * keywords:   => kill
 * status:  closed => reopened
 * resolution:  wontfix =>


-- 
Ticket URL: <http://trac.buildbot.net/ticket/751#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Feb  4 16:27:38 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 04 Feb 2011 16:27:38 -0000
Subject: [Buildbot-commits] [Buildbot] #931: SIGKILL doesn't kill
	children processes
In-Reply-To: <038.c2524bfd0fee980c82dd1fdd0cfde8ed@buildbot.net>
References: <038.c2524bfd0fee980c82dd1fdd0cfde8ed@buildbot.net>
Message-ID: <053.c519f0b9baca7d4ef34112844186a65a@buildbot.net>

#931: SIGKILL doesn't kill children processes
------------------------+------------------------
Reporter:  acanis       |       Owner:
    Type:  enhancement  |      Status:  closed
Priority:  major        |   Milestone:  0.8.+
 Version:  0.8.0        |  Resolution:  duplicate
Keywords:  kill         |
------------------------+------------------------
Changes (by dustin):

 * keywords:   => kill
 * status:  new => closed
 * resolution:   => duplicate


Comment:

 Duping forward to #1792, which has more suggestions

-- 
Ticket URL: <http://trac.buildbot.net/ticket/931#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Feb  4 16:28:05 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 04 Feb 2011 16:28:05 -0000
Subject: [Buildbot-commits] [Buildbot] #1749: xp slave fails to kill
 child process after network disconnect
In-Reply-To: <041.0ba5760290cca1b300b9ab289147eda3@buildbot.net>
References: <041.0ba5760290cca1b300b9ab289147eda3@buildbot.net>
Message-ID: <056.b2c3b6e927bfe8e3be79f671c72f6f72@buildbot.net>

#1749: xp slave fails to kill child process after network disconnect
--------------------------+--------------------
Reporter:  philippem      |       Owner:
    Type:  defect         |      Status:  new
Priority:  critical       |   Milestone:  0.8.+
 Version:  0.8.3          |  Resolution:
Keywords:  windows, kill  |
--------------------------+--------------------
Changes (by dustin):

 * keywords:  windows => windows, kill


-- 
Ticket URL: <http://trac.buildbot.net/ticket/1749#comment:18>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Feb  4 20:08:37 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 04 Feb 2011 20:08:37 -0000
Subject: [Buildbot-commits] [Buildbot] #1793: StatusPush uses
 setServiceParent instead of startService
Message-ID: <038.535a6264c4fbfbb9e9546ca90a7f01d4@buildbot.net>

#1793: StatusPush uses setServiceParent instead of startService
--------------------+-------------------
Reporter:  dustin   |      Owner:
    Type:  defect   |     Status:  new
Priority:  major    |  Milestone:  0.8.4
 Version:  0.8.3p1  |   Keywords:
--------------------+-------------------
 This potentially starts the service long before it should be.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1793>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Feb  4 23:49:36 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 04 Feb 2011 23:49:36 -0000
Subject: [Buildbot-commits] [Buildbot] #1794: UI for displaying test results
Message-ID: <041.e541d58ea8c1293e93ea80873861e229@buildbot.net>

#1794: UI for displaying test results
----------------------+-----------------------
Reporter:  liucougar  |      Owner:  liucougar
    Type:  task       |     Status:  new
Priority:  major      |  Milestone:  undecided
 Version:  0.8.3p1    |   Keywords:
----------------------+-----------------------
 a customize UI for pypy is available here:
 http://buildbot.pypy.org/summary?branch=%3Ctrunk%3E

 source code is at http://codespeak.net/svn/pypy/build/bot2/pypybuildbot/

 see how to generalize it and merge it in buildbot (pypy is BSD licensed)

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1794>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Feb  5 05:34:50 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 05 Feb 2011 05:34:50 -0000
Subject: [Buildbot-commits] [Buildbot] #1786: master fails to send mail
	with TLS on windows
In-Reply-To: <041.17c065ce0b4b102fac9a5d0fd4a17072@buildbot.net>
References: <041.17c065ce0b4b102fac9a5d0fd4a17072@buildbot.net>
Message-ID: <056.ffaeb54f3a37e32b2df277f11d1a611d@buildbot.net>

#1786: master fails to send mail with TLS on windows
----------------------+------------------------
Reporter:  philippem  |       Owner:
    Type:  defect     |      Status:  new
Priority:  major      |   Milestone:  undecided
 Version:  0.8.3p1    |  Resolution:
Keywords:  windows    |
----------------------+------------------------

Comment (by philippem):

 Turns out the failure is due to Twisted not being able to import ssl,
 which depends on PyOpenSSL, which is not on the machine. not sure why,
 perhaps it's not there in windows by default.

 I will install the pyopenssl egg and see what happens.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1786#comment:6>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Feb  5 05:51:34 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 05 Feb 2011 05:51:34 -0000
Subject: [Buildbot-commits] [Buildbot] #1786: master fails to send mail
	with TLS on windows
In-Reply-To: <041.17c065ce0b4b102fac9a5d0fd4a17072@buildbot.net>
References: <041.17c065ce0b4b102fac9a5d0fd4a17072@buildbot.net>
Message-ID: <056.316243adb558b11c7d9210d43134756f@buildbot.net>

#1786: master fails to send mail with TLS on windows
----------------------+------------------------
Reporter:  philippem  |       Owner:
    Type:  defect     |      Status:  closed
Priority:  major      |   Milestone:  undecided
 Version:  0.8.3p1    |  Resolution:  invalid
Keywords:  windows    |
----------------------+------------------------
Changes (by philippem):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 yes this is due to the missing pre-requisite pyOpenSSL. I installed via
 egg and it works. Yay!
 thanks

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1786#comment:7>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Feb  5 05:52:15 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 05 Feb 2011 05:52:15 -0000
Subject: [Buildbot-commits] [Buildbot] #1786: master fails to send mail
	with TLS on windows
In-Reply-To: <041.17c065ce0b4b102fac9a5d0fd4a17072@buildbot.net>
References: <041.17c065ce0b4b102fac9a5d0fd4a17072@buildbot.net>
Message-ID: <056.001e394fbe7deb3b49376b5482ee0285@buildbot.net>

#1786: master fails to send mail with TLS on windows
----------------------+------------------------
Reporter:  philippem  |       Owner:
    Type:  defect     |      Status:  closed
Priority:  major      |   Milestone:  undecided
 Version:  0.8.3p1    |  Resolution:  invalid
Keywords:  windows    |
----------------------+------------------------

Comment (by philippem):

 (we were probably both looking at the twisted code and assuming that
 self.context was True, but in fact it was None.)

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1786#comment:8>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Feb  5 17:47:30 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 05 Feb 2011 17:47:30 -0000
Subject: [Buildbot-commits] [Buildbot] #1795: add python script slave-side
	command
Message-ID: <038.e85839bcaeecc89b05fe39de8747e2e9@buildbot.net>

#1795: add python script slave-side command
------------------------+-------------------
Reporter:  dustin       |      Owner:
    Type:  enhancement  |     Status:  new
Priority:  major        |  Milestone:  0.8.+
 Version:  0.8.3p1      |   Keywords:
------------------------+-------------------
 Complex slave-side functionality is often written as a big 'ol master-side
 shell script, e.g.,
  https://github.com/buildbot/metabbotcfg/blob/master/builders.py

 This works pretty well for systems with a shell (although you still need
 to deal with shell portability issues), but is problematic for Windows.

 It's not particularly difficult to run Python scripts slave-side right
 now, either.  Usually you'll use a FileDownload to send the script, and
 then a ShellCommand to invoke Python.  That requires knowing with Python
 is installed, though, which varies from platform to platform.  But the
 Buildbot-slave code is running in the python interpreter and knows exactly
 what its pathname is ({{{sys.executable}}})!

 So this is proposing adding a slave-side command that can take a string
 and execute it in a freshly-spawned Python interpreter on the slave.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1795>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Feb  5 23:38:40 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 05 Feb 2011 23:38:40 -0000
Subject: [Buildbot-commits] [Buildbot] #1796: Need to support killing a
 process group without usePTY=True
Message-ID: <038.ba98010cb3a770d73f1b4472187b56af@buildbot.net>

#1796: Need to support killing a process group without usePTY=True
--------------------+--------------------
Reporter:  dustin   |      Owner:  dustin
    Type:  defect   |     Status:  new
Priority:  major    |  Milestone:  0.8.4
 Version:  0.8.3p1  |   Keywords:  kill
--------------------+--------------------
 It seems that usePTY is bad mojo, for reasons I don't understand very
 well.  There are lots of bugs (#158, #284, #198, #255) about it causing
 problems for things like 'rm -rf'.  And, let's be honest, rm doesn't need
 its own terminal.

 However, the ability to kill a whole process group when a timeout occurs
 *is* useful.  This is particularly useful when the parent process has
 already exited, and child processes are keeping pipes open, as buildslave
 cannot kill those children.

 I think the right thing to do here is to put the child processes into a
 process group even when usePTY=False.

 {{{
 17:19 <+ayust|home`> It's really straightforward, really... just in the
 main python process that manages all the other sandbox processes,
 17:19 <+ayust|home`>     # Make ourselves a process group leader
 17:19 <+ayust|home`>     os.setpgid(os.getpid(), 0)
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1796>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Feb  5 23:43:59 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 05 Feb 2011 23:43:59 -0000
Subject: [Buildbot-commits] [Buildbot] #1797: default keepStdinOpen=True
	when usePTY=True
Message-ID: <038.4b5e8863f29bb2f0b9dfed244501355f@buildbot.net>

#1797: default keepStdinOpen=True when usePTY=True
------------------------+--------------------
Reporter:  dustin       |      Owner:  dustin
    Type:  enhancement  |     Status:  new
Priority:  major        |  Milestone:  0.8.4
 Version:  0.8.3p1      |   Keywords:  kill
------------------------+--------------------
 Lots of commands don't work well with usePTY=True.  I think that *part* of
 the problem is a race condition with closing the process's stdin, which
 triggers a SIGHUP of the process.  It leads to things like

 {{{
  argv: ['rm', '-rf', 'tools']
  environment:
   CVS_RSH=ssh
 ...
   _=/home/cltbld/bin/python
  closing stdin
  using PTY: True
 process killed by signal 1
 }}}

 where "signal 1" is SIGHUP.  This has caused a lot of pain in the past -
 #158, #284, #198, #255 - and the solution has been, in general, to not use
 usePTY for things that don't actually need a terminal.

 However, it would be helpful to also not close stdin in these cases, since
 generally a terminal's stdin is not closed.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1797>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Feb  5 23:44:56 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 05 Feb 2011 23:44:56 -0000
Subject: [Buildbot-commits] [Buildbot] #1798: be more firm in adminitions to
	not use usePTY
Message-ID: <038.95005d93b446b0e5a319b29c743f2f7a@buildbot.net>

#1798: be more firm in adminitions to not use usePTY
------------------------+--------------------
Reporter:  dustin       |      Owner:  dustin
    Type:  enhancement  |     Status:  new
Priority:  major        |  Milestone:  0.8.4
 Version:  0.8.3p1      |   Keywords:  kill
------------------------+--------------------
 Once #1796 is committed, the documentation should leave users with the
 impression that usePTY=True is an oddball configuration only really useful
 for oddball things like expect scripts or password prompts.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1798>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sun Feb  6 00:45:29 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 06 Feb 2011 00:45:29 -0000
Subject: [Buildbot-commits] [Buildbot] #1797: default keepStdinOpen=True
	when usePTY=True
In-Reply-To: <038.4b5e8863f29bb2f0b9dfed244501355f@buildbot.net>
References: <038.4b5e8863f29bb2f0b9dfed244501355f@buildbot.net>
Message-ID: <053.6055da4bb74c2dcb269e2ee2f714ea6f@buildbot.net>

#1797: default keepStdinOpen=True when usePTY=True
------------------------+---------------------
Reporter:  dustin       |       Owner:  dustin
    Type:  enhancement  |      Status:  new
Priority:  major        |   Milestone:  0.8.4
 Version:  0.8.3p1      |  Resolution:
Keywords:  kill         |
------------------------+---------------------

Comment (by dustin):

 This should be easy, since the master does not supply keep_stdin_open to
 the slave *anywhere*.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1797#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sun Feb  6 08:51:23 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 06 Feb 2011 08:51:23 -0000
Subject: [Buildbot-commits] [Buildbot] #1799: Fix pipe symbol with ^
	workaround
Message-ID: <036.70f4fc784899f73c738eab2f8aaa9bdc@buildbot.net>

#1799: Fix pipe symbol with ^ workaround
--------------------+----------------------------------------
Reporter:  todd     |      Owner:
    Type:  defect   |     Status:  new
Priority:  major    |  Milestone:
 Version:  0.8.3p1  |   Keywords:  vc10, pipe, windows, shell
--------------------+----------------------------------------
 Class buildbot.steps.vstudio.VC10 can't handle config names with a pipe
 (|) in it, e.g. "Release|Win32".

 A workaround is to use buildbpt.steps.shell.ShellCommand and escape the
 pipe with a ^, e.g.:

 {{{
 ShellCommand(command=['devenv.com', 'Solution.sln', '/Build',
 'Release^|Win32'])
 }}}


 The following would *not* work, because the ^ is missing:

 {{{
 ShellCommand(command=['devenv.com', 'Solution.sln', '/Build',
 'Release|Win32'])
 }}}


 Maybe this workaround can be used to fix this bug. One simple solution
 would be to search for pipes (|) and replace them with ^|.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1799>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sun Feb  6 14:02:10 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 06 Feb 2011 14:02:10 -0000
Subject: [Buildbot-commits] [Buildbot] #1800: Automatically create
 "templates" folder with explanatory "readme.txt" on create/update mster
Message-ID: <039.c1df8e027943a49015f72fd5783fca61@buildbot.net>

#1800: Automatically create "templates" folder with explanatory "readme.txt" on
create/update mster
------------------------+-------------------
Reporter:  marcusl      |      Owner:
    Type:  enhancement  |     Status:  new
Priority:  major        |  Milestone:  0.8.+
 Version:  0.8.3p1      |   Keywords:  web
------------------------+-------------------
 See [http://comments.gmane.org/gmane.comp.python.buildbot.devel/6973 mail
 thread] for background

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1800>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sun Feb  6 14:17:05 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 06 Feb 2011 14:17:05 -0000
Subject: [Buildbot-commits] [Buildbot] #1800: Automatically create
 "templates" folder with explanatory "readme.txt" on create/update master
 (was: Automatically create "templates" folder with explanatory "readme.txt"
 on create/update mster)
In-Reply-To: <039.c1df8e027943a49015f72fd5783fca61@buildbot.net>
References: <039.c1df8e027943a49015f72fd5783fca61@buildbot.net>
Message-ID: <054.13a453a0af17b4c0f813b75bb57f465d@buildbot.net>

#1800: Automatically create "templates" folder with explanatory "readme.txt" on
create/update master
------------------------+--------------------
Reporter:  marcusl      |       Owner:
    Type:  enhancement  |      Status:  new
Priority:  major        |   Milestone:  0.8.+
 Version:  0.8.3p1      |  Resolution:
Keywords:  web          |
------------------------+--------------------

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1800#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sun Feb  6 18:45:59 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 06 Feb 2011 18:45:59 -0000
Subject: [Buildbot-commits] [Buildbot] #1801: refactor
	slave/buildslave/runprocess.py
Message-ID: <038.dbe890d09f95792c8f35a619c410e1fa@buildbot.net>

#1801: refactor slave/buildslave/runprocess.py
------------------------+-------------------
Reporter:  dustin       |      Owner:
    Type:  enhancement  |     Status:  new
Priority:  major        |  Milestone:  0.8.+
 Version:  0.8.3p1      |   Keywords:
------------------------+-------------------
 This file is massively overgrown, and contains a lot of compatibility code
 for ancient versions of Twisted.  It should be factored out into smaller
 methods and smaller modules.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1801>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sun Feb  6 18:49:23 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 06 Feb 2011 18:49:23 -0000
Subject: [Buildbot-commits] [Buildbot] #1801: refactor
	slave/buildslave/runprocess.py
In-Reply-To: <038.dbe890d09f95792c8f35a619c410e1fa@buildbot.net>
References: <038.dbe890d09f95792c8f35a619c410e1fa@buildbot.net>
Message-ID: <053.8e175c7e184b6fe5f167f4582cc8b4f8@buildbot.net>

#1801: refactor slave/buildslave/runprocess.py
------------------------+--------------------
Reporter:  dustin       |       Owner:
    Type:  enhancement  |      Status:  new
Priority:  major        |   Milestone:  0.8.+
 Version:  0.8.3p1      |  Resolution:
Keywords:  kill         |
------------------------+--------------------
Changes (by dustin):

 * keywords:   => kill


-- 
Ticket URL: <http://trac.buildbot.net/ticket/1801#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sun Feb  6 23:23:10 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 06 Feb 2011 23:23:10 -0000
Subject: [Buildbot-commits] [Buildbot] #1797: remove keepStdinOpen from
 runprocess.py (was: default keepStdinOpen=True when usePTY=True)
In-Reply-To: <038.4b5e8863f29bb2f0b9dfed244501355f@buildbot.net>
References: <038.4b5e8863f29bb2f0b9dfed244501355f@buildbot.net>
Message-ID: <053.99040f8c139c262598453c68ccaae600@buildbot.net>

#1797: remove keepStdinOpen from runprocess.py
------------------------+---------------------
Reporter:  dustin       |       Owner:  dustin
    Type:  enhancement  |      Status:  new
Priority:  major        |   Milestone:  0.8.4
 Version:  0.8.3p1      |  Resolution:
Keywords:  kill         |
------------------------+---------------------

Comment (by dustin):

 It turns out that
  * with usePTY=True, keepStdinOpen is ignored:
 http://twistedmatrix.com/trac/browser/tags/releases/twisted-10.2.0/twisted/internet/process.py#L930
  * with usePTY=False, there's never a good reason to leave stdin open - at
 least, the opportunity to do so is never used by the master or any of the
 slave-side commands.

 So I'm morphing this bug to just removing support for it.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1797#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Sun Feb  6 23:59:32 2011
From: noreply at github.com (noreply at github.com)
Date: Sun, 6 Feb 2011 15:59:32 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] 12319a: do not schedule a
	backup timeout if runprocess is ...
Message-ID: <20110206235932.1AA284234F@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 12319a700bc79da7943387510463c28eb53b9a02
    https://github.com/buildbot/buildbot/commit/12319a700bc79da7943387510463c28eb53b9a02
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-05 (Sat, 05 Feb 2011)

Changed paths:
  M slave/buildslave/runprocess.py

Log Message:
-----------
do not schedule a backup timeout if runprocess is done

This can happen when the runprocess has finished itself but kill() gets
called anyway.  It should be handled gracefully.


Commit: d2e949f1a16b5b11c85f8b43c5a1d7827ce8d0bc
    https://github.com/buildbot/buildbot/commit/d2e949f1a16b5b11c85f8b43c5a1d7827ce8d0bc
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-06 (Sun, 06 Feb 2011)

Changed paths:
  A slave/buildslave/test/unit/runprocess-scripts.py
  M slave/buildslave/test/unit/test_runprocess.py

Log Message:
-----------
Better tests for killing processes


Commit: a8a5c8ba4d98a8aba186a615109ba6b91ee3558b
    https://github.com/buildbot/buildbot/commit/a8a5c8ba4d98a8aba186a615109ba6b91ee3558b
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-06 (Sun, 06 Feb 2011)

Changed paths:
  M slave/buildslave/commands/base.py
  M slave/buildslave/commands/shell.py
  M slave/buildslave/runprocess.py
  M slave/buildslave/test/fake/runprocess.py
  M slave/buildslave/test/unit/runprocess-scripts.py
  M slave/buildslave/test/unit/test_runprocess.py

Log Message:
-----------
Remove unused keepStdinOpen option

This option is never passed from the master, and has defaulted to False
(meaning that stdin gets closed).  Upon investigation of Twisted, the
pp.closeStdin method only has an effect when usePTY=True:

  http://twistedmatrix.com/trac/browser/tags/releases/twisted-10.2.0/twisted/internet/process.py#L930

So with this patch, stdin is always closed, potentially after writing
the required input.  Tests verify this.

Fixes #1797


Commit: 8ab6e28691b9b3b2fa9734e1dd1780e8381b3373
    https://github.com/buildbot/buildbot/commit/8ab6e28691b9b3b2fa9734e1dd1780e8381b3373
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-06 (Sun, 06 Feb 2011)

Changed paths:
  M slave/buildslave/runprocess.py
  M slave/buildslave/test/unit/test_runprocess.py

Log Message:
-----------
Kill entire process groups

This is technically configurable, but the option is not currently
exposed to users - that can be added later, if it becomes necessary.

Fixes #1796


Commit: 1d3d8f7655b175932d476b2b728885725ed37b47
    https://github.com/buildbot/buildbot/commit/1d3d8f7655b175932d476b2b728885725ed37b47
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-06 (Sun, 06 Feb 2011)

Changed paths:
  M master/docs/cfg-buildsteps.texinfo
  M slave/NEWS

Log Message:
-----------
Be more stern in advising against usePTY

Fixes #1798.





From nobody at buildbot.net  Sun Feb  6 23:59:41 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 06 Feb 2011 23:59:41 -0000
Subject: [Buildbot-commits] [Buildbot] #1797: remove keepStdinOpen from
	runprocess.py
In-Reply-To: <038.4b5e8863f29bb2f0b9dfed244501355f@buildbot.net>
References: <038.4b5e8863f29bb2f0b9dfed244501355f@buildbot.net>
Message-ID: <053.29d0f30fe61fa95f8ae97c3504b3aab7@buildbot.net>

#1797: remove keepStdinOpen from runprocess.py
------------------------+---------------------
Reporter:  dustin       |       Owner:  dustin
    Type:  enhancement  |      Status:  closed
Priority:  major        |   Milestone:  0.8.4
 Version:  0.8.3p1      |  Resolution:  fixed
Keywords:  kill         |
------------------------+---------------------
Changes (by Dustin J. Mitchell):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Remove unused keepStdinOpen option

 This option is never passed from the master, and has defaulted to False
 (meaning that stdin gets closed).  Upon investigation of Twisted, the
 pp.closeStdin method only has an effect when usePTY=True:

 http://twistedmatrix.com/trac/browser/tags/releases/twisted-10.2.0/twisted/internet/process.py#L930

 So with this patch, stdin is always closed, potentially after writing
 the required input.  Tests verify this.

 Fixes #1797
  Changeset: a8a5c8ba4d98a8aba186a615109ba6b91ee3558b

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1797#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sun Feb  6 23:59:43 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 06 Feb 2011 23:59:43 -0000
Subject: [Buildbot-commits] [Buildbot] #1798: be more firm in
	adminitions to not use usePTY
In-Reply-To: <038.95005d93b446b0e5a319b29c743f2f7a@buildbot.net>
References: <038.95005d93b446b0e5a319b29c743f2f7a@buildbot.net>
Message-ID: <053.044aac5365ec3e3b5e054077a6619c86@buildbot.net>

#1798: be more firm in adminitions to not use usePTY
------------------------+---------------------
Reporter:  dustin       |       Owner:  dustin
    Type:  enhancement  |      Status:  closed
Priority:  major        |   Milestone:  0.8.4
 Version:  0.8.3p1      |  Resolution:  fixed
Keywords:  kill         |
------------------------+---------------------
Changes (by Dustin J. Mitchell):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Be more stern in advising against usePTY

 Fixes #1798.
  Changeset: 1d3d8f7655b175932d476b2b728885725ed37b47

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1798#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sun Feb  6 23:59:42 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 06 Feb 2011 23:59:42 -0000
Subject: [Buildbot-commits] [Buildbot] #1796: Need to support killing a
 process group without usePTY=True
In-Reply-To: <038.ba98010cb3a770d73f1b4472187b56af@buildbot.net>
References: <038.ba98010cb3a770d73f1b4472187b56af@buildbot.net>
Message-ID: <053.592a4da15d07bea9b7d991d7b712629c@buildbot.net>

#1796: Need to support killing a process group without usePTY=True
--------------------+---------------------
Reporter:  dustin   |       Owner:  dustin
    Type:  defect   |      Status:  closed
Priority:  major    |   Milestone:  0.8.4
 Version:  0.8.3p1  |  Resolution:  fixed
Keywords:  kill     |
--------------------+---------------------
Changes (by Dustin J. Mitchell):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Kill entire process groups

 This is technically configurable, but the option is not currently
 exposed to users - that can be added later, if it becomes necessary.

 Fixes #1796
  Changeset: 8ab6e28691b9b3b2fa9734e1dd1780e8381b3373

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1796#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Mon Feb  7 00:11:00 2011
From: noreply at github.com (noreply at github.com)
Date: Sun, 6 Feb 2011 16:11:00 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] 98458b: don't run
	test_stdin_closed on windows
Message-ID: <20110207001100.6970D42308@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 98458b529d49e0a3265e207cbe8ceaf406e91eea
    https://github.com/buildbot/buildbot/commit/98458b529d49e0a3265e207cbe8ceaf406e91eea
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-06 (Sun, 06 Feb 2011)

Changed paths:
  M slave/buildslave/test/unit/test_runprocess.py

Log Message:
-----------
don't run test_stdin_closed on windows





From noreply at github.com  Mon Feb  7 02:45:17 2011
From: noreply at github.com (noreply at github.com)
Date: Sun, 6 Feb 2011 18:45:17 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] e15751: misc fixes
Message-ID: <20110207024517.00C354224E@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: e15751c301cff0ada7bd116449012c17d633ba09
    https://github.com/buildbot/buildbot/commit/e15751c301cff0ada7bd116449012c17d633ba09
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-06 (Sun, 06 Feb 2011)

Changed paths:
  M slave/buildslave/runprocess.py
  M slave/buildslave/test/unit/test_runprocess.py

Log Message:
-----------
misc fixes

* always use a timeout for assertDead
* don't try to kill a pgid if none is known (indentation error)
* only set process.pgid in connectionMade





From noreply at github.com  Mon Feb  7 02:53:07 2011
From: noreply at github.com (noreply at github.com)
Date: Sun, 6 Feb 2011 18:53:07 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] 464f9e: add a decorator for
	tests that use flushLoggedErro...
Message-ID: <20110207025307.2B9DB420CF@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 464f9e60a943cb21be0bda3322b5170037d11ae1
    https://github.com/buildbot/buildbot/commit/464f9e60a943cb21be0bda3322b5170037d11ae1
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-06 (Sun, 06 Feb 2011)

Changed paths:
  M master/buildbot/test/unit/test_changes_svnpoller.py
  M master/buildbot/test/unit/test_util_subscriptions.py
  A master/buildbot/test/util/compat.py
  M slave/buildslave/test/unit/test_runprocess.py
  A slave/buildslave/test/util/compat.py

Log Message:
-----------
add a decorator for tests that use flushLoggedErrors

Such tests will not run on certain combinations of Python and Twisted; a
decorator is a much more succinct way to represent this in the test
code.





From nobody at buildbot.net  Mon Feb  7 04:15:31 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 07 Feb 2011 04:15:31 -0000
Subject: [Buildbot-commits] [Buildbot] #1802: send SIGTERM before SIGKILL
Message-ID: <038.512ed97667fb96d4260afa3530716da1@buildbot.net>

#1802: send SIGTERM before SIGKILL
------------------------+-------------------
Reporter:  dustin       |      Owner:
    Type:  enhancement  |     Status:  new
Priority:  major        |  Milestone:  0.8.+
 Version:  0.8.3p1      |   Keywords:  kill
------------------------+-------------------
 Buildbot should kill child processes by first sending SIGTERM, then
 waiting a bit before sending SIGKILL.  This will give processes some time
 to shut down cleanly, if necessary.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1802>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Mon Feb  7 16:54:54 2011
From: noreply at github.com (noreply at github.com)
Date: Mon, 7 Feb 2011 08:54:54 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] c3a6a0: Make the docs
	clearer for running buildbot tests
Message-ID: <20110207165454.68F2942306@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: c3a6a0d0acc92e99b4e5dd06bfccacba6488e432
    https://github.com/buildbot/buildbot/commit/c3a6a0d0acc92e99b4e5dd06bfccacba6488e432
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-07 (Mon, 07 Feb 2011)

Changed paths:
  M master/docs/cfg-buildslaves.texinfo
  M master/docs/installation.texinfo

Log Message:
-----------
Make the docs clearer for running buildbot tests

In particular, emphasize that 'mock' is required, and that running the
tests is optional anyway.





From nobody at buildbot.net  Mon Feb  7 17:46:18 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 07 Feb 2011 17:46:18 -0000
Subject: [Buildbot-commits] [Buildbot] #1768: MailNotifier emails sent
	with base64 encoding
In-Reply-To: <039.a3c5ed7b7703fddacb868504fd6c9228@buildbot.net>
References: <039.a3c5ed7b7703fddacb868504fd6c9228@buildbot.net>
Message-ID: <054.bfe962a2328eba4a52a1e8fd982a8eb6@buildbot.net>

#1768: MailNotifier emails sent with base64 encoding
--------------------+--------------------
Reporter:  cortana  |       Owner:
    Type:  defect   |      Status:  new
Priority:  trivial  |   Milestone:  0.8.+
 Version:  0.8.3p1  |  Resolution:
Keywords:  mail     |
--------------------+--------------------

Comment (by cortana):

 If you're using the python `email` module, I think the following will
 work:

 {{{
 from email import Charset
 Charset.add_charset('utf-8', Charset.SHORTEST, Charset.QP, 'utf-8')
 }}}

 or, if you want 8-bit rather than quoted-printable (slightly less
 conservative):

 {{{
 Charset.add_charset('utf-8', Charset.SHORTEST, None, 'utf-8')
 }}}

 ref: http://code.djangoproject.com/ticket/3472 and
 http://code.djangoproject.com/ticket/11212

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1768#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Tue Feb  8 04:15:10 2011
From: noreply at github.com (noreply at github.com)
Date: Mon, 7 Feb 2011 20:15:10 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] 0633ed: use log.msg instead
	of print, for friendliness to ...
Message-ID: <20110208041510.A21EE422B9@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 0633ed3704fab575ccc9ba50146fa73a2a0f29b7
    https://github.com/buildbot/buildbot/commit/0633ed3704fab575ccc9ba50146fa73a2a0f29b7
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-07 (Mon, 07 Feb 2011)

Changed paths:
  M master/buildbot/util/loop.py

Log Message:
-----------
use log.msg instead of print, for friendliness to tests


Commit: d54f801512dea6c7022e138bd914b44a9ea27ff2
    https://github.com/buildbot/buildbot/commit/d54f801512dea6c7022e138bd914b44a9ea27ff2
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-07 (Mon, 07 Feb 2011)

Changed paths:
  M master/buildbot/util/subscription.py

Log Message:
-----------
docstring fixes


Commit: 44608269787a30467e4fe8edb4645095ff5aa822
    https://github.com/buildbot/buildbot/commit/44608269787a30467e4fe8edb4645095ff5aa822
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-07 (Mon, 07 Feb 2011)

Changed paths:
  M master/buildbot/util/maildir.py

Log Message:
-----------
remove confusing default implementation of messageReceived





From noreply at github.com  Tue Feb  8 05:35:05 2011
From: noreply at github.com (noreply at github.com)
Date: Mon, 7 Feb 2011 21:35:05 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] 8ce54f: Merge branch
	'postgres-fixes' of git://github.com/...
Message-ID: <20110208053505.D04EE42365@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 8ce54f6965ad0ca0eca103082234a674c959f0aa
    https://github.com/buildbot/buildbot/commit/8ce54f6965ad0ca0eca103082234a674c959f0aa
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-07 (Mon, 07 Feb 2011)

Changed paths:
  M master/buildbot/db/connector.py
  M master/buildbot/db/migrate/versions/001_initial.py
  M master/buildbot/db/migrate/versions/004_add_autoincrement.py
  M master/buildbot/db/migrate/versions/005_add_indexes.py
  M master/buildbot/db/model.py

Log Message:
-----------
Merge branch 'postgres-fixes' of git://github.com/PiotrSikora/buildbot

* 'postgres-fixes' of git://github.com/PiotrSikora/buildbot:
  Fix typo.
  Some more PostgreSQL-love, this time for run-time queries.
  Cleaner SQL dialect comparison.
  Work-around SQLAlchemy issue when migrating to SERIAL data type.
  "BLOB" is invalid type, use "LargeBinary" instead.
  Don't use "NULL" as the server default.


Commit: cf8c078a106520afd44f3a98aa62e8702a4c6e7d
    https://github.com/buildbot/buildbot/commit/cf8c078a106520afd44f3a98aa62e8702a4c6e7d
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-07 (Mon, 07 Feb 2011)

Changed paths:
  M master/buildbot/db/connector.py

Log Message:
-----------
restore 'TODO: remove' tags in connector.py


Commit: a3a3c3f625a63edadfa5d807e47a2e5bac94fb6f
    https://github.com/buildbot/buildbot/commit/a3a3c3f625a63edadfa5d807e47a2e5bac94fb6f
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-07 (Mon, 07 Feb 2011)

Changed paths:
  M master/buildbot/db/migrate/versions/005_add_indexes.py
  M master/buildbot/db/model.py

Log Message:
-----------
adjust comments about server_defaults





From nobody at buildbot.net  Tue Feb  8 06:12:08 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 08 Feb 2011 06:12:08 -0000
Subject: [Buildbot-commits] [Buildbot] #1780: Latent build slaves shut
 down uncleanly and get forgotten by the master
In-Reply-To: <040.ea5c2cbbd82d21ecc7d22b950b6307bf@buildbot.net>
References: <040.ea5c2cbbd82d21ecc7d22b950b6307bf@buildbot.net>
Message-ID: <055.bb7470c3cf13a8f10e42dc9b8f29eaac@buildbot.net>

#1780: Latent build slaves shut down uncleanly and get forgotten by the master
---------------------------+--------------------
Reporter:  jacobian        |       Owner:
    Type:  defect          |      Status:  new
Priority:  major           |   Milestone:  0.8.4
 Version:  0.8.3p1         |  Resolution:
Keywords:  virtualization  |
---------------------------+--------------------
Changes (by dustin):

 * keywords:   => virtualization
 * milestone:  undecided => 0.8.4


Comment:

 I suspect that the right solution is to use the graceful shutdown
 functionality to shut down the slave permanently, rather than just
 disconnecting it.

 Do you want to code this up and test it out?

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1780#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Feb  8 06:18:18 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 08 Feb 2011 06:18:18 -0000
Subject: [Buildbot-commits] [Buildbot] #1794: UI for displaying test
	results
In-Reply-To: <041.e541d58ea8c1293e93ea80873861e229@buildbot.net>
References: <041.e541d58ea8c1293e93ea80873861e229@buildbot.net>
Message-ID: <056.e07db3f2b3d44f577f3697f0e3b7cd29@buildbot.net>

#1794: UI for displaying test results
------------------------+------------------------
Reporter:  liucougar    |       Owner:  liucougar
    Type:  enhancement  |      Status:  new
Priority:  major        |   Milestone:  0.8.+
 Version:  0.8.3p1      |  Resolution:
Keywords:  web          |
------------------------+------------------------
Changes (by dustin):

 * keywords:   => web
 * type:  task => enhancement
 * milestone:  undecided => 0.8.+


-- 
Ticket URL: <http://trac.buildbot.net/ticket/1794#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Tue Feb  8 07:10:13 2011
From: noreply at github.com (noreply at github.com)
Date: Mon, 7 Feb 2011 23:10:13 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] bec473: add mention of MSys
	Git minimum version
Message-ID: <20110208071013.B165A42328@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: bec4737c28a7fc5f9bc61633d3ffb5bbd1a58f5f
    https://github.com/buildbot/buildbot/commit/bec4737c28a7fc5f9bc61633d3ffb5bbd1a58f5f
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-07 (Mon, 07 Feb 2011)

Changed paths:
  M master/docs/installation.texinfo

Log Message:
-----------
add mention of MSys Git minimum version


Commit: a924f9db43ab2fa92cc9f3f4f577fd50d61c48da
    https://github.com/buildbot/buildbot/commit/a924f9db43ab2fa92cc9f3f4f577fd50d61c48da
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-07 (Mon, 07 Feb 2011)

Changed paths:
  M master/docs/cfg-statustargets.texinfo

Log Message:
-----------
Add docs regarding TLSRequiredError

Refs #1786


Commit: 51c9433f0b79e7c3f785392ab7eb13167d6a37cc
    https://github.com/buildbot/buildbot/commit/51c9433f0b79e7c3f785392ab7eb13167d6a37cc
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-07 (Mon, 07 Feb 2011)

Changed paths:
  M master/docs/cfg-global.texinfo

Log Message:
-----------
add a note about trailing slash on URLs

Thanks to Fulvio Cervone for the suggestion.





From nobody at buildbot.net  Tue Feb  8 07:10:23 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 08 Feb 2011 07:10:23 -0000
Subject: [Buildbot-commits] [Buildbot] #1786: master fails to send mail
	with TLS on windows
In-Reply-To: <041.17c065ce0b4b102fac9a5d0fd4a17072@buildbot.net>
References: <041.17c065ce0b4b102fac9a5d0fd4a17072@buildbot.net>
Message-ID: <056.a5a80add6c905396c2210403b2cd3e46@buildbot.net>

#1786: master fails to send mail with TLS on windows
----------------------+------------------------
Reporter:  philippem  |       Owner:
    Type:  defect     |      Status:  closed
Priority:  major      |   Milestone:  undecided
 Version:  0.8.3p1    |  Resolution:  invalid
Keywords:  windows    |
----------------------+------------------------

Comment (by Dustin J. Mitchell):

 Add docs regarding TLSRequiredError

 Refs #1786
  Changeset: a924f9db43ab2fa92cc9f3f4f577fd50d61c48da

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1786#comment:9>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Feb  8 07:13:00 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 08 Feb 2011 07:13:00 -0000
Subject: [Buildbot-commits] [Buildbot] #1768: MailNotifier emails sent
	with base64 encoding
In-Reply-To: <039.a3c5ed7b7703fddacb868504fd6c9228@buildbot.net>
References: <039.a3c5ed7b7703fddacb868504fd6c9228@buildbot.net>
Message-ID: <054.58b0b8a0bc76ccabf9826936090a33c7@buildbot.net>

#1768: MailNotifier emails sent with base64 encoding
--------------------+--------------------
Reporter:  cortana  |       Owner:
    Type:  defect   |      Status:  new
Priority:  trivial  |   Milestone:  0.8.4
 Version:  0.8.3p1  |  Resolution:
Keywords:  mail     |
--------------------+--------------------
Changes (by dustin):

 * milestone:  0.8.+ => 0.8.4


Comment:

 Sounds good.  Let's see if someone (maybe me) can find time to make this
 into a patch before 0.8.4.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1768#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Feb  8 15:11:10 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 08 Feb 2011 15:11:10 -0000
Subject: [Buildbot-commits] [Buildbot] #1780: Latent build slaves shut
 down uncleanly and get forgotten by the master
In-Reply-To: <040.ea5c2cbbd82d21ecc7d22b950b6307bf@buildbot.net>
References: <040.ea5c2cbbd82d21ecc7d22b950b6307bf@buildbot.net>
Message-ID: <055.63ceece75fc2b7a9487043c4f933ea6d@buildbot.net>

#1780: Latent build slaves shut down uncleanly and get forgotten by the master
---------------------------+--------------------
Reporter:  jacobian        |       Owner:
    Type:  defect          |      Status:  new
Priority:  major           |   Milestone:  0.8.4
 Version:  0.8.3p1         |  Resolution:
Keywords:  virtualization  |
---------------------------+--------------------

Comment (by jacobian):

 I'm very much a newbie to the Buildbot source, but I'll give it a shot if
 I can figure it out. Can you point me in the right direction toward the
 API/module I'd be using to issue the graceful shutdown?

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1780#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Feb  8 20:35:37 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 08 Feb 2011 20:35:37 -0000
Subject: [Buildbot-commits] [Buildbot] #1803: gitpoller failure when workdir
 has no parent directory
Message-ID: <037.fc2e7ebeea7a896b05f0d492580a0a9e@buildbot.net>

#1803: gitpoller failure when workdir has no parent directory
----------------------+-----------------------
Reporter:  anton      |      Owner:
    Type:  undecided  |     Status:  new
Priority:  major      |  Milestone:  undecided
 Version:  0.8.3p1    |   Keywords:
----------------------+-----------------------
 My gitpoller config contains:

         workdir='gitpoller-project',

 Which causes the following error:


 {{{
 2011-02-08 04:38:30-0600 [-] gitpoller: creating parent directories for
 workdir
 2011-02-08 04:38:30-0600 [-] Unhandled Error
         Traceback (most recent call last):
           File "/usr/lib/python2.6/site-
 packages/buildbot-0.8.3p1-py2.6.egg/buildbot/master.py", line 1041, in
 <lambda>
             d.addCallback(lambda res:
 self.loadConfig_Sources(change_sources))
           File "/usr/lib/python2.6/site-
 packages/buildbot-0.8.3p1-py2.6.egg/buildbot/master.py", line 1125, in
 loadConfig_Sources
             d.addCallback(addNewOnes)
           File "/usr/lib/python2.6/site-packages/Twisted-10.2.0-py2.6
 -linux-ppc64.egg/twisted/internet/defer.py", line 297, in addCallback
             callbackKeywords=kw)
           File "/usr/lib/python2.6/site-packages/Twisted-10.2.0-py2.6
 -linux-ppc64.egg/twisted/internet/defer.py", line 286, in addCallbacks
             self._runCallbacks()
         --- <exception caught here> ---
           File "/usr/lib/python2.6/site-packages/Twisted-10.2.0-py2.6
 -linux-ppc64.egg/twisted/internet/defer.py", line 542, in _runCallbacks
             current.result = callback(current.result, *args, **kw)
           File "/usr/lib/python2.6/site-
 packages/buildbot-0.8.3p1-py2.6.egg/buildbot/master.py", line 1123, in
 addNewOnes
             [self.change_svc.addSource(s) for s in added_sources]
           File "/usr/lib/python2.6/site-
 packages/buildbot-0.8.3p1-py2.6.egg/buildbot/changes/manager.py", line 70,
 in addSource
             source.setServiceParent(self)
           File "/usr/lib/python2.6/site-packages/Twisted-10.2.0-py2.6
 -linux-ppc64.egg/twisted/application/service.py", line 184, in
 setServiceParent
             self.parent.addService(self)
           File "/usr/lib/python2.6/site-packages/Twisted-10.2.0-py2.6
 -linux-ppc64.egg/twisted/application/service.py", line 304, in addService
             service.startService()
           File "/usr/lib/python2.6/site-
 packages/buildbot-0.8.3p1-py2.6.egg/buildbot/changes/gitpoller.py", line
 66, in startService
             os.makedirs(dirpath)
           File "/usr/lib64/python2.6/os.py", line 157, in makedirs
             mkdir(name, mode)
         exceptions.OSError: [Errno 2] No such file or directory: ''

 }}}

 Patch to follow.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1803>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Feb  8 20:41:17 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 08 Feb 2011 20:41:17 -0000
Subject: [Buildbot-commits] [Buildbot] #1780: Latent build slaves shut
 down uncleanly and get forgotten by the master
In-Reply-To: <040.ea5c2cbbd82d21ecc7d22b950b6307bf@buildbot.net>
References: <040.ea5c2cbbd82d21ecc7d22b950b6307bf@buildbot.net>
Message-ID: <055.7fc1ad96719490a0e44a0aa6c44454df@buildbot.net>

#1780: Latent build slaves shut down uncleanly and get forgotten by the master
---------------------------+--------------------
Reporter:  jacobian        |       Owner:
    Type:  defect          |      Status:  new
Priority:  major           |   Milestone:  0.8.4
 Version:  0.8.3p1         |  Resolution:
Keywords:  virtualization  |
---------------------------+--------------------

Comment (by dustin):

 See [source:master/buildbot/buildslave.py], particularly the 'shutdown'
 method.  You can call this to cause the buildslave process on the slave to
 exit - then, even if the system shutdown takes a while, the slave will not
 accidentally reconnect (well, assuming that the system isn't running some
 automatically-restart-dead-buildslaves monitoring script).

 Hopefully that helps?

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1780#comment:4>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Tue Feb  8 20:57:17 2011
From: noreply at github.com (noreply at github.com)
Date: Tue, 8 Feb 2011 12:57:17 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] 7175a0: try the old way of
	shutting down slaves, too
Message-ID: <20110208205717.D3E144233C@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 7175a0db346ea63f2ea837a63d5431b65f0bd49b
    https://github.com/buildbot/buildbot/commit/7175a0db346ea63f2ea837a63d5431b65f0bd49b
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-08 (Tue, 08 Feb 2011)

Changed paths:
  M master/buildbot/buildslave.py

Log Message:
-----------
try the old way of shutting down slaves, too

This was (presumably accidentally?) commented out in
74f27204e2e632752d97c7dedc6079e21b87e230.  Refs #429.





From nobody at buildbot.net  Tue Feb  8 20:57:25 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 08 Feb 2011 20:57:25 -0000
Subject: [Buildbot-commits] [Buildbot] #429: Slave shutdown cleanup
In-Reply-To: <038.241f0534008b5d2ecf022bdeeacb9ea1@buildbot.net>
References: <038.241f0534008b5d2ecf022bdeeacb9ea1@buildbot.net>
Message-ID: <053.58fe9f6387f66b7aecc6b28396953478@buildbot.net>

#429: Slave shutdown cleanup
-------------------+---------------------
Reporter:  catlee  |       Owner:
    Type:  defect  |      Status:  closed
Priority:  minor   |   Milestone:  0.8.3
 Version:  0.7.9   |  Resolution:  fixed
Keywords:          |
-------------------+---------------------

Comment (by Dustin J. Mitchell):

 try the old way of shutting down slaves, too

 This was (presumably accidentally?) commented out in
 74f27204e2e632752d97c7dedc6079e21b87e230.  Refs #429.
  Changeset: 7175a0db346ea63f2ea837a63d5431b65f0bd49b

-- 
Ticket URL: <http://trac.buildbot.net/ticket/429#comment:5>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Feb  8 20:59:51 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 08 Feb 2011 20:59:51 -0000
Subject: [Buildbot-commits] [Buildbot] #1803: gitpoller failure when
 workdir has no parent directory
In-Reply-To: <037.fc2e7ebeea7a896b05f0d492580a0a9e@buildbot.net>
References: <037.fc2e7ebeea7a896b05f0d492580a0a9e@buildbot.net>
Message-ID: <052.93eba8acef3523fab1c5c6d4d815b437@buildbot.net>

#1803: gitpoller failure when workdir has no parent directory
--------------------+--------------------
Reporter:  anton    |       Owner:
    Type:  defect   |      Status:  new
Priority:  major    |   Milestone:  0.8.4
 Version:  0.8.3p1  |  Resolution:
Keywords:  git      |
--------------------+--------------------
Changes (by dustin):

 * keywords:   => git
 * type:  undecided => defect
 * milestone:  undecided => 0.8.4


Comment:

 There's an (IMHO) better fix in 8906f8838a2ac61d5874e66fa35811bc981fa355,
 which hasn't been released yet.  It makes the workdir absolute as soon as
 it has a basedir.  What do you think?

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1803#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Feb  8 21:12:32 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 08 Feb 2011 21:12:32 -0000
Subject: [Buildbot-commits] [Buildbot] #1803: gitpoller failure when
 workdir has no parent directory
In-Reply-To: <037.fc2e7ebeea7a896b05f0d492580a0a9e@buildbot.net>
References: <037.fc2e7ebeea7a896b05f0d492580a0a9e@buildbot.net>
Message-ID: <052.329d1a0018b9e78f960fe217d7963377@buildbot.net>

#1803: gitpoller failure when workdir has no parent directory
--------------------+--------------------
Reporter:  anton    |       Owner:
    Type:  defect   |      Status:  new
Priority:  major    |   Milestone:  0.8.4
 Version:  0.8.3p1  |  Resolution:
Keywords:  git      |
--------------------+--------------------

Comment (by anton):

 Hi Dustin, that patch seems fine, I'll pull it in and test here. Thanks.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1803#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Feb  9 00:00:19 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 09 Feb 2011 00:00:19 -0000
Subject: [Buildbot-commits] [Buildbot] #1803: gitpoller failure when
 workdir has no parent directory
In-Reply-To: <037.fc2e7ebeea7a896b05f0d492580a0a9e@buildbot.net>
References: <037.fc2e7ebeea7a896b05f0d492580a0a9e@buildbot.net>
Message-ID: <052.55931e9a83029749c76d2ae2bef7db92@buildbot.net>

#1803: gitpoller failure when workdir has no parent directory
--------------------+---------------------
Reporter:  anton    |       Owner:
    Type:  defect   |      Status:  closed
Priority:  major    |   Milestone:  0.8.4
 Version:  0.8.3p1  |  Resolution:  fixed
Keywords:  git      |
--------------------+---------------------
Changes (by dustin):

 * status:  new => closed
 * resolution:   => fixed


-- 
Ticket URL: <http://trac.buildbot.net/ticket/1803#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Wed Feb  9 15:59:50 2011
From: noreply at github.com (noreply at github.com)
Date: Wed, 9 Feb 2011 07:59:50 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] 8194ae: update reference to
	Waterfall object
Message-ID: <20110209155950.C90EB422F1@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 8194aef3712901f6859ae18ceba800e63ee74d4f
    https://github.com/buildbot/buildbot/commit/8194aef3712901f6859ae18ceba800e63ee74d4f
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-09 (Wed, 09 Feb 2011)

Changed paths:
  M master/docs/cfg-global.texinfo

Log Message:
-----------
update reference to Waterfall object





From nobody at buildbot.net  Thu Feb 10 21:29:49 2011
From: nobody at buildbot.net (Buildbot)
Date: Thu, 10 Feb 2011 21:29:49 -0000
Subject: [Buildbot-commits] [Buildbot] #1749: xp slave fails to kill
 child process after network disconnect
In-Reply-To: <041.0ba5760290cca1b300b9ab289147eda3@buildbot.net>
References: <041.0ba5760290cca1b300b9ab289147eda3@buildbot.net>
Message-ID: <056.2937298b64f19130b840c9a02c2501c6@buildbot.net>

#1749: xp slave fails to kill child process after network disconnect
--------------------------+--------------------
Reporter:  philippem      |       Owner:
    Type:  defect         |      Status:  new
Priority:  critical       |   Milestone:  0.8.+
 Version:  0.8.3          |  Resolution:
Keywords:  windows, kill  |
--------------------------+--------------------

Comment (by philippem):

 this fix seems to be working well for me.
 I'm not 100% sure of the "dummy kill" behaviour, I did not test it, and I
 don't really understand how the timer works. Also, it runs "if it's not
 posix" which is Windows and maybe other platforms too. (BeOs? VMS?
 OS/360?)

 {{{
 c:\Python27\Lib\site-
 packages\buildbot_slave-0.8.3-py2.7.egg\buildslave>diff -c runprocess.py~
 runprocess.py
 diff -c runprocess.py~ runprocess.py
 *** runprocess.py~      Mon Jan 17 10:01:49 2011
 --- runprocess.py       Fri Feb 04 20:51:50 2011
 ***************
 *** 753,758 ****
 --- 753,767 ----
                   # probably no-such-process, maybe because there is no
 process
                   # group
                   pass
 +         else:
 +             # windows?
 +             if self.KILL == None:
 +                 log.msg("self.KILL==None, only pretending to kill
 child")
 +             else:
 +                 os.system("TASKKILL /F /PID %s /T" % self.process.pid)
 +                 log.msg("used TASKKILL /F PID /T to kill pid %s" %
 self.process.pid)
 +                 hit = 1
 +
           if not hit:
               try:
                   if self.KILL is None:
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1749#comment:19>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Thu Feb 10 23:38:47 2011
From: noreply at github.com (noreply at github.com)
Date: Thu, 10 Feb 2011 15:38:47 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] ac07b5: Use taskkill to kill
	windows procs
Message-ID: <20110210233847.4E325423F3@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: ac07b5d2678ef2d1fd7fc23b2777faf5072c9852
    https://github.com/buildbot/buildbot/commit/ac07b5d2678ef2d1fd7fc23b2777faf5072c9852
Author: Amber Yust <ayust at yelp.com>
Date:   2011-02-10 (Thu, 10 Feb 2011)

Changed paths:
  M slave/buildslave/runprocess.py

Log Message:
-----------
Use taskkill to kill windows procs





From nobody at buildbot.net  Thu Feb 10 23:39:39 2011
From: nobody at buildbot.net (Buildbot)
Date: Thu, 10 Feb 2011 23:39:39 -0000
Subject: [Buildbot-commits] [Buildbot] #1749: xp slave fails to kill
 child process after network disconnect
In-Reply-To: <041.0ba5760290cca1b300b9ab289147eda3@buildbot.net>
References: <041.0ba5760290cca1b300b9ab289147eda3@buildbot.net>
Message-ID: <056.d97663b7c5e2228c5f424c9c9d6b48c2@buildbot.net>

#1749: xp slave fails to kill child process after network disconnect
--------------------------+---------------------
Reporter:  philippem      |       Owner:
    Type:  defect         |      Status:  closed
Priority:  critical       |   Milestone:  0.8.+
 Version:  0.8.3          |  Resolution:  fixed
Keywords:  windows, kill  |
--------------------------+---------------------
Changes (by ayust):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 https://github.com/buildbot/buildbot/commit/ac07b5d2678ef2d1fd7fc23b2777faf5072c9852

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1749#comment:20>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Feb 11 11:42:38 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 11 Feb 2011 11:42:38 -0000
Subject: [Buildbot-commits] [Buildbot] #1804: DirectoryUpload does not raise
 an error if it can't copy all the files
Message-ID: <039.4c8f26f7950601795b47b896a9c35b3a@buildbot.net>

#1804: DirectoryUpload does not raise an error if it can't copy all the files
--------------------+-----------------------
Reporter:  cortana  |      Owner:
    Type:  defect   |     Status:  new
Priority:  minor    |  Milestone:  undecided
 Version:  0.8.2    |   Keywords:
--------------------+-----------------------
 Since !DirectoryUpload gained !WithProperties support, I switched my
 upload buildstep from being a !ShellCommand that ran rsync to a
 !DirectoryUpload.

 I've noticed that when the destination filesystem doesn't have enough
 room, the !DirectoryUpload build step does not fail. Instead it skips the
 files it can't copy and succeeds, silently.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1804>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Feb 12 18:35:23 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 12 Feb 2011 18:35:23 -0000
Subject: [Buildbot-commits] [Buildbot] #1805: build end_time can become
	"True"
Message-ID: <039.2931abac5224cf52776522f9443597c0@buildbot.net>

#1805: build end_time can become "True"
----------------------+-----------------------
Reporter:  ddunbar    |      Owner:
    Type:  undecided  |     Status:  new
Priority:  major      |  Milestone:  undecided
 Version:  0.8.3p1    |   Keywords:
----------------------+-----------------------
 In buildbot 0.8.3p1, there appear to be a possible sequence of events in
 which a build's end_time can become the value "True", which is not a legal
 time.

 Here is an example taken from a builder page:
 --

 Timing:

 Start   Sat Feb 12 10:15:41 2011
 End     Wed Dec 31 16:00:01 1969
 Elapsed -1297534540 secs
 --

 And if I look at the JSON API output I see:
 --

   "times": [
     1297534541.848984,
     true
   ]
 --

 At this point, I don't know the exact sequence of events which reproduces
 this issue, but I have seen it multiple times.

 I believe it tends to happen when there is some sort of slave disconnect
 event.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1805>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sun Feb 13 02:02:42 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 13 Feb 2011 02:02:42 -0000
Subject: [Buildbot-commits] [Buildbot] #1805: build end_time can become
	"True"
In-Reply-To: <039.2931abac5224cf52776522f9443597c0@buildbot.net>
References: <039.2931abac5224cf52776522f9443597c0@buildbot.net>
Message-ID: <054.76d73df0ae8bb52abb027f4276d52060@buildbot.net>

#1805: build end_time can become "True"
----------------------+------------------------
Reporter:  ddunbar    |       Owner:
    Type:  undecided  |      Status:  new
Priority:  major      |   Milestone:  undecided
 Version:  0.8.3p1    |  Resolution:
Keywords:             |
----------------------+------------------------

Comment (by dustin):

 Can you attach the build pickle, too?  Or send it to ayust and I if it's
 sensitive?

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1805#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sun Feb 13 02:37:55 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 13 Feb 2011 02:37:55 -0000
Subject: [Buildbot-commits] [Buildbot] #1806: ircbot doesn't rejoin
Message-ID: <035.b36ea871adb92b51419b18fcd78d503d@buildbot.net>

#1806: ircbot doesn't rejoin
----------------------+-----------------------
Reporter:  gg0        |      Owner:
    Type:  undecided  |     Status:  new
Priority:  major      |  Milestone:  undecided
 Version:  0.8.3      |   Keywords:
----------------------+-----------------------
 <gg0> hi
 <gg0> if ircbot leaves due to network timeout, it won't rejoin until
 master restart. known issue? should I file a bug?
 <xxxxxx> there may be a bug for it already
 <yyyyyy> yeah probably it's been known for a long time
 <xxxxxx> gg0: file a bug and let someone mark it as duplicate later :P

 http://www.gnashdev.org:8010/about

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1806>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sun Feb 13 18:44:10 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 13 Feb 2011 18:44:10 -0000
Subject: [Buildbot-commits] [Buildbot] #1806: ircbot doesn't rejoin
In-Reply-To: <035.b36ea871adb92b51419b18fcd78d503d@buildbot.net>
References: <035.b36ea871adb92b51419b18fcd78d503d@buildbot.net>
Message-ID: <050.ee08117c66732fcfe76a5e2d508d9385@buildbot.net>

#1806: ircbot doesn't rejoin
-------------------+------------------------
Reporter:  gg0     |       Owner:
    Type:  defect  |      Status:  new
Priority:  major   |   Milestone:  undecided
 Version:  0.8.3   |  Resolution:
Keywords:          |
-------------------+------------------------
Changes (by dustin):

 * type:  undecided => defect


Old description:

> <gg0> hi
> <gg0> if ircbot leaves due to network timeout, it won't rejoin until
> master restart. known issue? should I file a bug?
> <xxxxxx> there may be a bug for it already
> <yyyyyy> yeah probably it's been known for a long time
> <xxxxxx> gg0: file a bug and let someone mark it as duplicate later :P
>
> http://www.gnashdev.org:8010/about

New description:

 {{{
 <gg0> hi
 <gg0> if ircbot leaves due to network timeout, it won't rejoin until
 master restart. known issue? should I file a bug?
 <xxxxxx> there may be a bug for it already
 <yyyyyy> yeah probably it's been known for a long time
 <xxxxxx> gg0: file a bug and let someone mark it as duplicate later :P
 }}}
 http://www.gnashdev.org:8010/about

--

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1806#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sun Feb 13 18:45:00 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 13 Feb 2011 18:45:00 -0000
Subject: [Buildbot-commits] [Buildbot] #1806: ircbot doesn't rejoin
In-Reply-To: <035.b36ea871adb92b51419b18fcd78d503d@buildbot.net>
References: <035.b36ea871adb92b51419b18fcd78d503d@buildbot.net>
Message-ID: <050.ad6a513a45ad6b8ada2c7c619012caff@buildbot.net>

#1806: ircbot doesn't rejoin
-------------------+------------------------
Reporter:  gg0     |       Owner:
    Type:  defect  |      Status:  closed
Priority:  major   |   Milestone:  undecided
 Version:  0.8.3   |  Resolution:  duplicate
Keywords:  irc     |
-------------------+------------------------
Changes (by dustin):

 * keywords:   => irc
 * status:  new => closed
 * resolution:   => duplicate


Comment:

 yep, it's a dupe - see the 'irc' tag: #498

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1806#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sun Feb 13 22:29:01 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 13 Feb 2011 22:29:01 -0000
Subject: [Buildbot-commits] [Buildbot] #1805: build end_time can become
	"True"
In-Reply-To: <039.2931abac5224cf52776522f9443597c0@buildbot.net>
References: <039.2931abac5224cf52776522f9443597c0@buildbot.net>
Message-ID: <054.9e2f6c6ae0dc7a4c047f55df77934756@buildbot.net>

#1805: build end_time can become "True"
----------------------+------------------------
Reporter:  ddunbar    |       Owner:
    Type:  undecided  |      Status:  new
Priority:  major      |   Milestone:  undecided
 Version:  0.8.3p1    |  Resolution:
Keywords:             |
----------------------+------------------------

Comment (by dustin):

 That looks like a builder pickle, rather than a build pickle.  The times
 should be in the build, not the builder.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1805#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sun Feb 13 22:53:35 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 13 Feb 2011 22:53:35 -0000
Subject: [Buildbot-commits] [Buildbot] #1807: aggregate coverage from all
	metabuildbot builders
Message-ID: <038.fbd4026cb0390f7e085aa96a3d473c33@buildbot.net>

#1807: aggregate coverage from all metabuildbot builders
--------------------+-------------------
Reporter:  dustin   |      Owner:
    Type:  task     |     Status:  new
Priority:  major    |  Milestone:  0.8.+
 Version:  0.8.3p1  |   Keywords:  tests
--------------------+-------------------
 There are a number of special cases for windows or old versions of Twisted
 or Python that come across as un-covered in the Buildbot coverage
 analysis.  Wouldn't it be cool if we could aggregate the reported coverage
 from all test runs across all builders, and make a combined report?

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1807>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Mon Feb 14 00:27:30 2011
From: noreply at github.com (noreply at github.com)
Date: Sun, 13 Feb 2011 16:27:30 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] 0d4dc9: Add identity_file
	for gerrit events
Message-ID: <20110214002730.416C0422D3@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 0d4dc9f583e88e6b6d3e5b30ba0e518a106ae4cc
    https://github.com/buildbot/buildbot/commit/0d4dc9f583e88e6b6d3e5b30ba0e518a106ae4cc
Author: Terence Haddock <thaddock at tripi.com>
Date:   2011-02-13 (Sun, 13 Feb 2011)

Changed paths:
  M master/buildbot/changes/gerritchangesource.py

Log Message:
-----------
Add identity_file for gerrit events





From noreply at github.com  Mon Feb 14 00:42:55 2011
From: noreply at github.com (noreply at github.com)
Date: Sun, 13 Feb 2011 16:42:55 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] 84361d: fix pxref uses
Message-ID: <20110214004255.1D796420D8@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 84361d782a326af2aa7551fe7e6f0ac5cda37c5b
    https://github.com/buildbot/buildbot/commit/84361d782a326af2aa7551fe7e6f0ac5cda37c5b
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-13 (Sun, 13 Feb 2011)

Changed paths:
  M master/docs/cfg-global.texinfo

Log Message:
-----------
fix pxref uses


Commit: 9aa10654658fd7ca314503dd6c3ae275c17fddc1
    https://github.com/buildbot/buildbot/commit/9aa10654658fd7ca314503dd6c3ae275c17fddc1
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-13 (Sun, 13 Feb 2011)

Changed paths:
  M master/buildbot/db/buildsets.py
  M master/buildbot/test/unit/test_db_buildsets.py
  M master/buildbot/test/util/db.py

Log Message:
-----------
test_getSubscribedBuildsets passes, but sqlite is broken

This is enough to get buildbot.test.unit.test_db_buildsets.TestBuildsetsConnectorComponent.test_getSubscribedBuildsets
to pass for postgres, but now the sqlite tests are broken..


Commit: 05814dd3ecc51b757e05f1c82c22a73f7d5612ff
    https://github.com/buildbot/buildbot/commit/05814dd3ecc51b757e05f1c82c22a73f7d5612ff
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-13 (Sun, 13 Feb 2011)

Changed paths:
  M master/buildbot/test/util/db.py

Log Message:
-----------
better _clean_database impl thanks to Piotr Sikora


Commit: 06f99f26a736d9467f3fc6fa71eaf1a92150b956
    https://github.com/buildbot/buildbot/commit/06f99f26a736d9467f3fc6fa71eaf1a92150b956
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-13 (Sun, 13 Feb 2011)

Changed paths:
  M master/buildbot/db/pool.py
  M master/buildbot/test/util/connector_component.py

Log Message:
-----------
properly shut down pools when tests are complete


Commit: 9b940ec7f182c798802487bf7f608fc30ceb6b61
    https://github.com/buildbot/buildbot/commit/9b940ec7f182c798802487bf7f608fc30ceb6b61
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-13 (Sun, 13 Feb 2011)

Changed paths:
  M master/buildbot/test/unit/test_db_buildsets.py

Log Message:
-----------
Fix test_db_buildsets to use proper referential integrity in sample data





From noreply at github.com  Mon Feb 14 05:21:08 2011
From: noreply at github.com (noreply at github.com)
Date: Sun, 13 Feb 2011 21:21:08 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] 1095ed: is_dir col is
	numeric, so don't feed it booleans
Message-ID: <20110214052108.1BC0D422FE@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 1095ede7d32526b9b27a42317bcf0c083dd19492
    https://github.com/buildbot/buildbot/commit/1095ede7d32526b9b27a42317bcf0c083dd19492
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-13 (Sun, 13 Feb 2011)

Changed paths:
  M master/buildbot/test/unit/test_db_changes.py

Log Message:
-----------
is_dir col is numeric, so don't feed it booleans


Commit: 8356403f76d391884c0a17c4ab7b0189e12556b2
    https://github.com/buildbot/buildbot/commit/8356403f76d391884c0a17c4ab7b0189e12556b2
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-13 (Sun, 13 Feb 2011)

Changed paths:
  M master/buildbot/test/util/db.py

Log Message:
-----------
avoid double-cleaning db in tests





From nobody at buildbot.net  Mon Feb 14 14:13:47 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 14 Feb 2011 14:13:47 -0000
Subject: [Buildbot-commits] [Buildbot] #1808: Scheduler with treeStableTimer
 "merges" changes to multiple projects into single SourceStamp
Message-ID: <039.cd87665d300c4855d7e125d8690e0a31@buildbot.net>

#1808: Scheduler with treeStableTimer "merges" changes to multiple projects into
single SourceStamp
--------------------+-----------------------
Reporter:  aivarsk  |      Owner:
    Type:  defect   |     Status:  new
Priority:  major    |  Milestone:  undecided
 Version:  0.8.3p1  |   Keywords:
--------------------+-----------------------
 With treeStableTimer set to some interval Scheduler merges multiple
 changes regardless of project and repository into single SourceStamp.
 SourceStamp then uses project and repository from last change in list and
 only the last project gets built.

 Attached patch solves it for us, maybe there is a better way to do it.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1808>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Feb 14 16:04:25 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 14 Feb 2011 16:04:25 -0000
Subject: [Buildbot-commits] [Buildbot] #1808: Scheduler with
 treeStableTimer "merges" changes to multiple projects into single
 SourceStamp
In-Reply-To: <039.cd87665d300c4855d7e125d8690e0a31@buildbot.net>
References: <039.cd87665d300c4855d7e125d8690e0a31@buildbot.net>
Message-ID: <054.f4f59f2b27c86a1556988a7059fbdce9@buildbot.net>

#1808: Scheduler with treeStableTimer "merges" changes to multiple projects into
single SourceStamp
--------------------+------------------------
Reporter:  aivarsk  |       Owner:
    Type:  defect   |      Status:  new
Priority:  major    |   Milestone:  undecided
 Version:  0.8.3p1  |  Resolution:
Keywords:           |
--------------------+------------------------

Comment (by dustin):

 We're re-naming {{{Scheduler}}} to {{{SingleBranchScheduler}}} in the next
 release, as it's really only intended to watch a single branch (and
 therefore a single proj/repo).

 This change may be a good one to make to the {{{AnyBranchScheduler}}},
 though - it should keep a separate timer for each (proj,repo,branch).

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1808#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Feb 14 16:48:10 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 14 Feb 2011 16:48:10 -0000
Subject: [Buildbot-commits] [Buildbot] #1805: build end_time can become
	"True"
In-Reply-To: <039.2931abac5224cf52776522f9443597c0@buildbot.net>
References: <039.2931abac5224cf52776522f9443597c0@buildbot.net>
Message-ID: <054.18b84651ace89adf0e3d60c9050532ee@buildbot.net>

#1805: build end_time can become "True"
----------------------+------------------------
Reporter:  ddunbar    |       Owner:
    Type:  undecided  |      Status:  new
Priority:  major      |   Milestone:  undecided
 Version:  0.8.3p1    |  Resolution:
Keywords:             |
----------------------+------------------------

Comment (by ddunbar):

 Ah, my bad. Attached build 941.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1805#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Feb 14 17:16:47 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 14 Feb 2011 17:16:47 -0000
Subject: [Buildbot-commits] [Buildbot] #1805: build end_time can become
	"True"
In-Reply-To: <039.2931abac5224cf52776522f9443597c0@buildbot.net>
References: <039.2931abac5224cf52776522f9443597c0@buildbot.net>
Message-ID: <054.0a4e9c727aeeedef08727ebf21b15375@buildbot.net>

#1805: build end_time can become "True"
--------------------+--------------------
Reporter:  ddunbar  |       Owner:
    Type:  defect   |      Status:  new
Priority:  major    |   Milestone:  0.8.4
 Version:  0.8.3p1  |  Resolution:
Keywords:           |
--------------------+--------------------
Changes (by dustin):

 * type:  undecided => defect
 * milestone:  undecided => 0.8.4


Comment:

 Ah, here's the problem, in the !BuildStatus class:

 {{{
     def __getstate__(self):
         d = styles.Versioned.__getstate__(self)
         # for now, a serialized Build is always "finished". We will never
         # save unfinished builds.
         if not self.finished:
             d['finished'] = True
 }}}

 I'm not sure how you're pickling a running build, but there you are.  The
 fix is straightforward.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1805#comment:4>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Mon Feb 14 17:18:53 2011
From: noreply at github.com (noreply at github.com)
Date: Mon, 14 Feb 2011 09:18:53 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] 00e718: Don't use 'True' as
	a build completion time
Message-ID: <20110214171853.B8E87422ED@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 00e718ffbe510b4e7e72ecb979e6588f61cc00b9
    https://github.com/buildbot/buildbot/commit/00e718ffbe510b4e7e72ecb979e6588f61cc00b9
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-14 (Mon, 14 Feb 2011)

Changed paths:
  M master/buildbot/status/builder.py

Log Message:
-----------
Don't use 'True' as a build completion time

Builds ideally wouldn't be pickled while still running, but in the case
that they are, util.now is a much better choice for completion time than
True.  Fixes #1805.





From nobody at buildbot.net  Mon Feb 14 17:19:00 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 14 Feb 2011 17:19:00 -0000
Subject: [Buildbot-commits] [Buildbot] #1805: build end_time can become
	"True"
In-Reply-To: <039.2931abac5224cf52776522f9443597c0@buildbot.net>
References: <039.2931abac5224cf52776522f9443597c0@buildbot.net>
Message-ID: <054.ff762cd933a3f4022872f4408abdd818@buildbot.net>

#1805: build end_time can become "True"
--------------------+---------------------
Reporter:  ddunbar  |       Owner:
    Type:  defect   |      Status:  closed
Priority:  major    |   Milestone:  0.8.4
 Version:  0.8.3p1  |  Resolution:  fixed
Keywords:           |
--------------------+---------------------
Changes (by Dustin J. Mitchell):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Don't use 'True' as a build completion time

 Builds ideally wouldn't be pickled while still running, but in the case
 that they are, util.now is a much better choice for completion time than
 True.  Fixes #1805.
  Changeset: 00e718ffbe510b4e7e72ecb979e6588f61cc00b9

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1805#comment:5>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Feb 14 18:57:44 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 14 Feb 2011 18:57:44 -0000
Subject: [Buildbot-commits] [Buildbot] #1809: better tests for prune_changes
Message-ID: <038.0f7589c0a4a6ccfb9ebeaf9a67ad6c76@buildbot.net>

#1809: better tests for prune_changes
------------------------+-----------------------------
Reporter:  dustin       |      Owner:
    Type:  enhancement  |     Status:  new
Priority:  major        |  Milestone:  0.8.4
 Version:  master       |   Keywords:  tests, database
------------------------+-----------------------------
 The changes table has a lot of inbound foreign key relationships, and not
 all of them are tested by the prune_changes tests.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1809>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Mon Feb 14 19:03:47 2011
From: noreply at github.com (noreply at github.com)
Date: Mon, 14 Feb 2011 11:03:47 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] 49f19a: Refactor DB test code
Message-ID: <20110214190347.E1014422F4@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 49f19a02c387cd2db86387b41f1bf57d436e7909
    https://github.com/buildbot/buildbot/commit/49f19a02c387cd2db86387b41f1bf57d436e7909
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-14 (Mon, 14 Feb 2011)

Changed paths:
  M master/buildbot/test/fake/fakedb.py
  M master/buildbot/test/integration/test_upgrade.py
  M master/buildbot/test/regressions/test_import_unicode_changes.py
  M master/buildbot/test/unit/test_db_buildsets.py
  M master/buildbot/test/unit/test_db_changes.py
  M master/buildbot/test/unit/test_db_connector.py
  M master/buildbot/test/unit/test_db_model.py
  M master/buildbot/test/unit/test_db_schedulers.py
  M master/buildbot/test/unit/test_db_sourcestamps.py
  R master/buildbot/test/unit/test_schedulers_timed_Nightly.py
  M master/buildbot/test/util/change_import.py
  M master/buildbot/test/util/connector_component.py
  M master/buildbot/test/util/db.py

Log Message:
-----------
Refactor DB test code

This factors the RealDatabaseMixin and fakedb code to allow test classes
to specify test data that should be inserted into the database before
the test is run.  This accomplishes two things: first, rows can be
inserted in proper dependency order, which is important for Postgres.
Second, it opens the possibility of using the same test scripts (e.g.,
test_db_changes.py) to test the fake database connectors used in testing
the higher-level parts of Buildbot.

Database cleanup is also improved, at the cost of making the database
test depend on the accuracy of buildbot.db.model.


Commit: b68c44d3c6e162a79e5bdd76f6d96d4b5c5936a0
    https://github.com/buildbot/buildbot/commit/b68c44d3c6e162a79e5bdd76f6d96d4b5c5936a0
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-14 (Mon, 14 Feb 2011)

Changed paths:
  M master/buildbot/db/schedulers.py
  M master/buildbot/test/unit/test_db_connector.py
  M master/buildbot/test/unit/test_db_schedulers.py

Log Message:
-----------
Make tests pass for postgres

This involves getting column types right and making sure that
prerequisite rows are inserted first





From nobody at buildbot.net  Mon Feb 14 20:16:59 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 14 Feb 2011 20:16:59 -0000
Subject: [Buildbot-commits] [Buildbot] #1805: build end_time can become
	"True"
In-Reply-To: <039.2931abac5224cf52776522f9443597c0@buildbot.net>
References: <039.2931abac5224cf52776522f9443597c0@buildbot.net>
Message-ID: <054.cf6db83dee590ec1b1c1f31e7ac0e2c3@buildbot.net>

#1805: build end_time can become "True"
--------------------+---------------------
Reporter:  ddunbar  |       Owner:
    Type:  defect   |      Status:  closed
Priority:  major    |   Milestone:  0.8.4
 Version:  0.8.3p1  |  Resolution:  fixed
Keywords:           |
--------------------+---------------------

Comment (by ddunbar):

 Thanks Dustin!

 One other oddity that happened whenever I see this bug is that the build
 also shows up with no status reported, i.e., the build looks like it was
 never completed, but it also isn't ongoing. Will your fix also resolve
 that?

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1805#comment:6>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Feb 14 20:58:26 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 14 Feb 2011 20:58:26 -0000
Subject: [Buildbot-commits] [Buildbot] #1805: build end_time can become
	"True"
In-Reply-To: <039.2931abac5224cf52776522f9443597c0@buildbot.net>
References: <039.2931abac5224cf52776522f9443597c0@buildbot.net>
Message-ID: <054.c84a9f9fb43a25cdf30573138cd94251@buildbot.net>

#1805: build end_time can become "True"
--------------------+---------------------
Reporter:  ddunbar  |       Owner:
    Type:  defect   |      Status:  closed
Priority:  major    |   Milestone:  0.8.4
 Version:  0.8.3p1  |  Resolution:  fixed
Keywords:           |
--------------------+---------------------

Comment (by dustin):

 That makes sense, given what I saw in the build pickle.  I would need to
 figure out *why* this happens to be able to fix the problem.

 I suspect it has something to do with a long-running build running off the
 tail end of the build cache (which is an LRU cache).  But there's code in
 there to make sure that running builds aren't expired, so that "shouldn't
 happen".  If you can narrow down the circumstances a bit, that might help.
 A new bug pointing to this one would be best for that purpose.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1805#comment:7>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Tue Feb 15 00:01:11 2011
From: noreply at github.com (noreply at github.com)
Date: Mon, 14 Feb 2011 16:01:11 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] bc7c80: add more db.pool
	tests
Message-ID: <20110215000111.26F0A42327@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: bc7c8039b2eef7d74e691a1ce600e34a9e79e984
    https://github.com/buildbot/buildbot/commit/bc7c8039b2eef7d74e691a1ce600e34a9e79e984
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-14 (Mon, 14 Feb 2011)

Changed paths:
  M master/buildbot/test/unit/test_db_pool.py
  M master/buildbot/test/util/db.py

Log Message:
-----------
add more db.pool tests





From nobody at buildbot.net  Tue Feb 15 03:03:25 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 15 Feb 2011 03:03:25 -0000
Subject: [Buildbot-commits] [Buildbot] #1810: older versions of sqlite don't
 handle DDL changes between connections
Message-ID: <038.681ae3df2337646bf8427f98bb7802d9@buildbot.net>

#1810: older versions of sqlite don't handle DDL changes between connections
-------------------+----------------------
Reporter:  dustin  |      Owner:
    Type:  defect  |     Status:  new
Priority:  major   |  Milestone:  0.8.4
 Version:  master  |   Keywords:  database
-------------------+----------------------
 The following fails on sqlite-3.4.2
 {{{
 import os
 import sqlite3

 if os.path.exists("/tmp/my.db"):
         os.unlink("/tmp/my.db")

 def combined():
         conn1 = sqlite3.connect("/tmp/my.db")
         curs1 = conn1.cursor()
         print "1: pragma" ## B
         curs1.execute("PRAGMA table_info('foo')")

         conn2 = sqlite3.connect("/tmp/my.db")
         curs2 = conn2.cursor()
         print "2: create"
         curs2.execute("CREATE TABLE foo ( a integer )")
         conn2.commit()
         conn2.close() ## C

         print "1: select"
         # curs1.execute("SELECT * from sqlite_master") ## A
         curs1.execute("SELECT * from foo")

 combined()
 }}}
 as follows:
 {{{
 1: pragma
 2: create
 1: select
 Traceback (most recent call last):
   File "simp.py", line 23, in <module>
     combined()
   File "simp.py", line 21, in combined
     curs1.execute("SELECT * from foo")
 sqlite3.OperationalError: no such table: foo
 }}}


 Uncommenting the sqlite_master select (A) will eliminate the
 OperationalError.
 Commenting out the pragma (B) will eliminate the OperationalError.
 Adding {{{conn2.close()}}} after the commit (C) does not help
 (OperationalError stil occurs)

 I haven't managed to find an upstream bug for this yet, bug I'll link it
 here when I do.  For the moment, I'm going to add a nasty, ugly, no-good
 workaround based on B.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1810>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Feb 15 03:03:56 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 15 Feb 2011 03:03:56 -0000
Subject: [Buildbot-commits] [Buildbot] #1810: older versions of sqlite
 don't handle DDL changes between connections
In-Reply-To: <038.681ae3df2337646bf8427f98bb7802d9@buildbot.net>
References: <038.681ae3df2337646bf8427f98bb7802d9@buildbot.net>
Message-ID: <053.8a7bdfde063edd1d0b0a901a274626c2@buildbot.net>

#1810: older versions of sqlite don't handle DDL changes between connections
---------------------+--------------------
Reporter:  dustin    |       Owner:
    Type:  defect    |      Status:  new
Priority:  major     |   Milestone:  0.8.4
 Version:  master    |  Resolution:
Keywords:  database  |
---------------------+--------------------
Description changed by dustin:

Old description:

> The following fails on sqlite-3.4.2
> {{{
> import os
> import sqlite3
>
> if os.path.exists("/tmp/my.db"):
>         os.unlink("/tmp/my.db")
>
> def combined():
>         conn1 = sqlite3.connect("/tmp/my.db")
>         curs1 = conn1.cursor()
>         print "1: pragma" ## B
>         curs1.execute("PRAGMA table_info('foo')")
>
>         conn2 = sqlite3.connect("/tmp/my.db")
>         curs2 = conn2.cursor()
>         print "2: create"
>         curs2.execute("CREATE TABLE foo ( a integer )")
>         conn2.commit()
>         conn2.close() ## C
>
>         print "1: select"
>         # curs1.execute("SELECT * from sqlite_master") ## A
>         curs1.execute("SELECT * from foo")
>
> combined()
> }}}
> as follows:
> {{{
> 1: pragma
> 2: create
> 1: select
> Traceback (most recent call last):
>   File "simp.py", line 23, in <module>
>     combined()
>   File "simp.py", line 21, in combined
>     curs1.execute("SELECT * from foo")
> sqlite3.OperationalError: no such table: foo
> }}}
>

> Uncommenting the sqlite_master select (A) will eliminate the
> OperationalError.
> Commenting out the pragma (B) will eliminate the OperationalError.
> Adding {{{conn2.close()}}} after the commit (C) does not help
> (OperationalError stil occurs)
>
> I haven't managed to find an upstream bug for this yet, bug I'll link it
> here when I do.  For the moment, I'm going to add a nasty, ugly, no-good
> workaround based on B.

New description:

 The following fails on sqlite-3.4.2
 {{{
 import os
 import sqlite3

 if os.path.exists("/tmp/my.db"):
         os.unlink("/tmp/my.db")

 def combined():
         conn1 = sqlite3.connect("/tmp/my.db")
         curs1 = conn1.cursor()
         print "1: pragma" ## B
         curs1.execute("PRAGMA table_info('foo')")

         conn2 = sqlite3.connect("/tmp/my.db")
         curs2 = conn2.cursor()
         print "2: create"
         curs2.execute("CREATE TABLE foo ( a integer )")
         conn2.commit()
         conn2.close() ## C

         print "1: select"
         # curs1.execute("SELECT * from sqlite_master") ## A
         curs1.execute("SELECT * from foo")

 combined()
 }}}
 as follows:
 {{{
 1: pragma
 2: create
 1: select
 Traceback (most recent call last):
   File "simp.py", line 23, in <module>
     combined()
   File "simp.py", line 21, in combined
     curs1.execute("SELECT * from foo")
 sqlite3.OperationalError: no such table: foo
 }}}


 Uncommenting the sqlite_master select (A) will eliminate the
 !OperationalError.
 Commenting out the pragma (B) will eliminate the !OperationalError.
 Adding {{{conn2.close()}}} after the commit (C) does not help
 (!OperationalError stil occurs)

 I haven't managed to find an upstream bug for this yet, bug I'll link it
 here when I do.  For the moment, I'm going to add a nasty, ugly, no-good
 workaround based on B.

--

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1810#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Feb 15 04:09:34 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 15 Feb 2011 04:09:34 -0000
Subject: [Buildbot-commits] [Buildbot] #1810: older versions of sqlite
 don't handle DDL changes between connections
In-Reply-To: <038.681ae3df2337646bf8427f98bb7802d9@buildbot.net>
References: <038.681ae3df2337646bf8427f98bb7802d9@buildbot.net>
Message-ID: <053.7211aafa63659c02ff069f8ca8759cd4@buildbot.net>

#1810: older versions of sqlite don't handle DDL changes between connections
---------------------+--------------------
Reporter:  dustin    |       Owner:
    Type:  defect    |      Status:  new
Priority:  major     |   Milestone:  0.8.4
 Version:  master    |  Resolution:
Keywords:  database  |
---------------------+--------------------
Description changed by dustin:

Old description:

> The following fails on sqlite-3.4.2
> {{{
> import os
> import sqlite3
>
> if os.path.exists("/tmp/my.db"):
>         os.unlink("/tmp/my.db")
>
> def combined():
>         conn1 = sqlite3.connect("/tmp/my.db")
>         curs1 = conn1.cursor()
>         print "1: pragma" ## B
>         curs1.execute("PRAGMA table_info('foo')")
>
>         conn2 = sqlite3.connect("/tmp/my.db")
>         curs2 = conn2.cursor()
>         print "2: create"
>         curs2.execute("CREATE TABLE foo ( a integer )")
>         conn2.commit()
>         conn2.close() ## C
>
>         print "1: select"
>         # curs1.execute("SELECT * from sqlite_master") ## A
>         curs1.execute("SELECT * from foo")
>
> combined()
> }}}
> as follows:
> {{{
> 1: pragma
> 2: create
> 1: select
> Traceback (most recent call last):
>   File "simp.py", line 23, in <module>
>     combined()
>   File "simp.py", line 21, in combined
>     curs1.execute("SELECT * from foo")
> sqlite3.OperationalError: no such table: foo
> }}}
>

> Uncommenting the sqlite_master select (A) will eliminate the
> !OperationalError.
> Commenting out the pragma (B) will eliminate the !OperationalError.
> Adding {{{conn2.close()}}} after the commit (C) does not help
> (!OperationalError stil occurs)
>
> I haven't managed to find an upstream bug for this yet, bug I'll link it
> here when I do.  For the moment, I'm going to add a nasty, ugly, no-good
> workaround based on B.

New description:

 The following fails on sqlite-3.4.2
 {{{
 import os
 import sqlite3

 print "sqlite.py:", sqlite3.version
 print "sqlite itself:", sqlite3.sqlite_version

 if os.path.exists("/tmp/my.db"):
         os.unlink("/tmp/my.db")

 def combined():
         conn1 = sqlite3.connect("/tmp/my.db")
         curs1 = conn1.cursor()
         print "1: pragma" ## B
         curs1.execute("PRAGMA table_info('foo')")

         conn2 = sqlite3.connect("/tmp/my.db")
         curs2 = conn2.cursor()
         print "2: create"
         curs2.execute("CREATE TABLE foo ( a integer )")
         conn2.commit()
         conn2.close() ## C

         print "1: select"
         # curs1.execute("SELECT * from sqlite_master") ## A
         curs1.execute("SELECT * from foo")

 combined()
 }}}
 as follows:
 {{{
 1: pragma
 2: create
 1: select
 Traceback (most recent call last):
   File "simp.py", line 23, in <module>
     combined()
   File "simp.py", line 21, in combined
     curs1.execute("SELECT * from foo")
 sqlite3.OperationalError: no such table: foo
 }}}


 Uncommenting the sqlite_master select (A) will eliminate the
 !OperationalError.
 Commenting out the pragma (B) will eliminate the !OperationalError.
 Adding {{{conn2.close()}}} after the commit (C) does not help
 (!OperationalError stil occurs)

 I haven't managed to find an upstream bug for this yet, bug I'll link it
 here when I do.  For the moment, I'm going to add a nasty, ugly, no-good
 workaround based on B.

--

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1810#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Tue Feb 15 04:12:59 2011
From: noreply at github.com (noreply at github.com)
Date: Mon, 14 Feb 2011 20:12:59 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] 68285a: Workaround SQLite
	bug with caching table metadata
Message-ID: <20110215041259.2C0DB42193@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 68285a36bb37b05515976a5f0139f66f06969a9f
    https://github.com/buildbot/buildbot/commit/68285a36bb37b05515976a5f0139f66f06969a9f
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-14 (Mon, 14 Feb 2011)

Changed paths:
  M master/buildbot/db/pool.py

Log Message:
-----------
Workaround SQLite bug with caching table metadata

This runs 'SELECT * from sqlite_master' before each pool operation, when
using the sqlite dialect.  Refs #1810.


Commit: cef4936661e639456fb8ac1b6651f0ec4210c3e2
    https://github.com/buildbot/buildbot/commit/cef4936661e639456fb8ac1b6651f0ec4210c3e2
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-14 (Mon, 14 Feb 2011)

Changed paths:
  M master/buildbot/db/pool.py

Log Message:
-----------
Conditionalize SQLite workaround on presence of bug

This runs a quick sequence on every pool instantiation to determine
whether or not this SQLite bug is present, and sets the workaround flag
only if it is found.  Refs #1810.





From nobody at buildbot.net  Tue Feb 15 04:13:07 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 15 Feb 2011 04:13:07 -0000
Subject: [Buildbot-commits] [Buildbot] #1810: older versions of sqlite
 don't handle DDL changes between connections
In-Reply-To: <038.681ae3df2337646bf8427f98bb7802d9@buildbot.net>
References: <038.681ae3df2337646bf8427f98bb7802d9@buildbot.net>
Message-ID: <053.fb4d5902e8ac6baae036ad9f52839825@buildbot.net>

#1810: older versions of sqlite don't handle DDL changes between connections
---------------------+--------------------
Reporter:  dustin    |       Owner:
    Type:  defect    |      Status:  new
Priority:  major     |   Milestone:  0.8.4
 Version:  master    |  Resolution:
Keywords:  database  |
---------------------+--------------------

Comment (by Dustin J. Mitchell):

 Workaround SQLite bug with caching table metadata

 This runs 'SELECT * from sqlite_master' before each pool operation, when
 using the sqlite dialect.  Refs #1810.
  Changeset: 68285a36bb37b05515976a5f0139f66f06969a9f

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1810#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Feb 15 04:13:08 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 15 Feb 2011 04:13:08 -0000
Subject: [Buildbot-commits] [Buildbot] #1810: older versions of sqlite
 don't handle DDL changes between connections
In-Reply-To: <038.681ae3df2337646bf8427f98bb7802d9@buildbot.net>
References: <038.681ae3df2337646bf8427f98bb7802d9@buildbot.net>
Message-ID: <053.debe419af79d861e3802e96738651a57@buildbot.net>

#1810: older versions of sqlite don't handle DDL changes between connections
---------------------+--------------------
Reporter:  dustin    |       Owner:
    Type:  defect    |      Status:  new
Priority:  major     |   Milestone:  0.8.4
 Version:  master    |  Resolution:
Keywords:  database  |
---------------------+--------------------

Comment (by Dustin J. Mitchell):

 Conditionalize SQLite workaround on presence of bug

 This runs a quick sequence on every pool instantiation to determine
 whether or not this SQLite bug is present, and sets the workaround flag
 only if it is found.  Refs #1810.
  Changeset: cef4936661e639456fb8ac1b6651f0ec4210c3e2

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1810#comment:4>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Tue Feb 15 04:18:23 2011
From: noreply at github.com (noreply at github.com)
Date: Mon, 14 Feb 2011 20:18:23 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] 31a3b8: close connections
	before deleting test database, f...
Message-ID: <20110215041823.B4038422DF@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 31a3b802f8d0010c09808ec6e84d8fb8c25ac432
    https://github.com/buildbot/buildbot/commit/31a3b802f8d0010c09808ec6e84d8fb8c25ac432
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-14 (Mon, 14 Feb 2011)

Changed paths:
  M master/buildbot/db/pool.py

Log Message:
-----------
close connections before deleting test database, for windows





From nobody at buildbot.net  Tue Feb 15 04:41:40 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 15 Feb 2011 04:41:40 -0000
Subject: [Buildbot-commits] [Buildbot] #1810: older versions of sqlite
 don't handle DDL changes between connections
In-Reply-To: <038.681ae3df2337646bf8427f98bb7802d9@buildbot.net>
References: <038.681ae3df2337646bf8427f98bb7802d9@buildbot.net>
Message-ID: <053.34d46591ab3ade3f740b9ad182220b91@buildbot.net>

#1810: older versions of sqlite don't handle DDL changes between connections
---------------------+--------------------
Reporter:  dustin    |       Owner:
    Type:  defect    |      Status:  new
Priority:  major     |   Milestone:  0.8.4
 Version:  master    |  Resolution:
Keywords:  database  |
---------------------+--------------------

Comment (by dustin):

 Running this on a few systems, I've narrowed it down to the sqlite_version
 -- 3.6.12 and earlier fail; 3.6.17 and later succeed.  I don't have
 systems within that gap, so I don't know exactly where this was fixed.

 I'll check the sqlite mailing list to see if the workaround above is
 decent, or if there's something better.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1810#comment:5>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Tue Feb 15 06:22:31 2011
From: noreply at github.com (noreply at github.com)
Date: Mon, 14 Feb 2011 22:22:31 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] b95cbd: fix formatting
Message-ID: <20110215062231.97FA042338@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: b95cbd7640e2ddf1e19755e651ac2aec07272ed2
    https://github.com/buildbot/buildbot/commit/b95cbd7640e2ddf1e19755e651ac2aec07272ed2
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-14 (Mon, 14 Feb 2011)

Changed paths:
  M master/buildbot/db/buildsets.py
  M master/buildbot/db/pool.py
  M master/buildbot/test/util/db.py

Log Message:
-----------
fix formatting





From noreply at github.com  Tue Feb 15 18:22:41 2011
From: noreply at github.com (noreply at github.com)
Date: Tue, 15 Feb 2011 10:22:41 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] c78e6a: minor setup.py
	cleanup
Message-ID: <20110215182241.D5A4B420D5@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: c78e6acdf2c7f20d54277d99c9bd119bb7ad0a31
    https://github.com/buildbot/buildbot/commit/c78e6acdf2c7f20d54277d99c9bd119bb7ad0a31
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-15 (Tue, 15 Feb 2011)

Changed paths:
  M master/setup.py

Log Message:
-----------
minor setup.py cleanup


Commit: eae1014d05bc1ded3927cccdc0a21d0160a65c70
    https://github.com/buildbot/buildbot/commit/eae1014d05bc1ded3927cccdc0a21d0160a65c70
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-15 (Tue, 15 Feb 2011)

Changed paths:
  M slave/buildslave/bot.py

Log Message:
-----------
don't assume that reactor.stop doesn't return (it does)





From nobody at buildbot.net  Wed Feb 16 16:04:50 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 16 Feb 2011 16:04:50 -0000
Subject: [Buildbot-commits] [Buildbot] #1811: alwaysRun steps don't get run
 if Stop Build is pressed
Message-ID: <038.34c2a2d495c9751f122d8351e15a68df@buildbot.net>

#1811: alwaysRun steps don't get run if Stop Build is pressed
-------------------+-----------------------
Reporter:  catlee  |      Owner:
    Type:  defect  |     Status:  new
Priority:  minor   |  Milestone:  undecided
 Version:  0.8.0   |   Keywords:
-------------------+-----------------------
 In ticket #706 (e0d4533f962a51c60456a5a4fd1a5b4d6dee3c1d) we made it so
 that alwaysRun steps don't get run after Stop Build is pressed.

 I think this was a mistake, as it prevents being able to add cleanup steps
 to your builds (e.g. rebooting machines).

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1811>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Wed Feb 16 21:24:36 2011
From: noreply at github.com (noreply at github.com)
Date: Wed, 16 Feb 2011 13:24:36 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] 5c47a5: Fix integration with
	SQLAlchemy-migrate-0.6.1.
Message-ID: <20110216212436.DE1614224E@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 5c47a5d4483cf76c0a7be1db8e4fe8f6f8aae48e
    https://github.com/buildbot/buildbot/commit/5c47a5d4483cf76c0a7be1db8e4fe8f6f8aae48e
Author: Piotr Sikora <piotr.sikora at frickle.com>
Date:   2011-02-16 (Wed, 16 Feb 2011)

Changed paths:
  M master/buildbot/db/model.py

Log Message:
-----------
Fix integration with SQLAlchemy-migrate-0.6.1.

SQLAlchemy-migrate moved all exceptions to migrate.exceptions.


Commit: fb4d65f735bdfd635d3ac54d0b9ed6772e09af56
    https://github.com/buildbot/buildbot/commit/fb4d65f735bdfd635d3ac54d0b9ed6772e09af56
Author: Piotr Sikora <piotr.sikora at frickle.com>
Date:   2011-02-16 (Wed, 16 Feb 2011)

Changed paths:
  M master/buildbot/db/model.py

Log Message:
-----------
Change order.


Commit: 0e78c4c71020170c2732bbdc1d898cb0d9a6b723
    https://github.com/buildbot/buildbot/commit/0e78c4c71020170c2732bbdc1d898cb0d9a6b723
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-16 (Wed, 16 Feb 2011)

Changed paths:
  M master/buildbot/db/model.py

Log Message:
-----------
Merge branch 'migrate-fixes' of git://github.com/PiotrSikora/buildbot

* 'migrate-fixes' of git://github.com/PiotrSikora/buildbot:
  Change order.
  Fix integration with SQLAlchemy-migrate-0.6.1.

(_hush_pyflakes added by dustin)





From noreply at github.com  Thu Feb 17 03:09:22 2011
From: noreply at github.com (noreply at github.com)
Date: Wed, 16 Feb 2011 19:09:22 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] 553665: correctly pass
	master to PBChangeSource perspectiv...
Message-ID: <20110217030922.5B00D42335@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 553665af63e46e20d0dc7888fd54f6f04f28de47
    https://github.com/buildbot/buildbot/commit/553665af63e46e20d0dc7888fd54f6f04f28de47
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-16 (Wed, 16 Feb 2011)

Changed paths:
  M master/buildbot/changes/pb.py

Log Message:
-----------
correctly pass master to PBChangeSource perspective


Commit: 4d30e8d900dffb56fc79ba704a6b40f2c224cf16
    https://github.com/buildbot/buildbot/commit/4d30e8d900dffb56fc79ba704a6b40f2c224cf16
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-16 (Wed, 16 Feb 2011)

Changed paths:
  M master/buildbot/changes/manager.py

Log Message:
-----------
remove non-working epydoc





From nobody at buildbot.net  Fri Feb 18 10:39:58 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 18 Feb 2011 10:39:58 -0000
Subject: [Buildbot-commits] [Buildbot] #1812: How to use two buildbot with
 different version in same machine.
Message-ID: <047.014b18441d5660ff2a711533374f3bc3@buildbot.net>

#1812: How to use two buildbot with different version in same machine.
----------------------------+------------------------------
Reporter:  sanlokenpatidar  |      Owner:  Lokendra Patidar
    Type:  support-request  |     Status:  new
Priority:  major            |  Milestone:  0.8.+
 Version:  0.8.2            |   Keywords:  Buildbot
----------------------------+------------------------------
 Currently i am using linux fedora11 for build master and Windows 7 for
 buildbot slave.
 I installed buildbot master and slave 0.8.2 version on linux and Windows
 machine.
 Now how to use two buildbot master with different version in linux machine
 and same for windows machine.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1812>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Feb 18 12:16:34 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 18 Feb 2011 12:16:34 -0000
Subject: [Buildbot-commits] [Buildbot] #1813: Grid and T-Grid performance
Message-ID: <039.477df23688cdc5e02e1ceaf762a6af66@buildbot.net>

#1813: Grid and T-Grid performance
------------------------+-----------------------
Reporter:  aivarsk      |      Owner:
    Type:  enhancement  |     Status:  new
Priority:  major        |  Milestone:  undecided
 Version:  0.8.3p1      |   Keywords:
------------------------+-----------------------
 Instead of collecting all unique SourceStamps from all builders and then
 taking last numBuilds sourcestamps, the code now takes only last numBuilds
 Builds/SourceStamps from each builder.

 This improves performance from 15 seconds with default caching options (18
 builders, 1100 builds) to under a second.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1813>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Feb 18 12:54:53 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 18 Feb 2011 12:54:53 -0000
Subject: [Buildbot-commits] [Buildbot] #1812: How to use two buildbot
 with different version in same machine.
In-Reply-To: <047.014b18441d5660ff2a711533374f3bc3@buildbot.net>
References: <047.014b18441d5660ff2a711533374f3bc3@buildbot.net>
Message-ID: <062.f62d59be783415d3bfb55b5d0b74dda8@buildbot.net>

#1812: How to use two buildbot with different version in same machine.
----------------------------+-------------------------------
Reporter:  sanlokenpatidar  |       Owner:  Lokendra Patidar
    Type:  support-request  |      Status:  new
Priority:  major            |   Milestone:  0.8.+
 Version:  0.8.2            |  Resolution:
Keywords:  Buildbot         |
----------------------------+-------------------------------

Comment (by jollyroger):

 You could run different versions of buildbot using
 [http://pypi.python.org/pypi/virtualenv virtualenv] Python package. This a
 Pythonic chroot, where you can install your packages. There is an article
 on this wiki, too: RunningBuildbotWithVirtualEnv

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1812#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Feb 18 15:49:59 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 18 Feb 2011 15:49:59 -0000
Subject: [Buildbot-commits] [Buildbot] #1812: How to use two buildbot
 with different version in same machine.
In-Reply-To: <047.014b18441d5660ff2a711533374f3bc3@buildbot.net>
References: <047.014b18441d5660ff2a711533374f3bc3@buildbot.net>
Message-ID: <062.4f941ed2a90af38184bb786aebdedc07@buildbot.net>

#1812: How to use two buildbot with different version in same machine.
----------------------------+-------------------------------
Reporter:  sanlokenpatidar  |       Owner:  Lokendra Patidar
    Type:  support-request  |      Status:  closed
Priority:  major            |   Milestone:  0.8.+
 Version:  0.8.2            |  Resolution:  fixed
Keywords:                   |
----------------------------+-------------------------------
Changes (by dustin):

 * keywords:  Buildbot =>
 * status:  new => closed
 * resolution:   => fixed


Comment:

 Thanks, jollyroger!

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1812#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Feb 19 00:41:37 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 19 Feb 2011 00:41:37 -0000
Subject: [Buildbot-commits] [Buildbot] #1814: Make Buildbot more awesome.
Message-ID: <037.ab1167a7230acbc697f72ef23bfaa5ba@buildbot.net>

#1814: Make Buildbot more awesome.
------------------------+----------------------
Reporter:  ayust        |      Owner:  djmitche
    Type:  enhancement  |     Status:  new
Priority:  critical     |  Milestone:  ongoing
 Version:  master       |   Keywords:
------------------------+----------------------
 See title.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1814>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Feb 19 00:42:27 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 19 Feb 2011 00:42:27 -0000
Subject: [Buildbot-commits] [Buildbot] #1814: Make Buildbot more awesome.
In-Reply-To: <037.ab1167a7230acbc697f72ef23bfaa5ba@buildbot.net>
References: <037.ab1167a7230acbc697f72ef23bfaa5ba@buildbot.net>
Message-ID: <052.885544be5b5a90f2e1a56851049cd3d6@buildbot.net>

#1814: Make Buildbot more awesome.
-------------------------------------------------+-------------------------
Reporter:  ayust                                 |       Owner:  djmitche
    Type:  enhancement                           |      Status:  new
Priority:  critical                              |   Milestone:  ongoing
 Version:  master                                |  Resolution:
Keywords:  car chases, explosions, high-tech     |
  sounds                                         |
-------------------------------------------------+-------------------------
Changes (by ayust):

 * keywords:   => car chases, explosions, high-tech sounds


-- 
Ticket URL: <http://trac.buildbot.net/ticket/1814#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Feb 19 11:21:52 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 19 Feb 2011 11:21:52 -0000
Subject: [Buildbot-commits] [Buildbot] #1815: exceptions.NameError: global
 name 't' is not defined
Message-ID: <038.5f5fb5625898af4621952ce486a2b2c8@buildbot.net>

#1815: exceptions.NameError: global name 't' is not defined
-------------------+-----------------------
Reporter:  pitrou  |      Owner:
    Type:  defect  |     Status:  new
Priority:  major   |  Milestone:  undecided
 Version:  0.8.2   |   Keywords:
-------------------+-----------------------
 The following appeared in our log file here (rev 0.8.2-15-gefcf05d):

 {{{
 2011-02-19 11:17:34+0000 [-] Unhandled Error
         Traceback (most recent call last):
           File "/data/buildbot/lib/python/buildbot/status/builder.py",
 line 1388, in buildFinished
             w.callback(self)
           File "/usr/lib/python2.6/dist-
 packages/twisted/internet/defer.py", line 318, in callback
             self._startRunCallbacks(result)
           File "/usr/lib/python2.6/dist-
 packages/twisted/internet/defer.py", line 424, in _startRunCallbacks
             self._runCallbacks()
           File "/usr/lib/python2.6/dist-
 packages/twisted/internet/defer.py", line 441, in _runCallbacks
             self.result = callback(self.result, *args, **kw)
         --- <exception caught here> ---
           File "/data/buildbot/lib/python/buildbot/status/builder.py",
 line 2045, in _buildFinished
             w.buildFinished(name, s, results)
           File "/data/buildbot/lib/python/buildbot/status/mail.py", line
 406, in buildFinished
             return self.buildMessage(name, build, results)
           File "/data/buildbot/lib/python/buildbot/status/mail.py", line
 530, in buildMessage
             if "test" in t: # only if the test went wrong
         exceptions.NameError: global name 't' is not defined
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1815>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Feb 19 19:13:38 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 19 Feb 2011 19:13:38 -0000
Subject: [Buildbot-commits] [Buildbot] #1815: exceptions.NameError:
 global name 't' is not defined
In-Reply-To: <038.5f5fb5625898af4621952ce486a2b2c8@buildbot.net>
References: <038.5f5fb5625898af4621952ce486a2b2c8@buildbot.net>
Message-ID: <053.e2301019650f8c7da26efceaefc425b4@buildbot.net>

#1815: exceptions.NameError: global name 't' is not defined
-------------------+------------------------
Reporter:  pitrou  |       Owner:
    Type:  defect  |      Status:  closed
Priority:  major   |   Milestone:  undecided
 Version:  0.8.2   |  Resolution:  invalid
Keywords:          |
-------------------+------------------------
Changes (by dustin):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 That looks like a local modification.  I see no such line, and revision
 efcf05d doesn't seem to exist in my repository.  Line 530 of that file in
 v0.8.2 is
 {{{
          return self.sendMessage(m, list(to_recipients | cc_recipients))
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1815#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Feb 19 20:48:13 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 19 Feb 2011 20:48:13 -0000
Subject: [Buildbot-commits] [Buildbot] #1816: Add a propery exposing slave
	basedir.
Message-ID: <042.eefc96616f7c1c3a9170d09daa28ceb2@buildbot.net>

#1816: Add a propery exposing slave basedir.
------------------------+-----------------------
Reporter:  tom.prince   |      Owner:
    Type:  enhancement  |     Status:  new
Priority:  trivial      |  Milestone:  undecided
 Version:  master       |   Keywords:
------------------------+-----------------------
 The slave already passes (enough info to calculate) this to the master, so
 we should just expose it, rather than everybody giving different methods.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1816>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Sun Feb 20 01:14:59 2011
From: noreply at github.com (noreply at github.com)
Date: Sat, 19 Feb 2011 17:14:59 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] 815177: Add ability to track
	persistent state for objects
Message-ID: <20110220011459.8407842314@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 815177cb37ab71d576bfe35f5026a565e68d92f2
    https://github.com/buildbot/buildbot/commit/815177cb37ab71d576bfe35f5026a565e68d92f2
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-19 (Sat, 19 Feb 2011)

Changed paths:
  A master/buildbot/db/migrate/versions/007_add_object_tables.py
  M master/buildbot/db/model.py
  A master/buildbot/db/state.py
  M master/buildbot/test/fake/fakedb.py
  A master/buildbot/test/unit/test_db_state.py

Log Message:
-----------
Add ability to track persistent state for objects

This allows objects to track their state from process to process.  It's
similar to scheduler state, except that each (object,name) pair gets its
own database row, so there is less concern about conflicting state
updates.





From noreply at github.com  Sun Feb 20 01:16:50 2011
From: noreply at github.com (noreply at github.com)
Date: Sat, 19 Feb 2011 17:16:50 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] a7f47f: set active=1 when
	subscribing to a buildset
Message-ID: <20110220011650.8F19C422E2@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: a7f47f8c37a6deaafbcdf366cf5413565345793b
    https://github.com/buildbot/buildbot/commit/a7f47f8c37a6deaafbcdf366cf5413565345793b
Author: Dustin J. Mitchell <dustin at v.igoro.us>
Date:   2011-02-19 (Sat, 19 Feb 2011)

Changed paths:
  M master/buildbot/db/buildsets.py
  M master/buildbot/test/unit/test_db_buildsets.py

Log Message:
-----------
set active=1 when subscribing to a buildset





From noreply at github.com  Sun Feb 20 01:29:40 2011
From: noreply at github.com (noreply at github.com)
Date: Sat, 19 Feb 2011 17:29:40 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] cac108: add master.db.state
	attribute
Message-ID: <20110220012940.0BF7842323@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: cac108abf65a35d3d298f602c3723a0b66277866
    https://github.com/buildbot/buildbot/commit/cac108abf65a35d3d298f602c3723a0b66277866
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-19 (Sat, 19 Feb 2011)

Changed paths:
  M master/buildbot/db/connector.py

Log Message:
-----------
add master.db.state attribute





From nobody at buildbot.net  Mon Feb 21 05:07:45 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 21 Feb 2011 05:07:45 -0000
Subject: [Buildbot-commits] [Buildbot] #1813: Grid and T-Grid performance
In-Reply-To: <039.477df23688cdc5e02e1ceaf762a6af66@buildbot.net>
References: <039.477df23688cdc5e02e1ceaf762a6af66@buildbot.net>
Message-ID: <054.ce47a95e297c43d4b9b1ac11e0cb5bd8@buildbot.net>

#1813: Grid and T-Grid performance
------------------------+------------------------
Reporter:  aivarsk      |       Owner:  ayust
    Type:  enhancement  |      Status:  assigned
Priority:  major        |   Milestone:  undecided
 Version:  0.8.3p1      |  Resolution:
Keywords:               |
------------------------+------------------------
Changes (by ayust):

 * owner:   => ayust
 * status:  new => assigned


Comment:

 Note to self, integrate this on Tuesday.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1813#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Feb 21 22:47:03 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 21 Feb 2011 22:47:03 -0000
Subject: [Buildbot-commits] [Buildbot] #1810: older versions of sqlite
 don't handle DDL changes between connections
In-Reply-To: <038.681ae3df2337646bf8427f98bb7802d9@buildbot.net>
References: <038.681ae3df2337646bf8427f98bb7802d9@buildbot.net>
Message-ID: <053.a7d0bd47298c9412cf2bf739b2fffb9a@buildbot.net>

#1810: older versions of sqlite don't handle DDL changes between connections
---------------------+--------------------
Reporter:  dustin    |       Owner:
    Type:  defect    |      Status:  new
Priority:  major     |   Milestone:  0.8.4
 Version:  master    |  Resolution:
Keywords:  database  |
---------------------+--------------------

Comment (by dustin):

 the reply is
  You should close the cursor after executing PRAGMA table_info('foo'). You
 cannot modify database schema while there are still outstanding statements
 (on the same or other connections).

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1810#comment:6>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Feb 22 04:12:35 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 22 Feb 2011 04:12:35 -0000
Subject: [Buildbot-commits] [Buildbot] #1817: master should ping slaves
Message-ID: <043.7cf11f5b71690dcb4a8e436ed52b1381@buildbot.net>

#1817: master should ping slaves
------------------------+-------------------
Reporter:  PiotrSikora  |      Owner:
    Type:  enhancement  |     Status:  new
Priority:  minor        |  Milestone:  0.8.4
 Version:  0.8.3p1      |   Keywords:
------------------------+-------------------
 Currently master doesn't ping slaves, which means that if slave will lose
 network connectivity then master won't know about it until it tries to
 execute any command on the slave.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1817>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Feb 22 04:21:28 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 22 Feb 2011 04:21:28 -0000
Subject: [Buildbot-commits] [Buildbot] #1818: sqlalchemy-migrate uses full
 paths in the 'migrate_version' database table
Message-ID: <038.ecd1553f82421bf6df35851d7bf005b4@buildbot.net>

#1818: sqlalchemy-migrate uses full paths in the 'migrate_version' database table
--------------------+----------------------
Reporter:  dustin   |      Owner:
    Type:  defect   |     Status:  new
Priority:  minor    |  Milestone:  0.8.+
 Version:  0.8.3p1  |   Keywords:  database
--------------------+----------------------
 This will make buildmasters non-relocatable.  I don't know if this will be
 a problem for anyone, so this is currently a low-priority bug.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1818>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Feb 22 04:24:12 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 22 Feb 2011 04:24:12 -0000
Subject: [Buildbot-commits] [Buildbot] #1819: MailDirService should handle
 renaming files, rather than subclasses
Message-ID: <038.b654d701e23765a7d909f3ce73410d09@buildbot.net>

#1819: MailDirService should handle renaming files, rather than subclasses
------------------------+-------------------
Reporter:  dustin       |      Owner:
    Type:  enhancement  |     Status:  new
Priority:  minor        |  Milestone:  0.8.4
 Version:  master       |   Keywords:
------------------------+-------------------
 There's an elaborate little dance that both subclasses of !MailDirService
 do to rename files out of the 'new' directory.  That should be written
 on.ce

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1819>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Feb 22 04:25:37 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 22 Feb 2011 04:25:37 -0000
Subject: [Buildbot-commits] [Buildbot] #1820: store configuration values in
	self.master.config
Message-ID: <038.d73b9124a0c220076348d7da9bda8fbe@buildbot.net>

#1820: store configuration values in self.master.config
------------------------+-------------------
Reporter:  dustin       |      Owner:
    Type:  enhancement  |     Status:  new
Priority:  major        |  Milestone:  0.8.+
 Version:  master       |   Keywords:
------------------------+-------------------
 The configuration dictionary should be available as attributes from
 {{{self.master.config}}}, so that any code that needs access to
 configuration values can just go get them.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1820>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Feb 22 04:27:28 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 22 Feb 2011 04:27:28 -0000
Subject: [Buildbot-commits] [Buildbot] #1821: scheduler usability
	improvements
Message-ID: <038.38073a6e2654ee7a291ee089b013a6d2@buildbot.net>

#1821: scheduler usability improvements
------------------------+-------------------
Reporter:  dustin       |      Owner:
    Type:  enhancement  |     Status:  new
Priority:  major        |  Milestone:  0.8.4
 Version:  master       |   Keywords:
------------------------+-------------------
 * periodic and nightly should accept repository/project args to set on new
 builds
  * clarify that the branch= argument for !SingleBranchScheduler
    specifies the branch to *build*, and in the absence of a !ChangeFilter,
 the
    branch to look for

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1821>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Feb 22 04:29:36 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 22 Feb 2011 04:29:36 -0000
Subject: [Buildbot-commits] [Buildbot] #1822: Support schedulers "claiming"
	their schedulerid
Message-ID: <038.dc5a8ef119444049494f81c927fed200@buildbot.net>

#1822: Support schedulers "claiming" their schedulerid
------------------------+----------------------
Reporter:  dustin       |      Owner:
    Type:  enhancement  |     Status:  new
Priority:  major        |  Milestone:  0.8.+
 Version:  master       |   Keywords:  database
------------------------+----------------------
 Currently, Buildbot will not notice if you have the same scheduler running
 on multiple masters, although it will cause great unhappiness.  The
 schedulers should claim their schedulerid using some kind of transactional
 process that can ensure only one instance of a scheduler is running at any
 time.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1822>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Feb 22 04:31:56 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 22 Feb 2011 04:31:56 -0000
Subject: [Buildbot-commits] [Buildbot] #1823: Verify interaction of
 Dependent scheduler with retried builds
Message-ID: <038.9abe79edb4412b68e022bd51a0a2fcf0@buildbot.net>

#1823: Verify interaction of Dependent scheduler with retried builds
------------------------+-------------------
Reporter:  dustin       |      Owner:
    Type:  enhancement  |     Status:  new
Priority:  critical     |  Milestone:  0.8.4
 Version:  master       |   Keywords:
------------------------+-------------------
 * does the scheduler trigger a downstream build on RETRY?
  * does it trigger a downstream build when the retried build is OK?

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1823>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Feb 22 04:33:16 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 22 Feb 2011 04:33:16 -0000
Subject: [Buildbot-commits] [Buildbot] #1824: Dependent build depends on
	scheduler property
Message-ID: <038.5e9d2be315d14148cde444957abc6f92@buildbot.net>

#1824: Dependent build depends on scheduler property
------------------------+----------------------
Reporter:  dustin       |      Owner:
    Type:  enhancement  |     Status:  new
Priority:  critical     |  Milestone:  0.8.4
 Version:  master       |   Keywords:  database
------------------------+----------------------
 In general, no part of Buildbot has depended on properties except for the
 got_revision property, and that's ugly.  But Dependent is using properties
 to figure out if a newly submitted buildset is from its upstream
 scheduler.  Is there a better way?

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1824>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Feb 22 04:37:13 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 22 Feb 2011 04:37:13 -0000
Subject: [Buildbot-commits] [Buildbot] #1825: Nightly scheduler should use a
 smarter algorithm to find the next time
Message-ID: <038.9230397741f016ec165d088d9e530123@buildbot.net>

#1825: Nightly scheduler should use a smarter algorithm to find the next time
------------------------+-------------------
Reporter:  dustin       |      Owner:
    Type:  enhancement  |     Status:  new
Priority:  major        |  Milestone:  0.8.+
 Version:  master       |   Keywords:
------------------------+-------------------
 The current algorithm is to scan minute by minute for the next matching
 time, which is not efficient at all!

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1825>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Feb 22 04:38:38 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 22 Feb 2011 04:38:38 -0000
Subject: [Buildbot-commits] [Buildbot] #1826: Periodic scheduler should not
 necessarily run at master startup
Message-ID: <038.b1d9295a21989a6d1befac025c8a21e0@buildbot.net>

#1826: Periodic scheduler should not necessarily run at master startup
------------------------+-------------------
Reporter:  dustin       |      Owner:
    Type:  enhancement  |     Status:  new
Priority:  minor        |  Milestone:  0.8.+
 Version:  master       |   Keywords:
------------------------+-------------------
 The Periodic scheduler runs immediately when it starts.  It should have an
 option, similar to !LoopingCall's {{{now=}}}, to skip this run and merely
 start its timer at startup.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1826>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Feb 22 09:53:59 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 22 Feb 2011 09:53:59 -0000
Subject: [Buildbot-commits] [Buildbot] #1827: Make graceful shutdown a
	buildbot command
Message-ID: <035.0e49a5e0b9b88be7892ca41082c5f07e@buildbot.net>

#1827: Make graceful shutdown a buildbot command
----------------------+-----------------------
Reporter:  mjw        |      Owner:
    Type:  undecided  |     Status:  new
Priority:  major      |  Milestone:  undecided
 Version:  0.8.3p1    |   Keywords:
----------------------+-----------------------
 Currently you can only do a graceful shutdown of the buildbot through the
 web status page. It would be nice to be able to do it through the command
 line too. Just like you can do a buildbot reconfig (if that fails you
 often want a graceful shutdown or even graceful restart to happen).

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1827>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Feb 22 09:58:51 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 22 Feb 2011 09:58:51 -0000
Subject: [Buildbot-commits] [Buildbot] #1827: Make graceful shutdown a
	buildbot command
In-Reply-To: <035.0e49a5e0b9b88be7892ca41082c5f07e@buildbot.net>
References: <035.0e49a5e0b9b88be7892ca41082c5f07e@buildbot.net>
Message-ID: <050.4d773b3505057d96418a4bf67367ab78@buildbot.net>

#1827: Make graceful shutdown a buildbot command
----------------------+------------------------
Reporter:  mjw        |       Owner:  ayust
    Type:  undecided  |      Status:  assigned
Priority:  major      |   Milestone:  undecided
 Version:  0.8.3p1    |  Resolution:
Keywords:             |
----------------------+------------------------
Changes (by ayust):

 * owner:   => ayust
 * status:  new => assigned


-- 
Ticket URL: <http://trac.buildbot.net/ticket/1827#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Feb 22 09:59:08 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 22 Feb 2011 09:59:08 -0000
Subject: [Buildbot-commits] [Buildbot] #1827: Make graceful shutdown a
	buildbot command
In-Reply-To: <035.0e49a5e0b9b88be7892ca41082c5f07e@buildbot.net>
References: <035.0e49a5e0b9b88be7892ca41082c5f07e@buildbot.net>
Message-ID: <050.5e5af0c28a000dc6b9e91be630caef2c@buildbot.net>

#1827: Make graceful shutdown a buildbot command
------------------------+------------------------
Reporter:  mjw          |       Owner:  ayust
    Type:  enhancement  |      Status:  assigned
Priority:  major        |   Milestone:  undecided
 Version:  0.8.3p1      |  Resolution:
Keywords:               |
------------------------+------------------------
Changes (by ayust):

 * type:  undecided => enhancement


-- 
Ticket URL: <http://trac.buildbot.net/ticket/1827#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Feb 22 16:31:14 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 22 Feb 2011 16:31:14 -0000
Subject: [Buildbot-commits] [Buildbot] #1828: buildbot utilities should be
	separate package
Message-ID: <038.0d6ac88a02be7f4801831dfee30c607b@buildbot.net>

#1828: buildbot utilities should be separate package
------------------------+-------------------
Reporter:  dustin       |      Owner:
    Type:  enhancement  |     Status:  new
Priority:  minor        |  Milestone:  0.9.+
 Version:  master       |   Keywords:
------------------------+-------------------
 There are a few buildbot commands that are commonly needed outside of the
 Buildbot source, and those should be installable without Buildbot itself:
  * buildbot sendchange
  * buildbot try
  * debug client

 these should be split off into one (or even a few?) very small sub-
 packages

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1828>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Feb 22 16:34:30 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 22 Feb 2011 16:34:30 -0000
Subject: [Buildbot-commits] [Buildbot] #1829: PBChangeSource loses string
	encodings
Message-ID: <038.41f0798f20411d2d3d87b3680817ccc5@buildbot.net>

#1829: PBChangeSource loses string encodings
-------------------+----------------------
Reporter:  dustin  |      Owner:
    Type:  defect  |     Status:  new
Priority:  minor   |  Milestone:  0.8.4
 Version:  master  |   Keywords:  encoding
-------------------+----------------------
 If you run 'buildbot sendchange' and pass utf-8 strings on the command
 line, they will arrive as bytestrings on the PBChangeSource, and great
 sadness will ensue:

 {{{
 2011-02-22 13:46:58+0000 [Broker,5,172.31.17.193] perspective_addChange
 called
 2011-02-22 13:46:58+0000 [Broker,5,172.31.17.193] Peer will receive
 following PB
  traceback:
 2011-02-22 13:46:58+0000 [Broker,5,172.31.17.193] Unhandled Error
         Traceback (most recent call last):
           File "/usr/lib/python2.6/dist-
 packages/twisted/spread/banana.py", line
  153, in gotItem
             self.callExpressionReceived(item)
           File "/usr/lib/python2.6/dist-
 packages/twisted/spread/banana.py", line
  116, in callExpressionReceived
             self.expressionReceived(obj)
           File "/usr/lib/python2.6/dist-packages/twisted/spread/pb.py",
 line 514
 , in expressionReceived
             method(*sexp[1:])
           File "/usr/lib/python2.6/dist-packages/twisted/spread/pb.py",
 line 826
 , in proto_message
             self._recvMessage(self.localObjectForID, requestID, objectID,
 messag
 e, answerRequired, netArgs, netKw)
         --- <exception caught here> ---
           File "/usr/lib/python2.6/dist-packages/twisted/spread/pb.py",
 line 840
 , in _recvMessage
             netResult = object.remoteMessageReceived(self, message,
 netArgs, net
 Kw)
           File "/usr/lib/python2.6/dist-packages/twisted/spread/pb.py",
 line 225
 , in perspectiveMessageReceived
             state = method(*args, **kw)
           File "/usr/local/lib/python2.6/dist-
 packages/buildbot/changes/pb.py",
 line 58, in perspective_addChange
             self.changemaster.addChange(change)
           File "/usr/local/lib/python2.6/dist-
 packages/buildbot/changes/manager.
 py", line 82, in addChange
             change.comments, change.category, change.project))
         exceptions.UnicodeDecodeError: 'ascii' codec can't decode byte
 0xc3 in p
 osition 27: ordinal not in range(128)

 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1829>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Feb 22 16:37:02 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 22 Feb 2011 16:37:02 -0000
Subject: [Buildbot-commits] [Buildbot] #1829: PBChangeSource loses
	string encodings
In-Reply-To: <038.41f0798f20411d2d3d87b3680817ccc5@buildbot.net>
References: <038.41f0798f20411d2d3d87b3680817ccc5@buildbot.net>
Message-ID: <053.cb5a2079b0f9e08735dda45761441eaa@buildbot.net>

#1829: PBChangeSource loses string encodings
---------------------+--------------------
Reporter:  dustin    |       Owner:
    Type:  defect    |      Status:  new
Priority:  minor     |   Milestone:  0.8.4
 Version:  master    |  Resolution:
Keywords:  encoding  |
---------------------+--------------------
Changes (by mjw):

 * cc: mark@? (added)


-- 
Ticket URL: <http://trac.buildbot.net/ticket/1829#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Feb 22 16:38:43 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 22 Feb 2011 16:38:43 -0000
Subject: [Buildbot-commits] [Buildbot] #1829: PBChangeSource loses
	string encodings
In-Reply-To: <038.41f0798f20411d2d3d87b3680817ccc5@buildbot.net>
References: <038.41f0798f20411d2d3d87b3680817ccc5@buildbot.net>
Message-ID: <053.f9da28a47a25b9f0b731d99327a39f4d@buildbot.net>

#1829: PBChangeSource loses string encodings
---------------------+--------------------
Reporter:  dustin    |       Owner:
    Type:  defect    |      Status:  new
Priority:  minor     |   Milestone:  0.8.4
 Version:  master    |  Resolution:
Keywords:  encoding  |
---------------------+--------------------

Comment (by dustin):

 I suspect that the right solution here is to allow the sendchange user to
 specify an encoding for the command line (defaulting to the Python
 filesystem encoding?), and decode from that encoding to unicode strings
 before sending to PBChangeSource.

 I don't recall how well PB handles unicode, so that should be tested in a
 unit test that will detect any failures in older versions.

 PBChangeSource should be resilient by trying to decode any raw bytestrings
 it receives as ascii with replacement.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1829#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Tue Feb 22 20:12:51 2011
From: noreply at github.com (noreply at github.com)
Date: Tue, 22 Feb 2011 12:12:51 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] 074428: Improve grid/tgrid
	performance.
Message-ID: <20110222201251.BE83B421F4@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 074428d5a2dd395293e41d82739bca6a5bb08aff
    https://github.com/buildbot/buildbot/commit/074428d5a2dd395293e41d82739bca6a5bb08aff
Author: Amber Yust <ayust at yelp.com>
Date:   2011-02-22 (Tue, 22 Feb 2011)

Changed paths:
  M master/buildbot/status/web/grid.py

Log Message:
-----------
Improve grid/tgrid performance.

Patch diff submitted by alvarsk (Closes #1813):

Instead of collecting all unique SourceStamps from all builders and then taking last numBuilds sourcestamps, the code now takes only last numBuilds Builds/SourceStamps from each builder.

This improves performance from 15 seconds with default caching options (18 builders, 1100 builds) to under a second.





From nobody at buildbot.net  Tue Feb 22 20:12:58 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 22 Feb 2011 20:12:58 -0000
Subject: [Buildbot-commits] [Buildbot] #1813: Grid and T-Grid performance
In-Reply-To: <039.477df23688cdc5e02e1ceaf762a6af66@buildbot.net>
References: <039.477df23688cdc5e02e1ceaf762a6af66@buildbot.net>
Message-ID: <054.a82cf66b9f257938365c52ccdf079e11@buildbot.net>

#1813: Grid and T-Grid performance
------------------------+------------------------
Reporter:  aivarsk      |       Owner:  ayust
    Type:  enhancement  |      Status:  closed
Priority:  major        |   Milestone:  undecided
 Version:  0.8.3p1      |  Resolution:  fixed
Keywords:               |
------------------------+------------------------
Changes (by Amber Yust):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 Improve grid/tgrid performance.

 Patch diff submitted by alvarsk (Closes #1813):

 Instead of collecting all unique SourceStamps from all builders and then
 taking last numBuilds sourcestamps, the code now takes only last numBuilds
 Builds/SourceStamps from each builder.

 This improves performance from 15 seconds with default caching options (18
 builders, 1100 builds) to under a second.
  Changeset: 074428d5a2dd395293e41d82739bca6a5bb08aff

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1813#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Tue Feb 22 23:53:11 2011
From: nobody at buildbot.net (Buildbot)
Date: Tue, 22 Feb 2011 23:53:11 -0000
Subject: [Buildbot-commits] [Buildbot] #1830: ER : Add a warning for
 logfiles if the log file does not exist or is not found
Message-ID: <039.372e33a57b836ef962d4796cba2c0ee3@buildbot.net>

#1830: ER : Add a warning for logfiles if the log file does not exist or is not
found
------------------------+------------------------------------
Reporter:  darshie      |      Owner:
    Type:  enhancement  |     Status:  new
Priority:  major        |  Milestone:  undecided
 Version:  0.8.3        |   Keywords:  shellCommand, logfiles
------------------------+------------------------------------
 I've noticed that there is no warning in the logs if i try to read a log
 file from disk using logfiles.

 f.addStep(ShellCommand(
                         command=["make", "test"],
                         logfiles={"disk_log":
 "/slavebot/testbuild/test.log"}))

 In this case if the file cannot be found, an empty file called test.log
 will be created and added to the waterfall page.

 Would be useful to have a warning in the logs so is possible to know if
 the file exist or not, and troubleshoot why a log file is not displayed in
 the waterfall page, instead than just showing an empty file.

 Thanks

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1830>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Feb 23 01:48:39 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 23 Feb 2011 01:48:39 -0000
Subject: [Buildbot-commits] [Buildbot] #1831: support recording username for
	web clicks
Message-ID: <038.9e41b01353390cce49c1d029e452bb7c@buildbot.net>

#1831: support recording username for web clicks
------------------------+-------------------
Reporter:  dustin       |      Owner:
    Type:  enhancement  |     Status:  new
Priority:  major        |  Milestone:  0.9.+
 Version:  master       |   Keywords:
------------------------+-------------------
 from comments:
 {{{
         # TODO: if we can authenticate that a particular User pushed the
         # button, use their name instead of None, so they'll be informed
 of
         # the results.
         # TODO2: we can authenticate that a particular User pushed the
 button
         # now, so someone can write this support. but it requires a
         # buildbot.changes.changes.Change instance which is tedious at
 this
         # stage to compute
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1831>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Wed Feb 23 03:51:13 2011
From: noreply at github.com (noreply at github.com)
Date: Tue, 22 Feb 2011 19:51:13 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] 1a80c3: Rewrite scheduler
	implementations for efficiency
Message-ID: <20110223035113.12393422BF@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 1a80c3cfccdf066dbab9331723e4fcba07066366
    https://github.com/buildbot/buildbot/commit/1a80c3cfccdf066dbab9331723e4fcba07066366
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-22 (Tue, 22 Feb 2011)

Changed paths:
  M master/NEWS
  M master/buildbot/changes/base.py
  M master/buildbot/db/buildsets.py
  M master/buildbot/db/changes.py
  M master/buildbot/db/connector.py
  A master/buildbot/db/migrate/versions/008_add_scheduler_changes_index.py
  M master/buildbot/db/model.py
  M master/buildbot/db/pool.py
  M master/buildbot/db/schedulers.py
  M master/buildbot/interfaces.py
  M master/buildbot/master.py
  M master/buildbot/process/builder.py
  M master/buildbot/process/properties.py
  M master/buildbot/scheduler.py
  M master/buildbot/schedulers/base.py
  M master/buildbot/schedulers/basic.py
  A master/buildbot/schedulers/dependent.py
  M master/buildbot/schedulers/manager.py
  M master/buildbot/schedulers/timed.py
  M master/buildbot/schedulers/triggerable.py
  M master/buildbot/schedulers/trysched.py
  M master/buildbot/scripts/runner.py
  M master/buildbot/sourcestamp.py
  M master/buildbot/status/web/build.py
  M master/buildbot/status/web/builder.py
  M master/buildbot/status/words.py
  M master/buildbot/steps/trigger.py
  M master/buildbot/test/fake/fakedb.py
  M master/buildbot/test/integration/test_upgrade.py
  M master/buildbot/test/regressions/test_import_unicode_changes.py
  M master/buildbot/test/unit/test_changes_base.py
  M master/buildbot/test/unit/test_db_buildsets.py
  M master/buildbot/test/unit/test_db_connector.py
  M master/buildbot/test/unit/test_db_schedulers.py
  M master/buildbot/test/unit/test_master.py
  M master/buildbot/test/unit/test_oldpaths.py
  A master/buildbot/test/unit/test_schedulers_base.py
  A master/buildbot/test/unit/test_schedulers_basic.py
  R master/buildbot/test/unit/test_schedulers_basic_Scheduler.py
  A master/buildbot/test/unit/test_schedulers_dependent.py
  A master/buildbot/test/unit/test_schedulers_manager.py
  A master/buildbot/test/unit/test_schedulers_timed_Nightly.py
  A master/buildbot/test/unit/test_schedulers_timed_Periodic.py
  A master/buildbot/test/unit/test_schedulers_timed_Timed.py
  A master/buildbot/test/unit/test_schedulers_triggerable.py
  A master/buildbot/test/unit/test_schedulers_trysched.py
  A master/buildbot/test/util/scheduler.py
  M master/docs/cfg-schedulers.texinfo

Log Message:
-----------
Rewrite scheduler implementations for efficiency

* use the new database interface, based on sqlalchemy
* schedulers no longer poll individually, but rely on the master
  to poll in multi-master configurations, or on change subscriptions in
  a single-master configuration
* several schedulers move to new Python modules
* fakedb enhanced with fake implementations of db connector components
* significantly more tests, with complete coverage of new code


Commit: 1144d629a6952c94dead8639dfedf9a3bff372ed
    https://github.com/buildbot/buildbot/commit/1144d629a6952c94dead8639dfedf9a3bff372ed
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-22 (Tue, 22 Feb 2011)

Changed paths:
  M master/buildbot/process/builder.py

Log Message:
-----------
correctly specify properties when rebuilding


Commit: d9b4cc8a36224eb2e6c7105c269b72e75507b8e1
    https://github.com/buildbot/buildbot/commit/d9b4cc8a36224eb2e6c7105c269b72e75507b8e1
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-22 (Tue, 22 Feb 2011)

Changed paths:
  M master/buildbot/test/fake/fakedb.py

Log Message:
-----------
don't use Thunk quite so liberally


Commit: fbfbe6a784c61396784d5d7b8970c8a300901809
    https://github.com/buildbot/buildbot/commit/fbfbe6a784c61396784d5d7b8970c8a300901809
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-22 (Tue, 22 Feb 2011)

Changed paths:
  M master/buildbot/master.py
  M master/buildbot/test/unit/test_master.py

Log Message:
-----------
shorten subscription attribute names for readability


Commit: 1f4d6d5c1721dbf30bf1419263f4577e377db6c8
    https://github.com/buildbot/buildbot/commit/1f4d6d5c1721dbf30bf1419263f4577e377db6c8
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-22 (Tue, 22 Feb 2011)

Changed paths:
  M master/docs/cfg-schedulers.texinfo

Log Message:
-----------
fix typo





From noreply at github.com  Wed Feb 23 06:17:35 2011
From: noreply at github.com (noreply at github.com)
Date: Tue, 22 Feb 2011 22:17:35 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] 39b971: Avoid yield-in-try,
	which is not py24-compatible
Message-ID: <20110223061734.F0D92422CC@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 39b971bcb48e02dc9718b7742d0860f8a0700f18
    https://github.com/buildbot/buildbot/commit/39b971bcb48e02dc9718b7742d0860f8a0700f18
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-22 (Tue, 22 Feb 2011)

Changed paths:
  M master/buildbot/schedulers/timed.py

Log Message:
-----------
Avoid yield-in-try, which is not py24-compatible





From nobody at buildbot.net  Wed Feb 23 06:35:15 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 23 Feb 2011 06:35:15 -0000
Subject: [Buildbot-commits] [Buildbot] #1832: GitPoller unhandled error on
	adding a change
Message-ID: <046.1580261d7ececbba4e1cf2e7e15be043@buildbot.net>

#1832: GitPoller unhandled error on adding a change
----------------------------+----------------------------
Reporter:  davidholsgrove   |      Owner:
    Type:  support-request  |     Status:  new
Priority:  major            |  Milestone:  undecided
 Version:  0.8.3p1          |   Keywords:  git, gitpoller
----------------------------+----------------------------
 Hi,

 I have implemented a set of 4 gitpoller's, pointing to different local git
 repos (eventually to be hosted) which point to 3 lists of builders (2 of
 the repos point to the same set of builders - ie these builders should
 build if there are changes to either repo).

 The gitpollers all have their own workdir and point to the 4 different
 repo_urls, giving an arrangement like this;

 {{{
    GitPoller 1   |   GitPoller 2   |   GitPoller 3   |   GitPoller 4
         |                    \           /                    |
     builder 1                  builder 2                  builder 3
 }}}
 The gitpollers register the correct changesources and appear to be
 processing any changes correctly;

 {{{
 2011-02-23 16:20:42+1000 [-] adding 4 new changesources, removing 0
 2011-02-23 16:20:42+1000 [-] gitpoller: polling git repo at
 file:///home/buildbot/petalinux_modular/bld_components/gnu_tools/.git
 2011-02-23 16:20:42+1000 [-] gitpoller: polling git repo at
 file:///home/buildbot/petalinux_modular/bld_components/toolchains/.git
 2011-02-23 16:20:42+1000 [-] gitpoller: polling git repo at
 file:///home/buildbot/petalinux_modular/bld_components/qemu/.git
 2011-02-23 16:20:42+1000 [-] gitpoller: polling git repo at
 file:///home/buildbot/petalinux_modular/bld_components/gdb/.git

 2011-02-23 16:20:42+1000 [-] gitpoller: processing 0 changes: [] in
 "/tmp/gitpoller_work/CENTOSx86/GNU_Tools/master"
 2011-02-23 16:20:42+1000 [-] gitpoller: no changes, no catch_up
 2011-02-23 16:20:42+1000 [-] gitpoller: processing 0 changes: [] in
 "/tmp/gitpoller_work/CENTOSx86/Toolchains/master"
 2011-02-23 16:20:42+1000 [-] gitpoller: no changes, no catch_up
 2011-02-23 16:20:42+1000 [-] gitpoller: processing 0 changes: [] in
 "/tmp/gitpoller_work/CENTOSx86/QEMU/master"
 2011-02-23 16:20:42+1000 [-] gitpoller: no changes, no catch_up
 2011-02-23 16:20:42+1000 [-] gitpoller: processing 0 changes: [] in
 "/tmp/gitpoller_work/CENTOSx86/GDB/master"
 2011-02-23 16:20:42+1000 [-] gitpoller: no changes, no catch_up
 }}}

 but a change does occur on a repo, the following is seen in the logs;

 {{{
 2011-02-23 16:30:53+1000 [-] gitpoller: processing 1 changes:
 ['7e41cd8aca3fe3c522adbae34fff0425ce8c1a34'] in
 "/tmp/gitpoller_work/CENTOSx86/GNU_Tools/master"
 2011-02-23 16:30:53+1000 [-] gitpoller: _add_change results: "[(True,
 1298442055.0), (True, 'buildbot at dholsgrove-Ubuntu104.(none)'), (True,
 ['src/busybox/Makefile']), (True, 'Add empty line to trigger build via git
 poller')]", rev: "7e41cd8aca3fe3c522adbae34fff0425ce8c1a34" in
 "/tmp/gitpoller_work/CENTOSx86/GNU_Tools/master"
 2011-02-23 16:30:53+1000 [-] gitpoller: change
 "<buildbot.changes.changes.Change instance at 0xa1036ec>" in
 "/tmp/gitpoller_work/CENTOSx86/GNU_Tools/master"
 2011-02-23 16:30:53+1000 [-] adding change, who buildbot at dholsgrove-
 Ubuntu104.(none), 1 files, rev=7e41cd8aca3fe3c522adbae34fff0425ce8c1a34,
 branch=master,
 repository=file:///home/buildbot/petalinux_modular/bld_components/gnu_tools/.git,
 comments Add empty line to trigger build via git poller, category None,
 project ['GNU_Tools [CENTOSx86 - master branch]']
 2011-02-23 16:30:53+1000 [-] gitpoller: repo poll failed
 2011-02-23 16:30:53+1000 [-] Unhandled Error
         Traceback (most recent call last):
           File "/usr/local/lib/python2.6/dist-
 packages/Twisted-10.2.0-py2.6-linux-i686.egg/twisted/internet/defer.py",
 line 361, in callback
             self._startRunCallbacks(result)
           File "/usr/local/lib/python2.6/dist-
 packages/Twisted-10.2.0-py2.6-linux-i686.egg/twisted/internet/defer.py",
 line 455, in _startRunCallbacks
             self._runCallbacks()
           File "/usr/local/lib/python2.6/dist-
 packages/Twisted-10.2.0-py2.6-linux-i686.egg/twisted/internet/defer.py",
 line 542, in _runCallbacks
             current.result = callback(current.result, *args, **kw)
           File "/usr/local/lib/python2.6/dist-
 packages/Twisted-10.2.0-py2.6-linux-i686.egg/twisted/internet/defer.py",
 line 891, in gotResult
             _deferGenerator(g, deferred)
         --- <exception caught here> ---
           File "/usr/local/lib/python2.6/dist-
 packages/Twisted-10.2.0-py2.6-linux-i686.egg/twisted/internet/defer.py",
 line 866, in _deferGenerator
             result = g.next()
           File "/usr/local/lib/python2.6/dist-
 packages/buildbot-0.8.3p1-py2.6.egg/buildbot/changes/gitpoller.py", line
 207, in _process_changes_in_output
             wfd.getResult()
           File "/usr/local/lib/python2.6/dist-
 packages/Twisted-10.2.0-py2.6-linux-i686.egg/twisted/internet/defer.py",
 line 845, in getResult
             self.result.raiseException()
           File "/usr/local/lib/python2.6/dist-
 packages/Twisted-10.2.0-py2.6-linux-i686.egg/twisted/internet/defer.py",
 line 542, in _runCallbacks
             current.result = callback(current.result, *args, **kw)
           File "/usr/local/lib/python2.6/dist-
 packages/buildbot-0.8.3p1-py2.6.egg/buildbot/changes/gitpoller.py", line
 223, in _add_change
             self.parent.addChange(c)
           File "/usr/local/lib/python2.6/dist-
 packages/buildbot-0.8.3p1-py2.6.egg/buildbot/changes/manager.py", line 88,
 in addChange
             self.parent.addChange(change)
           File "/usr/local/lib/python2.6/dist-
 packages/buildbot-0.8.3p1-py2.6.egg/buildbot/master.py", line 1246, in
 addChange
             self.db.addChangeToDatabase(change)
           File "/usr/local/lib/python2.6/dist-
 packages/buildbot-0.8.3p1-py2.6.egg/buildbot/db/connector.py", line 282,
 in addChangeToDatabase
             self.runInteractionNow(self._txn_addChangeToDatabase, change)
           File "/usr/local/lib/python2.6/dist-
 packages/buildbot-0.8.3p1-py2.6.egg/buildbot/db/connector.py", line 188,
 in runInteractionNow
             return self._runInteractionNow(interaction, *args, **kwargs)
           File "/usr/local/lib/python2.6/dist-
 packages/buildbot-0.8.3p1-py2.6.egg/buildbot/db/connector.py", line 213,
 in _runInteractionNow
             result = interaction(c, *args, **kwargs)
           File "/usr/local/lib/python2.6/dist-
 packages/buildbot-0.8.3p1-py2.6.egg/buildbot/db/connector.py", line 300,
 in _txn_addChangeToDatabase
             t.execute(q, values)
           File "/usr/local/lib/python2.6/dist-
 packages/buildbot-0.8.3p1-py2.6.egg/buildbot/db/dbspec.py", line 81, in
 execute
             result = self.cursor.execute(*args, **kw)
         sqlite3.InterfaceError: Error binding parameter 9 - probably
 unsupported type.

 2011-02-23 16:30:53+1000 [-] gitpoller: catching up to FETCH_HEAD
 }}}


 What could cause such an unhandled error? I've previously used svnpoller
 in a similar manner and it was fine?

 thanks,

 david

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1832>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Feb 23 07:04:03 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 23 Feb 2011 07:04:03 -0000
Subject: [Buildbot-commits] [Buildbot] #1833: test for left-open database
	cursors
Message-ID: <038.309c689915c8cfa297619261088b1af3@buildbot.net>

#1833: test for left-open database cursors
---------------------+-----------------------------
Reporter:  dustin    |      Owner:  dustin
    Type:  defect    |     Status:  new
Priority:  critical  |  Milestone:  0.8.4
 Version:  0.8.3p1   |   Keywords:  database, tests
---------------------+-----------------------------
 Or find some way to prevent them.  A leftover cursor can result in
 "database locked" errors, which I saw on the inaugural run of the
 metabuildbot on the scheduler/sqlalchemy commits.

 {{{
 2011-02-23 07:35:37+0100 [-] while rebuilding a build
         Traceback (most recent call last):
           File "/usr/lib/python2.6/threading.py", line 504, in __bootstrap
             self.__bootstrap_inner()
           File "/usr/lib/python2.6/threading.py", line 532, in
 __bootstrap_inner
             self.run()
           File "/usr/lib/python2.6/threading.py", line 484, in run
             self.__target(*self.__args, **self.__kwargs)
         --- <exception caught here> ---
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/twisted/python/threadpool.py", line 207, in _worker
             result = context.call(ctx, function, *args, **kwargs)
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/twisted/python/context.py", line 59, in callWithContext
             return self.currentContext().callWithContext(ctx, func, *args,
 **kw)
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/twisted/python/context.py", line 37, in callWithContext
             return func(*args,**kw)
           File
 "/home/buildbot/metabuildbot/src/master/buildbot/db/pool.py", line 91, in
 thd
             rv = callable(conn, *args, **kwargs)
           File
 "/home/buildbot/metabuildbot/src/master/buildbot/db/sourcestamps.py", line
 53, in thd
             project=project))
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/sqlalchemy/engine/base.py", line 1191, in execute
             params)
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/sqlalchemy/engine/base.py", line 1271, in _execute_clauseelement
             return self.__execute_context(context)
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/sqlalchemy/engine/base.py", line 1315, in __execute_context
             self._commit_impl()
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/sqlalchemy/engine/base.py", line 1100, in _commit_impl
             self._handle_dbapi_exception(e, None, None, None, None)
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/sqlalchemy/engine/base.py", line 1097, in _commit_impl
             self.engine.dialect.do_commit(self.connection)
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/sqlalchemy/engine/default.py", line 275, in do_commit
             connection.commit()
         sqlalchemy.exc.OperationalError: (OperationalError) database is
 locked None None
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1833>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Feb 23 07:04:55 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 23 Feb 2011 07:04:55 -0000
Subject: [Buildbot-commits] [Buildbot] #1833: test for left-open
	database cursors
In-Reply-To: <038.309c689915c8cfa297619261088b1af3@buildbot.net>
References: <038.309c689915c8cfa297619261088b1af3@buildbot.net>
Message-ID: <053.0b0da53442757029b2a2d140c0ed1ed8@buildbot.net>

#1833: test for left-open database cursors
----------------------------+---------------------
Reporter:  dustin           |       Owner:  dustin
    Type:  defect           |      Status:  new
Priority:  critical         |   Milestone:  0.8.4
 Version:  0.8.3p1          |  Resolution:
Keywords:  database, tests  |
----------------------------+---------------------

Comment (by dustin):

 See http://www.sqlite.org/cvstrac/wiki?p=DatabaseIsLocked for reference.
 And know that exarkun was right!

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1833#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Feb 23 07:04:58 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 23 Feb 2011 07:04:58 -0000
Subject: [Buildbot-commits] [Buildbot] #1834: forcing builds via IRC fails
	on master
Message-ID: <038.1d139354eb940381bc232aad6f75b1a5@buildbot.net>

#1834: forcing builds via IRC fails on master
---------------------+----------------------
Reporter:  dustin    |      Owner:
    Type:  defect    |     Status:  new
Priority:  critical  |  Milestone:  0.8.4
 Version:  master    |   Keywords:  database
---------------------+----------------------
 {{{
 2011-02-23 07:59:50+0100 [-] while forcing a build
         Traceback (most recent call last):
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/twisted/internet/base.py", line 1167, in mainLoop
             self.runUntilCurrent()
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/twisted/internet/base.py", line 762, in runUntilCurrent
             f(*a, **kw)
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/twisted/internet/defer.py", line 361, in callback
             self._startRunCallbacks(result)
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/twisted/internet/defer.py", line 455, in _startRunCallbacks
             self._runCallbacks()
         --- <exception caught here> ---
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/twisted/internet/defer.py", line 542, in _runCallbacks
             current.result = callback(current.result, *args, **kw)
           File
 "/home/buildbot/metabuildbot/src/master/buildbot/process/builder.py", line
 1004, in get_brs
             bss = BuildSetStatus(bsid, self.scheduler.master.status,
         exceptions.AttributeError: BuilderControl instance has no
 attribute 'scheduler'
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1834>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Feb 23 07:05:58 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 23 Feb 2011 07:05:58 -0000
Subject: [Buildbot-commits] [Buildbot] #1835: failure rendering grid on
	master
Message-ID: <038.c36ba6ceebeab0b5582843d79944ae20@buildbot.net>

#1835: failure rendering grid on master
---------------------+----------------------
Reporter:  dustin    |      Owner:
    Type:  defect    |     Status:  new
Priority:  critical  |  Milestone:  0.8.4
 Version:  master    |   Keywords:  database
---------------------+----------------------
 {{{
 2011-02-23 07:34:26+0100 [HTTPChannel,7,127.0.0.1] Unhandled Error
         Traceback (most recent call last):
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/twisted/protocols/basic.py", line 564, in dataReceived
             why = self.lineReceived(line)
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/twisted/web/http.py", line 1573, in lineReceived
             self.allContentReceived()
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/twisted/web/http.py", line 1641, in allContentReceived
             req.requestReceived(command, path, version)
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/twisted/web/http.py", line 807, in requestReceived
             self.process()
         --- <exception caught here> ---
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/twisted/web/server.py", line 125, in process
             self.render(resrc)
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/twisted/web/server.py", line 132, in render
             body = resrc.render(self)
           File
 "/home/buildbot/metabuildbot/src/master/buildbot/status/web/base.py", line
 274, in render
             data = self.content(request, ctx)
           File
 "/home/buildbot/metabuildbot/src/master/buildbot/status/web/grid.py", line
 230, in content
             stamps = self.getRecentSourcestamps(status, numBuilds,
 categories, branch)
           File
 "/home/buildbot/metabuildbot/src/master/buildbot/status/web/grid.py", line
 134, in getRecentSourcestamps
             ss = build.getSourceStamp(absolute=True)
         exceptions.AttributeError: 'NoneType' object has no attribute
 'getSourceStamp'
 }}}

 I stopped and started the master, and this did not occur the second time.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1835>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Feb 23 07:06:28 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 23 Feb 2011 07:06:28 -0000
Subject: [Buildbot-commits] [Buildbot] #1836: URI /changes/N fails on master
Message-ID: <038.9f2c98d4d0f766c527dc3dd40d7bad02@buildbot.net>

#1836: URI /changes/N fails on master
---------------------+----------------------
Reporter:  dustin    |      Owner:
    Type:  defect    |     Status:  new
Priority:  critical  |  Milestone:  0.8.4
 Version:  master    |   Keywords:  database
---------------------+----------------------
 {{{
 2011-02-23 07:45:32+0100 [HTTPChannel,21,127.0.0.1] Unhandled Error
         Traceback (most recent call last):
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/twisted/protocols/basic.py", line 564, in dataReceived
             why = self.lineReceived(line)
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/twisted/web/http.py", line 1573, in lineReceived
             self.allContentReceived()
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/twisted/web/http.py", line 1641, in allContentReceived
             req.requestReceived(command, path, version)
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/twisted/web/http.py", line 807, in requestReceived
             self.process()
         --- <exception caught here> ---
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/twisted/web/server.py", line 125, in process
             self.render(resrc)
           File "/home/buildbot/sandbox/lib/python2.6/site-
 packages/twisted/web/server.py", line 132, in render
             body = resrc.render(self)
         exceptions.AttributeError: Deferred instance has no attribute
 'render'
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1836>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Wed Feb 23 10:55:30 2011
From: nobody at buildbot.net (Buildbot)
Date: Wed, 23 Feb 2011 10:55:30 -0000
Subject: [Buildbot-commits] [Buildbot] #1837: "Using LogFiles in custom
 BuildSteps" example does not work
Message-ID: <044.84b63f7a13fb8fa096c31058c53b01dd@buildbot.net>

#1837: "Using LogFiles in custom BuildSteps" example does not work
-------------------------+-----------------------
Reporter:  thomaswayden  |      Owner:
    Type:  undecided     |     Status:  new
Priority:  major         |  Milestone:  undecided
 Version:  0.8.3p1       |   Keywords:
-------------------------+-----------------------
 The example given at http://buildbot.net/buildbot/docs/latest/BuildStep-
 LogFiles.html
 to filter the output of a BuildStep:

 {{{
          def createSummary(self, log):
              warnings = []
              for line in log.readlines():
                  if "warning:" in line:
                      warnings.append()
              self.addCompleteLog('warnings', "".join(warnings))
 }}}

 does not work.

 Instead you have to use log.getText() to get the text of the log.

 {{{
         sio = StringIO.StringIO( log.getText() )
         for line in sio.readlines():
 }}}

 would work.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1837>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Wed Feb 23 17:30:45 2011
From: noreply at github.com (noreply at github.com)
Date: Wed, 23 Feb 2011 09:30:45 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] d74ae9: Fix reading
	"change_properties" from the database.
Message-ID: <20110223173045.9E32042362@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: d74ae9e181a16aecbd8e8b40004a0775dd73efd6
    https://github.com/buildbot/buildbot/commit/d74ae9e181a16aecbd8e8b40004a0775dd73efd6
Author: Piotr Sikora <piotr.sikora at frickle.com>
Date:   2011-02-23 (Wed, 23 Feb 2011)

Changed paths:
  M master/buildbot/db/connector.py

Log Message:
-----------
Fix reading "change_properties" from the database.

Current code assumes that all properties are in ["value", "source"]
format, which is true for "buildset_properties" but isn't true for
"change_properties".

This means that builds for changes with properties (like everything
from GerritChangeSource) won't be executed.

It's actually more of a work-around than a fix.


Commit: f2739d6c7f69b59c8f590d6626378094cbbd794f
    https://github.com/buildbot/buildbot/commit/f2739d6c7f69b59c8f590d6626378094cbbd794f
Author: Piotr Sikora <piotr.sikora at frickle.com>
Date:   2011-02-23 (Wed, 23 Feb 2011)

Changed paths:
  M master/buildbot/db/connector.py

Log Message:
-----------
Remove surrounding quotes from value properties.


Commit: fb2150a9ff651357db0a0634432115cfd254f460
    https://github.com/buildbot/buildbot/commit/fb2150a9ff651357db0a0634432115cfd254f460
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-23 (Wed, 23 Feb 2011)

Changed paths:
  M master/buildbot/db/connector.py

Log Message:
-----------
Merge branch 'props-workaround' of git://github.com/PiotrSikora/buildbot

* 'props-workaround' of git://github.com/PiotrSikora/buildbot:
  Remove surrounding quotes from value properties.
  Fix reading "change_properties" from the database.


Commit: 23b015b54cbdf94d5ca723a241ffda1679131051
    https://github.com/buildbot/buildbot/commit/23b015b54cbdf94d5ca723a241ffda1679131051
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-23 (Wed, 23 Feb 2011)

Changed paths:
  M master/buildbot/db/connector.py
  M master/buildbot/test/unit/test_db_connector.py

Log Message:
-----------
fix workaround to not just strip quotes; add tests





From noreply at github.com  Thu Feb 24 01:20:06 2011
From: noreply at github.com (noreply at github.com)
Date: Wed, 23 Feb 2011 17:20:06 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] 1c1c9a: Add option to
	disable providing atom, json, and/or...
Message-ID: <20110224012006.DDE9C4224E@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 1c1c9a07f6ab11871fcc2c14a55fafcd5ca0a503
    https://github.com/buildbot/buildbot/commit/1c1c9a07f6ab11871fcc2c14a55fafcd5ca0a503
Author: Jeff Bailey <jeffbailey at google.com>
Date:   2011-02-23 (Wed, 23 Feb 2011)

Changed paths:
  M master/buildbot/status/web/baseweb.py

Log Message:
-----------
Add option to disable providing atom, json, and/or rss feeds





From nobody at buildbot.net  Thu Feb 24 04:40:00 2011
From: nobody at buildbot.net (Buildbot)
Date: Thu, 24 Feb 2011 04:40:00 -0000
Subject: [Buildbot-commits] [Buildbot] #1052: blamelist lost via trigger
In-Reply-To: <039.c1a1ed20af5a431c7d00e91345a91371@buildbot.net>
References: <039.c1a1ed20af5a431c7d00e91345a91371@buildbot.net>
Message-ID: <054.50077d0826246c8d8026510e32ab018c@buildbot.net>

#1052: blamelist lost via trigger
--------------------+--------------------
Reporter:  qzhwang  |       Owner:
    Type:  defect   |      Status:  new
Priority:  minor    |   Milestone:  0.8.+
 Version:  0.8.1    |  Resolution:
Keywords:           |
--------------------+--------------------

Comment (by neomantra):

 Looks like this landed on
 changeset:8f4dc94001d006f59b5d1cc467b1a473af83372c

 I am not sure if it fixes "blamelist lost via trigger".

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1052#comment:4>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Thu Feb 24 05:46:16 2011
From: noreply at github.com (noreply at github.com)
Date: Wed, 23 Feb 2011 21:46:16 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] 8f0786: Fix issue with grid
	view optimization when actual ...
Message-ID: <20110224054616.8511542351@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 8f07867397eac2d9e98bbc7bb5c6fbdf51452398
    https://github.com/buildbot/buildbot/commit/8f07867397eac2d9e98bbc7bb5c6fbdf51452398
Author: Amber Yust <ayust at yelp.com>
Date:   2011-02-23 (Wed, 23 Feb 2011)

Changed paths:
  M master/buildbot/status/web/grid.py

Log Message:
-----------
Fix issue with grid view optimization when actual available builds < numBuilds





From noreply at github.com  Fri Feb 25 01:44:19 2011
From: noreply at github.com (noreply at github.com)
Date: Thu, 24 Feb 2011 17:44:19 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] b447f8: clarify
	documentation points as requested by dabra...
Message-ID: <20110225014419.B7A2D421A1@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: b447f869f91b30bea349bb5325c48344be2ae537
    https://github.com/buildbot/buildbot/commit/b447f869f91b30bea349bb5325c48344be2ae537
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-24 (Thu, 24 Feb 2011)

Changed paths:
  M master/docs/cfg-global.texinfo
  M master/docs/concepts.texinfo
  M master/docs/installation.texinfo

Log Message:
-----------
clarify documentation points as requested by dabrahams





From nobody at buildbot.net  Fri Feb 25 01:46:07 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 25 Feb 2011 01:46:07 -0000
Subject: [Buildbot-commits] [Buildbot] #1810: older versions of sqlite
 don't handle DDL changes between connections
In-Reply-To: <038.681ae3df2337646bf8427f98bb7802d9@buildbot.net>
References: <038.681ae3df2337646bf8427f98bb7802d9@buildbot.net>
Message-ID: <053.f6516b838523a434d2c4393db93f2b5f@buildbot.net>

#1810: older versions of sqlite don't handle DDL changes between connections
---------------------+--------------------
Reporter:  dustin    |       Owner:
    Type:  defect    |      Status:  new
Priority:  major     |   Milestone:  0.8.4
 Version:  master    |  Resolution:
Keywords:  database  |
---------------------+--------------------

Comment (by dustin):

 I think the right solution is to create all of the tables in each step's
 setUp method, and ensure that the relevant code closes all statements.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1810#comment:7>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Feb 25 01:48:57 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 25 Feb 2011 01:48:57 -0000
Subject: [Buildbot-commits] [Buildbot] #1837: "Using LogFiles in custom
 BuildSteps" example does not work
In-Reply-To: <044.84b63f7a13fb8fa096c31058c53b01dd@buildbot.net>
References: <044.84b63f7a13fb8fa096c31058c53b01dd@buildbot.net>
Message-ID: <059.ff02224c4ddede04aa17155189aaa49d@buildbot.net>

#1837: "Using LogFiles in custom BuildSteps" example does not work
-------------------------+--------------------
Reporter:  thomaswayden  |       Owner:
    Type:  defect        |      Status:  new
Priority:  major         |   Milestone:  0.8.4
 Version:  0.8.3p1       |  Resolution:
Keywords:  docs          |
-------------------------+--------------------
Changes (by dustin):

 * keywords:   => docs
 * type:  undecided => defect
 * milestone:  undecided => 0.8.4


-- 
Ticket URL: <http://trac.buildbot.net/ticket/1837#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Feb 25 01:50:05 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 25 Feb 2011 01:50:05 -0000
Subject: [Buildbot-commits] [Buildbot] #1811: alwaysRun steps don't get
 run if Stop Build is pressed
In-Reply-To: <038.34c2a2d495c9751f122d8351e15a68df@buildbot.net>
References: <038.34c2a2d495c9751f122d8351e15a68df@buildbot.net>
Message-ID: <053.724b67392abdc87efb541b80e4eb15f0@buildbot.net>

#1811: alwaysRun steps don't get run if Stop Build is pressed
------------------------+--------------------
Reporter:  catlee       |       Owner:
    Type:  enhancement  |      Status:  new
Priority:  minor        |   Milestone:  0.8.4
 Version:  0.8.0        |  Resolution:
Keywords:               |
------------------------+--------------------
Changes (by dustin):

 * type:  defect => enhancement
 * milestone:  undecided => 0.8.4


-- 
Ticket URL: <http://trac.buildbot.net/ticket/1811#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Feb 25 01:50:13 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 25 Feb 2011 01:50:13 -0000
Subject: [Buildbot-commits] [Buildbot] #1811: alwaysRun steps don't get
 run if Stop Build is pressed
In-Reply-To: <038.34c2a2d495c9751f122d8351e15a68df@buildbot.net>
References: <038.34c2a2d495c9751f122d8351e15a68df@buildbot.net>
Message-ID: <053.a0541f23247e7f54a5a56f6cdb4fcf96@buildbot.net>

#1811: alwaysRun steps don't get run if Stop Build is pressed
------------------------+--------------------
Reporter:  catlee       |       Owner:
    Type:  enhancement  |      Status:  new
Priority:  minor        |   Milestone:  0.8.4
 Version:  0.8.2        |  Resolution:
Keywords:               |
------------------------+--------------------
Changes (by dustin):

 * version:  0.8.0 => 0.8.2


-- 
Ticket URL: <http://trac.buildbot.net/ticket/1811#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Feb 25 01:52:11 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 25 Feb 2011 01:52:11 -0000
Subject: [Buildbot-commits] [Buildbot] #1832: GitPoller unhandled error
	on adding a change
In-Reply-To: <046.1580261d7ececbba4e1cf2e7e15be043@buildbot.net>
References: <046.1580261d7ececbba4e1cf2e7e15be043@buildbot.net>
Message-ID: <061.0024e886d45143eaef0e3bc7c833beca@buildbot.net>

#1832: GitPoller unhandled error on adding a change
----------------------------+--------------------
Reporter:  davidholsgrove   |       Owner:
    Type:  support-request  |      Status:  new
Priority:  major            |   Milestone:  0.8.4
 Version:  0.8.3p1          |  Resolution:
Keywords:  git              |
----------------------------+--------------------
Changes (by dustin):

 * keywords:  git, gitpoller => git
 * milestone:  undecided => 0.8.4


Comment:

 The problem is that the project is a list:
 {{{
 ['GNU_Tools [CENTOSx86 - master branch]']
 }}}
 It needs to be a simple string.  Check your config?

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1832#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Fri Feb 25 01:56:18 2011
From: nobody at buildbot.net (Buildbot)
Date: Fri, 25 Feb 2011 01:56:18 -0000
Subject: [Buildbot-commits] [Buildbot] #1052: blamelist lost via trigger
In-Reply-To: <039.c1a1ed20af5a431c7d00e91345a91371@buildbot.net>
References: <039.c1a1ed20af5a431c7d00e91345a91371@buildbot.net>
Message-ID: <054.ae2fa0bca11bf6ea34f0d49b4144ea83@buildbot.net>

#1052: blamelist lost via trigger
--------------------+---------------------
Reporter:  qzhwang  |       Owner:
    Type:  defect   |      Status:  closed
Priority:  minor    |   Milestone:  0.8.2
 Version:  0.8.1    |  Resolution:  fixed
Keywords:           |
--------------------+---------------------
Changes (by dustin):

 * status:  new => closed
 * resolution:   => fixed
 * milestone:  0.8.+ => 0.8.2


Comment:

 Indeed, it should.  Does this still occur in v0.8.2 or later?  Please re-
 open, if so.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1052#comment:5>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Feb 26 17:17:04 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 26 Feb 2011 17:17:04 -0000
Subject: [Buildbot-commits] [Buildbot] #1838: Document github hooks universe
Message-ID: <041.9a4e869942f3d84e8c96227870beab4e@buildbot.net>

#1838: Document github hooks universe
------------------------+-----------------------
Reporter:  dabrahams    |      Owner:
    Type:  enhancement  |     Status:  new
Priority:  major        |  Milestone:  undecided
 Version:  0.8.3p1      |   Keywords:  docs
------------------------+-----------------------
 github_buildbot.py and hooks/github.py overlap in purpose and have
 different stregths in terms of simplicity/flexibility/security.  Those
 should be documented and each one should cross-reference the other.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1838>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Sat Feb 26 17:42:14 2011
From: noreply at github.com (noreply at github.com)
Date: Sat, 26 Feb 2011 09:42:14 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] e38c04: Fix example logfile
	summarizer
Message-ID: <20110226174214.7F6884234E@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: e38c042b0ac8e8f764b92d86cf04a31721ad874c
    https://github.com/buildbot/buildbot/commit/e38c042b0ac8e8f764b92d86cf04a31721ad874c
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-26 (Sat, 26 Feb 2011)

Changed paths:
  M master/docs/cfg-buildsteps.texinfo

Log Message:
-----------
Fix example logfile summarizer

Fixes #1837.  Thanks to thomaswayden for the suggestion.





From nobody at buildbot.net  Sat Feb 26 17:42:24 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 26 Feb 2011 17:42:24 -0000
Subject: [Buildbot-commits] [Buildbot] #1837: "Using LogFiles in custom
 BuildSteps" example does not work
In-Reply-To: <044.84b63f7a13fb8fa096c31058c53b01dd@buildbot.net>
References: <044.84b63f7a13fb8fa096c31058c53b01dd@buildbot.net>
Message-ID: <059.732c05f404f2e808bb221bebb6955892@buildbot.net>

#1837: "Using LogFiles in custom BuildSteps" example does not work
-------------------------+---------------------
Reporter:  thomaswayden  |       Owner:
    Type:  defect        |      Status:  closed
Priority:  major         |   Milestone:  0.8.4
 Version:  0.8.3p1       |  Resolution:  fixed
Keywords:  docs          |
-------------------------+---------------------
Changes (by Dustin J. Mitchell):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Fix example logfile summarizer

 Fixes #1837.  Thanks to thomaswayden for the suggestion.
  Changeset: e38c042b0ac8e8f764b92d86cf04a31721ad874c

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1837#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Feb 26 17:48:13 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 26 Feb 2011 17:48:13 -0000
Subject: [Buildbot-commits] [Buildbot] #1836: URI /changes/N fails on
	master
In-Reply-To: <038.9f2c98d4d0f766c527dc3dd40d7bad02@buildbot.net>
References: <038.9f2c98d4d0f766c527dc3dd40d7bad02@buildbot.net>
Message-ID: <053.3edc919c4df591c28a615d1c45230885@buildbot.net>

#1836: URI /changes/N fails on master
---------------------+--------------------
Reporter:  dustin    |       Owner:
    Type:  defect    |      Status:  new
Priority:  critical  |   Milestone:  0.8.4
 Version:  master    |  Resolution:
Keywords:  database  |
---------------------+--------------------

Comment (by dustin):

 tomprince has the beginnings of a fix here:
   https://gist.github.com/844731

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1836#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Feb 26 19:08:25 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 26 Feb 2011 19:08:25 -0000
Subject: [Buildbot-commits] [Buildbot] #1839: replace apidocs with something
	like LXR
Message-ID: <038.9d1bc7b4a0237e361c6c248811bc13c8@buildbot.net>

#1839: replace apidocs with something like LXR
-------------------+---------------------
Reporter:  dustin  |      Owner:
    Type:  task    |     Status:  new
Priority:  major   |  Milestone:  ongoing
 Version:  master  |   Keywords:
-------------------+---------------------
 The apidocs aren't working out very well, for a few reasons:
  * they tend to blur the line between public and private APIs
  * they do not document instance variables very well
  * we have been very inconsistent in writing docstrings
  * they're often wrong
  * they obscure the actual implementation

 I think we'd do better to publish annotate, searchable source code -
 something like http://mxr.mozilla.org/.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1839>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Sat Feb 26 19:08:38 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 26 Feb 2011 19:08:38 -0000
Subject: [Buildbot-commits] [Buildbot] #1839: replace apidocs with
	something like LXR
In-Reply-To: <038.9d1bc7b4a0237e361c6c248811bc13c8@buildbot.net>
References: <038.9d1bc7b4a0237e361c6c248811bc13c8@buildbot.net>
Message-ID: <053.36d7bd250851dc47fe824667d2fa1180@buildbot.net>

#1839: replace apidocs with something like LXR
-------------------+----------------------
Reporter:  dustin  |       Owner:
    Type:  task    |      Status:  new
Priority:  major   |   Milestone:  ongoing
 Version:  master  |  Resolution:
Keywords:  docs    |
-------------------+----------------------
Changes (by dustin):

 * keywords:   => docs


-- 
Ticket URL: <http://trac.buildbot.net/ticket/1839#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Sat Feb 26 19:41:53 2011
From: noreply at github.com (noreply at github.com)
Date: Sat, 26 Feb 2011 11:41:53 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] bd3fe4: Allow /changes/NN to
	render from deferred
Message-ID: <20110226194153.157BA42350@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: bd3fe48d083d599fdf53a220a296160ed2a26f4d
    https://github.com/buildbot/buildbot/commit/bd3fe48d083d599fdf53a220a296160ed2a26f4d
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-26 (Sat, 26 Feb 2011)

Changed paths:
  M master/buildbot/status/web/base.py
  M master/buildbot/status/web/changes.py

Log Message:
-----------
Allow /changes/NN to render from deferred

Fixes #1836





From nobody at buildbot.net  Sat Feb 26 19:41:59 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 26 Feb 2011 19:41:59 -0000
Subject: [Buildbot-commits] [Buildbot] #1836: URI /changes/N fails on
	master
In-Reply-To: <038.9f2c98d4d0f766c527dc3dd40d7bad02@buildbot.net>
References: <038.9f2c98d4d0f766c527dc3dd40d7bad02@buildbot.net>
Message-ID: <053.c83befca1c9dd94057af7c0ce4fa5fcf@buildbot.net>

#1836: URI /changes/N fails on master
---------------------+---------------------
Reporter:  dustin    |       Owner:
    Type:  defect    |      Status:  closed
Priority:  critical  |   Milestone:  0.8.4
 Version:  master    |  Resolution:  fixed
Keywords:  database  |
---------------------+---------------------
Changes (by Dustin J. Mitchell):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Allow /changes/NN to render from deferred

 Fixes #1836
  Changeset: bd3fe48d083d599fdf53a220a296160ed2a26f4d

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1836#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Sat Feb 26 19:45:34 2011
From: noreply at github.com (noreply at github.com)
Date: Sat, 26 Feb 2011 11:45:34 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] 9f3754: fix
	PBChangeSource.describe to work when port is i...
Message-ID: <20110226194534.DF5E3422E8@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 9f37542697e16f7aeb8239c0730b95790aea2132
    https://github.com/buildbot/buildbot/commit/9f37542697e16f7aeb8239c0730b95790aea2132
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-26 (Sat, 26 Feb 2011)

Changed paths:
  M master/buildbot/changes/pb.py
  M master/buildbot/test/unit/test_changes_pb.py

Log Message:
-----------
fix PBChangeSource.describe to work when port is int





From nobody at buildbot.net  Sat Feb 26 19:50:41 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 26 Feb 2011 19:50:41 -0000
Subject: [Buildbot-commits] [Buildbot] #1833: test for left-open
	database cursors
In-Reply-To: <038.309c689915c8cfa297619261088b1af3@buildbot.net>
References: <038.309c689915c8cfa297619261088b1af3@buildbot.net>
Message-ID: <053.19fbb1c2c8b119a86edeac5b37da6a38@buildbot.net>

#1833: test for left-open database cursors
----------------------------+---------------------
Reporter:  dustin           |       Owner:  dustin
    Type:  defect           |      Status:  new
Priority:  critical         |   Milestone:  0.8.4
 Version:  master           |  Resolution:
Keywords:  database, tests  |
----------------------------+---------------------
Changes (by dustin):

 * version:  0.8.3p1 => master


-- 
Ticket URL: <http://trac.buildbot.net/ticket/1833#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Sat Feb 26 19:54:38 2011
From: noreply at github.com (noreply at github.com)
Date: Sat, 26 Feb 2011 11:54:38 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] 0070e6: log username for
	UnauthorizedLogins
Message-ID: <20110226195438.42B8742175@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 0070e6cd5633cf6ea98178767bb824b5bf54883c
    https://github.com/buildbot/buildbot/commit/0070e6cd5633cf6ea98178767bb824b5bf54883c
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-26 (Sat, 26 Feb 2011)

Changed paths:
  M master/buildbot/pbmanager.py

Log Message:
-----------
log username for UnauthorizedLogins





From noreply at github.com  Sat Feb 26 21:03:16 2011
From: noreply at github.com (noreply at github.com)
Date: Sat, 26 Feb 2011 13:03:16 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] b2b864: replace
	changeEventGenerator with getRecentChangeI...
Message-ID: <20110226210316.5E75742350@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: b2b864fcbea4629114ba31ac584bdfb1d78686ba
    https://github.com/buildbot/buildbot/commit/b2b864fcbea4629114ba31ac584bdfb1d78686ba
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-26 (Sat, 26 Feb 2011)

Changed paths:
  M master/buildbot/changes/manager.py
  M master/buildbot/db/changes.py
  M master/buildbot/status/web/console.py
  M master/buildbot/status/web/waterfall.py
  M master/buildbot/test/unit/test_db_changes.py

Log Message:
-----------
replace changeEventGenerator with getRecentChangeInstances

The changeEventGenerator had a nasty habit of holding database
connections open, causing locking errors.  The new method is probably
less efficient, but is more reliable.

Refs #1833





From nobody at buildbot.net  Sat Feb 26 21:03:24 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 26 Feb 2011 21:03:24 -0000
Subject: [Buildbot-commits] [Buildbot] #1833: test for left-open
	database cursors
In-Reply-To: <038.309c689915c8cfa297619261088b1af3@buildbot.net>
References: <038.309c689915c8cfa297619261088b1af3@buildbot.net>
Message-ID: <053.fe3ece286303a42bdb771a173273375b@buildbot.net>

#1833: test for left-open database cursors
----------------------------+---------------------
Reporter:  dustin           |       Owner:  dustin
    Type:  defect           |      Status:  new
Priority:  critical         |   Milestone:  0.8.4
 Version:  master           |  Resolution:
Keywords:  database, tests  |
----------------------------+---------------------

Comment (by Dustin J. Mitchell):

 replace changeEventGenerator with getRecentChangeInstances

 The changeEventGenerator had a nasty habit of holding database
 connections open, causing locking errors.  The new method is probably
 less efficient, but is more reliable.

 Refs #1833
  Changeset: b2b864fcbea4629114ba31ac584bdfb1d78686ba

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1833#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Sat Feb 26 21:32:59 2011
From: noreply at github.com (noreply at github.com)
Date: Sat, 26 Feb 2011 13:32:59 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] dc23ea: mention SQLite
	version requirements in docs
Message-ID: <20110226213259.19FBD422F2@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: dc23ea0b42fc669341d5f659d45fcf45c540a51d
    https://github.com/buildbot/buildbot/commit/dc23ea0b42fc669341d5f659d45fcf45c540a51d
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-26 (Sat, 26 Feb 2011)

Changed paths:
  M master/docs/installation.texinfo

Log Message:
-----------
mention SQLite version requirements in docs





From nobody at buildbot.net  Sat Feb 26 21:46:25 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 26 Feb 2011 21:46:25 -0000
Subject: [Buildbot-commits] [Buildbot] #1835: failure rendering grid on
	master
In-Reply-To: <038.c36ba6ceebeab0b5582843d79944ae20@buildbot.net>
References: <038.c36ba6ceebeab0b5582843d79944ae20@buildbot.net>
Message-ID: <053.99c94c648a181c255a545ba749e66899@buildbot.net>

#1835: failure rendering grid on master
---------------------+---------------------
Reporter:  dustin    |       Owner:
    Type:  defect    |      Status:  closed
Priority:  critical  |   Milestone:  0.8.4
 Version:  master    |  Resolution:  fixed
Keywords:  database  |
---------------------+---------------------
Changes (by dustin):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Ah, getting the line numbers to line up shows that this was a commit
 before 8f07867397eac2d9e98bbc7bb5c6fbdf51452398, in which ayust fixed
 this.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1835#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Sat Feb 26 21:49:07 2011
From: noreply at github.com (noreply at github.com)
Date: Sat, 26 Feb 2011 13:49:07 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] a72cc2: fix typo in forcing
	builds via IRC
Message-ID: <20110226214907.43D2A42362@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: a72cc2dd23ca9979c95fee3a93ddb40832487057
    https://github.com/buildbot/buildbot/commit/a72cc2dd23ca9979c95fee3a93ddb40832487057
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-26 (Sat, 26 Feb 2011)

Changed paths:
  M master/buildbot/process/builder.py

Log Message:
-----------
fix typo in forcing builds via IRC

Fixes #1834





From nobody at buildbot.net  Sat Feb 26 21:49:13 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 26 Feb 2011 21:49:13 -0000
Subject: [Buildbot-commits] [Buildbot] #1834: forcing builds via IRC
	fails on master
In-Reply-To: <038.1d139354eb940381bc232aad6f75b1a5@buildbot.net>
References: <038.1d139354eb940381bc232aad6f75b1a5@buildbot.net>
Message-ID: <053.f7a6b4369c25099748813479c6c22e67@buildbot.net>

#1834: forcing builds via IRC fails on master
---------------------+---------------------
Reporter:  dustin    |       Owner:
    Type:  defect    |      Status:  closed
Priority:  critical  |   Milestone:  0.8.4
 Version:  master    |  Resolution:  fixed
Keywords:  database  |
---------------------+---------------------
Changes (by Dustin J. Mitchell):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 fix typo in forcing builds via IRC

 Fixes #1834
  Changeset: a72cc2dd23ca9979c95fee3a93ddb40832487057

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1834#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Sat Feb 26 23:06:29 2011
From: noreply at github.com (noreply at github.com)
Date: Sat, 26 Feb 2011 15:06:29 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] db7727: further fixes for
	IRC status job submission
Message-ID: <20110226230629.94C4342337@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: db77276fda4cdb2b1570ac3e8eba99f5142feff2
    https://github.com/buildbot/buildbot/commit/db77276fda4cdb2b1570ac3e8eba99f5142feff2
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-26 (Sat, 26 Feb 2011)

Changed paths:
  M master/buildbot/process/builder.py
  M master/buildbot/status/words.py

Log Message:
-----------
further fixes for IRC status job submission

Fixes #1834





From nobody at buildbot.net  Sat Feb 26 23:06:36 2011
From: nobody at buildbot.net (Buildbot)
Date: Sat, 26 Feb 2011 23:06:36 -0000
Subject: [Buildbot-commits] [Buildbot] #1834: forcing builds via IRC
	fails on master
In-Reply-To: <038.1d139354eb940381bc232aad6f75b1a5@buildbot.net>
References: <038.1d139354eb940381bc232aad6f75b1a5@buildbot.net>
Message-ID: <053.138fa966447ddc85c605f00837255527@buildbot.net>

#1834: forcing builds via IRC fails on master
---------------------+---------------------
Reporter:  dustin    |       Owner:
    Type:  defect    |      Status:  closed
Priority:  critical  |   Milestone:  0.8.4
 Version:  master    |  Resolution:  fixed
Keywords:  database  |
---------------------+---------------------

Comment (by Dustin J. Mitchell):

 further fixes for IRC status job submission

 Fixes #1834
  Changeset: db77276fda4cdb2b1570ac3e8eba99f5142feff2

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1834#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Sun Feb 27 00:00:00 2011
From: noreply at github.com (noreply at github.com)
Date: Sat, 26 Feb 2011 16:00:00 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] d09a7d: wait longer and more
	persistently for stdin to clo...
Message-ID: <20110227000000.29F3642353@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: d09a7da071813352ab3ec948e648d5a32e2dfea6
    https://github.com/buildbot/buildbot/commit/d09a7da071813352ab3ec948e648d5a32e2dfea6
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-26 (Sat, 26 Feb 2011)

Changed paths:
  M slave/buildslave/test/unit/runprocess-scripts.py

Log Message:
-----------
wait longer and more persistently for stdin to close





From noreply at github.com  Sun Feb 27 03:47:36 2011
From: noreply at github.com (noreply at github.com)
Date: Sat, 26 Feb 2011 19:47:36 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] c17482: Create tables during
	setUp
Message-ID: <20110227034737.0280842337@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: c174823fff337902aa8de4508c9aa4c99bef5a5e
    https://github.com/buildbot/buildbot/commit/c174823fff337902aa8de4508c9aa4c99bef5a5e
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-26 (Sat, 26 Feb 2011)

Changed paths:
  M master/buildbot/test/unit/test_db_buildsets.py
  M master/buildbot/test/unit/test_db_changes.py
  M master/buildbot/test/unit/test_db_connector.py
  M master/buildbot/test/unit/test_db_schedulers.py
  M master/buildbot/test/unit/test_db_sourcestamps.py
  M master/buildbot/test/unit/test_db_state.py
  M master/buildbot/test/util/connector_component.py
  M master/buildbot/test/util/db.py

Log Message:
-----------
Create tables during setUp

This should avoid some problems with SQLAlchemy trying to interleave
create statements with selects and inserts.  Refs #1810.





From nobody at buildbot.net  Sun Feb 27 03:47:44 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 27 Feb 2011 03:47:44 -0000
Subject: [Buildbot-commits] [Buildbot] #1810: older versions of sqlite
 don't handle DDL changes between connections
In-Reply-To: <038.681ae3df2337646bf8427f98bb7802d9@buildbot.net>
References: <038.681ae3df2337646bf8427f98bb7802d9@buildbot.net>
Message-ID: <053.44d61ef8bb243ff3b4f59db8bd5c4dc6@buildbot.net>

#1810: older versions of sqlite don't handle DDL changes between connections
---------------------+--------------------
Reporter:  dustin    |       Owner:
    Type:  defect    |      Status:  new
Priority:  major     |   Milestone:  0.8.4
 Version:  master    |  Resolution:
Keywords:  database  |
---------------------+--------------------

Comment (by Dustin J. Mitchell):

 Create tables during setUp

 This should avoid some problems with SQLAlchemy trying to interleave
 create statements with selects and inserts.  Refs #1810.
  Changeset: c174823fff337902aa8de4508c9aa4c99bef5a5e

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1810#comment:8>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Sun Feb 27 03:57:35 2011
From: noreply at github.com (noreply at github.com)
Date: Sat, 26 Feb 2011 19:57:35 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] 8e9f9b: make tests
	order-insensitive
Message-ID: <20110227035735.0C7B1422E1@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 8e9f9bd67d70762cc9e6968f7ec5d727c5682ea3
    https://github.com/buildbot/buildbot/commit/8e9f9bd67d70762cc9e6968f7ec5d727c5682ea3
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-26 (Sat, 26 Feb 2011)

Changed paths:
  M master/buildbot/test/unit/test_db_changes.py

Log Message:
-----------
make tests order-insensitive


Commit: f41e3f24e056cd7a50ea4c853d7dd4cf347c0136
    https://github.com/buildbot/buildbot/commit/f41e3f24e056cd7a50ea4c853d7dd4cf347c0136
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-26 (Sat, 26 Feb 2011)

Changed paths:
  M master/buildbot/test/unit/test_db_schedulers.py

Log Message:
-----------
use integer for 'important' column





From nobody at buildbot.net  Sun Feb 27 04:06:13 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 27 Feb 2011 04:06:13 -0000
Subject: [Buildbot-commits] [Buildbot] #1810: older versions of sqlite
 don't handle DDL changes between connections
In-Reply-To: <038.681ae3df2337646bf8427f98bb7802d9@buildbot.net>
References: <038.681ae3df2337646bf8427f98bb7802d9@buildbot.net>
Message-ID: <053.6c341e4ccf28439235ca441b095426c0@buildbot.net>

#1810: older versions of sqlite don't handle DDL changes between connections
---------------------+---------------------
Reporter:  dustin    |       Owner:
    Type:  defect    |      Status:  closed
Priority:  major     |   Milestone:  0.8.4
 Version:  master    |  Resolution:  fixed
Keywords:  database  |
---------------------+---------------------
Changes (by dustin):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Closing in hopes this is now fixed .. we'll see!

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1810#comment:9>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Sun Feb 27 04:12:07 2011
From: noreply at github.com (noreply at github.com)
Date: Sat, 26 Feb 2011 20:12:07 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] bc94bf: limit use of
	do_with_engine to schema functions
Message-ID: <20110227041207.1776142371@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: bc94bfd89b89b44bd82264dc8f06aadb15e64682
    https://github.com/buildbot/buildbot/commit/bc94bfd89b89b44bd82264dc8f06aadb15e64682
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-26 (Sat, 26 Feb 2011)

Changed paths:
  M master/buildbot/db/pool.py
  M master/buildbot/test/util/db.py

Log Message:
-----------
limit use of do_with_engine to schema functions





From nobody at buildbot.net  Sun Feb 27 04:16:31 2011
From: nobody at buildbot.net (Buildbot)
Date: Sun, 27 Feb 2011 04:16:31 -0000
Subject: [Buildbot-commits] [Buildbot] #1833: test for left-open
	database cursors
In-Reply-To: <038.309c689915c8cfa297619261088b1af3@buildbot.net>
References: <038.309c689915c8cfa297619261088b1af3@buildbot.net>
Message-ID: <053.8894b249f46fd896a810d71835697094@buildbot.net>

#1833: test for left-open database cursors
----------------------------+---------------------
Reporter:  dustin           |       Owner:  dustin
    Type:  defect           |      Status:  closed
Priority:  critical         |   Milestone:  0.8.4
 Version:  master           |  Resolution:  fixed
Keywords:  database, tests  |
----------------------------+---------------------
Changes (by dustin):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 I think this is already effectively tested: the only conflict is to try to
 DROP while a SELECT is in progress.  This is, indeed, what we saw with the
 {{{changeEventGenerator}}}, but since the tests drop all tables after each
 test completes, problems with left-open statements will cause test
 failures.

 I verified this assertion by adding a deliberately left-open statement:
 {{{
 self.r = sometable.select()
 }}}
 into the thd() method in a test.  The result was lots of
 {{{
 sqlalchemy.exc.OperationalError: (OperationalError) database is locked
 u'\nDROP TABLE sourcestamp_changes' ()
 }}}
 and
 {{{
 sqlalchemy.exc.OperationalError: (OperationalError) database table is
 locked u'\nDROP TABLE sourcestamp_changes' ()
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1833#comment:4>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Sun Feb 27 23:00:15 2011
From: noreply at github.com (noreply at github.com)
Date: Sun, 27 Feb 2011 15:00:15 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] 786b68: remove unused test
	functions from BotMaster
Message-ID: <20110227230015.B7A9C422E5@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 786b6835a43d0f65312b250ccb6048695c8bc541
    https://github.com/buildbot/buildbot/commit/786b6835a43d0f65312b250ccb6048695c8bc541
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-27 (Sun, 27 Feb 2011)

Changed paths:
  M master/buildbot/master.py

Log Message:
-----------
remove unused test functions from BotMaster


Commit: 919f116ad43d2d05f490982a058a16be68ef9ae8
    https://github.com/buildbot/buildbot/commit/919f116ad43d2d05f490982a058a16be68ef9ae8
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-27 (Sun, 27 Feb 2011)

Changed paths:
  M master/buildbot/buildrequest.py
  M master/buildbot/clients/tryclient.py
  M master/buildbot/db/connector.py
  M master/buildbot/master.py
  M master/buildbot/process/base.py
  A master/buildbot/process/build.py
  M master/buildbot/process/builder.py
  A master/buildbot/process/buildrequest.py
  M master/buildbot/process/buildstep.py
  M master/buildbot/process/factory.py
  A master/buildbot/process/sourcestamp.py
  M master/buildbot/sourcestamp.py
  M master/buildbot/status/builder.py
  M master/buildbot/status/web/grid.py
  M master/buildbot/status/web/status_json.py
  M master/buildbot/status/words.py
  M master/buildbot/test/regressions/test_shell_command_properties.py
  M master/buildbot/test/regressions/test_sourcestamp_revision.py
  M master/buildbot/test/unit/test_oldpaths.py
  R master/buildbot/test/unit/test_persistent_queue.py
  R master/buildbot/test/unit/test_process_base.py
  A master/buildbot/test/unit/test_process_build.py
  R master/buildbot/test/unit/test_repo_parse_download.py
  R master/buildbot/test/unit/test_source_repourl.py
  A master/buildbot/test/unit/test_status_persistent_queue.py
  A master/buildbot/test/unit/test_steps_source_Repo.py
  A master/buildbot/test/unit/test_steps_source_Source.py
  M master/docs/cfg-statustargets.texinfo

Log Message:
-----------
move classes out of the top level package

This leaves "redirect" modules in place, so the old names still work
(and are tested to do so)


Commit: cc298b8af72f07a3c77a825a00e8d7fc15ce27b2
    https://github.com/buildbot/buildbot/commit/cc298b8af72f07a3c77a825a00e8d7fc15ce27b2
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-27 (Sun, 27 Feb 2011)

Changed paths:
  M master/buildbot/process/build.py
  M master/buildbot/process/buildrequest.py
  M master/buildbot/test/unit/test_process_build.py

Log Message:
-----------
remove BuildRequest's startCount


Commit: 238cb32e49f48c66972edadd62c892dd07874b58
    https://github.com/buildbot/buildbot/commit/238cb32e49f48c66972edadd62c892dd07874b58
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-27 (Sun, 27 Feb 2011)

Changed paths:
  M master/buildbot/process/builder.py
  M master/buildbot/process/buildrequest.py

Log Message:
-----------
move BuildRequestControl into buildrequest.py





From noreply at github.com  Sun Feb 27 23:17:53 2011
From: noreply at github.com (noreply at github.com)
Date: Sun, 27 Feb 2011 15:17:53 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] d5bd31: move slavebuilder
	classes to buildbot.process.slav...
Message-ID: <20110227231753.9D4F5421F6@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: d5bd31cfaab41db29bc98acc8b119c68d19f0d1c
    https://github.com/buildbot/buildbot/commit/d5bd31cfaab41db29bc98acc8b119c68d19f0d1c
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-27 (Sun, 27 Feb 2011)

Changed paths:
  M master/buildbot/interfaces.py
  M master/buildbot/master.py
  M master/buildbot/process/builder.py
  A master/buildbot/process/slavebuilder.py
  M master/docs/developer.texinfo

Log Message:
-----------
move slavebuilder classes to buildbot.process.slavebuilder





From noreply at github.com  Mon Feb 28 00:25:46 2011
From: noreply at github.com (noreply at github.com)
Date: Sun, 27 Feb 2011 16:25:46 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] 6112b8: move botmaster and
	debugperspective out of master....
Message-ID: <20110228002546.D19F84204C@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 6112b8e38351bc02f20588dcece73b0e135a73e4
    https://github.com/buildbot/buildbot/commit/6112b8e38351bc02f20588dcece73b0e135a73e4
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-27 (Sun, 27 Feb 2011)

Changed paths:
  M master/buildbot/master.py
  A master/buildbot/process/botmaster.py
  A master/buildbot/process/debug.py
  M master/buildbot/status/builder.py
  R master/buildbot/test/unit/test_master_cleanshutdown.py
  A master/buildbot/test/unit/test_process_botmaster_BotMaster_cleanshutdown.py
  M master/docs/developer.texinfo

Log Message:
-----------
move botmaster and debugperspective out of master.py





From nobody at buildbot.net  Mon Feb 28 02:43:25 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 28 Feb 2011 02:43:25 -0000
Subject: [Buildbot-commits] [Buildbot] #1840: Bad comment in default
	master.cfg
Message-ID: <041.3802e52ba17eb917030b973e18ed8fdd@buildbot.net>

#1840: Bad comment in default master.cfg
----------------------+-----------------------
Reporter:  dabrahams  |      Owner:
    Type:  defect     |     Status:  new
Priority:  major      |  Milestone:  undecided
 Version:  0.8.3p1    |   Keywords:  docs
----------------------+-----------------------
 {{{
 # The 'slaves' list defines the set of recognized buildslaves. Each
 element is
 # a BuildSlave object, specifying a username and password.  The same
 username and
 # password must be configured on the slave.
 }}}

 These are not usernames, but slave names

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1840>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Mon Feb 28 02:55:11 2011
From: noreply at github.com (noreply at github.com)
Date: Sun, 27 Feb 2011 18:55:11 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] 535188: fix docstring typo
Message-ID: <20110228025511.01D7F422CE@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 535188644ad9891350dd354d50949be90dc7dc6d
    https://github.com/buildbot/buildbot/commit/535188644ad9891350dd354d50949be90dc7dc6d
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-27 (Sun, 27 Feb 2011)

Changed paths:
  M master/buildbot/schedulers/base.py

Log Message:
-----------
fix docstring typo


Commit: 405277fa36412feb52507b5acd9d1f0d5a4a3ed1
    https://github.com/buildbot/buildbot/commit/405277fa36412feb52507b5acd9d1f0d5a4a3ed1
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-27 (Sun, 27 Feb 2011)

Changed paths:
  M master/buildbot/test/unit/test_util.py
  A master/buildbot/test/unit/test_util_misc.py
  M master/buildbot/util/__init__.py
  M master/buildbot/util/misc.py

Log Message:
-----------
add and test new SerializedInvocation class





From noreply at github.com  Mon Feb 28 02:58:35 2011
From: noreply at github.com (noreply at github.com)
Date: Sun, 27 Feb 2011 18:58:35 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] bf688b: don't mention
	usernames in sample.cfg
Message-ID: <20110228025835.524D4422CE@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: bf688b1eb0e0945c45973b515a0f2b7ed03844ff
    https://github.com/buildbot/buildbot/commit/bf688b1eb0e0945c45973b515a0f2b7ed03844ff
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-27 (Sun, 27 Feb 2011)

Changed paths:
  M master/buildbot/scripts/sample.cfg

Log Message:
-----------
don't mention usernames in sample.cfg

Fixes #1840





From nobody at buildbot.net  Mon Feb 28 02:58:41 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 28 Feb 2011 02:58:41 -0000
Subject: [Buildbot-commits] [Buildbot] #1840: Bad comment in default
	master.cfg
In-Reply-To: <041.3802e52ba17eb917030b973e18ed8fdd@buildbot.net>
References: <041.3802e52ba17eb917030b973e18ed8fdd@buildbot.net>
Message-ID: <056.57c18e6f7fe2a11e2b37706b38c1ba9c@buildbot.net>

#1840: Bad comment in default master.cfg
----------------------+------------------------
Reporter:  dabrahams  |       Owner:
    Type:  defect     |      Status:  closed
Priority:  major      |   Milestone:  undecided
 Version:  0.8.3p1    |  Resolution:  fixed
Keywords:  docs       |
----------------------+------------------------
Changes (by Dustin J. Mitchell):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 don't mention usernames in sample.cfg

 Fixes #1840
  Changeset: bf688b1eb0e0945c45973b515a0f2b7ed03844ff

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1840#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Mon Feb 28 02:59:59 2011
From: noreply at github.com (noreply at github.com)
Date: Sun, 27 Feb 2011 18:59:59 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] 156e38: remove warning about
	PBChangeSource and its own po...
Message-ID: <20110228025959.4AF87422A5@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 156e3811b9ef91be2b3458d459ab5ce0cee09ab1
    https://github.com/buildbot/buildbot/commit/156e3811b9ef91be2b3458d459ab5ce0cee09ab1
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-27 (Sun, 27 Feb 2011)

Changed paths:
  M master/docs/cfg-changesources.texinfo

Log Message:
-----------
remove warning about PBChangeSource and its own port





From noreply at github.com  Mon Feb 28 03:53:16 2011
From: noreply at github.com (noreply at github.com)
Date: Sun, 27 Feb 2011 19:53:16 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] 295cbb: Remove unnecessary
	'Admin: ' on buildslaves web st...
Message-ID: <20110228035316.EE5BF42193@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 295cbbd80be534135be9cc7d8335d6593957b1f1
    https://github.com/buildbot/buildbot/commit/295cbbd80be534135be9cc7d8335d6593957b1f1
Author: Tom Prince <tom.prince at ualberta.net>
Date:   2011-02-27 (Sun, 27 Feb 2011)

Changed paths:
  M master/buildbot/status/web/templates/buildslaves.html

Log Message:
-----------
Remove unnecessary 'Admin: ' on buildslaves web status page.

We don't need to repeat the column heading in every row.

Signed-off-by: Tom Prince <tom.prince at ualberta.net>





From nobody at buildbot.net  Mon Feb 28 04:05:52 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 28 Feb 2011 04:05:52 -0000
Subject: [Buildbot-commits] [Buildbot] #1841: mozilla slaves failing in 'git'
Message-ID: <038.7e62b7cc167bd5b9e57aef033cdda169@buildbot.net>

#1841: mozilla slaves failing in 'git'
-------------------+---------------------
Reporter:  dustin  |      Owner:
    Type:  defect  |     Status:  new
Priority:  major   |  Milestone:  ongoing
 Version:  master  |   Keywords:
-------------------+---------------------
 This seems to be mostly, but not exclusively, affect the XP slaves.

 Git fetch fails after 100 seconds with
 {{{
 fatal: read error: Invalid argument
 }}}

 http://code.google.com/p/msysgit/issues/detail?id=197 seems to suggest
 this is MTU-related.  Which sounds suspiciously like infra problems we've
 been seeing elsewhere in Mozilla..

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1841>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Feb 28 04:07:53 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 28 Feb 2011 04:07:53 -0000
Subject: [Buildbot-commits] [Buildbot] #1841: mozilla slaves failing in
	'git'
In-Reply-To: <038.7e62b7cc167bd5b9e57aef033cdda169@buildbot.net>
References: <038.7e62b7cc167bd5b9e57aef033cdda169@buildbot.net>
Message-ID: <053.4c81eba5b95cbce095116f5ccb503b83@buildbot.net>

#1841: mozilla slaves failing in 'git'
-------------------+----------------------
Reporter:  dustin  |       Owner:
    Type:  defect  |      Status:  new
Priority:  major   |   Milestone:  ongoing
 Version:  master  |  Resolution:
Keywords:          |
-------------------+----------------------

Comment (by dustin):

 This is with the git protocol:
 {{{
 fetching branch master from git://github.com/buildbot/buildbot.git
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1841#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Feb 28 04:35:19 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 28 Feb 2011 04:35:19 -0000
Subject: [Buildbot-commits] [Buildbot] #1841: mozilla slaves failing in
	'git'
In-Reply-To: <038.7e62b7cc167bd5b9e57aef033cdda169@buildbot.net>
References: <038.7e62b7cc167bd5b9e57aef033cdda169@buildbot.net>
Message-ID: <053.183d9346e8c3119e5d66f3a050efa066@buildbot.net>

#1841: mozilla slaves failing in 'git'
-------------------+----------------------
Reporter:  dustin  |       Owner:
    Type:  defect  |      Status:  new
Priority:  major   |   Milestone:  ongoing
 Version:  master  |  Resolution:
Keywords:          |
-------------------+----------------------

Comment (by dustin):

 tcpdump of a brief 'fetch' from my server:
 {{{
 22:24:31.979057 IP adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781 >
 github.com.git: S 846634609:846634609(0) win 5840 <mss
 1460,sackOK,timestamp 2770775669 0,nop,wscale 7>
 22:24:32.045390 IP github.com.git >
 adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781: S
 2231992162:2231992162(0) ack 846634610 win 5792 <mss 1452,sackOK,timestamp
 1433003840 2770775669,nop,wscale 7>
 22:24:32.045418 IP adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781 >
 github.com.git: . ack 1 win 46 <nop,nop,timestamp 2770775686 1433003840>
 22:24:32.045443 IP adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781 >
 github.com.git: P 1:60(59) ack 1 win 46 <nop,nop,timestamp 2770775686
 1433003840>
 22:24:32.112380 IP github.com.git >
 adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781: . ack 60 win 46
 <nop,nop,timestamp 1433003857 2770775686>
 22:24:32.124351 IP github.com.git >
 adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781: P 1:156(155) ack 60 win
 46 <nop,nop,timestamp 1433003860 2770775686>
 22:24:32.124375 IP adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781 >
 github.com.git: . ack 156 win 54 <nop,nop,timestamp 2770775705 1433003860>
 22:24:32.132625 IP github.com.git >
 adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781: . 156:1596(1440) ack 60
 win 46 <nop,nop,timestamp 1433003861 2770775686>
 22:24:32.132650 IP adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781 >
 github.com.git: . ack 1596 win 77 <nop,nop,timestamp 2770775708
 1433003861>
 22:24:32.193696 IP github.com.git >
 adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781: . 1596:3036(1440) ack 60
 win 46 <nop,nop,timestamp 1433003876 2770775705>
 22:24:32.193720 IP adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781 >
 github.com.git: . ack 3036 win 100 <nop,nop,timestamp 2770775723
 1433003876>
 22:24:32.197731 IP github.com.git >
 adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781: P 3036:4476(1440) ack 60
 win 46 <nop,nop,timestamp 1433003876 2770775705>
 22:24:32.197754 IP adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781 >
 github.com.git: . ack 4476 win 122 <nop,nop,timestamp 2770775724
 1433003876>
 22:24:32.203731 IP github.com.git >
 adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781: . 4476:5916(1440) ack 60
 win 46 <nop,nop,timestamp 1433003878 2770775708>
 22:24:32.203755 IP adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781 >
 github.com.git: . ack 5916 win 145 <nop,nop,timestamp 2770775725
 1433003878>
 22:24:32.205677 IP github.com.git >
 adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781: P 5916:6852(936) ack 60
 win 46 <nop,nop,timestamp 1433003878 2770775708>
 22:24:32.205700 IP adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781 >
 github.com.git: . ack 6852 win 167 <nop,nop,timestamp 2770775726
 1433003878>
 22:24:32.222389 IP adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781 >
 github.com.git: P 60:579(519) ack 6852 win 167 <nop,nop,timestamp
 2770775730 1433003878>
 22:24:32.247370 IP adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781 >
 github.com.git: . 579:2019(1440) ack 6852 win 167 <nop,nop,timestamp
 2770775736 1433003878>
 22:24:32.337099 IP github.com.git >
 adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781: . ack 2019 win 77
 <nop,nop,timestamp 1433003913 2770775730>
 22:24:32.337126 IP adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781 >
 github.com.git: P 2019:2892(873) ack 6852 win 167 <nop,nop,timestamp
 2770775759 1433003913>
 22:24:32.347111 IP github.com.git >
 adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781: P 6852:7300(448) ack
 2019 win 77 <nop,nop,timestamp 1433003915 2770775730>
 22:24:32.347227 IP github.com.git >
 adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781: P 7300:7748(448) ack
 2019 win 77 <nop,nop,timestamp 1433003915 2770775730>
 22:24:32.347242 IP adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781 >
 github.com.git: . ack 7748 win 212 <nop,nop,timestamp 2770775761
 1433003915>
 22:24:32.349057 IP github.com.git >
 adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781: P 7748:8196(448) ack
 2019 win 77 <nop,nop,timestamp 1433003915 2770775730>
 22:24:32.351125 IP github.com.git >
 adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781: P 8196:8364(168) ack
 2019 win 77 <nop,nop,timestamp 1433003915 2770775730>
 22:24:32.351126 IP github.com.git >
 adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781: P 8364:8420(56) ack 2019
 win 77 <nop,nop,timestamp 1433003915 2770775730>
 22:24:32.351154 IP adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781 >
 github.com.git: . ack 8420 win 257 <nop,nop,timestamp 2770775762
 1433003915>
 22:24:32.422252 IP github.com.git >
 adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781: P 8420:9485(1065) ack
 2892 win 99 <nop,nop,timestamp 1433003934 2770775759>
 22:24:32.460445 IP adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781 >
 github.com.git: . ack 9485 win 280 <nop,nop,timestamp 2770775790
 1433003934>
 22:24:32.492844 IP github.com.git >
 adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781: P 9485:9520(35) ack 2892
 win 99 <nop,nop,timestamp 1433003952 2770775762>
 22:24:32.492869 IP adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781 >
 github.com.git: . ack 9520 win 280 <nop,nop,timestamp 2770775798
 1433003952>
 22:24:32.508862 IP github.com.git >
 adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781: P 9520:9678(158) ack
 2892 win 99 <nop,nop,timestamp 1433003956 2770775762>
 22:24:32.508886 IP adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781 >
 github.com.git: . ack 9678 win 302 <nop,nop,timestamp 2770775802
 1433003956>
 22:24:32.522870 IP github.com.git >
 adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781: . 9678:11118(1440) ack
 2892 win 99 <nop,nop,timestamp 1433003959 2770775762>
 22:24:32.522895 IP adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781 >
 github.com.git: . ack 11118 win 325 <nop,nop,timestamp 2770775805
 1433003959>
 22:24:32.528808 IP github.com.git >
 adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781: . 11118:12558(1440) ack
 2892 win 99 <nop,nop,timestamp 1433003959 2770775762>
 22:24:32.528828 IP adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781 >
 github.com.git: . ack 12558 win 348 <nop,nop,timestamp 2770775806
 1433003959>
 22:24:32.532700 IP github.com.git >
 adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781: . 12558:13998(1440) ack
 2892 win 99 <nop,nop,timestamp 1433003959 2770775762>
 22:24:32.532719 IP adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781 >
 github.com.git: . ack 13998 win 370 <nop,nop,timestamp 2770775807
 1433003959>
 22:24:32.536653 IP github.com.git >
 adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781: . 13998:15438(1440) ack
 2892 win 99 <nop,nop,timestamp 1433003959 2770775762>
 22:24:32.536680 IP adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781 >
 github.com.git: . ack 15438 win 393 <nop,nop,timestamp 2770775809
 1433003959>
 22:24:32.542674 IP github.com.git >
 adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781: . 15438:16878(1440) ack
 2892 win 99 <nop,nop,timestamp 1433003959 2770775762>
 22:24:32.542698 IP adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781 >
 github.com.git: . ack 16878 win 416 <nop,nop,timestamp 2770775810
 1433003959>
 22:24:32.546545 IP github.com.git >
 adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781: P 16878:18318(1440) ack
 2892 win 99 <nop,nop,timestamp 1433003960 2770775790>
 22:24:32.546571 IP adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781 >
 github.com.git: . ack 18318 win 438 <nop,nop,timestamp 2770775811
 1433003960>
 22:24:32.550415 IP github.com.git >
 adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781: . 18318:19758(1440) ack
 2892 win 99 <nop,nop,timestamp 1433003960 2770775790>
 22:24:32.550440 IP adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781 >
 github.com.git: . ack 19758 win 461 <nop,nop,timestamp 2770775812
 1433003960>
 22:24:32.562232 IP github.com.git >
 adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781: . 19758:21198(1440) ack
 2892 win 99 <nop,nop,timestamp 1433003968 2770775798>
 22:24:32.562257 IP adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781 >
 github.com.git: . ack 21198 win 483 <nop,nop,timestamp 2770775815
 1433003968>
 22:24:32.566205 IP github.com.git >
 adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781: . 21198:22638(1440) ack
 2892 win 99 <nop,nop,timestamp 1433003968 2770775798>
 22:24:32.566229 IP adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781 >
 github.com.git: . ack 22638 win 501 <nop,nop,timestamp 2770775816
 1433003968>
 22:24:32.576261 IP github.com.git >
 adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781: . 22638:24078(1440) ack
 2892 win 99 <nop,nop,timestamp 1433003972 2770775802>
 22:24:32.579988 IP github.com.git >
 adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781: . 24078:25518(1440) ack
 2892 win 99 <nop,nop,timestamp 1433003972 2770775802>
 22:24:32.580012 IP adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781 >
 github.com.git: . ack 25518 win 501 <nop,nop,timestamp 2770775819
 1433003972>
 22:24:32.593956 IP github.com.git >
 adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781: . 25518:26958(1440) ack
 2892 win 99 <nop,nop,timestamp 1433003976 2770775805>
 22:24:32.597723 IP github.com.git >
 adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781: . 26958:28398(1440) ack
 2892 win 99 <nop,nop,timestamp 1433003976 2770775805>
 22:24:32.597747 IP adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781 >
 github.com.git: . ack 28398 win 501 <nop,nop,timestamp 2770775824
 1433003976>
 22:24:32.601820 IP github.com.git >
 adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781: . 28398:29838(1440) ack
 2892 win 99 <nop,nop,timestamp 1433003978 2770775806>
 22:24:32.605731 IP github.com.git >
 adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781: . 29838:31278(1440) ack
 2892 win 99 <nop,nop,timestamp 1433003978 2770775806>
 22:24:32.605753 IP adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781 >
 github.com.git: . ack 31278 win 501 <nop,nop,timestamp 2770775826
 1433003978>
 22:24:32.611711 IP github.com.git >
 adsl-99-89-149-21.dsl.chcgil.sbcglobal.net.33781: P 31278:32718(1440) ack
 2892 win 99 <nop,nop,timestamp 1433003979 2770775807>
 }}}

 and the same from a cm-bbot-linux-001:
 {{{
 20:17:40.628403 IP cm-bbot-linux-001.sj.mozilla.com.60831 >
 github.com.git: S 3512995651:3512995651(0) win 5840 <mss
 1460,sackOK,timestamp 681688542 0,nop,wscale 6>
 20:17:40.699016 IP github.com.git > cm-bbot-
 linux-001.sj.mozilla.com.60831: S 1747304768:1747304768(0) ack 3512995652
 win 5792 <mss 1460,sackOK,timestamp 3417924511 681688542,nop,w
 scale 7>
 20:17:40.699041 IP cm-bbot-linux-001.sj.mozilla.com.60831 >
 github.com.git: . ack 1 win 92 <nop,nop,timestamp 681688560 3417924511>
 20:17:40.699094 IP cm-bbot-linux-001.sj.mozilla.com.60831 >
 github.com.git: P 1:60(59) ack 1 win 92 <nop,nop,timestamp 681688560
 3417924511>
 20:17:40.770063 IP github.com.git > cm-bbot-
 linux-001.sj.mozilla.com.60831: . ack 60 win 46 <nop,nop,timestamp
 3417924529 681688560>
 20:17:40.781458 IP github.com.git > cm-bbot-
 linux-001.sj.mozilla.com.60831: P 1:156(155) ack 60 win 46
 <nop,nop,timestamp 3417924532 681688560>
 20:17:40.781466 IP github.com.git > cm-bbot-
 linux-001.sj.mozilla.com.60831: P 156:220(64) ack 60 win 46
 <nop,nop,timestamp 3417924532 681688560>
 20:17:40.781488 IP cm-bbot-linux-001.sj.mozilla.com.60831 >
 github.com.git: . ack 156 win 108 <nop,nop,timestamp 681688580 3417924532>
 20:17:40.781495 IP cm-bbot-linux-001.sj.mozilla.com.60831 >
 github.com.git: . ack 220 win 108 <nop,nop,timestamp 681688580 3417924532>
 20:17:40.852168 IP github.com.git > cm-bbot-
 linux-001.sj.mozilla.com.60831: . 220:1668(1448) ack 60 win 46
 <nop,nop,timestamp 3417924550 681688580>
 20:17:40.852176 IP github.com.git > cm-bbot-
 linux-001.sj.mozilla.com.60831: . 1668:3116(1448) ack 60 win 46
 <nop,nop,timestamp 3417924550 681688580>
 20:17:40.852182 IP github.com.git > cm-bbot-
 linux-001.sj.mozilla.com.60831: . 3116:4564(1448) ack 60 win 46
 <nop,nop,timestamp 3417924550 681688580>
 20:17:40.852223 IP cm-bbot-linux-001.sj.mozilla.com.60831 >
 github.com.git: . ack 1668 win 154 <nop,nop,timestamp 681688598
 3417924550>
 20:17:40.852229 IP cm-bbot-linux-001.sj.mozilla.com.60831 >
 github.com.git: . ack 3116 win 199 <nop,nop,timestamp 681688598
 3417924550>
 20:17:40.852236 IP cm-bbot-linux-001.sj.mozilla.com.60831 >
 github.com.git: . ack 4564 win 244 <nop,nop,timestamp 681688598
 3417924550>
 20:17:40.852443 IP github.com.git > cm-bbot-
 linux-001.sj.mozilla.com.60831: . 4564:6012(1448) ack 60 win 46
 <nop,nop,timestamp 3417924550 681688580>
 20:17:40.852480 IP cm-bbot-linux-001.sj.mozilla.com.60831 >
 github.com.git: . ack 6012 win 289 <nop,nop,timestamp 681688598
 3417924550>
 20:17:40.923181 IP github.com.git > cm-bbot-
 linux-001.sj.mozilla.com.60831: P 6012:6852(840) ack 60 win 46
 <nop,nop,timestamp 3417924567 681688598>
 20:17:40.923213 IP cm-bbot-linux-001.sj.mozilla.com.60831 >
 github.com.git: . ack 6852 win 335 <nop,nop,timestamp 681688616
 3417924567>
 20:17:40.923265 IP cm-bbot-linux-001.sj.mozilla.com.60831 >
 github.com.git: P 60:64(4) ack 6852 win 335 <nop,nop,timestamp 681688616
 3417924567>
 20:17:40.927681 IP cm-bbot-linux-001.sj.mozilla.com.60832 >
 github.com.git: S 3825055815:3825055815(0) win 5840 <mss
 1460,sackOK,timestamp 681688617 0,nop,wscale 6>
 20:17:40.998555 IP github.com.git > cm-bbot-
 linux-001.sj.mozilla.com.60832: S 88648109:88648109(0) ack 3825055816 win
 5792 <mss 1460,sackOK,timestamp 1432901076 681688617,nop,wscal
 e 7>
 20:17:40.998573 IP cm-bbot-linux-001.sj.mozilla.com.60832 >
 github.com.git: . ack 1 win 92 <nop,nop,timestamp 681688634 1432901076>
 20:17:40.998625 IP cm-bbot-linux-001.sj.mozilla.com.60832 >
 github.com.git: P 1:60(59) ack 1 win 92 <nop,nop,timestamp 681688634
 1432901076>
 20:17:41.034573 IP github.com.git > cm-bbot-
 linux-001.sj.mozilla.com.60831: . ack 64 win 46 <nop,nop,timestamp
 3417924595 681688616>
 20:17:41.048303 IP github.com.git > cm-bbot-
 linux-001.sj.mozilla.com.60831: F 6852:6852(0) ack 64 win 46
 <nop,nop,timestamp 3417924599 681688616>
 20:17:41.069876 IP github.com.git > cm-bbot-
 linux-001.sj.mozilla.com.60832: . ack 60 win 46 <nop,nop,timestamp
 1432901094 681688634>
 20:17:41.080241 IP github.com.git > cm-bbot-
 linux-001.sj.mozilla.com.60832: P 1:346(345) ack 60 win 46
 <nop,nop,timestamp 1432901096 681688634>
 20:17:41.080248 IP github.com.git > cm-bbot-
 linux-001.sj.mozilla.com.60832: P 346:409(63) ack 60 win 46
 <nop,nop,timestamp 1432901096 681688634>
 20:17:41.080279 IP cm-bbot-linux-001.sj.mozilla.com.60832 >
 github.com.git: . ack 346 win 108 <nop,nop,timestamp 681688655 1432901096>
 20:17:41.080285 IP cm-bbot-linux-001.sj.mozilla.com.60832 >
 github.com.git: . ack 409 win 108 <nop,nop,timestamp 681688655 1432901096>
 20:17:41.086911 IP cm-bbot-linux-001.sj.mozilla.com.60831 >
 github.com.git: . ack 6853 win 335 <nop,nop,timestamp 681688657
 3417924599>
 20:17:41.151464 IP github.com.git > cm-bbot-
 linux-001.sj.mozilla.com.60832: P 409:1857(1448) ack 60 win 46
 <nop,nop,timestamp 1432901114 681688655>
 20:17:41.151471 IP github.com.git > cm-bbot-
 linux-001.sj.mozilla.com.60832: . 1857:3305(1448) ack 60 win 46
 <nop,nop,timestamp 1432901114 681688655>
 20:17:41.151476 IP github.com.git > cm-bbot-
 linux-001.sj.mozilla.com.60832: . 3305:4753(1448) ack 60 win 46
 <nop,nop,timestamp 1432901114 681688655>
 20:17:41.151480 IP github.com.git > cm-bbot-
 linux-001.sj.mozilla.com.60832: . 4753:6201(1448) ack 60 win 46
 <nop,nop,timestamp 1432901114 681688655>
 20:17:41.151515 IP cm-bbot-linux-001.sj.mozilla.com.60832 >
 github.com.git: . ack 1857 win 154 <nop,nop,timestamp 681688673
 1432901114>
 20:17:41.151521 IP cm-bbot-linux-001.sj.mozilla.com.60832 >
 github.com.git: . ack 3305 win 199 <nop,nop,timestamp 681688673
 1432901114>
 20:17:41.151527 IP cm-bbot-linux-001.sj.mozilla.com.60832 >
 github.com.git: . ack 4753 win 244 <nop,nop,timestamp 681688673
 1432901114>
 20:17:41.151533 IP cm-bbot-linux-001.sj.mozilla.com.60832 >
 github.com.git: . ack 6201 win 289 <nop,nop,timestamp 681688673
 1432901114>
 20:17:41.222399 IP github.com.git > cm-bbot-
 linux-001.sj.mozilla.com.60832: P 6201:6852(651) ack 60 win 46
 <nop,nop,timestamp 1432901132 681688673>
 20:17:41.222430 IP cm-bbot-linux-001.sj.mozilla.com.60832 >
 github.com.git: . ack 6852 win 335 <nop,nop,timestamp 681688690
 1432901132>
 20:17:41.236135 IP cm-bbot-linux-001.sj.mozilla.com.60832 >
 github.com.git: P 60:154(94) ack 6852 win 335 <nop,nop,timestamp 681688694
 1432901132>
 20:17:41.261797 IP cm-bbot-linux-001.sj.mozilla.com.60832 >
 github.com.git: . 154:1602(1448) ack 6852 win 335 <nop,nop,timestamp
 681688700 1432901132>
 20:17:41.332633 IP github.com.git > cm-bbot-
 linux-001.sj.mozilla.com.60832: . ack 1602 win 68 <nop,nop,timestamp
 1432901159 681688694>
 20:17:41.332684 IP cm-bbot-linux-001.sj.mozilla.com.60832 >
 github.com.git: P 1602:2871(1269) ack 6852 win 335 <nop,nop,timestamp
 681688718 1432901159>
 20:17:41.333357 IP github.com.git > cm-bbot-
 linux-001.sj.mozilla.com.60832: P 6852:6968(116) ack 1602 win 68
 <nop,nop,timestamp 1432901160 681688694>
 20:17:41.333618 IP github.com.git > cm-bbot-
 linux-001.sj.mozilla.com.60832: P 6968:7258(290) ack 1602 win 68
 <nop,nop,timestamp 1432901160 681688694>
 20:17:41.333626 IP github.com.git > cm-bbot-
 linux-001.sj.mozilla.com.60832: P 7258:7432(174) ack 1602 win 68
 <nop,nop,timestamp 1432901160 681688694>
 20:17:41.333646 IP cm-bbot-linux-001.sj.mozilla.com.60832 >
 github.com.git: . ack 7432 win 425 <nop,nop,timestamp 681688718
 1432901160>
 20:17:41.333872 IP github.com.git > cm-bbot-
 linux-001.sj.mozilla.com.60832: P 7432:7780(348) ack 1602 win 68
 <nop,nop,timestamp 1432901160 681688694>
 20:17:41.333880 IP github.com.git > cm-bbot-
 linux-001.sj.mozilla.com.60832: P 7780:8012(232) ack 1602 win 68
 <nop,nop,timestamp 1432901160 681688694>
 20:17:41.333904 IP cm-bbot-linux-001.sj.mozilla.com.60832 >
 github.com.git: . ack 8012 win 516 <nop,nop,timestamp 681688718
 1432901160>
 20:17:41.405513 IP github.com.git > cm-bbot-
 linux-001.sj.mozilla.com.60832: P 8012:9006(994) ack 2871 win 91
 <nop,nop,timestamp 1432901178 681688718>
 20:17:41.406102 IP github.com.git > cm-bbot-
 linux-001.sj.mozilla.com.60832: P 9006:9577(571) ack 2871 win 91
 <nop,nop,timestamp 1432901178 681688718>
 20:17:41.406119 IP cm-bbot-linux-001.sj.mozilla.com.60832 >
 github.com.git: . ack 9577 win 606 <nop,nop,timestamp 681688736
 1432901178>
 20:17:41.495128 IP github.com.git > cm-bbot-
 linux-001.sj.mozilla.com.60832: P 9577:9612(35) ack 2871 win 91
 <nop,nop,timestamp 1432901200 681688736>
 }}}

 I was worried about the small window sizes advertised by github.com, but
 it's still in slow-start mode because only about 2.5k are ever sent to
 that host.  In both cases, once things get rolling, github.com is sending
 full-MTU segments (1440 on my system, which uses 802.1q VLAN tagging, and
 1448 on the Mozilla system).

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1841#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Feb 28 09:19:04 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 28 Feb 2011 09:19:04 -0000
Subject: [Buildbot-commits] [Buildbot] #496: ShellCommand not working
	with params on Windows
In-Reply-To: <040.054f062bad741fa8cdaa0967bc36cb69@buildbot.net>
References: <040.054f062bad741fa8cdaa0967bc36cb69@buildbot.net>
Message-ID: <055.2781b92a512eddca99e3a3b011cf0c4f@buildbot.net>

#496: ShellCommand not working with params on Windows
--------------------------------+------------------------
Reporter:  ipv6guru             |       Owner:
    Type:  defect               |      Status:  reopened
Priority:  major                |   Milestone:  undecided
 Version:  0.7.10               |  Resolution:
Keywords:  sourceforge 1584002  |
--------------------------------+------------------------
Changes (by dabrahams):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 This is definitely not fixed.  At least, I still can't launch an
 executable with a space in its pathname.  Do you not have a windows
 buildslave testing this?  If you do have a windows buildslave, are you
 testing that specific case?

-- 
Ticket URL: <http://trac.buildbot.net/ticket/496#comment:5>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Feb 28 09:19:28 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 28 Feb 2011 09:19:28 -0000
Subject: [Buildbot-commits] [Buildbot] #496: ShellCommand not working
	with params on Windows
In-Reply-To: <040.054f062bad741fa8cdaa0967bc36cb69@buildbot.net>
References: <040.054f062bad741fa8cdaa0967bc36cb69@buildbot.net>
Message-ID: <055.34ec6700233644c9701d46343e65431e@buildbot.net>

#496: ShellCommand not working with params on Windows
--------------------------------+------------------------
Reporter:  ipv6guru             |       Owner:
    Type:  defect               |      Status:  reopened
Priority:  major                |   Milestone:  undecided
 Version:  0.8.3p1              |  Resolution:
Keywords:  sourceforge 1584002  |
--------------------------------+------------------------
Changes (by dabrahams):

 * version:  0.7.10 => 0.8.3p1


-- 
Ticket URL: <http://trac.buildbot.net/ticket/496#comment:6>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Feb 28 16:08:39 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 28 Feb 2011 16:08:39 -0000
Subject: [Buildbot-commits] [Buildbot] #496: ShellCommand not working
	with params on Windows
In-Reply-To: <040.054f062bad741fa8cdaa0967bc36cb69@buildbot.net>
References: <040.054f062bad741fa8cdaa0967bc36cb69@buildbot.net>
Message-ID: <055.60f668601a4840b5150ca80977b0e17f@buildbot.net>

#496: ShellCommand not working with params on Windows
---------------------+-----------------------
Reporter:  ipv6guru  |       Owner:
    Type:  defect    |      Status:  reopened
Priority:  major     |   Milestone:  0.8.+
 Version:  0.8.3p1   |  Resolution:
Keywords:  windows   |
---------------------+-----------------------
Changes (by dustin):

 * keywords:  sourceforge 1584002 => windows
 * milestone:  undecided => 0.8.+


Comment:

 Nope, this needs a windows maintainer to take a look.  I can't test if I
 don't know how to fix it.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/496#comment:7>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Mon Feb 28 16:20:57 2011
From: noreply at github.com (noreply at github.com)
Date: Mon, 28 Feb 2011 08:20:57 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] ff0d00: include
	github_buildbot.py in docs, differentiate
Message-ID: <20110228162057.C73964224E@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: ff0d00d56dbd95a646dd69b13dc2dd6e5345f0a8
    https://github.com/buildbot/buildbot/commit/ff0d00d56dbd95a646dd69b13dc2dd6e5345f0a8
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2011-02-28 (Mon, 28 Feb 2011)

Changed paths:
  M master/docs/cfg-changesources.texinfo
  M master/docs/cfg-statustargets.texinfo

Log Message:
-----------
include github_buildbot.py in docs, differentiate

This makes the availability of both the github hook and
github_buildbot.py clear, and disambiguates their purposes.
Fixes #1838.





From nobody at buildbot.net  Mon Feb 28 16:21:03 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 28 Feb 2011 16:21:03 -0000
Subject: [Buildbot-commits] [Buildbot] #1838: Document github hooks
	universe
In-Reply-To: <041.9a4e869942f3d84e8c96227870beab4e@buildbot.net>
References: <041.9a4e869942f3d84e8c96227870beab4e@buildbot.net>
Message-ID: <056.4172930d704b3114ed237602a2e34d43@buildbot.net>

#1838: Document github hooks universe
------------------------+------------------------
Reporter:  dabrahams    |       Owner:
    Type:  enhancement  |      Status:  closed
Priority:  major        |   Milestone:  undecided
 Version:  0.8.3p1      |  Resolution:  fixed
Keywords:  docs         |
------------------------+------------------------
Changes (by Dustin J. Mitchell):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 include github_buildbot.py in docs, differentiate

 This makes the availability of both the github hook and
 github_buildbot.py clear, and disambiguates their purposes.
 Fixes #1838.
  Changeset: ff0d00d56dbd95a646dd69b13dc2dd6e5345f0a8

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1838#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Feb 28 17:46:16 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 28 Feb 2011 17:46:16 -0000
Subject: [Buildbot-commits] [Buildbot] #1842: logfiles apparently not
 allowed to be a plain string
Message-ID: <041.a2a477bd8b05c0e52c55b718e52e0c68@buildbot.net>

#1842: logfiles apparently not allowed to be a plain string
----------------------+-----------------------
Reporter:  dabrahams  |      Owner:
    Type:  defect     |     Status:  new
Priority:  major      |  Milestone:  undecided
 Version:  0.8.3p1    |   Keywords:
----------------------+-----------------------
 {{{
 ==> twistd.log <==
        File "/usr/lib/python2.6/site-packages/buildbot/steps/shell.py",
 line 389, in __init__
             ShellCommand.__init__(self, workdir=workdir, **kwargs)
         File "/usr/lib/python2.6/site-packages/buildbot/steps/shell.py",
 line 106, in __init__
             LoggingBuildStep.__init__(self, **buildstep_kwargs)
    File "/usr/lib/python2.6/site-packages/buildbot/process/buildstep.py",
 line 1056, in __init__
      self.logfiles.update(logfiles)
       exceptions.ValueError: dictionary update sequence element #0 has
 length 1; 2 is required
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1842>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Feb 28 17:48:07 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 28 Feb 2011 17:48:07 -0000
Subject: [Buildbot-commits] [Buildbot] #1842: logfiles apparently not
 allowed to be a plain string
In-Reply-To: <041.a2a477bd8b05c0e52c55b718e52e0c68@buildbot.net>
References: <041.a2a477bd8b05c0e52c55b718e52e0c68@buildbot.net>
Message-ID: <056.44f4bf3782721ccc7bb1d9f9ba1fbe20@buildbot.net>

#1842: logfiles apparently not allowed to be a plain string
----------------------+------------------------
Reporter:  dabrahams  |       Owner:
    Type:  defect     |      Status:  new
Priority:  major      |   Milestone:  undecided
 Version:  0.8.3p1    |  Resolution:
Keywords:             |
----------------------+------------------------

Comment (by dustin):

 What was your config?

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1842#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Feb 28 17:48:49 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 28 Feb 2011 17:48:49 -0000
Subject: [Buildbot-commits] [Buildbot] #1842: logfiles apparently not
 allowed to be a plain string
In-Reply-To: <041.a2a477bd8b05c0e52c55b718e52e0c68@buildbot.net>
References: <041.a2a477bd8b05c0e52c55b718e52e0c68@buildbot.net>
Message-ID: <056.4fb5723a6670db123db9d3d7fd06cad6@buildbot.net>

#1842: logfiles apparently not allowed to be a plain string
----------------------------+------------------------
Reporter:  dabrahams        |       Owner:
    Type:  support-request  |      Status:  new
Priority:  major            |   Milestone:  undecided
 Version:  0.8.3p1          |  Resolution:
Keywords:                   |
----------------------------+------------------------
Changes (by dustin):

 * type:  defect => support-request


-- 
Ticket URL: <http://trac.buildbot.net/ticket/1842#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Feb 28 18:40:59 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 28 Feb 2011 18:40:59 -0000
Subject: [Buildbot-commits] [Buildbot] #1843: LibVirtSlave fails to destroy
 domain on buildFinished
Message-ID: <037.d89d89e9b5680b1588413adcb0628a19@buildbot.net>

#1843: LibVirtSlave fails to destroy domain on buildFinished
--------------------+-----------------------
Reporter:  fr4nk    |      Owner:
    Type:  defect   |     Status:  new
Priority:  major    |  Milestone:  undecided
 Version:  0.8.3p1  |   Keywords:
--------------------+-----------------------
 [root at eridu ~]# libvirtd --version
 '''libvirtd (libvirt) 0.8.8'''
 [root at eridu ~]# qemu-kvm --version
 QEMU emulator version 0.14.0 '''(qemu-kvm-0.14.0)''', Copyright (c)
 2003-2008 Fabrice Bellard
 [root at eridu ~]#



 master.cfg snippet:


 {{{
 from buildbot.libvirtbuildslave import LibVirtSlave
 from buildbot.libvirtbuildslave import Connection

 connection = Connection("qemu:///system")

 c['slaves'] = []

 [...]

 slave = LibVirtSlave("arch32", "<password>", connection,
 "/data/vms/snapshots/arch32.tmp", base_image="/data/vms/arch32.img",
 max_builds=1, missing_timeout=30, build_wait_timeout=30)

 c['slaves'].append(slave)

 }}}

 A builder associated with this slave will cause the (qemu-kvm) virtual
 machine to start, from a snapshot overlay disk, just fine. The buildslave
 on the VM starts, connects, the build starts, and finishes, or fails..
 this is not the issue here..

 The problem is that after the build, it doesn't manage to stop/destroy the
 VM, leaving it running. Apart from taking up memory, this also de-syncs
 the states between libvirt and buildbot, so that you can't start the build
 again.

 below is a stacktrace from a manually interrupted build (but the last line
 is the same regardless of how the build terminates:


 {{{
 2011-02-26 16:33:56+0100 [-]  setting expectations for next time
 2011-02-26 16:33:56+0100 [-] new expectations: 367.477597952 seconds
 2011-02-26 16:33:56+0100 [-] Got buildFinished notification - attempting
 to insubstantiate
 2011-02-26 16:33:56+0100 [-] Attempting to stop 'arch32'
 2011-02-26 16:33:56+0100 [-] Unhandled Error
         Traceback (most recent call last):
           File
 "/usr/lib/python2.7/site-packages/buildbot/process/base.py", line 478,
 in allStepsDone
             return self.buildFinished(text, self.result)
           File
 "/usr/lib/python2.7/site-packages/buildbot/process/base.py", line 511,
 in buildFinished
             self.deferred.callback(self)
           File
 "/usr/lib/python2.7/site-packages/twisted/internet/defer.py", line 361,
 in callback
             self._startRunCallbacks(result)
           File
 "/usr/lib/python2.7/site-packages/twisted/internet/defer.py", line 455,
 in _startRunCallbacks
             self._runCallbacks()
         --- <exception caught here> ---
           File
 "/usr/lib/python2.7/site-packages/twisted/internet/defer.py", line 542,
 in _runCallbacks
             current.result = callback(current.result, *args, **kw)
           File
 "/usr/lib/python2.7/site-packages/buildbot/process/base.py", line 225,
 in _release_slave
             self.slavebuilder.buildFinished()
           File
 "/usr/lib/python2.7/site-packages/buildbot/process/builder.py", line
 317, in buildFinished
             self.slave.buildFinished(self)
           File
 "/usr/lib/python2.7/site-packages/buildbot/libvirtbuildslave.py", line
 264, in buildFinished
             self.insubstantiate()
           File
 "/usr/lib/python2.7/site-packages/buildbot/buildslave.py", line 715, in
 insubstantiate
             d = self.stop_instance(fast)
           File
 "/usr/lib/python2.7/site-packages/buildbot/libvirtbuildslave.py", line
 239, in stop_instance
             d = domain.destroy()
         exceptions.AttributeError: 'int' object has no attribute 'destroy'
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1843>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From noreply at github.com  Mon Feb 28 20:12:20 2011
From: noreply at github.com (noreply at github.com)
Date: Mon, 28 Feb 2011 12:12:20 -0800
Subject: [Buildbot-commits] [buildbot/buildbot] 9b2639: fixed repository
	path send for github_buildbot.py
Message-ID: <20110228201220.1C9F7422C6@smtp1.rs.github.com>

Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 9b2639105fc473f4895d4633f327d2eb9a214c5f
    https://github.com/buildbot/buildbot/commit/9b2639105fc473f4895d4633f327d2eb9a214c5f
Author: Dmitry Gladkov <dmitry.gladkov at gmail.com>
Date:   2011-02-28 (Mon, 28 Feb 2011)

Changed paths:
  M master/contrib/github_buildbot.py

Log Message:
-----------
fixed repository path send for github_buildbot.py





From nobody at buildbot.net  Mon Feb 28 20:46:25 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 28 Feb 2011 20:46:25 -0000
Subject: [Buildbot-commits] [Buildbot] #1843: LibVirtSlave fails to
 destroy domain on buildFinished
In-Reply-To: <037.d89d89e9b5680b1588413adcb0628a19@buildbot.net>
References: <037.d89d89e9b5680b1588413adcb0628a19@buildbot.net>
Message-ID: <052.5b1845f5a6e57bf55bab6525223d5539@buildbot.net>

#1843: LibVirtSlave fails to destroy domain on buildFinished
---------------------------+--------------------
Reporter:  fr4nk           |       Owner:
    Type:  defect          |      Status:  new
Priority:  major           |   Milestone:  0.8.+
 Version:  0.8.3p1         |  Resolution:
Keywords:  virtualization  |
---------------------------+--------------------
Changes (by dustin):

 * keywords:   => virtualization
 * milestone:  undecided => 0.8.+


-- 
Ticket URL: <http://trac.buildbot.net/ticket/1843#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Feb 28 22:12:04 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 28 Feb 2011 22:12:04 -0000
Subject: [Buildbot-commits] [Buildbot] #1844: Gift Baskets
Message-ID: <046.eef894c1a312538bd3c1e09fcfaf0ae3@buildbot.net>

#1844: Gift Baskets
---------------------------+--------------------------
Reporter:  giftbaskets654  |      Owner:
    Type:  undecided       |     Status:  new
Priority:  major           |  Milestone:  undecided
 Version:  0.8.3p1         |   Keywords:  gift baskets
---------------------------+--------------------------
 == Gift Baskets - How To Make Gift Baskets To Sell On EBay ==

 [[Image(http://www.bdaygiftidea.com/wp-content/uploads/2008/07/newborn-
 baby-gift-baskets.gif)]]

 You can make the '''[http://www.giftbasketsplus.com/ gift baskets]''' you
 wish to make depends on the occasion where in you are going to give your
 '''giftbaskets''' to your friends, family or to the most especial person
 in your life. Nowadays one of the fastest selling of the '''Gift
 Baskets''' items is through eBay. Where in you can sell your great product
 if you have enough time and budget. This article will give you some tips
 on how to make a gift basket to sell on eBay.

 [[Image(http://www.pricedrightgift-
 baskets.com/images/Easter=Deluxe_Easter=SKU_913704.jpg)]]

 To make a '''[http://www.giftbasketsplus.com/ gift baskets]''' to sell on
 eBay is to prepare the different type of the including the '''fruit
 basket''' and some other kind of the gift basket where in may people where
 purchasing it. All you need is to be more creative in times of decorating
 the gift basket. You have to do '''shopping baskets''' so that you are
 going to make a choose of what sized of basket you are going to use
 including the shape so that you can sell it on eBay.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1844>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Feb 28 22:16:17 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 28 Feb 2011 22:16:17 -0000
Subject: [Buildbot-commits] [Buildbot] #1845: Life Insurance - How To Save
 Money On A Life Insurance Policy
Message-ID: <046.afde98a4847eef8f08482ac5d3a25121@buildbot.net>

#1845: Life Insurance - How To Save Money On A Life Insurance Policy
---------------------------+----------------------------
Reporter:  lifeinsurance0  |      Owner:  jenny cool
    Type:  enhancement     |     Status:  new
Priority:  major           |  Milestone:  1.0.+
 Version:  master          |   Keywords:  life insurance
---------------------------+----------------------------
 [[Image(http://wellplayedinsurance.com/images/pic3.jpg)]]

 In times that a certain individual may need to have things that will be
 best for them in making such ways in life. This
 '''[http://www.lifeinsurance.net.au/ life insurance]''' can make things
 better for those people in making such ways to satisfy their needs in life
 living in this world. With the things that will make those people have
 such ways having a '''Death Insurance''' in a certain period of time. With
 such services that will make a certain individual have the things they may
 need in life living in this world having a '''Living insurance''' today.

 [[Image(http://www.hamptonfamilyinsurance.com/images/headimg.jpg)]]

 People who wanted to make things that will be best for them in making such
 ways that people can have a '''[http://trac.cod3r.com/perian/ticket/554
 life insurance]''' in making things better for them during this days.
 People who wanted to make things that will be best for them in making such
 ways to satisfy their needs having a '''live insurance''' nowadays.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1845>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

From nobody at buildbot.net  Mon Feb 28 22:35:26 2011
From: nobody at buildbot.net (Buildbot)
Date: Mon, 28 Feb 2011 22:35:26 -0000
Subject: [Buildbot-commits] [Buildbot] #1846: Automobile Insurance
Message-ID: <054.46fbe9c3e1425c7893914f006c070ca2@buildbot.net>

#1846: Automobile Insurance
-----------------------------------+----------------------------------
Reporter:  automobileinsurance025  |      Owner:  Jlai Real
    Type:  undecided               |     Status:  new
Priority:  major                   |  Milestone:  undecided
 Version:  0.8.3p1                 |   Keywords:  Automobile Insurance
-----------------------------------+----------------------------------
 == Automobile Insurance - How To Buy Auto Insurance Online ==

 [[Image(http://www.enmodeluxe.com/wordpress/wp-content/uploads/2009/11
 /bugatti-veyron-grand-sport-21-500x375.jpg)]]

 The best place where you can buy something in an instant is the
 Internet.There are lots of companies who would prefer to explore online so
 that they would be able to gain a lot of customers.One of those products
 that could be seen in the Internet are those '''[http://www.automobile-
 insurance.com/ Automobile Insurance]''' policies which has been very
 important to those who wants to have there own car.If you think going to
 an '''auto vehicle insurance''' company is a little expensive due to the
 fares,then you can buy your '''automotive insurance''' online.

 [[Image(http://www.carbonfibergear.com/wp-content/uploads/2009/07/3
 -mansory-vincero-bugatti-veyron.jpg)]]

 To do that, you have to look for registered site that sells
 '''[http://open.silverstripe.org/ticket/6477 Automobile Insurance]'''.Make
 sure that the site is registered so that you would be able to know if the
 '''Automobile Insurance''' plan that you have is reliable and you can get
 your claims.When you are on the site,navigate through it then find an
 application form where you have to fill up to complete your purchase when
 it comes to your '''vehicle insurance''' plan.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1846>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation