[Buildbot-commits] [Buildbot] #2093: try does not understand patches generated by git

Buildbot nobody at buildbot.net
Tue Aug 30 03:58:28 UTC 2011


#2093: try does not understand patches generated by git
----------------------+-----------------------
Reporter:  dank       |      Owner:
    Type:  undecided  |     Status:  new
Priority:  major      |  Milestone:  undecided
 Version:  master     |   Keywords:
----------------------+-----------------------
 Most of the time, you can use patches generated by git
 with "buildbot try --diff=...".  However, when git diffs a
 binary file, it uses a different format, and patch silently
 ignores those hunks, leading to mysterious failed builds.

 Drupal's testbots (not buildbot-based) recently switched to using
 'git apply' instead of 'patch' for just this reason; see
 http://groups.drupal.org/node/141529
 http://drupal.org/node/1107552
 buildbot should probably do the same (at least when faced
 with a git binary patch).

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2093>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation


More information about the Commits mailing list