[Buildbot-commits] [Buildbot] #2091: MailNotifier chokes on try job with non-ascii char in first line of patch?
Buildbot
nobody at buildbot.net
Mon Aug 29 20:10:06 UTC 2011
#2091: MailNotifier chokes on try job with non-ascii char in first line of patch?
-------------------+-----------------------
Reporter: dank | Owner:
Type: defect | Status: new
Priority: major | Milestone: undecided
Version: master | Keywords:
-------------------+-----------------------
I'm turning MailNotifier on, and the very first job it tried to
process happened to be a try job where the first line of the patch
was "From: André..." (with the non-ascii character at offset 10
in the patch). This did not go over well:
File "buildbot/status/builder.py", line 535, in _buildFinished
w.buildFinished(name, s, results)
File "buildbot/status/mail.py", line 411, in buildFinished
return self.buildMessage(name, [build], results)
File "buildbot/status/mail.py", line 596, in buildMessage
results, builds, patches, logs)
File "buildbot/status/mail.py", line 526, in createEmail
a = MIMEText(patch[1].encode(ENCODING), _charset=ENCODING)
exceptions.UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in
position 10: ordinal not in range(128)
Evidently it thinks the patch is ascii, and explodes when trying
to convert it to utf-8.
This is with buildbot from git as of yesterday,
077078052a1fe259d31b081d9df60ff5e15fec01
The try job was submitted with
buildbot try --who nerv at dawncrow.de --properties=comment="78111: Subject:
wineview: Rename view to wineview and install it" --connect=pb
--master=127.0.0.1:5555 --username=blah --passwd=blah --diff=78111.patch
-p
and 78111.patch was fetched from
http://source.winehq.org/patches/data/78111
using the command
wget -O 78111.patch http://source.winehq.org/patches/data/78111
--
Ticket URL: <http://trac.buildbot.net/ticket/2091>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation
More information about the Commits
mailing list