[Buildbot-commits] [Buildbot] #2089: Slave SVN.parseGotRevision() needs to expect a 'P' suffix, too

[Buildbot]

#2089: Slave SVN.parseGotRevision() needs to expect a 'P' suffix, too
--------------------+-----------------------
Reporter:  spencer  |      Owner:
    Type:  defect   |     Status:  new
Priority:  minor    |  Milestone:  undecided
 Version:  0.7.12   |   Keywords:  svn
--------------------+-----------------------
 A quick one-letter fix is needed to support sparse checkouts (achieved via
 a combination of the normal source.SVN step plus custom svn actions
 afterwards) which can result in svnversion printing information such as:

 1234P

 Adding 'P' to the list of characters removed by rstrip() solves this
 problem.

 I'm using an older version so I don't have a patch for the trunk handy,
 but the one letter change goes here AFAICT:

 https://github.com/buildbot/buildbot/blob/master/slave/buildslave/commands/svn.py#L198

 For reference:

 $ svnversion --help
 usage: svnversion [OPTIONS] [WC_PATH [TRAIL_URL]]
 [...]
    4123:4168     mixed revision working copy
    4168M         modified working copy
    4123S         switched working copy
    4123P         partial working copy, from a sparse checkout
    4123:4168MS   mixed revision, modified, switched working copy

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2089>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation