[Buildbot-commits] [Buildbot] #827: ChangeSources may produce changes containing non-ascii bytestrings

[Buildbot]

#827: ChangeSources may produce changes containing non-ascii bytestrings
------------------------------+---------------------
Reporter:  dustin             |       Owner:
    Type:  defect             |      Status:  closed
Priority:  critical           |   Milestone:  0.8.5
 Version:  0.7.12             |  Resolution:  fixed
Keywords:  encoding database  |
------------------------------+---------------------

Comment (by birbilakos):

 Strangely, I've used the latest code from the git and it seems that
 p4poller fails to poll good changes too now:

 {{{
 2011-08-24 10:57:24+0300 [-] added change Change(revision=u'86748',
 who=u'asdfg', branch=u'asdfgh/1.1', comments=u"Change 86748 by
 asdfg at asdfg_gui_ga_11 on 2011/08/24 01:06:03\n\n\tchange description of
 ASD/FGH performance data: remove 'blade' in all their counters\n\t[
 http://asdfghj.asdfghjkla.com/r/9044 - Reviewed By: asdf ] \n\nJobs fixed
 ...\n\nbug38762 by asdfg at asdfghjkla.com *RESOLVED-FIXED*\n\n\tA4200 GUI:
 Most performance counter descriptions should change\n\n", when=1314137163,
 category=None, project=u'', repository=u'') to database
 2011-08-24 10:57:24+0300 [-] P4 poll failed
         Traceback (most recent call last):
           File "/usr/local/lib/python2.6/site-
 packages/twisted/internet/defer.py", line 243, in callback
             self._startRunCallbacks(result)
           File "/usr/local/lib/python2.6/site-
 packages/twisted/internet/defer.py", line 312, in _startRunCallbacks
             self._runCallbacks()
           File "/usr/local/lib/python2.6/site-
 packages/twisted/internet/defer.py", line 328, in _runCallbacks
             self.result = callback(self.result, *args, **kw)
           File "/usr/local/lib/python2.6/site-
 packages/twisted/internet/defer.py", line 630, in gotResult
             _deferGenerator(g, deferred)
         --- <exception caught here> ---
           File "/usr/local/lib/python2.6/site-
 packages/twisted/internet/defer.py", line 605, in _deferGenerator
             result = g.next()
           File "/usr/local/lib/python2.6/site-
 packages/buildbot-0.8.4_pre_1121_g3c95c91-py2.6.egg/buildbot/changes/p4poller.py",
 line 147, in _poll
             result = result.decode(self.encoding)
           File "/usr/local/lib/python2.6/encodings/utf_8.py", line 16, in
 decode
             return codecs.utf_8_decode(input, errors, True)
         exceptions.UnicodeDecodeError: 'utf8' codec can't decode byte 0x92
 in position 327: unexpected code byte
 }}}

 The changelist though seems good though:

 {{{
 p4 change -o 86748
 Change: 86748

 Date:   2011/08/24 01:06:03

 Client: asdfg_gui_ga_11

 User:   asdfg

 Status: submitted

 Description:
         change description of ASD/FGH performance data: remove 'blade' in
 all their counters
         [ http://asdfghj.asdfghjkla.com/r/9044 - Reviewed By: asdf ]

 Jobs:
         bug38762        # A4200 GUI: Most performance cou
 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/827#comment:24>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation