[Buildbot-commits] [buildbot/buildbot] 391d54: status.web.authz.Authz now has actionAllowed retur...

noreply at github.com noreply at github.com
Wed Aug 24 01:02:35 UTC 2011


  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 391d54c59e1c3f81a35ed208a5fd6c2419442d21
      https://github.com/buildbot/buildbot/commit/391d54c59e1c3f81a35ed208a5fd6c2419442d21
  Author: Derek Hurley <dzhurley at gmail.com>
  Date:   2011-08-22 (Mon, 22 Aug 2011)

  Changed paths:
    M master/buildbot/status/web/authz.py
  M master/buildbot/test/unit/test_status_web_authz_Authz.py

  Log Message:
  -----------
  status.web.authz.Authz now has actionAllowed return a deferred

This is verified by test_status_web_authz_Authz and needed to
happen for possible deferreds in authenticate methods.


  Commit: 1df06e9b3b9af28ba83b59d028fd0c68f6add284
      https://github.com/buildbot/buildbot/commit/1df06e9b3b9af28ba83b59d028fd0c68f6add284
  Author: Derek Hurley <dzhurley at gmail.com>
  Date:   2011-08-22 (Mon, 22 Aug 2011)

  Changed paths:
    M master/buildbot/status/web/slaves.py

  Log Message:
  -----------
  allowedAction now works with deferred in status.web.slaves

This means 'gracefulShutdown' auth is handled in deferreds,
with redirects taken care of in an ActionResource subclass.


  Commit: ca4a722540e135eec0a50a646f10a8323aff373f
      https://github.com/buildbot/buildbot/commit/ca4a722540e135eec0a50a646f10a8323aff373f
  Author: Derek Hurley <dzhurley at gmail.com>
  Date:   2011-08-22 (Mon, 22 Aug 2011)

  Changed paths:
    M master/buildbot/status/web/build.py

  Log Message:
  -----------
  moved stop/rebuild logic in status.web.build into ActionResource subclasses

This gets rid of some dependencies and makes 'forceBuild'
and 'stopBuild' auth work with the deferred actionAllowed.


  Commit: 52e87f6dcb2d4e31b999a51084f37e4bf4b348a6
      https://github.com/buildbot/buildbot/commit/52e87f6dcb2d4e31b999a51084f37e4bf4b348a6
  Author: Derek Hurley <dzhurley at gmail.com>
  Date:   2011-08-22 (Mon, 22 Aug 2011)

  Changed paths:
    M master/buildbot/status/web/build.py
  M master/buildbot/status/web/builder.py

  Log Message:
  -----------
  status.web.builder now does all actionAllowed via deferred

This prompted new ActionResource subclasses for 'forceAllBuilds',
'stopAllBuilds', 'pingBuilder', and 'forceBuild'. This also
showed that performAction() wasn't getting called if force/stop
was called with auth_ok = True, so code had to be left in the
original methods.


  Commit: 3df4cd938a8708a7223a09c8b36b329cf2042a9a
      https://github.com/buildbot/buildbot/commit/3df4cd938a8708a7223a09c8b36b329cf2042a9a
  Author: Derek Hurley <dzhurley at gmail.com>
  Date:   2011-08-22 (Mon, 22 Aug 2011)

  Changed paths:
    M master/buildbot/status/web/root.py

  Log Message:
  -----------
  status.web.root now uses deferred actionAllowed

This means 'cleanShutDown' is checked in a deferred
for /shutdown and /cancel_shutdown requests.


  Commit: 1ec6878ce17bf6575f497cf6ddc19a9a6e9fdfb0
      https://github.com/buildbot/buildbot/commit/1ec6878ce17bf6575f497cf6ddc19a9a6e9fdfb0
  Author: Derek Hurley <dzhurley at gmail.com>
  Date:   2011-08-23 (Tue, 23 Aug 2011)

  Changed paths:
    M master/docs/manual/developer.rst

  Log Message:
  -----------
  updated dev docs for actionAllowed changes


  Commit: 7db9dc011768558b3f00cce7eda7b07d2b8267be
      https://github.com/buildbot/buildbot/commit/7db9dc011768558b3f00cce7eda7b07d2b8267be
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-08-23 (Tue, 23 Aug 2011)

  Changed paths:
    M master/buildbot/status/web/authz.py
  M master/buildbot/status/web/build.py
  M master/buildbot/status/web/builder.py
  M master/buildbot/status/web/root.py
  M master/buildbot/status/web/slaves.py
  M master/buildbot/test/unit/test_status_web_authz_Authz.py
  M master/docs/manual/developer.rst

  Log Message:
  -----------
  Merge branch 'async_authenticate_calltree' of git://github.com/dzhurley/buildbot

* 'async_authenticate_calltree' of git://github.com/dzhurley/buildbot:
  updated dev docs for actionAllowed changes
  status.web.root now uses deferred actionAllowed
  status.web.builder now does all actionAllowed via deferred
  moved stop/rebuild logic in status.web.build into ActionResource subclasses
  allowedAction now works with deferred in status.web.slaves
  status.web.authz.Authz now has actionAllowed return a deferred


Compare: https://github.com/buildbot/buildbot/compare/a897508...7db9dc0




More information about the Commits mailing list