[Buildbot-commits] [Buildbot] #1937: Exceptions in Logfile.merge (called from LogFile.addEntry) aren't handled, causing the step to fail, without finishing the build

[Buildbot]

#1937: Exceptions in Logfile.merge (called from LogFile.addEntry) aren't handled,
causing the step to fail, without finishing the build
-----------------------+-------------------------
Reporter:  tom.prince  |       Owner:
    Type:  defect      |      Status:  closed
Priority:  major       |   Milestone:  0.8.5
 Version:  0.8.3p1     |  Resolution:  worksforme
Keywords:              |
-----------------------+-------------------------
Changes (by dustin):

 * status:  new => closed
 * resolution:   => worksforme


Comment:

 This failure was actually handled correctly, and ironically was able to
 write the error message to disk.  The traceback you show produced a
 Failure, which was duly returned from !RemoteShellCommand's deferred,
 which startCommand handles with {{{self.failed}}}, which adds err.html and
 err.txt to the buildstep.  A failure to add these files is correctly
 handled ("exception during failure processing" in the twistd.log), but
 that didn't occur in this case.

 I suspect the failure was due to some other out-of-disk related failure --
 perhaps the relevant database commit failed?

 I can confirm by manually adding an exception to what is now {{{_merge}}}
 that this is handled correctly.  Perhaps the cleanup I did there as part
 of adding tests fixed something!

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1937#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation