[Buildbot-commits] [Buildbot] #1927: buildbot: commit notification crashes with Unicode characters in git commit logs

[Buildbot]

#1927: buildbot: commit notification crashes with Unicode characters in git commit
logs
-----------------------+------------------------
Reporter:  edwintorok  |       Owner:
    Type:  defect      |      Status:  new
Priority:  major       |   Milestone:  undecided
 Version:  0.8.3p1     |  Resolution:
Keywords:              |
-----------------------+------------------------

Comment (by edwintorok):

 Replying to [comment:2 dustin]:
 > Thanks!
 >
 > This looks like a good patch for your situation, but in general I think
 that it would be better for the various uses of sendchange to get the
 encoding right on the client side.  Then if you have different invocations
 of sendchange feeding to the same master (a not uncommon arrangement),
 those can decode from different encodings.
 >
 > That would mean a similar patch to
 source:buildbot/master/buildbot/clients/sendchange.py, along with an
 optional constructor argument for {{{Sender}}} to specify the encoding
 (defaulting to utf8).

 Makes sense.

 >
 > Do you want to try that out?

 Judging by the time it took for me to even reply to this, no. Got too much
 other work to do right now :(

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1927#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation