[Buildbot-commits] [Buildbot] #1932: property value can't have space if submitted from "Force build" or "Resubmit build" form
Buildbot
nobody at buildbot.net
Tue Apr 19 23:07:29 UTC 2011
#1932: property value can't have space if submitted from "Force build" or
"Resubmit build" form
------------------------+-----------------
Reporter: liucougar | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Version: 0.8.3p1 | Keywords:
------------------------+-----------------
in file buildbot/status/web/base.py :
{{{
#!python
def getAndCheckProperties(req):
...
if not re.match(r'^[\w\.\-\/\~:]*$', pname) \
or not re.match(r'^[\w\.\-\/\~:]*$', pvalue):
log.msg("bad property name='%s', value='%s'" % (pname,
pvalue))
return None
}}}
and particular reason to not allow anything in pvalue? (I can understand
pname should probably be a valid python identifier, but why put the same
limitation on pvalue?
--
Ticket URL: <http://trac.buildbot.net/ticket/1932>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation
More information about the Commits
mailing list