[Buildbot-commits] [Buildbot] #1927: buildbot: commit notification crashes with Unicode characters in git commit logs

[Buildbot]

#1927: buildbot: commit notification crashes with Unicode characters in git commit
logs
-----------------------+-----------------------
Reporter:  edwintorok  |      Owner:
    Type:  defect      |     Status:  new
Priority:  major       |  Milestone:  undecided
 Version:  0.8.3p1     |   Keywords:
-----------------------+-----------------------
 We were using buildbot from the 0.7.x series before.
 After upgrading to latest 0.8.3p1 the git commits made by me are no longer
 seen by the buildbot.
 Turns out it hates the Unicode characters in my name:

  File ".../botbin/lib/python/buildbot/changes/manager.py", line 82, in
 addChange

            change.comments, change.category, change.project))

        exceptions.UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3
 in position 20: ordinal not in range(128)

 Looks like there is something in manager.py to encode strings as utf8, but
 it is too late: it is on the line just after the crash (line 83).

 Sample git commit log that crashes commit notifier (and misses commits):
 commit ad3fad0c97522e34a99b52fe3754586b9e22ebaf
 Author: Török Edvin <edwin at clamav.net>
 Date:   Thu Apr 14 17:08:57 2011 +0300

     build system: add missing files

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1927>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation