[Buildbot-commits] [Buildbot] #1922: git does not retry if the fetch fails

[Buildbot]

#1922: git does not retry if the fetch fails
--------------------+---------------------
Reporter:  dustin   |       Owner:
    Type:  defect   |      Status:  closed
Priority:  major    |   Milestone:  0.8.4
 Version:  0.8.3p1  |  Resolution:  fixed
Keywords:  git      |
--------------------+---------------------
Changes (by dustin):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Well, the slaves are running 0.8.1, which has the retry behavior.  The
 Twisted version is 10.1.0.  I added

 {{{
 #!diff
 diff --git a/slave/buildslave/commands/vcs.py
 b/slave/buildslave/commands/vcs.py
 index b0e8f7f..7dd33d5 100644
 --- a/slave/buildslave/commands/vcs.py
 +++ b/slave/buildslave/commands/vcs.py
 @@ -1019,7 +1019,7 @@ class Git(SourceBase):
          command = ['fetch', '-t', self.repourl, '+%s' % self.branch]
          self.sendStatus({"header": "fetching branch %s from %s\n"
                                          % (self.branch, self.repourl)})
 -        return self._dovccmd(command, self._didFetch)
 +        return self._dovccmd(['false']+command, self._didFetch)

      def _didClean(self, dummy):
          # After a clean, try to use the given revision if we have one.
 }}}

 locally to try to replicate the problem (on Linux), and I see this being
 retried.  Making the same change on the slave did not retry.

 I upgraded the cm-bbot-xp-NNN slaves to buildbot-slave-0.8.3, and all
 seems well.  So I'm calling this fixed for now.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1922#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation