[Buildbot-commits] [Buildbot] #1699: Add support for wild-card matching for logfiles parameter in build steps

[Buildbot]

#1699: Add support for wild-card matching for logfiles parameter in build steps
------------------------+--------------------
Reporter:  lantictac    |       Owner:
    Type:  enhancement  |      Status:  new
Priority:  minor        |   Milestone:  1.0.+
 Version:  0.8.2        |  Resolution:
Keywords:               |
------------------------+--------------------

Comment (by dustin):

 I, too, think this would be well-received.  A few concerns:

  * you say it works most of the time - what is the failure condition?
  * I'm worried about using ';' as a separator (as it might appear in
 existing filenames), and also about assuming any filename with '*' is a
 glob.  The latter is both too conservative (doesn't notice '?') and too
 liberal (precludes filenames containing '*')

 I'd rather see a master-side configuration that explicitly asks for
 globbing, and explicit support for it in the master/slave protocol
 (including using a tuple to avoid trying to encode two filenames in one
 with an unquoted separator).  There is a facility in place already that
 can be used to determine whether slaves support a certain feature, so it's
 a simple matter for the master to error out if the user requests globbing
 but the slave does not support it.

 Do you think you could put together a patch against master that addresses
 these concerns?

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1699#comment:4>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation