[Buildbot-commits] [Buildbot] #990: on windows, Git step uses reset and doesn't notice the failure

[Buildbot]

#990: on windows, Git step uses reset and doesn't notice the failure
-------------------+--------------------------------------------------------
Reporter:  dustin  |       Owner:             
    Type:  defect  |      Status:  new        
Priority:  major   |   Milestone:  0.8.2      
 Version:  0.8.1   |    Keywords:  windows git
-------------------+--------------------------------------------------------
 {{{
 starting git operation
 C:\Program Files\Git\cmd\git.CMD reset --hard
 bbc39370c04cb46caa21fbdf01ade748b11f60b8
  in dir C:\slave\slave-cm-bbot-xp-001\source (timeout 1200 secs)
  watching logfiles {}
  argv: ['C:\\Program Files\\Git\\cmd\\git.CMD', 'reset', '--hard',
 u'bbc39370c04cb46caa21fbdf01ade748b11f60b8']
  environment:
   ALLUSERSPROFILE=C:\Documents and Settings\All Users
   APPDATA=C:\Documents and Settings\buildbot\Application Data
   BB_BUILDSLAVE="c:\mozilla-build\python\Scripts\buildslave"
   BB_PYTHON="c:\mozilla-build\python\Scripts\..\python"
   CLIENTNAME=aglon
   COMMONPROGRAMFILES=C:\Program Files\Common Files
   COMPUTERNAME=CM-BBOT-XP-001
   COMSPEC=C:\WINDOWS\system32\cmd.exe
   FP_NO_HOST_CHECK=NO
   HOMEDRIVE=C:
   HOMEPATH=\Documents and Settings\buildbot
   LOGONSERVER=\\CM-BBOT-XP-001
   NUMBER_OF_PROCESSORS=2
   OS=Windows_NT
   PATH=C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;c:\Program
 Files\gnuwin32\bin;c:\mozilla-build\Python\;c:\mozilla-
 build\Python\scripts;C:\Program Files\Git\cmd
   PATHEXT=.COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH
   PROCESSOR_ARCHITECTURE=x86
   PROCESSOR_IDENTIFIER=x86 Family 6 Model 14 Stepping 8, GenuineIntel
   PROCESSOR_LEVEL=6
   PROCESSOR_REVISION=0e08
   PROGRAMFILES=C:\Program Files
   PROMPT=$P$G
   PWD=C:\slave\slave-cm-bbot-xp-001\source
   SESSIONNAME=RDP-Tcp#1
   SYSTEMDRIVE=C:
   SYSTEMROOT=C:\WINDOWS
   TEMP=C:\DOCUME~1\buildbot\LOCALS~1\Temp
   TMP=C:\DOCUME~1\buildbot\LOCALS~1\Temp
   USERDOMAIN=CM-BBOT-XP-001
   USERNAME=buildbot
   USERPROFILE=C:\Documents and Settings\buildbot
   WINDIR=C:\WINDOWS
  closing stdin
  using PTY: False
 fatal: Could not parse object 'bbc39370c04cb46caa21fbdf01ade748b11f60b8'.
 elapsedTime=0.218000
 C:\Program Files\Git\cmd\git.CMD rev-parse HEAD
  in dir C:\slave\slave-cm-bbot-xp-001\source (timeout 1200 secs)
  watching logfiles {}
  argv: ['C:\\Program Files\\Git\\cmd\\git.CMD', 'rev-parse', 'HEAD']
  environment:
   ALLUSERSPROFILE=C:\Documents and Settings\All Users
   APPDATA=C:\Documents and Settings\buildbot\Application Data
   BB_BUILDSLAVE="c:\mozilla-build\python\Scripts\buildslave"
   BB_PYTHON="c:\mozilla-build\python\Scripts\..\python"
   CLIENTNAME=aglon
   COMMONPROGRAMFILES=C:\Program Files\Common Files
   COMPUTERNAME=CM-BBOT-XP-001
   COMSPEC=C:\WINDOWS\system32\cmd.exe
   FP_NO_HOST_CHECK=NO
   HOMEDRIVE=C:
   HOMEPATH=\Documents and Settings\buildbot
   LOGONSERVER=\\CM-BBOT-XP-001
   NUMBER_OF_PROCESSORS=2
   OS=Windows_NT
   PATH=C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;c:\Program
 Files\gnuwin32\bin;c:\mozilla-build\Python\;c:\mozilla-
 build\Python\scripts;C:\Program Files\Git\cmd
   PATHEXT=.COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH
   PROCESSOR_ARCHITECTURE=x86
   PROCESSOR_IDENTIFIER=x86 Family 6 Model 14 Stepping 8, GenuineIntel
   PROCESSOR_LEVEL=6
   PROCESSOR_REVISION=0e08
   PROGRAMFILES=C:\Program Files
   PROMPT=$P$G
   PWD=C:\slave\slave-cm-bbot-xp-001\source
   SESSIONNAME=RDP-Tcp#1
   SYSTEMDRIVE=C:
   SYSTEMROOT=C:\WINDOWS
   TEMP=C:\DOCUME~1\buildbot\LOCALS~1\Temp
   TMP=C:\DOCUME~1\buildbot\LOCALS~1\Temp
   USERDOMAIN=CM-BBOT-XP-001
   USERNAME=buildbot
   USERPROFILE=C:\Documents and Settings\buildbot
   WINDIR=C:\WINDOWS
  closing stdin
  using PTY: False
 3c2b3b91f801a29bfd0ed568441e532dd41583b2
 elapsedTime=0.141000
 Since we're on a non-POSIX platform, we're not going to try to execute cp
 in a subprocess, but instead use shutil.copytree(), which will block until
 it is complete.  fromdir: C:\slave\slave-cm-bbot-xp-001\source, todir:
 C:\slave\slave-cm-bbot-xp-001\build
 program finished with exit code 0
 }}}

 To summarize: git.CMD ran and printed an error, but somehow Buildbot did
 not notice, and assumed that it worked correctly (otherwise it would have
 invoked git fetch)

-- 
Ticket URL: <http://buildbot.net/trac/ticket/990>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation