[Buildbot-commits] [Buildbot] #989: upgrade-master skips database creation.

[Buildbot]

#989: upgrade-master skips database creation.
-------------------+--------------------------------------------------------
Reporter:  verm    |       Owner:          
    Type:  defect  |      Status:  new     
Priority:  major   |   Milestone:  0.8.2   
 Version:  0.8.1   |    Keywords:  database
-------------------+--------------------------------------------------------
 Under certain conditions `upgrade-master` will skip creating the initial
 database.

 Here is what I did to hit this:

  1. `buildbot create-master ./buildmaster`
  2. Replace master.cfg with new config file.
  3. Update `c['db']` with proper mysql connector string.
  4. Start buildbot
  5. Receive error about requiring `upgrade-master`
  6. Run `upgrade-master`, this passes w/out error.
  7. Re-start buildbot which produces the same error as in !#5
  8. Observe that mysql database is infact empty with no tables.

 In order to get this working, I had to run `buildbot create-master
 --db='[connector string]'`  This gave me a working database to start from.

 The `upgrade-master` tool needs to detect this condition and suggest
 starting from scratch.  At the very least it should confirm that the
 required tables have been created w/out errors and produce a suitable
 error message in case of failure.

-- 
Ticket URL: <http://buildbot.net/trac/ticket/989>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation