[Buildbot-commits] [Buildbot] #1032: use getProcessOutput in gitpoller

[Buildbot]

#1032: use getProcessOutput in gitpoller
------------------------+---------------------------------------------------
Reporter:  dustin       |       Owner:       
    Type:  enhancement  |      Status:  new  
Priority:  major        |   Milestone:  0.8.3
 Version:  0.8.2        |    Keywords:  git  
------------------------+---------------------------------------------------

Comment(by matisse):

 Specifically it is _get_git_output (only)  that uses subprocess. There are
 5 places where _get_git_output is used:

 {{{
 _get_commit_comments(self, rev)
 _get_commit_timestamp(self, rev)
 _get_commit_files(self, rev)
 _get_commit_name(self, rev)
 _process_changes(self, res)
 }}}

 I am new to the deferred pattern, and even newer to getProcessOutput so I
 could be mistaken, but, I think that what needs to be done is that
 _get_git_output would change to return a Deferred (via getProcessOutput)
 and then each caller of _get_git_output would add it's own callback to
 make use of the the output obtained from git.

 Might this mean that for every current caller of _get_git_output we factor
 out most of their code into new methods which are the callbacks that get
 added to the Deferred returned by _get_git_output?

 It's plausible that I could do the work for this if I get some direction
 on the right way to go about it.

-- 
Ticket URL: <http://buildbot.net/trac/ticket/1032#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation