[Buildbot-commits] [Buildbot] #1684: Buildbot doesn't detect a broken configuration file

[Buildbot]

#1684: Buildbot doesn't detect a broken configuration file
------------------------+---------------------------------------------------
Reporter:  kostja       |       Owner:       
    Type:  enhancement  |      Status:  new  
Priority:  major        |   Milestone:  0.8.3
 Version:  0.8.2        |    Keywords:       
------------------------+---------------------------------------------------
Changes (by dustin):

  * type:  undecided => enhancement
  * milestone:  undecided => 0.8.3


Old description:

> If there are two c['status'].append(html.WebStatus(...)) lines in the
> configuration file, like below:
>
> from buildbot.status import html
> c['status'].append(html.WebStatus(http_port=8010,allowForce=True))
>
> which are very easy to add by mistake, by just uncommenting allowForce
> line in the sample config, buildbot checkconfig completes successfully,
> and buildbot successfully starts, but is unable to see any of its slaves.
>
> An error is produced into the log, but the message is quite cryptic:
>
>         twisted.internet.error.CannotListenError: Couldn't listen on
> any:8010: [Errno 98] Address already in use.

New description:

 If there are two
 {{{
 c['status'].append(html.WebStatus(...))
 }}}
 lines in the configuration file, like below:

 {{{
 from buildbot.status import html
 c['status'].append(html.WebStatus(http_port=8010,allowForce=True))
 }}}

 which are very easy to add by mistake, by just uncommenting allowForce
 line in the sample config, buildbot checkconfig completes successfully,
 and buildbot successfully starts, but is unable to see any of its slaves.

 An error is produced into the log, but the message is quite cryptic:

 {{{
         twisted.internet.error.CannotListenError: Couldn't listen on
 any:8010: [Errno 98] Address already in use.
 }}}

--

Comment:

 This should have some kind of check in the early parts of the
 {{{loadConfig}}} process.

-- 
Ticket URL: <http://buildbot.net/trac/ticket/1684#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation