[Buildbot-commits] [Buildbot] #1065: Builds scheduled with unimportant changes have the last unimportant change's revision used in the sourcestamp

[Buildbot]

#1065: Builds scheduled with unimportant changes have the last unimportant
change's revision used in the sourcestamp
-------------------+--------------------------------------------------------
Reporter:  catlee  |       Owner:           
    Type:  defect  |      Status:  new      
Priority:  major   |   Milestone:  undecided
 Version:  0.8.2   |    Keywords:           
-------------------+--------------------------------------------------------
 Scenario:

 User Bob pushes revision A, which is determined by the scheduler to be
 unimportant (e.g. by adding DONTBUILD to the comments) User Charlie pushes
 revision B, which is important.  The scheduler triggers builds at the
 appropriate time.

 The build's sourcestamp has two changes, A and B.  But the sourcestamp's
 revision is A (the unimportant one), however it's actually checking out B
 (the important one).

 Expected behaviour would be to have B as the sourcestamp's revision, since
 it's the more recent of the two.

 Easiest fix I can think of right now is to change that line in the
 scheduler to say all_changes = unimportant + important...or sort
 all_changes by change.number.

-- 
Ticket URL: <http://buildbot.net/trac/ticket/1065>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation