[Buildbot-commits] [Buildbot] #1058: FileUpload step crashes if file already exists at server (Windows)

[Buildbot]

#1058: FileUpload step crashes if file already exists at server (Windows)
--------------------+-------------------------------------------------------
Reporter:  parshin  |       Owner:           
    Type:  defect   |      Status:  new      
Priority:  major    |   Milestone:  undecided
 Version:  0.8.2    |    Keywords:  windows  
--------------------+-------------------------------------------------------
 If build uploads file to server and the file already exists on server,
 step crashes with !WindowsError:
 {{{
 Traceback (most recent call last):
           File "c:\Python26\lib\site-packages\twisted\spread\banana.py",
 line 153, in gotItem
             self.callExpressionReceived(item)
           File "c:\Python26\lib\site-packages\twisted\spread\banana.py",
 line 116, in callExpressionReceived
             self.expressionReceived(obj)
           File "c:\Python26\lib\site-packages\twisted\spread\pb.py", line
 514, in expressionReceived
             method(*sexp[1:])
           File "c:\Python26\lib\site-packages\twisted\spread\pb.py", line
 826, in proto_message
             self._recvMessage(self.localObjectForID, requestID, objectID,
 message, answerRequired, netArgs, netKw)
         --- <exception caught here> ---
           File "c:\Python26\lib\site-packages\twisted\spread\pb.py", line
 840, in _recvMessage
             netResult = object.remoteMessageReceived(self, message,
 netArgs, netKw)
           File "c:\Python26\lib\site-packages\twisted\spread\flavors.py",
 line 114, in remoteMessageReceived
             state = method(*args, **kw)
           File "c:\Python26\lib\site-packages\buildbot\steps\transfer.py",
 line 58, in remote_close
             os.rename(self.tmpname, self.destfile)
         exceptions.WindowsError: [Error 183] Cannot create a file when
 that file already exists
 }}}

 Maybe, file on server should be deleted before rename (or when step
 starts?)...

-- 
Ticket URL: <http://buildbot.net/trac/ticket/1058>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation